Re: [PATCH net-next 10/12] net: hns3: don't allow user to change vlan filter state

2019-02-02 Thread Sergei Shtylyov
Hello! On 02.02.2019 17:39, Huazhong Tan wrote: From: Jian Shen When user disables vlan filter, and adds vlan device, it won't notify the driver the update the vlan filter. In this case, when To update, perhaps? user enables vlan filter again, the packets with new vlan tag will be filt

[PATCH] net: fix IPv6 prefix route residue

2019-02-02 Thread Zhiqiang Liu
From: Zhiqiang Liu Follow those steps: # ip addr add 2001:123::1/32 dev eth0 # ip addr add 2001:123:456::2/64 dev eth0 # ip addr del 2001:123::1/32 dev eth0 # ip addr del 2001:123:456::2/64 dev eth0 and then prefix route of 2001:123::1/32 will still exist. This is because ipv6_prefix_equal i

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread 戈润栋
Hi Andrew Sorry for the previous mails due to my error mail format setting on browser. I have reproduced the tcpdump issue in my env, but not sure if it is the same issue as you mentioned. Ifdown a slave interface which is under tcpdump capturing will also decrease the master's promiscuous twice.

Re: [PATCH net-next] bonding: check slave set command firstly

2019-02-02 Thread Tonghao Zhang
ing-check-slave-set-command-firstly/20190202-215305 > config: xtensa-allyesconfig (attached as .config) > compiler: xtensa-linux-gcc (GCC) 8.2.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross >

Re: [PATCH] bna: fix indentation issue on call to bfa_ioc_pf_failed

2019-02-02 Thread David Miller
From: Colin King Date: Sat, 2 Feb 2019 11:37:07 + > From: Colin Ian King > > The call to bfa_ioc_pf_failed is indented too far, fix this by > removing a tab. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] chelsio: clean up indentation issue

2019-02-02 Thread David Miller
From: Colin King Date: Sat, 2 Feb 2019 11:33:51 + > From: Colin Ian King > > The assignment to size is indented too far, fix this and join > two lines into one. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] atl1c: fix indentation issue on an if statement

2019-02-02 Thread David Miller
From: Colin King Date: Sat, 2 Feb 2019 11:41:29 + > From: Colin Ian King > > An if statement is indented one level too deep, fix this by removing > the extra tabs. Also add some spaces to the dev_warn arguments to clean > up checkpatch warnings. > > Signed-off-by: Colin Ian King Applied

Re: [PATCH] atheros: atl2: fix an indentaion issue on a return statement

2019-02-02 Thread David Miller
From: Colin King Date: Sat, 2 Feb 2019 11:45:26 + > From: Colin Ian King > > A return statment is not indented correctly, fix this by adding an > extra tab. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH v2 net-next 1/2] net: nixge: Separate ctrl and dma resources

2019-02-02 Thread David Miller
From: alex.willi...@ettus.com Date: Thu, 31 Jan 2019 13:33:27 -0800 > From: Alex Williams > > The DMA engine is a separate entity altogether, and this allows the DMA > controller's address to float elsewhere in the FPGA's map. > > Signed-off-by: Alex Williams Applied.

Re: [PATCH v2 net-next 2/2] net: nixge: Update device-tree bindings with v3.00

2019-02-02 Thread David Miller
From: alex.willi...@ettus.com Date: Thu, 31 Jan 2019 13:33:28 -0800 > From: Alex Williams > > Now the DMA engine is free to float elsewhere in the system map. > > Signed-off-by: Alex Williams Applied.

[PATCH] netdevice.h: Add __cold to netdev_ logging functions

2019-02-02 Thread Joe Perches
Add __cold to the netdev_ logging functions similar to the use of __cold in the generic printk function. Using __cold moves all the netdev_ logging functions out-of-line possibly improving code locality and runtime performance. Signed-off-by: Joe Perches --- include/linux/netdevice.h | 16 +

Re: [PATCH net-next] r8169: remove rtl_wol_pll_power_down

2019-02-02 Thread David Miller
From: Heiner Kallweit Date: Thu, 31 Jan 2019 22:03:48 +0100 > rtl_wol_pll_power_down() is used in only one place and removing it > makes the code simpler and better readable. > > Signed-off-by: Heiner Kallweit Applied, thanks Heiner.

Re: [PATCH v2] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x"

2019-02-02 Thread David Miller
From: Russell King Date: Thu, 31 Jan 2019 16:59:46 + > This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0. > > The original diagnosis was incorrect: it appears that the NIC had > PHY polling mode enabled, which meant that it overwrote the PHYs > advertisement register during negoti

Re: [PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-02 Thread David Miller
From: Callum Sinclair Date: Thu, 31 Jan 2019 09:52:09 +1300 > > -/* Close the multicast socket, and clear the vif tables etc */ > -static void mroute_clean_tables(struct mr_table *mrt, bool all) > +/* Clear the vif tables */ > +static void mroute_clean_cache(struct mr_table *mrt, bool all) > {

Re: [PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-02 Thread Deepa Dinamani
On Sat, Feb 2, 2019 at 9:15 AM Oliver Hartkopp wrote: > > Hi all, > > On 02.02.19 16:34, Deepa Dinamani wrote: > > Add new socket timeout options that are y2038 safe. > (..) > > > > diff --git a/arch/alpha/include/uapi/asm/socket.h > > b/arch/alpha/include/uapi/asm/socket.h > > index 9826d1db71d0

[PATCH] Bluetooth: Fix decrementing reference count twice in releasing socket

2019-02-02 Thread Myungho Jung
When releasing socket, it is possible to enter hci_sock_release() and hci_sock_dev_event(HCI_DEV_UNREG) at the same time in different thread. The reference count of hdev should be decremented only once from one of them but if storing hdev to local variable in hci_sock_release() before detached from

Re: [RFC 00/14] netlink/hierarchical stats

2019-02-02 Thread Roopa Prabhu
On Thu, Jan 31, 2019 at 11:31 AM Jakub Kicinski wrote: > > On Thu, 31 Jan 2019 08:31:51 -0800, Roopa Prabhu wrote: > > On Thu, Jan 31, 2019 at 8:16 AM Roopa Prabhu wrote: > > > On Wed, Jan 30, 2019 at 4:24 PM Jakub Kicinski wrote: > > > > On Wed, 30 Jan 2019 14:14:34 -0800, Roopa Prabhu wrote: > >

Re: Bluetooth: hci0: last event is not cmd complete (0x0f) with LG TV

2019-02-02 Thread Paul Menzel
Dear Linux folks, On 01.02.19 22:34, Paul Menzel wrote: [attaching Linux messages, lspci and lsusb output] On 01.02.19 22:20, Paul Menzel wrote: When trying to pair a Dell Latitude E7250 running Debian Sid/unstable with Linux 4.20 and GNOME 3.30 with an LG TV, after starting the pairing pr

Re: [PATCH iproute2-next] devlink: add info subcommand

2019-02-02 Thread Jakub Kicinski
On Sat, 2 Feb 2019 16:59:38 +0100, Jiri Pirko wrote: > Sat, Feb 02, 2019 at 01:03:38AM CET, jakub.kicin...@netronome.com wrote: > >Add support for reading the device serial number and versions > >from the kernel. > > > >RFCv2: > > - make info subcommand of dev. > > Please add some examples of in

Re: [PATCH net-next] net: devlink: report cell size of shared buffers

2019-02-02 Thread Jakub Kicinski
On Sat, 2 Feb 2019 12:35:51 +, Ido Schimmel wrote: > On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote: > > Shared buffer allocation is usually done in cell increments. > > Drivers will either round up the allocation or refuse the > > configuration if it's not an exact multiple of

Re: [PATCH 02/12 net-next,v7] net/mlx5e: support for two independent packet edit actions

2019-02-02 Thread Or Gerlitz
On Sat, Feb 2, 2019 at 5:19 PM Tonghao Zhang wrote: > The patch [1] is ready too. David may decide which one will be applied > firstly. and other is rebased ?. Your patch is for net, net-next is rebased over net > [1] http://patchwork.ozlabs.org/patch/1032952/

Re: [PATCH 02/12 net-next,v7] net/mlx5e: support for two independent packet edit actions

2019-02-02 Thread Or Gerlitz
On Sat, Feb 2, 2019 at 5:19 PM Tonghao Zhang wrote: > The patch [1] is ready too. David may decide which one will be applied > firstly. and other is rebased ?. Your patch is for net, net-next is rebased over net > [1] http://patchwork.ozlabs.org/patch/1032952/

Re: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames

2019-02-02 Thread David Ahern
On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: >> >> David, Jesper, care to chime in where we ended up in that last thread >> discussion this? > > IHMO packets RX and TX on a device need to be accounted, in standard > counters, regardless of XDP. For XDP RX the packet is counted as RX, > regar

Re: [PATCH] net: dsa: Fix lockdep false positive splat

2019-02-02 Thread Florian Fainelli
Le 2/2/19 à 9:53 AM, Marc Zyngier a écrit : > Creating a macvtap on a DSA-backed interface results in the following > splat when lockdep is enabled: > > [ 19.638080] IPv6: ADDRCONF(NETDEV_CHANGE): lan0: link becomes ready > [ 23.041198] device lan0 entered promiscuous mode > [ 23.043445] dev

Re: general protection fault in rds_recv_rcvbuf_delta

2019-02-02 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:cd984a5be215 Merge tag 'xtensa-20190201' of git://github.c.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1725e4ff40 kernel config: https://syzkaller.appspot.com/x/.config?x=2e0064

[PATCH] net: dsa: Fix lockdep false positive splat

2019-02-02 Thread Marc Zyngier
Creating a macvtap on a DSA-backed interface results in the following splat when lockdep is enabled: [ 19.638080] IPv6: ADDRCONF(NETDEV_CHANGE): lan0: link becomes ready [ 23.041198] device lan0 entered promiscuous mode [ 23.043445] device eth0 entered promiscuous mode [ 23.049255] [ 23.

Re: [PATCH] PCI / ACPI: Don't clear pme_poll on device that has unreliable ACPI wake

2019-02-02 Thread Kai Heng Feng
Hi Bjorn, > On Jan 28, 2019, at 3:51 PM, Kai Heng Feng > wrote: [snipped] >> If I understand correctly, the bugzilla lspci >> (https://bugzilla.kernel.org/attachment.cgi?id=280691) was collected >> at point 8, and it shows PME_Status=1 when it should be 0. >> >> If we write a 1 to PME_Status t

[PATCH] e1000e: Disable runtime PM on CNP+

2019-02-02 Thread Kai-Heng Feng
There are some new e1000e devices can only be woken up from D3 one time, by plugging ethernet cable. Subsequent cable plugging does set PME bit correctly, but it still doesn't get woken up. Since e1000e connects to the root complex directly, we rely on ACPI to wake it up. In this case, the GPE fro

Re: [PATCH 02/18] dmaengine: imx-sdma: pass struct device to DMA API functions

2019-02-02 Thread Christoph Hellwig
On Sat, Feb 02, 2019 at 03:41:21PM +0530, Vinod Koul wrote: > On 01-02-19, 09:47, Christoph Hellwig wrote: > > The DMA API generally relies on a struct device to work properly, and > > only barely works without one for legacy reasons. Pass the easily > > available struct device from the platform_d

Re: [PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-02 Thread Oliver Hartkopp
Hi all, On 02.02.19 16:34, Deepa Dinamani wrote: Add new socket timeout options that are y2038 safe. (..) diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h index 9826d1db71d0..0d0fddb7e738 100644 --- a/arch/alpha/include/uapi/asm/socket.h +++ b/arch/alp

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Andrew Lunn
On Sat, Feb 02, 2019 at 09:05:11AM -0800, Florian Fainelli wrote: > Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : > > The unbalance of master's promiscuity or allmulti will happen after ifdown > > and ifup a slave interface which is in a bridge. > > > > When we ifdown a slave interface , both the 'dsa

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Florian Fainelli
Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : > The unbalance of master's promiscuity or allmulti will happen after ifdown > and ifup a slave interface which is in a bridge. > > When we ifdown a slave interface , both the 'dsa_slave_close' and > 'dsa_slave_change_rx_flags' will clear the master's flag

Re: [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces

2019-02-02 Thread Alexei Starovoitov
On Fri, Feb 01, 2019 at 04:14:13PM -0800, Yonghong Song wrote: > These are patches responding to my comments for > Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/). > The goal is to make pr_* macros available to other C files > than libbpf.c, and to simplify API function libbpf_set_prin

Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-02 Thread David Miller
From: Huazhong Tan Date: Sat, 2 Feb 2019 22:39:25 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied.

Re: [PATCH iproute2-next] devlink: add info subcommand

2019-02-02 Thread Jiri Pirko
Sat, Feb 02, 2019 at 01:03:38AM CET, jakub.kicin...@netronome.com wrote: >Add support for reading the device serial number and versions >from the kernel. > >RFCv2: > - make info subcommand of dev. Please add some examples of inputs and outputs. > >Signed-off-by: Jakub Kicinski >--- > devlink/de

Re: [RFC net-next 00/13] Get rid of switchdev_ops

2019-02-02 Thread Jiri Pirko
Fri, Feb 01, 2019 at 11:06:44PM CET, f.faine...@gmail.com wrote: >Hi all, > >This patch series converts SWITCHDEV_PORT_ATTR_{GET,SET} to use a >blocking notifier, similar to how SWITCHDEV_PORT_OBJ_{ADD,DEL} has been >changed recently by Petr. > >This was suggested by Ido to help with a particular u

Re: [RFC net-next 01/13] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET

2019-02-02 Thread Jiri Pirko
Fri, Feb 01, 2019 at 11:06:45PM CET, f.faine...@gmail.com wrote: >In preparation for allowing switchdev enabled drivers to veto specific >attribute settings from within the context of the caller, introduce a >new switchdev notifier type for port attributes. > >Suggested-by: Ido Schimmel >Signed-of

Re: [PATCH 06/12 net-next,v7] drivers: net: use flow action infrastructure

2019-02-02 Thread Jiri Pirko
Sat, Feb 02, 2019 at 12:50:48PM CET, pa...@netfilter.org wrote: >This patch updates drivers to use the new flow action infrastructure. > >Signed-off-by: Pablo Neira Ayuso >--- >v7: rebase on top of net-next. Dropping previous Acked-by tags since >this one is slightly large, and it would be goo

Re: [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return

2019-02-02 Thread Ido Schimmel
On Thu, Jan 31, 2019 at 05:19:25PM -0800, Florian Fainelli wrote: > On 1/30/19 11:50 PM, Ido Schimmel wrote: > > On Wed, Jan 30, 2019 at 05:00:57PM -0800, Florian Fainelli wrote: > >> On 1/29/19 11:36 PM, Ido Schimmel wrote: > >>> On Tue, Jan 29, 2019 at 04:55:37PM -0800, Florian Fainelli wrote: >

[PATCH net-next v5 06/12] socket: Use old_timeval types for socket timestamps

2019-02-02 Thread Deepa Dinamani
As part of y2038 solution, all internal uses of struct timeval are replaced by struct __kernel_old_timeval and struct compat_timeval by struct old_timeval32. Make socket timestamps use these new types. This is mainly to be able to verify that the kernel build is y2038 safe when such non y2038 safe

[PATCH net-next v5 00/12] net: y2038-safe socket timestamps

2019-02-02 Thread Deepa Dinamani
The series introduces new socket timestamps that are y2038 safe. The time data types used for the existing socket timestamp options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING are not y2038 safe. The series introduces SO_TIMESTAMP_NEW, SO_TIMESTAMPNS_NEW and SO_TIMESTAMPING_NEW to replace th

[PATCH net-next v5 09/12] socket: Add SO_TIMESTAMPING_NEW

2019-02-02 Thread Deepa Dinamani
Add SO_TIMESTAMPING_NEW variant of socket timestamp options. This is the y2038 safe versions of the SO_TIMESTAMPING_OLD for all architectures. Signed-off-by: Deepa Dinamani Acked-by: Willem de Bruijn Cc: ch...@zankel.net Cc: fenghua...@intel.com Cc: r...@twiddle.net Cc: t...@linutronix.de Cc: ub

[PATCH net-next v5 05/12] arch: sparc: Override struct __kernel_old_timeval

2019-02-02 Thread Deepa Dinamani
struct __kernel_old_timeval is supposed to have the same layout as struct timeval. But, it was inadvarently missed that __kernel_suseconds has a different definition for sparc64. Provide an asm-specific override that fixes it. Reported-by: Arnd Bergmann Suggested-by: Arnd Bergmann Signed-off-by:

[PATCH net-next v5 04/12] sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD

2019-02-02 Thread Deepa Dinamani
SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING options, the way they are currently defined, are not y2038 safe. Subsequent patches in the series add new y2038 safe versions of these options which provide 64 bit timestamps on all architectures uniformly. Hence, rename existing options with OLD tag

[PATCH net-next v5 10/12] socket: Update timestamping Documentation

2019-02-02 Thread Deepa Dinamani
With the new y2038 safe timestamping options added, update the documentation to reflect the changes. Signed-off-by: Deepa Dinamani Acked-by: Willem de Bruijn --- Documentation/networking/timestamping.txt | 43 --- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git

[PATCH net-next v5 01/12] selftests: add missing include unistd

2019-02-02 Thread Deepa Dinamani
Compiling rxtimestamp.c generates error messages due to non-existing declaration for write() library call. Add missing unistd.h include to provide the declaration and silence the error. Signed-off-by: Deepa Dinamani Acked-by: Willem de Bruijn --- tools/testing/selftests/networking/timestamping

[PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-02 Thread Deepa Dinamani
Add new socket timeout options that are y2038 safe. Signed-off-by: Deepa Dinamani Acked-by: Willem de Bruijn Cc: ccaul...@redhat.com Cc: da...@davemloft.net Cc: del...@gmx.de Cc: pau...@samba.org Cc: r...@linux-mips.org Cc: r...@twiddle.net Cc: cluster-de...@redhat.com Cc: linuxppc-...@lists.ozl

[PATCH net-next v5 08/12] socket: Add SO_TIMESTAMP[NS]_NEW

2019-02-02 Thread Deepa Dinamani
Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of socket timestamp options. These are the y2038 safe versions of the SO_TIMESTAMP_OLD and SO_TIMESTAMPNS_OLD for all architectures. Note that the format of scm_timestamping.ts[0] is not changed in this patch. Signed-off-by: Deepa Dinamani Ack

[PATCH net-next v5 07/12] socket: Add struct __kernel_sock_timeval

2019-02-02 Thread Deepa Dinamani
The new type is meant to be used as a y2038 safe structure to be used as part of cmsg data. Presently the SO_TIMESTAMP socket option uses struct timeval for timestamps. This is not y2038 safe. Subsequent patches in the series add new y2038 safe socket option to be used in the place of SO_TIMESTAMP_

[PATCH net-next v5 11/12] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes

2019-02-02 Thread Deepa Dinamani
SO_RCVTIMEO and SO_SNDTIMEO socket options use struct timeval as the time format. struct timeval is not y2038 safe. The subsequent patches in the series add support for new socket timeout options with _NEW suffix that will use y2038 safe data structures. Although the existing struct timeval layout

[PATCH net-next v5 03/12] arch: Use asm-generic/socket.h when possible

2019-02-02 Thread Deepa Dinamani
Many architectures maintain an arch specific copy of the file even though there are no differences with the asm-generic one. Allow these architectures to use the generic one instead. Signed-off-by: Deepa Dinamani Acked-by: Max Filippov Acked-by: Heiko Carstens Acked-by: Willem de Bruijn Cc: ch

[PATCH net-next v5 02/12] socket: move compat timeout handling into sock.c

2019-02-02 Thread Deepa Dinamani
From: Arnd Bergmann This is a cleanup to prepare for the addition of 64-bit time_t in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems unnecessarily complex and error-prone, moving it all into the main setsockopt()/getsockopt() implementation requires half as much code and is easier to ex

Re: [PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them

2019-02-02 Thread Jiri Pirko
Sat, Feb 02, 2019 at 12:50:43PM CET, pa...@netfilter.org wrote: >This patch wraps the dissector key and mask - that flower uses to >represent the matching side - around the flow_match structure. > >To avoid a follow up patch that would edit the same LoCs in the drivers, >this patch also wraps this

Re: [PATCH 02/12 net-next,v7] net/mlx5e: support for two independent packet edit actions

2019-02-02 Thread Tonghao Zhang
On Sat, Feb 2, 2019 at 8:11 PM Pablo Neira Ayuso wrote: > > This patch adds pedit_headers_action structure to store the result of > parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to > populate the mlx5e hardware intermediate representation once all actions > have been parsed. > >

[PATCH net-next 01/12] net: hns3: fix a code style issue for hns3_update_new_int_gl()

2019-02-02 Thread Huazhong Tan
From: Peng Li Use the same code style for rx_group and tx_group in the hns3_update_new_int_gl(). Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisi

[PATCH net-next 06/12] net: hns3: move some set_bit statement into hclge_prepare_mac_addr

2019-02-02 Thread Huazhong Tan
From: Weihang Li This patch does not change the code logic. There are some same set_bit statements called by add/rm_uc/mc_addr_common, and move this statements into hclge_prepare_mac_addr to reduce duplicate code. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --

[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-02 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (1): net: hns3: fix a wrong checking in the hclge_tx_buffer_calc() Jian Shen (1): net: hns3: don't allow user to change vlan filter state Peng Li (2): net: hns3: fix a code style iss

[PATCH net-next 03/12] net: hns3: Modify parameter type from int to bool in set_gro_en

2019-02-02 Thread Huazhong Tan
From: Yonglong Liu The second parameter to the hook function set_gro_en is always passed in true/false, so modify it's type from int to bool. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +- .../net/ethe

[PATCH net-next 02/12] net: hns3: fix an issue for hns3_update_new_int_gl

2019-02-02 Thread Huazhong Tan
From: Peng Li HNS3 supports setting rx-usecs|tx-usecs as 0, but it will not update dynamically when adaptive-tx or adaptive-rx is enable. This patch removes the Redundant check. Fixes: a95e1f8666e9 ("net: hns3: change the time interval of int_gl calculating") Signed-off-by: Peng Li Signed-off-

[PATCH net-next 05/12] net: hns3: add hclge_cmd_check_retval() to parse comman's return value

2019-02-02 Thread Huazhong Tan
From: Weihang Li For simplifying the code, this patch adds hclge_cmd_check_retval() to check the return value of the command. Also, according the IMP's description, when there are several descriptors in a command, then the IMP will save the return value on the last description, so hclge_cmd_chec

[PATCH net-next 04/12] net: hns3: code optimization for hclge_rx_buffer_calc

2019-02-02 Thread Huazhong Tan
From: Yunsheng Lin There are four steps to calcuate the rx private buffer, each step can be done in a function to avoid code duplication and aid code readability. This patch adds three separate functions do the job. Also, the function name more or less make the comment redundant, so remove some

[PATCH net-next 07/12] net: hns3: fix a wrong checking in the hclge_tx_buffer_calc()

2019-02-02 Thread Huazhong Tan
Only the TC is enabled, we need to check whether the buffer is enough, otherwise it may lead to a wrong -ENOMEM case. Fixes: 9ffe79a9c2ee ("net: hns3: Support for dynamically assigning tx buffer to TC") Signed-off-by: Huazhong Tan Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/

[PATCH net-next 10/12] net: hns3: don't allow user to change vlan filter state

2019-02-02 Thread Huazhong Tan
From: Jian Shen When user disables vlan filter, and adds vlan device, it won't notify the driver the update the vlan filter. In this case, when user enables vlan filter again, the packets with new vlan tag will be filtered by vlan filter. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-

[PATCH net-next 12/12] net: hns3: MAC table entry count function increases operation 0 value protection measures

2019-02-02 Thread Huazhong Tan
From: liuzhongzhu When updating the available MAC VLAN table counts, MAC VLAN table entry count function adds operation 0 value protection measures. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +

[PATCH net-next 09/12] net: hns3: optimize the maximum TC macro

2019-02-02 Thread Huazhong Tan
From: liuzhongzhu Multiple macros with the largest number of TCs in the system, optimized to HCLGE_MAX_TC_NUM. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 7 +++ drivers/net/ethernet/hisili

[PATCH net-next 08/12] net: hns3: fix the problem that the supported port is empty

2019-02-02 Thread Huazhong Tan
From: liuzhongzhu Run ethtool ethx when displaying device information in VF, the supported port and link mode items will be empty. This patch fixes it. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Signed-off-by: liuzhongzhu Signed-off-by: Peng Li S

[PATCH net-next 11/12] net: hns3: modify the upper limit judgment condition

2019-02-02 Thread Huazhong Tan
From: liuzhongzhu In order to prevent the variable anomaly from being larger than desc_num, the upper limit judgment condition becomes >=. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 4 ++-- 1 file

Re: [PATCH net-next] bonding: check slave set command firstly

2019-02-02 Thread kbuild test robot
Hi Tonghao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/bonding-check-slave-set-command-firstly/20190202-215305 config: xtensa-allyesconfig (attached as .config

[PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Rundong Ge
The unbalance of master's promiscuity or allmulti will happen after ifdown and ifup a slave interface which is in a bridge. When we ifdown a slave interface , both the 'dsa_slave_close' and 'dsa_slave_change_rx_flags' will clear the master's flags. The flags of master will be decrease twice. In th

Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh

2019-02-02 Thread Masahiro Yamada
On Sat, Feb 2, 2019 at 9:00 AM Alexei Starovoitov wrote: > > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > > Currently, the header search paths -Itools/include and > > -Itools/include/uapi are not used. Let's drop the unused code. > > > > We can remove -I. too by fixing up one

Re: [PATCH net-next] net: devlink: report cell size of shared buffers

2019-02-02 Thread Ido Schimmel
On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote: > Shared buffer allocation is usually done in cell increments. > Drivers will either round up the allocation or refuse the > configuration if it's not an exact multiple of cell size. > Drivers know exactly the cell size of shared buffe

Re: r8169 Driver - Poor Network Performance Since Kernel 4.19

2019-02-02 Thread Heiner Kallweit
Hi David, to check another potential incompatibility: Could you please test a 4.19 version with the following line disabled. Rgds, Heiner --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/

[PATCH 12/12 net-next,v7] qede: use ethtool_rx_flow_rule() to remove duplicated parser code

2019-02-02 Thread Pablo Neira Ayuso
The qede driver supports for ethtool_rx_flow_spec and flower, both codebases look very similar. This patch uses the ethtool_rx_flow_rule() infrastructure to remove the duplicated ethtool_rx_flow_spec parser and consolidate ACL offload support around the flow_rule infrastructure. Furthermore, more

[PATCH 06/12 net-next,v7] drivers: net: use flow action infrastructure

2019-02-02 Thread Pablo Neira Ayuso
This patch updates drivers to use the new flow action infrastructure. Signed-off-by: Pablo Neira Ayuso --- v7: rebase on top of net-next. Dropping previous Acked-by tags since this one is slightly large, and it would be good another look after this rebase. drivers/net/ethernet/broadcom/

[PATCH 09/12 net-next,v7] ethtool: add ethtool_rx_flow_spec to flow_rule structure translator

2019-02-02 Thread Pablo Neira Ayuso
This patch adds a function to translate the ethtool_rx_flow_spec structure to the flow_rule representation. This allows us to reuse code from the driver side given that both flower and ethtool_rx_flow interfaces use the same representation. This patch also includes support for the flow type flags

[PATCH 05/12 net-next,v7] flow_offload: add statistics retrieval infrastructure and use it

2019-02-02 Thread Pablo Neira Ayuso
This patch provides the flow_stats structure that acts as container for tc_cls_flower_offload, then we can use to restore the statistics on the existing TC actions. Hence, tcf_exts_stats_update() is not used from drivers anymore. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v7: reba

[PATCH 10/12 net-next,v7] dsa: bcm_sf2: use flow_rule infrastructure

2019-02-02 Thread Pablo Neira Ayuso
Update this driver to use the flow_rule infrastructure, hence we can use the same code to populate hardware IR from ethtool_rx_flow and the cls_flower interfaces. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko Reviewed-by: Florian Fainelli --- v7: rebase on top of net-next. drivers/net

[PATCH 07/12 net-next,v7] cls_flower: don't expose TC actions to drivers anymore

2019-02-02 Thread Pablo Neira Ayuso
Now that drivers have been converted to use the flow action infrastructure, remove this field from the tc_cls_flower_offload structure. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v7: rebase on top of net-next. include/net/pkt_cls.h | 1 - net/sched/cls_flower.c | 5 - 2 fil

[PATCH 02/12 net-next,v7] net/mlx5e: support for two independent packet edit actions

2019-02-02 Thread Pablo Neira Ayuso
This patch adds pedit_headers_action structure to store the result of parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to populate the mlx5e hardware intermediate representation once all actions have been parsed. This patch comes in preparation for the new flow_action infrastructur

[PATCH 00/12 net-next,v7] add flow_rule infrastructure

2019-02-02 Thread Pablo Neira Ayuso
Hi, This patchset, as is, allows us to reuse the driver codebase to configure ACL hardware offloads for the ethtool_rxnfc and the TC flower interfaces. A few clients for this infrastructure are presented, such as the bcm_sf2 and the qede drivers, for reference. Moreover all of the existing drivers

[PATCH 11/12 net-next,v7] qede: place ethtool_rx_flow_spec after code after TC flower codebase

2019-02-02 Thread Pablo Neira Ayuso
This is a preparation patch to reuse the existing TC flower codebase from ethtool_rx_flow_spec. This patch is merely moving the core ethtool_rx_flow_spec parser after tc flower offload driver code so we can skip a few forward function declarations in the follow up patch. Signed-off-by: Pablo Neir

[PATCH 08/12 net-next,v7] flow_offload: add wake-up-on-lan and queue to flow_action

2019-02-02 Thread Pablo Neira Ayuso
These actions need to be added to support the ethtool_rx_flow interface. The queue action includes a field to specify the RSS context, that is set via FLOW_RSS flow type flag and the rss_context field in struct ethtool_rxnfc, plus the corresponding queue index. FLOW_RSS implies that rss_context is

[PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them

2019-02-02 Thread Pablo Neira Ayuso
This patch wraps the dissector key and mask - that flower uses to represent the matching side - around the flow_match structure. To avoid a follow up patch that would edit the same LoCs in the drivers, this patch also wraps this new flow match structure around the flow rule object. This new struct

[PATCH 04/12 net-next,v7] cls_api: add translator to flow_action representation

2019-02-02 Thread Pablo Neira Ayuso
This patch implements a new function to translate from native TC action to the new flow_action representation. Moreover, this patch also updates cls_flower to use this new function. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v7: rebase on top of net-next. include/net/pkt_cls.h

[PATCH 03/12 net-next,v7] flow_offload: add flow action infrastructure

2019-02-02 Thread Pablo Neira Ayuso
This new infrastructure defines the nic actions that you can perform from existing network drivers. This infrastructure allows us to avoid a direct dependency with the native software TC action representation. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v7: rebase on top of net-nex

[PATCH] atheros: atl2: fix an indentaion issue on a return statement

2019-02-02 Thread Colin King
From: Colin Ian King A return statment is not indented correctly, fix this by adding an extra tab. Signed-off-by: Colin Ian King --- drivers/net/ethernet/atheros/atlx/atl2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/

[PATCH] atl1c: fix indentation issue on an if statement

2019-02-02 Thread Colin King
From: Colin Ian King An if statement is indented one level too deep, fix this by removing the extra tabs. Also add some spaces to the dev_warn arguments to clean up checkpatch warnings. Signed-off-by: Colin Ian King --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 8 1 file chang

[PATCH] bna: fix indentation issue on call to bfa_ioc_pf_failed

2019-02-02 Thread Colin King
From: Colin Ian King The call to bfa_ioc_pf_failed is indented too far, fix this by removing a tab. Signed-off-by: Colin Ian King --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/dri

[PATCH] chelsio: clean up indentation issue

2019-02-02 Thread Colin King
From: Colin Ian King The assignment to size is indented too far, fix this and join two lines into one. Signed-off-by: Colin Ian King --- drivers/net/ethernet/chelsio/cxgb/sge.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.c b/driv

Re: [PATCH 02/18] dmaengine: imx-sdma: pass struct device to DMA API functions

2019-02-02 Thread Vinod Koul
On 01-02-19, 09:47, Christoph Hellwig wrote: > The DMA API generally relies on a struct device to work properly, and > only barely works without one for legacy reasons. Pass the easily > available struct device from the platform_device to remedy this. This looks good to me but fails to apply. Can