Re: [PATCH mlx5-next 0/4] mlx5 next misc updates

2019-01-26 Thread Leon Romanovsky
On Fri, Jan 25, 2019 at 10:08:00AM -0800, Saeed Mahameed wrote: > On Thu, Jan 24, 2019 at 4:30 AM Leon Romanovsky wrote: > > > > On Fri, Jan 18, 2019 at 04:33:09PM -0800, Saeed Mahameed wrote: > > > Hi all, > > > > > > This series includes updates to mlx5-next shared branch. > > > > > > 1) from Ja

[PATCH net] ip6mr: Fix notifiers call on mroute_clean_tables()

2019-01-26 Thread Nir Dotan
When the MC route socket is closed, mroute_clean_tables() is called to cleanup existing routes. Mistakenly notifiers call was put on the cleanup of the unresolved MC route entries cache. In a case where the MC socket closes before an unresolved route expires, the notifier call leads to a crash, cau

Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-26 Thread Eli Britstein
On 1/27/2019 1:04 AM, David Miller wrote: > From: Eli Britstein > Date: Thu, 24 Jan 2019 11:46:47 +0200 > >> Declare ovs key structures using macros to enable retrieving fields >> information, with no functional change. >> >> Signed-off-by: Eli Britstein >> Reviewed-by: Roi Dayan > I agree with

Re: [PATCH] net: lmc: remove -I. header search path

2019-01-26 Thread David Miller
From: Masahiro Yamada Date: Fri, 25 Jan 2019 23:22:29 +0900 > The header search path -I. in kernel Makefiles is very suspicious; > it allows the compiler to search for headers in the top of $(srctree), > where obviously no header file exists. > > I was able to build without this header search pa

[PATCH net] net: tls: Fix deadlock in free_resources tx

2019-01-26 Thread Dave Watson
If there are outstanding async tx requests (when crypto returns EINPROGRESS), there is a potential deadlock: the tx work acquires the lock, while we cancel_delayed_work_sync() while holding the lock. Drop the lock while waiting for the work to complete. Fixes: a42055e8d2c30 ("Add support for asyn

[PATCH net] net: tls: Save iv in tls_rec for async crypto requests

2019-01-26 Thread Dave Watson
aead_request_set_crypt takes an iv pointer, and we change the iv soon after setting it. Some async crypto algorithms don't save the iv, so we need to save it in the tls_rec for async requests. Found by hardcoding x64 aesni to use async crypto manager (to test the async codepath), however I don't

Re: [PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap()

2019-01-26 Thread Michael S. Tsirkin
On Sat, Jan 26, 2019 at 02:37:08PM -0800, David Miller wrote: > From: Jason Wang > Date: Wed, 23 Jan 2019 17:55:52 +0800 > > > This series tries to access virtqueue metadata through kernel virtual > > address instead of copy_user() friends since they had too much > > overheads like checks, spec b

Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-26 Thread David Miller
From: Eli Britstein Date: Thu, 24 Jan 2019 11:46:47 +0200 > Declare ovs key structures using macros to enable retrieving fields > information, with no functional change. > > Signed-off-by: Eli Britstein > Reviewed-by: Roi Dayan I agree with Pravin, this need a much better commit message. May

RE: Good News

2019-01-26 Thread Hovey, Kim
You are a recipient of 3.5M USD for more details please contact us via: frbe...@gmail.com

[PATCH net] net: set default network namespace in init_dummy_netdev()

2019-01-26 Thread Josh Elsasser
Assign a default net namespace to netdevs created by init_dummy_netdev(). Fixes a NULL pointer dereference caused by busy-polling a socket bound to an iwlwifi wireless device, which bumps the per-net BUSYPOLLRXPACKETS stat if napi_poll() received packets: BUG: unable to handle kernel NULL pointe

Re: [PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap()

2019-01-26 Thread David Miller
From: Jason Wang Date: Wed, 23 Jan 2019 17:55:52 +0800 > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. > > Test shows about 24% imp

Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-26 Thread Josh Elsasser
On Jan 23, 2019, at 7:40 PM, Josh Elsasser wrote: > On Jan 23, 2019, at 7:08 PM, Herbert Xu wrote: > >> Thanks for catching this! >> >> Although I think we should fix this in a different way. The problem >> here is that the shrink cannot proceed because there was a previous >> rehash that is s

Re: [PATCH bpf-next v2 3/3] selftests: bpf: add test_lwt_ip_encap selftest

2019-01-26 Thread Alexei Starovoitov
On Sat, Jan 26, 2019 at 1:46 PM Alexei Starovoitov wrote: > > On Thu, Jan 24, 2019 at 11:34 AM Peter Oskolkov wrote: > > > > This patch adds a bpf self-test to cover BPF_LWT_ENCAP_IP mode > > in bpf_lwt_push_encap. > > > > Covered: > > - encapping in LWT_IN and LWT_XMIT > > - IPv4 and IPv6 > > >

Re: [PATCH bpf-next v2 3/3] selftests: bpf: add test_lwt_ip_encap selftest

2019-01-26 Thread Alexei Starovoitov
On Thu, Jan 24, 2019 at 11:34 AM Peter Oskolkov wrote: > > This patch adds a bpf self-test to cover BPF_LWT_ENCAP_IP mode > in bpf_lwt_push_encap. > > Covered: > - encapping in LWT_IN and LWT_XMIT > - IPv4 and IPv6 > > Signed-off-by: Peter Oskolkov > --- > tools/testing/selftests/bpf/Makefile

Re: [PATCH bpf-next v4 00/16] bpf: propose new jmp32 instructions

2019-01-26 Thread Alexei Starovoitov
On Sat, Jan 26, 2019 at 12:25:58PM -0500, Jiong Wang wrote: > v3 -> v4: > - Fixed rebase issue. JMP32 checks were missing in two new functions: > + kernel/bpf/verifier.c:insn_is_cond_jump > + drivers/net/ethernet/netronome/nfp/bpf/main.h:is_mbpf_cond_jump >(Daniel) > - Further rebase

Re: [PATCH] iwlwifi: Use kmemdup instead of duplicating its function

2019-01-26 Thread Joe Perches
On Sat, 2019-01-26 at 20:42 +0800, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation [] > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c > b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c [] > @@ -1196,13 +1196,9 @@ iwl_parse_nvm_mcc_info(struct device

[PATCH] decnet: fix DN_IFREQ_SIZE

2019-01-26 Thread Johannes Berg
From: Johannes Berg Digging through the ioctls with Al because of the previous patches, we found that on 64-bit decnet's dn_dev_ioctl() is wrong, because struct ifreq::ifr_ifru is actually 24 bytes (not 16 as expected from struct sockaddr) due to the ifru_map and ifru_settings members. Clearly,

[PATCH] net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup()

2019-01-26 Thread Alexey Khoroshilov
If phy_power_on() fails in rk_gmac_powerup(), clocks are left enabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drive

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Heiner Kallweit
On 26.01.2019 18:07, Marc Haber wrote: > On Sat, Jan 26, 2019 at 03:04:34PM +0100, Heiner Kallweit wrote: >> Thanks for testing. Then the only way to find the offending commit is >> bisecting. > > :-( > > Bisecting between which tags? > You could go with this range: from 4ff364662814 ("r8169:

Re: [PATCH net-next] Documentation: net: phy: switch documentation to rst format

2019-01-26 Thread Heiner Kallweit
On 26.01.2019 18:17, David Miller wrote: > From: Heiner Kallweit > Date: Sat, 26 Jan 2019 11:25:37 +0100 > >> Switch phylib documentation to rst format. >> >> Signed-off-by: Heiner Kallweit > > Applied, but there was a lot of trailing whitespace which I needed to > clean up. > > GIT warns abou

Re: [PATCH net 2/4] Revert "kill dev_ifsioc()"

2019-01-26 Thread Johannes Berg
On Sat, 2019-01-26 at 18:49 +0100, Johannes Berg wrote: > On Sat, 2019-01-26 at 18:45 +0100, Johannes Berg wrote: > > > > Yes and no. It *sometimes* (actually rarely, since we don't really have > > dev_ioctls that much, afaict) hits this, but it could also just hit > > Actually, no, I'm wrong. We

Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion

2019-01-26 Thread Sasha Levin
On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote: Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() when the conversion into ktime multiplies the given value with NSEC_PER_USEC (1000). Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 Add a c

Re: [PATCH net 2/4] Revert "kill dev_ifsioc()"

2019-01-26 Thread Johannes Berg
On Sat, 2019-01-26 at 18:45 +0100, Johannes Berg wrote: > > Yes and no. It *sometimes* (actually rarely, since we don't really have > dev_ioctls that much, afaict) hits this, but it could also just hit Actually, no, I'm wrong. We do mostly hit dev_ioctl(), since that's the common case for things

Re: [PATCH net 2/4] Revert "kill dev_ifsioc()"

2019-01-26 Thread Johannes Berg
On Sat, 2019-01-26 at 17:29 +, Al Viro wrote: > > I disagree with solution. Look at what's happening here: > > > + uifr = compat_alloc_user_space(sizeof(*uifr)); > > + if (copy_in_user(uifr, uifr32, sizeof(*uifr32))) > > + return -EFAULT; > > an enlarged copy is made. Yes, th

Re: [PATCH v2 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-26 Thread David Miller
From: Bryan Whitehead Date: Wed, 23 Jan 2019 15:18:47 -0500 > The LAN743x includes on chip One-Time-Programmable (OTP) memory. > > This patch extends the ethtool EEPROM read/write interface to > access OTP memory space. > > The currently existing interface is limited, as it does not > allow OTP

Re: [PATCH bpf-next v4 12/16] ppc: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
On 26/01/2019 17:26, Jiong Wang wrote: This patch implements code-gen for new JMP32 instructions on ppc. For JMP32 | JSET, instruction encoding for PPC_RLWINM_DOT is added to check the result of ANDing low 32-bit of operands. Cc: Naveen N. Rao Cc: Sandipan Das Signed-off-by: Jiong Wang Apo

Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-01-26 Thread David Miller
From: Huazhong Tan Date: Sun, 27 Jan 2019 00:49:09 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied, thanks.

Re: [PATCH net 2/4] Revert "kill dev_ifsioc()"

2019-01-26 Thread Al Viro
On Fri, Jan 25, 2019 at 10:43:18PM +0100, Johannes Berg wrote: > From: Johannes Berg > > This reverts commit bf4405737f9f ("kill dev_ifsioc()"). > > This wasn't really unused as implied by the original commit, > it still handles the copy to/from user differently, and the > commit thus caused iss

[PATCH bpf-next v4 14/16] nfp: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on NFP. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 97 --- drivers/net/ethernet/netronome/nfp/bpf/main.h | 22 +- 2 files changed, 93 insertions(+

[PATCH bpf-next v4 15/16] selftests: bpf: functional and min/max reasoning unit tests for JMP32

2019-01-26 Thread Jiong Wang
This patch adds unit tests for new JMP32 instructions. This patch also added the new BPF_JMP32_REG and BPF_JMP32_IMM macros to samples/bpf/bpf_insn.h so that JMP32 insn builders are available to tests under 'samples' directory. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- samples/

[PATCH bpf-next v4 00/16] bpf: propose new jmp32 instructions

2019-01-26 Thread Jiong Wang
v3 -> v4: - Fixed rebase issue. JMP32 checks were missing in two new functions: + kernel/bpf/verifier.c:insn_is_cond_jump + drivers/net/ethernet/netronome/nfp/bpf/main.h:is_mbpf_cond_jump (Daniel) - Further rebased on top of latest llvm-readelf change. v2 -> v3: - Added missed check

[PATCH bpf-next v4 13/16] s390: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on s390. Cc: Martin Schwidefsky Cc: Heiko Carstens Signed-off-by: Jiong Wang --- arch/s390/net/bpf_jit_comp.c | 66 ++-- 1 file changed, 52 insertions(+), 14 deletions(-) diff --git a/arch/s390/n

[PATCH bpf-next v4 16/16] selftests: bpf: makefile support sub-register code-gen test mode

2019-01-26 Thread Jiong Wang
This patch enables testing some eBPF programs under sub-register compilation mode. Only enable this when there is BPF_JMP32 support on both LLVM and kernel. This is because only after BPF_JMP32 added, code-gen for complex program under sub-register mode will be clean enough to pass verification.

[PATCH bpf-next v4 10/16] arm64: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on arm64. Cc: Daniel Borkmann Cc: Alexei Starovoitov Cc: Zi Shen Lim Signed-off-by: Jiong Wang --- arch/arm64/net/bpf_jit_comp.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git

[PATCH bpf-next v4 04/16] bpf: disassembler support JMP32

2019-01-26 Thread Jiong Wang
This patch teaches disassembler about JMP32. There are two places to update: - Class 0x6 now used by BPF_JMP32, not "unused". - BPF_JMP32 need to show comparison operands properly. The disassemble format is to add an extra "(32)" before the operands if it is a sub-register. A better d

[PATCH bpf-next v4 12/16] ppc: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on ppc. For JMP32 | JSET, instruction encoding for PPC_RLWINM_DOT is added to check the result of ANDing low 32-bit of operands. Cc: Naveen N. Rao Cc: Sandipan Das Signed-off-by: Jiong Wang --- arch/powerpc/include/asm/ppc-opcode.h |

[PATCH bpf-next v4 08/16] x86_64: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on x86_64. Cc: Alexei Starovoitov Cc: Daniel Borkmann Signed-off-by: Jiong Wang --- arch/x86/net/bpf_jit_comp.c | 46 +++-- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/arch/x86/

[PATCH bpf-next v4 03/16] bpf: verifier support JMP32

2019-01-26 Thread Jiong Wang
This patch teach verifier about the new BPF_JMP32 instruction class. Verifier need to treat it similar as the existing BPF_JMP class. A BPF_JMP32 insn needs to go through all checks that have been done on BPF_JMP. Also, verifier is doing runtime optimizations based on the extra info conditional ju

[PATCH bpf-next v4 02/16] bpf: refactor verifier min/max code for condition jump

2019-01-26 Thread Jiong Wang
The current min/max code does both signed and unsigned comparisons against the input argument "val" which is "u64" and there is explicit type casting when the comparison is signed. As we will need slightly more complexer type casting when JMP32 introduced, it is better to host the signed type cast

[PATCH bpf-next v4 11/16] arm: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on arm. For JSET, "ands" (AND with flags updated) is used, so corresponding encoding helper is added. Cc: Shubham Bansal Signed-off-by: Jiong Wang --- arch/arm/net/bpf_jit_32.c | 53 +++ arch/

[PATCH bpf-next v4 09/16] x32: bpf: implement jitting of JMP32

2019-01-26 Thread Jiong Wang
This patch implements code-gen for new JMP32 instructions on x32. Also fixed several reverse xmas tree coding style issues as I am there. Cc: Wang YanQing Signed-off-by: Jiong Wang --- arch/x86/net/bpf_jit_comp32.c | 121 +- 1 file changed, 85 insertions(

[PATCH bpf-next v4 06/16] bpf: interpreter support for JMP32

2019-01-26 Thread Jiong Wang
This patch implements interpreting new JMP32 instructions. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- kernel/bpf/core.c | 197 +- 1 file changed, 63 insertions(+), 134 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/co

[PATCH bpf-next v4 05/16] tools: bpftool: teach cfg code about JMP32

2019-01-26 Thread Jiong Wang
The cfg code need to be aware of the new JMP32 instruction class so it could partition functions correctly. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- tools/bpf/bpftool/cfg.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/bpf/bpftool/cfg.c b/to

[PATCH bpf-next v4 07/16] bpf: JIT blinds support JMP32

2019-01-26 Thread Jiong Wang
This patch adds JIT blinds support for JMP32. Like BPF_JMP_REG/IMM, JMP32 version are needed for building raw bpf insn. They are added to both include/linux/filter.h and tools/include/linux/filter.h. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/filter.h | 20 ++

[PATCH bpf-next v4 01/16] bpf: allocate 0x06 to new eBPF instruction class JMP32

2019-01-26 Thread Jiong Wang
The new eBPF instruction class JMP32 uses the reserved class number 0x6. Kernel BPF ISA documentation updated accordingly. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- Documentation/networking/filter.txt | 15 --- include/uapi/linux/bpf.h| 1 + tools/includ

Re: [PATCH net-next 0/2] r8169: add EEE support for RTL8168f

2019-01-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 26 Jan 2019 10:34:31 +0100 > This series adds EEE support for RTL8168f. Again first patch adds the > support, and second patch enables EEE per default. Series applied.

Re: [PATCH net-next] Documentation: net: phy: switch documentation to rst format

2019-01-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 26 Jan 2019 11:25:37 +0100 > Switch phylib documentation to rst format. > > Signed-off-by: Heiner Kallweit Applied, but there was a lot of trailing whitespace which I needed to clean up. GIT warns about this, and you can double check in the future by doing som

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Marc Haber
On Sat, Jan 26, 2019 at 03:04:34PM +0100, Heiner Kallweit wrote: > Thanks for testing. Then the only way to find the offending commit is > bisecting. :-( Bisecting between which tags? Greetings Ma "at least this issue is readily reproducible" rc --

[PATCH net-next 12/12] net: hns3: don't allow vf to enable promisc mode

2019-01-26 Thread Huazhong Tan
From: Jian Shen VF can receive packets of other functions when in promisc mode. It's not safe, so don't allow VF to enable promisc mode. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_mbx.c | 7 ++-- .../hisilicon/hns3/hns3vf/hclgevf_main.c

[PATCH net-next 10/12] net: hns3: add 8 BD limit for tx flow

2019-01-26 Thread Huazhong Tan
From: Peng Li A single transmit packet can span up to 8 descriptors according to the HW limit. If a skb has more than 8 frags, driver uses skb_copy to get a new skb which has less frags. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 28

[PATCH net-next 02/12] net: hns3: clear pci private data when unload hns3 driver

2019-01-26 Thread Huazhong Tan
From: Jian Shen When unload hns3 driver, we should clear the pci private data. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hn

[PATCH net-next 08/12] net: hns3: remove dcb_ops->map_update in hclge_dcb

2019-01-26 Thread Huazhong Tan
From: Yunsheng Lin After doing down/uninit/init/up in hclge_dcb, it is not necessary to call dcb_ops->map_update in enet, so hclge_map_update can be called directly in hclge_dcb. This is for preparing to call hns3_nic_set_real_num_queue with netdev down when user changes mqprio configuration. S

[PATCH net-next 03/12] net: hns3: add error handling in hclge_ieee_setets

2019-01-26 Thread Huazhong Tan
From: Yunsheng Lin Currently hclge_ieee_setets returns error directly when there is error, which may cause netdev not up problem. This patch adds some error handling when setting ETS configuration fails. Fixes: cacde272dd00 ("net: hns3: Add hclge_dcb module for the support of DCB feature") Sig

[PATCH net-next 04/12] net: hns3: fix return value handle issue for hclge_set_loopback()

2019-01-26 Thread Huazhong Tan
From: Jian Shen In current code, it always return 0, even loopback mode setting failed. It's incorrect. This patch fixes return value handle for loopback test. Fixes: 0f29fc23b21d ("net: hns3: Fix for loopback selftest failed problem") Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off

[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-01-26 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Jian Shen (6): net: hns3: don't update packet statistics for packets dropped by hardware net: hns3: clear pci private data when unload hns3 driver net: hns3: fix return value handle issue for h

[PATCH net-next 01/12] net: hns3: don't update packet statistics for packets dropped by hardware

2019-01-26 Thread Huazhong Tan
From: Jian Shen Packet statistics for netdev should not include the packets dropped by hardware. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/e

[PATCH net-next 05/12] net: hns3: fix broadcast promisc issue for revision 0x20

2019-01-26 Thread Huazhong Tan
From: Jian Shen For revision 0x20, vlan filter is always bypassed when enable broadcast promisc mode. In this case, broadcast packets with any vlan id can be accpeted. We should disable broadcast promisc mode until user want enable it. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engin

[PATCH net-next 09/12] net: hns3: call hns3_nic_set_real_num_queue with netdev down

2019-01-26 Thread Huazhong Tan
From: Yunsheng Lin hns3_client_setup_tc in enet is for updating TC configuration to stack, and hclge_setup_tc in hclge_dcb is mainly for setting the configuration to hardware. This patch removes the hns3_nic_set_real_num_queue from hns3_setup_tc in enet, and call hclge_client_setup_tc to update

[PATCH net-next 11/12] net: hns3: add initialization for nic state

2019-01-26 Thread Huazhong Tan
From: Jian Shen This patch adds initialization for nic state, sets flag HNS3_NIC_STATE_DOWN when initialize, clears it before vectors and napi being enabled in the hns3_nic_net_up(), and sets it back in the error handler. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/et

[PATCH net-next 06/12] net: hns3: After setting the loopback, add the status of getting MAC

2019-01-26 Thread Huazhong Tan
From: liuzhongzhu After setting the serdes loopback, you need to determine the status of the MAC negotiation. If a status exception is obtained after 200ms, a timeout error is returned. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3p

[PATCH net-next 07/12] net: hns3: do reinitialization while mqprio configuration changed

2019-01-26 Thread Huazhong Tan
From: Yunsheng Lin When user changes the mqprio configuration, enet need to be uninited and inited besides down'ed and up'ed, because the queue num may change when the TC num changes. Also, it is more suitable to do the down/unint/init/up operation in hclge module using hclge_notify_client, beca

Re: [PATCH] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x"

2019-01-26 Thread Russell King - ARM Linux admin
On Sat, Jan 26, 2019 at 04:58:34PM +0100, Andrew Lunn wrote: > On Fri, Jan 25, 2019 at 11:27:57PM +, Russell King wrote: > > This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0. > > > > The original diagnosis was incorrect: it appears that the NIC had > > PHY polling mode enabled, whi

Re: [PATCH net-next] Documentation: net: phy: switch documentation to rst format

2019-01-26 Thread Andrew Lunn
On Sat, Jan 26, 2019 at 11:25:37AM +0100, Heiner Kallweit wrote: > Switch phylib documentation to rst format. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x"

2019-01-26 Thread Andrew Lunn
On Fri, Jan 25, 2019 at 11:27:57PM +, Russell King wrote: > This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0. > > The original diagnosis was incorrect: it appears that the NIC had > PHY polling mode enabled, which meant that it overwrote the PHYs > advertisement register during neg

Re: [RFC PATCH 2/6] net/sched: flower: add support for matching on ConnTrack

2019-01-26 Thread Marcelo Ricardo Leitner
On Fri, Jan 25, 2019 at 02:37:13PM +0100, Simon Horman wrote: > Hi Marcelo, > > On Fri, Jan 25, 2019 at 12:32:31AM -0200, Marcelo Ricardo Leitner wrote: > > Hook on flow dissector's new interface on ConnTrack from previous patch. > > > > Signed-off-by: Marcelo Ricardo Leitner > > --- > > includ

Re: [net-next PATCH] MAINTAINERS: Add entry for XDP core code

2019-01-26 Thread Jesper Dangaard Brouer
On Fri, 25 Jan 2019 23:10:51 +0100 Daniel Borkmann wrote: > Hi Jesper, > > On 01/25/2019 01:02 PM, Jesper Dangaard Brouer wrote: > > Add myself as a maintainer for these parts, as I'm responsible > > for adding most of this. > > > > Signed-off-by: Jesper Dangaard Brouer > > --- > > MAINTAINER

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Heiner Kallweit
On 26.01.2019 15:08, Heiner Kallweit wrote: > On 13.01.2019 17:01, Marc Haber wrote: >> On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: >>> On 12.01.2019 21:08, Marc Haber wrote: I am writing to all people who have commits in r8169.c between the v4.18 and v4.19 tags in th

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Heiner Kallweit
On 13.01.2019 17:01, Marc Haber wrote: > On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: >> On 12.01.2019 21:08, Marc Haber wrote: >>> I am writing to all people who have commits in r8169.c between the v4.18 >>> and v4.19 tags in the Linux kernel. Please ignore as appropriate. If >

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Heiner Kallweit
On 26.01.2019 14:56, Marc Haber wrote: > On Fri, Jan 25, 2019 at 07:22:36PM +0100, Heiner Kallweit wrote: >> Then I'm slowly running out of ideas. New in 4.19 is a check for invalid >> WoL flags, but usually the caller should warn if -EINVAL is returned. >> Nevertheless, could you try the following

Re: WoL broken in r8169.c since kernel 4.19

2019-01-26 Thread Marc Haber
On Fri, Jan 25, 2019 at 07:22:36PM +0100, Heiner Kallweit wrote: > Then I'm slowly running out of ideas. New in 4.19 is a check for invalid > WoL flags, but usually the caller should warn if -EINVAL is returned. > Nevertheless, could you try the following and check whether the warning > is triggere

[PATCH] iwlwifi: Use kmemdup instead of duplicating its function

2019-01-26 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwl

Re: [PATCH bpf-next v3 03/16] bpf: verifier support JMP32

2019-01-26 Thread Jiong Wang
Daniel Borkmann writes: > On 01/25/2019 01:10 AM, Jiong Wang wrote: >> This patch teach verifier about the new BPF_JMP32 instruction class. >> Verifier need to treat it similar as the existing BPF_JMP class. >> A BPF_JMP32 insn needs to go through all checks that have been done on >> BPF_JMP. >>

Re: [RFC v4 00/19] batman-adv: netlink restructuring, part 2

2019-01-26 Thread Sven Eckelmann
On Saturday, 19 January 2019 16.56.07 CET Sven Eckelmann wrote: [...] > There were also two topics which were not yet really discussed and thus > these requests (from Linus) were not yet implemented: @Jiri, @Linus maybe you can discuss these topics further and select the correct solution. > * co

[PATCH net-next] Documentation: net: phy: switch documentation to rst format

2019-01-26 Thread Heiner Kallweit
Switch phylib documentation to rst format. Signed-off-by: Heiner Kallweit --- Documentation/networking/index.rst | 1 + Documentation/networking/phy.rst | 447 + Documentation/networking/phy.txt | 429 --- 3 files changed, 448 insertions(

[PATCH net-next 2/2] r8169: enable EEE per default on RTL8168f

2019-01-26 Thread Heiner Kallweit
Enable EEE per default on RTL8168f. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 35 ++-- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 4572de

[PATCH net-next 1/2] r8169: add EEE support for RTL8168f

2019-01-26 Thread Heiner Kallweit
Add EEE support for RTL8168f to the recently added EEE handling framework in the driver. This patch leaves the chip defaults, means EEE typically is disabled initially and it's up to the user to enable it via ethtool. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 47 +

Re: [PATCH RFC 3/3] udp: Support UDP fraglist GRO/GSO.

2019-01-26 Thread Paolo Abeni
On Fri, 2019-01-25 at 08:58 +0100, Steffen Klassert wrote: > > Finally this will cause GRO/GSO for local UDP packets delivery to non > > GSO_SEGMENT sockets. That could be possibly a win or a regression: we > > save on netfilter/IP stack traversal, but we add additional work, some > > performances

[PATCH net-next 0/2] r8169: add EEE support for RTL8168f

2019-01-26 Thread Heiner Kallweit
This series adds EEE support for RTL8168f. Again first patch adds the support, and second patch enables EEE per default. Heiner Kallweit (2): r8169: add EEE support for RTL8168f r8169: enable EEE per default on RTL8168f drivers/net/ethernet/realtek/r8169.c | 80 +---

[PATCH net 2/3] net: hns: Restart autoneg need return failed when autoneg off

2019-01-26 Thread Peng Li
From: Yonglong Liu The hns driver of earlier devices, when autoneg off, restart autoneg will return -EINVAL, so make the hns driver for the latest devices do the same. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 16 +---

[PATCH net 3/3] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol

2019-01-26 Thread Peng Li
From: Yonglong Liu When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li --- drivers/n

[PATCH net 1/3] net: hns: Fix for missing of_node_put() after of_parse_phandle()

2019-01-26 Thread Peng Li
From: Yonglong Liu In hns enet driver, we use of_parse_handle() to get hold of the device node related to "ae-handle" but we have missed to put the node reference using of_node_put() after we are done using the node. This patch fixes it. Note: This problem is stated in Link: https://lkml.org/lkm

[PATCH net 0/3] net: hns: code optimizations & bugfixes for HNS driver

2019-01-26 Thread Peng Li
This patchset includes bugfixes and code optimizations for the HNS ethernet controller driver Yonglong Liu (3): net: hns: Fix for missing of_node_put() after of_parse_phandle() net: hns: Restart autoneg need return failed when autoneg off net: hns: Fix wrong read accesses via Clause 45 MDIO

Re: Clang warnings in net/phonet

2019-01-26 Thread Nathan Chancellor
On Mon, Jan 07, 2019 at 07:54:20PM -0700, Nathan Chancellor wrote: > Hi all, > > When building the kernel with Clang, this warning comes up in net/phonet. > > net/phonet/pep.c:224:16: warning: array index 1 is past the end of the array > (which contains 1 element) [-Warray-bounds] > ph->