From: Willem de Bruijn
Date: Fri, 25 Jan 2019 11:17:23 -0500
> From: Willem de Bruijn
>
> Accept MSG_ZEROCOPY in all the TCP states that allow sendmsg. Remove
> the explicit check for ESTABLISHED and CLOSE_WAIT states.
>
> This requires correctly handling zerocopy state (uarg, sk_zckey) in
> a
On Fri, Jan 25, 2019 at 10:17:28PM -0800, Jakub Kicinski wrote:
> On Fri, 25 Jan 2019 21:55:30 -0800, Alexei Starovoitov wrote:
> > On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote:
> > > Hi!
> > >
> > > The tools/testing/selftests/bpf/test_verifier.c file is
> > > way too large, and
On Fri, 25 Jan 2019 21:55:30 -0800, Alexei Starovoitov wrote:
> On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote:
> > Hi!
> >
> > The tools/testing/selftests/bpf/test_verifier.c file is
> > way too large, and since most people add their at the
> > end of the list it's very prone to c
From: YueHaibing
Date: Fri, 25 Jan 2019 02:28:59 +
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_
From: Heiner Kallweit
Date: Fri, 25 Jan 2019 20:37:30 +0100
> This series adds general EEE support to be used with ethtool.
> In addition it implements EEE for chip versions from RTL8168g.
> The first patch leaves the default chip settings and the
> second enables EEE per default. This allows us
On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote:
> Hi!
>
> The tools/testing/selftests/bpf/test_verifier.c file is
> way too large, and since most people add their at the
> end of the list it's very prone to conflicts.
>
> Break it up in the simplest possible way - slice the
> arra
From: Peter Oskolkov
Date: Tue, 22 Jan 2019 10:02:49 -0800
> Currently, IPv6 defragmentation code drops non-last fragments that
> are smaller than 1280 bytes: see
> commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu")
>
> This behavior is not specified in IPv6 RFCs and
On Fri, Jan 25, 2019 at 11:20:57AM +0100, Arnaldo Carvalho de Melo wrote:
> # bpftool version
> bpftool v5.0.0-rc3
> #
>
> # bpftool prog | tail -6
> 309: tracepoint name sys_enter tag 819967866022f1e1 gpl
> loaded_at 2019-01-25T11:05:41+0100 uid 0
> xlated 528B jited 38
From: Julian Wiedmann
Date: Fri, 25 Jan 2019 15:44:15 +0100
> please apply a first batch of qeth patches for net-next, primarily touching
> the
> net_device parts of the driver.
> In addition to the usual refactoring & code consolidation, patch 7 makes use
> of
> netif_device_detach() to let th
From: Saeed Mahameed
Date: Fri, 25 Jan 2019 12:18:10 -0800
> This series provides some misc updates to mlx5 driver.
> For more information please see tag log below.
>
> Please pull and let me know if there is any problem.
Pulled, thanks.
From: Heiner Kallweit
Date: Fri, 25 Jan 2019 21:08:24 +0100
> Recent changes to the phylib API
> - removed phy_stop_interrupts
> - replaced phy_start_interrupts with phy_request_interrupt
> - moved some functionality from phy_connect() and phy_disconnect()
> to phy_start() and phy_stop() respec
On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote:
> tty_set_termios() has the following WARMN_ON which can be triggered with a
> syscall to invoke TIOCGETD __NR_ioctl.
>
> WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY &&
> tty->driver->subtype == PTY_TYPE_MASTER);
> Re
On Fri, Jan 25, 2019 at 12:21 PM Palmer Dabbelt wrote:
> Jim, would you be opposed to something like this?
This looks OK to me.
> +builtin_define_with_int_value ("__riscv_tune_misaligned_load_cost",
> +
> riscv_tune_info->slow_unaligned_access ? 102
On Sat, Jan 26, 2019 at 1:43 AM Jann Horn wrote:
> On Sat, Jan 26, 2019 at 12:44 AM Alexei Starovoitov
> wrote:
> >
> > On Fri, Jan 25, 2019 at 02:51:12PM -0800, Paul E. McKenney wrote:
> > > > >
> > > > > So no more than (say) 100 milliseconds?
> > > >
> > > > Depends on RLIMIT_MEMLOCK and on ho
On 01/25, Song Liu wrote:
> On Thu, Jan 24, 2019 at 8:52 AM Stanislav Fomichev wrote:
> >
> > Use existing pkt_v4 and pkt_v6 to make sure flow_keys are what we want.
> >
> > Also, add new bpf_flow_load routine (and flow_dissector_load.h header)
> > that loads bpf_flow.o program and does all requir
On 01/25, Song Liu wrote:
> On Thu, Jan 24, 2019 at 8:53 AM Stanislav Fomichev wrote:
> >
> > The input is packet data, the output is struct bpf_flow_key. This should
> > make it easy to test flow dissector programs without elaborate
> > setup.
> >
> > Signed-off-by: Stanislav Fomichev
> > ---
>
On Sat, Jan 26, 2019 at 12:44 AM Alexei Starovoitov
wrote:
>
> On Fri, Jan 25, 2019 at 02:51:12PM -0800, Paul E. McKenney wrote:
> > > >
> > > > So no more than (say) 100 milliseconds?
> > >
> > > Depends on RLIMIT_MEMLOCK and on how hard userspace is trying to make
> > > things slow, I guess - if
On Thu, Jan 24, 2019 at 8:52 AM Stanislav Fomichev wrote:
>
> Use existing pkt_v4 and pkt_v6 to make sure flow_keys are what we want.
>
> Also, add new bpf_flow_load routine (and flow_dissector_load.h header)
> that loads bpf_flow.o program and does all required setup.
>
> Signed-off-by: Stanislav
On 01/25/2019 01:10 AM, Jiong Wang wrote:
> This patch teach verifier about the new BPF_JMP32 instruction class.
> Verifier need to treat it similar as the existing BPF_JMP class.
> A BPF_JMP32 insn needs to go through all checks that have been done on
> BPF_JMP.
>
> Also, verifier is doing runtim
On Thu, Jan 24, 2019 at 8:53 AM Stanislav Fomichev wrote:
>
> The input is packet data, the output is struct bpf_flow_key. This should
> make it easy to test flow dissector programs without elaborate
> setup.
>
> Signed-off-by: Stanislav Fomichev
> ---
> include/linux/bpf.h | 3 ++
> net/bpf/te
On Thu, Jan 24, 2019 at 8:51 AM Stanislav Fomichev wrote:
>
> This way, we can reuse it for flow dissector in BPF_PROG_TEST_RUN.
>
> No functional changes.
>
> Signed-off-by: Stanislav Fomichev
Acked-by: Song Liu
> ---
> include/linux/skbuff.h| 5 +++
> net/core/flow_dissector.c | 92 +++
On 1/24/19 12:34 PM, Peter Oskolkov wrote:
> This patchset implements BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap
> BPF helper. It enables BPF programs (specifically, BPF_PROG_TYPE_LWT_IN
> and BPF_PROG_TYPE_LWT_XMIT prog types) to add IP encapsulation headers
> to packets (e.g. IP/GRE, GUE, IPIP).
This is a resend of the previous pull request with the qed changes
reverted.
1) Count ttl-dropped frames properly in mac80211, from Bob Copeland.
2) Integer overflow in ktime handling of bcm can code, from Oliver
Hartkopp.
3) Fix RX desc handling wrt. hw checksumming in ravb, from Simon
On Fri, Jan 25, 2019 at 11:23:12AM +0100, Peter Zijlstra wrote:
> On Thu, Jan 24, 2019 at 03:58:59PM -0800, Alexei Starovoitov wrote:
> > On Thu, Jan 24, 2019 at 07:01:09PM +0100, Peter Zijlstra wrote:
>
> > > And this would again be the moment where I go pester you about the BPF
> > > memory mode
On Fri, Jan 25, 2019 at 02:51:12PM -0800, Paul E. McKenney wrote:
> > >
> > > So no more than (say) 100 milliseconds?
> >
> > Depends on RLIMIT_MEMLOCK and on how hard userspace is trying to make
> > things slow, I guess - if userspace manages to create a hashtable,
> > with a few dozen megabytes
On Fri, Jan 25, 2019 at 10:10:57AM +0100, Peter Zijlstra wrote:
> On Thu, Jan 24, 2019 at 03:58:59PM -0800, Alexei Starovoitov wrote:
> > On Thu, Jan 24, 2019 at 07:01:09PM +0100, Peter Zijlstra wrote:
> > >
> > > Thanks for having kernel/locking people on Cc...
> > >
> > > On Wed, Jan 23, 2019 a
From: Linus Torvalds
Date: Fri, 25 Jan 2019 13:15:37 -1000
> You don't even *mention* the changes to the qlogic driver that are
> completely new and over a thousand lines.
It's error recovery code and I trust the judgment of the qlogic folks
that this was appropriate to add.
I am more than hap
From: Linus Torvalds
Date: Fri, 25 Jan 2019 13:25:22 -1000
> No way is this appropriate. Get rid of it.
Ok, consider it done.
tty_set_termios() has the following WARMN_ON which can be triggered with a
syscall to invoke TIOCGETD __NR_ioctl.
WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY &&
tty->driver->subtype == PTY_TYPE_MASTER);
Reference:
https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd0
This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0.
The original diagnosis was incorrect: it appears that the NIC had
PHY polling mode enabled, which meant that it overwrote the PHYs
advertisement register during negotiation.
Signed-off-by: Russell King
---
drivers/net/phy/marvell.c |
On Fri, Jan 25, 2019 at 1:15 PM Linus Torvalds
wrote:
>
> You don't even *mention* the changes to the qlogic driver that are
> completely new and over a thousand lines.
They look like completely new error handling and recovery code. Very
much new development, not fixes.
And this is not some new
Hi!
The tools/testing/selftests/bpf/test_verifier.c file is
way too large, and since most people add their at the
end of the list it's very prone to conflicts.
Break it up in the simplest possible way - slice the
array up into smaller C files and include them in the
right spot.
Tested:
$ make -C
On Fri, Jan 25, 2019 at 05:18:12PM +0100, Jann Horn wrote:
> On Fri, Jan 25, 2019 at 5:12 AM Paul E. McKenney
> wrote:
> > On Fri, Jan 25, 2019 at 02:46:55AM +0100, Jann Horn wrote:
> > > On Fri, Jan 25, 2019 at 2:22 AM Paul E. McKenney
> > > wrote:
> > > > On Thu, Jan 24, 2019 at 04:05:16PM -0
test_verifier.c has grown to be very long (almost 16 kLoC),
and it is very conflict prone since we always add tests at
the end.
Try to break it apart a little bit. Allow test snippets
to be defined in separate files and include them automatically
into the huge test array.
Signed-off-by: Jakub Ki
On Fri, Jan 25, 2019 at 9:58 AM David Miller wrote:
>
> Please pull, thanks a lot!
Why?
You don't even *mention* the changes to the qlogic driver that are
completely new and over a thousand lines.
What is going on here? There's no explanation for these huge "fixes"
that aren't even mentioned
On Fri, Jan 25, 2019 at 5:03 AM Ruhl, Michael J
wrote:
>
> Hi,
>
> While running a 5.0.0.rc1 kernel with the LOCKDEP debug configuration turned
> on, and I saw this LOCKDEP error:
...
>
> I saw this on the console while not doing anything on the system (i.e. no
> test were running, or any overt
On Thu, Jan 24, 2019 at 6:49 PM YueHaibing wrote:
>
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
Acked-by: Song Liu
Thanks!
> ---
> tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
> tools/testing/selftests/bpf/test_maps.c | 1 -
> tools/testing/selftests/bpf
> My point still stands, we have an abstraction layer through the i2c core
> which sits between clients and adapters.
>
> If you have a simple read into a buffer transaction (like what we have
> here), then you can provide a safe accessor function that takes care of
> looking at the max_read_len q
On 1/25/19 1:58 PM, René van Dorst wrote:
> Quoting René van Dorst :
>
>> Quoting Florian Fainelli :
>>
>>> On 1/23/19 1:20 PM, René van Dorst wrote:
Without this patch sfp code retries to read the full struct
sfp_eeprom_id
id out of the SFP eeprom. Sizeof(id) is 96 bytes.
My i
Hi Jesper,
On 01/25/2019 01:02 PM, Jesper Dangaard Brouer wrote:
> Add myself as a maintainer for these parts, as I'm responsible
> for adding most of this.
>
> Signed-off-by: Jesper Dangaard Brouer
> ---
> MAINTAINERS |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/MAINTA
Quoting René van Dorst :
Quoting Florian Fainelli :
On 1/23/19 1:20 PM, René van Dorst wrote:
Without this patch sfp code retries to read the full struct sfp_eeprom_id
id out of the SFP eeprom. Sizeof(id) is 96 bytes.
My i2c hardware, Mediatek mt7621, has a rx buffer of 64 bytes.
So sfp_read
On Tue, Jan 22, 2019 at 4:38 PM wrote:
> From: Tonghao Zhang
>
> In some case, we may use multiple pedit actions to modify packets.
just to clarify, this is a matter of choice, right? in other words, it
doesn't buy you extra functionality
> The command shown as below: the last pedit action is e
On Thu, Jan 24, 2019 at 1:47 AM Eli Britstein wrote:
>
> Declare ovs key structures using macros to enable retrieving fields
> information, with no functional change.
>
I am not sure why is this done. Can you explain what are u trying to solve here?
> Signed-off-by: Eli Britstein
> Reviewed-by:
From: Johannes Berg
Same story as before, these use struct ifreq and thus need
to be read with the shorter version to not cause faults.
Cc: sta...@vger.kernel.org
Fixes: f92d4fc95341 ("kill bond_ioctl()")
Signed-off-by: Johannes Berg
---
net/socket.c | 8
1 file changed, 4 insertions(
From: Johannes Berg
This reverts commit bf4405737f9f ("kill dev_ifsioc()").
This wasn't really unused as implied by the original commit,
it still handles the copy to/from user differently, and the
commit thus caused issues such as
https://bugzilla.kernel.org/show_bug.cgi?id=199469
and
https:
From: Johannes Berg
This reverts commit 1cebf8f143c2 ("socket: fix struct ifreq
size in compat ioctl"), it's a bugfix for another commit that
I'll revert next.
This is not a 'perfect' revert, I'm keeping some coding style
intact rather than revert to the state with indentation errors.
Cc: sta..
Back a long time ago, I already fixed a few of these by passing
the size of the struct ifreq to do_sock_ioctl(). However, Robert
found more cases, and now it won't be as simple because we'd have
to pass that down all the way to e.g. bond_do_ioctl() which isn't
really feasible.
Therefore, restore t
From: Johannes Berg
As reported by Robert O'Callahan in
https://bugzilla.kernel.org/show_bug.cgi?id=202273
reverting the previous changes in this area broke
the SIOCGIFNAME ioctl in compat again (I'd previously
fixed it after his previous report of breakage in
https://bugzilla.kernel.org/show_bug
On Tue, 15 Jan 2019 08:06:47 PST (-0800), bjorn.to...@gmail.com wrote:
Den tis 15 jan. 2019 kl 16:39 skrev Christoph Hellwig :
Hmm, while the RISC-V spec requires misaligned load/store support,
who says they are efficient? Maybe add a little comment that says
on which cpus they are efficient.
mlx5e_grp_sw_update_stats can be called from two threads,
1) ndo_get_stats64
2) get_ethtool_stats
For this reason and to minimize concurrency issue impact on 64bit machines
mlx5e_grp_sw_update_stats folds the software stats into a temporary
variable then copies it to the global driver stats, both
From: Jason Gunthorpe
This confusing construction confuses the compiler which can't see
that flow is initialized if !err:
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function
`mlx5e_configure_flower`
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:2727:28: warning:
`flow` may be used un
From: Tariq Toukan
This behavior is already adopted for all other cases in the cited patch.
The representor's functions were missed, here we modify the them to
behave similarly.
Fixes: 8bfaf07f7806 ("net/mlx5e: Present SW stats when state is not opened")
Signed-off-by: Tariq Toukan
Signed-off-b
From: Moshe Shemesh
Currently we have one cpu in XPS cpumask per tx queue, this is good
enough for default configuration where there is a tx queue per cpu.
However, once configuration changes to use less tx queues, part of the
cpus are not XPS-mapped and so the select queue decision falls back to
From: Tariq Toukan
In the non-linear SKB memory scheme of Striding RQ, a packet header
could cross page boundary. This requires special care in fast path
that costs LoC, additional runtime instructions and branches.
It could happen when the header (up to 256B) does not fit in
a single stride. Av
Representors software stats are basic, this patch is reusing the
mlx5e_fold_sw_stats in representors, which sums up the basic stats64 for a
mlx5e netdevice.
Fixes: 8bfaf07f7806 ("net/mlx5e: Present SW stats when state is not opened")
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellano
From: Or Gerlitz
We were not tracking flow tables so far, add it up.
Signed-off-by: Or Gerlitz
Signed-off-by: Saeed Mahameed
---
.../mellanox/mlx5/core/diag/fs_tracepoint.c | 2 ++
.../mellanox/mlx5/core/diag/fs_tracepoint.h | 35 +++
.../net/ethernet/mellanox/mlx5/core/f
From: Tariq Toukan
Only the Receive CQ makes use of these fields. Take them
out into a separate struct and save space in the generic
CQ structure.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 15 ++-
.../net/ethernet/mellanox/m
Hi Dave,
This series provides some misc updates to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
Thanks,
Saeed.
---
The following changes since commit 30e5c2c6bf285d93dee4c45f23da95d7d50b125a:
net: Revert devlink health chang
Recent changes to the phylib API
- removed phy_stop_interrupts
- replaced phy_start_interrupts with phy_request_interrupt
- moved some functionality from phy_connect() and phy_disconnect()
to phy_start() and phy_stop() respectively.
Reflect these changes in the documentation.
Signed-off-by: Hein
From: Shay Agroskin
MLX5E_PFLAG_* definitions were changed from bitmask to enumerated
values. However, in mlx5e_open_rq(), the proper API (MLX5E_GET_PFLAG macro)
was not used to read the flag value of MLX5E_PFLAG_RX_NO_CSUM_COMPLETE.
Fixed it.
Fixes: 8ff57c18e9f6 ("net/mlx5e: Improve ethtool pri
From: Or Gerlitz
With VF LAG commit 491c37e49b48 "net/mlx5e: In case of LAG, one switch
parent id is used for all representors", both uplinks and all the VFs
(on both of them) get the same switchdev id.
This cause the provisioning system method to identify the rep of a given
VF from the parent P
From: Moni Shoua
The lock in qp_table might be taken from process context or from
interrupt context. This may lead to a deadlock unless it is taken with
IRQs disabled.
Discovered by lockdep
WARNING: inconsistent lock state
4.20.0-rc6
Hi Dave,
This series introduces some fixes to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
For -stable v4.13
('net/mlx5e: Allow MAC invalidation while spoofchk is ON')
For -stable v4.18
('Revert "net/mlx5e: E-Switch, Initialize
From: Or Gerlitz
It turns out that libvirt uses 0-vid as a default if no vlan was
set for the guest (which is the case for switchdev mode) and errs
if we disallow that:
error: Failed to start domain vm75
error: Cannot set interface MAC/vlanid to 6a:66:2d:48:92:c2/0 \
for ifname e
From: Aya Levin
Prior to this patch the driver prohibited spoof checking on invalid MAC.
Now the user can set this configuration if it wishes to.
This is required since libvirt might invalidate the VF Mac by setting it
to zero, while spoofcheck is ON.
Fixes: 1ab2068a4c66 ("net/mlx5: Implement v
From: Bodong Wang
This reverts commit 5f5991f36dce1e69dd8bd7495763eec2e28f08e7.
With the original commit, eswitch instance will not be initialized for
a function which is vport group manager but not eswitch manager such as
host PF on SmartNIC (BlueField) card. This will result in a kernel crash
1) Count ttl-dropped frames properly in mac80211, from Bob Copeland.
2) Integer overflow in ktime handling of bcm can code, from Oliver
Hartkopp.
3) Fix RX desc handling wrt. hw checksumming in ravb, from Simon
Horman.
4) Various hash key fixes in hv_netvsc, from Haiyang Zhang.
5) Use a
Hi,
thanks for taking a shot at the eBPF JIT; this will be very useful.
On Tue, 15 Jan 2019, Björn Töpel wrote:
> * I've added "HAVE_EFFICIENT_UNALIGNED_ACCESS" to
> arch/riscv/Kconfig. Is this assumption correct?
From a hardware point of view, this is not the case on the Linux-capable
RISC-
Enable EEE per default on chip versions from RTL8168g.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index f46bf1187..9e335d2
This patch adds the general framework to deal with EEE in this driver
plus EEE support for chip versions from RTL8168g. We don't touch the
default chip settings, therefore EEE will usually be disabled and it's
up to the user to enable it.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/r
From: Johannes Berg
Date: Fri, 25 Jan 2019 20:34:57 +0100
> On Fri, 2019-01-25 at 11:04 -0800, David Miller wrote:
>>
>> > Dave, it looks like we're the only users of this right now,
>> > so let me know if you'd prefer I take it through my tree.
>> > Also, this conflicts with the fix I just made
This series adds general EEE support to be used with ethtool.
In addition it implements EEE for chip versions from RTL8168g.
The first patch leaves the default chip settings and the
second enables EEE per default. This allows us to revert patch 2
w/o removing EEE support completely if we should fac
On Fri, 2019-01-25 at 11:04 -0800, David Miller wrote:
>
> > Dave, it looks like we're the only users of this right now,
> > so let me know if you'd prefer I take it through my tree.
> > Also, this conflicts with the fix I just made to the place
> > where I got it wrong, but obviously the resoluti
On Fri, 25 Jan 2019 10:48:38 -0800
Florian Fainelli wrote:
> On 1/24/19 11:39 AM, Marek Behun wrote:
> > On Thu, 24 Jan 2019 11:27:54 -0800
> > Florian Fainelli wrote:
> >
> >> On 1/24/19 11:24 AM, Marek Behun wrote:
> >>> On Thu, 24 Jan 2019 19:11:59 +0100
> >>> Andrew Lunn wrote:
> >>>
On 25.01.2019 20:07, Andrew Lunn wrote:
>> Andrew, for my understanding: What do you think is wrong with the
>> alignment requirement? It was introduced because we do a 32 bit access
>> to the start address of the array and want to avoid an unaligned access.
>
> Hi Heiner
>
> Because you are doi
On Fri, Jan 25, 2019 at 11:00:46AM -0800, Florian Fainelli wrote:
> > +++ b/drivers/net/phy/phylink.c
> > @@ -409,7 +409,8 @@ static void phylink_resolve(struct work_struct *w)
> >
> > case MLO_AN_FIXED:
> > phylink_get_fixed_state(pl, &link_state);
> > -
> Andrew, for my understanding: What do you think is wrong with the
> alignment requirement? It was introduced because we do a 32 bit access
> to the start address of the array and want to avoid an unaligned access.
Hi Heiner
Because you are doing pointer aliasing, the compiler will by default
g
From: Johannes Berg
Date: Fri, 25 Jan 2019 10:08:28 +0100
> From: Johannes Berg
>
> In typical cases, there's no need to pass both the maxattr
> and the policy array pointer, as the maxattr should just be
> ARRAY_SIZE(policy) - 1. Therefore, to be less error prone,
> just remove the maxattr arg
On Tue, 15 Jan 2019 08:03:18 PST (-0800), bjorn.to...@gmail.com wrote:
Den tis 15 jan. 2019 kl 16:40 skrev Christoph Hellwig :
Hi Björn,
at least for me patch 3 didn't make it to the list.
Hmm, held back: "Your message to linux-riscv awaits moderator
approval". Exceeded the 40k limit.
I'll
From: Johannes Berg
Date: Fri, 25 Jan 2019 14:20:40 +0100
> Here are 8 fixes for the current cycle, nothing that seems out of
> the ordinary.
>
> Please pull and let me know if there's any problem.
Pulled, thanks Johannes.
On 1/22/19 6:10 PM, Andrew Lunn wrote:
>> Hi Andrew,
>>
>> I tested the patch and it has an issue that prevents the carrier from turning
>> on. I think it's caused by the change from using link_state to
>> phy->phy_state,
>> as later in the same function the link_state attributes are read when
>>
On Fri, 2019-01-25 at 10:31 -0800, Eric Dumazet wrote:
>
> On 01/25/2019 10:22 AM, Saeed Mahameed wrote:
> > On Tue, 2019-01-22 at 13:30 -0800, Cong Wang wrote:
> > > On Fri, Jan 18, 2019 at 4:25 PM Saeed Mahameed <
> > > sae...@mellanox.com>
> > > wrote:
> > > > From: Cong Wang
> > >
> > > I do
From: Eran Ben Elisha
Date: Fri, 25 Jan 2019 09:16:16 +
> On 1/25/2019 8:08 AM, David Miller wrote:
>> I'll do it once I have Eran's confirmation.
>
> Note that you will also have to revert ARM compilation fix which was
> accepted on top.
> https://patchwork.ozlabs.org/patch/1029047/
Thank
TCP receiver today tries not to delay the ACKs to speed up the initial
slow start (a.k.a QUICK ACK mechanism). However the previous design
does not work well with modern TCP applications that starts with an
application-level handshake. For example, a HTTPs server often
receives the SSL hello and re
Instead of using pingpong as a single bit information, we refactor the
code to treat it as a counter. When interactive session is detected,
we set pingpong count to TCP_PINGPONG_THRESH. And when pingpong count
is >= TCP_PINGPONG_THRESH, we consider the session in pingpong mode.
This patch is a pur
In order to be more confident about an on-going interactive session, we
increment pingpong count by 1 for every interactive transaction and we
adjust TCP_PINGPONG_THRESH to 3.
This means, we only consider a session in pingpong mode after we see 3
interactive transactions, and start to activate dela
On Fri, Jan 25, 2019 at 07:11:28PM +0100, Heiner Kallweit wrote:
> On 25.01.2019 16:00, Andrew Lunn wrote:
> > On Fri, Jan 25, 2019 at 12:35:10PM +, Carlo Caione wrote:
> >> Libphy provides a standard set of helpers to access the MMD PHY
> >> registers. Use those instead of relying on custom dr
On 1/24/19 11:39 AM, Marek Behun wrote:
> On Thu, 24 Jan 2019 11:27:54 -0800
> Florian Fainelli wrote:
>
>> On 1/24/19 11:24 AM, Marek Behun wrote:
>>> On Thu, 24 Jan 2019 19:11:59 +0100
>>> Andrew Lunn wrote:
>>>
On Thu, Jan 24, 2019 at 07:04:51PM +0100, Marek Behun wrote:
> What
On 1/25/19 4:35 AM, Carlo Caione wrote:
> Libphy provides a standard set of helpers to access the MMD PHY
> registers. Use those instead of relying on custom driver-specific
> functions.
>
> Signed-off-by: Carlo Caione
Reviewed-by: Florian Fainelli
--
Florian
On 2019-01-25 11:48 a.m., Russell King - ARM Linux admin wrote:
> If you don't have any means to reset the card like that, then the only
> workaround is to reduce the maximum speed - and avoid going to 1.8V
> signalling mode.
There is no power controller on espressobin. The regulator only
switches
Hi Miquel,
On 1/25/19 1:55 AM, Miquel Raynal wrote:
> The user might apply a specific switch configuration, with specific
> forwarding rules, VLAN, bridges, etc.
>
> During suspend to RAM the switch power will be turned off and the
> switch will lost its configuration. In an attempt to bring S2RA
On 25.01.2019 11:18, Thierry Reding wrote:
> From: Thierry Reding
>
> If the system was booted using a device tree and if the device tree
> contains a MAC address, use it instead of reading one from the EEPROM.
> This is useful in situations where the EEPROM isn't properly programmed
> or where t
On 01/25/2019 10:22 AM, Saeed Mahameed wrote:
> On Tue, 2019-01-22 at 13:30 -0800, Cong Wang wrote:
>> On Fri, Jan 18, 2019 at 4:25 PM Saeed Mahameed
>> wrote:
>>> From: Cong Wang
>>
>> I don't know why you want to make me as the author here, but I never
>> agree on _your_ updates on my previo
On 25.01.2019 15:57, Andrew Lunn wrote:
> On Fri, Jan 25, 2019 at 11:18:14AM +0100, Thierry Reding wrote:
>> From: Thierry Reding
>>
>> If the system was booted using a device tree and if the device tree
>> contains a MAC address, use it instead of reading one from the EEPROM.
>> This is useful in
On 25.01.2019 13:02, Marc Haber wrote:
> On Fri, Jan 25, 2019 at 07:49:56AM +0100, Heiner Kallweit wrote:
>> thanks a lot for the detailed analysis. That this ethtool sequence
>>
>> ethtool -s wol d
>> ethtool -s wol g
>>
>> helps makes me think that the following patch should help too.
>> Could
On Tue, 2019-01-22 at 13:30 -0800, Cong Wang wrote:
> On Fri, Jan 18, 2019 at 4:25 PM Saeed Mahameed
> wrote:
> > From: Cong Wang
>
> I don't know why you want to make me as the author here, but I never
> agree on _your_ updates on my previous patch.
>
> Please see below.
>
sorry, i just took
On Mon, 2019-01-21 at 18:22 +, Jason Gunthorpe wrote:
> On Mon, Jan 21, 2019 at 10:12:58AM -0800, Saeed Mahameed wrote:
> > On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe
> > wrote:
> > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote:
> > > > You need to do one of two things
On 25.01.2019 16:00, Andrew Lunn wrote:
> On Fri, Jan 25, 2019 at 12:35:10PM +, Carlo Caione wrote:
>> Libphy provides a standard set of helpers to access the MMD PHY
>> registers. Use those instead of relying on custom driver-specific
>> functions.
>
> Hi Carlo
>
> Maybe deja vu, but i thoug
On Thu, Jan 24, 2019 at 4:30 AM Leon Romanovsky wrote:
>
> On Fri, Jan 18, 2019 at 04:33:09PM -0800, Saeed Mahameed wrote:
> > Hi all,
> >
> > This series includes updates to mlx5-next shared branch.
> >
> > 1) from Jason, improve mlx5_cmd_exec_cb async API to be safer
> > 2) from Maxim Mikityansk
- Ido Schimmel wrote:
> While iproute2 correctly uses ifinfomsg struct as the ancillary header
> when requesting an FDB dump on old kernels, it sets the message type to
> RTM_GETLINK. This results in wrong reply being returned.
>
> Fix this by using RTM_GETNEIGH instead.
>
> Before:
> $ br
1 - 100 of 180 matches
Mail list logo
