Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-18 Thread Leon Romanovsky
On Fri, Jan 18, 2019 at 04:33:13PM -0800, Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > As there is no user of mlx5_write64 that passes a spinlock to > mlx5_write64, remove this functionality and simplify the function. > > Signed-off-by: Maxim Mikityanskiy > Reviewed-by: Eran Ben Elisha >

Re: [PATCH RFC 1/4] net: dsa: microchip: convert KSZ9477 SPI driver to use regmap

2019-01-18 Thread Marek Vasut
On 1/18/19 9:32 PM, tristram...@microchip.com wrote: >>> These extremely patches look similar to what I posted here before: >>> >>> https://patchwork.ozlabs.org/cover/1017222/ >>> >>> But the authorship has changed. Why ? >> >> There seems to be explanation in 0/4. >> >> Tristram: if you started fr

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-18 Thread Marek Vasut
On 1/18/19 9:25 PM, tristram...@microchip.com wrote: >>> +#define REG_SIZE 0x8000 >>> + >>> +#define I2C_REGMAP_VAL 8 >>> +#define I2C_REGMAP_REG 16 >>> + >>> +#define KSZ_REGMAP_COMMON(n, width) >> \ >>> +{

[PATCH bpf-next] bpf: use the proper optlen when doing strncpy in bpf_getsockopt()

2019-01-18 Thread Yafang Shao
As the last character of optval will be set with 0, so just copying (optlen - 1) characters is enough. Signed-off-by: Yafang Shao --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 447dd1b..7a4de22 100644 --- a/ne

[PATCH bpf-next] bpf: sock recvbuff must be limited by rmem_max in bpf_setsockopt()

2019-01-18 Thread Yafang Shao
When sock recvbuff is set by bpf_setsockopt(), the value must by limited by rmem_max. It is the same with sendbuff. Signed-off-by: Yafang Shao --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index 447dd1b..f30b58a 100644 --- a/net

[PATCH v2] ip_tunnel: Make none-tunnel-dst tunnel port work with lwtunnel

2019-01-18 Thread wenxu
From: wenxu ip l add dev tun type gretap key 1000 ip a a dev tun 10.0.0.1/24 Packets with tun-id 1000 can be recived by tun dev. But packet can't be sent through dev tun for non-tunnel-dst With this patch: tunnel-dst can be get through lwtunnel like beflow: ip r a 10.0.0.7 encap ip dst 172.168.

Re: [PATCH v2 13/29] arch: add split IPC system calls where needed

2019-01-18 Thread Gabriel Paubert
On Fri, Jan 18, 2019 at 05:18:19PM +0100, Arnd Bergmann wrote: > The IPC system call handling is highly inconsistent across architectures, > some use sys_ipc, some use separate calls, and some use both. We also > have some architectures that require passing IPC_64 in the flags, and > others that s

Re: [pull request][net 0/4] Mellanox, mlx5 fixes 2019-01-18

2019-01-18 Thread David Miller
From: Saeed Mahameed Date: Fri, 18 Jan 2019 16:25:19 -0800 > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. I'll pull this, thanks! > For -stable v4.18 > ('net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames') > > The pat

Shooting and Retouching

2019-01-18 Thread Jenna
Want to shoot photos for your products and retouching also i needed? We are studio special for photo shooting and retouching. For your photos: White background, Optimized for Shopify, Retouching included Revisions accepted We can also give you dedicate editing service for your photos Let me kn

Re: selftests/bpf/test_netcnt failed on i386 - ibbpf: failed to create map (name: 'percpu_netcnt'): Invalid argument

2019-01-18 Thread Roman Gushchin
On Fri, Jan 18, 2019 at 01:39:24PM +0530, Naresh Kamboju wrote: > Newly added test case bpf test_netcnt failed on i386 and qemu_i386 on > mainline and -next kernel. > Here we are running i386 kernel on x86_64 device. > Pass on x86_64, arm64 and arm. > > Am i missing any pre required Kconfigs ? Hi

RE: [PATCH hyperv-fixes,3/3] Fix hash key value reset after other ops

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > Changing mtu, channels, or buffer sizes ops call to netvsc_attach(), > rndis_set_subchannel(), which always reset the hash key to default > value. That will override hash key changed previously. This patch > fixes the problem by save

RE: [PATCH hyperv-fixes,2/3] Refactor assignments of struct netvsc_device_info

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > These assignments occur in multiple places. The patch refactor them > to a function for simplicity. It also puts the struct to heap area > for future expension. > > Signed-off-by: Haiyang Zhang > --- > drivers/net/hyperv/netvsc_d

RE: [PATCH hyperv-fixes,1/3] Fix ethtool change hash key error

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > Hyper-V hosts require us to disable RSS before changing RSS key, > otherwise the changing request will fail. This patch fixes the > coding error. > > Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") > Reported

Re: [PATCH] net: mlx5: don't overwrite pedit action when multiple pedit used

2019-01-18 Thread Saeed Mahameed
On Wed, Jan 16, 2019 at 7:46 PM wrote: > > From: Tonghao Zhang > > In some case, we may use multiple pedit actions to modify packets. > The command shown as below: the last pedit action is effective. > > $ tc filter add dev netdev_rep parent : protocol ip prio 1 \ > flower skip_sw ip

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

2019-01-18 Thread Saeed Mahameed
On Thu, Jan 17, 2019 at 5:19 PM Christoph Paasch wrote: > > Hello, > > On Sun, Jan 6, 2019 at 3:12 AM Saeed Mahameed > wrote: > > > > On Sat, Jan 5, 2019 at 8:35 PM Nikola Ciprich > > wrote: > > > > > > Hi Saeed, > > > > > > > > > > Most likely the same issue, we are finalizing the patch initia

[PATCH mlx5-next 2/4] net/mlx5: Add pci AtomicOps request

2019-01-18 Thread Saeed Mahameed
From: Michael Guralnik Calling pci_enable_atomic_ops_to_root enables AtomicOp requests to pci root port. AtomicOp requests will be enabled only if the completer and all intermediate pci bridges support PCI atomic operations. This, together with appropriate settings in the NVCONFIG should enable

[PATCH mlx5-next 1/4] net/mlx5: Make mlx5_cmd_exec_cb() a safe API

2019-01-18 Thread Saeed Mahameed
From: Jason Gunthorpe APIs that have deferred callbacks should have some kind of cleanup function that callers can use to fence the callbacks. Otherwise things like module unloading can lead to dangling function pointers, or worse. The IB MR code is the only place that calls this function and ha

[PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-18 Thread Saeed Mahameed
From: Maxim Mikityanskiy As there is no user of mlx5_write64 that passes a spinlock to mlx5_write64, remove this functionality and simplify the function. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/qp.c

[PATCH mlx5-next 0/4] mlx5 next misc updates

2019-01-18 Thread Saeed Mahameed
Hi all, This series includes updates to mlx5-next shared branch. 1) from Jason, improve mlx5_cmd_exec_cb async API to be safer 2) from Maxim Mikityanskiy, cleanups for mlx5_write64 doorbell API 3) from Michael Guralnik, Add pci AtomicOps request Thanks, Saeed. --- Jason Gunthorpe (1): net/ml

[PATCH mlx5-next 3/4] net/mlx5: Remove unused MLX5_*_DOORBELL_LOCK macros

2019-01-18 Thread Saeed Mahameed
From: Maxim Mikityanskiy MLX5_*_DOORBELL_LOCK macros provided a way to avoid locking for mlx5_write64 on 64-bit platforms where it's not necessary. Currently all calls to mlx5_write64 don't use a spinlock, so the macros became unused. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Eran Ben Elis

[net 1/4] net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames

2019-01-18 Thread Saeed Mahameed
From: Cong Wang When an ethernet frame is padded to meet the minimum ethernet frame size, the padding octets are not covered by the hardware checksum. Fortunately the padding octets are usually zero's, which don't affect checksum. However, we have a switch which pads non-zero octets, this causes

[net 3/4] net/mlx5e: Fix wrong (zero) TX drop counter indication for representor

2019-01-18 Thread Saeed Mahameed
From: Tariq Toukan For representors, the TX dropped counter is not folded from the per-ring counters. Fix it. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet

[net 2/4] net/mlx5e: Fix wrong error code return on FEC query failure

2019-01-18 Thread Saeed Mahameed
From: Shay Agroskin Advertised and configured FEC query failure resulted in printing wrong error code. Fixes: 6cfa94605091 ("net/mlx5e: Ethtool driver callback for query/set FEC policy") Signed-off-by: Shay Agroskin Reported-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ether

[net 4/4] net/mlx5e: Fix cb_ident duplicate in indirect block register

2019-01-18 Thread Saeed Mahameed
From: Eli Britstein Previously the identifier used for indirect block callback registry and for block rule cb registry (when done via indirect blocks) was the pointer to the tunnel netdev we were interested in receiving updates on. This worked fine if a single PF existed that registered one callb

[pull request][net 0/4] Mellanox, mlx5 fixes 2019-01-18

2019-01-18 Thread Saeed Mahameed
Hi Dave, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. For -stable v4.18 ('net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames') The patch doesn't apply cleanly to 4.18.y, but it is very simple to resolve, what should be the p

Re: [patch 8/9] tools: bpftool: Cleanup license mess

2019-01-18 Thread Alexei Starovoitov
On Fri, Jan 18, 2019 at 12:14:24AM +0100, Thomas Gleixner wrote: > Precise and non-ambiguous license information is important. The recent > relicensing of the bpftools introduced a license conflict. > > The files have now: > > SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause > > and >

Re: [PATCH bpf] bpf: fix inner map masking to prevent oob under speculation

2019-01-18 Thread Alexei Starovoitov
On Thu, Jan 17, 2019 at 04:34:45PM +0100, Daniel Borkmann wrote: > During review I noticed that inner meta map setup for map in > map is buggy in that it does not propagate all needed data > from the reference map which the verifier is later accessing. > > In particular one such case is index mask

DSA incompatible with TI CPSW device model in dual mac mode

2019-01-18 Thread Daniele Orlandi
Hello, I am trying to connect a Marvell switch (88E6172) to an AM3352 ethernet port. In the DSA devicetree description the CPU port has to have an "ethernet" attribute with a reference to a device node. From which it derives the net_device with a call of of_find_net_device_by_node The CP

Re: [PATCH bpf] bpf: pull in pkt_sched.h header for tooling to fix bpftool build

2019-01-18 Thread Alexei Starovoitov
On Thu, Jan 17, 2019 at 07:20:51PM +, Martin Lau wrote: > On Thu, Jan 17, 2019 at 04:15:09PM +0100, Daniel Borkmann wrote: > > Dan reported that bpftool does not compile for him: > > > > $ make tools/bpf > > DESCEND bpf > > > > Auto-detecting system features: > > ..

Re: [PATCH net 0/8] mlxsw: Various fixes

2019-01-18 Thread David Miller
From: Ido Schimmel Date: Fri, 18 Jan 2019 15:57:54 + > This patchset contains small fixes in mlxsw and one fix in the bridge > driver. > > Patches #1-#4 perform small adjustments in PCI and FID code following > recent tests that were performed on the Spectrum-2 ASIC. > > Patch #5 fixes the

[PATCH] wlcore: clean up an indentation issue

2019-01-18 Thread Colin King
From: Colin Ian King There is a goto statement that is missing a tab for indentation. Fix this. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wlcore/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/cmd.c b/drivers/net/wireles

Re: [PATCH net-next 00/12] net: hns3: code optimizations & bugfixes for HNS3 driver

2019-01-18 Thread David Miller
From: Huazhong Tan Date: Fri, 18 Jan 2019 16:13:02 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied.

Re: [PATCH net-next v2 00/11] Devlink health reporting and recovery system

2019-01-18 Thread David Miller
From: Eran Ben Elisha Date: Thu, 17 Jan 2019 23:59:09 +0200 > The health mechanism is targeted for Real Time Alerting, in order to know when > something bad had happened to a PCI device > - Provide alert debug information > - Self healing > - If problem needs vendor support, provide a way to gath

Re: [PATCH] soc: fsl: qbman: avoid race in clearing QMan interrupt

2019-01-18 Thread Li Yang
On Fri, Dec 21, 2018 at 8:43 AM Madalin Bucur wrote: > > By clearing all interrupt sources, not only those that > already occurred, the existing code may acknowledge by > mistake interrupts that occurred after the code checks > for them. > > Signed-off-by: Madalin Bucur > Signed-off-by: Roy Pledg

[PATCH v5] coding-style: Clarify the expectations around bool

2019-01-18 Thread Jason Gunthorpe
There has been some confusion since checkpatch started warning about bool use in structures, and people have been avoiding using it. Many people feel there is still a legitimate place for bool in structures, so provide some guidance on bool usage derived from the entire thread that spawned the che

Re: [PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close

2019-01-18 Thread Andrey Ignatov
Stanislav Fomichev [Fri, 2019-01-18 08:50 -0800]: > On 01/18, Andrey Ignatov wrote: > > Stanislav Fomichev [Thu, 2019-01-17 16:41 -0800]: > > > Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on > > > socket creation and there is no way to know when the socket is being > > > clo

[PATCH v4 2/5] usb: assign ACPI companions for embedded USB devices

2019-01-18 Thread Rajat Jain
From: Dmitry Torokhov USB devices permanently connected to USB ports may be described in ACPI tables and share ACPI devices with ports they are connected to. See [1] for details. This will allow us to describe sideband resources for devices, such as, for example, hard reset line for BT USB contr

[PATCH v4 3/5] Bluetooth: Reset Bluetooth chip after multiple command timeouts

2019-01-18 Thread Rajat Jain
Add a quirk and a hook to allow the HCI core to reset the BT chip if needed (after a number of timed out commands). Use that new hook to initiate BT chip reset if the controller fails to respond to certain number of commands (currently 5) including the HCI reset commands. This is done based on a ne

[PATCH v4 4/5] Bluetooth: btusb: Collect the common Intel assignments together

2019-01-18 Thread Rajat Jain
The BTUSB_INTEL and BTUSB_INTEL_NEW have common functions & quirks are assigned to hdev structure. Lets collect them together instead of repeating them in different code branches. Signed-off-by: Rajat Jain --- v4: same as v1 v3: same as v1 v2: same as v1 drivers/bluetooth/btusb.c | 27 +

[PATCH v4 5/5] Bluetooth: btusb: Use the hw_reset method to allow resetting the BT chip

2019-01-18 Thread Rajat Jain
If the platform provides it, use the reset gpio to reset the BT chip (requested by the HCI core if needed). This has been found helpful on some of Intel bluetooth controllers where the firmware gets stuck and the only way out is a hard reset pin provided by the platform. Signed-off-by: Rajat Jain

[PATCH v4 1/5] usb: split code locating ACPI companion into port and device

2019-01-18 Thread Rajat Jain
From: Dmitry Torokhov In preparation for handling embedded USB devices let's split usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and usb_acpi_find_companion_for_port(). Signed-off-by: Dmitry Torokhov Signed-off-by: Rajat Jain Acked-by: Greg Kroah-Hartman Tested-by: Sukum

Re: [Patch net-next] net_sched: add hit counter for matchall

2019-01-18 Thread David Miller
From: Cong Wang Date: Thu, 17 Jan 2019 12:44:25 -0800 > Although matchall always matches packets, however, it still > relies on a protocol match first. So it is still useful to have > such a counter for matchall. Of course, unlike u32, every time > we hit a matchall filter, it is always a success

Re: [PATCH v3 net-next 0/3] net: phy: improve stopping PHY

2019-01-18 Thread David Miller
From: Heiner Kallweit Date: Thu, 17 Jan 2019 20:06:46 +0100 > This patchset improves and simplifies stopping the PHY. Series applied, thanks.

Re: [PATCH net] MAINTAINERS: update email addresses of liquidio driver maintainers

2019-01-18 Thread David Miller
From: Felix Manlunas Date: Thu, 17 Jan 2019 18:07:45 + > From: Felix Manlunas > > Update email addresses of liquidio driver maintainers. Also remove a > former maintainer. > > Signed-off-by: Felix Manlunas > Acked-by: Derek Chickles Applied, thanks.

Re: [PATCH] net: Fix typo in NET_FAILOVER help text

2019-01-18 Thread David Miller
From: Jonathan Neuschäfer Date: Thu, 17 Jan 2019 18:02:18 +0100 > "also enables" should not be spelled as one word. > > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") > Signed-off-by: Jonathan Neuschäfer Applied.

Re: [PATCH] net: Fix usage of pskb_trim_rcsum

2019-01-18 Thread David Miller
From: Ross Lagerwall Date: Thu, 17 Jan 2019 15:34:38 + > In certain cases, pskb_trim_rcsum() may change skb pointers. > Reinitialize header pointers afterwards to avoid potential > use-after-frees. Add a note in the documentation of > pskb_trim_rcsum(). Found by KASAN. > > Signed-off-by: Ros

Re: [PATCH net-next] tcp: declare tcp_mmap() only when CONFIG_MMU is set

2019-01-18 Thread David Miller
From: Yafang Shao Date: Thu, 17 Jan 2019 18:03:14 +0800 > Since tcp_mmap() is defined when CONFIG_MMU is set. > > Signed-off-by: Yafang Shao Applied.

[PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-18 Thread Bryan Whitehead
The LAN743x includes on chip One-Time-Programmable (OTP) memory. This patch extends the ethtool EEPROM read/write interface to access OTP memory space. This is done by adding the private flag OTP_ACCESS, which is used to switch between EEPROM, and OTP modes. The private flag OTP_ACCESS is config

Re: [PATCH] net: vxge: fix indentation issue

2019-01-18 Thread David Miller
From: Colin King Date: Wed, 16 Jan 2019 23:59:10 + > From: Colin Ian King > > There is a goto statement that indented too deeply, fix it. > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [PATCH] net: jme: fix indentation issues

2019-01-18 Thread David Miller
From: Colin King Date: Thu, 17 Jan 2019 00:03:26 + > From: Colin Ian King > > There are two lines that have indentation issues, fix these. Also remove > an empty line. > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [PATCH net-next] net: phy: remove state PHY_CHANGELINK

2019-01-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 16 Jan 2019 19:47:57 +0100 > Since recent changes to the phylib state machine state PHY_CHANGELINK > isn't used any longer. Therefore let's remove it. > > Signed-off-by: Heiner Kallweit Applied.

[PATCH bpf-next v2] bpf: btf: add btf documentation

2019-01-18 Thread Yonghong Song
This patch added documentation for BTF (BPF Debug Format). The document is placed under linux:Documentation/bpf directory. Signed-off-by: Yonghong Song --- Documentation/bpf/btf.rst | 870 Documentation/bpf/index.rst | 7 + 2 files changed, 877 insertions

Re: [PATCH net-next] net: ip6_gre: remove gre_hdr_len from ip6erspan_rcv

2019-01-18 Thread David Miller
From: Lorenzo Bianconi Date: Wed, 16 Jan 2019 19:38:05 +0100 > Remove gre_hdr_len from ip6erspan_rcv routine signature since > it is not longer used > > Signed-off-by: Lorenzo Bianconi Applied.

Re: [PATCH net-next 09/14] net: bridge: Propagate MC addresses with VID through switchdev

2019-01-18 Thread Florian Fainelli
On 1/18/19 3:41 AM, Ido Schimmel wrote: > On Thu, Jan 17, 2019 at 11:17:57AM -0800, Florian Fainelli wrote: >> On 1/17/19 6:05 AM, Ido Schimmel wrote: >>> On Wed, Jan 16, 2019 at 12:00:57PM -0800, Florian Fainelli wrote: In order for bridge port members to get a chance to implement unicast >>>

Re: [PATCH v3 1/3] Bluetooth: Add quirk for reading BD_ADDR from fwnode property

2019-01-18 Thread Matthias Kaehlcke
On Fri, Dec 28, 2018 at 02:05:44PM -0800, Matthias Kaehlcke wrote: > Add HCI_QUIRK_USE_BDADDR_PROPERTY to allow controllers to retrieve > the public Bluetooth address from the firmware node property > 'local-bd-address'. If quirk is set and the property does not exist > or is invalid the controller

Re: [BUG bisect] Missing Micrel driver on VF50 (net: phy: check return code when requesting PHY driver module)

2019-01-18 Thread Heiner Kallweit
On 18.01.2019 21:58, Heiner Kallweit wrote: > On 18.01.2019 09:48, Krzysztof Kozlowski wrote: >> On Fri, 18 Jan 2019 at 09:39, Krzysztof Kozlowski wrote: >>> >>> Hi, >>> >>> On today's next (next-20190118) my Colibri VF50 board fails to boot

Re: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:908

2019-01-18 Thread Jeff Kirsher
On Fri, 2019-01-18 at 18:31 +0900, Tetsuo Handa wrote: > This is not a MM bug. ;-) > And this change is made by below commit. > > commit 59361316afcb08569af21e1af83e89c7051c055a > Author: Jeff Kirsher > Date: Thu Aug 2 10:13:10 2018 -0700 > > igb: reduce CPU0 latency when updating statisti

Re: [BUG bisect] Missing Micrel driver on VF50 (net: phy: check return code when requesting PHY driver module)

2019-01-18 Thread Heiner Kallweit
On 18.01.2019 09:48, Krzysztof Kozlowski wrote: > On Fri, 18 Jan 2019 at 09:39, Krzysztof Kozlowski wrote: >> >> Hi, >> >> On today's next (next-20190118) my Colibri VF50 board fails to boot up >> from network (DHCP, NFSv4 root). Looks like missing netwo

Re: [PATCH v3 5/5] Bluetooth: btusb: Use the hw_reset method to allow resetting the BT chip

2019-01-18 Thread Rajat Jain
Hi Marcel, Thanks for your review. On Fri, Jan 18, 2019 at 3:04 AM Marcel Holtmann wrote: > > Hi Rajat, > > > If the platform provides it, use the reset gpio to reset the BT > > chip (requested by the HCI core if needed). This has been found helpful > > on some of Intel bluetooth controllers whe

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-18 Thread Arnd Bergmann
On Fri, Jan 18, 2019 at 8:53 PM Andy Lutomirski wrote: > I think we have two issues if we reuse those numbers for new syscalls. > First, I'd really like to see new syscalls be numbered consistently > everywhere, or at least on all x86 variants, and we can't on x32 > because they mean something els

[PATCH v2 1/1] doc: networking: integrate scaling document into doc tree

2019-01-18 Thread Otto Sabart
Convert scaling document into reStructuredText and add reference to scaling document into main table of contents in network documentation. There are no semantic changes. There are no references to "scaling.txt" file. Whole kernel tree was checked using: $ grep -r "scaling\.txt" Signed-off-by: Ot

[PATCH v2 0/1] doc: networking: integrate scaling document into doc tree

2019-01-18 Thread Otto Sabart
Changes in v2: * Changed formatting of sections according to kernel documentation conventions [0]. * All commits from this series were squashed into one. [0] https://www.kernel.org/doc/html/latest/doc-guide/sphinx.html Otto Sabart (1): doc: networking: integrate scaling document into doc tree

RE: [PATCH RFC 1/4] net: dsa: microchip: convert KSZ9477 SPI driver to use regmap

2019-01-18 Thread Tristram.Ha
> > These extremely patches look similar to what I posted here before: > > > > https://patchwork.ozlabs.org/cover/1017222/ > > > > But the authorship has changed. Why ? > > There seems to be explanation in 0/4. > > Tristram: if you started from Marek's patches as you describe in 0/4, > you should

RE: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-18 Thread Tristram.Ha
> > +#define REG_SIZE 0x8000 > > + > > +#define I2C_REGMAP_VAL 8 > > +#define I2C_REGMAP_REG 16 > > + > > +#define KSZ_REGMAP_COMMON(n, width) > \ > > +{ \ > > +

Re: [PATCH] net: dpaa2: build ptp clock driver in default

2019-01-18 Thread Richard Cochran
On Fri, Jan 18, 2019 at 07:18:32AM +, Y.b. Lu wrote: > > We want to use "imply" instead of "select" here. > > [Y.b. Lu] Just learned the "imply" from the doc. I have a query here. > Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of > FSL_DPAA2_PTP_CLOCK driver may not work. >

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-18 Thread Andy Lutomirski
On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > - Once we get to 512, we clash with the x32 numbers (unless > > > we remove x32 support first), and probably have to s

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-18 Thread Arnd Bergmann
On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > - Once we get to 512, we clash with the x32 numbers (unless > > we remove x32 support first), and probably have to skip > > a few more. I also considered using the 512..547 space

Re: [PATCH v2 13/29] arch: add split IPC system calls where needed

2019-01-18 Thread Arnd Bergmann
On Fri, Jan 18, 2019 at 6:20 PM Gabriel Paubert wrote: > > On Fri, Jan 18, 2019 at 05:18:19PM +0100, Arnd Bergmann wrote: > > The IPC system call handling is highly inconsistent across architectures, > > some use sys_ipc, some use separate calls, and some use both. We also > > have some architect

Re: [PATCH] bpftool: Fix prog dump by tag

2019-01-18 Thread Jakub Kicinski
On Fri, 18 Jan 2019 13:58:17 +0100, Jiri Olsa wrote: > Lance reported an issue with bpftool not being able to > dump program if there are more programs loaded and you > want to dump any but the first program, like: > > # bpftool prog > 28: kprobe name trace_req_start tag 1dfc28ba8b3dd597 gp

[PATCH v2 iproute2 0/1] Hide keys for state output - changelog

2019-01-18 Thread Benedict Wong
Changes v1 -> v2: Corrected stylistic nits: - Line break locations in ipxfrm.c - Usage and man pages updated to reflect deleteall and list parameters are no longer optional, as they have been individualized. Benedict Wong (1): xfrm: add option to hide keys in state output ip/ipxfrm.c

[PATCH v2 iproute2 1/1] xfrm: add option to hide keys in state output

2019-01-18 Thread Benedict Wong
ip xfrm state show currently dumps keys unconditionally. This limits its use in logging, as security information can be leaked. This patch adds a nokeys option to ip xfrm ( state show | monitor ), which prevents the printing of keys. This allows ip xfrm state show to be used in logging without exp

Re: [PATCH] net: phy: mdio_bus: add missing device_del() in mdiobus_register() error handling

2019-01-18 Thread David Miller
From: Thomas Petazzoni Date: Wed, 16 Jan 2019 10:53:58 +0100 > The current code in __mdiobus_register() doesn't properly handle > failures returned by the devm_gpiod_get_optional() call: it returns > immediately, without unregistering the device that was added by the > call to device_register() e

Re: [PATCH bpf] bpftool: fix percpu maps updating

2019-01-18 Thread Quentin Monnet
2019-01-18 17:50 UTC+0100 ~ Paolo Abeni > When updating a percpu map, bpftool currently copies the provided > value only into the first per CPU copy of the specified value, > all others instances are left zeroed. > > This change explicitly copies the user-provided bytes to all the > per CPU insta

Re: [PATCH net-next] ip_gre: Make none-tunnel-dst gre port work with lwtunnel

2019-01-18 Thread David Miller
From: we...@ucloud.cn Date: Tue, 15 Jan 2019 10:44:35 +0800 > + tun_info = skb_tunnel_info(skb); > + if (tun_info && (tun_info->mode & IP_TUNNEL_INFO_TX) && > + ip_tunnel_info_af(tun_info) == AF_INET && > + tun_info->key.u.ipv4.dst) { > +

Re: [PATCH 1/1 RESEND] doc: net: fix bad references to network drivers

2019-01-18 Thread David Miller
From: Otto Sabart Date: Mon, 14 Jan 2019 12:56:36 +0100 > Fix "reference to nonexisting document" warnings. > > Fixes: b255e500c8dc ("net: documentation: build a directory structure > for drivers") Please do not chop up Fixes: tags, keep the entire text on one continuous line. I fixed it up fo

Re: [PATCH] net: core: dev: Initialise napi state correctly

2019-01-18 Thread David McKay
On Fri, 18 Jan 2019 at 17:15, Eric Dumazet wrote: > > > > On 01/18/2019 04:46 AM, Dave McKay wrote: > > The state member of the napi_struct is not initialised correctly, it > > sets the SCHED bit without initialising the state to zero first. This > > results in peculiar behaviour if the original n

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-18 Thread Andy Lutomirski
On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > This adds 21 new system calls on each ABI that has 32-bit time_t > today. All of these have the exact same semantics as their existing > counterparts, and the new ones all have macro names that end in 'time64' > for clarification. > > This g

[PATCH net-next v2 04/14] rtnetlink: ifinfo: perform strict checks also for doit handler

2019-01-18 Thread Jakub Kicinski
Make RTM_GETLINK's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/core/rtnetlink.c | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c

[PATCH net-next v2 09/14] net: ipv6: addr: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETADDR's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/ipv6/addrconf.c | 49 +++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c i

[PATCH net-next v2 01/14] net: netlink: add helper to retrieve NETLINK_F_STRICT_CHK

2019-01-18 Thread Jakub Kicinski
Dumps can read state of the NETLINK_F_STRICT_CHK flag from a field in the callback structure. For non-dump GET requests we need a way to access the state of that flag from a socket. Signed-off-by: Jakub Kicinski --- include/linux/netlink.h | 1 + net/netlink/af_netlink.c | 8 2 files

[PATCH net-next v2 14/14] net: mpls: netconf: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETNETCONF's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/mpls/af_mpls.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c inde

[PATCH net-next v2 10/14] net: ipv6: netconf: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETNETCONF's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/ipv6/addrconf.c | 41 ++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c in

[PATCH net-next v2 13/14] net: mpls: route: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETROUTE's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/mpls/af_mpls.c | 61 -- 1 file changed, 59 insertions(+), 2 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c in

[PATCH net-next v2 12/14] net: ipv6: route: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETROUTE's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/ipv6/route.c | 70 ++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index

[PATCH net-next v2 02/14] rtnetlink: stats: validate attributes in get as well as dumps

2019-01-18 Thread Jakub Kicinski
Make sure NETLINK_GET_STRICT_CHK influences both GETSTATS doit as well as the dump. Signed-off-by: Jakub Kicinski --- net/core/rtnetlink.c | 58 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.

[PATCH net-next v2 08/14] net: ipv4: ipmr: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETROUTE's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. v2: - improve extack messages (DaveA). Signed-off-by: Jakub Kicinski --- net/ipv4/ipmr.c | 61 + 1 file changed, 56 insertions(+), 5 deletions(-) diff --git a/ne

[PATCH net-next v2 06/14] net: ipv4: netconf: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETNETCONF's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/ipv4/devinet.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c ind

[PATCH net-next v2 05/14] net: namespace: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETNSID's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. v2: - don't check size >= sizeof(struct rtgenmsg) (Nicolas). Signed-off-by: Jakub Kicinski --- CC: ktk...@virtuozzo.com CC: nicolas.dich...@6wind.com --- net/core/net_namespace.c | 38 +++

[PATCH net-next v2 03/14] rtnetlink: stats: reject requests for unknown stats

2019-01-18 Thread Jakub Kicinski
In the spirit of strict checks reject requests of stats the kernel does not support when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/core/rtnetlink.c | 4 1 file changed, 4 insertions(+) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 08f142b59403..3c1

[PATCH net-next v2 00/14] net: use strict checks in doit handlers

2019-01-18 Thread Jakub Kicinski
Hi! This series extends strict argument checking to doit handlers of the GET* nature. This is a bit tricky since strict checking flag has already been released.. iproute2 did not have a release with strick checks enabled, and it will only need a minor one-liner to pass strick checks after all th

[PATCH net-next v2 11/14] net: ipv6: addrlabel: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETADDRLABEL's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski --- net/ipv6/addrlabel.c | 47 ++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrlabel.c b/net/ipv6/addrla

[PATCH net-next v2 07/14] net: ipv4: route: perform strict checks also for doit handlers

2019-01-18 Thread Jakub Kicinski
Make RTM_GETROUTE's doit handler use strict checks when NETLINK_F_STRICT_CHK is set. v2: - new patch (DaveA). Signed-off-by: Jakub Kicinski --- net/ipv4/route.c | 72 ++-- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/net/ipv4/route.c

Re: [PATCH] ethtool: zero initialize coalesce struct

2019-01-18 Thread John W. Linville
On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > prior to fetching it from kernel. > > Otherwise we run the risk of very tail portion of it (dmac field) > being left entirely uninitialized, and likely containing some sort > of stale data. > >

Re: [PATCH v2 0/7] ethtool: pretty dump mv88e6xxx registers

2019-01-18 Thread John W. Linville
On Tue, Dec 18, 2018 at 02:06:34PM -0500, Vivien Didelot wrote: > This patch series adds support to pretty dump the registers of user > ports created by the kernel "dsa" subsystem. > > The first patch adds the base support for "dsa" interfaces. > > The second patch adds the boilerplate for the "m

Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above

2019-01-18 Thread John W. Linville
On Thu, Nov 29, 2018 at 04:36:53PM +0100, Ivan Vecera wrote: > Support for UDP fragmentation offloading was removed in kernel v4.14. > The ethtool reports incorrectly its state on this and newer kernels: > > $ ethtool -k enp0s31f6 | grep udp-frag > udp-fragmentation-offload: off > > It's look lik

Re: [PATCH] ethtool: change to new sane powerpc64 kernel headers

2019-01-18 Thread John W. Linville
On Fri, Dec 14, 2018 at 05:19:36PM -0800, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This fixes: > In file included from ethtool-copy.h:22:0, >from internal.h:32, >from ethtool.c:29: > .../include/linux/types.h:32:25: error: conflicting

Re: [PATCH v2 bpf-next] bpf: allow BPF programs access skb_shared_info->gso_segs field

2019-01-18 Thread Martin Lau
On Thu, Jan 17, 2019 at 03:31:57PM -0800, Eric Dumazet wrote: > This adds the ability to read gso_segs from a BPF program. > > v2: refined Eddie Hao patch to address Alexei feedback. > > Signed-off-by: Eric Dumazet > Cc: Eddie Hao > Cc: Vlad Dumitrescu > Cc: Xiaotian Pei > Cc: Yuchung Cheng

Re: [PATCH] bpftool: Fix prog dump by tag

2019-01-18 Thread Quentin Monnet
2019-01-18 13:58 UTC+0100 ~ Jiri Olsa > Lance reported an issue with bpftool not being able to > dump program if there are more programs loaded and you > want to dump any but the first program, like: > > # bpftool prog > 28: kprobe name trace_req_start tag 1dfc28ba8b3dd597 gpl > load

Re: [PATCH net-next 0/8] net: mscc: PTP offloading support

2019-01-18 Thread Florian Fainelli
On 1/18/19 12:58 AM, Antoine Tenart wrote: > Hi Florian, > > On Thu, Jan 17, 2019 at 09:07:05PM -0800, Florian Fainelli wrote: >> On 1/17/2019 2:02 AM, Antoine Tenart wrote: >>> >>> This series adds support for the PTP offloading support in the Mscc >>> Ocelot Ethernet switch driver. Both PTP 1-st

Re: [PATCH net-next 00/13] net: use strict checks in doit handlers

2019-01-18 Thread Jakub Kicinski
On Fri, 18 Jan 2019 07:45:50 -0700, David Ahern wrote: > On 1/17/19 3:52 PM, Jakub Kicinski wrote: > > Hi! > > > > This series extends strict argument checking to doit handlers > > of the GET* nature. This is a bit tricky since strict checking > > flag has already been released.. > > > > iproute

  1   2   3   >