Re: [net-next PATCH RFC 1/8] page_pool: add helper functions for DMA

2018-12-07 Thread Ilias Apalodimas
On Fri, Dec 07, 2018 at 11:06:55PM -0800, David Miller wrote: > This isn't going to work on 32-bit platforms where dma_addr_t is a u64, > because the page private is unsigned long. > > Grep for PHY_ADDR_T_64BIT under arch/ to see the vast majority of the > cases where this happens, then ARCH_DMA_

Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-07 Thread Ilias Apalodimas
On Fri, Dec 07, 2018 at 11:15:14PM -0800, David Miller wrote: > From: Jesper Dangaard Brouer > Date: Fri, 07 Dec 2018 00:25:47 +0100 > > > @@ -744,6 +745,10 @@ struct sk_buff { > > head_frag:1, > > xmit_more:1, > >

Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-07 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 07 Dec 2018 00:25:47 +0100 > @@ -744,6 +745,10 @@ struct sk_buff { > head_frag:1, > xmit_more:1, > pfmemalloc:1; > + /* TODO: Future idea, extend mem_info with __u

Re: [net-next PATCH RFC 1/8] page_pool: add helper functions for DMA

2018-12-07 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 07 Dec 2018 00:25:32 +0100 > From: Ilias Apalodimas > > Add helper functions for retreiving dma_addr_t stored in page_private and > unmapping dma addresses, mapped via the page_pool API. > > Signed-off-by: Ilias Apalodimas > Signed-off-by: Jesper Dangaa

Re: [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"

2018-12-07 Thread David Miller
From: Benjamin Herrenschmidt Date: Fri, 07 Dec 2018 15:05:04 +1100 > This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9. > > This commit is completely bogus. The STACR register has two formats, old > and new, depending on the version of the IP block used. There's a pair of > device-tre

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-07 Thread David Miller
From: Maciej Żenczykowski Date: Fri, 7 Dec 2018 16:46:36 -0800 >> This doesn't apply to the current net tree. >> >> Also "net-udp: " is a weird subsystem prefix, just use "udp: ". >> >> Thank you. > > Interesting... this patch was on top of net-next/master, and it still > rebases cleanly on curr

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
On 12/08/2018 12:46 AM, David Miller wrote: > From: Marek Vasut > Date: Fri, 7 Dec 2018 23:59:58 +0100 > >> On 12/07/2018 11:24 PM, Andrew Lunn wrote: >>> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: Add code to handle optional reset GPIO in the KSZ switch driver. The switch

Re: [PATCH] net: dsa: ksz: Increase the tag alignment

2018-12-07 Thread Marek Vasut
On 12/08/2018 01:52 AM, tristram...@microchip.com wrote: >> -padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len; >> +padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb- >>> len; > > The requirement is the tail tag should be at the end of frame before FCS. > When the leng

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Marek Vasut
On 12/08/2018 01:13 AM, tristram...@microchip.com wrote: >> Do you have a git tree with all the KSZ patches based on -next >> somewhere, so I don't have to look for them in random MLs ? > > I just sent it this Monday and the subject for that patch is > "[PATCH RFC 6/6] net: dsa: microchip: Add swi

Re: [PATCH bpf-next 2/3] bpf: add bpffs pretty print for cgroup local storage maps

2018-12-07 Thread Yonghong Song
On 12/7/18 4:53 PM, Roman Gushchin wrote: > Implement bpffs pretty printing for cgroup local storage maps > (both shared and per-cpu). > Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c): > > Shared: >$ cat /sys/fs/bpf/map_2 ># WARNING!! The output is for debug purp

[PATCH bpf-next 2/3] bpf: add bpffs pretty print for cgroup local storage maps

2018-12-07 Thread Roman Gushchin
Implement bpffs pretty printing for cgroup local storage maps (both shared and per-cpu). Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c): Shared: $ cat /sys/fs/bpf/map_2 # WARNING!! The output is for debug purpose only # WARNING!! The output format will change {4294

[PATCH bpf-next 3/3] selftests/bpf: add btf annotations for cgroup_local_storage maps

2018-12-07 Thread Roman Gushchin
Add btf annotations to cgroup local storage maps (per-cpu and shared) in the network packet counting example. Signed-off-by: Roman Gushchin Cc: Alexei Starovoitov Cc: Daniel Borkmann --- tools/testing/selftests/bpf/netcnt_prog.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/t

[PATCH bpf-next 1/3] bpf: pass struct btf pointer to the map_check_btf() callback

2018-12-07 Thread Roman Gushchin
If key_type or value_type are of non-trivial data types (e.g. structure or typedef), it's not possible to check them without the additional information, which can't be obtained without a pointer to the btf structure. So, let's pass btf pointer to the map_check_btf() callbacks. Signed-off-by: Roma

RE: [PATCH] net: dsa: ksz: Increase the tag alignment

2018-12-07 Thread Tristram.Ha
> - padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len; > + padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb- > >len; The requirement is the tail tag should be at the end of frame before FCS. When the length is less than 60 the MAC controller will pad the frame to lega

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-07 Thread Maciej Żenczykowski
> This doesn't apply to the current net tree. > > Also "net-udp: " is a weird subsystem prefix, just use "udp: ". > > Thank you. Interesting... this patch was on top of net-next/master, and it still rebases cleanly on current net-next/master. Would you like it on net/master instead? It indeed do

[PATCH bpf-next 1/7] bpf: Add bpf_line_info support

2018-12-07 Thread Martin KaFai Lau
This patch adds bpf_line_info support. It accepts an array of bpf_line_info objects during BPF_PROG_LOAD. The "line_info", "line_info_cnt" and "line_info_rec_size" are added to the "union bpf_attr". The "line_info_rec_size" makes bpf_line_info extensible in the future. The new "check_btf_line()"

[PATCH bpf-next 6/7] bpf: libbpf: Add btf_line_info support to libbpf

2018-12-07 Thread Martin KaFai Lau
This patch adds bpf_line_info support to libbpf: 1) Parsing the line_info sec from ".BTF.ext" 2) Relocating the line_info. If the main prog *_info relocation fails, it will ignore the remaining subprog line_info and continue. If the subprog *_info relocation fails, it will bail out. 3) BPF_P

[PATCH bpf-next 3/7] bpf: Refactor and bug fix in test_func_type in test_btf.c

2018-12-07 Thread Martin KaFai Lau
1) bpf_load_program_xattr() is absorbing the EBIG error which makes testing this case impossible. It is replaced with a direct syscall(__NR_bpf, BPF_PROG_LOAD,...). 2) The test_func_type() is renamed to test_info_raw() to prepare for the new line_info test in the next patch. 3) The bpf_ob

[PATCH bpf-next 0/7] Introduce bpf_line_info

2018-12-07 Thread Martin KaFai Lau
This patch series introduces the bpf_line_info. Please see individual patch for details. It will be useful for introspection purpose, like: [root@arch-fb-vm1 bpf]# ~/devshare/fb-kernel/linux/tools/bpf/bpftool/bpftool prog dump jited pinned /sys/fs/bpf/test_btf_haskv [...] int test_long_fname_2(

[PATCH bpf-next 7/7] bpf: libbpf: bpftool: Print bpf_line_info during prog dump

2018-12-07 Thread Martin KaFai Lau
This patch adds print bpf_line_info function in 'prog dump jitted' and 'prog dump xlated': [root@arch-fb-vm1 bpf]# ~/devshare/fb-kernel/linux/tools/bpf/bpftool/bpftool prog dump jited pinned /sys/fs/bpf/test_btf_haskv [...] int test_long_fname_2(struct dummy_tracepoint_args * arg): bpf_prog_44a04

[PATCH bpf-next 2/7] bpf: tools: Sync uapi bpf.h

2018-12-07 Thread Martin KaFai Lau
Sync uapi bpf.h to tools/include/uapi/linux for the new bpf_line_info. Signed-off-by: Martin KaFai Lau Acked-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bp

[PATCH bpf-next 4/7] bpf: Add unit tests for bpf_line_info

2018-12-07 Thread Martin KaFai Lau
Add unit tests for bpf_line_info for both BPF_PROG_LOAD and BPF_OBJ_GET_INFO_BY_FD. jit enabled: [root@arch-fb-vm1 bpf]# ./test_btf -k 0 BTF prog info raw test[5] (line_info (No subprog)): OK BTF prog info raw test[6] (line_info (No subprog. insn_off >= prog->len)): OK BTF prog info raw test[7] (l

[PATCH bpf-next 5/7] bpf: libbpf: Refactor and bug fix on the bpf_func_info loading logic

2018-12-07 Thread Martin KaFai Lau
This patch refactor and fix a bug in the libbpf's bpf_func_info loading logic. The bug fix and refactoring are targeting the same commit 2993e0515bb4 ("tools/bpf: add support to read .BTF.ext sections") which is in the bpf-next branch. 1) In bpf_load_program_xattr(), it should retry when errno ==

Re: [PATCH net-next 0/4] tc-testing: implement command timeouts and better results tracking

2018-12-07 Thread David Miller
From: Lucas Bates Date: Thu, 6 Dec 2018 17:42:23 -0500 > Patch 1 adds a timeout feature for any command tdc launches in a subshell. > This prevents tdc from hanging indefinitely. > > Patches 2-4 introduce a new method for tracking and generating test case > results, and implements it across the

Re: [PATCH net v2 0/2] Fix slab out-of-bounds on insufficient headroom for IPv6 packets

2018-12-07 Thread David Miller
From: Stefano Brivio Date: Thu, 6 Dec 2018 19:30:35 +0100 > Patch 1/2 fixes a slab out-of-bounds occurring with short SCTP packets over > IPv4 over L2TP over IPv6 on a configuration with relatively low HEADER_MAX. > > Patch 2/2 makes sure we avoid writing before the allocated buffer in > neigh_

Re: [PATCH net] tcp: lack of available data can also cause TSO defer

2018-12-07 Thread David Miller
From: Eric Dumazet Date: Thu, 6 Dec 2018 09:58:24 -0800 > tcp_tso_should_defer() can return true in three different cases : > > 1) We are cwnd-limited > 2) We are rwnd-limited > 3) We are application limited. > > Neal pointed out that my recent fix went too far, since > it assumed that if w

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-07 Thread David Miller
From: Maciej Żenczykowski Date: Wed, 5 Dec 2018 12:59:17 -0800 > From: Maciej Żenczykowski > > During udp socket lookup cpu match should be lowest priority, > hence it should increase score by only 1. > > The next priority is delivering v4 to v4 sockets, and v6 to v6 sockets. > The v6 code pa

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> Do you have a git tree with all the KSZ patches based on -next > somewhere, so I don't have to look for them in random MLs ? I just sent it this Monday and the subject for that patch is "[PATCH RFC 6/6] net: dsa: microchip: Add switch offload forwarding support."

Re: [Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-07 Thread David Miller
From: yupeng Date: Wed, 5 Dec 2018 18:56:28 -0800 > after set SO_DONTROUTE to 1, the IP layer should not route packets if > the dest IP address is not in link scope. But if the socket has cached > the dst_entry, such packets would be routed until the sk_dst_cache > expires. So we should clean th

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> > I think if you do this without setting offload_fwd_mark you will > > receive duplicate frame. > > I don't think it will, at least not in the normal case. The hardware > should know the egress port, so there is no need to forward a copy to > the CPU. The only time it should forward to the CPU i

Re: [PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Miller
From: David Ahern Date: Fri, 7 Dec 2018 12:24:57 -0800 > From: David Ahern > > The existing garbage collection algorithm has a number of problems: ... > This patch addresses these problems as follows: > > 1. Use of a separate list_head to track entries that can be garbage >collected alon

Re: [PATCH net-next 00/14] net: hns3: Additions/optimizations related to HNS3 H/W err handling

2018-12-07 Thread David Miller
From: Salil Mehta Date: Fri, 7 Dec 2018 21:07:57 + > This patch set primarily does following addtions and optimizations > related to error handling in HNS3 Ethernet driver: > > 1. Name changes for enable and process functions and minor loop > optimizations. [PATCH 1-6] > 2. Modify quer

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> >> If two ports are in the same bridge and in forwarding state, the packets > >> must be able to pass between them in both directions. The current code > >> only configures this bridge membership for a port newly added to the > >> bridge, but does not update all the other ports. Thus, ingress pac

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread David Miller
From: Marek Vasut Date: Fri, 7 Dec 2018 23:59:58 +0100 > On 12/07/2018 11:24 PM, Andrew Lunn wrote: >> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: >>> Add code to handle optional reset GPIO in the KSZ switch driver. The switch >>> has a reset GPIO line which can be controlled by

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Miller
From: Eric Dumazet Date: Fri, 7 Dec 2018 15:03:04 -0800 > On 12/07/2018 02:24 PM, David Ahern wrote: >> On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> /* --- cacheline 3 boundary (192 bytes) --- */ >> struct hh_cachehh; /* 19248 */ >> >> ... >> >> but does no

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 02:24 PM, David Ahern wrote: > On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> >> On 12/07/2018 01:49 PM, David Ahern wrote: >>> From: David Ahern >>> >>> Similar to routes and rules, add protocol attribute to neighbor entries >>> for easier tracking of how each was created. >>> >>>

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
On 12/07/2018 11:24 PM, Andrew Lunn wrote: > On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: >> Add code to handle optional reset GPIO in the KSZ switch driver. The switch >> has a reset GPIO line which can be controlled by the CPU, so make sure it is >> configured correctly in such se

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
On 12/7/18 3:20 PM, Eric Dumazet wrote: > > > On 12/07/2018 01:49 PM, David Ahern wrote: >> From: David Ahern >> >> Similar to routes and rules, add protocol attribute to neighbor entries >> for easier tracking of how each was created. >> >> Signed-off-by: David Ahern >> --- >> include/net/nei

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Andrew Lunn
On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: > Add code to handle optional reset GPIO in the KSZ switch driver. The switch > has a reset GPIO line which can be controlled by the CPU, so make sure it is > configured correctly in such setups. Hi Marek Please make this a patch series

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 01:49 PM, David Ahern wrote: > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern > --- > include/net/neighbour.h| 2 ++ > include/uapi/linux/neigh

[PATCH] net: dsa: Add optional reset GPIO to Microchip KSZ switch binding

2018-12-07 Thread Marek Vasut
Add optional reset GPIO, as such a signal is available on the KSZ switches. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Woojung Huh Cc: David S. Miller --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 4 1 file changed, 4 insertions(+) diff --git a/Docume

Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
On 12/07/2018 08:55 PM, Andrew Lunn wrote: >> +dev->reset_gpio = -1; >> +reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0, >> + &reset_gpio_flags); >> +if (reset_gpio >= 0) { >> +flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW

[PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
Add code to handle optional reset GPIO in the KSZ switch driver. The switch has a reset GPIO line which can be controlled by the CPU, so make sure it is configured correctly in such setups. Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Cc: Tristram Ha --- V

[PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
From: David Ahern Similar to routes and rules, add protocol attribute to neighbor entries for easier tracking of how each was created. Signed-off-by: David Ahern --- include/net/neighbour.h| 2 ++ include/uapi/linux/neighbour.h | 1 + net/core/neighbour.c | 24 +

Re: [PATCH net-next v2 1/4] indirect call wrappers: helpers to speed-up indirect calls of builtin

2018-12-07 Thread David Woodhouse
On Fri, 2018-12-07 at 21:46 +0100, Paolo Abeni wrote: > > I wonder if we can declare the common case functions as 'weak' so that > > the link failures don't happen when they're absent. > > I experimented a previous version with alias. I avoided weak alias > usage, because I [mis?]understood not al

Re: [PATCH bpf 1/2] selftests/bpf: use thoff instead of nhoff in BPF flow dissector

2018-12-07 Thread Alexei Starovoitov
On Wed, Dec 05, 2018 at 08:40:47PM -0800, Stanislav Fomichev wrote: > We are returning thoff from the flow dissector, not the nhoff. Pass > thoff along with nhoff to the bpf program (initially thoff == nhoff) > and expect flow dissector amend/return thoff, not nhoff. > > This avoids confusion, whe

Re: [PATCH v2 bpf-next 0/7] bpf: support BPF_ALU | BPF_ARSH

2018-12-07 Thread Alexei Starovoitov
On Wed, Dec 05, 2018 at 01:52:29PM -0500, Jiong Wang wrote: > BPF_ALU | BPF_ARSH | BPF_* were rejected by commit: 7891a87efc71 > ("bpf: arsh is not supported in 32 bit alu thus reject it"). As explained > in the commit message, this is due to there is no complete support for them > on interpreter a

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote: > From: Björn Töpel > > Hi! > > This patch set adds support for a new XDP socket bind option, > XDP_ATTACH. > > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of creating/bin

[PATCH net-next 01/14] net: hns3: remove existing process error functions and reorder hw_blk table

2018-12-07 Thread Salil Mehta
From: Shiju Jose 1.The command interface for queryng and clearing hw errors is changed, which requires the new process error functions to be added. This patch removes all the current process error functions and associated definitions. The new functions to handle ras errors would be added

[PATCH net-next 00/14] net: hns3: Additions/optimizations related to HNS3 H/W err handling

2018-12-07 Thread Salil Mehta
This patch set primarily does following addtions and optimizations related to error handling in HNS3 Ethernet driver: 1. Name changes for enable and process functions and minor loop optimizations. [PATCH 1-6] 2. Modify query and clearing of RAS errors using new set of commands because mo

[PATCH net-next 12/14] net: hns3: handle hw errors of PPU(RCB)

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch enables and handles hw RAS and MSIx errors of PPU(RCB). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 3 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 162 + .../net/ethe

[PATCH net-next 07/14] net: hns3: add handling of hw ras errors using new set of commands

2018-12-07 Thread Salil Mehta
From: Shiju Jose 1. This patch adds handling of hw ras errors using new set of common commands. 2. Updated the error message tables to match the register's name and error status returned by the commands. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon

[PATCH net-next 10/14] net: hns3: add handling of hw errors of MAC

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch adds enable and handling of hw errors of the MAC block. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 48 ++ .../net/ether

[PATCH net-next 09/14] net: hns3: add handling of hw errors reported through MSIX

2018-12-07 Thread Salil Mehta
This patch adds handling for HNS3 hardware errors(non-standard) which are reported through MSIX interrupts and not through PCIe AER channel. These MSIX reported hardware errors are handled using common misc. interrupt handler. Hardware error related registers cannot be cleared in context to the in

[PATCH net-next 03/14] net: hns3: re-enable error interrupts on hw reset

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch adds calling hclge_hw_error_set_state function to re-enable the error interrupts those will be disabled on the hw reset. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 2 +- drivers/net/ethernet/h

[PATCH net-next 04/14] net: hns3: deletes unnecessary settings of the descriptor data

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch deletes unnecessary setting of the descriptor data to 0 for disabling error interrupts because it is already done by the hclge_cmd_setup_basic_desc function. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

[PATCH net-next 02/14] net: hns3: rename enable error interrupt functions

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch - renames the enable error interrupt functions. The reason is that these functions are used for both enable and disable error interrupts. - removes redundant logs from the enable error interrupt functions. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --

[PATCH net-next 06/14] net: hns3: add optimization in the hclge_hw_error_set_state

2018-12-07 Thread Salil Mehta
From: Shiju Jose 1. This patch adds minor loop optimization in the hclge_hw_error_set_state function. 2. Adds logging module's name if it fails to configure the error interrupts. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_er

[PATCH net-next 05/14] net: hns3: rename process_hw_error function

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch renames process_hw_error function to handle_hw_ras_error function to match the purpose of the function. This is because hw errors reported through ras and msix interrupts will be handled separately. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/n

[PATCH net-next 08/14] net: hns3: deleted logging 1 bit errors

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch deletes logging 1 bit errors for the following reasons. 1. AER does not notify 1 bit errors to the device drivers. However AER reports 1 bit errors to the userspace through the trace_aer_event for logging in the rasdaemon. 2. Firmware clears the status of 1 bit e

[PATCH net-next 11/14] net: hns3: handle hw errors of PPP PF

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch handles PF hw errors of PPP(Programmable Packet Processor). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH net-next 13/14] net: hns3: handle hw errors of SSU

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch enables and handles hw errors of the Storage Switch Unit(SSU). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 187 + .../n

[PATCH net-next 14/14] net: hns3: add handling of RDMA RAS errors

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch handles the RDMA RAS errors. 1. Enable RAS interrupt, print error detail info and clear error status. 2. Do CORE reset to recovery when these non-fatal errors happened. Signed-off-by: Xiaofei Tan Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/eth

Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

2018-12-07 Thread David Miller
From: Paolo Abeni Date: Fri, 07 Dec 2018 21:29:20 +0100 > Are you building with CONFIG_IPV6=m ? I always build allmodconfig

Re: [PATCH net-next v2 00/12] mlxsw: Un/offload FDB on NVE detach/attach

2018-12-07 Thread David Miller
From: Ido Schimmel Date: Fri, 7 Dec 2018 19:55:01 + > Petr says: > > When a VXLAN device is attached to a bridge of a driver capable of > offloading such, or upped, the FDB entries already present at the device > need to be offloaded. Similarly when an offloaded VXLAN device ceases > being i

Re: [PATCH iproute2-next 0/2] devlink: Add support for 'fw_load_policy' generic parameter

2018-12-07 Thread David Ahern
On 12/4/18 3:14 AM, Shalom Toledo wrote: > Patch #1 add string to uint conversion support for generic parameters. > Patch #2 add string to uint support for 'fw_load_policy' generic parameter > > Shalom Toledo (2): > devlink: Add string to uint{8,16,32} conversion for generic parameters > devli

Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

2018-12-07 Thread David Miller
Every patch series should have a header posting with Subject of the form "[PATCH 0/N] ..." explaining what the series does at a high level, how it does it, and why it does it that way.

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Russell King - ARM Linux [181207 19:27]: > You mentioned that edge mode didn't work as well as level mode on > duovero smsc controller, I think this may help to solve the same > issue but for edge IRQs - we need a mask_ack_irq function to avoid > acking while the edge interrupt is masked. Let m

Re: [PATCH v2 net-next 0/4] net: aquantia: add RSS configuration

2018-12-07 Thread David Miller
From: Igor Russkikh Date: Fri, 7 Dec 2018 14:00:09 + > In this patchset few bugs related to RSS are fixed and RSS table and > hash key configuration is added. > > We also do increase max number of HW rings upto 8. > > v2: removed extra arg check Series applied.

Re: [PATCH net-next v2 1/4] indirect call wrappers: helpers to speed-up indirect calls of builtin

2018-12-07 Thread Paolo Abeni
On Fri, 2018-12-07 at 09:46 +, David Woodhouse wrote: > On Wed, 2018-12-05 at 19:13 +0100, Paolo Abeni wrote: > > +/* > > + * We can use INDIRECT_CALL_$NR for ipv6 related functions only if ipv6 is > > + * builtin, this macro simplify dealing with indirect calls with only > > ipv4/ipv6 > > + *

Re: [PATCH] net/mlx4_core: Correctly set PFC param if global pause is turned off.

2018-12-07 Thread David Miller
From: Tarick Bedeir Date: Fri, 7 Dec 2018 00:30:26 -0800 > rx_ppp and tx_ppp can be set between 0 and 255, so don't clamp to 1. > > Fixes: 6e8814ceb7e8 ("net/mlx4_en: Fix mixed PFC and Global pause user > control requests") > Signed-off-by: Tarick Bedeir Tariq and co., please review.

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Florian Fainelli
On 12/7/18 9:26 AM, Andrew Lunn wrote: >> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs? > > I think it makes sense to allow a fixed phy carrier to be changed from > user space. However, i don't think you can easily plumb that to > .ndo_change_carrier(), since that is a MA

Re: [PATCH rdma-next 0/3] Packet based credit mode

2018-12-07 Thread Jason Gunthorpe
On Fri, Dec 07, 2018 at 08:04:26AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote: > > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > >From Danit, > > > > > > Packet based credit mode is an a

Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

2018-12-07 Thread Paolo Abeni
Hi, On Thu, 2018-12-06 at 22:28 -0800, David Miller wrote: > From: David Miller > Date: Thu, 06 Dec 2018 22:24:09 -0800 (PST) > > > Series applied, thanks! > > Erm... actually reverted. Please fix these build failures: oops ... I'm sorry for the late reply. I'm travelling and I will not able

[PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Ahern
From: David Ahern The existing garbage collection algorithm has a number of problems: 1. The gc algorithm will not evict PERMANENT entries as those entries are managed by userspace, yet the existing algorithm walks the entire hash table which means it always considers PERMANENT entries whe

Re: [PATCH net] ipv6: sr: properly initialize flowi6 prior passing to ip6_route_output

2018-12-07 Thread David Miller
From: Shmulik Ladkani Date: Fri, 7 Dec 2018 09:50:17 +0200 > In 'seg6_output', stack variable 'struct flowi6 fl6' was missing > initialization. > > Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and > injection with lwtunnels") > Signed-off-by: Shmulik Ladkani Applied and

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Andrew Lunn
> I think if you do this without setting offload_fwd_mark you will > receive duplicate frame. I don't think it will, at least not in the normal case. The hardware should know the egress port, so there is no need to forward a copy to the CPU. The only time it should forward to the CPU is when the e

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Marek Vasut
On 12/07/2018 08:37 PM, tristram...@microchip.com wrote: >> If two ports are in the same bridge and in forwarding state, the packets >> must be able to pass between them in both directions. The current code >> only configures this bridge membership for a port newly added to the >> bridge, but does

[PATCH net-next v2 06/12] mlxsw: spectrum_switchdev: Publish mlxsw_sp_switchdev_notifier

2018-12-07 Thread Ido Schimmel
From: Petr Machata The notifier block will need to be passed to vxlan_fdb_replay() in a follow-up patch. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 + drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +-

[PATCH net-next v2 11/12] selftests: mlxsw: vxlan: Test FDB un/marking on VXLAN join/leave

2018-12-07 Thread Ido Schimmel
From: Petr Machata When a VXLAN device is attached to an offloaded bridge, or when a front-panel port is attached to a bridge that already has a VXLAN device, mlxsw should offload the existing offloadable FDB entries. Similarly when VXLAN device is downed, the FDB entries are unoffloaded, and the

[PATCH net-next v2 12/12] selftests: forwarding: Add PVID test case for VXLAN with VLAN-aware bridges

2018-12-07 Thread Ido Schimmel
When using VLAN-aware bridges with VXLAN, the VLAN that is mapped to the VNI of the VXLAN device is that which is configured as "pvid untagged" on the corresponding bridge port. When these flags are toggled or when the VLAN is deleted entirely, remote hosts should not be able to receive packets fr

[PATCH net-next v2 08/12] mlxsw: spectrum_nve: Add mlxsw_sp_nve_ops.fdb_clear_offload

2018-12-07 Thread Ido Schimmel
From: Petr Machata If there are any offloaded FDB entries at an NVE device at the time that it's un-offloaded, their offloaded marks need to be cleared. How that is done depends on NVE device type, and therefore add a per-NVE-type operation. Implement the operation for the sole NVE device type c

[PATCH net-next v2 07/12] mlxsw: spectrum_nve: Add mlxsw_sp_nve_ops.fdb_replay

2018-12-07 Thread Ido Schimmel
From: Petr Machata A replay of FDB needs to be performed so that the FDB entries existing at the NVE device are offloaded. How the replay is done depends on NVE device type, and therefore add a per-NVE-type operation. Implement the operation for the sole NVE device type currently supported by ml

[PATCH net-next v2 10/12] mlxsw: spectrum_nve: Un/offload FDB on nve_fid_disable/enable

2018-12-07 Thread Ido Schimmel
From: Petr Machata Any existing NVE FDB entries need to be offloaded when NVE is enabled for a given FID. Recent patches have added fdb_replay op for this, so just invoke it from mlxsw_sp_nve_fid_enable(). When NVE is disabled on a FID, any existing FDB offloaded marks need to be cleared on NVE

[PATCH net-next v2 09/12] mlxsw: spectrum: Add mlxsw_sp_fid_ops.fdb_clear_offload

2018-12-07 Thread Ido Schimmel
From: Petr Machata If there are any offloaded FDB entries at bridge master of an NVE device at the time that it's un-offloaded, their offloaded marks need to be cleared. How that is done depends on whether the bridge in question is vlan aware. Therefore add a per-FID-type operation. Implement th

Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Andrew Lunn
> + dev->reset_gpio = -1; > + reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0, > + &reset_gpio_flags); > + if (reset_gpio >= 0) { > + flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ? > + GPIOF_ACTIVE_LO

[PATCH net-next v2 00/12] mlxsw: Un/offload FDB on NVE detach/attach

2018-12-07 Thread Ido Schimmel
Petr says: When a VXLAN device is attached to a bridge of a driver capable of offloading such, or upped, the FDB entries already present at the device need to be offloaded. Similarly when an offloaded VXLAN device ceases being interesting (it is downed, or detached, or a front-panel port netdevice

[PATCH net-next v2 02/12] vxlan: Add vxlan_fdb_replay()

2018-12-07 Thread Ido Schimmel
From: Petr Machata When a VXLAN device becomes relevant to a driver (such as when it is attached to an offloaded bridge), the driver will generally need to walk the existing FDB entries and offload them. Add a function vxlan_fdb_replay() to call a given notifier block for each FDB entry with a g

[PATCH net-next v2 03/12] vxlan: Add vxlan_fdb_clear_offload()

2018-12-07 Thread Ido Schimmel
From: Petr Machata When a driver unoffloads all FDB entries en bloc, it's inefficient to send the switchdev notification one by one. Add a helper that walks the FDB table, unsetting the offload flag on RDST with a given VNI. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/

[PATCH net-next v2 05/12] mlxsw: spectrum: Track NVE type at FIDs

2018-12-07 Thread Ido Schimmel
From: Petr Machata A follow-up patch will add support for replay and for clearing of offload marks. These are NVE type-sensitive operations, and to be able to dispatch them properly, a FID needs to know what NVE type is attached to it. Therefore, track the NVE type at struct mlxsw_sp_fid. Extend

[PATCH net-next v2 01/12] vxlan: Add a function to init switchdev_notifier_vxlan_fdb_info

2018-12-07 Thread Ido Schimmel
From: Petr Machata There are currently two places that need to initialize the notifier info structure, and one more is coming next when vxlan_fdb_replay() is introduced. These three instances have / will have very similar code that is easy to abstract away into a named function. Add such functio

[PATCH net-next v2 04/12] bridge: Add br_fdb_clear_offload()

2018-12-07 Thread Ido Schimmel
From: Petr Machata When a driver unoffloads all FDB entries en bloc, it's inefficient to send the switchdev notification one by one. Add a helper that unsets the offload flag on FDB entries on a given bridge port and VLAN. Signed-off-by: Petr Machata Acked-by: Nikolay Aleksandrov Signed-off-by

Re: [PATCH net-next] neighbour: Improve garbage collection

2018-12-07 Thread David Ahern
On 12/6/18 8:59 PM, David Miller wrote: > But why do you need the on_gc_list boolean state? f mental blockage. v2 coming up.

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Florian Fainelli
On 12/7/18 11:37 AM, tristram...@microchip.com wrote: >> If two ports are in the same bridge and in forwarding state, the packets >> must be able to pass between them in both directions. The current code >> only configures this bridge membership for a port newly added to the >> bridge, but does not

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> If two ports are in the same bridge and in forwarding state, the packets > must be able to pass between them in both directions. The current code > only configures this bridge membership for a port newly added to the > bridge, but does not update all the other ports. Thus, ingress packets > on th

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2018 at 11:03:12AM -0800, Tony Lindgren wrote: > * Tony Lindgren [181207 18:14]: > > Hi, > > > > * Russell King - ARM Linux [181207 18:01]: > > > Hi Tony, > > > > > > You know most of what's been going on from IRC, but here's the patch > > > which gets me: > > > > > > 1) workin

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Tony Lindgren [181207 18:14]: > Hi, > > * Russell King - ARM Linux [181207 18:01]: > > Hi Tony, > > > > You know most of what's been going on from IRC, but here's the patch > > which gets me: > > > > 1) working interrupts for networking > > 2) solves the stuck-wakeup problem > > > > It also

Re: [PATCH bpf-next] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2018-12-07 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 05:19:21PM +, Jiong Wang wrote: > On 06/12/2018 03:13, Alexei Starovoitov wrote: > > On Wed, Dec 05, 2018 at 03:32:50PM +, Jiong Wang wrote: > > > On 05/12/2018 14:52, Edward Cree wrote: > > > > On 05/12/18 09:46, Jiong Wang wrote: > > > > > There is NO processed ins

[PATCH 5/5] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2018-12-07 Thread Marek Vasut
From: Tristram Ha Add Microchip KSZ8795 DSA driver. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller --- drivers/net/dsa/microchip/Kconfig | 17 + drivers/net/dsa/microchip/Makefile |2 + drivers/net/dsa/microchip

[PATCH 2/5] net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477

2018-12-07 Thread Marek Vasut
From: Tristram Ha Rename the tag Kconfig option and related macros in preparation for addition of new KSZ family switches with different tag formats. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller --- drivers/net/dsa/microchip/K

  1   2   >