Re: Business Proposal

2018-11-01 Thread Edward Yuan
Dear Friend, My name is Mr. Edward Yuan, a consultant/broker. I know you might be a bit apprehensive because you do not know me. Nevertheless, I have a proposal on behalf of a client, a lucrative business that might be of mutual benefit to you. If interested in this proposition please kind

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Aaron Lu
On Thu, Nov 01, 2018 at 08:23:19PM +, Saeed Mahameed wrote: > On Thu, 2018-11-01 at 23:27 +0800, Aaron Lu wrote: > > On Thu, Nov 01, 2018 at 10:22:13AM +0100, Jesper Dangaard Brouer > > wrote: > > ... ... > > > Section copied out: > > > > > > mlx5e_poll_tx_cq > > > | > > >--1

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-11-01 Thread David Miller
From: Kristian Evensen Date: Thu, 1 Nov 2018 20:37:55 +0100 > On Thu, Nov 1, 2018 at 8:30 PM Kristian Evensen > wrote: >> >> On Thu, Nov 1, 2018 at 6:40 PM Kristian Evensen >> wrote: >> > >> > Hi, >> > >> > On Sat, Sep 8, 2018 at 1:50 PM Kristian Evensen >> > wrote: >> > > Quectel EP06 (and EM

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-11-01 Thread Song Liu
Hi Arnaldo, On Wed, Oct 17, 2018 at 5:11 AM Arnaldo Carvalho de Melo wrote: > > Adding Alexey, Jiri and Namhyung as they worked/are working on > multithreading 'perf record'. I have read Alexey's work on enabling aio for perf-record (https://lkml.org/lkml/2018/10/15/169). But I feel it is not re

Re: [PATCH bpf 0/3] show more accurrate bpf program address

2018-11-01 Thread Alexei Starovoitov
On Thu, Nov 01, 2018 at 12:00:55AM -0700, Song Liu wrote: > This set improves bpf program address showed in /proc/kallsyms and in > bpf_prog_info. First, real program address is showed instead of page > address. Second, when there is no subprogram, bpf_prog_info->jited_ksyms > returns the main prog

[PATCH net 0/2] net: timeout fixes for GENET and SYSTEMPORT

2018-11-01 Thread Florian Fainelli
Hi David, This patch series fixes occasional transmit timeout around the time the system goes into suspend. GENET and SYSTEMPORT have nearly the same logic in that regard and were both affected in the same way. Please queue up for stable, thanks! Doug Berger (1): net: bcmgenet: protect stop fr

[PATCH net 2/2] net: systemport: Protect stop from timeout

2018-11-01 Thread Florian Fainelli
A timing hazard exists when the network interface is stopped that allows a watchdog timeout to be processed by a separate core in parallel. This creates the potential for the timeout handler to wake the queues while the driver is shutting down, or access registers after their clocks have been remov

[PATCH iproute2] Include bsd/string.h only in include/utils.h

2018-11-01 Thread Luca Boccassi
This is simpler and cleaner, and avoids having to include the header from every file where the functions are used. The prototypes of the internal implementation are in this header, so utils.h will have to be included anyway for those. Fixes: 508f3c231efb ("Use libbsd for strlcpy if available") Si

Re: [RFC 0/2] Delayed binding of UDP sockets for Quic per-connection sockets

2018-11-01 Thread Christoph Paasch
On 01/11/18 - 17:51:39, Willem de Bruijn wrote: > On Wed, Oct 31, 2018 at 7:30 PM Christoph Paasch wrote: > > > > Implementations of Quic might want to create a separate socket for each > > Quic-connection by creating a connected UDP-socket. > > > > To achieve that on the server-side, a "master-so

Re: [PATCH v2 net] net: dsa: microchip: initialize mutex before use

2018-11-01 Thread Florian Fainelli
On 11/1/18 3:08 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Initialize mutex before use. Avoid kernel complaint when > CONFIG_DEBUG_LOCK_ALLOC is enabled. > > Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") > Signed-off-by: Tristram Ha > Reviewed-b

[PATCH v2 net] net: dsa: microchip: initialize mutex before use

2018-11-01 Thread Tristram.Ha
From: Tristram Ha Initialize mutex before use. Avoid kernel complaint when CONFIG_DEBUG_LOCK_ALLOC is enabled. Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") Signed-off-by: Tristram Ha Reviewed-by: Pavel Machek Reviewed-by: Andrew Lunn --- v2 - Add endorsements

Re: [RFC 0/2] Delayed binding of UDP sockets for Quic per-connection sockets

2018-11-01 Thread Willem de Bruijn
On Wed, Oct 31, 2018 at 7:30 PM Christoph Paasch wrote: > > Implementations of Quic might want to create a separate socket for each > Quic-connection by creating a connected UDP-socket. > > To achieve that on the server-side, a "master-socket" needs to wait for > incoming new connections and then

Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset

2018-11-01 Thread David Ahern
On 11/1/18 7:42 AM, Alexey Kodanev wrote: > On 11/01/2018 04:11 PM, Alexey Kodanev wrote: >> On 10/31/2018 08:35 PM, David Ahern wrote: >>> On 10/31/18 10:55 AM, David Ahern wrote: I think the simplest fix for 4.20 is to break the loop if ret is non-0 - restore the previous behavior. >>>

Re: [PATCH iproute2 net-next 0/3] ss: Allow selection of columns to be displayed

2018-11-01 Thread Stephen Hemminger
On Thu, 1 Nov 2018 15:18:03 -0600 David Ahern wrote: > On 11/1/18 3:06 PM, Jakub Kicinski wrote: > > On Wed, 31 Oct 2018 20:48:05 -0600, David Ahern wrote: > >>> spacing with a special character in the format string, that is: > >>> > >>> "%S.%Qr.%Qs %Al:%Pl %Ar:%Pr %p\n" > >>> > >>> wou

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 22:24, Paweł Staszewski pisze: W dniu 01.11.2018 o 22:18, Paweł Staszewski pisze: W dniu 01.11.2018 o 21:37, Saeed Mahameed pisze: On Thu, 2018-11-01 at 12:09 +0100, Paweł Staszewski wrote: W dniu 01.11.2018 o 10:50, Saeed Mahameed pisze: On Wed, 2018-10-31 at 22:57

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 22:18, Paweł Staszewski pisze: W dniu 01.11.2018 o 21:37, Saeed Mahameed pisze: On Thu, 2018-11-01 at 12:09 +0100, Paweł Staszewski wrote: W dniu 01.11.2018 o 10:50, Saeed Mahameed pisze: On Wed, 2018-10-31 at 22:57 +0100, Paweł Staszewski wrote: Hi So maybee someone

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 21:37, Saeed Mahameed pisze: On Thu, 2018-11-01 at 12:09 +0100, Paweł Staszewski wrote: W dniu 01.11.2018 o 10:50, Saeed Mahameed pisze: On Wed, 2018-10-31 at 22:57 +0100, Paweł Staszewski wrote: Hi So maybee someone will be interested how linux kernel handles normal tr

Re: [PATCH iproute2 net-next 0/3] ss: Allow selection of columns to be displayed

2018-11-01 Thread David Ahern
On 11/1/18 3:06 PM, Jakub Kicinski wrote: > On Wed, 31 Oct 2018 20:48:05 -0600, David Ahern wrote: >>> spacing with a special character in the format string, that is: >>> >>> "%S.%Qr.%Qs %Al:%Pl %Ar:%Pr %p\n" >>> >>> would mean "align everything to the right, distribute remaining >>> wh

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-01 Thread Edward Cree
I've spent a bit more time thinking about / sleeping on this, and I  still think there's a major disagreement here.  Basically it seems  like I'm saying "the design of BTF is wrong" and you're saying "but  it's the design" (with the possible implication — I'm not entirely  sure — of "but that's wha

Re: [PATCH iproute2 net-next 0/3] ss: Allow selection of columns to be displayed

2018-11-01 Thread Jakub Kicinski
On Wed, 31 Oct 2018 20:48:05 -0600, David Ahern wrote: > > spacing with a special character in the format string, that is: > > > > "%S.%Qr.%Qs %Al:%Pl %Ar:%Pr %p\n" > > > > would mean "align everything to the right, distribute remaining > > whitespace between %S, %Qr and %Qs". But it

Re: [RFC PATCH v3 06/10] udp: cope with UDP GRO packet misdirection

2018-11-01 Thread Willem de Bruijn
On Wed, Oct 31, 2018 at 5:57 AM Paolo Abeni wrote: > > On Tue, 2018-10-30 at 18:24 +0100, Paolo Abeni wrote: > > --- a/include/net/udp.h > > +++ b/include/net/udp.h > > @@ -406,17 +406,24 @@ static inline int copy_linear_skb(struct sk_buff > > *skb, int len, int off, > > } while(0) > > > > #if

Re: [RFC PATCH v3 08/10] selftests: conditionally enable XDP support in udpgso_bench_rx

2018-11-01 Thread Willem de Bruijn
On Tue, Oct 30, 2018 at 1:28 PM Paolo Abeni wrote: > > XDP support will be used by a later patch to test the GRO path > in a net namespace, leveraging the veth XDP implementation. > To avoid breaking existing setup, XDP support is conditionally > enabled and build only if llc is locally available.

Re: [RFC PATCH v3 01/10] udp: implement complete book-keeping for encap_needed

2018-11-01 Thread Willem de Bruijn
On Tue, Oct 30, 2018 at 1:28 PM Paolo Abeni wrote: > > The *encap_needed static keys are enabled by UDP tunnels > and several UDP encapsulations type, but they are never > turned off. This can cause unneeded overall performance > degradation for systems where such features are used > transiently.

Re: [Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread David Miller
From: Cong Wang Date: Thu, 1 Nov 2018 12:02:37 -0700 > Most callers of pskb_trim_rcsum() simply drop the skb when > it fails, however, ip_check_defrag() still continues to pass > the skb up to stack. This is suspicious. > > In ip_check_defrag(), after we learn the skb is an IP fragment, > passi

Re: [RFC 0/2] Delayed binding of UDP sockets for Quic per-connection sockets

2018-11-01 Thread Leif Hedstrom
> On Oct 31, 2018, at 6:53 PM, Eric Dumazet wrote: > > > > On 10/31/2018 04:26 PM, Christoph Paasch wrote: >> Implementations of Quic might want to create a separate socket for each >> Quic-connection by creating a connected UDP-socket. >> > > Nice proposal, but I doubt a QUIC server can a

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Saeed Mahameed
On Thu, 2018-11-01 at 12:09 +0100, Paweł Staszewski wrote: > > W dniu 01.11.2018 o 10:50, Saeed Mahameed pisze: > > On Wed, 2018-10-31 at 22:57 +0100, Paweł Staszewski wrote: > > > Hi > > > > > > So maybee someone will be interested how linux kernel handles > > > normal > > > traffic (not pktgen

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Saeed Mahameed
On Thu, 2018-11-01 at 23:27 +0800, Aaron Lu wrote: > On Thu, Nov 01, 2018 at 10:22:13AM +0100, Jesper Dangaard Brouer > wrote: > ... ... > > Section copied out: > > > > mlx5e_poll_tx_cq > > | > >--16.34%--napi_consume_skb > > | > > |--12.65%--_

Re: Help with the BPF verifier

2018-11-01 Thread Edward Cree
On 01/11/18 18:52, Arnaldo Carvalho de Melo wrote: > R0=inv(id=0) R1=inv6 R2=inv6 R3=inv(id=0) R6=ctx(id=0,off=0,imm=0) R7=inv64 > R10=fp0,call_-1 > 15: (b7) r2 = 0 > 16: (63) *(u32 *)(r10 -260) = r2 > 17: (67) r1 <<= 32 > 18: (77) r1 >>= 32 > 19: (67) r1 <<= 3 > 20: (bf) r2 = r6 > 21: (0f) r2 +=

Re: [PATCH iproute2] ip rule: Require at least one argument for add

2018-11-01 Thread Stephen Hemminger
On Tue, 30 Oct 2018 13:59:05 -0700 David Ahern wrote: > From: David Ahern > > 'ip rule add' with no additional arguments just adds another rule > for the main table - which exists by default. Require at least > 1 argument similar to delete. > > Signed-off-by: David Ahern Applied these two

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-11-01 Thread Kristian Evensen
On Thu, Nov 1, 2018 at 8:30 PM Kristian Evensen wrote: > > On Thu, Nov 1, 2018 at 6:40 PM Kristian Evensen > wrote: > > > > Hi, > > > > On Sat, Sep 8, 2018 at 1:50 PM Kristian Evensen > > wrote: > > > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > > > interfaces, without th

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-11-01 Thread Kristian Evensen
On Thu, Nov 1, 2018 at 6:40 PM Kristian Evensen wrote: > > Hi, > > On Sat, Sep 8, 2018 at 1:50 PM Kristian Evensen > wrote: > > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > > interfaces, without the device changing VID/PID or configuration number. > > When the configuratio

Re: Help with the BPF verifier

2018-11-01 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Thu, 1 Nov 2018 16:13:10 -0300 > Nope... this is inside an if: > > if (filename_arg <= 5) { > augmented_args.filename.reserved = 0; > augmented_args.filename.size = > probe_read_str(&augmented_args.filename.value, >

RE: [Intel-wired-lan] [PATCH][next] igc: fix error return handling from call to netif_set_real_num_tx_queues

2018-11-01 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Colin King > Sent: Friday, October 19, 2018 11:16 AM > To: Neftin, Sasha ; Kirsher, Jeffrey T > ; David S . Miller ; > intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; kernel-janit...@vger.kernel.org >

RE: [PATCH net-next] igc: Remove set but not used variable 'pci_using_dac'

2018-11-01 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:48 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Neftin, Sasha > Cc: YueHaibing ; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; kernel-janit...

RE: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'

2018-11-01 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:41 AM > To: Kirsher, Jeffrey T ; Neftin, Sasha > > Cc: YueHaibing ; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; kernel-janit...@vger.kernel.org >

Re: [PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2018 at 07:17:29PM +, Edward Cree escreveu: > On 31/10/18 23:05, Daniel Borkmann wrote: > > ALU operations on pointers such as scalar_reg += map_value_ptr are > > handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr > > and range in the register state share a un

Re: [PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-11-01 Thread Edward Cree
On 31/10/18 23:05, Daniel Borkmann wrote: > ALU operations on pointers such as scalar_reg += map_value_ptr are > handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr > and range in the register state share a union, so transferring state > through dst_reg->range = ptr_reg->range is

Re: Help with the BPF verifier

2018-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2018 at 12:10:39PM -0700, David Miller escreveu: > From: Arnaldo Carvalho de Melo > Date: Thu, 1 Nov 2018 15:52:17 -0300 > > > 50 unsigned int filename_arg = 6; > ... > > --- /wb/augmented_raw_syscalls.c.old2018-11-01 15:43:55.000394234 > > -0300 > > +++

Re: Help with the BPF verifier

2018-11-01 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Thu, 1 Nov 2018 15:52:17 -0300 > 50unsigned int filename_arg = 6; ... > --- /wb/augmented_raw_syscalls.c.old 2018-11-01 15:43:55.000394234 -0300 > +++ /wb/augmented_raw_syscalls.c 2018-11-01 15:44:15.102367838 -0300 > @@ -67,7 +67,7

Re: [Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread Eric Dumazet
On 11/01/2018 12:02 PM, Cong Wang wrote: > Most callers of pskb_trim_rcsum() simply drop the skb when > it fails, however, ip_check_defrag() still continues to pass > the skb up to stack. This is suspicious. > > In ip_check_defrag(), after we learn the skb is an IP fragment, > passing the skb t

[Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread Cong Wang
Most callers of pskb_trim_rcsum() simply drop the skb when it fails, however, ip_check_defrag() still continues to pass the skb up to stack. This is suspicious. In ip_check_defrag(), after we learn the skb is an IP fragment, passing the skb to callers makes no sense, because callers expect fragmen

Help with the BPF verifier

2018-11-01 Thread Arnaldo Carvalho de Melo
tl;dr: I seem to be trying to get past clang optimizations that get the verifier to accept my proggie. Hi, So I'm moving to use raw_syscalls:sys_exit to collect pointer contents, using maps to tell the bpf program what to copy, how many bytes, filters, etc. I'm at the star

Re: [RFC 0/2] Delayed binding of UDP sockets for Quic per-connection sockets

2018-11-01 Thread Eric Dumazet
On 11/01/2018 10:58 AM, Leif Hedstrom wrote: > > >> On Oct 31, 2018, at 6:53 PM, Eric Dumazet wrote: >> >> >> >> On 10/31/2018 04:26 PM, Christoph Paasch wrote: >>> Implementations of Quic might want to create a separate socket for each >>> Quic-connection by creating a connected UDP-socket.

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-11-01 Thread Kristian Evensen
Hi, On Sat, Sep 8, 2018 at 1:50 PM Kristian Evensen wrote: > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > interfaces, without the device changing VID/PID or configuration number. > When the configuration is updated and interfaces are added/removed, the > interface numbers

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 18:23, David Ahern pisze: On 11/1/18 7:52 AM, Paweł Staszewski wrote: W dniu 01.11.2018 o 11:55, Jesper Dangaard Brouer pisze: On Wed, 31 Oct 2018 21:37:16 -0600 David Ahern wrote: This is mainly a forwarding use case? Seems so based on the perf report. I suspect forw

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread David Ahern
On 11/1/18 7:52 AM, Paweł Staszewski wrote: > > > W dniu 01.11.2018 o 11:55, Jesper Dangaard Brouer pisze: >> On Wed, 31 Oct 2018 21:37:16 -0600 David Ahern wrote: >> >>> This is mainly a forwarding use case? Seems so based on the perf report. >>> I suspect forwarding with XDP would show pretty

Re: [RFC bpf-next] libbpf: increase rlimit before trying to create BPF maps

2018-11-01 Thread Quentin Monnet
2018-10-30 15:23 UTC+ ~ Quentin Monnet > The limit for memory locked in the kernel by a process is usually set to > 64 bytes by default. This can be an issue when creating large BPF maps. > A workaround is to raise this limit for the current process before > trying to create a new BPF map. Cha

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 12:09, Paweł Staszewski pisze: rx_cqe_compress_pkts: 0 If this is a pcie bottleneck it might be useful to  enable CQE compression (to reduce PCIe completion descriptors transactions) you should see the above rx_cqe_compress_pkts increasing when enabled. $ ethtool  --set-p

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Aaron Lu
On Thu, Nov 01, 2018 at 10:22:13AM +0100, Jesper Dangaard Brouer wrote: ... ... > Section copied out: > > mlx5e_poll_tx_cq > | >--16.34%--napi_consume_skb > | > |--12.65%--__free_pages_ok > | | > |

Re: [net 1/8] igb: shorten maximum PHC timecounter update interval

2018-11-01 Thread Miroslav Lichvar
On Wed, Oct 31, 2018 at 12:42:47PM -0700, Jeff Kirsher wrote: > From: Miroslav Lichvar > > The timecounter needs to be updated at least once per ~550 seconds in > order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old > timestamp. > > Since commit 500462a9d ("timers: Switch to a

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 11:55, Jesper Dangaard Brouer pisze: On Wed, 31 Oct 2018 21:37:16 -0600 David Ahern wrote: This is mainly a forwarding use case? Seems so based on the perf report. I suspect forwarding with XDP would show pretty good improvement. Yes, significant performance improvement

Re: [PATCH v1 net] net: dsa: microchip: initialize mutex before use

2018-11-01 Thread Pavel Machek
On Thu 2018-11-01 13:17:19, Andrew Lunn wrote: > On Wed, Oct 31, 2018 at 07:49:08PM -0700, tristram...@microchip.com wrote: > > From: Tristram Ha > > > > Initialize mutex before use. Avoid kernel complaint when > > CONFIG_DEBUG_LOCK_ALLOC is enabled. > > > > Fixes: b987e98e50ab90e5 ("dsa: add D

Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset

2018-11-01 Thread Alexey Kodanev
On 11/01/2018 04:11 PM, Alexey Kodanev wrote: > On 10/31/2018 08:35 PM, David Ahern wrote: >> On 10/31/18 10:55 AM, David Ahern wrote: >>> I think the simplest fix for 4.20 is to break the loop if ret is non-0 - >>> restore the previous behavior. >> >> that is the only recourse. It has to bail if

RE: [PATCH iproute2-next] rdma: Refresh help section of resource information

2018-11-01 Thread Steve Wise
> -Original Message- > From: Leon Romanovsky > Sent: Thursday, November 1, 2018 3:35 AM > To: David Ahern > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list ; > Stephen Hemminger ; Steve Wise > > Subject: [PATCH iproute2-next] rdma: Refresh help section of resource > information >

Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset

2018-11-01 Thread Alexey Kodanev
On 10/31/2018 08:35 PM, David Ahern wrote: > On 10/31/18 10:55 AM, David Ahern wrote: >> I think the simplest fix for 4.20 is to break the loop if ret is non-0 - >> restore the previous behavior. > > that is the only recourse. It has to bail if ret is non-0. Do you want > to send a patch with tha

Re: [PATCH v1 net] net: dsa: microchip: initialize mutex before use

2018-11-01 Thread Andrew Lunn
On Wed, Oct 31, 2018 at 07:49:08PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Initialize mutex before use. Avoid kernel complaint when > CONFIG_DEBUG_LOCK_ALLOC is enabled. > > Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") > Signed-off-by: Tri

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Jesper Dangaard Brouer
On Wed, 31 Oct 2018 21:37:16 -0600 David Ahern wrote: > This is mainly a forwarding use case? Seems so based on the perf report. > I suspect forwarding with XDP would show pretty good improvement. Yes, significant performance improvements. Notice Davids talk: "Leveraging Kernel Tables with XDP

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Paweł Staszewski
W dniu 01.11.2018 o 10:22, Jesper Dangaard Brouer pisze: On Wed, 31 Oct 2018 23:20:01 +0100 Paweł Staszewski wrote: W dniu 31.10.2018 o 23:09, Eric Dumazet pisze: On 10/31/2018 02:57 PM, Paweł Staszewski wrote: Hi So maybee someone will be interested how linux kernel handles normal traff

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-01 Thread Jesper Dangaard Brouer
On Wed, 31 Oct 2018 23:20:01 +0100 Paweł Staszewski wrote: > W dniu 31.10.2018 o 23:09, Eric Dumazet pisze: > > > > On 10/31/2018 02:57 PM, Paweł Staszewski wrote: > >> Hi > >> > >> So maybee someone will be interested how linux kernel handles > >> normal traffic (not pktgen :) ) Pawel is this

Re: [PATCH v2 net 3/3] net/mlx4_en: use __netdev_tx_sent_queue()

2018-11-01 Thread Tariq Toukan
On 31/10/2018 5:39 PM, Eric Dumazet wrote: > doorbell only depends on xmit_more and netif_tx_queue_stopped() > > Using __netdev_tx_sent_queue() avoids messing with BQL stop flag, > and is more generic. > > This patch increases performance on GSO workload by keeping > doorbells to the minimum re

[PATCH iproute2-next] rdma: Refresh help section of resource information

2018-11-01 Thread Leon Romanovsky
From: Leon Romanovsky After commit 4060e4c0d257 ("rdma: Add PD resource tracking information"), the resource information shows PDs and MRs, but help pages didn't fully reflect it. Signed-off-by: Leon Romanovsky --- rdma/res.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

[PATCH bpf 1/3] bpf: show real jited prog address in /proc/kallsyms

2018-11-01 Thread Song Liu
Currently, /proc/kallsyms shows page address of jited bpf program. This is not ideal for detailed profiling (find hot instructions from stack traces). This patch replaces the page address with real prog start address. Signed-off-by: Song Liu --- kernel/bpf/core.c | 4 +--- 1 file changed, 1 inse

[PATCH bpf 2/3] bpf: show real jited address in bpf_prog_info->jited_ksyms

2018-11-01 Thread Song Liu
Currently, jited_ksyms in bpf_prog_info shows page addresses of jited bpf program. This is not ideal for detailed profiling (find hot instructions from stack traces). This patch replaces the page address with real prog start address. Signed-off-by: Song Liu --- kernel/bpf/syscall.c | 1 - 1 file

[PATCH bpf 0/3] show more accurrate bpf program address

2018-11-01 Thread Song Liu
This set improves bpf program address showed in /proc/kallsyms and in bpf_prog_info. First, real program address is showed instead of page address. Second, when there is no subprogram, bpf_prog_info->jited_ksyms returns the main prog address. Song Liu (3): bpf: show real jited prog address in /p

[PATCH bpf 3/3] bpf: show main program address in bpf_prog_info->jited_ksyms

2018-11-01 Thread Song Liu
Currently, when there is not subprog (prog->aux->func_cnt == 0), bpf_prog_info does not return any jited_ksyms. This patch adds main program address (prog->bpf_func) to jited_ksyms. Signed-off-by: Song Liu --- kernel/bpf/syscall.c | 16 1 file changed, 12 insertions(+), 4 deleti