Fri, Oct 26, 2018 at 12:40:31AM CEST, jay.vosbu...@canonical.com wrote:
>Chas Williams <3ch...@gmail.com> wrote:
>
>>On 10/25/2018 05:59 PM, Jay Vosburgh wrote:
>>> Chas Williams <3ch...@gmail.com> wrote:
>>>
netif_is_lag_port should be used to identify link aggregation ports.
For this to
Similiar with ipv6 mcast commit 89225d1ce6af3 ("net: ipv6: mld: fix v1/v2
switchback timeout to rfc3810, 9.12.")
i) RFC3376 8.12. Older Version Querier Present Timeout says:
The Older Version Querier Interval is the time-out for transitioning
a host back to IGMPv3 mode once an older version
On 2018/10/26 10:37, Timur Tabi wrote:
> On 10/25/18 9:18 PM, Wang, Dongsheng wrote:
>> But when I was reading Documentation/acpi/DSD-properties-rules.txt, my
>> understanding is we should try to conform to DT bindings. So maybe ACPI
>> doesn't have such a document, just DT bindings.
> There was an
On 10/25/18 9:18 PM, Wang, Dongsheng wrote:
But when I was reading Documentation/acpi/DSD-properties-rules.txt, my
understanding is we should try to conform to DT bindings. So maybe ACPI
doesn't have such a document, just DT bindings.
There was an attempt to document DSDs, but it was abandoned
Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
change sysctl_mld_qrv after interface up, it will has no effect.
Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
Reported-by: Ying Xu
Signed-off-by: Hangbin Liu
---
net/ipv6/mcast.c | 1 +
1 f
Based on RFC 4541, 2.1.1. IGMP Forwarding Rules
The switch supporting IGMP snooping must maintain a list of
multicast routers and the ports on which they are attached. This
list can be constructed in any combination of the following ways:
a) This list should be built by the snooping swi
On 2018/10/26 3:24, Andrew Lunn wrote:
> On Thu, Oct 25, 2018 at 06:09:15PM +0800, Wang Dongsheng wrote:
>> Use "phy-handle" to porint an internal MDIO device port.
> Hi Dongsheng
>
> You are basically defining how all future ACPI based MAC drivers get
> access to their PHY. This needs to become pa
On Wed, Oct 24, 2018 at 10:05:42PM +0200, Daniel Borkmann wrote:
> Several fixes to get direct packet access in order from verifier
> side. Also test suite fix to run cg_skb as unpriv and an improvement
> to make direct packet write less error prone in future.
Applied, Thanks
From: Bjørn Mork
Date: Thu, 25 Oct 2018 21:18:25 +0200
> The cleanup path will put the target net when netnsid is set. So we must
> reset netnsid if the input is invalid.
>
> Fixes: d7e38611b81e ("net/ipv4: Put target net when address dump fails due to
> bad attributes")
> Fixes: 242afaa6968c
From: Bryan Whitehead
Date: Thu, 25 Oct 2018 13:09:38 -0400
> The SPI dependency does not apply to lan743x driver, and other
> drivers in the group already state their dependence on SPI.
>
> Signed-off-by: Bryan Whitehead
Yep, make sense.
Applied, thanks.
From: Eric Dumazet
Date: Thu, 25 Oct 2018 06:42:12 -0700
> Drivers using generic NAPI interface no longer need to include
> , since busy polling was moved to core networking
> stack long ago.
>
> See commit 79e7fff47b7b ("net: remove support for per driver
> ndo_busy_poll()") for reference.
>
>
From: Andrew Lunn
Date: Thu, 25 Oct 2018 14:42:38 +0200
> This driver got missed during the recent change of .features from a
> u32 to a pointer to a Linux bitmap. Change the initialisation from 0
> to PHY_10GBIT_FEATURES so removing the danger of a NULL pointer
> dereference.
>
> Fixes: 719655a
From: Heiner Kallweit
Date: Thu, 25 Oct 2018 18:40:19 +0200
> It was reported that WoL from S5 is broken (WoL from S3 works) and the
> analysis showed that during system shutdown the network interface was
> brought down already when the actual kernel shutdown started.
> Therefore netif_running()
On 10/24/2018 01:15 PM, Taehee Yoo wrote:
> The dev_map_notification() removes interface in devmap if
> unregistering interface's ifindex is same.
> But only checking ifindex is not enough because other netns can have
> same ifindex. so that wrong interface selection could occurred.
> Hence netdev
On 10/25/2018 04:47 PM, Naresh Kamboju wrote:
> BPF sockmap and hashmap are dependent on CONFIG_BPF_STREAM_PARSER and
> xskmap is dependent on CONFIG_XDP_SOCKETS
>
> Signed-off-by: Naresh Kamboju
Applied to bpf, thanks Naresh!
Chas Williams <3ch...@gmail.com> wrote:
>On 10/25/2018 05:59 PM, Jay Vosburgh wrote:
>> Chas Williams <3ch...@gmail.com> wrote:
>>
>>> netif_is_lag_port should be used to identify link aggregation ports.
>>> For this to work, we need to reorganize the bonding and team drivers
>>> so that the neces
On 10/25/2018 05:59 PM, Jay Vosburgh wrote:
Chas Williams <3ch...@gmail.com> wrote:
netif_is_lag_port should be used to identify link aggregation ports.
For this to work, we need to reorganize the bonding and team drivers
so that the necessary flags are set before dev_open is called.
commit
On 10/25/2018 05:10 PM, Jiri Pirko wrote:
Thu, Oct 25, 2018 at 11:02:27PM CEST, 3ch...@gmail.com wrote:
netif_is_lag_port should be used to identify link aggregation ports.
For this to work, we need to reorganize the bonding and team drivers
so that the necessary flags are set before dev_open
Chas Williams <3ch...@gmail.com> wrote:
>netif_is_lag_port should be used to identify link aggregation ports.
>For this to work, we need to reorganize the bonding and team drivers
>so that the necessary flags are set before dev_open is called.
>
>commit 31e77c93e432 ("sched/fair: Update blocked lo
Thu, Oct 25, 2018 at 11:02:27PM CEST, 3ch...@gmail.com wrote:
>netif_is_lag_port should be used to identify link aggregation ports.
>For this to work, we need to reorganize the bonding and team drivers
>so that the necessary flags are set before dev_open is called.
>
>commit 31e77c93e432 ("sched/fa
netif_is_lag_port should be used to identify link aggregation ports.
For this to work, we need to reorganize the bonding and team drivers
so that the necessary flags are set before dev_open is called.
commit 31e77c93e432 ("sched/fair: Update blocked load when newly idle")
made this decision origin
Hi,
I'm running into a weird issue at the DMA boundary for large packets
(>8192) that I can't explain. I'm hoping someone here has an idea on
why I'm seeing this issue.
This is the Synopsys DesignWare Ethernet GMAC core (3.74) using the
stmmac driver found at drivers/net/ethernet/stmicro/st
David,
Please promote mainline commit 285189c78eeb6f684a024b86fb5997d10c6aa564
[netfilter: use kvmalloc_array to allocate memory for hashtable] to
linux-4.18.y stable. As it happens this not only fixes the issue described in
the commit log, it also solves the issue of kmemleak reporting false p
On 10/25/18 1:18 PM, Bjørn Mork wrote:
> The cleanup path will put the target net when netnsid is set. So we must
> reset netnsid if the input is invalid.
>
> Fixes: d7e38611b81e ("net/ipv4: Put target net when address dump fails due to
> bad attributes")
> Fixes: 242afaa6968c ("net/ipv6: Put ta
On Thu, Oct 25, 2018 at 06:09:15PM +0800, Wang Dongsheng wrote:
> Use "phy-handle" to porint an internal MDIO device port.
Hi Dongsheng
You are basically defining how all future ACPI based MAC drivers get
access to their PHY. This needs to become part of the ACPI standard,
etc.
This code should
The cleanup path will put the target net when netnsid is set. So we must
reset netnsid if the input is invalid.
Fixes: d7e38611b81e ("net/ipv4: Put target net when address dump fails due to
bad attributes")
Fixes: 242afaa6968c ("net/ipv6: Put target net when address dump fails due to
bad attrib
On 10/25/18 12:43 PM, Bjørn Mork wrote:
>
> inet_valid_dump_ifaddr_req() will bail out with an error, but only
> *after* setting fillargs->netnsid:
>
> if (i == IFA_TARGET_NETNSID) {
> struct net *net;
>
> fillargs->netnsid = nla_ge
David Ahern writes:
> On 10/24/18 9:02 AM, David Ahern wrote:
>> On 10/24/18 3:36 AM, Li RongQing wrote:
>>> put net when input a invalid ifindex, otherwise it will be leaked
>>>
>>> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a
>>> specific device")
>>> Cc: David Ahern
On 10/25/18 11:32 AM, David Miller wrote:
> From:
> Date: Wed, 24 Oct 2018 14:51:23 -0700
>
>> From: Tristram Ha
>>
>> Socket buffer is not re-created when headroom is 2 and tailroom is 1.
>>
>> Signed-off-by: Tristram Ha
>
> Applied.
No fixes tag?
--
Florian
From: Wei Yongjun
Date: Thu, 25 Oct 2018 01:42:26 +
> The function nix_update_mce_list() is called from
> nix_update_bcast_mce_list(), and a spin lock is held
> here, so we should use GFP_ATOMIC instead.
>
> Fixes: 4b05528ebf0c ("octeontx2-af: Update bcast list upon NIXLF alloc/free")
> Sign
From:
Date: Wed, 24 Oct 2018 14:51:23 -0700
> From: Tristram Ha
>
> Socket buffer is not re-created when headroom is 2 and tailroom is 1.
>
> Signed-off-by: Tristram Ha
Applied.
From: Keyur Amrutbhai Patel
Date: Thu, 25 Oct 2018 17:22:02 +
> Current time consuming function are " netif_receive_skb " and "
> napi_alloc_skb " these two function calls are taking maximum about
> of time
netif_receive_skb() calls the entire networking stack receive path.
So measuring it b
On 10/24/2018 12:41 PM, Andre Tomt wrote:
>
> It eventually showed up again with mlx4, on 4.18.16 + fix and also on 4.19. I
> still do not have a useful packet capture.
>
> It is running a torrent client serving up various linux distributions.
>
Have you also applied this fix ?
https://git.
On 2018-10-25 17:57, Steve Grubb wrote:
> On Thu, 25 Oct 2018 08:27:32 -0400
> Richard Guy Briggs wrote:
>
> > On 2018-10-25 06:49, Paul Moore wrote:
> > > On Thu, Oct 25, 2018 at 2:06 AM Steve Grubb
> > > wrote:
> > > > On Wed, 24 Oct 2018 20:42:55 -0400
> > > > Richard Guy Briggs wrote:
>
Please do not top post, and use normal quoting.
On 10/25/2018 10:22 AM, Keyur Amrutbhai Patel wrote:
> Hi Eric,
>
> First of all thank you for replying and giving some spotlight.
>
> First step would be to read Documentation/networking/scaling.txt and see if
> anything there helps.
> - This
Hi Eric,
First of all thank you for replying and giving some spotlight.
First step would be to read Documentation/networking/scaling.txt and see if
anything there helps.
- This is good article. I had gone through it. Any suggestion on RSS? How to
configure it? Do I need to take care anything
The SPI dependency does not apply to lan743x driver, and other
drivers in the group already state their dependence on SPI.
Signed-off-by: Bryan Whitehead
---
drivers/net/ethernet/microchip/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/Kconfig
b/driver
The SPI dependency does not apply to lan743x driver, and other
drivers in the group already state their dependence on SPI.
Bryan Whitehead (1):
lan743x: Remove SPI dependency from Microchip group.
drivers/net/ethernet/microchip/Kconfig | 1 -
1 file changed, 1 deletion(-)
--
2.7.4
On 10/25/2018 08:39 AM, Keyur Amrutbhai Patel wrote:
> Hi,
>
> In my NIC driver "netif_receive_skb" is taking too long time. Almost 3375
> neno seconds. Which is more than whole packet processing from interrupt.
>
> Could anyone please help me to understand what could be the reason behind
>
Any help on this would be appreciated.
-Original Message-
From: netdev-ow...@vger.kernel.org On Behalf Of
Keyur Amrutbhai Patel
Sent: Thursday, October 25, 2018 9:09 PM
To: netdev@vger.kernel.org
Subject: netif_receive_skb is taking long time
Hi,
In my NIC driver "netif_receive_skb" i
It was reported that WoL from S5 is broken (WoL from S3 works) and the
analysis showed that during system shutdown the network interface was
brought down already when the actual kernel shutdown started.
Therefore netif_running() returned false and as a consequence the PHY
was suspended. Obviously W
Hi,
In my NIC driver "netif_receive_skb" is taking too long time. Almost 3375 neno
seconds. Which is more than whole packet processing from interrupt.
Could anyone please help me to understand what could be the reason behind this?
How to solve it to take minimum time?
Is there any standard cal
On Tue, 9 Oct 2018 at 01:08, Song Liu wrote:
>
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -253,6 +253,8 @@ enum bpf_attach_type {
> > #define BPF_F_NO_COMMON_LRU(1U << 1)
> > /* Specify numa node during map creation */
> > #define BPF_F_NUMA_NODE
On Tue, 9 Oct 2018 at 01:12, Song Liu wrote:
>
> On Mon, Oct 8, 2018 at 3:34 AM Lorenz Bauer wrote:
> >
> > Synchronize changes to linux/bpf.h from
> > commit 88db241b34bf ("bpf: allow zero-initializing hash map seed").
> I guess we cannot keep this hash during git-am? We probably don't
> need th
On Thu, Oct 25, 2018 at 2:00 PM Jiri Pirko wrote:
>
> Thu, Oct 25, 2018 at 02:26:51PM CEST, john.hur...@netronome.com wrote:
> >Add a helper function to determine if the type of a netdev is geneve based
> >on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels
> >to check the un
On Thu, Oct 25, 2018 at 1:58 PM Jiri Pirko wrote:
>
> Thu, Oct 25, 2018 at 02:26:49PM CEST, john.hur...@netronome.com wrote:
> >This patchset introduces an alternative to egdev offload by allowing a
> >driver to register for block updates when an external device (e.g. tunnel
> >netdev) is bound to
BPF sockmap and hashmap are dependent on CONFIG_BPF_STREAM_PARSER and
xskmap is dependent on CONFIG_XDP_SOCKETS
Signed-off-by: Naresh Kamboju
---
tools/testing/selftests/bpf/config | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/config
b/tools/testing/selftests
Drivers using generic NAPI interface no longer need to include
, since busy polling was moved to core networking
stack long ago.
See commit 79e7fff47b7b ("net: remove support for per driver
ndo_busy_poll()") for reference.
Signed-off-by: Eric Dumazet
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c
Hi,
I'm sorry for lagging behind, this one felt outside my radar.
On Mon, 2018-10-22 at 12:06 -0400, Willem de Bruijn wrote:
> @@ -2431,7 +2435,9 @@ int udp_lib_setsockopt(struct sock *sk, int level, int
> optname,
> > /* FALLTHROUGH */
> > case UDP_ENCAP_
Thu, Oct 25, 2018 at 02:26:51PM CEST, john.hur...@netronome.com wrote:
>Add a helper function to determine if the type of a netdev is geneve based
>on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels
>to check the underlying type of the device.
>
>A recent patch added a simila
Thu, Oct 25, 2018 at 02:26:49PM CEST, john.hur...@netronome.com wrote:
>This patchset introduces an alternative to egdev offload by allowing a
>driver to register for block updates when an external device (e.g. tunnel
>netdev) is bound to a TC block. Drivers can track new netdevs or register
>to ex
This driver got missed during the recent change of .features from a
u32 to a pointer to a Linux bitmap. Change the initialisation from 0
to PHY_10GBIT_FEATURES so removing the danger of a NULL pointer
dereference.
Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode
bitm
Recent changes to NFP mean that stats updates from fw to driver no longer
require a flow lookup and (because egdev offload has been removed) the
ingress netdev for a lookup is now always known.
Remove obsolete code in a flow lookup that matches on host context and
that allows for a netdev to be NU
Add support structures and functions that can be used by NFP to impliment
the indirect block register functionality of TC.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/flower/main.c | 13 +++
drivers/net/ethernet/netronome/nfp/flower/main.h
Previously, TC block tunnel decap rules were only offloaded when a
callback was triggered through registration of the rules egress device.
This meant that the driver had no access to the ingress netdev and so
could not verify it was the same tunnel type that the rule implied.
Register tunnel devic
Previously, only tunnel decap rules required egdev registration for
offload in NFP. These are now supported via indirect TC block callbacks.
Remove the egdev code from NFP.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/flower/main.c | 12
Add a helper function to determine if the type of a netdev is geneve based
on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels
to check the underlying type of the device.
A recent patch added a similar helper to vxlan.h
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Previously the offload functions in NFP assumed that the ingress (or
egress) netdev passed to them was an nfp repr.
Modify the driver to permit the passing of non repr netdevs as the ingress
device for an offload rule candidate. This may include devices such as
tunnels. The driver should then base
Offload of geneve decap rules is supported in NFP. Include geneve in the
check for supported types.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/netro
This patchset introduces an alternative to egdev offload by allowing a
driver to register for block updates when an external device (e.g. tunnel
netdev) is bound to a TC block. Drivers can track new netdevs or register
to existing ones to receive information on such events. Based on this,
they may
Currently drivers can register to receive TC block bind/unbind callbacks
by implementing the setup_tc ndo in any of their given netdevs. However,
drivers may also be interested in binds to higher level devices (e.g.
tunnel drivers) to potentially offload filters applied to them.
Introduce indirect
From: Karsten Graul
The pointer to the link group is unset in the smc connection structure
right before the call to smc_buf_unuse. Provide the lgr pointer to
smc_buf_unuse explicitly.
And move the call to smc_lgr_schedule_free_work to the end of
smc_conn_free.
Fixes: a6920d1d130c ("net/smc: hand
Use "phy-handle" to porint an internal MDIO device port.
Signed-off-by: Wang Dongsheng
---
drivers/net/ethernet/qualcomm/emac/emac-phy.c | 115 +++---
1 file changed, 100 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-phy.c
b/drivers/net/etherne
The emac include MDIO controller, and the motherboard has more than one
PHY connected to an MDIO bus. So share the shared mii_bus for others MAC
device that not has MDIO bus connected.
Based on ACPI, since "phy-handle" cannot directly point to a _DSD
sub-package, so we use "phy-handle" to point an
This patch separate emac_mdio_bus_create and emac_get_phydev from
emac_phy_config, and do some codes clean.
Signed-off-by: Wang Dongsheng
---
drivers/net/ethernet/qualcomm/emac/emac-phy.c | 96 +++
1 file changed, 56 insertions(+), 40 deletions(-)
diff --git a/drivers/net/ethern
On 10/24/18 22:12, Andrew Lunn wrote:
On Wed, Oct 24, 2018 at 09:36:02PM +0200, Holger Hoffstätte wrote:
Hi,
Since 4.19 r8169 depends on phylib:
$lsmod | grep r8169
r8169 81920 0
libphy 57344 2 r8169,realtek
Unfortunately this now gives me the following sysf
On 10/25/2018 5:54 PM, Naresh Kamboju wrote:
On Tue, 9 Oct 2018 at 12:32, Song Liu wrote:
On Mon, Oct 8, 2018 at 6:07 PM Prashant Bhole
wrote:
map_lookup_elem isn't supported by certain map types like:
- BPF_MAP_TYPE_PROG_ARRAY
- BPF_MAP_TYPE_STACK_TRACE
- BPF_MAP_TYPE_XSKMAP
- BPF_MAP_T
On Tue, 9 Oct 2018 at 12:32, Song Liu wrote:
>
> On Mon, Oct 8, 2018 at 6:07 PM Prashant Bhole
> wrote:
> >
> > map_lookup_elem isn't supported by certain map types like:
> > - BPF_MAP_TYPE_PROG_ARRAY
> > - BPF_MAP_TYPE_STACK_TRACE
> > - BPF_MAP_TYPE_XSKMAP
> > - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE
Sorry, please ignore this patch.
Cheers,
-Dongsheng
> -Original Message-
> From: Wang, Dongsheng
> Sent: Thursday, October 25, 2018 4:15 PM
> To: ti...@kernel.org; and...@lunn.ch
> Cc: netdev@vger.kernel.org; Wang, Dongsheng
> ; Zheng, Joey
> ; f.faine...@gmail.com
> Subject: [PATCH v3 0
The emac include MDIO controller, and the motherboard has more than one
PHY connected to an MDIO bus. So share the shared mii_bus for others MAC
device that not has MDIO bus connected.
Based on ACPI, since "phy-handle" cannot directly point to a _DSD
sub-package, so we use "phy-handle" to point an
70 matches
Mail list logo
