Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-04 Thread Jiri Olsa
On Thu, Oct 04, 2018 at 03:10:15PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 04, 2018 at 10:22:31PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 4 Oct 2018 21:41:17 +0200 Daniel Borkmann > > wrote: > > > > > On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > > > > On Thu, 4 Oct 201

Re: [PATCH] net/packet: fix packet drop as of virtio gso

2018-10-04 Thread David Miller
From: Jianfeng Tan Date: Sat, 29 Sep 2018 15:41:27 + > When we use raw socket as the vhost backend, a packet from virito with > gso offloading information, cannot be sent out in later validaton at > xmit path, as we did not set correct skb->protocol which is further used > for looking up the

Re: [PATCH v2 0/5] Introducing ixgbe AF_XDP ZC support

2018-10-04 Thread Björn Töpel
On 2018-10-04 23:18, Jesper Dangaard Brouer wrote: I see similar performance numbers, but my system can crash with 'txonly'. Thanks for finding this, Jesper! Can you give me your "lspci -vvv" dump of your NIC, so I know what ixgbe flavor you've got? I'll dig into it right away. Björn

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-04 Thread David Miller
From: David Ahern Date: Thu, 4 Oct 2018 20:07:50 -0700 > From: David Ahern > > As part of the IPv6 fib info refactoring, the intent was to make metrics > handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy > led to confusion and a couple of incomplete attempts at finding and

RE: [PATCH 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2018-10-04 Thread Pankaj Bansal
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, October 5, 2018 9:22 AM > To: Pankaj Bansal > Cc: Florian Fainelli ; netdev@vger.kernel.org; > Alexandru Marginean > Subject: Re: [PATCH 2/2] netdev/phy: add MDIO bus multiplexer driven by a > regm

Re: [PATCH v3] net/ncsi: Add NCSI OEM command support

2018-10-04 Thread Samuel Mendoza-Jonas
On Wed, 2018-10-03 at 16:32 -0700, Vijay Khemka wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for OEM > comma

Re: [PATCH net-next] net: sched: remove unused helpers

2018-10-04 Thread David Miller
From: Jakub Kicinski Date: Thu, 4 Oct 2018 17:07:51 -0700 > tcf_block_dev() doesn't seem to be used anywhere in the tree. > > Signed-off-by: Jakub Kicinski Applied.

Re: [PATCH net 0/4] bnxt_en: Misc. bug fixes.

2018-10-04 Thread David Miller
From: Michael Chan Date: Fri, 5 Oct 2018 00:25:59 -0400 > 4 small bug fixes related to setting firmware message enables bits, possible > memory leak when probe fails, and ring accouting when RDMA driver is loaded. > > Please queue these for -stable as well. Thanks. Series applied and queued u

RE: [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2018-10-04 Thread Pankaj Bansal
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, October 5, 2018 8:38 AM > To: Pankaj Bansal > Cc: Florian Fainelli ; netdev@vger.kernel.org; > Alexandru Marginean > Subject: Re: [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven > by

[PATCH net 2/4] bnxt_en: Fix enables field in HWRM_QUEUE_COS2BW_CFG request

2018-10-04 Thread Michael Chan
From: Vasundhara Volam In HWRM_QUEUE_COS2BW_CFG request, enables field should have the bits set only for the queue ids which are having the valid parameters. This causes firmware to return error when the TC to hardware CoS queue mapping is not 1:1 during DCBNL ETS setup. Fixes: 2e8ef77ee0ff ("b

[PATCH net 1/4] bnxt_en: Fix VNIC reservations on the PF.

2018-10-04 Thread Michael Chan
The enables bit for VNIC was set wrong when calling the HWRM_FUNC_CFG firmware call to reserve VNICs. This has the effect that the firmware will keep a large number of VNICs for the PF, and having very few for VFs. DPDK driver running on the VFs, which requires more VNICs, may not work properly a

[PATCH net 3/4] bnxt_en: free hwrm resources, if driver probe fails.

2018-10-04 Thread Michael Chan
From: Venkat Duvvuru When the driver probe fails, all the resources that were allocated prior to the failure must be freed. However, hwrm dma response memory is not getting freed. This patch fixes the problem described above. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed

[PATCH net 0/4] bnxt_en: Misc. bug fixes.

2018-10-04 Thread Michael Chan
4 small bug fixes related to setting firmware message enables bits, possible memory leak when probe fails, and ring accouting when RDMA driver is loaded. Please queue these for -stable as well. Thanks. Michael Chan (1): bnxt_en: Fix VNIC reservations on the PF. Vasundhara Volam (2): bnxt_en

[PATCH net 4/4] bnxt_en: get the reduced max_irqs by the ones used by RDMA

2018-10-04 Thread Michael Chan
From: Vasundhara Volam When getting the max rings supported, get the reduced max_irqs by the ones used by RDMA. If the number MSIX is the limiting factor, this bug may cause the max ring count to be higher than it should be when RDMA driver is loaded and may result in ring allocation failures.

Re: [RFC v2 bpf-next 5/5] selftests/bpf: verifier, check bpf_map_lookup_elem access in bpf prog

2018-10-04 Thread Prashant Bhole
On 10/5/2018 10:51 AM, Alexei Starovoitov wrote: On Tue, Oct 02, 2018 at 02:35:19PM +0900, Prashant Bhole wrote: map_lookup_elem isn't supported by certain map types like: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH L

Re: [RFC v2 bpf-next 5/5] selftests/bpf: verifier, check bpf_map_lookup_elem access in bpf prog

2018-10-04 Thread Alexei Starovoitov
On Tue, Oct 02, 2018 at 02:35:19PM +0900, Prashant Bhole wrote: > map_lookup_elem isn't supported by certain map types like: > - BPF_MAP_TYPE_PROG_ARRAY > - BPF_MAP_TYPE_STACK_TRACE > - BPF_MAP_TYPE_XSKMAP > - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH > Let's add verfier tests to check whether ver

Re: [RFC v2 bpf-next 2/5] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-10-04 Thread Alexei Starovoitov
On Fri, Oct 05, 2018 at 09:16:04AM +0900, Prashant Bhole wrote: > > > On 10/5/2018 9:10 AM, Alexei Starovoitov wrote: > > On Tue, Oct 02, 2018 at 02:35:16PM +0900, Prashant Bhole wrote: > > > Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below > > > map types: > > > - BPF_MAP_TYPE

Re: [PATCH iproute2-next] tc: jsonify output of q_fifo

2018-10-04 Thread Jakub Kicinski
On Thu, 4 Oct 2018 17:10:58 -0700, Stephen Hemminger wrote: > On Thu, 4 Oct 2018 17:08:34 -0700 > Jakub Kicinski wrote: > > > Print limits correctly in JSON context. > > > > Signed-off-by: Jakub Kicinski > > --- > > tc/q_fifo.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-

[PATCH net-next] net: sched: remove unused helpers

2018-10-04 Thread Jakub Kicinski
tcf_block_dev() doesn't seem to be used anywhere in the tree. Signed-off-by: Jakub Kicinski --- include/net/pkt_cls.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 313fe840742d..338ef054bf16 100644 --- a/include/net/pkt_cls.h +

Re: [RFC v2 bpf-next 2/5] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-10-04 Thread Alexei Starovoitov
On Tue, Oct 02, 2018 at 02:35:16PM +0900, Prashant Bhole wrote: > Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below > map types: > - BPF_MAP_TYPE_PROG_ARRAY > - BPF_MAP_TYPE_STACK_TRACE > - BPF_MAP_TYPE_XSKMAP > - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH > > Signed-off-by: Pras

Re: [RFC v2 bpf-next 2/5] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-10-04 Thread Prashant Bhole
On 10/5/2018 9:10 AM, Alexei Starovoitov wrote: On Tue, Oct 02, 2018 at 02:35:16PM +0900, Prashant Bhole wrote: Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below map types: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BPF_

[PATCH iproute2-next] tc: jsonify output of q_fifo

2018-10-04 Thread Jakub Kicinski
Print limits correctly in JSON context. Signed-off-by: Jakub Kicinski --- tc/q_fifo.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tc/q_fifo.c b/tc/q_fifo.c index cb86a404d4de..61493fbbc5bc 100644 --- a/tc/q_fifo.c +++ b/tc/q_fifo.c @@ -69,9 +69,12 @@ static int f

Re: [PATCH iproute2-next] tc: jsonify output of q_fifo

2018-10-04 Thread Stephen Hemminger
On Thu, 4 Oct 2018 17:08:34 -0700 Jakub Kicinski wrote: > Print limits correctly in JSON context. > > Signed-off-by: Jakub Kicinski > --- > tc/q_fifo.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tc/q_fifo.c b/tc/q_fifo.c > index cb86a404d4de..61493fbbc5

Re: [RFC PATCH bpf-next v4 7/7] selftests/bpf: add test cases for queue and stack maps

2018-10-04 Thread Alexei Starovoitov
On Thu, Oct 04, 2018 at 07:13:00PM +0200, Mauricio Vasquez B wrote: > Two types of tests are done: > - test_maps: only userspace api. > - test_progs: userspace api and ebpf helpers. > > Signed-off-by: Mauricio Vasquez B overall looks very close. thank for you working on it. please fix the nits a

Re: [RFC PATCH bpf-next v4 5/7] bpf: restrict use of peek/push/pop

2018-10-04 Thread Alexei Starovoitov
On Thu, Oct 04, 2018 at 07:12:49PM +0200, Mauricio Vasquez B wrote: > Restrict the use of peek, push and pop helpers only to queue and stack > maps. > > Signed-off-by: Mauricio Vasquez B > --- > kernel/bpf/verifier.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/ker

Re: [RFC PATCH bpf-next v4 4/7] bpf: add bpf queue and stack maps

2018-10-04 Thread Alexei Starovoitov
On Thu, Oct 04, 2018 at 07:12:44PM +0200, Mauricio Vasquez B wrote: > Implement two new kind of maps that support the peek, push and pop > operations. > > A use case for this is to keep track of a pool of elements, like > network ports in a SNAT. > > Signed-off-by: Mauricio Vasquez B > --- > in

Re: [RFC PATCH bpf-next v4 3/7] bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall

2018-10-04 Thread Alexei Starovoitov
On Thu, Oct 04, 2018 at 07:12:39PM +0200, Mauricio Vasquez B wrote: > The following patch implements a bpf queue/stack maps that > provides the peek/pop/push functions. There is not a direct > relationship between those functions and the current maps > syscalls, hence a new MAP_LOOKUP_AND_DELETE_E

[PATCH] ixgbe: allow IPsec Tx offload in VEPA mode

2018-10-04 Thread Shannon Nelson
When it's possible that the PF might end up trying to send a packet to one of its own VFs, we have to forbid IPsec offload because the device drops the packets into a black hole. See commit 47b6f50077e6 ("ixgbe: disallow IPsec Tx offload when in SR-IOV mode") for more info. This really is only nec

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-04 Thread Song Liu
Hi Jesper, On Wed, Oct 3, 2018 at 7:04 AM Jesper Dangaard Brouer wrote: > > On Tue, 25 Sep 2018 22:36:39 -0700 > Song Liu wrote: > > > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > > wrote: > > > > > > XDP can modify (and resize) the Ethernet header in the packet. > > > > > > There i

[PATCH iproute2 net-next v2 6/6] taprio: Add manpage for tc-taprio(8)

2018-10-04 Thread Vinicius Costa Gomes
This documents the parameters and provides an example of usage. Signed-off-by: Vinicius Costa Gomes --- man/man8/tc-taprio.8 | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 man/man8/tc-taprio.8 diff --git a/man/man8/tc-taprio.8 b/man/man8

[PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve a __s64 from a netlink msg

2018-10-04 Thread Vinicius Costa Gomes
This allows signed 64-bit integers to be retrieved from a netlink message. --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 9d9249e6..88164975 100644 --- a/include/libnetlink.h +++ b/include/libnetlink.h @@ -185,6

[PATCH iproute2 net-next v2 3/6] libnetlink: Add helper for getting a __s32 from netlink msgs

2018-10-04 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia This function retrieves a signed 32-bit integer from a netlink message and returns it. Signed-off-by: Jesus Sanchez-Palencia --- include/libnetlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 88164975.

[PATCH iproute2 net-next v2 5/6] tc: Add support for configuring the taprio scheduler

2018-10-04 Thread Vinicius Costa Gomes
This traffic scheduler allows traffic classes states (transmission allowed/not allowed, in the simplest case) to be scheduled, according to a pre-generated time sequence. This is the basis of the IEEE 802.1Qbv specification. Example configuration: tc qdisc replace dev enp3s0 parent root handle 10

[PATCH iproute2 net-next v2 1/6] utils: Implement get_s64()

2018-10-04 Thread Vinicius Costa Gomes
Add this helper to read signed 64-bit integers from a string. Signed-off-by: Vinicius Costa Gomes --- include/utils.h | 1 + lib/utils.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/utils.h b/include/utils.h index 8cb4349e..58574a05 100644 --- a/includ

[PATCH iproute2 net-next v2 4/6] include: add definitions for taprio [DO NOT COMMIT]

2018-10-04 Thread Vinicius Costa Gomes
DO NOT COMMIT This patch exists only to ease the testing, until this header is updated with the definitions from the kernel. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 52 -- 1 file changed, 49 insertions(+), 3 deletions(-) diff --g

[PATCH iproute2 net-next v2 0/6] Introduce the taprio scheduler

2018-10-04 Thread Vinicius Costa Gomes
Hi, Changes from v1: - Remove references to the "H" (Set-Gates-And-Hold-MAC) and "R" (Set-Gates-And-Release-MAC) commands, as these commands will only be used when Frame Preemption support is added (David Ahern); - Moved the functions that print and read commands to be closer (David

Re: [PATCH v2] typo fix in Documentation/networking/af_xdp.rst

2018-10-04 Thread Daniel Borkmann
On 10/04/2018 07:38 PM, Björn Töpel wrote: > Den tors 4 okt. 2018 kl 19:03 skrev Konrad Djimeli : >> >> Fix a simple typo: Completetion -> Completion >> >> Signed-off-by: Konrad Djimeli >> --- >> Changes in v2: >> - Update line below to be same length as text above >> >> Documentation/networking/

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-04 Thread Alexei Starovoitov
On Thu, Oct 04, 2018 at 10:22:31PM +0200, Jesper Dangaard Brouer wrote: > On Thu, 4 Oct 2018 21:41:17 +0200 Daniel Borkmann > wrote: > > > On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > > > On Thu, 4 Oct 2018 10:11:43 -0700 Alexei Starovoitov > > > wrote: > > >> On Thu, Oct 04, 2018

[PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set nlmsg_len

2018-10-04 Thread David Ahern
From: David Ahern Some of the inner headers are not 4-byte aligned, so use NLMSG_LENGTH instead of sizeof(req) to set nlmsg_len. Signed-off-by: David Ahern --- lib/libnetlink.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/libnetlink.c b/lib/libnetlin

[PATCH net-next 00/20] rtnetlink: Add support for rigid checking of data in dump request

2018-10-04 Thread David Ahern
From: David Ahern There are many use cases where a user wants to influence what is returned in a dump for some rtnetlink command: one is wanting data for a different namespace than the one the request is received and another is limiting the amount of data returned in the dump to a specific set of

[PATCH net-next 13/20] rtnetlink: Update fib dumps for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Add helper to check netlink message for route dumps. If the strict flag is set the dump request is expected to have an rtmsg struct as the header. All elements of the struct are expected to be 0 with the exception of rtm_flags (which is used by both ipv4 and ipv6 dumps) and no a

[PATCH net-next 16/20] net/namespace: Update rtnl_net_dumpid for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update rtnl_net_dumpid for strict data checking. If the flag is set, the dump request is expected to have an rtgenmsg struct as the header which has the family as the only element. No data may be appended. Signed-off-by: David Ahern --- net/core/net_namespace.c | 8

[PATCH net-next 06/20] net/ipv4: Update inet_dump_ifaddr for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update inet_dump_ifaddr for strict data checking. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the da

[PATCH net-next 15/20] net/neighbor: Update neightbl_dump_info for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update neightbl_dump_info for strict data checking. If the flag is set, the dump request is expected to have an ndtmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/core/neighbour.c

[PATCH net-next 01/20] netlink: Pass extack to dump handlers

2018-10-04 Thread David Ahern
From: David Ahern Declare extack in netlink_dump and pass to dump handlers via netlink_callback. Add any extack message after the dump_done_errno allowing error messages to be returned. This will be useful when strict checking is done on dump requests, returning why the dump fails EINVAL. Signed

[PATCH net-next 03/20] net: Add extack to nlmsg_parse

2018-10-04 Thread David Ahern
From: David Ahern Make sure extack is passed to nlmsg_parse where easy to do so. Most of these are dump handlers and leveraging the extack in the netlink_callback. Signed-off-by: David Ahern --- net/core/devlink.c | 2 +- net/core/neighbour.c | 3 ++- net/core/rtnetlink.c

[PATCH net-next 18/20] net/ipv6: Update ip6addrlbl_dump for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update ip6addrlbl_dump for strict data checking. If the flag is set, the dump request is expected to have an ifaddrlblmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/ipv6/addrlabel

[PATCH net-next 05/20] netlink: Add new socket option to enable strict checking on dumps

2018-10-04 Thread David Ahern
From: David Ahern Add a new socket option, NETLINK_DUMP_STRICT_CHK, that userspace can use via setsockopt to request strict checking of headers and attributes on dump requests. To get dump features such as kernel side filtering based on data in the header or attributes appended to the dump reque

[PATCH net-next 19/20] net: Update netconf dump handlers for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update inet_netconf_dump_devconf, inet6_netconf_dump_devconf, and mpls_netconf_dump_devconf for strict data checking. If the flag is set, the dump request is expected to have an netconfmsg struct as the header. The struct only has the family member and no attributes can be appen

[PATCH net-next 09/20] rtnetlink: Update rtnl_bridge_getlink for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update rtnl_bridge_getlink for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the

[PATCH net-next 12/20] rtnetlink: Update ipmr_rtm_dumplink for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update ipmr_rtm_dumplink for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/ipv4/ipmr.c | 3

[PATCH net-next 04/20] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-04 Thread David Ahern
From: David Ahern Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid into it. Signed-off-by: David Ahern Acked-by: Christian Brauner --- net/ipv6/addrconf.c | 57 - 1 file changed, 30 insertions(+), 27 deletions(-) diff --gi

[PATCH net-next 07/20] net/ipv6: Update inet6_dump_addr for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update inet6_dump_addr for strict data checking. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the dat

[PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update inet6_dump_ifinfo for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/ipv6/addrconf.c

[PATCH net-next 10/20] rtnetlink: Update rtnl_stats_dump for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update rtnl_stats_dump for strict data checking. If the flag is set, the dump request is expected to have an if_stats_msg struct as the header. All elements of the struct are expected to be 0 except filter_mask which must be non-0 (legacy behavior). No attributes are supported.

[PATCH net-next 17/20] net/fib_rules: Update fib_nl_dumprule for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update fib_nl_dumprule for strict data checking. If the flag is set, the dump request is expected to have fib_rule_hdr struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/core/fib_rules.c

[PATCH net-next 14/20] net/neighbor: Update neigh_dump_info for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update neigh_dump_info for strict data checking. If the flag is set, the dump request is expected to have an ndmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the data re

[PATCH net-next 08/20] rtnetlink: Update rtnl_dump_ifinfo for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update rtnl_dump_ifinfo for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the da

[PATCH net-next 20/20] net/bridge: Update br_mdb_dump for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update br_mdb_dump for strict data checking. If the flag is set, the dump request is expected to have a br_port_msg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/bridge/br_mdb.c | 29

[PATCH net-next 02/20] netlink: Add extack message to nlmsg_parse for invalid header length

2018-10-04 Thread David Ahern
From: David Ahern Give a user a reason why EINVAL is returned in nlmsg_parse. Signed-off-by: David Ahern --- include/net/netlink.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/netlink.h b/include/net/netlink.h index 589683091f16..9522a0bf1f3a 100644 --- a/

Re: [PATCH v2 0/5] Introducing ixgbe AF_XDP ZC support

2018-10-04 Thread Jesper Dangaard Brouer
On Tue, 2 Oct 2018 10:00:29 +0200 Björn Töpel wrote: > From: Björn Töpel > > Jeff: Please remove the v1 patches from your dev-queue! > > This patch set introduces zero-copy AF_XDP support for Intel's ixgbe > driver. > > The ixgbe zero-copy code is located in its own file ixgbe_xsk.[ch], > an

Re: [PATCH net] team: Forbid enslaving team device to itself

2018-10-04 Thread David Miller
From: Ido Schimmel Date: Mon, 1 Oct 2018 12:21:59 +0300 > team's ndo_add_slave() acquires 'team->lock' and later tries to open the > newly enslaved device via dev_open(). This emits a 'NETDEV_UP' event > that causes the VLAN driver to add VLAN 0 on the team device. team's > ndo_vlan_rx_add_vid()

Re: [PATCHv2 net-next] geneve: allow to clear ttl inherit

2018-10-04 Thread David Miller
From: Hangbin Liu Date: Sat, 29 Sep 2018 23:06:29 +0800 > As Michal remaind, we should allow to clear ttl inherit. Then we will > have three states: > > 1. set the flag, and do ttl inherit. > 2. do not set the flag, use configured ttl value, or default ttl (0) if >not set. > 3. disable ttl i

Re: [PATCH net-next v1 1/1] tc: Add support for configuring the taprio scheduler

2018-10-04 Thread David Miller
From: Vinicius Costa Gomes Date: Fri, 28 Sep 2018 17:59:43 -0700 > This traffic scheduler allows traffic classes states (transmission > allowed/not allowed, in the simplest case) to be scheduled, according > to a pre-generated time sequence. This is the basis of the IEEE > 802.1Qbv specification.

Re: [PATCH v4 net-next 0/9] bnxt_en: devlink param updates

2018-10-04 Thread David Miller
From: Jiri Pirko Date: Thu, 4 Oct 2018 12:39:40 +0200 > Thu, Oct 04, 2018 at 07:43:43AM CEST, vasundhara-v.vo...@broadcom.com wrote: >>This patchset adds support for 3 generic and 1 driver-specific devlink >>parameters. Add documentation for these configuration parameters. >> >>Also, this patchse

Re: [PATCH net-next,v2] IPv6 ifstats separation

2018-10-04 Thread Eric Dumazet
On 10/04/2018 12:08 PM, Stephen Suryaputra wrote: > Separate IPv6 ifstats into the ones that are hit on fast path and > the ones that aren't. The ones that are not can be removed as needed > using sysctls. > > The separation minimizes percpu data. It reduces from 288 bytes per cpu to 56 > bytes

Re: [PATCH v2 net-next] rtnetlink: fix rtnl_fdb_dump() for ndmsg header

2018-10-04 Thread David Ahern
On 10/1/18 7:46 PM, Mauricio Faria de Oliveira wrote: > Currently, rtnl_fdb_dump() assumes the family header is 'struct ifinfomsg', > which is not always true -- 'struct ndmsg' is used by iproute2 ('ip neigh'). > > The problem is, the function bails out early if nlmsg_parse() fails, which > does o

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-04 Thread Jesper Dangaard Brouer
On Thu, 4 Oct 2018 21:41:17 +0200 Daniel Borkmann wrote: > On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > > On Thu, 4 Oct 2018 10:11:43 -0700 Alexei Starovoitov > > wrote: > >> On Thu, Oct 04, 2018 at 03:50:38PM +0200, Daniel Borkmann wrote: [...] > >> > >> If the purpose of the pa

Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

2018-10-04 Thread John W. Linville
On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote: > Struct sff_diags can be used uninitialized at sff8636_show_dom, this > caused the tool to show unreported fields (supports_alarms) by the lower > level driver. > > In addition, make sure the same struct is being initialized at > sf

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-04 Thread John W. Linville
On Thu, Oct 04, 2018 at 05:06:29PM +0100, Edward Cree wrote: > On 04/10/18 15:08, John W. Linville wrote: > > Ping? > > > > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > >> Is this patch still RFC? > Feel free to de-RFC and apply it. Great -- queued for next release. John --

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-04 Thread Daniel Borkmann
On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > On Thu, 4 Oct 2018 10:11:43 -0700 > Alexei Starovoitov wrote: >> On Thu, Oct 04, 2018 at 03:50:38PM +0200, Daniel Borkmann wrote: >>> Allow for audit messages to be emitted upon BPF program load and >>> unload for having a timeline of events.

Re: icmp6_send() is too expensive

2018-10-04 Thread David Miller
From: Jeff Barnhill <0xeff...@gmail.com> Date: Thu, 4 Oct 2018 15:02:39 -0400 > As mentioned here: > https://www.spinics.net/lists/netdev/msg505054.html > > icmp6_send() can be expensive when there are a lot of devices and > anycast addresses. One solution I've prototyped is adding a global > has

[PATCH net-next,v2] IPv6 ifstats separation

2018-10-04 Thread Stephen Suryaputra
Separate IPv6 ifstats into the ones that are hit on fast path and the ones that aren't. The ones that are not can be removed as needed using sysctls. The separation minimizes percpu data. It reduces from 288 bytes per cpu to 56 bytes. When the other stats are disabled, then it adds 4144 bytes savi

icmp6_send() is too expensive

2018-10-04 Thread Jeff Barnhill
As mentioned here: https://www.spinics.net/lists/netdev/msg505054.html icmp6_send() can be expensive when there are a lot of devices and anycast addresses. One solution I've prototyped is adding a global hash table to store and allow more efficient searches for anycast addresses. This works and p

Re: [PATCH bpf-next] net: core: Fix build with CONFIG_IPV6=m

2018-10-04 Thread Daniel Borkmann
On 10/04/2018 08:33 PM, Joe Stringer wrote: > On Thu, 4 Oct 2018 at 01:48, Daniel Borkmann wrote: >> >> On 10/03/2018 07:32 AM, Joe Stringer wrote: >>> Stephen Rothwell reports the following link failure with IPv6 as module: >>> >>> x86_64-linux-gnu-ld: net/core/filter.o: in function `sk_lookup'

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-04 Thread Jesper Dangaard Brouer
On Thu, 4 Oct 2018 10:11:43 -0700 Alexei Starovoitov wrote: > On Thu, Oct 04, 2018 at 03:50:38PM +0200, Daniel Borkmann wrote: > > Allow for audit messages to be emitted upon BPF program load and > > unload for having a timeline of events. The load itself is in > > syscall context, so additional

Re: [PATCH bpf-next] net: core: Fix build with CONFIG_IPV6=m

2018-10-04 Thread Joe Stringer
On Thu, 4 Oct 2018 at 01:48, Daniel Borkmann wrote: > > On 10/03/2018 07:32 AM, Joe Stringer wrote: > > Stephen Rothwell reports the following link failure with IPv6 as module: > > > > x86_64-linux-gnu-ld: net/core/filter.o: in function `sk_lookup': > > (.text+0x19219): undefined reference to

RE: [PATCH v3] net/ncsi: Add NCSI OEM command support

2018-10-04 Thread Justin.Lee1
> This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for OEM > commands > ncsi_rsp_handler_oem: This is a generic response

Re: [PATCH v5 13/15] octeontx2-af: Add support for CGX link management

2018-10-04 Thread Sunil Kovvuri
On Mon, Oct 1, 2018 at 6:17 PM Arnd Bergmann wrote: > > On Mon, Oct 1, 2018 at 1:37 PM wrote: > > > +/* Response to cmd ID as CGX_CMD_GET_FW_VER with cmd status as > > + * CGX_STAT_SUCCESS > > + */ > > +struct cgx_ver_s { > > +#if defined(__BIG_ENDIAN_BITFIELD) > > + uint64_t reserved2:47;

[PATCH v6 14/15] octeontx2-af: Register for CGX lmac events

2018-10-04 Thread sunil . kovvuri
From: Linu Cherian Added support in RVU AF driver to register for CGX LMAC link status change events from firmware and managing them. Processing part will be added in followup patches. - Introduced eventqueue for posting events from cgx lmac. Queueing mechanism will ensure that events can be p

[PATCH v6 08/15] octeontx2-af: Add RVU block LF provisioning support

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Added support for a RVU PF/VF to request AF via mailbox to attach or detach NPA/NIX/SSO/SSOW/TIM/CPT block LFs. Also supports partial detachment and modifying current LF attached count of a certian block type. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/oc

[PATCH v6 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Added maintainers entry for Marvell OcteonTX2 SOC's RVU admin function driver. Signed-off-by: Sunil Goutham --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bb5f431..eee6151 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[PATCH v6 12/15] octeontx2-af: Set RVU PFs to CGX LMACs mapping

2018-10-04 Thread sunil . kovvuri
From: Linu Cherian Each of the enabled CGX LMAC is considered a physical interface and RVU PFs are mapped to these. VFs of these SRIOV PFs will be virtual interfaces and share CGX LMAC along with PF. This mapping info will be used later on for Rx/Tx pkt steering. Signed-off-by: Linu Cherian Si

[PATCH v6 13/15] octeontx2-af: Add support for CGX link management

2018-10-04 Thread sunil . kovvuri
From: Linu Cherian CGX LMAC initialization, link status polling etc is done by low level secure firmware. For link management this patch adds a interface or communication mechanism between firmware and this kernel CGX driver. - Firmware interface specification is defined in cgx_fw_if.h. - Suppor

[PATCH v6 11/15] octeontx2-af: Add Marvell OcteonTX2 CGX driver

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's CGX ethernet interface driver. Just the probe. RVU AF driver will use APIs exported by this driver for various things like PF to physical interface mapping, loopback mode, interface stats etc. Hence marged both drivers int

[PATCH v6 10/15] octeontx2-af: Reconfig MSIX base with IOVA

2018-10-04 Thread sunil . kovvuri
From: Geetha sowjanya HW interprets RVU_AF_MSIXTR_BASE address as an IOVA, hence create a IOMMU mapping for the physcial address configured by firmware and reconfig RVU_AF_MSIXTR_BASE with IOVA. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeo

[PATCH v6 09/15] octeontx2-af: Configure block LF's MSIX vector offset

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Firmware configures a certain number of MSIX vectors to each of enabled RVU PF/VF. When a block LF is attached to a PF/VF, number of MSIX vectors needed by that LF are set aside (out of PF/VF's total MSIX vectors) and LF's msix_offset is configured in HW. Also added support f

[PATCH v6 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for mailbox interrupt and message handling. Mapped mailbox region and registered a workqueue for message handling. Enabled mailbox IRQ of RVU PFs and registered a interrupt handler. When IRQ is triggered work is added to the mbox workqueue for msgs to g

[PATCH v6 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's resource virtualization unit (RVU) admin function (AF) driver. Just the driver registration and probe. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/Kconfig | 3 + drivers/net/ethernet/ma

[PATCH v6 07/15] octeontx2-af: Scan blocks for LFs provisioned to PF/VF

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Scan all RVU blocks to find any 'LF to RVU PF/VF' mapping done by low level firmware. If found any, mark them as used in respective block's LF bitmap and also save mapped PF/VF's PF_FUNC info. This is done to avoid reattaching a block LF to a different RVU PF/VF. Signed-off-

[PATCH v6 06/15] octeontx2-af: Convert mbox msg id check to a macro

2018-10-04 Thread sunil . kovvuri
From: Aleksey Makarov With 10's of mailbox messages expected to be handled in future, checking for message id could become a lengthy switch case. Hence added a macro to auto generate the switch case for each msg id. Signed-off-by: Aleksey Makarov Signed-off-by: Sunil Goutham --- drivers/net/e

[PATCH v6 04/15] octeontx2-af: Add mailbox support infra

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch adds mailbox support infrastructure APIs. Each RVU device has a dedicated 64KB mailbox region shared with it's peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and a RVU PF has a separate region shared with each of it's VF. T

[PATCH v6 02/15] octeontx2-af: Reset all RVU blocks

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Go through all BLKADDRs and check which ones are implemented on this silicon and do a HW reset of each implemented block. Also added all RVU AF and PF register offsets. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c| 78 ++

[PATCH v6 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF/

[PATCH v6 00/15] octeontx2-af: Add RVU Admin Function driver

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW resources from the network, crypto and other functional blocks into PCI-compatible physical and virtual functions. Each functional block again has multiple local functions (LFs) for provisioning to PCI devic

Re: [RFC PATCH] skb: Define NET_IP_ALIGN based on CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS

2018-10-04 Thread Russell King - ARM Linux
On Thu, Oct 04, 2018 at 07:43:59PM +0200, Ard Biesheuvel wrote: > (+ Arnd, Russell, Catalin, Will) > > On 4 October 2018 at 19:36, Ben Hutchings > wrote: > > NET_IP_ALIGN is supposed to be defined as 0 if DMA writes to an > > unaligned buffer would be more expensive than CPU access to unaligned

[PATCH][-next] ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null

2018-10-04 Thread Colin King
From: Colin Ian King There is an earlier check to see if xdp_ring is null when configuring the tx ring, so assuming that it can still be null, the clearing of the xdp_ring->state currently could end up with a null pointer dereference. Fix this by only clearing the bit if xdp_ring is not null. D

Re: [RFC PATCH] skb: Define NET_IP_ALIGN based on CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS

2018-10-04 Thread Ard Biesheuvel
(+ Arnd but really) On 4 October 2018 at 19:43, Ard Biesheuvel wrote: > (+ Arnd, Russell, Catalin, Will) > > On 4 October 2018 at 19:36, Ben Hutchings > wrote: >> NET_IP_ALIGN is supposed to be defined as 0 if DMA writes to an >> unaligned buffer would be more expensive than CPU access to unali

Re: [RFC PATCH] skb: Define NET_IP_ALIGN based on CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS

2018-10-04 Thread Ard Biesheuvel
(+ Arnd, Russell, Catalin, Will) On 4 October 2018 at 19:36, Ben Hutchings wrote: > NET_IP_ALIGN is supposed to be defined as 0 if DMA writes to an > unaligned buffer would be more expensive than CPU access to unaligned > header fields, and otherwise defined as 2. > > Currently only ppc64 and x86

Re: [PATCH v2] typo fix in Documentation/networking/af_xdp.rst

2018-10-04 Thread Björn Töpel
Den tors 4 okt. 2018 kl 19:03 skrev Konrad Djimeli : > > Fix a simple typo: Completetion -> Completion > > Signed-off-by: Konrad Djimeli > --- > Changes in v2: > - Update line below to be same length as text above > > Documentation/networking/af_xdp.rst | 4 ++-- > 1 file changed, 2 insertions(+)

  1   2   >