Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

On Fri, Jun 15, 2018 at 9:00 PM, Cong Wang wrote: > On Fri, Jun 15, 2018 at 6:21 AM, Konstantin Khlebnikov > wrote: >> On 15.06.2018 16:13, Eric Dumazet wrote: >>> >>> >>> >>> On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: When blackhole is used on top of classful qdisc like hfsc

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

On Fri, Jun 15, 2018 at 6:21 AM, Konstantin Khlebnikov wrote: > On 15.06.2018 16:13, Eric Dumazet wrote: >> >> >> >> On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: >>> >>> When blackhole is used on top of classful qdisc like hfsc it breaks >>> qlen and backlog counters because packets are di

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

> On 15 Jun 2018, at 21:57, David Woodhouse wrote: > > > > On Fri, 2018-06-15 at 20:49 +, Kevin Darbyshire-Bryant wrote: >> >>> That does end up being quite hairy. I don't think it's worth doing. >>> >>> This should probably suffice to fix it... >>> >>> Kevin this is going to conflict

Re: [PATCH net] net/multicast: clean change record if add new INCLUDE group

Self NAK this patch, there is some issue I need to fix. On Wed, Jun 13, 2018 at 02:32:31PM +0800, Hangbin Liu wrote: > Based on RFC3376 5.1 and RFC3810 6.1: >If no interface >state existed for that multicast address before the change (i.e., the >change consisted of creating a new per-i

[PATCH iproute2-next v3] ip-xfrm: Add support for OUTPUT_MARK

This patch adds support for OUTPUT_MARK in xfrm state to exercise the functionality added by kernel commit 077fbac405bf ("net: xfrm: support setting an output mark."). Sample output- (with mark and output-mark) src 192.168.1.1 dst 192.168.1.2 proto esp spi 0x4321 reqid 0 mode tunnel

pull-request: bpf 2018-06-16

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a panic in devmap handling in generic XDP where return type of __devmap_lookup_elem() got changed recently but generic XDP code missed the related update, from Toshiaki. 2) Fix a fr

Re: [PATCH bpf v2] xdp: Fix handling of devmap in generic XDP

On 06/14/2018 11:33 AM, Jesper Dangaard Brouer wrote: > On Thu, 14 Jun 2018 18:00:22 +0900 > Toshiaki Makita wrote: >> On 2018/06/14 17:49, Jesper Dangaard Brouer wrote: >>> On Thu, 14 Jun 2018 11:07:42 +0900 >>> Toshiaki Makita wrote: >>> Commit 67f29e07e131 ("bpf: devmap introduce dev_m

Re: [PATCH bpf 0/2] Two bpf fixes

On 06/15/2018 09:31 PM, Alexei Starovoitov wrote: > On Fri, Jun 15, 2018 at 02:30:46AM +0200, Daniel Borkmann wrote: >> First one is a panic I ran into while testing the second >> one where we got several syzkaller reports. Series here >> fixes both. >> >> Thanks! > > Applied, thanks. > > The sec

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On Fri, 2018-06-15 at 20:49 +, Kevin Darbyshire-Bryant wrote: > > > That does end up being quite hairy. I don't think it's worth doing. > >  > > This should probably suffice to fix it... > >  > > Kevin this is going to conflict with the ifx_atm_alloc_skb() hack in > > the tree you're working

Re: [PATCH 0/2] leds: drop led_trigger_rename_static()

Hi, I need can or net maintainer's ack for merging this set via LED tree. It's been awaiting feedback for a few weeks now and it is blocking another set depending on it. On 05/18/2018 10:53 AM, Uwe Kleine-König wrote: Hello, initially I prepared a patch to fix the broken things in led_trigger

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

> On 15 Jun 2018, at 21:00, David Woodhouse wrote: > > On Fri, 2018-06-15 at 14:44 +0100, David Woodhouse wrote: >> >>> Or simply use a new field in ATM_SKB(skb) to remember a stable >>> truesize used in both sides (add/sub) >> >> Right, that was my second suggestion ("copy the accounted valu

ethtool 4.17 released

ethtool version 4.17 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.17.tar.xz Release notes: * Fix: In ethtool.8, remove superfluous and incorrect \c. * Fix: fix unini

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On Fri, 2018-06-15 at 14:44 +0100, David Woodhouse wrote: > > > Or simply use a new field in ATM_SKB(skb) to remember a stable > > truesize used in both sides (add/sub) > > Right, that was my second suggestion ("copy the accounted value..."). > > It's a bit of a hack, and I think that actually *

IMMEDIATE REPLY.

DEAR FRIEND, I know that this letter will come to you as surprise, I got your contact address while I was searching for foreign partner to champion this golden appoint unity that is present in our favor, My name is Mr. Isa Zongo, I am the Bill and Exchange (assistant) Manager CORIS BANK INTE

Re: [PATCH bpf 0/2] Two bpf fixes

On Fri, Jun 15, 2018 at 02:30:46AM +0200, Daniel Borkmann wrote: > First one is a panic I ran into while testing the second > one where we got several syzkaller reports. Series here > fixes both. > > Thanks! Applied, thanks. The second patch looks dubious to me though. Nothing in the kernel tree

Re: [PATCH iproute2 v3] ipaddress: strengthen check on 'label' input

On Thu, 14 Jun 2018 15:46:57 +0200 Patrick Talbert wrote: > As mentioned in the ip-address man page, an address label must > be equal to the device name or prefixed by the device name > followed by a colon. Currently the only check on this input is > to see if the device name appears at the begin

[PATCH] socket.7: Clarify that poll() and select() are affected by SO_RCVLOWAT

Signed-off-by: Anmol Sarma --- man7/socket.7 | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/man7/socket.7 b/man7/socket.7 index b1aebfae2..65532bc49 100644 --- a/man7/socket.7 +++ b/man7/socket.7 @@ -777,17 +777,20 @@ fails with the error .B SO_RCVLOWAT is cha

Re: [PATCH bpf 2/2] bpf: reject any prog that failed read-only lock

On Fri, Jun 15, 2018 at 02:30:48AM +0200, Daniel Borkmann wrote: > We currently lock any JITed image as read-only via bpf_jit_binary_lock_ro() > as well as the BPF image as read-only through bpf_prog_lock_ro(). In > the case any of these would fail we throw a WARN_ON_ONCE() in order to > yell loudl

Re: [PATCH net] net: stmmac: Run HWIF Quirks after getting HW caps

From: Jose Abreu Date: Fri, 15 Jun 2018 16:17:27 +0100 > Currently we were running HWIF quirks before getting HW capabilities. > This is not right because some HWIF callbacks depend on HW caps. > > Lets save the quirks callback and use it in a later stage. > > This fixes Altera socfpga. > > Si

Re: [PATCH net] neighbour: skip NTF_EXT_LEARNED entries during forced gc

From: Roopa Prabhu Date: Tue, 12 Jun 2018 21:26:10 -0700 > From: Roopa Prabhu > > Commit 9ce33e46531d ("neighbour: support for NTF_EXT_LEARNED flag") > added support for NTF_EXT_LEARNED for neighbour entries. > NTF_EXT_LEARNED entries are neigh entries managed by control > plane (eg: Ethernet V

Re: [PATCH net 0/2] Two tls fixes

From: Daniel Borkmann Date: Fri, 15 Jun 2018 03:07:44 +0200 > First one is syzkaller trigered uaf and second one noticed > while writing test code with tls ulp. For details please see > individual patches. Series applied and queued up for -stable, thanks!

Re: [PATCH net 0/2] l2tp: l2tp_ppp must ignore non-PPP sessions

From: Guillaume Nault Date: Fri, 15 Jun 2018 15:39:15 +0200 > The original L2TP code was written for version 2 of the protocol, which > could only carry PPP sessions. Then L2TPv3 generalised the protocol so that > it could transport different kinds of pseudo-wires. But parts of the > l2tp_ppp mod

Re: [PATCH net 0/4] mlxsw: IPv6 and reference counting fixes

From: Ido Schimmel Date: Fri, 15 Jun 2018 16:23:34 +0300 > The first three patches fix a mismatch between the new IPv6 behavior > introduced in commit f34436a43092 ("net/ipv6: Simplify route replace and > appending into multipath route") and mlxsw. The patches allow the driver > to support multip

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

On 6/15/18 7:24 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 14, 2018 at 09:56:43PM -0700, Yonghong Song escreveu: I really want to get rid of this option as well. To make pahole work with the default default format, I need to add bpf support to libdwfl in elfutils repo. I will work on tha

Re: [PATCH v7 net] stmmac: added support for 802.1ad vlan stripping

From: Elad Nachman Date: Fri, 15 Jun 2018 09:57:39 +0300 > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with > 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-cod

Re: [PATCH bpf 1/2] bpf: fix panic in prog load calls cleanup

On Fri, Jun 15, 2018 at 02:30:47AM +0200, Daniel Borkmann wrote: > While testing I found that when hitting error path in bpf_prog_load() > where we jump to free_used_maps and prog contained BPF to BPF calls > that were JITed earlier, then we never clean up the bpf_prog_kallsyms_add() > done under j

Re: [bpf PATCH v2 3/6] bpf: sockhash fix omitted bucket lock in sock_close

On Fri, Jun 15, 2018 at 08:23:14AM -0700, John Fastabend wrote: > On 06/14/2018 10:41 PM, Martin KaFai Lau wrote: > > On Thu, Jun 14, 2018 at 09:44:57AM -0700, John Fastabend wrote: > >> First in tcp_close, reduce scope of sk_callback_lock() the lock is > >> only needed for protecting smap_release_

Re: [PATCH v1 net-next] stmmac: fix DMA channel hang in half-duplex mode

Hi, On 6/15/2018 5:36 AM, David Miller wrote: From: Bhadram Varka Date: Wed, 13 Jun 2018 10:00:48 +0530 HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka Bug fixes should be subm

Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection

On 6/14/18 5:05 PM, David Miller wrote: > From: Frank van der Linden > Date: Tue, 12 Jun 2018 23:09:37 + > >> commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash >> table") introduced an optimization for the handling of child sockets >> created for a new TCP connection. >> >>

Re: [bpf PATCH v2 3/6] bpf: sockhash fix omitted bucket lock in sock_close

On 06/14/2018 10:41 PM, Martin KaFai Lau wrote: > On Thu, Jun 14, 2018 at 09:44:57AM -0700, John Fastabend wrote: >> First in tcp_close, reduce scope of sk_callback_lock() the lock is >> only needed for protecting smap_release_sock() the ingress and cork >> lists are protected by sock lock. Having

[PATCH net] net: stmmac: Run HWIF Quirks after getting HW caps

Currently we were running HWIF quirks before getting HW capabilities. This is not right because some HWIF callbacks depend on HW caps. Lets save the quirks callback and use it in a later stage. This fixes Altera socfpga. Signed-off-by: Jose Abreu Fixes: 5f0456b43140 ("net: stmmac: Implement log

Fw: [Bug 200083] New: kernel panic: fatal exception in interrupt

The screenshot shows: RIP: xfrm_lookup+0x17/0x676 Begin forwarded message: Date: Fri, 15 Jun 2018 12:35:21 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200083] New: kernel panic: fatal exception in interrupt https://bugzilla.kernel.org/show_bug.c

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

On 14-06-2018 17:18, Dinh Nguyen wrote: > On Thu, Jun 14, 2018 at 10:23 AM Jose Abreu wrote: >> On 14-06-2018 15:21, Dinh Nguyen wrote: >>> [0.835537] socfpga-dwmac ff702000.ethernet: PTP uses main clock >>> [0.841794] socfpga-dwmac ff702000.ethernet: Version ID not available >>> [0.84

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

Em Thu, Jun 14, 2018 at 09:56:43PM -0700, Yonghong Song escreveu: > I really want to get rid of this option as well. To make pahole work > with the default default format, I need to add bpf support to > libdwfl in elfutils repo. I will work on that. Right, I haven't looked into detail, but perhaps

Re: [PATCH net 1/4] ipv6: Only emit append events for appended routes

On 6/15/18 7:23 AM, Ido Schimmel wrote: > Current code will emit an append event in the FIB notification chain for > any route added with NLM_F_APPEND set, even if the route was not > appended to any existing route. > > This is inconsistent with IPv4 where such an event is only emitted when > the

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On Fri, 2018-06-15 at 06:39 -0700, Eric Dumazet wrote: > > On 06/15/2018 06:27 AM, Eric Dumazet wrote: > > > > > > > > On 06/15/2018 05:29 AM, David Woodhouse wrote: > > > > > > On Fri, 2017-06-30 at 13:08 +0300, Elena Reshetova wrote: > > > > > > > > diff --git a/include/linux/atmdev.h b/i

[PATCH net 2/2] l2tp: filter out non-PPP sessions in pppol2tp_tunnel_ioctl()

pppol2tp_tunnel_ioctl() can act on an L2TPv3 tunnel, in which case 'session' may be an Ethernet pseudo-wire. However, pppol2tp_session_ioctl() expects a PPP pseudo-wire, as it assumes l2tp_session_priv() points to a pppol2tp_session structure. For an Ethernet pseudo-wire l2tp_session_priv() points

[PATCH net 0/2] l2tp: l2tp_ppp must ignore non-PPP sessions

The original L2TP code was written for version 2 of the protocol, which could only carry PPP sessions. Then L2TPv3 generalised the protocol so that it could transport different kinds of pseudo-wires. But parts of the l2tp_ppp module still break in presence of non-PPP sessions. Assuming L2TPv2 tunn

[PATCH net 1/2] l2tp: reject creation of non-PPP sessions on L2TPv2 tunnels

The /proc/net/pppol2tp handlers (pppol2tp_seq_*()) iterate over all L2TPv2 tunnels, and rightfully expect that only PPP sessions can be found there. However, l2tp_netlink accepts creating Ethernet sessions regardless of the underlying tunnel version. This confuses pppol2tp_seq_session_show(), whic

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On 06/15/2018 06:27 AM, Eric Dumazet wrote: > > > On 06/15/2018 05:29 AM, David Woodhouse wrote: >> On Fri, 2017-06-30 at 13:08 +0300, Elena Reshetova wrote: >>> diff --git a/include/linux/atmdev.h b/include/linux/atmdev.h >>> index c1da539..4d97a89 100644 >>> --- a/include/linux/atmdev.h >>>

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

On 15.06.2018 16:13, Eric Dumazet wrote: On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: When blackhole is used on top of classful qdisc like hfsc it breaks qlen and backlog counters because packets are disappear without notice. In HFSC non-zero qlen while all classes are inactive trigge

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On 06/15/2018 05:29 AM, David Woodhouse wrote: > On Fri, 2017-06-30 at 13:08 +0300, Elena Reshetova wrote: >> diff --git a/include/linux/atmdev.h b/include/linux/atmdev.h >> index c1da539..4d97a89 100644 >> --- a/include/linux/atmdev.h >> +++ b/include/linux/atmdev.h >> @@ -254,7 +254,7 @@ stati

[PATCH net 2/4] mlxsw: spectrum_router: Allow appending to dev-only routes

Commit f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route") changed the IPv6 route append logic so that dev-only routes can be appended and not only gatewayed routes. Align mlxsw with the new behaviour. Fixes: f34436a43092 ("net/ipv6: Simplify route replace and app

[PATCH net 4/4] mlxsw: spectrum_switchdev: Fix port_vlan refcounting

From: Petr Machata Switchdev notifications for addition of SWITCHDEV_OBJ_ID_PORT_VLAN are distributed not only on clean addition, but also when flags on an existing VLAN are changed. mlxsw_sp_bridge_port_vlan_add() calls mlxsw_sp_port_vlan_get() to get at the port_vlan in question, which implicit

[PATCH net 3/4] mlxsw: spectrum_router: Align with new route replace logic

Commit f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route") changed the IPv6 route replace logic so that the first matching route (i.e., same metric) is replaced. Have mlxsw replace the first matching route as well. Fixes: f34436a43092 ("net/ipv6: Simplify route re

[PATCH net 1/4] ipv6: Only emit append events for appended routes

Current code will emit an append event in the FIB notification chain for any route added with NLM_F_APPEND set, even if the route was not appended to any existing route. This is inconsistent with IPv4 where such an event is only emitted when the new route is appended after an existing one. Align

[PATCH net 0/4] mlxsw: IPv6 and reference counting fixes

Hi, The first three patches fix a mismatch between the new IPv6 behavior introduced in commit f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route") and mlxsw. The patches allow the driver to support multipathing in IPv6 overlays with GRE tunnel devices. A selftest wi

Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote: > When blackhole is used on top of classful qdisc like hfsc it breaks > qlen and backlog counters because packets are disappear without notice. > > In HFSC non-zero qlen while all classes are inactive triggers warning: > WARNING: ... at net/s

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

On 06/15/2018 02:43 PM, William Tu wrote: > On Thu, Jun 14, 2018 at 10:24 PM, Eyal Birger wrote: >> >> >>> On 14 Jun 2018, at 15:01, William Tu wrote: >>> >>> Make the printting of bpf xfrm tunnel better and >>> cleanup xfrm state and policy when xfrm test finishes. >> >> Yeah the ‘tee’ was usefu

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

On Thu, Jun 14, 2018 at 10:24 PM, Eyal Birger wrote: > > >> On 14 Jun 2018, at 15:01, William Tu wrote: >> >> Make the printting of bpf xfrm tunnel better and >> cleanup xfrm state and policy when xfrm test finishes. > > Yeah the ‘tee’ was useful when developing the test - I could see what’s goin

Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t

On Fri, 2017-06-30 at 13:08 +0300, Elena Reshetova wrote: > diff --git a/include/linux/atmdev.h b/include/linux/atmdev.h > index c1da539..4d97a89 100644 > --- a/include/linux/atmdev.h > +++ b/include/linux/atmdev.h > @@ -254,7 +254,7 @@ static inline void atm_return(struct atm_vcc *vcc,int > trues

[PATCH][ipsec] xfrm: replace NR_CPU with num_possible_cpus()

The default NR_CPUS can be very large, but actual possible nr_cpu_ids usually is very small. For some x86 distribution, the NR_CPUS is 8192 and nr_cpu_ids is 4. when xfrm_init is running, num_possible_cpus() should work Signed-off-by: Li RongQing Signed-off-by: Wang Li --- net/xfrm/xfrm_policy

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

Hi, On Thu, Jun 07, 2018 at 04:30:29PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 07, 2018 at 12:05:10PM -0700, Martin KaFai Lau escreveu: dump-obj = true clang-opt = -g [root@jouet bpf]# perf trace -e open*,hello.c touch /tmp/hello.BTF LLVM: dumping hello.o 0.185 ( ): __bpf_s

[PATCH] net_sched: blackhole: tell upper qdisc about dropped packets

When blackhole is used on top of classful qdisc like hfsc it breaks qlen and backlog counters because packets are disappear without notice. In HFSC non-zero qlen while all classes are inactive triggers warning: WARNING: ... at net/sched/sch_hfsc.c:1393 hfsc_dequeue+0xba4/0xe90 [sch_hfsc] and sched

Re: [PATCH] net: Fix device name resolving crash in default_device_exit()

On 14.06.2018 20:11, David Ahern wrote: > On 6/14/18 6:38 AM, Kirill Tkhai wrote: >> The following script makes kernel to crash since it can't obtain >> a name for a device, when the name is occupied by another device: >> >> #!/bin/bash >> ifconfig eth0 down >> ifconfig eth1 down >> index=`cat /sys

[PATCH v2] ip: add rmnet initial support

This patch adds basic support for Qualcomm rmnet devices. Signed-off-by: Daniele Palmas --- v2: rebased on iproute2-next removed GPL boilerplate added print_opt function man page updated fixed MUXID values --- ip/Makefile | 2 +- ip/iplink.c

Re: BUG: KASAN: stack-out-of-bounds in ipv6_addr_equal include/net/ipv6.h

On Fri, Jun 15, 2018 at 8:33 AM, air icy wrote: > > Hi, > I found a kernel bug with enchanced syzkaller in the newest linux kernel > v4.17. > The output is as follows: > > == > BUG: KASAN: stack-out-of-bounds in ipv6_addr_equal inclu

Re: [PATCH v7 net] stmmac: added support for 802.1ad vlan stripping

On 2018/06/15 15:57, Elad Nachman wrote: > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with > 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding > the paramete