Re: [net] xfrm: allow to release xfrm_state with flush

2018-04-18 Thread Steffen Klassert
On Thu, Apr 12, 2018 at 12:03:14PM -0700, Jacek Kalwas wrote: > Call to flush SAs doesn't release xfrm_state in case there was a > traffic associated with that state and state was already deleted. > > Given patch calls xfrm_policy_cache_flush despite of actual states > deleted in xfrm_state_flush

Re: [net] udp: enable UDP checksum offload for ESP

2018-04-18 Thread Steffen Klassert
On Thu, Apr 12, 2018 at 12:03:13PM -0700, Jacek Kalwas wrote: > In case NIC has support for ESP TX CSUM offload skb->ip_summed is not > set to CHECKSUM_PARTIAL which results in checksum calculated by SW. > > Fix enables ESP TX CSUM for UDP by extending condition with check for > NETIF_F_HW_ESP_TX_

Re: kernel BUG at /home/blee/project/race-fuzzer/kernels/kernel_v4.16-rc3/net/packet/af_packet.c:LINE!

2018-04-18 Thread DaeRyong Jeong
Hello. We have analyzed the cause of the crash, kernel BUG at net/packet/af_packet.c:LINE!, which is found by RaceFuzzer (a modified version of Syzkaller) in v4.16-rc7. Since struct packet_sock's member variables, running, has_vnet_hdr, origdev and auxdata are declared as bitfields, accessing thes

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Siwei Liu
On Wed, Apr 18, 2018 at 11:10 PM, Samudrala, Sridhar wrote: > > On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: >> >> On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: >>> >>> On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Sam

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Johannes Berg
On Wed, 2018-04-18 at 14:51 -0700, Ben Greear wrote: > > It'd be pretty hard to know which flags are firmware stats? > > Yes, it is, but ethtool stats are difficult to understand in a generic > manner anyway, so someone using them is already likely aware of low-level > details of the driver(s) th

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Jiri Pirko
Thu, Apr 19, 2018 at 12:46:11AM CEST, sridhar.samudr...@intel.com wrote: >On 4/18/2018 1:32 PM, Jiri Pirko wrote: >> > > > > > > You still use "active"/"backup" names which is highly misleading >> > > > > > > as >> > > > > > > it has completely different meaning that in bond for example. >> > > >

Re: WARNING in refcount_dec

2018-04-18 Thread DaeRyong Jeong
Hello. We have analyzed the cause of the crash in v4.16-rc3, WARNING in refcount_dec, which is found by RaceFuzzer (a modified version of Syzkaller). Since struct packet_sock's member variables, running, has_vnet_hdr, origdev and auxdata are declared as bitfields, accessing these variables can rac

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Siwei Liu
On Wed, Apr 18, 2018 at 10:00 PM, Samudrala, Sridhar wrote: > On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: >> >> On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: >>> >>> On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some goo

[PATCH net-next] liquidio: Added ndo_get_vf_stats support

2018-04-18 Thread Felix Manlunas
From: Intiyaz Basha Added the ndo to gather VF statistics through the PF. Collect VF statistics via mailbox from VF. Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 54 ++ .../ethernet/cavium/liquidio/cn2

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a fe

答复: [PATCH][net-next] net: ip tos cgroup

2018-04-18 Thread Li,Rongqing
> -邮件原件- > 发件人: Daniel Borkmann [mailto:dan...@iogearbox.net] > 发送时间: 2018年4月17日 22:11 > 收件人: Li,Rongqing > 抄送: netdev@vger.kernel.org; t...@kernel.org; a...@fb.com; > bra...@fb.com > 主题: Re: [PATCH][net-next] net: ip tos cgroup > > On 04/17/2018 05:36 AM, Li RongQing wrote: > > ip tos

Re: [PATCH net 3/3] net: sched: ife: check on metadata length

2018-04-18 Thread yotam gigi
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote: > This patch checks if sk buffer is available to dererence ife header. If > not then NULL will returned to signal an malformed ife packet. This > avoids to crashing the kernel from outside. > > Signed-off-by: Alexander Aring Reviewed-by: Y

Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-18 Thread yotam gigi
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote: > There is currently no handling to check on a invalid tlv length. This > patch adds such handling to avoid killing the kernel with a malformed > ife packet. That's very important. Thanks for that! > > Signed-off-by: Alexander Aring > ---

Re: [PATCH net 1/3] net: sched: ife: signal not finding metaid

2018-04-18 Thread yotam gigi
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote: > We need to record stats for received metadata that we dont know how > to process. Have find_decode_metaid() return -ENOENT to capture this. Agree. > > Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi > --- > net/sched/act_ife.

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 10:21:25PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > > The code defines macro 'PAGE_

[PATCH v2 net 3/3] virtio_net: sparse annotation fix

2018-04-18 Thread Michael S. Tsirkin
offloads is a buffer in virtio format, should use the __virtio64 tag. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f84fe04..c5b11f2 100644 --- a/drivers

[PATCH v2 net 1/3] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so it's in theory (on extreme memory pressure) possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

[PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-18 Thread Michael S. Tsirkin
Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer Fixes: 9465a7a6f ("virtio_net: enable v1.0 support")

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > > address is in kernel space or not

Re: [PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 08:01:49AM +0300, Michael S. Tsirkin wrote: > When sending control commands, virtio net sets up several buffers for > DMA. The buffers are all part of the net device which means it's > actually allocated by kvmalloc so in theory (on extreme memory pressure) > it's possible t

Re: [PATCH] net: add mutex_unlock on xfrm4_protocol_register

2018-04-18 Thread Steffen Klassert
On Thu, Apr 19, 2018 at 09:08:57AM +0800, sunlianwen wrote: > The function of xfrm4_protocol_register() don't release > the mutx lock, which potential cause deadlock. Can you please explain how this can happen? > > Signed-off-by: Lianwen Sun > --- > net/ipv4/xfrm4_protocol.c | 4 > 1 file

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > address is in kernel space or not. But different architecture has > > different 'PAGE_OFFSET' so

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: > On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: > > > On 4/17/2018 5:26 PM, Siwei Liu wrote: > > > > I ran this with a few folks offline and gathered some go

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
This implements a misc character device named "qrtr-tun" for the purpose of allowing user space applications to implement endpoints in the qrtr network. This allows more advanced (and dynamic) testing of the qrtr code as well as opens up the ability of tunneling qrtr over a network or USB link. S

[PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so in theory (on extreme memory pressure) it's possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as il

[PATCH] net: net_cls: remove a NULL check for css_cls_state

2018-04-18 Thread Li RongQing
The input of css_cls_state() is impossible to NULL except cgrp_css_online, so simplify it Signed-off-by: Li RongQing --- net/core/netclassid_cgroup.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c index 5e4f0

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > address is in kernel space or not. But different architecture has > different 'PAGE_OFFSET' so this program cannot be used for all > platforms. > > This commit changes to

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: > On 4/17/2018 5:26 PM, Siwei Liu wrote: > > I ran this with a few folks offline and gathered some good feedbacks > > that I'd like to share thus revive the discussion. > > > > First of all, as illustrated in the reply below, clou

Re: [PATCH bpf-next v2 9/9] tools/bpf: add a test_progs test case for bpf_get_stack helper

2018-04-18 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 09:54:44AM -0700, Yonghong Song wrote: > The test_stacktrace_map is enhanced to call bpf_get_stack > in the helper to get the stack trace as well. > The stack traces from bpf_get_stack and bpf_get_stackid > are compared to ensure that for the same stack as > represented as t

Re: [PATCH bpf-next v2 7/9] samples/bpf: add a test for bpf_get_stack helper

2018-04-18 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 09:54:42AM -0700, Yonghong Song wrote: > The test attached a kprobe program to kernel function sys_write. > It tested to get stack for user space, kernel space and user > space with build_id request. It also tested to get user > and kernel stack into the same buffer with bac

Re: [PATCH bpf-next v2 4/9] bpf/verifier: improve register value range tracking with ARSH

2018-04-18 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 09:54:39AM -0700, Yonghong Song wrote: > When helpers like bpf_get_stack returns an int value > and later on used for arithmetic computation, the LSH and ARSH > operations are often required to get proper sign extension into > 64-bit. For example, without this patch: > 5

Re: [PATCH bpf-next v2 3/9] bpf/verifier: refine retval R0 state for bpf_get_stack helper

2018-04-18 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 09:54:38AM -0700, Yonghong Song wrote: > The special property of return values for helpers bpf_get_stack > and bpf_probe_read_str are captured in verifier. > Both helpers return a negative error code or > a length, which is equal to or smaller than the buffer > size argument

Re: [PATCH 01/12] iscsi_tcp: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 02/12] storsvc: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH bpf-next v2 2/9] bpf: add bpf_get_stack helper

2018-04-18 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 09:54:37AM -0700, Yonghong Song wrote: > Currently, stackmap and bpf_get_stackid helper are provided > for bpf program to get the stack trace. This approach has > a limitation though. If two stack traces have the same hash, > only one will get stored in the stackmap table, >

Re: tg3 crashes under high load, when using 100Mbits

2018-04-18 Thread Siva Reddy Kallam
On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng wrote: > Hi Satish, > >> On 2018Mar21, at 00:57, Kai-Heng Feng wrote: >> >> Satish Baddipadige wrote: >> >>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >>> wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam wrote: > O

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:32:06PM +0200, Jiri Pirko wrote: > >> >> > With regards to alternate names for 'active', you suggested 'stolen', > >> >> > but i > >> >> > am not too happy with it. > >> >> > netvsc uses vf_netdev, are you OK with this? Or another option is > >> >> > 'passthru' > >> >>

[PATCH] net: hns: Avoid action name truncation

2018-04-18 Thread dann frazier
When longer interface names are used, the action names exposed in /proc/interrupts and /proc/irq/* maybe truncated. For example, when using the predictable name algorithm in systemd on a HiSilicon D05, I see: ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //' enahisic2i0-tx0

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:38:43PM -0700, Eric Dumazet wrote: > > > On 04/18/2018 10:55 AM, Michael S. Tsirkin wrote: > > > Imagine you want to pass some data to card. > > Natural thing is to just put it in a variable and start DMA. > > However DMA API disallows stack access nowdays, > > so it's

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-04-18 Thread Eric Biggers
On Tue, Jan 02, 2018 at 03:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console ou

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: > > I don't want to do that - I just want the documentation to be correct > (or at least, not be blatantly incorrect). The function does not sleep, > and is safe to call with spin locks held. > Do we need to spell out when it can be called

Re: [PATCH net-next] ipv6: frags: fix a lockdep false positive

2018-04-18 Thread David Miller
From: Eric Dumazet Date: Tue, 17 Apr 2018 18:11:44 -0700 > lockdep does not know that the locks used by IPv4 defrag > and IPv6 reassembly units are of different classes. > > It complains because of following chains : > > 1) sch_direct_xmit()(lock txq->_xmit_lock) > dev_hard_start_xm

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi, messed up the subject there, sorry - this was meant to be [PATCH v4 0/9] net-next: New network driver for Amiga X-Surf 100 (m68k) Cheers, Michael Am 19.04.2018 um 14:05 schrieb Michael Schmitz: > [This is a resend of my v3 series which was based on the wrong version and > tree. On

Re: [Regression] net/phy/micrel.c v4.9.94

2018-04-18 Thread Chris Ruehl
On Thursday, April 19, 2018 09:34 AM, Chris Ruehl wrote: On Thursday, April 19, 2018 09:21 AM, Chris Ruehl wrote: On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote

Re: [RFC PATCH ghak32 V2 12/13] audit: NETFILTER_PKT: record each container ID associated with a netNS

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID auxiliary record(s) to NETFILTER_PKT event standalone > records. Iterate through all potential container IDs associated with a > network namespace. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c

[PATCH v4 8/9] net-next: ax88796: release platform device drvdata on probe error and module remove

2018-04-18 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(

[PATCH v4 2/9] net-next: ax88796: Fix MAC address reading

2018-04-18 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1 file

[PATCH v4 6/9] net-next: ax88796: add interrupt status callback to platform data

2018-04-18 Thread Michael Schmitz
From: Michael Karcher To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael

[PATCH v4 7/9] net-next: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-18 Thread Michael Schmitz
From: Michael Karcher On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1 files changed

[PATCH v4 1/9] net-next: phy: new Asix Electronics PHY driver

2018-04-18 Thread Michael Schmitz
The Asix Electronics PHY found on the X-Surf 100 Amiga Zorro network card by Individual Computers is buggy, and needs the reset bit toggled as workaround to make a PHY soft reset succeed. Add workaround driver just for this special case. Suggested in xsurf100 patch series review by Andrew Lunn

[PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
[This is a resend of my v3 series which was based on the wrong version and tree. Only substantial change is to Asix AX99796B PHY driver.] This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver

[PATCH v4 9/9] net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. The ax88796 module will be loaded through this module's probe function. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- Chan

[PATCH v4 3/9] net-next: ax88796: Attach MII bus only when open

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Andrew Lu

[PATCH v4 5/9] net-next: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- Changes in v3: Suggested

[PATCH v4 4/9] net-next: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-18 Thread Michael Schmitz
From: Michael Karcher This complements the fix in 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq without request_irq first") that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Fixes: 82533ad9a1c (n

Re: [PATCH 1/6] rhashtable: remove outdated comments about grow_decision etc

2018-04-18 Thread David Miller
From: NeilBrown Date: Thu, 19 Apr 2018 09:09:05 +1000 > On Wed, Apr 18 2018, Herbert Xu wrote: > >> On Wed, Apr 18, 2018 at 04:47:01PM +1000, NeilBrown wrote: >>> grow_decision and shink_decision no longer exist, so remove >>> the remaining references to them. >>> >>> Signed-off-by: NeilBrown

Re: [RFC PATCH ghak32 V2 11/13] audit: add support for containerid to network namespaces

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Audit events could happen in a network namespace outside of a task > context due to packets received from the net that trigger an auditing > rule prior to being associated with a running task. The network > namespace could in use by mul

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Dave Young
On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > > Hi Rahul, > > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > > > On production servers running variety of workloads over time, kernel > > > panic can happen sporadically

[PATCH bpf-next 0/5] samples/bpf: Minor fixes and cleanup

2018-04-18 Thread Leo Yan
This patch series is minor fixes and cleanup for bpf load and samples code. The first one patch is typo fixing; patch 0002 is refactor for dynamically allocate memory for kernel symbol structures; the last three patches are mainly related with refactor with function ksym_search(), the main benefit

[PATCH bpf-next 1/5] samples/bpf: Fix typo in comment

2018-04-18 Thread Leo Yan
Fix typo by replacing 'iif' with 'if'. Signed-off-by: Leo Yan --- samples/bpf/bpf_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c index bebe418..28e4678 100644 --- a/samples/bpf/bpf_load.c +++ b/samples/bpf/bpf_load.c @@

[PATCH bpf-next 3/5] samples/bpf: Use NULL for failed to find symbol

2018-04-18 Thread Leo Yan
Function ksym_search() is used to parse address and return the symbol structure, when the address is out of range for kernel symbols it returns the symbol structure of kernel '_stext' entry; this introduces confusion and it misses the chance to intuitively tell the address is out of range. This co

[PATCH bpf-next 2/5] samples/bpf: Dynamically allocate structure 'syms'

2018-04-18 Thread Leo Yan
Structure 'syms' is used to store kernel symbol info by reading proc fs node '/proc/kallsyms', this structure is declared with 30 entries and static linked into bss section. For most case the kernel symbols has less than 30 entries, so it's safe to define so large array, but the side effec

Re: [Regression] net/phy/micrel.c v4.9.94

2018-04-18 Thread Chris Ruehl
On Thursday, April 19, 2018 09:21 AM, Chris Ruehl wrote: On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote: Hello, I like to get your heads up at a regression int

[PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
The code defines macro 'PAGE_OFFSET' and uses it to decide if the address is in kernel space or not. But different architecture has different 'PAGE_OFFSET' so this program cannot be used for all platforms. This commit changes to check returned pointer from ksym_search() to judge if the address fa

[PATCH bpf-next 5/5] samples/bpf: Handle NULL pointer returned by ksym_search()

2018-04-18 Thread Leo Yan
This commit handles NULL pointer returned by ksym_search() to directly print address hexadecimal value, the change is applied in 'trace_event', 'spintest' and 'offwaketime' programs. Signed-off-by: Leo Yan --- samples/bpf/offwaketime_user.c | 5 + samples/bpf/spintest_user.c| 5 - sa

Re: [RFC PATCH ghak32 V2 10/13] audit: add containerid support for seccomp and anom_abend records

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID auxiliary records to secure computing and abnormal end > standalone records. > > Signed-off-by: Richard Guy Briggs > --- > kernel/auditsc.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --

Re: [RFC PATCH ghak32 V2 09/13] audit: add containerid support for config/feature/user records

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID auxiliary records to configuration change, feature set change > and user generated standalone records. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 50 ---

Re: [PATCH net] net: qualcomm: rmnet: Fix warning seen with fill_info

2018-04-18 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 17 Apr 2018 17:40:00 -0600 > When the last rmnet device attached to a real device is removed, the > real device is unregistered from rmnet. As a result, the real device > lookup fails resulting in a warning when the fill_info handler is > called as

Re: [Regression] net/phy/micrel.c v4.9.94

2018-04-18 Thread Chris Ruehl
On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote: On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote: Hello, I like to get your heads up at a regression introduced in 4.9.94 commitment lead to a kernel ops and make t

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation

2018-04-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Apr 2018 15:31:47 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 and 6.1 message structures, and includes > these versions into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang Applied to net-next, thank you.

Re: [PATCH net-next] hv_netvsc: propogate Hyper-V friendly name into interface alias

2018-04-18 Thread David Miller
From: Stephen Hemminger Date: Tue, 17 Apr 2018 14:25:30 -0700 > This patch implement the 'Device Naming' feature of the Hyper-V > network device API. In Hyper-V on the host through the GUI or PowerShell > it is possible to enable the device naming feature which causes > the host to make available

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-04-18 Thread Casey Schaufler
On 4/18/2018 5:46 PM, Paul Moore wrote: > On Wed, Apr 18, 2018 at 8:41 PM, Casey Schaufler > wrote: >> On 4/18/2018 4:47 PM, Paul Moore wrote: >>> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: Implement the proc fs write to set the audit container ID of a process, emitting

Re: [PATCH net-next 00/19] r8169: series with further smaller improvements

2018-04-18 Thread David Miller
From: Heiner Kallweit Date: Tue, 17 Apr 2018 23:16:07 +0200 > This series includes further smaller improvements. > > Then I think the basic cleanup has been done and next step would be > preparing the switch to phylib. Series applied, thank you.

[PATCH] net: add mutex_unlock on xfrm4_protocol_register

2018-04-18 Thread sunlianwen
The function of xfrm4_protocol_register() don't release the mutx lock, which potential cause deadlock. Signed-off-by: Lianwen Sun --- net/ipv4/xfrm4_protocol.c | 4 1 file changed, 4 insertions(+) diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c index 8dd0e6ab8606..1ee34e

Re: [net-next PATCH v4 00/13] Add support for netcp driver on K2G SoC

2018-04-18 Thread David Miller
From: Murali Karicheri Date: Tue, 17 Apr 2018 17:30:29 -0400 > K2G SoC is another variant of Keystone family of SoCs. This patch > series add support for NetCP driver on this SoC. The QMSS found on > K2G SoC is a cut down version of the QMSS found on other keystone > devices with less number of q

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-04-18 Thread Paul Moore
On Wed, Apr 18, 2018 at 8:41 PM, Casey Schaufler wrote: > On 4/18/2018 4:47 PM, Paul Moore wrote: >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: >>> Implement the proc fs write to set the audit container ID of a process, >>> emitting an AUDIT_CONTAINER record to document the event.

Re: [RFC PATCH ghak32 V2 07/13] audit: add container aux record to watch/tree/mark

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID auxiliary record to mark, watch and tree rule > configuration standalone records. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit_fsnotify.c | 5 - > kernel/audit_tree.c | 5 - > kernel/audit_w

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-04-18 Thread Casey Schaufler
On 4/18/2018 4:47 PM, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: >> Implement the proc fs write to set the audit container ID of a process, >> emitting an AUDIT_CONTAINER record to document the event. >> ... >> >> diff --git a/include/linux/sched.h b/include/lin

Re: [RFC PATCH ghak32 V2 06/13] audit: add support for non-syscall auxiliary records

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Standalone audit records have the timestamp and serial number generated > on the fly and as such are unique, making them standalone. This new > function audit_alloc_local() generates a local audit context that will > be used only for a

Re: [PATCH net-next] net: phy: mdio-boardinfo: Allow recursive mdiobus_register()

2018-04-18 Thread Andrew Lunn
On Wed, Apr 18, 2018 at 05:14:36PM -0700, Florian Fainelli wrote: > On 04/18/2018 05:00 PM, Andrew Lunn wrote: > > mdiobus_register will search for any mdiobus board info registered for > > the bus being registered. If found, it will probe devices on the bus. > > That device, if for example it is a

Re: [RFC PATCH ghak32 V2 05/13] audit: add containerid support for ptrace and signals

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID support to ptrace and signals. In particular, the "op" > field provides a way to label the auxiliary record to which it is > associated. > > Signed-off-by: Richard Guy Briggs > --- > include/linux/audit.h | 16 +++

Re: [RFC PATCH ghak32 V2 04/13] audit: add containerid filtering

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Implement container ID filtering using the AUDIT_CONTAINERID field name > to send an 8-character string representing a u64 since the value field > is only u32. > > Sending it as two u32 was considered, but gathering and comparing two > f

Re: [PATCH net-next] net: phy: mdio-boardinfo: Allow recursive mdiobus_register()

2018-04-18 Thread Florian Fainelli
On 04/18/2018 05:00 PM, Andrew Lunn wrote: > mdiobus_register will search for any mdiobus board info registered for > the bus being registered. If found, it will probe devices on the bus. > That device, if for example it is an ethernet switch, may then try to > register an mdio bus. Thus we need to

Re: [RFC PATCH ghak32 V2 02/13] audit: check children and threading before allowing containerid

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Check if a task has existing children or co-threads and refuse to set > the container ID if either are present. Failure to check this could > permit games where a child scratches its parent's back to work around > inheritance and double

Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior

2018-04-18 Thread Hangbin Liu
On Wed, Apr 18, 2018 at 08:50:16AM -0700, Stephen Hemminger wrote: > When davem merges the feature into net-next, dsa will merge this into > iproute2-next. > We hold off merging into iproute2 because often the kernel review feedback > causes > API changes. Got it, Thanks. Regards Hangbin

[PATCH net-next] net: phy: mdio-boardinfo: Allow recursive mdiobus_register()

2018-04-18 Thread Andrew Lunn
mdiobus_register will search for any mdiobus board info registered for the bus being registered. If found, it will probe devices on the bus. That device, if for example it is an ethernet switch, may then try to register an mdio bus. Thus we need to allow recursive calls to mdiobus_register. Holdin

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Implement the proc fs write to set the audit container ID of a process, > emitting an AUDIT_CONTAINER record to document the event. > > This is a write from the container orchestrator task to a proc entry of > the form /proc/PID/containe

Re: [PATCH bpf-next v3 6/8] bpf: add documentation for eBPF helpers (42-50)

2018-04-18 Thread Martin KaFai Lau
On Tue, Apr 17, 2018 at 03:34:36PM +0100, Quentin Monnet wrote: [...] > @@ -965,6 +984,17 @@ union bpf_attr { > * Return > * 0 on success, or a negative error in case of failure. > * > + * int bpf_skb_under_cgroup(struct sk_buff *skb, struct bpf_map *map, u32 > index) > + * Des

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main targe

Re: [PATCH bpf-next v3 6/8] bpf: add documentation for eBPF helpers (42-50)

2018-04-18 Thread Alexei Starovoitov
On Tue, Apr 17, 2018 at 03:34:36PM +0100, Quentin Monnet wrote: > Add documentation for eBPF helper functions to bpf.h user header file. > This documentation can be parsed with the Python script provided in > another commit of the patch series, in order to provide a RST document > that can later be

[PATCH net-next 10/11] net: phy: mdio-gpio: Add #defines for the GPIO index's

2018-04-18 Thread Andrew Lunn
The GPIOs are described in device tree using a list, without names. Add defines to indicate what each index in the list means. These defines should also be used by platform devices passing GPIOs via a GPIO lookup table. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c | 10 +++---

Re: [PATCH 1/6] rhashtable: remove outdated comments about grow_decision etc

2018-04-18 Thread NeilBrown
On Wed, Apr 18 2018, Herbert Xu wrote: > On Wed, Apr 18, 2018 at 04:47:01PM +1000, NeilBrown wrote: >> grow_decision and shink_decision no longer exist, so remove >> the remaining references to them. >> >> Signed-off-by: NeilBrown > > Acked-by: Herbert Xu Thanks. Is that Ack sufficient for th

Re: [PATCH 6/6] rhashtable: add rhashtable_walk_prev()

2018-04-18 Thread NeilBrown
On Wed, Apr 18 2018, Herbert Xu wrote: > On Wed, Apr 18, 2018 at 04:47:02PM +1000, NeilBrown wrote: >> rhashtable_walk_prev() returns the object returned by >> the previous rhashtable_walk_next(), providing it is still in the >> table (or was during this grace period). >> This works even if rhasht

[PATCH net-next 02/11] net: phy: mdio-gpio: Remove reset function

2018-04-18 Thread Andrew Lunn
The platform data can contain a function to call to reset the bit banging interface. It is not used, so remove it. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c | 1 - include/linux/platform_data/mdio-gpio.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/n

[PATCH net-next 06/11] net: phy: mdio-gpio: Remove support for IRQs in platform data

2018-04-18 Thread Andrew Lunn
No current devices use IRQs in platform data, so remove support for it. The MDIO core will also initialise the new bus such that all addresses are polled, so remove the unneeded re-initialisation. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c | 7 --- include/linux/p

[PATCH net-next 05/11] net: phy: mdio-gpio: remove support for phy mask

2018-04-18 Thread Andrew Lunn
This is not needed any more by devices using platform data, so remove it. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c | 4 include/linux/platform_data/mdio-gpio.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/md

[PATCH net-next 03/11] net: phy: mdio-bitbang: Remove reset support

2018-04-18 Thread Andrew Lunn
The mdio-gpio driver was the only user of the interface reset option. Since it no longer uses it, remove it from the bit banging code. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-bitbang.c | 9 - include/linux/mdio-bitbang.h | 2 -- 2 files changed, 11 deletions(-) diff --git

[PATCH net-next 04/11] net: phy: mdio-gpio: remove support for ignoring turn around

2018-04-18 Thread Andrew Lunn
This is not needed any more by devices using platform data, so remove it. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c | 1 - include/linux/platform_data/mdio-gpio.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-

[PATCH net-next 09/11] net: phy: mdio-gpio: Parse properties directly into bitbang structure

2018-04-18 Thread Andrew Lunn
The same parsing code can be used for both OF and platform devices, if the platform device uses a gpiod_lookup_table. Parse these properties directly into the bitbang structure, rather than use an intermediate platform data structure. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-gpio.c |

  1   2   3   4   >