Re: SRIOV switchdev mode BoF minutes

On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar wrote: > I meant between PFs on 2 compute nodes. If the PF serves as uplink rep, it functions as a switch port -- applications don't run on switch ports. One way to get apps to run on the host in switchdev mode is probe one of the VFs there.

[PATCH linux-stable-4.14] tcp: clear tp->packets_out when purging write queue

From: Soheil Hassas Yeganeh Clear tp->packets_out when purging the write queue, otherwise tcp_rearm_rto() mistakenly assumes TCP write queue is not empty. This results in NULL pointer dereference. Also, remove the redundant `tp->packets_out = 0` from tcp_disconnect(), since tcp_disconnect() call

[PATCH net] tcp: clear tp->packets_out when purging write queue

From: Soheil Hassas Yeganeh Clear tp->packets_out when purging the write queue, otherwise tcp_rearm_rto() mistakenly assumes TCP write queue is not empty. This results in NULL pointer dereference. Also, remove the redundant `tp->packets_out = 0` from tcp_disconnect(), since tcp_disconnect() call

Re: Cavium Octeon III network driver.

Hi Steven, On 04/13/2018 03:43 PM, Steven J. Hill wrote: > Patches for Cavium's Octeon III network driver were submitted by > David Daney back on 20180222. David has since left the company and > I am now responsible for the upstreaming effort. When looking at > they are marked as "Not Applicable"

Re: Regression with 5dcd8400884c ("macsec: missing dev_put() on error in macsec_newlink()")

Hello Laura, 2018-04-14, 10:56:55 -0700, Laura Abbott wrote: > Hi, > > Fedora got a bug report of a regression when trying to remove the > the macsec module (https://bugzilla.redhat.com/show_bug.cgi?id=1566410). > I did a bisect and found > > commit 5dcd8400884cc4a043a6d4617e042489e5d566a9 > Aut

Re: v6/sit tunnels and VRFs

I didn't see an easy way to achieve this behavior without affecting the non-VRF routing lookups (such as deleting non-VRF rules). We have some automated tests that were looking for specific responses, but, of course, those can be changed. Among a few of my colleagues, this became a discussion abo

[PATCH 3/3] net: macb: Receive Side Coalescing (RSC) feature added.

This is basically the same as Large Receive Offload (LRO) in Linux framework. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 6 +++ drivers/net/ethernet/cadence/macb_main.c | 70 +++- 2 files changed, 75 insertions(+), 1 deletion(-) diff

[PATCH 2/3] net: macb: Add support for header data spliting

This patch adds support for frames splited between many rx buffers. Header data spliting can be used but also buffers shorter than max frame length. The only limitation is that frame header can't be splited. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 13 +++ dri

[PATCH 1/3] net: macb: Add support for rsc capable hardware

When the pbuf_rsc has been enabled in hardware the receive buffer offset for incoming packets cannot be changed in the network configuration register (even when rsc is not use at all). Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 2 ++ drivers/net/ethernet/cadence

[PATCH 0/3] Receive Side Coalescing for macb driver

This patch series adds support for receive side coalescing for Cadence GEM driver. Receive segmentation coalescing is a mechanism to reduce CPU overhead. This is done by coalescing received TCP message segments together into a single large message. This means that when the message is complete the C

Re: [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO

On 4/14/18 3:11 AM, Peter Zijlstra wrote: On Fri, Apr 13, 2018 at 01:42:14PM -0700, Alexei Starovoitov wrote: On 4/13/18 11:19 AM, Peter Zijlstra wrote: On Tue, Apr 10, 2018 at 02:28:04PM -0700, Alexei Starovoitov wrote: Instead of #ifdef CC_HAVE_ASM_GOTO we can replace it with #ifndef __BPF

Re: [PATCH net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

The net-next tree is closed, please resubmit this when the merge window ends and the net-next tree opens back up. Thank you.

Re: [PATCH v2 net 0/3] sfc: ARFS fixes

From: Edward Cree Date: Fri, 13 Apr 2018 19:16:20 +0100 > Three issues introduced by my recent asynchronous filter handling changes: > 1. The old filter_rfs_insert would replace a matching filter of equal >priority; we need to pass the appropriate argument to filter_insert to >make it do

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

On Fri, 2018-04-13 at 19:26 +0200, Christoph Hellwig wrote: > On Fri, Apr 13, 2018 at 10:12:41AM -0700, Tushar Dave wrote: > > I guess there is nothing we need to do! > > > > On x86, in case of no intel iommu or iommu is disabled, you end up in > > swiotlb for DMA API calls when system has 4G mem

Regression with 5dcd8400884c ("macsec: missing dev_put() on error in macsec_newlink()")

Hi, Fedora got a bug report of a regression when trying to remove the the macsec module (https://bugzilla.redhat.com/show_bug.cgi?id=1566410). I did a bisect and found commit 5dcd8400884cc4a043a6d4617e042489e5d566a9 Author: Dan Carpenter Date: Wed Mar 21 11:09:01 2018 +0300 macsec: missi

Re: [PATCH iproute2-next 3/3] treewide: Use addattr_nest()/addattr_nest_end() to handle nested attributes

On Fri, 13 Apr 2018 15:57:37 -0700 Vinicius Costa Gomes wrote: > Hi, > > Serhey Popovych writes: > > [...] > > > diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c > > index 89b4600..207d644 100644 > > --- a/tc/q_mqprio.c > > +++ b/tc/q_mqprio.c > > @@ -173,8 +173,7 @@ static int mqprio_parse_opt(str

Re: tg3 crashes under high load, when using 100Mbits

Hi Satish, > On 2018Mar21, at 00:57, Kai-Heng Feng wrote: > > Satish Baddipadige wrote: > >> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >> wrote: >>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam >>> wrote: On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng wrote: >

Re: [RFC v2] virtio: support packed ring

On Fri, Apr 13, 2018 at 06:22:45PM +0300, Michael S. Tsirkin wrote: > On Sun, Apr 01, 2018 at 10:12:16PM +0800, Tiwei Bie wrote: > > +static inline bool more_used(const struct vring_virtqueue *vq) > > +{ > > + return vq->packed ? more_used_packed(vq) : more_used_split(vq); > > +} > > + > > +void

Re: [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO

On Fri, Apr 13, 2018 at 01:42:14PM -0700, Alexei Starovoitov wrote: > On 4/13/18 11:19 AM, Peter Zijlstra wrote: > > On Tue, Apr 10, 2018 at 02:28:04PM -0700, Alexei Starovoitov wrote: > > > Instead of > > > #ifdef CC_HAVE_ASM_GOTO > > > we can replace it with > > > #ifndef __BPF__ > > > or some ot

[PATCH net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

tcp_rcv_space_adjust is called every time data is copied to user space, introducing a tcp tracepoint for which could show us when the packet is copied to user. This could help us figure out whether there's latency in user process. When a tcp packet arrives, tcp_rcv_established() will be called and

Re: [PATCH] netfilter: CONFIG_NF_REJECT_IPV{4,6} becomes bool toggle

/Pablo-Neira-Ayuso/netfilter-CONFIG_NF_REJECT_IPV-4-6-becomes-bool-toggle/20180414-101337 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: powerpc64-allmodconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce

[PATCH v3] net: davicom: dm9000: Avoid spinlock recursion during dm9000_timeout routine

On the DM9000B, dm9000_phy_write() is called after the main spinlock is held, during the dm9000_timeout() routine. Spinlock recursion occurs because the main spinlock is requested again in dm9000_phy_write(). So spinlock should be avoided in phy operation during the dm9000_timeout() routine. --- v