Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-02 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > + > +static const struct dma_slave_map pxa_slave_map[] = { > + /* PXA25x, PXA27x and PXA3xx common entries */ > + { "pxa-pcm-audio", "ac97_mic_mono", PDMA_FILTER_PARAM(LOWEST, 8) }, > + { "pxa-pcm-audio", "ac97_aux_mono_in",

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-02 Thread Roopa Prabhu
On Mon, Apr 2, 2018 at 8:26 AM, Chas Williams <3ch...@gmail.com> wrote: > On Mon, Apr 2, 2018 at 11:08 AM, Roopa Prabhu > wrote: >> [snip] >> they are popular...in-fact they are the default bridge mode on our >> network switches. >> And they have been around for some time now to ignore its user

Re: [PATCH 00/47] Netfilter/IPVS updates for net-next

2018-04-02 Thread Rafał Miłecki
Hi Pablo, > The following patchset contains Netfilter/IPVS updates for your net-next > tree. This batch comes with more input sanitization for xtables to > address bug reports from fuzzers, preparation works to the flowtable > infrastructure and assorted updates. In no particular order, they are:

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-02 Thread Alex Vesker
On 4/2/2018 12:12 PM, Jiri Pirko wrote: Fri, Mar 30, 2018 at 05:11:29PM CEST, and...@lunn.ch wrote: Please see: http://patchwork.ozlabs.org/project/netdev/list/?series=36524 I bevieve that the solution in the patchset could be used for your usecase too. Hi Jiri https://lkml.org/lkml/2018/3/

linux-next: build failure after merge of the tip tree

2018-04-02 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/rxrpc/call_object.c: In function 'rxrpc_rcu_destroy_call': net/rxrpc/call_object.c:661:3: error: implicit declaration of function 'wake_up_atomic_t'; did you mean 'wake_up_bit'? [-Werror=imp

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > FWIW, I'm going through the ->kill_sb() instances, fixing that sort > of bugs (most of them preexisting, but I should've checked instead > of assuming that everything's fine). Will push out later tonight. OK, see vfs.git#for-linus. Caug

Re: [GIT PULL] remove in-kernel calls to syscalls

2018-04-02 Thread Linus Torvalds
On Mon, Apr 2, 2018 at 12:04 PM, Dominik Brodowski wrote: > > This patchset removes all in-kernel calls to syscall functions in the > kernel with the exception of arch/. Ok, this finished off my arch updates for today, I'll probably move on to driver pulls tomorrow. Anyway, it's in my tree, will

[PATCH iproute2-next v1] rdma: Print net device name and index for RDMA device

2018-04-02 Thread Leon Romanovsky
From: Leon Romanovsky The RDMA devices are operated in RoCE and iWARP modes have net device underneath. Present their names in regular output and their net index in detailed mode. [root@nps ~]# rdma link show mlx5_3/1 4/1: mlx5_3/1: state ACTIVE physical_state LINK_UP netdev ens7 [root@nps ~]# r

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

2018-04-02 Thread Richard Cochran
On Mon, Mar 26, 2018 at 01:01:58AM +0200, Andrew Lunn wrote: > The phylib core code will take the phydev lock before calling into the > driver. By violating the layering, we are missing on this lock. That lock protects the fields within the struct phy_device, like the state field. None of the tim

Re: WARNING in refcount_dec

2018-04-02 Thread DaeRyong Jeong
No. Only the first crash (WARNING in refcount_dec) is reproduced by the attached reproducer. The second crash (kernel bug at af_packet.c:3107) is reproduced by another reproducer. We reported it here. http://lkml.iu.edu/hypermail/linux/kernel/1803.3/05324.html On Sun, Apr 1, 2018 at 4:38 PM, Will

Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-04-02 Thread Herbert Xu
On Tue, Apr 03, 2018 at 01:41:26PM +1000, NeilBrown wrote: > > Do we really need a rhashtable_walk_peek() interface? > I imagine that a seqfile ->start function can do: > > if (*ppos == 0 && last_pos != 0) { > rhashtable_walk_exit(&iter); > rhashtable_walk_enter(&table, &iter); >

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

2018-04-02 Thread Richard Cochran
On Sun, Mar 25, 2018 at 04:01:49PM -0700, Florian Fainelli wrote: > The best that I can think about and it still is a hack in some way, is > to you have your time stamping driver create a proxy mii_bus whose > purpose is just to hook to mdio/phy_device events (such as link changes) > in order to do

Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-04-02 Thread NeilBrown
On Fri, Mar 30 2018, Herbert Xu wrote: > On Thu, Mar 29, 2018 at 06:52:34PM +0200, Andreas Gruenbacher wrote: >> >> Should rhashtable_walk_peek be kept around even if there are no more >> users? I have my doubts. > > Absolutely. All netlink dumps using rhashtable_walk_next are buggy > and need to

linux-next: manual merge of the net-next tree with the pci tree

2018-04-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_main.c between commit: 2907938d2375 ("net/mlx5e: Use pcie_bandwidth_available() to compute bandwidth") from the pci tree and commit: 0608d4dbaf4e ("net/mlx5e: Unify slow

Re: [PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
Alex, On 4/2/2018 3:06 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel() in multiple places. writel() > already has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code already ha

Re: [PATCH 0/2] rhashtable_walk fixes

2018-04-02 Thread David Miller
From: NeilBrown Date: Tue, 03 Apr 2018 12:23:40 +1000 > I'm sorry if I've caused some confusion, but I didn't think that I was > submitting patches to you and know nothing about your two trees. > I was submitting patches to Thomas and Herbert, the registered > maintainers of rhashtable. I as

Re: [PATCH 0/2] rhashtable_walk fixes

2018-04-02 Thread NeilBrown
On Fri, Mar 30 2018, David Miller wrote: > From: NeilBrown > Date: Thu, 29 Mar 2018 12:19:09 +1100 > >> These two patches apply on top of my previous "rhashtable: reset iter >> when rhashtable_walk_start sees new table" patch. >> >> The first fixes a bug that I found in rhltable_insert(). >> >>

Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer

2018-04-02 Thread Sean Wang
On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: > We would be passing 0 instead of NULL as the rsp argument to > mt7530_fdb_cmd(), fix that. > Acked-by: Sean Wang BTW, does the part of the commit message should be updated with "passing NULL instead of 0"? > Fixes: b8f126a8d543 ("ne

[PATCH net-next] pptp: remove a buggy dst release in pptp_connect()

2018-04-02 Thread Eric Dumazet
Once dst has been cached in socket via sk_setup_caps(), it is illegal to call ip_rt_put() (or dst_release()), since sk_setup_caps() did not change dst refcount. We can still dereference it since we hold socket lock. Caugth by syzbot : BUG: KASAN: use-after-free in atomic_dec_return include/asm-

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

2018-04-02 Thread Alexei Starovoitov
On Thu, Mar 29, 2018 at 11:44:17PM +0100, Edward Cree wrote: > By storing subprog boundaries as a subprogno mark on each insn, rather than > a start (and implicit end) for each subprog, we collect a number of gains: > * More efficient determination of which subprog contains a given insn, and > t

Re: [PATCH net-next 4/5] tun: Add support for SCTP checksum offload

2018-04-02 Thread kbuild test robot
Hi Vladislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladislav-Yasevich/virtio-net-Add-SCTP-checksum-offload-support/20180402-221407 config: m68k-hp300_defconfig (attached as .config

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-02 Thread Jacob Keller
On Mon, Apr 2, 2018 at 7:05 AM, Bjorn Helgaas wrote: > +/* PCIe speed to Mb/s reduced by encoding overhead */ > +#define PCIE_SPEED2MBS_ENC(speed) \ > + ((speed) == PCIE_SPEED_16_0GT ? (16000*(128/130)) : \ > +(speed) == PCIE_SPEED_8_0GT ? (8000*(128/130)) : \ > +(speed) ==

[PATCH net] net: dsa: mt7530: Use NULL instead of plain integer

2018-04-02 Thread Florian Fainelli
We would be passing 0 instead of NULL as the rsp argument to mt7530_fdb_cmd(), fix that. Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") Signed-off-by: Florian Fainelli --- drivers/net/dsa/mt7530.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[PATCH net] net: dsa: b53: Fix sparse warnings in b53_mmap.c

2018-04-02 Thread Florian Fainelli
sparse complains about the following warnings: drivers/net/dsa/b53/b53_mmap.c:33:31: warning: incorrect type in initializer (different address spaces) drivers/net/dsa/b53/b53_mmap.c:33:31:expected unsigned char [noderef] [usertype] *regs drivers/net/dsa/b53/b53_mmap.c:33:31:got void *priv

[PATCH net 0/2] net: Broadcom drivers sparse fixes

2018-04-02 Thread Florian Fainelli
Hi all, This patch series fixes the same warning reported by sparse in bcmsysport and bcmgenet in the code that deals with inserting the TX checksum pointers: drivers/net/ethernet/broadcom/bcmsysport.c:1155:26: warning: cast from restricted __be16 drivers/net/ethernet/broadcom/bcmsysport.c:1155:

[PATCH net 2/2] net: systemport: Fix sparse warnings in bcm_sysport_insert_tsb()

2018-04-02 Thread Florian Fainelli
skb->protocol is a __be16 which we would be calling htons() against, while this is not wrong per-se as it correctly results in swapping the value on LE hosts, this still upsets sparse. Adopt a similar pattern to what other drivers do and just assign ip_ver to skb->protocol, and then use htons() aga

[PATCH net 1/2] net: bcmgenet: Fix sparse warnings in bcmgenet_put_tx_csum()

2018-04-02 Thread Florian Fainelli
skb->protocol is a __be16 which we would be calling htons() against, while this is not wrong per-se as it correctly results in swapping the value on LE hosts, this still upsets sparse. Adopt a similar pattern to what other drivers do and just assign ip_ver to skb->protocol, and then use htons() aga

[PATCH net-next] rxrpc: Fix undefined packet handling

2018-04-02 Thread David Howells
By analogy with other Rx implementations, RxRPC packet types 9, 10 and 11 should just be discarded rather than being aborted like other undefined packet types. Reported-by: Jeffrey Altman Signed-off-by: David Howells --- net/rxrpc/input.c|6 ++ net/rxrpc/protocol.h |6 ++ 2

[PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-04-02 Thread Jakub Kicinski
Some user space depends on enabling sriov_totalvfs number of VFs to not fail, e.g.: $ cat .../sriov_totalvfs > .../sriov_numvfs For devices which VF support depends on loaded FW we have the pci_sriov_{g,s}et_totalvfs() API. However, this API uses 0 as a special "unset" value, meaning drivers can

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 10:52:12PM +0100, Al Viro wrote: > On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > > Tetsuo Handa writes: > > > > I don't think this is a dup of existing bug. > > > We need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. > > > > Even if expanding

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > Tetsuo Handa writes: > > I don't think this is a dup of existing bug. > > We need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. > > Even if expanding mount_ns to more filesystems was magically fixed, > proc would still ha

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-04-02 Thread Jakub Kicinski
On Fri, 30 Mar 2018 09:54:37 -0700, Alexander Duyck wrote: > On Fri, Mar 30, 2018 at 4:49 AM, Christoph Hellwig wrote: > > On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: > >> Some user space depends on driver allowing sriov_totalvfs to be > >> enabled. > > > > I can't make sen

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-04-02 Thread Jakub Kicinski
On Fri, 30 Mar 2018 04:49:05 -0700, Christoph Hellwig wrote: > On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: > > Some user space depends on driver allowing sriov_totalvfs to be > > enabled. > > I can't make sene of this sentence. Can you explain what user space > code depends

Re: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-02 Thread Tal Gilboa
On 4/2/2018 11:25 PM, Keller, Jacob E wrote: -Original Message- From: Bjorn Helgaas [mailto:helg...@kernel.org] Sent: Monday, April 02, 2018 12:58 PM To: Keller, Jacob E Cc: Tal Gilboa ; Tariq Toukan ; Ariel Elior ; Ganesh Goudar ; Kirsher, Jeffrey T ; everest-linux...@cavium.com; int

RE: [PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

2018-04-02 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Bjorn Helgaas > Sent: Monday, April 02, 2018 1:32 PM > To: Keller, Jacob E > Cc: Tal Gilboa ; Tariq Toukan ; Ariel > Elior ; Ganesh Goudar ; > Kirsher, Jeffrey T ; everest-linux..

Re: [PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 03:56:06PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Friday, March 30, 2018 2:06 PM > > To: Tal Gilboa > > Cc: Tariq Toukan ; Keller, Jacob E > > ; Ariel Elior ; Ganesh > > Goudar ; Kirsher, Je

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Eric W. Biederman
Tetsuo Handa writes: > syzbot wrote: >> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >> > wrote: >> >> Switching from mm to fsdevel, for this report says that put_net(net) in >> >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to >> >> register_shrinker() failure. >> >> >> Rele

[PATCH net-next] nfp: add a separate counter for packets with CHECKSUM_COMPLETE

2018-04-02 Thread Jakub Kicinski
We are currently counting packets with CHECKSUM_COMPLETE as "hw_rx_csum_ok". This is confusing. Add a new counter. To make sure it fits in the same cacheline move the less used error counter to a different location. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Marc Zyngier
On Mon, 2 Apr 2018 07:43:49 + Alexander Kurz wrote: > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 > ++--- > 1 file changed, 31 insertions(+), 106 d

RE: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-02 Thread Keller, Jacob E
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Monday, April 02, 2018 12:58 PM > To: Keller, Jacob E > Cc: Tal Gilboa ; Tariq Toukan ; Ariel > Elior ; Ganesh Goudar ; > Kirsher, Jeffrey T ; everest-linux...@cavium.com; > intel-wired-...@lists.osuosl.org; n

Re: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 04:25:17PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Friday, March 30, 2018 2:05 PM > > To: Tal Gilboa > > Cc: Tariq Toukan ; Keller, Jacob E > > ; Ariel Elior ; Ganesh > > Goudar ; Kirsher, Je

Re: [bpf-next PATCH 1/2] bpf: sockmap, free memory on sock close with cork data

2018-04-02 Thread John Fastabend
On 04/02/2018 12:50 PM, John Fastabend wrote: > If a socket with pending cork data is closed we do not return the > memory to the socket until the garbage collector free's the psock > structure. The garbage collector though can run after the sock has > completed its close operation. If this orderin

[bpf-next PATCH 2/2] bpf: sockmap, duplicates release calls may NULL sk_prot

2018-04-02 Thread John Fastabend
It is possible to have multiple ULP tcp_release call paths in flight if a sock is closed and simultaneously being removed from the sockmap control path. The result would be setting the sk_prot to the saved values on the first iteration and then on the second iteration setting the value to NULL. Th

[bpf-next PATCH 1/2] bpf: sockmap, free memory on sock close with cork data

2018-04-02 Thread John Fastabend
If a socket with pending cork data is closed we do not return the memory to the socket until the garbage collector free's the psock structure. The garbage collector though can run after the sock has completed its close operation. If this ordering happens the sock code will through a WARN_ON because

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 04:00:16PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Tal Gilboa [mailto:ta...@mellanox.com] > > Sent: Monday, April 02, 2018 7:34 AM > > To: Bjorn Helgaas > > Cc: Tariq Toukan ; Keller, Jacob E > > ; Ariel Elior ; Ganesh > > Goudar ; Kirsher, Je

Re: [PATCH v2] KEYS: DNS: limit the length of option strings

2018-04-02 Thread Eric Biggers
On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote: > > On Wed, Mar 07, 2018 at 03:54:37PM +, David Howells wrote: > > > Eric Biggers wrote: > > > > > > > Fix it by limiting option strings (combined name + value) to a m

[PATCH v8 2/7] ixgbe: eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

Re: [PATCH net-next v1] ipvs: add consistent source hashing scheduling

2018-04-02 Thread Vincent Bernat
❦ 2 avril 2018 22:05 +0300, Julian Anastasov  : > Sorry to say it but may be you missed the discussion > on lvs-devel about the new MH scheduler implemented by Inju Song: > > https://www.spinics.net/lists/lvs-devel/msg04928.html > http://archive.linuxvirtualserver.org/html/lvs-devel/2018-0

[PATCH v8 1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

[PATCH v8 5/7] fm10k: Eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

[PATCH v8 4/7] igb: eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

[PATCH v8 6/7] ixgbevf: keep writel() closer to wmb()

2018-04-02 Thread Sinan Kaya
Remove ixgbevf_write_tail() in favor of moving writel() close to wmb(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 - drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 +++--- 2 files changed, 3 insertions(+), 8 delet

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Marc Zyngier
[dropping Freddy as I'm getting bounces from asix.com.tw] On Mon, 2 Apr 2018 15:21:08 + Alexander Kurz wrote: Alexander, > Hi Marc, David, > with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") > I made an embarrasly stupid mistake of removing the wrong function. > The v2 patch

[PATCH v8 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

[PATCH v8 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are

[PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

2018-04-02 Thread Sinan Kaya
Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_rela

[GIT PULL] remove in-kernel calls to syscalls

2018-04-02 Thread Dominik Brodowski
Linus, please pull the following changes since commit 0c8efd610b58cb23cefdfa12015799079aef94ae: Linux 4.16-rc5 (2018-03-11 17:25:09 -0700) which are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git syscalls-next up to commit c9a211951c7c7

Re: [PATCH net-next v1] ipvs: add consistent source hashing scheduling

2018-04-02 Thread Julian Anastasov
Hello, On Mon, 2 Apr 2018, Vincent Bernat wrote: > Based on Google's Maglev algorithm [1][2], this scheduler builds a > lookup table in a way disruption is minimized when a change > occurs. This helps in case of active/active setup without > synchronization. Like for classic source hashi

Re: [PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

2018-04-02 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
On 04/02/2018 12:28 PM, David Miller wrote: > From: Murali Karicheri > Date: Mon, 2 Apr 2018 12:17:17 -0400 > >> This patch adds support for promiscuous mode in network driver for K2G >> SoC. This depends on v3 of my series at >> https://www.spinics.net/lists/kernel/msg2765942.html > > The net-n

Re: [net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
Andrew, Thanks for reviewing this! On 04/02/2018 12:47 PM, Andrew Lunn wrote: > On Mon, Apr 02, 2018 at 12:17:19PM -0400, Murali Karicheri wrote: >> +static int gbe_set_rx_mode(void *intf_priv, bool promisc) >> +{ >> +struct gbe_intf *gbe_intf = intf_priv; >> +struct gbe_priv *gbe_dev = g

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-02 Thread Alexei Starovoitov
On Mon, Apr 02, 2018 at 12:09:44PM -0600, David Ahern wrote: > On 4/2/18 12:03 PM, John Fastabend wrote: > > > > Can the above be a normal BPF helper that returns an > > ifindex? Then something roughly like this patter would > > work for all drivers with redirect support, > > > > > > route_

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-02 Thread David Ahern
On 4/2/18 12:03 PM, John Fastabend wrote: > > Can the above be a normal BPF helper that returns an > ifindex? Then something roughly like this patter would > work for all drivers with redirect support, > > > route_ifindex = ip_route_lookup(__daddr, ) > if (!route_ifindex) >

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-02 Thread John Fastabend
On 04/01/2018 05:47 PM, Md. Islam wrote: > This patch implements IPv4 forwarding on xdp_buff. I added a new > config option XDP_ROUTER. Kernel would forward packets through fast > path when this option is enabled. But it would require driver support. > Currently it only works with veth. Here I have

[Patch net] af_unix: remove redundant lockdep class

2018-04-02 Thread Cong Wang
After commit 581319c58600 ("net/socket: use per af lockdep classes for sk queues") sock queue locks now have per-af lockdep classes, including unix socket. It is no longer necessary to workaround it. I noticed this while looking at a syzbot deadlock report, this patch itself doesn't fix it (this

Re: [PATCH net-next v1] ipvs: add consistent source hashing scheduling

2018-04-02 Thread Vincent Bernat
❦ 2 avril 2018 10:33 -0700, Eric Dumazet  : >> +static inline u32 >> +ip_vs_csh_permutation(struct ip_vs_dest *d, int j) >> +{ >> +u32 offset, skip; >> +__be32 addr_fold = d->addr.ip; >> + >> +#ifdef CONFIG_IP_VS_IPV6 >> +if (d->af == AF_INET6) >> +addr_fold = d->addr.ip6

Re: [GIT] Networking

2018-04-02 Thread David Miller
Sorry, this is a dup of the bug fix pull request from last week. I'll send you the right one.

Re: [bpf-next PATCH 4/4] bpf: sockmap, add hash map support

2018-04-02 Thread John Fastabend
On 04/02/2018 08:54 AM, Alexei Starovoitov wrote: > On Sun, Apr 01, 2018 at 08:01:10AM -0700, John Fastabend wrote: >> Sockmap is currently backed by an array and enforces keys to be >> four bytes. This works well for many use cases and was originally >> modeled after devmap which also uses four by

Re: [PATCH net-next v1] ipvs: add consistent source hashing scheduling

2018-04-02 Thread Eric Dumazet
On 04/02/2018 10:20 AM, Vincent Bernat wrote: > +static inline u32 > +ip_vs_csh_permutation(struct ip_vs_dest *d, int j) > +{ > + u32 offset, skip; > + __be32 addr_fold = d->addr.ip; > + > +#ifdef CONFIG_IP_VS_IPV6 > + if (d->af == AF_INET6) > + addr_fold = d->addr.ip6[0]

[PATCH net-next v1] ipvs: add consistent source hashing scheduling

2018-04-02 Thread Vincent Bernat
Based on Google's Maglev algorithm [1][2], this scheduler builds a lookup table in a way disruption is minimized when a change occurs. This helps in case of active/active setup without synchronization. Like for classic source hashing, this lookup table is used to assign connections to a real server

Re: [PATCH net 0/2] net: bgmac: Couple of sparse warnings

2018-04-02 Thread David Miller
From: Florian Fainelli Date: Mon, 2 Apr 2018 10:17:36 -0700 > On 04/01/2018 07:21 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Sun, 1 Apr 2018 10:26:28 -0700 >> >>> This patch series fixes a couple of warnings reported by sparse, should not >>> cause any functional problems since

Re: [PATCH net 0/2] net: bgmac: Couple of sparse warnings

2018-04-02 Thread Florian Fainelli
On 04/01/2018 07:21 PM, David Miller wrote: > From: Florian Fainelli > Date: Sun, 1 Apr 2018 10:26:28 -0700 > >> This patch series fixes a couple of warnings reported by sparse, should not >> cause any functional problems since bgmac is typically used on LE platforms >> anyway. > > Series appli

[ANNOUNCE] iproute 4.16

2018-04-02 Thread Stephen Hemminger
Release of iproute2 for Linux 4.16 Lastest version iproute2 utility to support new features in Linux 4.16. This release covers a wide range of small changes. Lots of changes to: bpf, vrf, devlink, flower, and rdma support. Also more changes to ss and JSON support enhancements. The tarball can be

Re: SO_TCP_NODELAY implementation in TCP stack

2018-04-02 Thread Neal Cardwell
On Sun, Apr 1, 2018 at 4:06 AM Naruto Nguyen wrote: > Hello everyone, > As I know we have a socket option SO_TCP_NODELAY to disable Nagle > Algorithm, and I found it is implemented in TCP/IP stack at > https://elixir.bootlin.com/linux/v4.4.90/source/net/ipv4/tcp.c#L2401 . > However, I do not kno

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-02 Thread Stephen Hemminger
On Sun, 1 Apr 2018 20:47:28 -0400 "Md. Islam" wrote: > This patch implements IPv4 forwarding on xdp_buff. I added a new > config option XDP_ROUTER. Kernel would forward packets through fast > path when this option is enabled. But it would require driver support. > Currently it only works with vet

Re: [net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Andrew Lunn
On Mon, Apr 02, 2018 at 12:17:19PM -0400, Murali Karicheri wrote: > +static int gbe_set_rx_mode(void *intf_priv, bool promisc) > +{ > + struct gbe_intf *gbe_intf = intf_priv; > + struct gbe_priv *gbe_dev = gbe_intf->gbe_dev; > + struct cpsw_ale *ale = gbe_dev->ale; > + unsigned long

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-02 Thread kbuild test robot
: https://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/mt

[GIT] Networking

2018-04-02 Thread David Miller
1) Fix RCU locking in xfrm_local_error(), from Taehee Yoo. 2) Fix return value assignments and thus error checking in iwl_mvm_start_ap_ibss(), from Johannes Berg. 3) Don't count header length twice in vti4, from Stefano Brivio. 4) Fix deadlock in rt6_age_examine_exception, from Eric Dumazet.

Re: [net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread David Miller
From: Murali Karicheri Date: Mon, 2 Apr 2018 12:17:17 -0400 > This patch adds support for promiscuous mode in network driver for K2G > SoC. This depends on v3 of my series at > https://www.spinics.net/lists/kernel/msg2765942.html The net-next tree is closed, please resubmit this series after the

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-02 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Robert-Jarzmik/ARM-pxa-switch-to-DMA-slave-maps/20180402-233029 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones

RE: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-02 Thread Keller, Jacob E
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Friday, March 30, 2018 2:05 PM > To: Tal Gilboa > Cc: Tariq Toukan ; Keller, Jacob E > ; Ariel Elior ; Ganesh > Goudar ; Kirsher, Jeffrey T > ; everest-linux...@cavium.com; intel-wired- > l...@lists.osuosl.org;

[net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
From: WingMan Kwok This patch adds support for promiscuous mode in k2g's network driver. When upper layer instructs to transition from non-promiscuous mode to promiscuous mode or vice versa K2G network driver needs to configure ALE accordingly so that in case of non-promiscuous mode, ALE will not

[net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
This patch adds support for promiscuous mode in network driver for K2G SoC. This depends on v3 of my series at https://www.spinics.net/lists/kernel/msg2765942.html I plan to fold this to the above series and submit again when the net-next merge windows opens. At this time, please review and let me

[net-next 1/2] net: netcp: add api to support set rx mode in netcp modules

2018-04-02 Thread Murali Karicheri
From: WingMan Kwok This patch adds an API to support setting rx mode in netcp modules. If a netcp module needs to be notified when upper layer transitions from one rx mode to another and react accordingly, such a module will implement the new API set_rx_mode added in this patch. Currently rx mo

Re: [PATCH 0/4] RFC: Realtek 83xx SMI driver core

2018-04-02 Thread Carl-Daniel Hailfinger
Hi Linus, did you make any progress with this? I noticed that the Vodafone Easybox 904xdsl/904lte models both make use of the RTL8367 switch. About one million of these routers have been deployed in Germany. There is an OpenWrt fork at https://github.com/Quallenauge/Easybox-904-XDSL/commits/master

RE: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-02 Thread Keller, Jacob E
> -Original Message- > From: Tal Gilboa [mailto:ta...@mellanox.com] > Sent: Monday, April 02, 2018 7:34 AM > To: Bjorn Helgaas > Cc: Tariq Toukan ; Keller, Jacob E > ; Ariel Elior ; Ganesh > Goudar ; Kirsher, Jeffrey T > ; everest-linux...@cavium.com; intel-wired- > l...@lists.osuosl.org;

RE: [PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

2018-04-02 Thread Keller, Jacob E
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Friday, March 30, 2018 2:06 PM > To: Tal Gilboa > Cc: Tariq Toukan ; Keller, Jacob E > ; Ariel Elior ; Ganesh > Goudar ; Kirsher, Jeffrey T > ; everest-linux...@cavium.com; intel-wired- > l...@lists.osuosl.org;

Re: [bpf-next PATCH 4/4] bpf: sockmap, add hash map support

2018-04-02 Thread Alexei Starovoitov
On Sun, Apr 01, 2018 at 08:01:10AM -0700, John Fastabend wrote: > Sockmap is currently backed by an array and enforces keys to be > four bytes. This works well for many use cases and was originally > modeled after devmap which also uses four bytes keys. However, > this has become limiting in larger

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Tariq Toukan
On 02/04/2018 6:19 PM, Eric Dumazet wrote: On 04/02/2018 08:00 AM, Eran Ben Elisha wrote: Seems good, but why isn't this handled directly in GRO native layer ? ip6_tunnel and ip6_gre do not share initialization flow functions (unlike ipv4). Changing the ipv6 init infrastructure should not b

Re: [BUG/Q] can_pernet_exit() leaves devices on dead net

2018-04-02 Thread Kirill Tkhai
Hi, Oliver, On 02.04.2018 18:28, Oliver Hartkopp wrote: > Hi Kirill, Marc, > > I checked the code once more and added some debug output to the other parts > in CAN notifier code. > > In fact the code pointed to by both of you seems to be obsolete as I only > wanted to be 'really sure' that no

Re: [BUG/Q] can_pernet_exit() leaves devices on dead net

2018-04-02 Thread Oliver Hartkopp
Hi Kirill, Marc, I checked the code once more and added some debug output to the other parts in CAN notifier code. In fact the code pointed to by both of you seems to be obsolete as I only wanted to be 'really sure' that no leftovers of the CAN filters at module unloading. Yes, this one

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-02 Thread Chas Williams
On Mon, Apr 2, 2018 at 11:08 AM, Roopa Prabhu wrote: > On Fri, Mar 30, 2018 at 12:54 PM, Chas Williams <3ch...@gmail.com> wrote: >> On Thu, Mar 29, 2018 at 9:02 PM, Toshiaki Makita >> wrote: >>> On 2018/03/30 1:49, Roopa Prabhu wrote: On Thu, Mar 22, 2018 at 9:53 PM, Roopa Prabhu wrot

[RFC] vhost: introduce mdev based hardware vhost backend

2018-04-02 Thread Tiwei Bie
This patch introduces a mdev (mediated device) based hardware vhost backend. This backend is an abstraction of the various hardware vhost accelerators (potentially any device that uses virtio ring can be used as a vhost accelerator). Some generic mdev parent ops are provided for accelerator drivers

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Alexander Kurz
Hi Marc, David, with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") I made an embarrasly stupid mistake of removing the wrong function. The v2 patch accidentially changed ax88179_link_reset() instead of ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate code") is

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Eric Dumazet
On 04/02/2018 08:00 AM, Eran Ben Elisha wrote: Seems good, but why isn't this handled directly in GRO native layer ? >>> ip6_tunnel and ip6_gre do not share initialization flow functions (unlike >>> ipv4). >>> Changing the ipv6 init infrastructure should not be part of this >>> patch. we pr

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-02 Thread Stefan Strogin
Hi David, I don't see how it breaks UAPI. The point is that structures coredump_proc_event and exit_proc_event are members of *union* event_data, thus position of the existing data in the structure is unchanged. Furthermore, this change won't increase size of struct proc_event, because comm_proc_e

Re: [PATCH net v5 2/3] ipv6: allow to cache dst for a connected sk in ip6_sk_dst_lookup_flow()

2018-04-02 Thread David Miller
From: Alexey Kodanev Date: Mon, 2 Apr 2018 17:00:34 +0300 > +++ b/net/ipv6/ip6_output.c > @@ -1105,23 +1105,32 @@ struct dst_entry *ip6_dst_lookup_flow(const struct > sock *sk, struct flowi6 *fl6, > * @sk: socket which provides the dst cache and route info > * @fl6: flow to lookup > *

Re: [PATCH v3 0/2] net: mvneta: improve suspend/resume

2018-04-02 Thread David Miller
From: Jisheng Zhang Date: Mon, 2 Apr 2018 11:22:29 +0800 > This series tries to optimize the mvneta's suspend/resume > implementation by only taking necessary actions. > > Since v2: > - keep rtnl lock when calling mvneta_start_dev() and mvneta_stop_dev() >Thank Russell for pointing this out

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-02 Thread Roopa Prabhu
On Fri, Mar 30, 2018 at 12:54 PM, Chas Williams <3ch...@gmail.com> wrote: > On Thu, Mar 29, 2018 at 9:02 PM, Toshiaki Makita > wrote: >> On 2018/03/30 1:49, Roopa Prabhu wrote: >>> On Thu, Mar 22, 2018 at 9:53 PM, Roopa Prabhu >>> wrote: On Thu, Mar 22, 2018 at 8:34 AM, Chas Williams <3ch..

Re: [net-next PATCH v3 00/11] Add support for netcp driver on K2G SoC

2018-04-02 Thread Murali Karicheri
On 04/02/2018 10:40 AM, David Miller wrote: > > The net-next tree is closed, please resubmit this after the merge window and > the net-next tree is open back up again. > Ok. Will do. Thanks -- Murali Karicheri Linux Kernel, Keystone

  1   2   >