Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote:
>On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote:
>> Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote:
>>>On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote:
Fri, Mar 02, 2018 at 08:42:47PM CET, m...@red
> Hello,
>
> On Fri, 2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote:
> > +static struct {
> > + int pkt_size;
> > + int buf_num;
> > +} mvpp2_pools[MVPP2_BM_POOLS_NUM];
>
> Any reason for not doing:
>
> } mvpp2_pools[MVPP2_BM_POOLS_NUM] = {
> [MVPP2_BM_SHORT] = {
> .pkt
> > netdev_err(port->dev, "Invalid pool %d\n", pool);
> > return NULL;
> > }
> > @@ -4596,11 +4604,24 @@ mvpp2_bm_pool_use(struct mvpp2_port
> *port, int
> > pool, int pkt_size) static int mvpp2_swf_bm_pool_init(struct
> > mvpp2_port *port) {
> > int rxq;
> > + e
> On Fri, 2 Mar 2018 16:40:42 +0100, Antoine Tenart wrote:
>
> > -/* Initialize Tx FIFO's */
> > +/* Initialize Tx FIFO's
> > + * The CP110's total tx-fifo size is 19kB.
> > + * Use large-size 10kB for fast port but 3kB for others.
> > + */
>
> Is there a reason to hardcode 10KB for port 0, and
Switching from mm to fsdevel, for this report says that put_net(net) in
rpc_kill_sb() made net->count < 0 when mount_ns() failed due to
register_shrinker() failure.
Relevant commits will be
commit 9ee332d99e4d5a97 ("sget(): handle failures of register_shrinker()") and
commit d91ee87d8d85a080 ("vfs
From: Simon Wunderlich
Date: Fri, 2 Mar 2018 18:51:35 +0100
> here are some bugfixes which we would like to see integrated into net.
>
> Please pull or let me know of any problem!
Pulled, thanks Simon.
On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote:
> On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote:
> > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote:
> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala
> >> wrote:
> >> > This patch enables virtio_net to switch
On Fri, Mar 02, 2018 at 02:26:48PM -0800, Siwei Liu wrote:
> On Fri, Mar 2, 2018 at 1:31 PM, Michael S. Tsirkin wrote:
> > On Fri, Mar 02, 2018 at 12:44:56PM -0800, Siwei Liu wrote:
> >> On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin
> >> wrote:
> >> > On Fri, Mar 02, 2018 at 11:52:27AM -08
Signed-off-by: Jonathan Neuschäfer
---
include/net/dst_cache.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/dst_cache.h b/include/net/dst_cache.h
index 72fd5067c353..844906fbf8c9 100644
--- a/include/net/dst_cache.h
+++ b/include/net/dst_cache.h
@@ -71,7 +71,7 @
The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for
dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename
the parameter to increase consistency.
This fixes the following kernel-doc warnings:
./include/net/dst_cache.h:58: warning: Function parameter or membe
This fixes the following kernel-doc warning:
./include/net/dst.h:366: warning: Function parameter or member 'net' not
described in 'skb_tunnel_rx'
Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path")
Signed-off-by: Jonathan Neuschäfer
---
include/net/dst.h | 1 +
1 file ch
On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote:
> Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote:
>>On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote:
>>> Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote:
On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wr
From: David Daney
[ Upstream commit 1ef0910cfd681f0bd0b81f8809935b2006e9cfb9 ]
If bpf_needs_clear_a() returns true, only actually clear it if it is
ever used. If it is not used, we don't save and restore it, so the
clearing has the nasty side effect of clobbering caller state.
Also, don't emit
From: David Daney
[ Upstream commit a81507c79f4ae9a0f9fb1054b59b62a090620dd9 ]
o Socket data is unsigned, so use unsigned accessors instructions.
o Fix path result pointer generation arithmetic.
o Fix half-word byte swapping code for unsigned semantics.
Signed-off-by: David Daney
Cc: James
From: David Daney
[ Upstream commit 1ef0910cfd681f0bd0b81f8809935b2006e9cfb9 ]
If bpf_needs_clear_a() returns true, only actually clear it if it is
ever used. If it is not used, we don't save and restore it, so the
clearing has the nasty side effect of clobbering caller state.
Also, don't emit
From: David Daney
[ Upstream commit a81507c79f4ae9a0f9fb1054b59b62a090620dd9 ]
o Socket data is unsigned, so use unsigned accessors instructions.
o Fix path result pointer generation arithmetic.
o Fix half-word byte swapping code for unsigned semantics.
Signed-off-by: David Daney
Cc: James
When addressing a review comment in a early version of the offending
patch a comment where left in which should have been removed. Remove the
comment to keep it consistent with the code.
Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU")
Reported-by: Sergei Shtylyov
Signed-off-by: Nik
From: David Daney
[ Upstream commit 1ef0910cfd681f0bd0b81f8809935b2006e9cfb9 ]
If bpf_needs_clear_a() returns true, only actually clear it if it is
ever used. If it is not used, we don't save and restore it, so the
clearing has the nasty side effect of clobbering caller state.
Also, don't emit
Hi!
`lnstat` segfaults (tested on Debian 9, CentOS 6+7, Fedora 27) if it is
started as `lnstat -w 1`
according to gdb the crash is in `build_hdr_string` at lnstat.c:212
as it seems to be an useless value for the option anyway it might make
sense to just handle a single "1" the same as if "0" was
Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote:
>On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote:
>> Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote:
>>>On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote:
>Yeah, this code essentially calls out the "sh
On 03/03/2018 12:48 PM, Guenter Roeck wrote:
On 03/03/2018 11:07 AM, Troy Kisky wrote:
On 3/3/2018 8:32 AM, Guenter Roeck wrote:
Hi,
since v4.15, I get the following runtime warning when running sabrelite images
in qemu.
irq 65: nobody cared (try booting with the "irqpoll" option)
...
handler
On Sat, Mar 03, 2018 at 09:57:15PM +0100, Daniel Borkmann wrote:
> On 03/03/2018 05:02 PM, Daniel Axtens wrote:
> >> From: Daniel Axtens
> >>
> >> SCTP GSO skbs have a gso_size of GSO_BY_FRAGS, so any sort of
> >> unconditionally mangling of that will result in nonsense value
> >> and would corrup
On 03/03/2018 05:02 PM, Daniel Axtens wrote:
>> From: Daniel Axtens
>>
>> SCTP GSO skbs have a gso_size of GSO_BY_FRAGS, so any sort of
>> unconditionally mangling of that will result in nonsense value
>> and would corrupt the skb later on.
>>
>> Therefore, i) add two helpers skb_increase_gso_size
On 03/03/2018 11:07 AM, Troy Kisky wrote:
On 3/3/2018 8:32 AM, Guenter Roeck wrote:
Hi,
since v4.15, I get the following runtime warning when running sabrelite images
in qemu.
irq 65: nobody cared (try booting with the "irqpoll" option)
...
handlers:
[<26292474>] fec_pps_interrupt
Disabling IR
On 3/3/2018 8:32 AM, Guenter Roeck wrote:
> Hi,
>
> since v4.15, I get the following runtime warning when running sabrelite images
> in qemu.
>
> irq 65: nobody cared (try booting with the "irqpoll" option)
> ...
> handlers:
> [<26292474>] fec_pps_interrupt
> Disabling IRQ #65
> fec 2188000.ether
On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote:
> Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote:
>>On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote:
>>> >Yeah, this code essentially calls out the "shareable" code with a
>>> >comment at the start and end of the section what
On Sat, 3 Mar 2018 16:59:44 +
Jean-Philippe Brucker wrote:
> When ss is invoked with the no-header flag, if the query doesn't return
> any result, render() is called with 'buffer' uninitialized. This
> currently leads to a segfault. Ensure that buffer is initialized before
> rendering.
>
>
When ss is invoked with the no-header flag, if the query doesn't return
any result, render() is called with 'buffer' uninitialized. This
currently leads to a segfault. Ensure that buffer is initialized before
rendering.
The bug can be triggered with: ss -H sport = 10
Signed-off-by: Jean-Phili
Hi,
since v4.15, I get the following runtime warning when running sabrelite images
in qemu.
irq 65: nobody cared (try booting with the "irqpoll" option)
...
handlers:
[<26292474>] fec_pps_interrupt
Disabling IRQ #65
fec 2188000.ethernet (unnamed net_device) (uninitialized): MDIO read timeout
Bis
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
Changes in v2:
- Braces is dropped from if with single statement.
drivers/net/ethernet/amd/ni65.c | 4 +---
drivers/net/ethernet/neterion/s2
Hi Daniel,
> From: Daniel Axtens
>
> SCTP GSO skbs have a gso_size of GSO_BY_FRAGS, so any sort of
> unconditionally mangling of that will result in nonsense value
> and would corrupt the skb later on.
>
> Therefore, i) add two helpers skb_increase_gso_size() and
> skb_decrease_gso_size() that wo
Hi!
The Netfilter project proudly presents:
nftables 0.8.3
This release includes a few fixes since last release plus following
enhancements:
- ifname_type, so its possible to match interface names via sets:
table inet t {
set s {
type ifname
elements = { "eth0",
On Sat, 3 Mar 2018, Arushi Singhal wrote:
> Continue at the bottom of a loop are removed.
> Issue found using drop_continue.cocci Coccinelle script.
In each case you leave an if with a single statement in the branch. In
that case the { } should be dropped too.
julia
>
> Signed-off-by: Arushi
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/net/ethernet/amd/ni65.c | 1 -
drivers/net/ethernet/neterion/s2io.c | 1 -
drivers/net/ethernet/netronome/nfp/nfp_net_ma
On Fri, Mar 02, 2018 at 09:16:48PM +0300, Alexey Kodanev wrote:
> When we exceed current packets limit and have more than one
> segment in the list returned by skb_gso_segment(), netem drops
> only the first one, skipping the rest, hence kmemleak reports:
>
> unreferenced object 0x880b5d23b600
Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote:
>On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote:
>> >Yeah, this code essentially calls out the "shareable" code with a
>> >comment at the start and end of the section what defines the
>> >virtio_bypass functionality. It would j
On Fri, 2 Mar 2018 15:39:03 -0700
David Ahern wrote:
> On 3/2/18 8:36 AM, Stefano Brivio wrote:
> > Currently, administrative MTU changes on a given netdevice are
> > not reflected on route exceptions for MTU-less routes, with a
> > set PMTU value, for that device:
> >
> > # ip -6 route get 300
Hi Maciej,
On Fri, 2 Mar 2018 10:54:36 -0800
Maciej Żenczykowski wrote:
> I spend a significant fraction of my time making sure we never rely on PMTUD.
Thanks for your comments.
I see your point, but here we are not blindly relying on PMTUD,
rather reflecting an MTU administrative change on th
On Friday, March 03/02/18, 2018 at 18:52:45 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On production servers running variety of workloads over time, kernel
> > panic can happen sporadically after days or even months. It is
> > important to collect as much debug logs as possi
On 2018-03-02 19:43, Guillaume Nault wrote:
On Thu, Mar 01, 2018 at 10:07:05PM +0200, Denys Fedoryshchenko wrote:
On 2018-03-01 22:01, Guillaume Nault wrote:
> diff --git a/drivers/net/ppp/ppp_generic.c
> b/drivers/net/ppp/ppp_generic.c
> index 255a5def56e9..2acf4b0eabd1 100644
> --- a/drivers/n
On Thu, Mar 01, 2018 at 02:41:04PM -0500, Richard Guy Briggs wrote:
...
> +static inline bool audit_containerid_set(struct task_struct *tsk)
Hi Richard,
the calls to audit_containerid_set() confused me. Could you make it
is_audit_containerid_set() or audit_containerid_isset()?
> +{
> + retu
hi My name is Vanessa Ali. a France Nationality, I am a widow,
currently hospitalized due to cancer illness . Meanwhile, I have
decided to donate my fund to you as a reliable individual that will
use this money wisely, €2,800.000 Million Euros. to help the poor and
less privileged.
So if you are w
Am 2. März 2018 12:37:25 MEZ schrieb Kirill Tkhai :
>destroy_radio() may be executed in parallel with everything above you
>wrote,
>doesn't it? There may be several network namespaces, and
>destroy_radio()
>queued from one net namespace may race with mac80211_hwsim_new_radio()
>or hwsim_del_radio
43 matches
Mail list logo