Stephen Hemminger wrote:
> On Tue, 27 Feb 2018 14:06:51 +0200
> Serhey Popovych wrote:
>
>> diff --git a/include/compat/libc/bits/socket.h
>> b/include/compat/libc/bits/socket.h
>> new file mode 100644
>> index 000..25ef0d5
>> --- /dev/null
>> +++ b/include/compat/libc/bits/socket.h
>> @@ -0
Stephen Hemminger wrote:
> On Tue, 27 Feb 2018 21:34:56 +0200
> Serhey Popovych wrote:
>
>> Stephen Hemminger wrote:
>>> On Tue, 27 Feb 2018 14:06:50 +0200
>>> Serhey Popovych wrote:
>>>
Since commit 596b1c94aa38 ("iproute: build more easily on Android"),
iproute2 uses types __kerne
On 2018-03-01 19:40, Alexander Duyck wrote:
> On Thu, Mar 1, 2018 at 8:12 AM, wrote:
> > + intel-wired-...@lists.osuosl.org
> >
> >
> > On 2018-03-01 21:41, p...@codeaurora.org wrote:
> >>
> >> Hi All,
> >>
> >> I am facing the following issue on kernel 4.14.14.
> >>
> >> Enable SRIOV on Intel x7
On Fri, 2 Mar 2018 14:25:29 +0800
Jason Wang wrote:
> @@ -770,6 +774,19 @@ static struct sk_buff *receive_mergeable(struct
> net_device *dev,
> goto err_xdp;
> rcu_read_unlock();
> goto xdp_xmit;
> + case XDP_
> From: Tian, Kevin
> Sent: Friday, March 2, 2018 2:54 PM
>
> > From: Alex Williamson
> > Sent: Friday, March 2, 2018 4:22 AM
> > >
> > > I am pretty sure that you are describing is true of some, but not for
> > > all. I think the Amazon solutions and the virtio solution are doing
> > > hard parti
> From: Alex Williamson
> Sent: Friday, March 2, 2018 4:22 AM
> >
> > I am pretty sure that you are describing is true of some, but not for
> > all. I think the Amazon solutions and the virtio solution are doing
> > hard partitioning of the part. I will leave it to those guys to speak
> > for thems
XDP_REDIRECT support for mergeable buffer was removed since commit
7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
case"). This is because we don't reserve enough tailroom for struct
skb_shared_info which breaks XDP assumption. So this patch fixes this
by reserving enough tai
On 3/1/18 9:07 PM, Ka-Cheong Poon wrote:
Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the
accept socket") has a reference counting issue in TCP socket creation
when accepting a new connection. The code uses sock_create_lite() to
create a kernel socket. But it does not do _
On 2018-03-02 09:10, Alexander Duyck wrote:
On Thu, Mar 1, 2018 at 8:12 AM, wrote:
+ intel-wired-...@lists.osuosl.org
On 2018-03-01 21:41, p...@codeaurora.org wrote:
Hi All,
I am facing the following issue on kernel 4.14.14.
Enable SRIOV on Intel x710 card.
echo 32 > /sys/class/net/eth1/
> > +static int lan743x_phy_reset(struct lan743x_adapter *adapter) {
> > + u32 data;
> > +
> > + data = lan743x_csr_read(adapter, PMT_CTL);
> > + data |= PMT_CTL_ETH_PHY_RST_;
> > + lan743x_csr_write(adapter, PMT_CTL, data);
> > +
> > + return readx_poll_timeout(LAN743X_CSR_READ_OP, PMT_C
Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the
accept socket") has a reference counting issue in TCP socket creation
when accepting a new connection. The code uses sock_create_lite() to
create a kernel socket. But it does not do __module_get() on the
socket owner. When the
Hi all,
Commits
568477045f80 (" phy: marvell10g: Utilize gen10g_no_soft_reset()")
0adfdb667ab5 (" phy: cortina: Utilize generic functions")
aebc78a40b88 (" phy: teranetics: Utilize generic functions")
e8a714e086e4 (" phy: Export gen10g_* functions")
6ed33d3a06e6 (" phy: aquantia: Utiliz
Hi David,
On 03/01/2018 04:25 PM, Florian Fainelli wrote:
> Hi all,
>
> After turning on KASAN on one of my systems, I started getting lots of out of
> bounds errors while fetching a given port's statistics, and indeed using
> memcpy() is unsafe for copying strings, so let's use strncpy() instead
On 03/01/2018 07:08 PM, Andrew Lunn wrote:
> On Thu, Mar 01, 2018 at 04:25:29PM -0800, Florian Fainelli wrote:
>> Do not use memcpy() which is not safe, but instead use strncpy() which
>> will make sure that the string is NUL terminated (in the Linux
>> implementation) if the string is smaller th
From: Quentin Monnet
Make bpftool read its command list from standard input when the name if
the input file is a single dash.
Signed-off-by: Quentin Monnet
Acked-by: Jakub Kicinski
---
tools/bpf/bpftool/main.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/b
On Thu, 2018-03-01 at 18:58 -0800, Cong Wang wrote:
> As suggested by Eric, we need to make the xt_rateest
> hash table and its lock per netns to reduce lock
> contentions.
>
> Cc: Florian Westphal
> Cc: Eric Dumazet
> Cc: Pablo Neira Ayuso
> Signed-off-by: Cong Wang
> ---
> include/net/netfi
On 2018年03月01日 21:36, Michael S. Tsirkin wrote:
On Thu, Mar 01, 2018 at 11:19:04AM +0800, Jason Wang wrote:
XDP_REDIRECT support for mergeable buffer was removed since commit
7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
case"). This is because we don't reserve enough
Quentin says:
Several enhancements for bpftool batch mode are introduced in this series.
More specifically, input files for batch mode gain support for:
* comments (starting with '#'),
* continuation lines (after a line ending with '\'),
* arguments enclosed between quotes.
Also, make bpft
From: Quentin Monnet
Add support for continuation lines, such as in the following example:
prog show
prog dump xlated \
id 1337 opcodes
This patch is based after the code for support for continuation lines
from file lib/utils.c from package iproute2.
"Lines" in error messages a
From: Quentin Monnet
Replace '#' by '\0' in commands read from batch files in order to avoid
processing the remaining part of the line, thus allowing users to use
comments in the files.
Signed-off-by: Quentin Monnet
Acked-by: Jakub Kicinski
---
tools/bpf/bpftool/main.c | 5 +
1 file chang
From: Quentin Monnet
Improve argument parsing from batch input files in order to support
arguments enclosed between single (') or double quotes ("). For example,
this command can now be parsed in batch mode:
bpftool prog dump xlated id 1337 file "/tmp/my file with spaces"
The function respo
On 2018年03月01日 22:16, Jesper Dangaard Brouer wrote:
On Thu, 1 Mar 2018 21:15:36 +0800
Jason Wang wrote:
On 2018年03月01日 18:35, Jesper Dangaard Brouer wrote:
On Thu, 1 Mar 2018 17:23:37 +0800
Jason Wang wrote:
On 2018年03月01日 17:10, Jesper Dangaard Brouer wrote:
On Thu, 1 Mar 2018 11:19
On Thu, 1 Mar 2018 22:38:50 -0500, Alexander Aring wrote:
> I guess to make extack working, you need to return an errno if failed.
AFAIK extack is printed as a warning if operation did not fail.
On Thu, Mar 1, 2018 at 8:12 AM, wrote:
> + intel-wired-...@lists.osuosl.org
>
>
> On 2018-03-01 21:41, p...@codeaurora.org wrote:
>>
>> Hi All,
>>
>> I am facing the following issue on kernel 4.14.14.
>>
>> Enable SRIOV on Intel x710 card.
>> echo 32 > /sys/class/net/eth1/device/sriov_numvfs
>> s
Hi,
On Wed, Feb 28, 2018 at 4:45 AM, Jiri Pirko wrote:
> From: Nogah Frankel
>
> Offload sch_prio graft command for capable drivers.
> Warn in case of a failure, unless the graft was done as part of a destroy
> operation (the new qdisc is a noop) or if all the qdiscs (the parent, the
> old child
Rename NETEVENT_MULTIPATH_HASH_UPDATE to
NETEVENT_IPV4_MPATH_HASH_UPDATE to denote it relates to a change
in the IPv4 hash policy.
Signed-off-by: David Ahern
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
include/net/netevent.h| 2 +-
net/ipv4/s
Symmetry is good and allows easy comparison that ipv4 and ipv6 are
doing the same thing. To that end, change ip_multipath_l3_keys to
set addresses at the end after the icmp compares, and move the
initialization of ipv6 flow keys to rt6_multipath_hash.
Signed-off-by: David Ahern
---
net/ipv4/rout
Make rt6_multipath_hash more of a direct parallel to fib_multipath_hash
and reduce stack and overhead in the process: get_hash_from_flowi6 is
just a wrapper around __get_hash_from_flowi6 with another stack
allocation for flow_keys. Move setting the addresses, protocol and
label into rt6_multipath_h
As of commit e37b1e978bec5 ("ipv6: route: dissect flow in input path if
fib rules need it") fib_multipath_hash takes an optional flow keys. If
non-NULL it means the skb has already been dissected. If not set, then
fib_multipath_hash needs to call skb_flow_dissect_flow_keys.
Simplify the logic by s
IPv6 does path selection for multipath routes deep in the lookup
functions. The next patch adds L4 hash option and needs the skb
for the forward path. To get the skb to the relevant FIB lookup
functions it needs to go through the fib rules layer, so add a
lookup_data argument to the fib_lookup_arg
Some operators prefer IPv6 path selection to use a standard 5-tuple
hash rather than just an L3 hash with the flow the label. To that end
add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb
("net: ipv4: add support for ECMP hash policy choice"). The default
is still L3 which cove
fib_multipath_hash only needs net struct to check a sysctl. Make it
clear by passing net instead of fib_info. In the need this allows
alignment between the ipv4 and ipv6 versions.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 5 +++--
net/ipv4/fib_semantics.c | 2 +-
net/ipv4/route.c
__get_hash_from_flowi6 is still used for flowlabels, but the IPv4
variant and the wrappers to both are not used. Remove them.
Signed-off-by: David Ahern
---
include/net/flow.h| 15 ---
net/core/flow_dissector.c | 16
2 files changed, 31 deletions(-)
diff --g
Hardware supports multipath selection using the standard L4 5-tuple
instead of just L3 and the flow label. In addition, some network
operators prefer IPv6 path selection to use the 5-tuple. To that end,
add support to IPv6 for multipath hash policy similar to
bf4e0a3db97eb ("net: ipv4: add support
Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash
parameters upon netevents") for IPv4, make sure the kernel and asic are
using the same hash algorithm for path selection.
Signed-off-by: David Ahern
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 11 ++-
Add IPv6 multipath test using L4 hashing. Created with inputs from
Ido Schimmel.
Signed-off-by: David Ahern
---
.../selftests/net/forwarding/router_multipath.sh | 44 ++
1 file changed, 44 insertions(+)
diff --git a/tools/testing/selftests/net/forwarding/router_multipath.s
> +void mv88e6352_serdes_get_strings(struct mv88e6xxx_chip *chip,
> + int port, uint8_t *data)
> +{
> + struct mv88e6352_serdes_hw_stat *stat;
> + int i;
> +
> + if (!mv88e6352_port_has_serdes(chip, port))
> + return;
> +
> + for (i = 0; i <
On Thu, Mar 01, 2018 at 04:25:29PM -0800, Florian Fainelli wrote:
> Do not use memcpy() which is not safe, but instead use strncpy() which
> will make sure that the string is NUL terminated (in the Linux
> implementation) if the string is smaller than the length specified. This
> fixes KASAN out of
As suggested by Eric, we need to make the xt_rateest
hash table and its lock per netns to reduce lock
contentions.
Cc: Florian Westphal
Cc: Eric Dumazet
Cc: Pablo Neira Ayuso
Signed-off-by: Cong Wang
---
include/net/netfilter/xt_rateest.h | 4 +-
net/netfilter/xt_RATEEST.c | 91 +
On Thu, Mar 01, 2018 at 06:01:15PM -0800, Jakub Kicinski wrote:
> Jiong says:
>
> This patch set is an application of CFG information on eBPF program
> visualization. It presents some initial code for building CFG information
> from eBPF instruction sequences.
>
> After we get eBPF program byteco
On Thu, Mar 1, 2018 at 3:58 PM, Alex Williamson
wrote:
> On Thu, 1 Mar 2018 14:42:40 -0800
> Alexander Duyck wrote:
>
>> On Thu, Mar 1, 2018 at 12:22 PM, Alex Williamson
>> wrote:
>> > On Wed, 28 Feb 2018 16:36:38 -0800
>> > Alexander Duyck wrote:
>> >
>> >> On Wed, Feb 28, 2018 at 2:59 PM, Ale
From: Eric Dumazet
Date: Wed, 28 Feb 2018 14:40:45 -0800
> Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots,
> I found that BBR was performing poorly, because of TSO being limited to 16KB
>
> This patch series makes sure BBR is not under estimating number
> of packets that are neede
From: Daniel Borkmann
Date: Wed, 28 Feb 2018 21:27:58 +0100
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) Add schedule points and reduce the number of loop iterations
>the test_bpf kernel module is performing in order to not hog
>
From: Soheil Hassas Yeganeh
Date: Tue, 27 Feb 2018 18:22:40 -0500
> From: Soheil Hassas Yeganeh
>
> recvmmsg does not call ___sys_recvmsg when sk_err is set.
> That is fine for normal reads but, for MSG_ERRQUEUE, recvmmsg
> should always call ___sys_recvmsg regardless of sk->sk_err to
> be able
From: Mike Manning
Date: Mon, 26 Feb 2018 23:49:30 +
> Setting an interface into a VRF fails with 'RTNETLINK answers: File
> exists' if one of its VLAN interfaces is already in the same VRF.
> As the VRF is an upper device of the VLAN interface, it is also showing
> up as an upper device of t
This patch removes testns after test failure so that next test can
continue with clean ns
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/net/rtnetlink.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/rtnetlink.sh
b/tools/testing/selftests/net/r
This series adds support for IPv6 vxlan offload and UDP rss along with a
bug fix in filling the rq ring.
Govindarajulu Varadarajan (6):
enic: Check inner ip proto for pseudo header csum
enic: Add vxlan offload support for IPv6 pkts
enic: Check if hw supports multi wq with vxlan offload
eni
From: Florian Fainelli
Date: Thu, 1 Mar 2018 16:08:54 -0800
> This patch series reduces the duplication among 10G PHY drivers that just
> essentially stub most functions, but do that while replicating what the
> existing
> generic functions do.
Series applied, thanks Florian.
New adapter needs CMD_OPENF_IG_DESCCACHE flag to be set. If this flag is
not set, fw flushes the global IG desc cache. This flag is nop in older
adapter.
Also increment driver version
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic.h| 2 +-
drivers/net/
New hardware needs UDP flag set to enable UDP L4 rss hash. Add ethtool
get option to display supported rss flow hash.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 36 ++
drivers/net/ethernet/cisco/enic/enic_main.c| 4 +
From: Finn Thain
Date: Thu, 1 Mar 2018 18:29:28 -0500 (EST)
> Changes since v4 of combined patch series:
> - Removed redundant and non-portable MACH_IS_MAC tests.
> - Added acked-by tags from Geert Uytterhoeven.
> - Omitted patches unrelated to mac89x0 driver.
Series applied, thank you.
To compute pseudo IP header csum, we need to check the inner header for
encap pkt, not outer IP header.
Also add pseudo csum for IPv6 inner pkt.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic_main.c | 15 ++-
1 file changed, 14 insertions(+), 1 del
New adaptors supports vxlan offload for inner IPv6 and outer IPv6 vxlan
pkts.
Fw sets BIT(0) & BIT(1) in a1 if hw supports ipv6 inner & outer pkt
offload.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic.h| 1 +
drivers/net/ethernet/cisco/enic/enic_main
Some adaptors do not support vxlan offload when multi wq is configured.
If hw supports multi wq, BIT(2) is set in a1.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic_main.c | 5 +
drivers/net/ethernet/cisco/enic/vnic_devcmd.h | 1 +
2 files changed, 6 ins
rq should be enabled before posting the buffers to rq desc. If not hw sees
stale value and casuses DMAR errors.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/cisco/enic/enic_main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethe
From: David Ahern
Date: Thu, 1 Mar 2018 13:49:29 -0800
> Bug fixes and an enhancement for the recent forwarding tests:
> - only check tc version on tc tests
> - handle multipath tests failing with 0 packet count
> - fix ping command for IPv6 on Debian jessie
> - improve summary of multipath test
On Thu, 2018-03-01 at 17:55 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport
> and dport")
> Reported-by: Eric Dumazet
> Signed-off-by: Roopa Prabhu
> ---
> include/net/fib_rules.h | 6 +-
> 1 file changed, 5 in
From: Jakub Kicinski
Date: Thu, 1 Mar 2018 18:01:15 -0800
> This patch set is an application of CFG information on eBPF program
> visualization. It presents some initial code for building CFG information
> from eBPF instruction sequences.
For series:
Acked-by: David S. Miller
From: Roopa Prabhu
Date: Thu, 1 Mar 2018 17:55:37 -0800
> From: Roopa Prabhu
>
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport
> and dport")
> Reported-by: Eric Dumazet
> Signed-off-by: Roopa Prabhu
Applied, thanks Roopa.
From: Jiong Wang
This patch adds new command-line option for visualizing the xlated eBPF
sequence.
Documentations are updated accordingly.
Usage:
bpftool prog dump xlated id 2 visual
Reviewed-by: Quentin Monnet
Signed-off-by: Jiong Wang
Acked-by: Jakub Kicinski
---
tools/bpf/bpftool/Doc
Jiong says:
This patch set is an application of CFG information on eBPF program
visualization. It presents some initial code for building CFG information
from eBPF instruction sequences.
After we get eBPF program bytecode, we do sub-program detection and
basic-block partition. These information t
From: Jiong Wang
This patch partition basic-block for each function in the CFG. The
algorithm is simple, we identify basic-block head in a first traversal,
then second traversal to identify the tail.
We could build extended basic-block (EBB) in next steps. EBB could make the
graph more readable
From: Quentin Monnet
Add bash completion for the "visual" keyword used for dumping the CFG of
eBPF programs with bpftool. Make sure we only complete with this keyword
when we dump "xlated" (and not "jited") instructions.
Acked-by: Jiong Wang
Signed-off-by: Quentin Monnet
Acked-by: Jakub Kicins
From: Jiong Wang
This patch let bpftool print .dot graph file into stdout.
This graph is generated by the following steps:
- iterate through the function list.
- generate basic-block(BB) definition for each BB in the function.
- draw out edges to connect BBs.
This patch is the initial su
From: Jiong Wang
It is obvious we could use 'else if' instead of start a new 'if' in the
touched code.
Signed-off-by: Jiong Wang
Acked-by: Jakub Kicinski
---
tools/bpf/bpftool/prog.c | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/t
From: Jiong Wang
This patch detect all sub-programs from the eBPF sequence and keep the
information in the new CFG data structure.
The detection algorithm is basically the same as the one in verifier except
we need to use insn->off instead of insn->imm to get the pc-relative call
offset. Because
From: Jiong Wang
This patch adds out edges for each basic-block. We will need these out
edges to finish the .dot graph drawing.
Signed-off-by: Jiong Wang
Acked-by: Jakub Kicinski
---
tools/bpf/bpftool/cfg.c | 162 +++-
1 file changed, 160 insertions
From: Jiong Wang
This patch factors out those code of dumping xlated eBPF instructions into
xlated_dumper.[h|c].
They are quite independent dumper functions, so better to be kept
separately.
New dumper support will be added in later patches in this set.
Signed-off-by: Jiong Wang
Acked-by: Jak
From: Cong Wang
Date: Thu, 1 Mar 2018 13:46:35 -0800
> This patchset backports 4 important bug fixes for tc filter to
> 4.14 stable branch. Due to some big changes between 4.14 and 4.15,
> the backports are not trivial, I have to adjust and fix the conflicts
> manually.
>
> Thanks to Roland for
From: Roopa Prabhu
Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and
dport")
Reported-by: Eric Dumazet
Signed-off-by: Roopa Prabhu
---
include/net/fib_rules.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/net/fib_rules.h b/includ
So pointer rings work fine, but they have a problem: make them too small
and not enough entries fit. Make them too large and you start flushing
your cache and running out of memory.
This is a new idea of mine: a ring backed by a linked list. Once you run
out of ring entries, instead of a drop you
Dear friend
I am contacting you because I am dying and I want you to adopt my daughter. In
Adopting my daughter, I am willing to allocate to you my funds deposited in a
bank. When I get response from you, I will give you more details.
Charlotte Jonathan.
On 2018-03-01 14:41, Richard Guy Briggs wrote:
> Implement the proc fs write to set the audit container ID of a process,
> emitting an AUDIT_CONTAINER record to document the event.
>
> This is a write from the container orchestrator task to a proc entry of
> the form /proc/PID/containerid where PI
Hi all,
After turning on KASAN on one of my systems, I started getting lots of out of
bounds errors while fetching a given port's statistics, and indeed using
memcpy() is unsafe for copying strings, so let's use strncpy() instead.
Florian Fainelli (4):
net: dsa: b53: Use strncpy() for ethtool::
Do not use memcpy() which is not safe, but instead use strncpy() which
will make sure that the string is NUL terminated (in the Linux
implementation) if the string is smaller than the length specified. This
fixes KASAN out of bounds warnings while fetching port statistics.
Fixes: 967dd82ffc52 ("ne
Do not use memcpy() which is not safe, but instead use strncpy() which
will make sure that the string is NUL terminated (in the Linux
implementation) if the string is smaller than the length specified. This
fixes KASAN out of bounds warnings while fetching port statistics.
Fixes: 484c01720d84 ("ne
Do not use memcpy() which is not safe, but instead use strncpy() which
will make sure that the string is NUL terminated (in the Linux
implementation) if the string is smaller than the length specified. This
fixes KASAN out of bounds warnings while fetching port statistics.
Fixes: b987e98e50ab ("ds
Do not use memcpy() which is not safe, but instead use strncpy() which
will make sure that the string is NUL terminated (in the Linux
implementation) if the string is smaller than the length specified. This
fixes KASAN out of bounds warnings while fetching port statistics.
Fixes: f5e2ed022dff ("ds
Hi all,
This patch series reduces the duplication among 10G PHY drivers that just
essentially stub most functions, but do that while replicating what the existing
generic functions do.
Changes in v3:
- removed unused "reg" variable in teranetics.c
- fixed subject for patch 5 since we actually us
In order to remove a fair amount of duplication in the different 10G PHY
drivers, export all gen10g_* functions to be able to make use of those.
While we are at it, rename gen10g_soft_reset() to gen10g_no_soft_reset()
to illustrate what it does.
Signed-off-by: Florian Fainelli
---
drivers/net/ph
The driver duplicates what the generic function does, so use the generic
function intead.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/aquantia.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia
cortina_soft_reset() does the same thing as gen10g_soft_reset(), and
cortina_config_aneg() is actually doing what gen10g_config_init() does
for 10G capable PHYs.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/cortina.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-
We do the same thing as the generic function: nothing, so utilize it.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/marvell10g.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index 8a0bd98fdec7..4
Update teranetics_aneg_done() to use genphy_c45_aneg_done() instead of
duplicating that code, and switch to gen10g_* functions where
appropriate instead of maintaining identical copies doing nothing.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/teranetics.c | 32 +-
On Thu, 1 Mar 2018 14:42:40 -0800
Alexander Duyck wrote:
> On Thu, Mar 1, 2018 at 12:22 PM, Alex Williamson
> wrote:
> > On Wed, 28 Feb 2018 16:36:38 -0800
> > Alexander Duyck wrote:
> >
> >> On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson
> >> wrote:
> >> > On Wed, 28 Feb 2018 09:49:21 -
On Thu, 1 Mar 2018 10:27:55 -0800
Stephen Hemminger wrote:
> + if (change & IFF_PROMISC)
> + dev_set_promiscuity(net,
> + (net->flags & IFF_PROMISC) ? 1 : -1);
This should be vf_netdev here.
Simplify the code slightly by having seq_open_data do the ->private assignment.
Signed-off-by: Rasmus Villemoes
---
drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
b/dri
Fix log message fragments that no longer produce the desired output
since the behaviour of printk() was changed.
Add missing printk severity levels.
Drop deprecated "out of memory" message as per checkpatch advice.
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 19
Apparently these Dayna cards don't have a pseudoslot declaration ROM
which means they can't be probed like NuBus cards.
Cc: Geert Uytterhoeven
Signed-off-by: Finn Thain
Acked-by: Geert Uytterhoeven
---
arch/m68k/mac/config.c| 4 +++
drivers/net/Space.c | 3 -
Changes since v4 of combined patch series:
- Removed redundant and non-portable MACH_IS_MAC tests.
- Added acked-by tags from Geert Uytterhoeven.
- Omitted patches unrelated to mac89x0 driver.
Finn Thain (4):
net/mac89x0: Remove redundant code
net/mac89x0: Convert to platform_driver
net/mac
Adopt the conventional style of debug logging because it is both
shorter and more flexible.
Remove the 'version_printed' flag as the version will be printed
only once anyway (when the module loads).
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 47 +++-
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/net/ethernet/cirrus/mac89x0.c
b/drivers/net/ethernet/cirrus/mac89x0.c
index 977d4c2c759d..4fe0ae93ab36 100644
--- a/drivers/net/etherne
On 03/01/2018 06:47 AM, Prashant Bhole wrote:
> test_cgrp2_sock.sh and test_cgrp2_sock2.sh tests keep the program
> attached to cgroup even after completion.
> Using detach functionality of test_cgrp2_sock in both scripts.
>
> Signed-off-by: Prashant Bhole
Applied to bpf-next, thanks Prashant!
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/smc/smc_core.c
between commit:
2be922f31606 ("net/smc: use link_id of server in confirm link reply")
from the net tree and commit:
52bedf37bafe ("net/smc: process add/delete link messages")
from the net-next t
On Thu, Mar 1, 2018 at 2:48 PM, Eric Dumazet wrote:
> On Tue, 2018-02-27 at 19:52 -0800, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> uapi for ip_proto, sport and dport range match
>> in fib rules.
>
>
> Hi Roopa
>
> FRA_UNSPEC,
>> FRA_DST,/* destination address */
>> @@
On 2/28/18 10:47 PM, Prashant Bhole wrote:
> test_cgrp2_sock.sh and test_cgrp2_sock2.sh tests keep the program
> attached to cgroup even after completion.
> Using detach functionality of test_cgrp2_sock in both scripts.
>
> Signed-off-by: Prashant Bhole
> ---
> samples/bpf/test_cgrp2_sock.sh |
On Tue, 2018-02-27 at 19:52 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> uapi for ip_proto, sport and dport range match
> in fib rules.
Hi Roopa
FRA_UNSPEC,
> FRA_DST,/* destination address */
> @@ -59,6 +64,9 @@ enum {
> FRA_L3MDEV, /* iif or oif is l3md
On Thu, Mar 1, 2018 at 1:59 PM, Andy Lutomirski wrote:
> On Thu, Mar 1, 2018 at 9:51 PM, Sargun Dhillon wrote:
>> On Thu, Mar 1, 2018 at 9:44 AM, Andy Lutomirski wrote:
>>> On Wed, Feb 28, 2018 at 7:56 PM, Daniel Borkmann
>>> wrote:
On 02/28/2018 12:55 AM, chris hyser wrote:
>> On 02/
On Thu, Mar 1, 2018 at 12:22 PM, Alex Williamson
wrote:
> On Wed, 28 Feb 2018 16:36:38 -0800
> Alexander Duyck wrote:
>
>> On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson
>> wrote:
>> > On Wed, 28 Feb 2018 09:49:21 -0800
>> > Alexander Duyck wrote:
>> >
>> >> On Tue, Feb 27, 2018 at 2:25 PM, A
William reported ip hanging and bisected to a recent commit for batching
allowing more than 1 command to be sent per message. The loop over
recvmsg should never cycle more than iovlen times -- 1 response for
each command in the message.
Fixes: 72a2ff3916e5 ("lib/libnetlink: Add a new function rtnl
1 - 100 of 285 matches
Mail list logo
