Advertise NETIF_F_GRO_HW in hw_features if hardware GRO is supported.
In bnxt_fix_features(), disable GRO_HW and LRO if current hardware
configuration does not allow it. XDP setup will now rely on
bnxt_fix_features() to turn off aggregation. During chip init, turn on
or off hardware GRO based on
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
GRO. With this flag, we can now independently turn on or off hardware
GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to
control hardware GRO and so it cannot be independently turned on or
off without affecting GR
Introduce NETIF_F_GRO_HW feature flag and convert drivers that support
hardware GRO to use the new flag.
v3:
- Let driver's ndo_fix_features() disable NETIF_F_LRO when NETIF_F_GRO_HW
is set instead of doing it in common netdev_fix_features().
v2:
- NETIF_F_GRO_HW flag propagation between upper an
Hardware should not aggregate any packets when generic XDP is installed.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
net/core/dev.c | 24
1 file changed, 24 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 6ebd0e7..ec
Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW
is set. Disable NETIF_F_GRO_HW in bnx2x_fix_features() if the MTU
does not support TPA_MODE_GRO. bnx2x_change_mtu() also needs to disable
NETIF_F_GRO_HW if the MTU does not support it.
Cc: Ariel Elior
Cc: everest-linux...@cav
Advertise NETIF_F_GRO_HW and set edev->gro_disable according to the
feature flag. Add qede_fix_features() to drop NETIF_F_GRO_HW if
XDP is running or MTU does not support GRO_HW. qede_change_mtu()
also checks and disables GRO_HW if MTU is not supported.
Cc: Ariel Elior
Cc: everest-linux...@cavi
On Sat, Dec 9, 2017 at 6:09 AM, Cong Wang wrote:
> On Thu, Dec 7, 2017 at 9:28 PM, Tonghao Zhang
> wrote:
>>
>> Release the netlink sock created in kernel(not hold the _net_ namespace):
>>
>
> You can avoid counting kernel sock by testing 'kern' in sk_alloc()
> and testing 'sk->sk_net_refcnt' in
Closing a multicast socket after the final IPv4 address is deleted
from an interface will generate a membership report that uses the
source IP from a different interface. The following test script, run
from an isolated netns, reproduces the issue:
#!/bin/bash
ip link add dummy0 type dumm
On Fri, Dec 8, 2017 at 9:24 PM, Eric Dumazet wrote:
> On Fri, 2017-12-08 at 19:29 +0800, Tonghao Zhang wrote:
>> hi all. we can add synchronize_rcu and rcu_barrier in
>> sock_inuse_exit_net to
>> ensure there are no outstanding rcu callbacks using this network
>> namespace.
>> we will not have to
Hello,
I'm Mr. Hazim, A banker working in a bank in my country; there is a certain
deceased customer of my bank who left behind her fund.
I seek your partnership in receiving this fund. If interested, reply
immediately for detailed information.
My sincere regards, Mr. Hazim Issa.
> Ok, let me retry:
>
> > One thing to debug this problem is to dump the MIB counters. Use the
> ethtool
> > utility to show MIB counters of both ports:
> >
> > ethtool -S lan3
> > ethtool -S eth0
> >
> > Assuming eth0 is the MAC controller that drives the switch, the receive
> counters of
> > th
From: Carl Heymann
Convert the requested dump level parameter to big-endian at the start of
nfp_net_dump_calculate_size() and nfp_net_dump_populate_buffer(), then
compare and assign it directly where needed in the traversal and prolog
code. This decreases the total number of conversions used.
Si
From: John Hurley
Port matching is selected by default on every rule so remove check for it
and delete 'else' side of the statement. Remove nfp_flower_meta_one as now
it will not feature in the code. Rename nfp_flower_meta_two given that one
has been removed.
'Additional metadata' if statement c
Hi!
This series contains small clean ups from John and Carl, and brings
no functional changes.
John's improvements target the flower code. First he makes sure we don't
allocate space in FW request messages for MAC matches if the TC rule does
not contain any. The remaining two patches remove som
From: John Hurley
Delete match field defines that are not supported at this time.
Signed-off-by: John Hurley
Reviewed-by: Dirk van der Merwe
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethe
From: John Hurley
Remove the matching of mac/mpls as a default selection. These are not
necessarily set by a TC rule (unlike the port). Previously a mac/mpls
field would exist in every match and be masked out if not used. This patch
has no impact on functionality but removes unnessary memory assi
2017-12-09 0:28 GMT+08:00 David Miller :
> From: Yafang Shao
> Date: Fri, 8 Dec 2017 23:50:44 +0800
>
>> 2017-12-08 23:42 GMT+08:00 David Miller :
>>> From: Yafang Shao
>>> Date: Fri, 8 Dec 2017 11:40:23 +0800
>>>
It will looks like these,
if (sk->sk_protocol == IPPROTO_TCP)
>>
The purpose of pushing indication on a list and handle these in a
separate worker is to allow the handlers to sleep. It does therefor not
make much sense to hold the queue spinlock through the entire indication
worker function.
By removing items from the queue early we don't need to hold the lock
Sali,
On Fri, Dec 8, 2017 at 10:16 PM, Salil Mehta wrote:
> This patch adds the support of the mailbox to the VF driver. The
> mailbox shall be used as an interface to communicate with the
> PF driver for various purposes like {set|get} MAC related
> operations, reset, link status etc. The mailbo
On Fri, 8 Dec 2017 15:50:25 -0800
Solio Sarabia wrote:
> On Fri, Dec 08, 2017 at 02:23:23PM -0500, David Miller wrote:
> > From: Stephen Hemminger
> > Date: Thu, 7 Dec 2017 15:40:18 -0800
> >
> > > This is the more general way to solving the issue of GSO limits
> > > not being set correctly
On Wed, 6 Dec 2017, David Miller wrote:
From: Govindarajulu Varadarajan
Date: Tue, 5 Dec 2017 11:14:41 -0800
In case of tx clean up, we set '-1' as budget. This means clean up until
wq is empty or till (1 << 32) pkts are cleaned. Under heavy load this
will run for long time and cause
"watchd
On Fri, Dec 08, 2017 at 02:23:23PM -0500, David Miller wrote:
> From: Stephen Hemminger
> Date: Thu, 7 Dec 2017 15:40:18 -0800
>
> > This is the more general way to solving the issue of GSO limits
> > not being set correctly for containers on Azure. If a GSO packet
> > is sent to host that excee
On Fri, 8 Dec 2017 14:52:36 +, Roman Gushchin wrote:
> +static int list_attached_bpf_progs(int cgroup_fd, enum bpf_attach_type type)
> +{
> + __u32 prog_ids[1024] = {0};
> + char *attach_flags_str;
> + __u32 prog_cnt, iter;
> + __u32 attach_flags;
> + char buf[16];
> + i
Fixes: 46e6b992c250 ("rtnetlink: allow GSO maximums to be set on device
creation")
Signed-off-by: Stephen Hemminger
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 412ebf0b09c6..c688dc564b11 100644
---
On Fri, 8 Dec 2017 09:52:16 -0700, David Ahern wrote:
> On 12/8/17 8:39 AM, Quentin Monnet wrote:
> > I don't believe compatibility is an issue here, since the program and
> > its documentation come together (so they should stay in sync) and are
> > part of the kernel tree (so the tool should be co
On 12/8/2017 3:54 AM, Alexey Kodanev wrote:
On 12/08/2017 10:02 AM, Steffen Klassert wrote:
On Wed, Dec 06, 2017 at 07:38:19PM +0300, Alexey Kodanev wrote:
Since you're planning to do a 2nd version anyway, can we get a couple of
the commit message issues cleaned up?
LTP/udp6_ipsec_vti test
On 12/08/2017 09:24 PM, Josef Bacik wrote:
> On Fri, Dec 08, 2017 at 04:35:44PM +0100, Daniel Borkmann wrote:
>> On 12/06/2017 05:12 PM, Josef Bacik wrote:
>>> Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went
>>> to
>>> figure out why the compiler didn't catch it and it'
On Fri, Dec 8, 2017 at 2:09 PM, Marcelo Ricardo Leitner
wrote:
> Hi,
>
> On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote:
>> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> @@ -940,6 +940,9 @@ int qede_change_mtu(struct
Hi,
On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote:
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -940,6 +940,9 @@ int qede_change_mtu(struct net_device *ndev, int new_mtu)
> DP_VERBOSE(edev, (NETIF_MSG_IFUP
On Thu, Dec 7, 2017 at 9:28 PM, Tonghao Zhang wrote:
>
> Release the netlink sock created in kernel(not hold the _net_ namespace):
>
You can avoid counting kernel sock by testing 'kern' in sk_alloc()
and testing 'sk->sk_net_refcnt' in __sk_free().
This patch adds the support of the mailbox to the VF driver. The
mailbox shall be used as an interface to communicate with the
PF driver for various purposes like {set|get} MAC related
operations, reset, link status etc. The mailbox supports both
synchronous and asynchronous command send to PF driv
This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem 3)
Virtual Function Ethernet driver for hip08 family of SoCs. The Physical Function
driver is already part of the Linux mainline.
This VF driver has its Hardware Compatibility Layer and has commom/unified ENET
layer/clie
Most of the NAPI handling interface, skb buffer management,
management of the RX/TX descriptors, ethool interface etc.
has quite a bit of code which is common to VF and PF driver.
This patch makes the exisitng PF's HNS3 ENET driver as the
common ENET driver for both Virtual & Physical Function. Th
This patch adds the support of hardware compatibiltiy layer to the
HNS3 VF Driver. This layer implements various {set|get} operations
over MAC address for a virtual port, RSS related configuration,
fetches the link status info from PF, does various VLAN related
configuration over the virtual port,
Command queue provides the provision of Mailbox command which
can be used for communication between PF and VF. PF handles
messages from various VFs for fetching various information like,
queue, vlan, link status related etc. It also handles the request
from various VFs to perform certain privileged
This patch is required to support ring-vector binding and reset
of TQPs requested by the VF driver to the PF driver. Mailbox
handler is added with corresponding VF commands/messages to
handle the request.
Signed-off-by: Salil Mehta
Signed-off-by: lipeng
---
Patch V2: Addressed some internal comm
This patch introduces the new Makefiles and updates existing
Makefiles required to build the HNS3 Virtual Function driver.
This also updates the Kconfig for introduction of new menuconfig
entries related to VF driver.
Signed-off-by: Salil Mehta
Signed-off-by: lipeng
---
drivers/net/ethernet/his
All PF mailbox events are conveyed through a common interrupt
(vector 0). This interrupt vector is shared by reset and mailbox.
This patch adds the handling of mailbox interrupt event and its
deferred processing in context to a separate mailbox task.
Signed-off-by: Salil Mehta
Signed-off-by: lip
This patch adds support of command interface for communication with
the IMP(Integrated Management Processor) for HNS3 Virtual Function
Driver.
Each VF has support of CQP(Command Queue Pair) ring interface.
Each CQP consis of send queue CSQ and receive queue CRQ.
There are various commands a VF may
On Fri, 2017-12-08 at 12:26 -0800, Matt Turner wrote:
>
> Thanks for the quick reply!
>
> I tried the patch on top of master, but unfortunately the corruption
> still occurs.
You might try replacing in sbdma_add_rcvbuffer()
sb_new = netdev_alloc_skb(dev, size);
by
sb_new = alloc_skb(size, GF
On Fri, Dec 08, 2017 at 11:18:36AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso wrote:
[...]
>
> > diff --git a/net/netfilter/nf_flow_table.c b/net/netfilter/nf_flow_table.c
> > index ff27dad268c3..c578c3aec0e0 100644
> > --- a/net/netfilter/nf_flow_table.c
> > +++ b/net/netfilter/nf_flow_t
On Fri, Dec 08, 2017 at 11:04:13AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso wrote:
> > This patch adds the IPv4 flow table type, that implements the datapath
> > flow table to forward IPv4 traffic. Rationale is:
> >
> > 1) Look up for the packet in the flow table, from the ingress hook.
On Thu, Dec 7, 2017 at 8:59 PM, Jakub Kicinski wrote:
> On Thu, 7 Dec 2017 20:51:27 -0800, Jakub Kicinski wrote:
>> Running the netdevsim test after a week and a bit of not trying it:
>>
>> $ make -C tools/testing/selftests/bpf/ CLANG=clang LLC=llc
>> # ./tools/testing/selftests/bpf/test_offload.p
On Fri, Dec 08, 2017 at 07:47:02AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso wrote:
> > diff --git a/include/uapi/linux/netfilter/nf_conntrack_common.h
> > b/include/uapi/linux/netfilter/nf_conntrack_common.h
> > index dc947e59d03a..6b463b88182d 100644
> > --- a/include/uapi/linux/netfil
On 12/08/2017 at 09:11 PM Andreas Hartmann wrote:
> On 12/08/2017 at 05:04 PM Willem de Bruijn wrote:
>> On Fri, Dec 8, 2017 at 6:40 AM, Michal Kubecek wrote:
>>> On Fri, Dec 08, 2017 at 11:31:50AM +0100, Andreas Hartmann wrote:
On 12/08/2017 at 09:47 AM Michal Kubecek wrote:
> On Fri, De
On Fri, Dec 08, 2017 at 11:08:56AM -0500, Neil Horman wrote:
> On Fri, Dec 08, 2017 at 04:04:58PM +, David Laight wrote:
> > From: Marcelo Ricardo Leitner
> > > Sent: 08 December 2017 16:00
> > ...
> > > > Is it worth replacing the si struct with an index/enum value, and
> > > > indexing an
>
On Fri, Dec 8, 2017 at 5:52 AM, Eric Dumazet wrote:
> On Fri, 2017-12-08 at 05:42 -0800, Eric Dumazet wrote:
>> On Thu, Dec 7, 2017 at 11:54 PM, Matt Turner
>> wrote:
>> > On Thu, Dec 7, 2017 at 11:00 PM, Matt Turner
>> > wrote:
>> > > On Sun, Mar 12, 2017 at 6:43 PM, Matt Turner
>> > > wrote:
On Fri, Dec 08, 2017 at 04:35:44PM +0100, Daniel Borkmann wrote:
> On 12/06/2017 05:12 PM, Josef Bacik wrote:
> > Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went
> > to
> > figure out why the compiler didn't catch it and it's because it was not used
> > anywhere. I had
On 12/08/2017 at 05:04 PM Willem de Bruijn wrote:
> On Fri, Dec 8, 2017 at 6:40 AM, Michal Kubecek wrote:
>> On Fri, Dec 08, 2017 at 11:31:50AM +0100, Andreas Hartmann wrote:
>>> On 12/08/2017 at 09:47 AM Michal Kubecek wrote:
On Fri, Dec 08, 2017 at 08:21:16AM +0100, Andreas Hartmann wrote:
On Fri, Dec 8, 2017 at 10:27 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Since the block is freed with last chain being put, once we reach the
> end of iteration of list_for_each_entry_safe, the block may be
> already freed. I'm hitting this only by creating and deleting clsact:
List is still t
vhost (2017-12-04 11:32:02
-0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
for you to fetch changes up to fd29117aeb905aaacdf4ff5afbc7787fa50e16e4:
Merge tag 'linux-can-fixes-for-4.15-20171208' of
git://git.kernel.or
On 12/06/2017 11:45 PM, Song Liu wrote:
> Changes PATCH v4 to PATCH v5:
> Remove PERF_PROBE_CONFIG_IS_RETPROBE from uapi, use PMU_FORMAT_ATTR
> instead.
>
> Changes PATCH v3 to PATCH v4:
> Remove uapi define MAX_PROBE_FUNC_NAME_LEN, use KSYM_NAME_LEN instead.
> Add flag PERF_PROBE_CONFIG_I
From: Marc Kleine-Budde
Date: Fri, 8 Dec 2017 16:58:11 +0100
> this is a pull request of 6 patches for net/master.
>
> Martin Kelly provides 5 patches for various USB based CAN drivers, that
> properly cancel the URBs on adapter unplug, so that the driver doesn't
> end up in an endless loop. St
From: Girish Moodalbail
Date: Fri, 8 Dec 2017 06:03:26 -0800
> Move 'macaddr_count' from after 'netpoll' to after 'nest_level' to pack
> and reduce a memory hole.
>
> Fixes: 88ca59d1aaf28c25 (macvlan: remove unused fields in struct macvlan_dev)
> Signed-off-by: Girish Moodalbail
Applied, than
From: Kalle Valo
Date: Fri, 08 Dec 2017 16:32:16 +0200
> this is a pull request to net tree for 4.15, more info in the signed tag
> below. All small fixes and not really expecting any problems, but please
> let me know if you have any.
Pulled, thanks Kalle.
On 12/08/2017 12:00 AM, Jakub Kicinski wrote:
> Hi!
>
> This is a follow up to a series of Makefile fixes for bpftool from
> two weeks ago. I think there will have to be a merge back of net-next
> into bpf-next (or rebase), AFAICT the previous series arrived in
> net-next already, but not in bpf-
From: Marc Kleine-Budde
Date: Fri, 8 Dec 2017 12:18:59 +0100
> The first and only parameter of sl_alloc() is unused, so remove it.
>
> Fixes: 5342b77c4123 slip: ("Clean up create and destroy")
> Signed-off-by: Marc Kleine-Budde
Applied.
While reviewing this I noticed that slip_devs[], along
From: Antoine Tenart
Date: Fri, 8 Dec 2017 10:24:20 +0100
> The macro used to access or set an RSS table entry was using an offset
> of 8, while it should use an offset of 0. This lead to wrongly configure
> the RSS table, not accessing the right entries.
>
> Fixes: 1d7d15d79fb4 ("net: mvpp2: i
From: Alexei Starovoitov
Date: Thu, 7 Dec 2017 22:22:11 -0800
> The following pull-request contains BPF updates for your net-next tree.
>
> The main changes are:
>
> 1) Detailed documentation of BPF development process from Daniel.
>
> 2) Addition of is_fullsock, snd_cwnd and srtt_us fields to
From: Rahul Lakkireddy
Date: Fri, 8 Dec 2017 09:48:35 +0530
> Collect more hardware logs via ethtool --get-dump facility.
>
> Patch 1 collects on-chip memory layout information.
>
> Patch 2 collects on-chip MC memory dumps.
>
> Patch 3 collects HMA memory dump.
>
> Patch 4 evaluates and skip
From: David Daney
Date: Thu, 7 Dec 2017 16:09:33 -0800
> +static void bgx_port_check_state(struct work_struct *work)
> +{
...
> + mutex_lock(&priv->lock);
> + if (priv->work_queued)
> + queue_delayed_work(check_state_wq, &priv->dwork, HZ);
> + mutex_unlock(&priv->lock);
Hi David,
>>> This adds support for setting the public address on Texas Instruments
>>> Bluetooth chips using a vendor-specific command.
>>>
>>> This has been tested on a CC2560A. The TI wiki also indicates that this
>>> command should work on TI WL17xx/WL18xx Bluetooth chips.
>>>
>>> Signed-off
From: Stephen Hemminger
Date: Thu, 7 Dec 2017 15:40:18 -0800
> This is the more general way to solving the issue of GSO limits
> not being set correctly for containers on Azure. If a GSO packet
> is sent to host that exceeds the limit (reported by NDIS), then
> the host is forced to do segmentat
On 12/08/2017 02:07 AM, Marcel Holtmann wrote:
Hi David,
This adds support for setting the public address on Texas Instruments
Bluetooth chips using a vendor-specific command.
This has been tested on a CC2560A. The TI wiki also indicates that this
command should work on TI WL17xx/WL18xx Blueto
From: Niklas Cassel
Date: Thu, 7 Dec 2017 23:56:10 +0100
> There is nothing that says that number of TX queues == number of RX
> queues. E.g. the ARTPEC-6 SoC has 2 TX queues and 1 RX queue.
>
> This code is obviously wrong:
> for (chan = 0; chan < tx_channel_count; chan++) {
> struct stmma
From: Yuchung Cheng
Date: Thu, 7 Dec 2017 11:33:29 -0800
> This patch set has four minor bug fixes in TCP RACK loss recovery.
Series applied, thank you.
From: Egil Hjelmeland
Date: Thu, 7 Dec 2017 19:56:04 +0100
> ALR table operations are a sequence of related register operations which
> should be protected from concurrent access. The alr_cache should also be
> protected. Add alr_mutex doing that.
>
> Signed-off-by: Egil Hjelmeland
Applied.
From: Jiri Pirko
Date: Fri, 8 Dec 2017 19:27:27 +0100
> From: Jiri Pirko
>
> Since the block is freed with last chain being put, once we reach the
> end of iteration of list_for_each_entry_safe, the block may be
> already freed. I'm hitting this only by creating and deleting clsact:
...
> Fix
From: Michael Chan
Date: Fri, 8 Dec 2017 09:35:42 -0800
> On Fri, Dec 8, 2017 at 9:05 AM, Calvin Owens wrote:
>> After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
>> 903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
>> we still see the following WARN fir
On 2017-12-08 09:26, Dan Williams wrote:
On Sun, 2017-12-03 at 23:37 -0700, Subash Abhinov Kasiviswanathan
wrote:
Add an option to configure the rmnet aggregation and command features
on device creation. This is achieved by using the vlan flags option.
Does this overload the VLAN flags item wi
From: John Fastabend
Date: Thu, 07 Dec 2017 09:53:46 -0800
> This series adds support for building lockless qdiscs.
Series applied, nice work.
I particularly like how you solved the GSO and bad_tx requeueing.
Thanks!
On Thu, 7 Dec 2017 16:12:00 -0800
Wei Wang wrote:
> From: Wei Wang
>
> tcpi_rcv_ssthresh is an important stats when debugging receive side
> behavior.
> Add it to the ss output.
>
> Signed-off-by: Wei Wang
> Signed-off-by: Eric Dumazet
Applied
On Fri, 8 Dec 2017 18:07:19 +0100
Stefano Brivio wrote:
> Currently, 'ss' simply subdivides the whole available screen width
> between available columns, starting from a set of hardcoded amount
> of spacing and growing column widths.
>
> This makes the output unreadable in several cases, as it
From: Neal Cardwell
Date: Thu, 7 Dec 2017 12:43:29 -0500
> This patch series has a few minor bug fixes for cases where spurious
> loss recoveries can trick BBR estimators into estimating that the
> available bandwidth is much lower than the true available bandwidth.
> In both cases the fix here
From: Jiri Pirko
Since the block is freed with last chain being put, once we reach the
end of iteration of list_for_each_entry_safe, the block may be
already freed. I'm hitting this only by creating and deleting clsact:
[ 202.171952]
From: Bert Kenward
Date: Thu, 7 Dec 2017 17:18:58 +
> The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers
> cannot be NULL. Add a paranoid warning to check this condition and fix
> the one case where they were NULL.
>
> efx_enqueue_unwind() is called very rarely, during err
From: Claudiu Manoil
Date: Thu, 7 Dec 2017 18:44:23 +0200
> This controller does not support EEE, but it may connect to a PHY
> which supports EEE and advertises EEE by default, while its link
> partner also advertises EEE. If this happens, the PHY enters low
> power mode when the traffic rate is
Hi Dave,
On Fri, Dec 8, 2017 at 4:38 PM, David Miller wrote:
> Sorry, you cannot force the discussion of a feature which will be submitted
> upstream to occur on a private mailing list.
>
> It is _ABSOLUTELY_ appropriate to discss this on netdev since it is the
> netdev community which must consi
From: Jason Wang
Date: Thu, 7 Dec 2017 15:08:45 +0800
>
>
> On 2017年12月07日 13:09, Michael S. Tsirkin wrote:
>> On Thu, Dec 07, 2017 at 01:15:15PM +0900, Toshiaki Makita wrote:
>>> Since commit 39e6c8208d7b ("net: solve a NAPI race") napi has been
>>> able
>>> to be rescheduled within napi_compl
From: "Michael S. Tsirkin"
Date: Tue, 5 Dec 2017 21:29:37 +0200
> Users of ptr_ring expect that it's safe to give the
> data structure a pointer and have it be available
> to consumers, but that actually requires an smb_wmb
> or a stronger barrier.
>
> In absence of such barriers and on architec
On Sat, Dec 9, 2017 at 1:29 AM, David Laight wrote:
> From: Xin Long ...
>> Hi, David, Sorry, I'm not sure we're worrying about the cpu cost or
>> codes style now ?
>>
>> For cpu cost, I think 0x848(%r13) operation must be better than the
>> generated code of if-else.
>
> Nope - the call xxx(%ry
On Fri, Dec 8, 2017 at 9:05 AM, Calvin Owens wrote:
> After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
> 903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
> we still see the following WARN fire:
>
> [ cut here ]
> WARNING: CPU:
From: Xin Long ...
> Hi, David, Sorry, I'm not sure we're worrying about the cpu cost or
> codes style now ?
>
> For cpu cost, I think 0x848(%r13) operation must be better than the
> generated code of if-else.
Nope - the call xxx(%ryyy) is likely to be a data cache miss and a complete
cpu pipel
On Sat, Dec 9, 2017 at 12:22 AM, David Laight wrote:
> From: Xin Long
>> Sent: 08 December 2017 16:18
>>
> ...
>> >> Alternatively you could preform the dereference in two steps (i.e.
>> >> declare an si
>> >> pointer on the stack and set it equal to asoc->stream.si, then deref
>> >> si->make_dat
Hello!
On 12/08/2017 12:53 PM, Geert Uytterhoeven wrote:
On 12/04/2017 03:35 PM, Geert Uytterhoeven wrote:
From: Sergei Shtylyov
The PHY devices sometimes do have their reset signal (maybe even power
supply?) tied to some GPIO and sometimes it also does happen that a boot
loader does not leav
Group fitting fields into lines and space them equally using the
remaining screen width for each line. If columns don't fit on
one line, break them into the least possible amount of lines and
keep them aligned across lines.
This is done by:
- recording the length of the longest item in each colum
This is preparation work for output buffering, which will allow
us to use optimal spacing and alignment of logical "columns".
The new out() function is just a re-implementation of a typical
libc's printf(), except that the return value of vfprintf() is
ignored as no callers use it. This implementa
Currently, 'ss' simply subdivides the whole available screen width
between available columns, starting from a set of hardcoded amount
of spacing and growing column widths.
This makes the output unreadable in several cases, as it doesn't take
into account the actual content width.
Fix this by intr
Instead of embedding spacing directly while printing contents,
logically declare columns and functions to buffer their content,
to print left and right spacing around fields, to flush them to
screen, and to print headers.
This makes it a bit easier to handle layout changes and prepares
for full ou
This allows us to measure the maximum field length for each
column before printing fields and will permit us to apply
optimal field spacing and distribution. Structure of the output
buffer with chunked allocation is described in comments.
Output is still unchanged, original spacing is used.
Runni
After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
we still see the following WARN fire:
[ cut here ]
WARNING: CPU: 0 PID: 1875170 at net/core/netpoll.c:165
netpoll_poll_dev+0x15
> -Original Message-
> From: Michael Chan [mailto:michael.c...@broadcom.com]
> Sent: Thursday, December 07, 2017 1:34 PM
> To: da...@davemloft.net
> Cc: netdev@vger.kernel.org; andrew.gospoda...@broadcom.com; Elior, Ariel
> ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com>
> Subjec
On 12/8/17 8:39 AM, Quentin Monnet wrote:
> I don't believe compatibility is an issue here, since the program and
> its documentation come together (so they should stay in sync) and are
> part of the kernel tree (so the tool should be compatible with the
> kernel sources it comes with). My concern
On Fri, Dec 08, 2017 at 05:17:14PM +0100, Andrew Lunn wrote:
> Hi Russell
>
> > There is an open question whether there should be generic helpers for
> > this. Generic helpers would mean:
> >
> > - Additional couple of function pointers in phy_driver to read/write the
> > paging register. Thi
On Fri, Dec 08, 2017 at 05:26:43PM +0100, Andrew Lunn wrote:
> On Fri, Dec 08, 2017 at 04:04:59PM +, Russell King wrote:
> > XGMII is a 32-bit bus plus two clock signals per direction. XAUI is
> > four serial lanes per direction. The 88e6190 supports XAUI but not
> > XGMII as it doesn't have
On 12/07/2017 08:23 PM, Naresh Kamboju wrote:
> CONFIG_CGROUP_BPF=y is required for test_dev_cgroup test case.
>
> Signed-off-by: Naresh Kamboju
> ---
> tools/testing/selftests/net/config | 1 +
Did you mean to add this to tools/testing/selftests/bpf/config instead?
test_dev_cgroup is under bpf
From: Yafang Shao
Date: Fri, 8 Dec 2017 23:50:44 +0800
> 2017-12-08 23:42 GMT+08:00 David Miller :
>> From: Yafang Shao
>> Date: Fri, 8 Dec 2017 11:40:23 +0800
>>
>>> It will looks like these,
>>>
>>> if (sk->sk_protocol == IPPROTO_TCP)
>>> __tcp_set_state(newsk, TCP_SYN_RECV);
>>>
On Fri, Dec 08, 2017 at 04:04:59PM +, Russell King wrote:
> XGMII is a 32-bit bus plus two clock signals per direction. XAUI is
> four serial lanes per direction. The 88e6190 supports XAUI but not
> XGMII as it doesn't have enough pins. The same is true of 88e6176.
>
> Match on PHY_INTERFAC
On Sun, 2017-12-03 at 23:37 -0700, Subash Abhinov Kasiviswanathan
wrote:
> Add an option to configure the rmnet aggregation and command features
> on device creation. This is achieved by using the vlan flags option.
Does this overload the VLAN flags item with different meanings than
VLAN_FLAG_* th
From: Xin Long
> Sent: 08 December 2017 16:18
>
...
> >> Alternatively you could preform the dereference in two steps (i.e. declare
> >> an si
> >> pointer on the stack and set it equal to asoc->stream.si, then deref
> >> si->make_datafrag at call time. That will at least give the compiler an
>
1 - 100 of 263 matches
Mail list logo
