Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86

2017-11-08 Thread Yonghong Song
On 11/8/17 10:53 PM, Thomas Gleixner wrote: On Wed, 8 Nov 2017, Yonghong Song wrote: On 11/8/17 4:06 PM, David Miller wrote: From: Yonghong Song Date: Wed, 8 Nov 2017 13:37:12 -0800 Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First

[PATCH] qlge: remove duplicated assignment to mbcp

2017-11-08 Thread Colin King
From: Colin Ian King The assignment to mbcp is identical to the initiatialized value assigned to mbcp at declaration time a few lines earlier, hence we can remove the second redundant assignment. Cleans up clang warning: drivers/net/ethernet/qlogic/qlge/qlge_mpi.c:209:22: warning: Value stored

Re: [PATCH 23/31] nds32: Device tree support

2017-11-08 Thread Greentime Hu
2017-11-08 17:53 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Greentime Hu >> --- >> arch/nds32/boot/dts/Makefile |8 ++ >> arch/nds32/boot/dts/ae3xx.dts | 55 +

Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

2017-11-08 Thread Kamal Heib
On Wed, 2017-11-08 at 23:13 +0900, Or Gerlitz wrote: > On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed > wrote: > > From: Kamal Heib > > > > In the current code, if a size of zero is passed to > > mlx5_fpga_mem_{read|write}_i2c() functions the "err" > > Don't we need to fix the call site where z

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
On Thu, Nov 09, 2017 at 02:55:10PM +0800, Fengguang Wu wrote: On Wed, Nov 08, 2017 at 10:34:10PM -0800, Cong Wang wrote: On Wed, Nov 8, 2017 at 7:12 PM, Fengguang Wu wrote: Hi Alex, So looking over the trace the panic seems to be happening after a decnet interface is getting deleted. Is ther

Re: [PATCH 20/31] nds32: L2 cache support

2017-11-08 Thread Greentime Hu
2017-11-08 17:48 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Greentime Hu > >> + >> +/* This is defined for head.S to use due to device tree is not yet built. */ >> +#define L2CC_PA_BAS

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
sts in Zone order, mobility grouping on. Total pages: 81146 [0.00] Kernel command line: ip=vm-lkp-wsx03-openwrt-i386-18::dhcp root=/dev/ram0 user=lkp job=/lkp/scheduled/vm-lkp-wsx03-openwrt-i386-18/trinity-300s-openwrt-i386-2016-03-16.cgz-8d5e72dfdf0fa29a21143fd72746c6f43295ce9f-2017

Re: [PATCH 03/31] nds32: Support early_printk

2017-11-08 Thread Greentime Hu
2017-11-08 17:47 GMT+08:00 Tobias Klauser : > On 2017-11-08 at 06:54:51 +0100, Greentime Hu wrote: >> From: Greentime Hu >> >> Signed-off-by: Rick Chen >> Signed-off-by: Greentime Hu >> --- >> arch/nds32/kernel/early_printk.c | 124 >> ++ >> 1 file changed

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-08 Thread महेश बंडेवार
[resend response as earlier one failed because of formatting issues] On Thu, Nov 9, 2017 at 12:21 PM, Serge E. Hallyn wrote: > > On Thu, Nov 09, 2017 at 09:55:41AM +0900, Mahesh Bandewar (महेश बंडेवार) > wrote: > > On Thu, Nov 9, 2017 at 4:02 AM, Christian Brauner > > wrote: > > > On Wed, Nov 0

[PATCH linux-firmware 0/2] Mellanox: Add new mlxsw_spectrum firmware 13.1530.152

2017-11-08 Thread Shalom Toledo
This set adds a new firmware version 13.1530.152 as well as information about the previous firmware version of the mlxsw_spectrum driver Shalom Toledo (2): WHENCE: Add missing entry for mlxsw_spectrum firmware Mellanox: Add new mlxsw_spectrum firmware 13.1530.152 WHENCE

[PATCH linux-firmware 1/2] WHENCE: Add missing entry for mlxsw_spectrum firmware

2017-11-08 Thread Shalom Toledo
Fixes: a4c72696f5f4 ("Mellanox: Add firmware for mlxsw_spectrum") Signed-off-by: Shalom Toledo --- WHENCE | 37 + 1 file changed, 37 insertions(+) diff --git a/WHENCE b/WHENCE index b2dc6a1..2a6dde8 100644 --- a/WHENCE +++ b/WHENCE @@ -3684,3 +3684,40 @@ Licen

Re: [PATCH 13/31] nds32: DMA mapping API

2017-11-08 Thread Greentime Hu
2017-11-08 17:09 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > >> +static void consistent_sync(void *vaddr, size_t size, int direction) >> +{ >> + unsigned long start = (unsigned long)vaddr; >> + unsigned long end = start + size; >> + >> + swit

Re: [PATCH 12/31] nds32: Device specific operations

2017-11-08 Thread Greentime Hu
2017-11-08 17:04 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > >> + >> +#define ioremap(cookie,size) __ioremap(cookie,size,0,1) >> +#define ioremap_nocache(cookie,size) __ioremap(cookie,size,0,1) >> +#define iounmap(cookie)__i

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
On Wed, Nov 08, 2017 at 10:34:10PM -0800, Cong Wang wrote: On Wed, Nov 8, 2017 at 7:12 PM, Fengguang Wu wrote: Hi Alex, So looking over the trace the panic seems to be happening after a decnet interface is getting deleted. Is there any chance we could try compiling the kernel without decnet s

Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86

2017-11-08 Thread Thomas Gleixner
On Wed, 8 Nov 2017, Yonghong Song wrote: > On 11/8/17 4:06 PM, David Miller wrote: > > From: Yonghong Song > > Date: Wed, 8 Nov 2017 13:37:12 -0800 > > > > > Uprobe is a tracing mechanism for userspace programs. > > > Typical uprobe will incur overhead of two traps. > > > First trap is caused by

Re: [PATCH] net/tcp: introduce TRACE_EVENT for TCP/IPv4 state transition

2017-11-08 Thread Yafang Shao
2017-11-09 14:43 GMT+08:00 Alexei Starovoitov : > On Thu, Nov 09, 2017 at 02:01:38PM +0800, Yafang Shao wrote: >> With this newly introduced TRACE_EVENT, it will be very easy to minotor >> TCP/IPv4 state transition. >> >> A new TRACE_SYSTEM named tcp is added, in which we can trace other TCP >> eve

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
On Thu, Nov 09, 2017 at 10:43:08AM +0800, Fengguang Wu wrote: Of course, if it's bisectable, that would be great too. Yes, bisect is on the way. So far it's bisecting in the 4.12 commits. The bisect was unsuccessful due to an unrelated DRM_BOCHS oops in 4.11. Disabling the buggy driver, I man

Re: [PATCH] net/tcp: introduce TRACE_EVENT for TCP/IPv4 state transition

2017-11-08 Thread Alexei Starovoitov
On Thu, Nov 09, 2017 at 02:01:38PM +0800, Yafang Shao wrote: > With this newly introduced TRACE_EVENT, it will be very easy to minotor > TCP/IPv4 state transition. > > A new TRACE_SYSTEM named tcp is added, in which we can trace other TCP > event as well. > > Two helpers are added, > static inlin

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Cong Wang
On Wed, Nov 8, 2017 at 7:12 PM, Fengguang Wu wrote: > Hi Alex, > >> So looking over the trace the panic seems to be happening after a >> decnet interface is getting deleted. Is there any chance we could try >> compiling the kernel without decnet support to see if that is the >> source of these iss

[PATCH] net/tcp: introduce TRACE_EVENT for TCP/IPv4 state transition

2017-11-08 Thread Yafang Shao
With this newly introduced TRACE_EVENT, it will be very easy to minotor TCP/IPv4 state transition. A new TRACE_SYSTEM named tcp is added, in which we can trace other TCP event as well. Two helpers are added, static inline void __tcp_set_state(struct sock *sk, int state) static inline void __sk_st

Re: [PATCH] kallsyms: don't leak address when printing symbol

2017-11-08 Thread Tobin C. Harding
On Wed, Nov 08, 2017 at 10:35:55PM -0500, Steven Rostedt wrote: > On Thu, 9 Nov 2017 12:50:29 +1100 > "Tobin C. Harding" wrote: > > > Currently if a pointer is printed using %p[ssB] and the symbol is not > > found (kallsyms_lookup() fails) then we print the actual address. This > > leaks kernel

Re: Grant -> Reply To fmayrhoferfam...@gmail.com

2017-11-08 Thread The Mayrhofer's
-- Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims to our private email on: fmayrhoferfam...@gmail.com . We await your earliest response and God Bless you. Fr

[net-next v4 4/4] openvswitch: Add meter action support

2017-11-08 Thread Andy Zhou
Implements OVS kernel meter action support. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 3 +++ net/openvswitch/actions.c| 6 ++ net/openvswitch/datapath.h | 1 + net/openvswitch/flow_netlink.c | 6 ++ 4 files changed, 16 insertions(+) diff --git a/inc

[net-next v4 3/4] openvswitch: Add meter infrastructure

2017-11-08 Thread Andy Zhou
OVS kernel datapath so far does not support Openflow meter action. This is the first stab at adding kernel datapath meter support. This implementation supports only drop band type. Signed-off-by: Andy Zhou --- net/openvswitch/Makefile | 1 + net/openvswitch/datapath.c | 14 +- net/openvswit

[net-next v4 2/4] openvswitch: export get_dp() API.

2017-11-08 Thread Andy Zhou
Later patches will invoke get_dp() outside of datapath.c. Export it. Signed-off-by: Andy Zhou --- net/openvswitch/datapath.c | 29 - net/openvswitch/datapath.h | 31 +++ 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/net/o

[net-next v4 1/4] openvswitch: Add meter netlink definitions

2017-11-08 Thread Andy Zhou
Meter has its own netlink family. Define netlink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 51 1 file changed, 51 insertions(+) diff --git a/include/uapi/linux/

[net-next v3 0/4] Openvswitch meter action

2017-11-08 Thread Andy Zhou
This patch series is the first attempt to add openvswitch meter support. We have previously experimented with adding metering support in nftables. However 1) It was not clear how to expose a named nftables object cleanly, and 2) the logic that implements metering is quite small, < 100 lines of code

Re: Page allocator bottleneck

2017-11-08 Thread Jesper Dangaard Brouer
On Wed, 8 Nov 2017 09:35:47 + Mel Gorman wrote: > On Wed, Nov 08, 2017 at 02:42:04PM +0900, Tariq Toukan wrote: > > > > Hi all, > > > > > > > > After leaving this task for a while doing other tasks, I got back to it > > > > now > > > > and see that the good behavior I observed earlier was n

[net-next 5/8] net/mlx5e: Add 802.1ad VLAN filter steering rules

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman When a user chooses to use 802.1ad VLAN the proper steering rules will be added to the VLAN flow table (matching the specific S-tag VID). Due to current hardware limitation, when using 802.1ad, we must disable C-tag VLAN stripping on the RQs. Signed-off-by: Gal Pressman Revie

[pull request][net-next 0/8] Mellanox, mlx5 updates 2017-11-09

2017-11-08 Thread Saeed Mahameed
Hi Dave, This series introduces vlan offloads related improvements for mlx5 ethernet netdev driver Plus some trivial refactoring patches needed by this series, from Gal Pressman. For more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. -

[net-next 7/8] net/mlx5e: Add VLAN offloads statistics

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman The following counters are now exposed through ethtool -S: rx[i]_removed_vlan_packets (per channel) rx_removed_vlan_packets tx[i]_added_vlan_packets (per channel) tx_added_vlan_packets rx_removed_vlan_packets: The number of packets that had their outer VLAN header stripped to

[net-next 8/8] net/mlx5e: CHECKSUM_COMPLETE offload for VLAN/QinQ packets

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman When the VLAN tag is present in the packet buffer (i.e VLAN stripping disabled, QinQ) the driver will currently report CHECKSUM_UNNECESSARY. Instead of using CHECKSUM_COMPLETE offload for packets with first ethertype of IPv4/6, use it for packets with last ethertype of IPv4/6

[net-next 4/8] net/mlx5e: Declare bitmap using kernel macro

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman Replace explicit declaration of bitmap with DECLARE_BITMAP kernel macro. Signed-off-by: Gal Pressman Reviewed-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next 6/8] net/mlx5e: Add 802.1ad VLAN insertion support

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman Report VLAN insertion support for S-tagged packets and add support by choosing the correct VLAN type in the WQE. Signed-off-by: Gal Pressman Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 + drivers/net/eth

[net-next 3/8] net: Introduce netdev_*_once functions

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman Extend the net device error logging with netdev_*_once macros. netdev_*_once are the equivalents of the dev_*_once macros which are useful for messages that should only be logged once. Also add netdev_WARN_ONCE, which is the "once" extension for the already existing netdev_WAR

[net-next 2/8] net/mlx5e: Add rollback on add VLAN failure

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman When add VLAN rule fails the active vlan bit should be cleared. Fixes: afb736e9330a ("net/mlx5: Ethernet resource handling files") Signed-off-by: Gal Pressman Reviewed-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 7 +

[net-next 1/8] net/mlx5e: Rename VLAN related variables and functions

2017-11-08 Thread Saeed Mahameed
From: Gal Pressman Rename VLAN related symbols to better reflect the fact that they are associated to C-tag VLAN. Signed-off-by: Gal Pressman Reviewed-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 10 ++-- drivers/net/ethernet/mellano

[PATCH v2 0/8] scripts/leaking_addresses: add summary reporting

2017-11-08 Thread Tobin C. Harding
This series adds summary reporting to the script. First we do some clean up. Then we implement changes that were first posted as [PATCH v4] scripts: add leaking_addresses.pl Additionally; files (and paths) to skip is amended, thanks to Michael Ellerman and Kees Cook. Support for scanning PowerPC

[PATCH v2 2/8] scripts/leaking_addresses: remove dead code

2017-11-08 Thread Tobin C. Harding
debug_arrays is not called. Also, %seen hash is not used. We should remove unused code. Remove dead code. Signed-off-by: Tobin C. Harding --- scripts/leaking_addresses.pl | 9 - 1 file changed, 9 deletions(-) diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl inde

[PATCH v2 1/8] scripts/leaking_addresses: use tabs not spaces

2017-11-08 Thread Tobin C. Harding
Current code uses spaces instead of tabs in places. Use tabs instead of spaces. Signed-off-by: Tobin C. Harding --- scripts/leaking_addresses.pl | 54 ++-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/scripts/leaking_addresses.pl b/scri

[PATCH v2 5/8] scripts/leaking_addresses: add to exclude files/paths

2017-11-08 Thread Tobin C. Harding
There are a couple more files that cause the script to stall. /sys/firmware/devicetree and its symlink /proc/device-tree, reported by Michael Ellerman. usbmon should be skipped were ever it appears. Reported by Kees Cook Add files to be excluded from parsing. Signed-off-by: Tobin C. Harding --

[PATCH v2 7/8] scripts/leaking_addresses: add support for ppc64

2017-11-08 Thread Tobin C. Harding
Currently script is targeted at x86_64. We can support other architectures by using the correct regular expressions for each architecture. Add the infrastructure to support multiple architectures. Add support for ppc64. Signed-off-by: Tobin C. Harding --- scripts/leaking_addresses.pl | 66 +

[PATCH v2 4/8] scripts/leaking_addresses: fix comment typo

2017-11-08 Thread Tobin C. Harding
Fix typo in comment string. Signed-off-by: Tobin C. Harding --- scripts/leaking_addresses.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 719ed0aaede7..3f8c6e230962 100755 --- a/scripts/leaking_addresses.pl

[PATCH v2 3/8] scripts/leaking_addresses: remove command line options

2017-11-08 Thread Tobin C. Harding
Currently script accepts files to skip. This was added to make running the script faster (for repeat runs). We can remove this functionality in preparation for adding sub commands (scan and format) to the script. Remove command line options. Signed-off-by: Tobin C. Harding --- scripts/leaking_a

[PATCH v2 8/8] scripts/leaking_addresses: add timeout on file read

2017-11-08 Thread Tobin C. Harding
Currently script can stall if we read certain files (like /proc/kmsg). While we have a mechanism to skip these files once they are discovered it would be nice to not stall on as yet undiscovered files of this kind. Set a timer before each file is parsed, warn user if timer expires. Suggested-by:

[PATCH v2 6/8] scripts/leaking_addresses: add summary reporting

2017-11-08 Thread Tobin C. Harding
Currently script just dumps all results found. Potentially, this risks losing single results among multiple duplicate results. We need some way of restricting duplicates to assist users of the script. It would also be nice if we got a report instead of raw results. Duplicates can be defined in var

[GIT] Networking

2017-11-08 Thread David Miller
1) Fix use-after-free in IPSEC input parsing, desintation address pointer was loaded before pskb_may_pull() which can change the SKB data pointers. From Florian Westphal. 2) Stack out-of-bounds read in xfrm_state_find(), from Steffen Klassert. 3) IPVS state of SKB is not properly reset

Re: Page allocator bottleneck

2017-11-08 Thread Tariq Toukan
On 08/11/2017 6:35 PM, Mel Gorman wrote: On Wed, Nov 08, 2017 at 02:42:04PM +0900, Tariq Toukan wrote: Hi all, After leaving this task for a while doing other tasks, I got back to it now and see that the good behavior I observed earlier was not stable. Recall: I work with a modified driver t

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Kaiwan N Billimoria
On Thu, Nov 9, 2017 at 10:13 AM, Kaiwan N Billimoria wrote: >> But I don't know if there is anything else than the profiling code >> that _really_ wants access to /proc/kallsyms in user space as a >> regular user. > Front-ends to ftrace, like trace-cmd? [from the trace-cmd git repo (Steve Rostedt

[PATCH] net: wan: x25_asy: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114928 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wan/x25_asy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Kaiwan N Billimoria
> But I don't know if there is anything else than the profiling code > that _really_ wants access to /proc/kallsyms in user space as a > regular user. Am unsure about this, but kprobes? (/jprobes/kretprobes), and by extension, wrappers over this infra (like SystemTap)? I (hazily) recollect a scrip

Re: [PATCH] kallsyms: don't leak address when printing symbol

2017-11-08 Thread Sergey Senozhatsky
On (11/08/17 22:35), Steven Rostedt wrote: > On Thu, 9 Nov 2017 12:50:29 +1100 > "Tobin C. Harding" wrote: > > > Currently if a pointer is printed using %p[ssB] and the symbol is not > > found (kallsyms_lookup() fails) then we print the actual address. This > > leaks kernel addresses. We should

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
On Thu, Nov 09, 2017 at 11:12:06AM +0800, Fengguang Wu wrote: Hi Alex, So looking over the trace the panic seems to be happening after a decnet interface is getting deleted. Is there any chance we could try compiling the kernel without decnet support to see if that is the source of these issues

[PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-08 Thread Jason A. Donenfeld
The way people generally use netlink_dump is that they fill in the skb as much as possible, breaking when nla_put returns an error. Then, they get called again and start filling out the next skb, and again, and so forth. The mechanism at work here is the ability for the iterative dumping function t

[PATCH] net: 3com: 3c574_cs: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114888 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/3com/3c574_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/3com/3c5

[PATCH] net: 8390: pcnet_cs: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114891 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/8390/pcnet_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/8390/pcn

[PATCH] net: decnet: dn_table: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115106 Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_table.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/decnet/dn_table.c b/net/decnet/dn_table.

Re: [PATCH] kallsyms: don't leak address when printing symbol

2017-11-08 Thread Steven Rostedt
On Thu, 9 Nov 2017 12:50:29 +1100 "Tobin C. Harding" wrote: > Currently if a pointer is printed using %p[ssB] and the symbol is not > found (kallsyms_lookup() fails) then we print the actual address. This > leaks kernel addresses. We should instead print something _safe_. > > Print "" instead o

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

2017-11-08 Thread Andrew Lunn
On Thu, Nov 09, 2017 at 10:02:37AM +0800, lipeng (Y) wrote: > > > On 2017/11/8 22:30, Andrew Lunn wrote: > >On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: > >>From: Fuyun Liang > >> > >>Driver gets phy address from NCL_config file and uses the phy address > >>to initialize phydev. There

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-08 Thread Serge E. Hallyn
On Thu, Nov 09, 2017 at 09:55:41AM +0900, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Nov 9, 2017 at 4:02 AM, Christian Brauner > wrote: > > On Wed, Nov 08, 2017 at 03:09:59AM -0800, Mahesh Bandewar (महेश बंडेवार) > > wrote: > >> Sorry folks I was traveling and seems like lot happened on this

Re: [PATCH v3] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-08 Thread Jason A. Donenfeld
On Thu, Nov 9, 2017 at 11:02 AM, Johannes Berg wrote: > nit: I think your line got a little long here :) Ack. For v4. > and here Ack. For v4. > >> + nlk->dump_done_errno = INT_MAX; > > I guess positive values aren't really returned from dump? When a positive value is returned, the API use

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-08 Thread David Miller
From: David Miller Date: Thu, 09 Nov 2017 11:30:32 +0900 (KST) > Series applied, with the spurious whitespace change removed from patch > #5. Actually I had to revert, this doesn't build: net/dsa/slave.c: In function ‘dsa_slave_port_obj_add’: net/dsa/slave.c:311:26: warning: passing argument 1

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Fengguang Wu
Of course, if it's bisectable, that would be great too. Yes, bisect is on the way. So far it's bisecting in the 4.12 commits. The bisect was unsuccessful due to an unrelated DRM_BOCHS oops in 4.11. Disabling the buggy driver, I managed to reproduce the vlan_device_event bug in 4.11. However on

Re: [Patch net 00/13] net_sched: close the race between call_rcu() and cleanup_net()

2017-11-08 Thread Cong Wang
On Wed, Nov 8, 2017 at 6:26 PM, David Miller wrote: > From: Cong Wang > Date: Mon, 6 Nov 2017 13:47:17 -0800 > >> This patchset tries to fix the race between call_rcu() and >> cleanup_net() again. Without holding the netns refcnt the >> tc_action_net_exit() in netns workqueue could be called bef

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-08 Thread David Miller
From: Andrew Lunn Date: Tue, 7 Nov 2017 00:26:53 +0100 > The linux bridge supports IGMP snooping. It will listen to IGMP > reports on bridge ports and keep track of which groups have been > joined on an interface. It will then forward multicast based on this > group membership. > > When the bri

Re: [Patch net 00/13] net_sched: close the race between call_rcu() and cleanup_net()

2017-11-08 Thread David Miller
From: Cong Wang Date: Mon, 6 Nov 2017 13:47:17 -0800 > This patchset tries to fix the race between call_rcu() and > cleanup_net() again. Without holding the netns refcnt the > tc_action_net_exit() in netns workqueue could be called before > filter destroy works in tc filter workqueue. This patc

Re: pull request (net): ipsec 2017-11-09

2017-11-08 Thread David Miller
From: Steffen Klassert Date: Thu, 9 Nov 2017 02:40:44 +0100 > 1) Fix a use after free due to a reallocated skb head. >From Florian Westphal. > > 2) Fix sporadic lookup failures on labeled IPSEC. >From Florian Westphal. > > 3) Fix a stack out of bounds when a socket policy is applied >

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Tobin C. Harding
On Thu, Nov 09, 2017 at 11:49:52AM +1100, Michael Ellerman wrote: > "Tobin C. Harding" writes: > > > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: > >> "Tobin C. Harding" writes: > > [snip] > > > > Hi Michael, > > > > I'm working an adding support for ppc64 to leaking_address

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

2017-11-08 Thread lipeng (Y)
On 2017/11/8 22:30, Andrew Lunn wrote: On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5 bits. So 0-31 are all valid

Re: [PATCH v3] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-08 Thread Johannes Berg
On Thu, 2017-11-09 at 10:42 +0900, Jason A. Donenfeld wrote: > +++ b/net/netlink/af_netlink.c > @@ -2136,7 +2136,7 @@ static int netlink_dump(struct sock *sk) > struct sk_buff *skb = NULL; > struct nlmsghdr *nlh; > struct module *module; > - int len, err = -ENOBUFS; > + in

[PATCH] kallsyms: don't leak address when printing symbol

2017-11-08 Thread Tobin C. Harding
Currently if a pointer is printed using %p[ssB] and the symbol is not found (kallsyms_lookup() fails) then we print the actual address. This leaks kernel addresses. We should instead print something _safe_. Print "" instead of kernel address. Signed-off-by: Tobin C. Harding --- kernel/kallsyms.

[PATCH v3] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-08 Thread Jason A. Donenfeld
The way people generally use netlink_dump is that they fill in the skb as much as possible, breaking when nla_put returns an error. Then, they get called again and start filling out the next skb, and again, and so forth. The mechanism at work here is the ability for the iterative dumping function t

[PATCH 3/3] xfrm: Fix stack-out-of-bounds read in xfrm_state_find.

2017-11-08 Thread Steffen Klassert
When we do tunnel or beet mode, we pass saddr and daddr from the template to xfrm_state_find(), this is ok. On transport mode, we pass the addresses from the flowi, assuming that the IP addresses (and address family) don't change during transformation. This assumption is wrong in the IPv4 mapped IP

[PATCH 1/3] xfrm: defer daddr pointer assignment after spi parsing

2017-11-08 Thread Steffen Klassert
From: Florian Westphal syzbot reports: BUG: KASAN: use-after-free in __xfrm_state_lookup+0x695/0x6b0 Read of size 4 at addr 8801d434e538 by task syzkaller647520/2991 [..] __xfrm_state_lookup+0x695/0x6b0 net/xfrm/xfrm_state.c:833 xfrm_state_lookup+0x8a/0x160 net/xfrm/xfrm_state.c:1592 xfrm_inp

pull request (net): ipsec 2017-11-09

2017-11-08 Thread Steffen Klassert
1) Fix a use after free due to a reallocated skb head. From Florian Westphal. 2) Fix sporadic lookup failures on labeled IPSEC. From Florian Westphal. 3) Fix a stack out of bounds when a socket policy is applied to an IPv6 socket that sends IPv4 packets. Please pull or let me know if th

[PATCH 2/3] xfrm: do unconditional template resolution before pcpu cache check

2017-11-08 Thread Steffen Klassert
From: Florian Westphal Stephen Smalley says: Since 4.14-rc1, the selinux-testsuite has been encountering sporadic failures during testing of labeled IPSEC. git bisect pointed to commit ec30d ("xfrm: add xdst pcpu cache"). The xdst pcpu cache is only checking that the policies are the same, b

Re: [PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

2017-11-08 Thread Jesper Dangaard Brouer
On Wed, 08 Nov 2017 10:40:24 +0900 (KST) David Miller wrote: > From: Christina Jacob > Date: Sun, 5 Nov 2017 08:52:30 +0530 > > > From: Christina Jacob > > > > Implements port to port forwarding with route table and arp table > > lookup for ipv4 packets using bpf_redirect helper function and

RE: [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

2017-11-08 Thread Keller, Jacob E
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, November 08, 2017 4:32 PM > To: Keller, Jacob E > Cc: Brandeburg, Jesse ; netdev@vger.kernel.org; > intel-wired-...@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATC

Re: [PATCH 17/31] nds32: Signal handling support

2017-11-08 Thread Al Viro
On Wed, Nov 08, 2017 at 01:55:05PM +0800, Greentime Hu wrote: > +static int restore_sigframe(struct pt_regs *regs, > + struct rt_sigframe __user * sf) > +{ [snip] > + err |= !valid_user_regs(regs); IDGI... Where do you modify ->ipsw at all and how can valid_user_reg

Re: [PATCH 5/7] scripts/leaking_addresses: add emailing results

2017-11-08 Thread Tobin C. Harding
On Wed, Nov 08, 2017 at 12:51:20PM +0100, Greg KH wrote: > On Wed, Nov 08, 2017 at 11:16:43AM +0100, Petr Mladek wrote: > > On Wed 2017-11-08 14:37:37, Tobin C. Harding wrote: > > > Developers may not have the time (or inclination) to investigate script > > > output. This information is, however, u

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-08 Thread महेश बंडेवार
On Thu, Nov 9, 2017 at 4:02 AM, Christian Brauner wrote: > On Wed, Nov 08, 2017 at 03:09:59AM -0800, Mahesh Bandewar (महेश बंडेवार) > wrote: >> Sorry folks I was traveling and seems like lot happened on this thread. :p >> >> I will try to response few of these comments selectively - >> >> > The t

[PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-08 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first six patches add the SoC support needed by the

Re: [PATCH 4/7] scripts/leaking_addresses: add reporting

2017-11-08 Thread Tobin C. Harding
On Wed, Nov 08, 2017 at 11:42:21AM +0100, Petr Mladek wrote: > On Wed 2017-11-08 14:37:36, Tobin C. Harding wrote: > > Currently script just dumps all results found. Potentially, this risks > > loosing single results among multiple duplicate results. We need some > > way of restricting duplicates t

[PATCH x86 v2] uprobe: emulate push insns for uprobe on x86

2017-11-08 Thread Yonghong Song
Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced insn in user space. To reduce the overhead, kernel provides hooks for architectures to emulate

[PATCH v2 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-08 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insertions(+) create mode 10

[PATCH v2 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-08 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH v2 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-08 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions addit

[PATCH v2 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-08 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25 - drivers

[PATCH v2 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-08 Thread David Daney
From: Carlos Munoz >From the hardware user manual: "The FPA is a unit that maintains pools of pointers to free L2/DRAM memory. To provide QoS, the pools are referenced indirectly through 1024 auras. Both core software and hardware units allocate and free pointers." Signed-off-by: Carlos Munoz S

[PATCH v2 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-08 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc/ho

[PATCH v2 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-08 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data to the I/O device and

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Michael Ellerman
"Tobin C. Harding" writes: > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: >> "Tobin C. Harding" writes: > [snip] > > Hi Michael, > > I'm working an adding support for ppc64 to leaking_addresses.pl, I've > added the kernel address regular expression that you suggested. Thank

Re: [PATCH v2 iproute2] libnetlink: Handle extack messages for non-error case

2017-11-08 Thread Stephen Hemminger
On Tue, 7 Nov 2017 20:05:18 -0800 David Ahern wrote: > Kernel can now return non-fatal error messages in extack facility. > Update iproute2 to dump to use if present. > - rename nl_dump_ext_err to nl_dump_ext_ack > - rename errmsg to msg > - add call to nl_dump_ext_ack in rtnl_dump_done and __rt

Re: [PATCH 18/31] nds32: Library functions

2017-11-08 Thread Al Viro
On Wed, Nov 08, 2017 at 01:55:06PM +0800, Greentime Hu wrote: > +#define __range_ok(addr, size) (size <= get_fs() && addr <= (get_fs() -size)) > + > +#define access_ok(type, addr, size) \ > + __range_ok((unsigned long)addr, (unsigned long)size) > +#define __get_user_x(__r2,__p

Urgent response !!!

2017-11-08 Thread Melisa Mehmet
Greetings, I have a business proposal I would love to discuss with you. please reply me for more details Yours Sincerely, miss.melisa.mehmet

Re: [PATCHv2 net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

2017-11-08 Thread Florian Westphal
William Tu wrote: Not related to your patch specifically but: > +static int prepare_ip6gre_xmit_ipv6(struct sk_buff *skb, > + struct net_device *dev, > + struct flowi6 *fl6, __u8 *dsfield, > + int *en

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

2017-11-08 Thread Alexander Duyck
On Wed, Nov 8, 2017 at 4:21 PM, Keller, Jacob E wrote: > > >> -Original Message- >> From: Alexander Duyck [mailto:alexander.du...@gmail.com] >> Sent: Wednesday, November 08, 2017 3:04 PM >> To: Keller, Jacob E >> Cc: Brandeburg, Jesse ; netdev@vger.kernel.org; >> intel-wired-...@lists.osu

Re: [PATCH net-next 00/11] net: dsa: setup stage

2017-11-08 Thread David Miller
From: Vivien Didelot Date: Mon, 6 Nov 2017 16:11:42 -0500 > When probing a DSA switch, there is basically two stages. > > The first stage is the parsing of the switch device, from either device > tree or platform data. It fetches the DSA tree to which it belongs, and > validates its ports. The

RE: [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

2017-11-08 Thread Keller, Jacob E
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, November 08, 2017 3:04 PM > To: Keller, Jacob E > Cc: Brandeburg, Jesse ; netdev@vger.kernel.org; > intel-wired-...@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PA

[PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work()

2017-11-08 Thread Byungchul Park
I am sorry for having made a mistake on it. -8<- >From ba9a0f76dffceffa4fa3aa2d9be49cdb0d9b7d4f Mon Sep 17 00:00:00 2001 From: Byungchul Park Date: Thu, 9 Nov 2017 09:00:21 +0900 Subject: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work() The following patch change

  1   2   3   4   >