On 21/10/2017 13.02, Alexey Dobriyan wrote:
Add sparse-checked slab_flags_t for struct kmem_cache::flags
(SLAB_POISON, etc).
SLAB is bloated temporarily by switching to "unsigned long",
but only temporarily.
Signed-off-by: Alexey Dobriyan
Acked-by: Pekka Enberg
On 21/10/2017 13.06, Alexey Dobriyan wrote:
struct kmem_cache::flags is "unsigned long" which is unnecessary on
64-bit as no flags are defined in the higher bits.
Switch the field to 32-bit and save some space on x86_64 until such
flags appear:
add/remove: 0/0 grow/shrink: 0/107 up/do
On Sun, 2017-10-22 at 13:10 +0900, Koichiro Den wrote:
> On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote:
> > On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote:
> > > When retransmission on TSQ handler was introduced in the commit
> > > f9616c35a0d7 ("tcp: implement TSQ for retransmits"),
When retransmission on TSQ handler was introduced in the commit
f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted
skbs' timestamps were updated on the actual transmission. In the later
commit 385e20706fac ("tcp: use tp->tcp_mstamp in output path"), it stops
being done so. In th
On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote:
> On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote:
> > When retransmission on TSQ handler was introduced in the commit
> > f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted
> > skbs' timestamps were updated on the act
On Fri, 2017-10-20 at 10:37 +, Reshetova, Elena wrote:
> > On Fri, 2017-10-20 at 10:23 +0300, Elena Reshetova wrote:
> > > atomic_t variables are currently used to implement reference
> > > counters with the following properties:
> > > - counter is initialized to 1 using atomic_set()
> > > -
On Sun, 2017-10-22 at 12:38 +0900, Koichiro Den wrote:
> When retransmission on TSQ handler was introduced in the commit
> f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted
> skbs' timestamps were updated on the actual transmission. In the later
> commit 385e20706fac ("tcp: use
On Sat, 2017-10-21 at 20:52 -0700, Eric Dumazet wrote:
> Very nice catch, thanks a lot Koichiro.
>
> This IMO would target net tree, since it is a bug fix.
>
> Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path")
Reviewed-by: Eric Dumazet
When retransmission on TSQ handler was introduced in the commit
f9616c35a0d7 ("tcp: implement TSQ for retransmits"), the retransmitted
skbs' timestamps were updated on the actual transmission. In the later
commit 385e20706fac ("tcp: use tp->tcp_mstamp in output path"), it stops
being done so. In th
A little more than usual this time around. Been travelling, so that is
part of it.
Anyways, here are the highlights:
1) Deal with memcontrol races wrt. listener dismantle, from Eric
Dumazet.
2) Handle page allocation failures properly in nfp driver, from
Jaku Kicinski.
3) Fix memory lea
From: Bernd Edlinger
Date: Sat, 21 Oct 2017 06:51:30 +
> This is the possible reason for different hard to reproduce
> problems on my ARMv7-SMP test system.
>
> The symptoms are in recent kernels imprecise external aborts,
> and in older kernels various kinds of network stalls and
> unexpect
From: Eric Dumazet
Date: Sat, 21 Oct 2017 12:26:23 -0700
> From: Eric Dumazet
>
> When syzkaller team brought us a C repro for the crash [1] that
> had been reported many times in the past, I finally could find
> the root cause.
>
> If FlowLabel info is merged by fl6_merge_options(), we leave
From: Florian Fainelli
Date: Sat, 21 Oct 2017 19:01:45 -0700
> Reviewed-by : Florian Fainelli
>
> I still can't make sure this is not a problem for multiple PHYs
> hanging off the same bus, but like anything else, we'll deal with
> problems later if they arise.
Thanks Florian.
Applied, thanks
From: "Gustavo A. R. Silva"
Date: Sat, 21 Oct 2017 20:21:00 -0500
>
> Quoting David Miller :
>
>> From: "Gustavo A. R. Silva"
>> Date: Thu, 19 Oct 2017 17:02:44 -0500
>>
>>> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct
>>> work_struct *work)
>>> case SMC_PEERCLOSEWAIT1:
>>
From: John Allen
Date: Fri, 20 Oct 2017 16:00:54 -0500
> This series implements support for changing tunable parameters such as the
> mtu, number of tx/rx queues, and number of buffers per queue via ethtool
> and ifconfig.
These patches do not apply to net-next.
From: Randy Dunlap
Date: Fri, 20 Oct 2017 12:15:52 -0700
> From: Randy Dunlap
>
> Fix spellos (typos) in textsearch library helpers.
>
> Signed-off-by: Randy Dunlap
Applied.
From: Eric Dumazet
Date: Fri, 20 Oct 2017 11:29:54 -0700
> While working on a syzkaller issue that might have been
> fixed already by Cong Wang in commit 0ad646c81b21
> ("tun: call dev_get_valid_name() before register_netdevice()")
> I made three small changes related to flow_gc_timer.
Series ap
From: Lawrence Brakmo
Date: Fri, 20 Oct 2017 11:05:38 -0700
> This patch set adds the following functionality to socket_ops BPF
> programs.
> 1) Add bpf helper function bpf_getsocketops. Currently only supports
>TCP_CONGESTION
> 2) Add BPF_SOCKET_OPS_BASE_RTT op to get the base RTT of the
>
From: "Gustavo A. R. Silva"
Date: Fri, 20 Oct 2017 12:05:30 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
From: "Gustavo A. R. Silva"
Date: Fri, 20 Oct 2017 12:37:52 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
From: Simon Horman
Date: Fri, 20 Oct 2017 19:49:52 +0200
> From: Pieter Jansen van Vuuren
>
> Use direct access struct fields rather than PREP_FIELD()
> macros to manipulate the jump ID and length, both of which
> are exactly 8-bits wide. This simplifies the code somewhat.
>
> Signed-off-by: S
From: "Gustavo A. R. Silva"
Date: Fri, 20 Oct 2017 12:01:26 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
This doesn't apply to net-next.
On October 21, 2017 6:37:38 PM PDT, David Miller wrote:
>
>Second ping, this patch needs a review ASAP.
>
>Geert's hard-resetting PHY changes depend upon this change.
Done, same concerns as before and we could all improve on trying to get this
tested on a pure SW model (e.g QEMU) but there is on
From: David Howells
Date: Fri, 20 Oct 2017 17:01:22 +0100
> Don't release call mutex at the end of rxrpc_kernel_begin_call() if the
> call pointer actually holds an error value.
>
> Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and
> sendmsg/recvmsg")
> Reported-by: Marc Dionn
From: Jose Abreu
Date: Fri, 20 Oct 2017 14:37:33 +0100
> Three fixes for HW timestamping feature, all of them for RX side.
Series applied to 'net', thanks.
On October 18, 2017 4:54:03 AM PDT, Geert Uytterhoeven
wrote:
>If an Ethernet PHY is initialized before the interrupt controller it is
>connected to, a message like the following is printed:
>
>irq: no irq domain found for /interrupt-controller@e61c !
>
>However, the actual error is ignor
I have uploaded the VM core dump [1]. And I don’t know if these logs are
helpful in the case of
failing to get the C reproducer currently.
[1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz
2017/10/21 20:24:32 reproducing crash 'unable to handle kernel paging request
From: Stefano Brivio
Date: Fri, 20 Oct 2017 13:31:36 +0200
> No need to re-invent memchr_inv() with !is_all_zero(). While at
> it, replace conditional and return clauses with a single return
> clause in is_tnl_info_zero().
>
> Signed-off-by: Stefano Brivio
Applied.
From: Egil Hjelmeland
Date: Fri, 20 Oct 2017 12:19:08 +0200
> This series add support for accessing and managing the lan9303 ALR
> (Address Logic Resolution).
>
> The first patch add low level functions for accessing the ALR, along
> with port_fast_age and port_fdb_dump methods.
>
> The secon
From: Jon Maloy
Date: Fri, 20 Oct 2017 11:21:32 +0200
> The function tipc_sk_timeout() is more complex than necessary, and
> even seems to contain an undetected bug. At one of the occurences
> where we renew the timer we just order it with (HZ / 20), instead
> of (jiffies + HZ / 20);
>
> In this
Second ping, this patch needs a review ASAP.
Geert's hard-resetting PHY changes depend upon this change.
Thank you.
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva
---
Changes in v2:
Mov
From: Elena Reshetova
Date: Fri, 20 Oct 2017 10:23:34 +0300
> Note: these are the last patches related to networking that perform
> conversion of refcounters from atomic_t to refcount_t.
> In contrast to the core network refcounter conversions that
> were merged earlier, these are much more strai
Quoting David Miller :
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 17:02:44 -0500
@@ -360,7 +360,8 @@ static void smc_close_passive_work(struct
work_struct *work)
case SMC_PEERCLOSEWAIT1:
if (rxflags->peer_done_writing)
sk->sk_state =
From: Jiri Pirko
Date: Fri, 20 Oct 2017 09:16:14 +0200
> From: Jiri Pirko
>
> Petr says:
>
> Currently mlxsw only offloads tunnels that are configured with TTL of
> "inherit"
> (which is the default). However, Spectrum defaults to 255 and the driver
> neglects to change the configuration. Thu
From: Yunsheng Lin
Date: Fri, 20 Oct 2017 10:19:20 +0800
> This patchset refactors the skb receiving and transmitting function
> before adding mac loopback selftest support in hns3 driver.
Series applied.
From: Niklas Söderlund
Date: Fri, 20 Oct 2017 01:32:08 +0200
> Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> restores the transceiver type to struct ethtool_link_settings and
> convert_link_ksettings_to_legacy_settings() but forgets to remove the
> error check for the same
From: Alexander Duyck
This patch updates the i40e driver to include programming descriptors in
the cleaned_count. Without this change it becomes possible for us to leak
memory as we don't trigger a large enough allocation when the time comes to
allocate new buffers and we end up overwriting a num
From: Jakub Kicinski
Date: Thu, 19 Oct 2017 15:46:18 -0700
> Quentin says:
>
> The first seven patches of this series bring several minor fixes to
> bpftool. Please see individual commit logs for details.
>
> Last patch adds a "version" commands to bpftool, which is in fact the
> version of the
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 17:02:44 -0500
> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct
> *work)
> case SMC_PEERCLOSEWAIT1:
> if (rxflags->peer_done_writing)
> sk->sk_state = SMC_PEERCLOSEWAIT2;
> -
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 16:28:24 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
From: Craig Gallek
Date: Thu, 19 Oct 2017 15:00:29 -0400
> From: Craig Gallek
>
> Syzkaller stumbled upon a way to trigger
> WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41
> reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39
>
> There are two initialization paths for the sock
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 12:55:03 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I placed a "fall through" comment on
> its own line, which is what GCC is exp
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 13:03:51 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
From: "Gustavo A. R. Silva"
Date: Thu, 19 Oct 2017 12:43:08 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied to net-next.
From: Willem de Bruijn
Date: Thu, 19 Oct 2017 12:40:39 -0400
> From: Willem de Bruijn
>
> Syzkaller hits WARN_ON(sk->sk_wmem_queued) in sk_stream_kill_queues
> after triggering an EFAULT in __zerocopy_sg_from_iter.
>
> On this error, skb_zerocopy_stream_iter resets the skb to its state
> befor
From: Nikolay Aleksandrov
Date: Thu, 19 Oct 2017 20:17:32 +0300
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metada
From: Alexander Duyck
This reverts commit 11f29003d6376fb123b7c3779dba49bb56fb0815.
I am reverting this as I am fairly certain this can result in a memory leak
when combined with the current page recycling scheme. Specifically we end
up attempting to allocate fewer buffers than we recycled and t
From: Nikolay Aleksandrov
Date: Thu, 19 Oct 2017 19:10:11 +0300
> Self-NAK
> Dave, please ignore this set and apologies for the noise.
OK
From: Daniel Borkmann
Date: Sat, 21 Oct 2017 02:34:20 +0200
> The set contains two fixes for direct packet access range
> markings and test cases for all direct packet access patterns
> that the verifier matches on.
>
> They are targeted for net tree, note that once net gets merged
> into net-ne
From: John Fastabend
Date: Thu, 19 Oct 2017 09:03:52 -0700
> An integer overflow is possible in dev_map_bitmap_size() when
> calculating the BITS_TO_LONG logic which becomes, after macro
> replacement,
>
> (((n) + (d) - 1)/ (d))
>
> where 'n' is a __u32 and 'd' is (8 * sizeof(long)). To a
Any comment on this one? I have been using this in my tree since submission. No
issues to far.
I guess I could also put a Fixes-tag?
- Tobias
Tobias Jakobi wrote:
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with ge
On Fri, Oct 20, 2017 at 11:05:41AM -0700, Lawrence Brakmo wrote:
> TCP_NV will try to get the base RTT from a socket_ops BPF program if one
> is loaded. NV will then use the base RTT to bound its min RTT (its
> notion of the base RTT). It uses the base RTT as an upper bound and 80%
> of the base RT
From: Eric Dumazet
When syzkaller team brought us a C repro for the crash [1] that
had been reported many times in the past, I finally could find
the root cause.
If FlowLabel info is merged by fl6_merge_options(), we leave
part of the opt_space storage provided by udp/raw/l2tp with random value
On 10/20/2017 05:34 PM, Daniel Borkmann wrote:
> Alexander had a test program with direct packet access, where
> the access test was in the form of data + X > data_end. In an
> unrelated change to the program LLVM decided to swap the branches
> and emitted code for the test in form of data + X <= d
On 10/20/2017 05:34 PM, Daniel Borkmann wrote:
> Lets add test cases to cover really all possible direct packet
> access tests for good/bad access cases so we keep tracking them.
>
> Signed-off-by: Daniel Borkmann
> Acked-by: Alexei Starovoitov
> ---
Acked-by: John Fastabend
On 10/20/2017 05:34 PM, Daniel Borkmann wrote:
> During review I noticed that the current logic for direct packet
> access marking in check_cond_jmp_op() has an off by one for the
> upper right range border when marking in find_good_pkt_pointers()
> with BPF_JLT and BPF_JLE. It's not really harmful
Hello,
On Wed, Oct 18, 2017 at 04:45:08PM -0500, Dennis Zhou wrote:
> I'm not sure I see the reason we can't match the minimum allocation size
> with the unit size? It seems weird to arbitrate the maximum allocation
> size given a lower bound on the unit size.
idk, it can be weird for the maximum
> On Thu, Oct 19, 2017 at 4:21 PM, Yuval Mintz
> wrote:
> >> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config
> parameter
> >> get/set operations
> >>
> >> Add support for permanent config parameter get/set commands. Used
> >> for parameters held in NVRAM, persistent device configura
> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote:
> > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote:
> >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote:
> >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote:
> > Adding DEVLINK_PERM_CONFIG_MSIX_VEC
From: Igor Russkikh
Date: Thu, 19 Oct 2017 18:23:52 +0300
> This patchset fixes various issues in driver,
> improves parameters for better performance on 10Gbit link
Series applied.
From: Steve Lin
Date: Thu, 19 Oct 2017 10:45:56 -0400
> Moving generic devlink code (registration) out of VF-R code
> into new bnxt_devlink file, in preparation for future work
> to add additional devlink functionality to bnxt.
>
> Signed-off-by: Steve Lin
> Acked-by: Andy Gospodarek
Applied.
From: Jon Maloy
Date: Thu, 19 Oct 2017 16:42:04 +0200
> In commit ae236fb208a6 ("tipc: receive group membership events via
> member socket") we broke the tipc_poll() function by checking the
> state of the receive queue before the call to poll_sock_wait(), while
> relying that state afterwards, w
From: Xin Long
Date: Sat, 21 Oct 2017 17:45:09 +0800
> Let's just see if David could accept the patches if I will
> remove the "security claim" from changelog, considering
> it as an improvement of sock diag.
>
> David ?
No I won't. See my other response.
Use modules.conf or netfilter rules t
From: Xin Long
Date: Sat, 21 Oct 2017 14:06:27 +0800
> Imagine a customer generates a sosreport on their system, and
> with that, it loads sctp module. From then on, if their firewall
> doesn't block incoming packets for sctp, they may be prone to some
> remotely triggerable issue on sctp code, w
On Sat, Oct 21, 2017 at 12:03 PM, Sergei Shtylyov
wrote:
> On 10/20/2017 9:11 PM, Florian Fainelli wrote:
>>> From: Sergei Shtylyov
>>> --- a/drivers/of/of_mdio.c
>>> +++ b/drivers/of/of_mdio.c
>
> [...]
>>>
>>> @@ -55,10 +56,22 @@ static int of_mdiobus_register_phy(struct mii_bus
>>> *mdio,
>>>
struct kmem_cache::flags is "unsigned long" which is unnecessary on
64-bit as no flags are defined in the higher bits.
Switch the field to 32-bit and save some space on x86_64 until such
flags appear:
add/remove: 0/0 grow/shrink: 0/107 up/down: 0/-657 (-657)
function
Hello!
On 10/20/2017 9:11 PM, Florian Fainelli wrote:
From: Sergei Shtylyov
The PHY devices sometimes do have their reset signal (maybe even power
supply?) tied to some GPIO and sometimes it also does happen that a boot
loader does not leave it deasserted. So far this issue has been attacked
Hi Tom,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support-Part-I/20171021-121328
config: arm-iop33x_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce
Add sparse-checked slab_flags_t for struct kmem_cache::flags
(SLAB_POISON, etc).
SLAB is bloated temporarily by switching to "unsigned long",
but only temporarily.
Signed-off-by: Alexey Dobriyan
---
fs/ecryptfs/main.c |2 -
fs/xfs/kmem.h|2 -
include/linux/kasan.h
On Sat, Oct 21, 2017 at 4:45 PM, Xin Long wrote:
> On Sat, Oct 21, 2017 at 3:45 PM, Eric Dumazet wrote:
>> On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote:
>>> On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote:
>>> > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote:
>>> >>
>>> >>
>>> >> On
Fri, Oct 20, 2017 at 05:13:39PM CEST, steven.l...@broadcom.com wrote:
>On Fri, Oct 20, 2017 at 10:39 AM, Jiri Pirko wrote:
>> Thu, Oct 19, 2017 at 09:17:05PM CEST, steven.l...@broadcom.com wrote:
>>>Add support for permanent config parameter get/set commands. Used
>>>for parameters held in NVRAM,
Present Blue sky Studio, is Soliciting for the Right to use Your Photo/Face and
Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED
Stereoscope 3D Movie-The Story of Anubis
All Reply to: blueskyentstud...@usa.com
On Sat, Oct 21, 2017 at 3:45 PM, Eric Dumazet wrote:
> On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote:
>> On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote:
>> > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote:
>> >>
>> >>
>> >> On Sat, Oct 21, 2017 at 9:27 AM, David Miller wrote:
>> >>>
On 10/21/2017 08:25 AM, Alexei Starovoitov wrote:
fix broken tests
Fixes: e043325b3087 ("bpf: Add tests for eBPF file mode")
Fixes: 6e71b04a8224 ("bpf: Add file mode configuration into bpf maps")
Signed-off-by: Alexei Starovoitov
---
Chenbo,
this was very broken patch submission.
Please make s
On Sat, 2017-10-21 at 14:51 +0800, Xin Long wrote:
> On Sat, Oct 21, 2017 at 2:18 PM, Eric Dumazet wrote:
> > On Fri, Oct 20, 2017 at 11:06 PM, Xin Long wrote:
> >>
> >>
> >> On Sat, Oct 21, 2017 at 9:27 AM, David Miller wrote:
> >>>
> >>> From: Xin Long
> >>> Date: Thu, 19 Oct 2017 15:32:23 +0
76 matches
Mail list logo
