Re: using verifier to ensure a BPF program uses certain metadata?

2017-10-17 Thread Johannes Berg
Hi Alexei, > > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next > > .git/log/?h=bpf > > bpf bits looks pretty straightforward. Thanks for looking at this! > attach looks fine too. I'm assuming there is some rtnl or other lock, > so multiple assigns cannot race? Yes. > It's

Re: [PATCH net-next 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-17 Thread Simon Horman
On Tue, Oct 17, 2017 at 09:47:44AM +0200, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen 1 and 2. > > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship > between IP block

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

2017-10-17 Thread Kalle Valo
Kees Cook writes: > On Tue, Oct 17, 2017 at 7:18 AM, Kalle Valo wrote: >> + linux-wireless >> >> Hi Kees, >> >> Kees Cook writes: >> >>> This is the current set of outstanding networking patches to perform >>> conversions to the new timer interface (rebased to -next). This is not >>> all expect

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-17 Thread Gilad Ben-Yossef
On Tue, Oct 17, 2017 at 5:06 PM, Russell King - ARM Linux wrote: > On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: >> Many users of kernel async. crypto services have a pattern of >> starting an async. crypto op and than using a completion >> to wait for it to end. >> >> This pat

Re: [Intel-wired-lan] [PATCH] [v2] i40e: avoid 64-bit division where possible

2017-10-17 Thread Nambiar, Amritha
On 10/17/2017 10:33 AM, Alexander Duyck wrote: > On Tue, Oct 17, 2017 at 8:49 AM, Arnd Bergmann wrote: >> The new bandwidth calculation caused a link error on 32-bit >> architectures, like >> >> ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko] >> undefined! >> >> The problem is

RE: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-17 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, October 18, 2017 5:34 AM >>> This is better for code locality and should slightly speed up normal >interrupts. >>> >>> This also allows PPS clock output to start working for i.mx7. This is >>> because >>> i.mx7 was already using the limit of 3 interrupts, and nee

RE: [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic

2017-10-17 Thread Chris Mi
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Tuesday, October 17, 2017 11:53 PM > To: Chris Mi > Cc: Linux Kernel Network Developers ; Jamal Hadi > Salim ; Lucas Bates ; Jiri Pirko > ; David Miller > Subject: Re: [patch net v2 1/4] net/sched: Change tc_

RE: [patch net v3 2/4] net/sched: Use action array instead of action list as parameter

2017-10-17 Thread Chris Mi
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Wednesday, October 18, 2017 12:56 AM > To: Chris Mi > Cc: Linux Kernel Network Developers ; Jamal Hadi > Salim ; Lucas Bates ; Jiri Pirko > ; David Miller > Subject: Re: [patch net v3 2/4] net/sched: Use ac

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Song Liu
> > Remove use of ipv6_pinfo in favor of data in sock_common. > > > > Fixes: e086101b150a ("tcp: add a tracepoint for tcp retransmission") > > Signed-off-by: David Ahern > > --- > > Reviewed-by: Eric Dumazet > Thanks David ! Tested-by: Song Liu

Re: RFC(v2): Audit Kernel Container IDs

2017-10-17 Thread Steve Grubb
On Tuesday, October 17, 2017 1:57:43 PM EDT James Bottomley wrote: > > > > The idea is that processes spawned into a container would be > > > > labelled by the container orchestration system. It's unclear > > > > what should happen to processes using nsenter after the fact, but > > > > policy for

[PATCH] dql: make dql_init return void

2017-10-17 Thread Stephen Hemminger
dql_init always returned 0, and the only place that uses it in network core code didn't care about the return value anyway. Signed-off-by: Stephen Hemminger --- include/linux/dynamic_queue_limits.h | 2 +- lib/dynamic_queue_limits.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletion

[PATCH] net: mac80211: mark expected switch fall-throughs

2017-10-17 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in some cases I replaced "fall through on else" and "otherwise fall through" comments with just a "fall through" comment, which is what GCC is expecting to find. Signed-off-by:

Re: [Intel-wired-lan] [RFC PATCH next 2/2] i40e: add support for macvlan hardware offload

2017-10-17 Thread Shannon Nelson
On 10/17/2017 2:32 PM, Alexander Duyck wrote: So the select_queue function being needed is the deal breaker on all of this as far as I am concerned. We aren't allowed to use it under other cases so why should macvlan be an exception to the rule? I realize that the stack is pretty good at chosi

[PATCH] net: l2tp: mark expected switch fall-through

2017-10-17 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced the "NOBREAK" comment with a "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- This cod

Re: [PATCH 0/7] Adding permanent config get/set to devlink

2017-10-17 Thread Steve Lin
My apologies - this patchset was intended for net-next; I forgot to add that to the subject line, though. Steve On Tue, Oct 17, 2017 at 4:44 PM, Steve Lin wrote: > DIFFERENCES FROM RFC: > Implemented most of the changes suggested by Jiri and others. > Thanks for the valuable feedback! > > Adds a

Re: using verifier to ensure a BPF program uses certain metadata?

2017-10-17 Thread Alexei Starovoitov
On Mon, Oct 16, 2017 at 09:38:44AM +0200, Johannes Berg wrote: > Hi, > > As we discussed in April already (it's really been that long...), I'd > wanted to allow using BPF to filter wireless monitor frames, to enable > new use cases and higher performance in monitoring. I have some code, > at > >

Cycling Enthusiasts List

2017-10-17 Thread Greg Elmassian
Hi, Hope all's well, Would you be interested in acquiring an email list of “ Cycling Enthusiasts List ” from USA? Each record in the list contains Contact Name (First, Middle and Last Name), Mailing Address, List type and Opt-in email address. All the contacts are opt-in verified, 100% perm

Re: [PATCH net-next 2/3] ipv6: start fib6 gc on RTF_CACHE dst creation

2017-10-17 Thread Martin KaFai Lau
On Tue, Oct 17, 2017 at 06:35:13PM +, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > After the commit Fixes: 2b760fcf5cfb ("ipv6: hook up exception > > table to store dst cache"), the fib6 gc is not started after > > the creation of a RTF_CACHE via a redirect or pmt

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Martin KaFai Lau
On Tue, Oct 17, 2017 at 06:58:23PM +, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > > dst.obsolete when a cached route has expired"). > >

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Eric Dumazet
On Tue, 2017-10-17 at 13:09 -0700, David Ahern wrote: > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the int

Re: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-17 Thread Troy Kisky
On 10/15/2017 8:41 PM, Andy Duan wrote: > From: Troy Kisky Sent: Saturday, October 14, > 2017 10:10 AM >> This is better for code locality and should slightly speed up normal >> interrupts. >> >> This also allows PPS clock output to start working for i.mx7. This is because >> i.mx7 was already u

Re: [Intel-wired-lan] [RFC PATCH next 2/2] i40e: add support for macvlan hardware offload

2017-10-17 Thread Alexander Duyck
On Tue, Oct 17, 2017 at 2:18 PM, Shannon Nelson wrote: > This patch adds support for macvlan hardware offload (l2-fwd-offload) > feature using the XL710's macvlan-to-queue filtering machanism. These > are most useful for supporting separate mac addresses for Container > virtualization using Docke

[RFC PATCH next 1/2] i40e: add ToQueue specific handling for mac filters

2017-10-17 Thread Shannon Nelson
Add the concept of queue-specific filters to the filter handling. This will be used in the near future for macvlan offload filters. In general, filters for standard use will use a queue of 0, which we'll take to mean the filter applies to the whole VSI. Only the filters for macvlan offload will

[RFC PATCH next 2/2] i40e: add support for macvlan hardware offload

2017-10-17 Thread Shannon Nelson
This patch adds support for macvlan hardware offload (l2-fwd-offload) feature using the XL710's macvlan-to-queue filtering machanism. These are most useful for supporting separate mac addresses for Container virtualization using Docker and similar configurations. The basic design is to partition

[RFC PATCH next 0/2] Add support for macvlan offload

2017-10-17 Thread Shannon Nelson
The XL710 and family was originally designed as a device to support the growing "cloud" networking needs. With its large number of queues, filters, VFs, and other features, it can be a very handy device for sorting traffic in a variety of ways. However, one early design point was to support macvl

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > On Tue, 2017-10-17 at 11:58 -0700, Wei Wang wrote: >> On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: >> > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store >> > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set >> >

[PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-17 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for parameters held in NVRAM, persistent device configuration. The config_get() and config_set() operations operate as expected, but note that the driver implementation of the config_set() operation can indicate whether a restart is

[PATCH 5/7] devlink: Adding pre-boot permanent config parameters

2017-10-17 Thread Steve Lin
Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) to include some pre-boot device configuration settings: DEVLINK_ATTR_PERM_CFG_MBA_ENABLED: 1 to enable Multiple Boot Agent (BMA), 0 to disable. DEVLINK_ATTR_PERM_CFG_MBA_BOOT_TYPE: Controls mechanism MBA will use to insert its

[PATCH 6/7] bnxt: Move generic devlink code to new file

2017-10-17 Thread Steve Lin
Moving generic devlink code (registration) out of VR-R code into new bnxt_devlink file. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net/ethernet/broadcom/bnxt/

[PATCH 7/7] bnxt: Add devlink support for config get/set

2017-10-17 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 310 +- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 17 ++ drivers/net

[PATCH 3/7] devlink: Adding high level dev perm config params

2017-10-17 Thread Steve Lin
Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) to include some high level device configuration settings: DEVLINK_ATTR_PERM_CFG_DCBX_MODE: Data Center Bridging Exchange (DCBX) protocol mode; use enum devlink_dcbx_mode. DEVLINK_ATTR_PERM_CFG_RDMA_ENABLED: 1 to enable RDMA, 0

[PATCH 0/7] Adding permanent config get/set to devlink

2017-10-17 Thread Steve Lin
DIFFERENCES FROM RFC: Implemented most of the changes suggested by Jiri and others. Thanks for the valuable feedback! Adds a devlink command for getting & setting permanent (persistent / NVRAM) device configuration parameters, and enumerates the parameters as nested devlink attributes. bnxt drive

[PATCH 4/7] devlink: Adding perm config of link settings

2017-10-17 Thread Steve Lin
Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) to include persistent configuration of device link settings: DEVLINK_ATTR_PERM_CFG_AUTONEG_PROTOCOL: Configure default autoneg protocol; use enum devlink_autoneg_protocol. DEVLINK_ATTR_PERM_CFG_MEDIA_AUTO_DETECT: Configure def

[PATCH 2/7] devlink: Adding NPAR permanent config parameters

2017-10-17 Thread Steve Lin
Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) to include NPAR settings: DEVLINK_ATTR_PERM_CFG_NPAR_NUM_PARTITIONS_PER_PORT: Number of NIC Partitions (NPAR) per port. DEVLINK_ATTR_PERM_CFG_NPAR_BW_IN_PERCENT: 1 if BW_RESERVATION and BW_LIMIT is in percent; /0 if BW_RESERVA

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Cong Wang
On Tue, Oct 17, 2017 at 1:09 PM, David Ahern wrote: > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the inter

[no subject]

2017-10-17 Thread kelley
<>

[PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-17 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This removes the tid mapping array and expands the tid structures to add a pointer back to the station, alon

Re: [patch net-next 01/20] net: sched: add block bind/unbind notif. and extended block_get/put

2017-10-17 Thread Duyck, Alexander H
On Tue, 2017-10-17 at 22:05 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce new type of ndo_setup_tc message to propage binding/unbinding > of a block to driver. Call this ndo whenever qdisc gets/puts a block. > Alongside with this, there's need to propagate binder type from qdisc > cod

[PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread David Ahern
Running perf in one window to capture tcp_retransmit_skb tracepoint: $ perf record -e tcp:tcp_retransmit_skb -a And causing a retransmission on an active TCP session (e.g., dropping packets in the receiver, changing MTU on the interface to 500 and back to 1500) triggers a panic: [ 58.543144

[patch net-next 01/20] net: sched: add block bind/unbind notif. and extended block_get/put

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Introduce new type of ndo_setup_tc message to propage binding/unbinding of a block to driver. Call this ndo whenever qdisc gets/puts a block. Alongside with this, there's need to propagate binder type from qdisc code down to the notifier. So introduce extended variants of block_g

[patch net-next 02/20] net: sched: use extended variants of block_get/put in ingress and clsact qdiscs

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Use previously introduced extended variants of block get and put functions. This allows to specify a binder types specific to clsact ingress/egress which is useful for drivers to distinguish who actually got the block. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 2

[patch net-next 04/20] net: sched: use tc_setup_cb_call to call per-block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Extend the tc_setup_cb_call entrypoint function originally used only for action egress devices callbacks to call per-block callbacks as well. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 4 ++-- net/sched/cls_api.c| 21 ++--- net/sched/cls_flower

[patch net-next 09/20] mlxsw: spectrum: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for matchall and flower offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 82 +++--- 1 file changed, 60

[patch net-next 03/20] net: sched: introduce per-block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Introduce infrastructure that allows drivers to register callbacks that are called whenever tc would offload inserted rule for a specific block. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 81 +++ include/net/sch_generic.h | 1 +

[patch net-next 06/20] net: sched: cls_u32: swap u32_remove_hw_knode and u32_remove_hw_hnode

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- net/sched/cls_u32.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index b6d4606..f407f13 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -462,7 +462,7 @@

[patch net-next 05/20] net: sched: cls_matchall: call block callbacks for offload

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Use the newly introduced callbacks infrastructure and call block callbacks alongside with the existing per-netdev ndo_setup_tc. Signed-off-by: Jiri Pirko --- net/sched/cls_matchall.c | 72 ++-- 1 file changed, 45 insertions(+), 27 de

[patch net-next 10/20] mlx5e: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for flower offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4

[patch net-next 07/20] net: sched: cls_u32: call block callbacks for offload

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Use the newly introduced callbacks infrastructure and call block callbacks alongside with the existing per-netdev ndo_setup_tc. Signed-off-by: Jiri Pirko --- net/sched/cls_u32.c | 72 ++--- 1 file changed, 52 insertions(+), 20 de

[patch net-next 11/20] bnxt: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for flower offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 37 +++ drivers/net/ethernet/broadcom/bnxt/b

[patch net-next 15/20] nfp: flower: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for flower offloads to block callbacks. Signed-off-by: Jiri Pirko --- .../net/ethernet/netronome/nfp/flower/offload.c| 56 ++ 1 file changed, 48 insertions(+)

[patch net-next 16/20] nfp: bpf: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for bpf offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 54 ++- 1 file changed, 45 insertions(+), 9

[patch net-next 14/20] mlx5e_rep: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for flower offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 44 1 file changed, 38 insertions(+)

[patch net-next 12/20] cxgb4: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for flower and u32 offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 45 + 1 file changed, 39 inser

[patch net-next 19/20] net: sched: remove unused classid field from tc_cls_common_offload

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko It is no longer used by the drivers, so remove it. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index fcca5a9..04caa24 100644 --- a/include/net/pkt_cls.h +++ b/include/net

[patch net-next 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko This patchset is a bit bigger, but most of the patches are doing the same changes in multiple classifiers and drivers. I could do some squashes, but I think it is better split. This is another dependency on the way to shared block implementation. The goal is to remove use of tp-

[patch net-next 18/20] net: sched: avoid ndo_setup_tc calls for TC_SETUP_CLS*

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko All drivers are converted to use block callbacks for TC_SETUP_CLS*. So it is now safe to remove the calls to ndo_setup_tc from cls_* Signed-off-by: Jiri Pirko --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 -- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |

[patch net-next 17/20] dsa: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for matchall offloads to block callbacks. Signed-off-by: Jiri Pirko --- net/dsa/slave.c | 64 +++-- 1 file changed, 53 insertions(

[patch net-next 20/20] net: sched: remove unused is_classid_clsact_ingress/egress helpers

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko These helpers are no longer in use by drivers, so remove them. Signed-off-by: Jiri Pirko --- include/net/pkt_sched.h | 13 - 1 file changed, 13 deletions(-) diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h index 2d234af..b8ecafc 100644 --- a/include/

[patch net-next 08/20] net: sched: cls_bpf: call block callbacks for offload

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Use the newly introduced callbacks infrastructure and call block callbacks alongside with the existing per-netdev ndo_setup_tc. Signed-off-by: Jiri Pirko --- net/sched/cls_bpf.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) di

[patch net-next 13/20] ixgbe: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
From: Jiri Pirko Benefit from the newly introduced block callback infrastructure and convert ndo_setup_tc calls for u32 offloads to block callbacks. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 45 +++ 1 file changed, 39 insertions(+), 6

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Paolo Abeni
On Tue, 2017-10-17 at 11:58 -0700, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > > dst.obsolete when a cached route has expired"). > > > > Th

[PATCH v2 net] dccp/tcp: fix ireq->opt races

2017-10-17 Thread Eric Dumazet
From: Eric Dumazet syzkaller found another bug in DCCP/TCP stacks [1] For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access ireq->opt unless we own the request sock. [1] BUG: KASAN: use-after-free in ip_queue_xmit+0x1687/0x1

Re: [PATCH net] dccp/tcp: fix ireq->opt races

2017-10-17 Thread Eric Dumazet
On Tue, 2017-10-17 at 12:50 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller found another bug in DCCP/TCP stacks [1] > > For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix > ireq->pktopts race"), we need to make sure we do not access > ireq->opt unless we own the requ

[PATCH net] dccp/tcp: fix ireq->opt races

2017-10-17 Thread Eric Dumazet
From: Eric Dumazet syzkaller found another bug in DCCP/TCP stacks [1] For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access ireq->opt unless we own the request sock. [1] BUG: KASAN: use-after-free in ip_queue_xmit+0x1687/0x1

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

2017-10-17 Thread Kees Cook
On Tue, Oct 17, 2017 at 7:18 AM, Kalle Valo wrote: > + linux-wireless > > Hi Kees, > > Kees Cook writes: > >> This is the current set of outstanding networking patches to perform >> conversions to the new timer interface (rebased to -next). This is not >> all expected conversions, but it contains

[PATCH net] dccp/tcp: fix ireq->opt races

2017-10-17 Thread Eric Dumazet
From: Eric Dumazet syzkaller found another bug in DCCP/TCP stacks [1] For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access ireq->opt unless we own the request sock. [1] BUG: KASAN: use-after-free in ip_queue_xmit+0x1687/0x1

Re: [PATCH net-next 1/3] ipv6: fix route cache dump

2017-10-17 Thread Paolo Abeni
Hi, On Tue, 2017-10-17 at 11:41 -0700, Eric Dumazet wrote: > On Tue, Oct 17, 2017 at 11:26 AM, Wei Wang wrote: > > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > > After the commit 2b760fcf5cfb ("ipv6: hook up exception table to > > > store dst cache"), entries in the routing cache are

[PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources

2017-10-17 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to fall through. drivers/net/e

[PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists

2017-10-17 Thread Gustavo A. R. Silva
NULL check before freeing functions like kfree is not needed. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > dst.obsolete when a cached route has expired"). > > This change brings back the dst obsoleting and push it a step > fa

Re: [PATCH net-next 1/3] ipv6: fix route cache dump

2017-10-17 Thread Eric Dumazet
On Tue, Oct 17, 2017 at 11:26 AM, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: >> After the commit 2b760fcf5cfb ("ipv6: hook up exception table to >> store dst cache"), entries in the routing cache are not shown by: >> >> ip route show cache > > Hi Paolo, > > Thanks for

Re: [PATCH net-next 2/3] ipv6: start fib6 gc on RTF_CACHE dst creation

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > After the commit Fixes: 2b760fcf5cfb ("ipv6: hook up exception > table to store dst cache"), the fib6 gc is not started after > the creation of a RTF_CACHE via a redirect or pmtu update, since > fib6_add() isn't invoked anymore for such dsts.

[PATCH] mac80211: use constant time comparison with keys

2017-10-17 Thread Jason A. Donenfeld
Otherwise we risk leaking information via timing side channel. Fixes: fdf7cb4185b6 ("mac80211: accept key reinstall without changing anything") Signed-off-by: Jason A. Donenfeld --- net/mac80211/key.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/key.c b/net/

[net-next 04/15] i40e: fix clearing link masks in i40e_get_link_ksettings

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This fixes two issues in i40e_get_link_ksettings. It adds calls to ethtool_link_ksettings_zero_link_mode to make sure advertising and supported link masks are cleared before we start setting bits in them. This also replaces some funky bit manipulations with a much nicer call to

[net-next 06/15] i40e: fix comment typo

2017-10-17 Thread Jeff Kirsher
From: Alan Brady Someone forgot a word in this comment and it's confusing without it. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[net-next 05/15] i40e: fix i40e_phy_type_to_ethtool function header

2017-10-17 Thread Jeff Kirsher
From: Alan Brady The function header erroneously listed 'phy_types' as a parameter. The correct parameter is 'pf'. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-17

2017-10-17 Thread Jeff Kirsher
This series contains updates to i40e and ethtool. Alan provides most of the changes in this series which are mainly fixes and cleanups. Renamed the ethtool "cmd" variable to "ks", since the new ethtool API passes us ksettings structs instead of command structs. Cleaned up an ifdef that was not ac

[net-next 08/15] i40e: group autoneg PHY types together

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This separates the setting of autoneg in i40e_phy_types_to_ethtool into its own conditional. Doing this adds clarity as what PHYs support/advertise autoneg and makes it easier to add new PHY types in the future. This also fixes an issue on devices with CRT_RETIMER where adverti

[net-next 03/15] i40e: add function header for i40e_get_rxfh

2017-10-17 Thread Jeff Kirsher
From: Alan Brady Someone left this poor little function naked with no header. This dresses it up in a proper function header it deserves. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 ++ 1 file

[net-next 12/15] i40e: convert i40e_get_settings_link_up to new API

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This removes references to old ethtool API macros and functions in i40e_get_settings_link_up as part of the process of converting to the new API. The new API also allows us to provide more explicit support for new 25G and 10G PHY types so some of the PHY types have been adjusted

[net-next 09/15] i40e: Add new PHY types for 25G AOC and ACC support

2017-10-17 Thread Jeff Kirsher
From: Sudheer Mogilappagari This patch adds support for 25G Active Optical Cables (AOC) and Active Copper Cables (ACC) PHY types. Signed-off-by: Sudheer Mogilappagari Signed-off-by: Krzysztof Malek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e

[net-next 10/15] ethtool: add ethtool_intersect_link_masks

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This function provides a way to intersect two link masks together to find the common ground between them. For example in i40e, the driver first generates link masks for what is supported by the PHY type. The driver then gets the link masks for what the NVM supports. The result

[net-next 07/15] i40e: fix whitespace issues in i40e_ethtool.c

2017-10-17 Thread Jeff Kirsher
From: Alan Brady There's a number of minor incidental whitespace issues in this file. This addresses most of the ones I could find. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 44 +++--

Re: [PATCH net-next 1/3] ipv6: fix route cache dump

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > After the commit 2b760fcf5cfb ("ipv6: hook up exception table to > store dst cache"), entries in the routing cache are not shown by: > > ip route show cache > > because the per route exception table containing such routes is not > traversed by

[net-next 15/15] i40e: fix u64 division usage

2017-10-17 Thread Jeff Kirsher
From: Alan Brady Commit 52eb1ff93e98 ("i40e: Add support setting TC max bandwidth rates") and commit 1ea6f21ae530 ("i40e: Refactor VF BW rate limiting") add some needed functionality for TC bandwidth rate limiting. Unfortunately they introduce several usages of unsigned 64-bit division which nee

[net-next 13/15] i40e: rename 'change' variable to 'autoneg_changed'

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This variable isn't actually very descriptive and makes the code a bit confusing as to what it is being used for. This patch enhances the variable with the longer name, 'autoneg_changed', which makes it clear we are concerned with autoneg changing in this context. Signed-off-by

[net-next 14/15] i40e: convert i40e_set_link_ksettings to new API

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This finishes off the conversion to the new ethtool API by removing the old macros being used in i40e_set_link_ksettings and replacing them with shiny new ones. This conversion also allows us to provide link speed support for new 25G and 10G macros which is included here as well

[net-next 02/15] i40e: remove ifdef SPEED_25000

2017-10-17 Thread Jeff Kirsher
From: Alan Brady This 'ifdef' doesn't accomplish anything so remove it. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i4

[net-next 11/15] i40e: convert i40e_phy_type_to_ethtool to new API

2017-10-17 Thread Jeff Kirsher
From: Alan Brady We are still largely using the old ethtool API macros. This is problematic because eventually they will be removed and they only support 32 bits of PHY types. This overhauls i40e_phy_type_to_ethtool to use only the new API. Doing this also allows us to provide much better supp

[net-next 01/15] i40e: rename 'cmd' variables in ethtool interface

2017-10-17 Thread Jeff Kirsher
From: Alan Brady After the switch to the new ethtool API, ethtool passes us ethtool_ksettings structs instead of ethtool_command structs, however we were still referring to them as 'cmd' variables. This renames them to 'ks' variables which makes the code easier to understand. Signed-off-by: Ala

Re: pull-request: mac80211 2017-10-16

2017-10-17 Thread Jason A. Donenfeld
On Tue, Oct 17, 2017 at 7:46 AM, Johannes Berg wrote: > If it's not equal, you execute so much code > beneath, going to the driver etc., that I'd think this particular time > is in the noise. Usually presumptions like this get you in trouble when some crafty academic has a smart idea about that n

Re: [patch net-next 27/34] nfp: bpf: Convert ndo_setup_tc offloads to block callbacks

2017-10-17 Thread Jiri Pirko
Tue, Oct 17, 2017 at 04:39:59PM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 17 Oct 2017 14:48:12 +0200, Jiri Pirko wrote: >> Fri, Oct 13, 2017 at 03:08:24AM CEST, jakub.kicin...@netronome.com wrote: >> >On Thu, 12 Oct 2017 19:18:16 +0200, Jiri Pirko wrote: >> >> diff --git a/drivers/net/et

[PATCH] net/ethernet/sgi: Code cleanup

2017-10-17 Thread Joshua Kinard
From: Joshua Kinard The below patch attempts to clean up the code for the in-tree driver for IOC3 ethernet and serial console support, primarily used by SGI MIPS platforms. Notable changes include: - Lots of whitespace cleanup - Using shorthand integer types (u16, u32, etc) where appropriat

[PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Paolo Abeni
The commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache") partially reverted 1e2ea8ad37be ("ipv6: set dst.obsolete when a cached route has expired"). This change brings back the dst obsoleting and push it a step farther: cached dst are always obsoleted when removed from the fib

Re: [PATCH net-next] tcp: Enable TFO without a cookie on a per-socket basis

2017-10-17 Thread Christoph Paasch
On 17/10/17 - 10:26:58, Yuchung Cheng wrote: > On Mon, Oct 16, 2017 at 11:37 PM, Christoph Paasch wrote: > > We already allow to enable TFO without a cookie by using the > > fastopen-sysctl and setting it to TFO_SERVER_COOKIE_NOT_REQD (0x200). > > This is safe to do in certain environments where w

Re: RFC(v2): Audit Kernel Container IDs

2017-10-17 Thread James Bottomley
On Tue, 2017-10-17 at 13:15 -0400, Steve Grubb wrote: > On Tuesday, October 17, 2017 12:43:18 PM EDT Casey Schaufler wrote: > > > > > > > > The idea is that processes spawned into a container would be > > > labelled by the container orchestration system.  It's unclear > > > what should happen to

[PATCH net-next 2/3] ipv6: start fib6 gc on RTF_CACHE dst creation

2017-10-17 Thread Paolo Abeni
After the commit Fixes: 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"), the fib6 gc is not started after the creation of a RTF_CACHE via a redirect or pmtu update, since fib6_add() isn't invoked anymore for such dsts. We need the fib6 gc to run periodically to clean the RTF_CACH

[PATCH net-next 1/3] ipv6: fix route cache dump

2017-10-17 Thread Paolo Abeni
After the commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"), entries in the routing cache are not shown by: ip route show cache because the per route exception table containing such routes is not traversed by rt6_dump_route(). Fix it by explicitly dumping all routes present

[PATCH net-next 0/3] ipv6: fixes for RTF_CACHE entries

2017-10-17 Thread Paolo Abeni
This series addresses 3 different but related issues with RTF_CACHE introduced by the recent refactory. patch 1 restore redirect and pmtu route update dump patch 2 restore the gc timer for such routes patch 3 obsoletes the dst on removal from exception tables Paolo Abeni (3): ipv6: fix route ca

[PATCH net-next 3/3] ibmvnic: Let users change net device features

2017-10-17 Thread Thomas Falcon
Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index aedb81c..b991703 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/

  1   2   3   >