RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

2017-10-15 Thread Yuval Mintz
> Hi, Yuval > > On 2017/10/15 13:14, Yuval Mintz wrote: > >> Hi, Yuval > >> > >> On 2017/10/13 4:21, Yuval Mintz wrote: > This patchset adds a new hardware offload type in mqprio before > adding > mqprio hardware offload support in hns3 driver. > >>> > >>> I think one of the biggest issu

Re: [PATCH v1] pch_gbe: Switch to new PCI IRQ allocation API

2017-10-15 Thread kbuild test robot
Hi Andy, [auto build test ERROR on net-next/master] [also build test ERROR on v4.14-rc5 next-20171013] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pch_gbe-Switch-to-new-PCI-IR

Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11,Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-15 Thread David Miller
From: Doug Ledford Date: Sat, 14 Oct 2017 17:19:34 -0400 > On 10/14/2017 2:48 PM, Saeed Mahameed wrote: >> Hi Dave and Doug, >> >> This series includes updates for mlx5 IPoIB offloading driver from Alex >> and Feras to add the support for Muli Pkey in the mlx5i ipoib offloading >> netdev, >> to

RE: [PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-15 Thread Madalin-cristian Bucur
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Sunday, October 15, 2017 9:34 PM > To: Madalin-cristian Bucur > Cc: netdev@vger.kernel.org; da...@davemloft.net; f.faine...@gmail.com; > vivien.dide...@savoirfairelinux.com; jun...@outlook.com; linux- > ker...@vger.ke

Re: [PATCH 3/3][v2] selftests: silence test output by default

2017-10-15 Thread Michael Ellerman
Shuah Khan writes: > On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: >> From: Josef Bacik >> >> Some of the networking tests are very noisy and make it impossible to >> see if we actually passed the tests as they run. Default to suppressing >> the output from any tests run in order to make

RE: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-15 Thread Andy Duan
From: Troy Kisky Sent: Saturday, October 14, 2017 10:10 AM >This is better for code locality and should slightly speed up normal >interrupts. > >This also allows PPS clock output to start working for i.mx7. This is because >i.mx7 was already using the limit of 3 interrupts, and needed another. >

RE: [PATCH v2 5/5] fsl/fman: add dpaa in module names

2017-10-15 Thread Madalin-cristian Bucur
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Friday, October 13, 2017 8:39 PM > To: Madalin-cristian Bucur ; > netdev@vger.kernel.org; da...@davemloft.net > Cc: and...@lunn.ch; vivien.dide...@savoirfairelinux.com; > jun...@outlook.com; linux-ker...@vge

To learn the netdev code, please give me some advice...

2017-10-15 Thread admin
Hi, all     I want to learn network programming, and hope to read the kernel code of netdev.     Please give me some advice.     Thanks!

Re: routing UAPI mismatch invalid state behavior?

2017-10-15 Thread David Ahern
On 10/15/17 11:02 AM, Alexander Aring wrote: > Hi, > > I figure out some problem, easy to reproduce: > > # setup dummy > $ modprobe dummy > $ ip link set dummy0 up > > # issue > $ ip route replace default via 169.254.65.37 dev dummy0 > RTNETLINK answers: Network is unreachable This fails in fib

Re: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

2017-10-15 Thread Yunsheng Lin
Hi, Yuval On 2017/10/15 16:51, Yuval Mintz wrote: > This patchset adds a new hardware offload type in mqprio before >> adding > mqprio hardware offload support in hns3 driver. > > Apparently Dave has already accepted Amirtha's changes to mqprio: > https://marc.info/?l=linux-netdev&m=1508

Re: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

2017-10-15 Thread Yunsheng Lin
Hi, Yuval On 2017/10/15 13:14, Yuval Mintz wrote: >> Hi, Yuval >> >> On 2017/10/13 4:21, Yuval Mintz wrote: This patchset adds a new hardware offload type in mqprio before adding mqprio hardware offload support in hns3 driver. >>> >>> I think one of the biggest issues in tying this to DC

Re: [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink

2017-10-15 Thread David Ahern
[ cc'ed Nicolas ] On 10/15/17 4:13 AM, Xin Long wrote: > The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really > work after status & DO_SETLINK_MODIFIED, as: > > DO_SETLINK_MODIFIED 0x1 > DO_SETLINK_NOTIFY 0x3 > > Considering that notifications are suppposed to be sent only whe

Re: [PATCH net 6/6] rtnetlink: do not set notification for tx_queue_len in do_setlink

2017-10-15 Thread David Ahern
On 10/15/17 4:13 AM, Xin Long wrote: > NETDEV_CHANGE_TX_QUEUE_LEN event process in rtnetlink_event would > send a notification for userspace and tx_queue_len's setting in > do_setlink would trigger NETDEV_CHANGE_TX_QUEUE_LEN. > > So it shouldn't set DO_SETLINK_NOTIFY status for this change to > se

Re: [PATCH net 2/6] rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN event process back in rtnetlink_event

2017-10-15 Thread David Ahern
On 10/15/17 4:13 AM, Xin Long wrote: > The same fix for changing mtu in the patch 'rtnetlink: bring > NETDEV_CHANGEMTU event process back in rtnetlink_event' is > needed for changing tx_queue_len. > > Note that the redundant notifications issue for tx_queue_len > will be fixed in the later patch '

Re: [PATCH net 4/6] rtnetlink: bring NETDEV_CHANGEUPPER event process back in rtnetlink_event

2017-10-15 Thread David Ahern
On 10/15/17 4:13 AM, Xin Long wrote: > libteam needs this event notification in userspace when dev's master > dev has been changed. After this, the redundant notifications issue > would be fixed in the later patch 'rtnetlink: check DO_SETLINK_NOTIFY > correctly in do_setlink'. > > Fixes: b6b36eb23

Re: [PATCH net 3/6] rtnetlink: bring NETDEV_POST_TYPE_CHANGE event process back in rtnetlink_event

2017-10-15 Thread David Ahern
On 10/15/17 4:13 AM, Xin Long wrote: > As I said in patch 'rtnetlink: bring NETDEV_CHANGEMTU event process back > in rtnetlink_event', removing NETDEV_POST_TYPE_CHANGE event was not the > right fix for the redundant notifications issue. > > So bring this event process back to rtnetlink_event and t

Re: RFC: making cn_proc work in {pid,user} namespaces

2017-10-15 Thread Eric W. Biederman
Aleksa Sarai writes: > Hi all, > > At the moment, cn_proc is not usable by containers or container runtimes. In > addition, all connectors have an odd relationship with init_net (for example, > /proc/net/connectors only exists in init_net). There are two main use-cases > that > would be perfect

Re: [PATCH] bpf: devmap: Check attr->max_entries more carefully

2017-10-15 Thread Richard Weinberger
Am Montag, 16. Oktober 2017, 00:00:20 CEST schrieb Richard Weinberger: > max_entries is user controlled and used as input for __alloc_percpu(). > This function expects that the allocation size is a power of two and > less than PCPU_MIN_UNIT_SIZE. > Otherwise a WARN() is triggered. On a second thou

[PATCH] bpf: devmap: Check attr->max_entries more carefully

2017-10-15 Thread Richard Weinberger
max_entries is user controlled and used as input for __alloc_percpu(). This function expects that the allocation size is a power of two and less than PCPU_MIN_UNIT_SIZE. Otherwise a WARN() is triggered. Fixes: 11393cc9b9be ("xdp: Add batching support to redirect map") Reported-by: Shankara Pailoor

Re: [PATCH net-next 00/10] korina cleanups/optimizations

2017-10-15 Thread David Miller
From: Roman Yeryomin Date: Sun, 15 Oct 2017 19:46:02 +0300 > On 2017-10-15 19:38, Florian Fainelli wrote: >> On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin >> wrote: >>> TX optimizations have led to ~15% performance increase (35->40Mbps) >>> in local tx usecase (tested with iperf v3.2). >> C

[PATCH] hamradio: baycom_par: use new parport device model

2017-10-15 Thread Sudip Mukherjee
Modify baycom driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- Not tested on real hardware, only tested on kvm with 32 bit guest and verified that the device is binding to the driver properly in par96_open but then unbinding as the device was not found. driv

Re: [PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-15 Thread Andrew Lunn
On Fri, Oct 13, 2017 at 05:50:09PM +0300, Madalin Bucur wrote: > Signed-off-by: Madalin Bucur > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++-- > drivers/net/ethernet/freescale/fman/mac.c | 97 > ++ > drivers/net/ethernet/freescale/fman/mac.h

[PATCH] net: dccp: mark expected switch fall-throughs

2017-10-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that for options.c file, I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- This code was tested by

Re: [PATCH net-next] ipv6: only update __use and lastusetime once per jiffy at most

2017-10-15 Thread Martin KaFai Lau
On Sat, Oct 14, 2017 at 12:26:28AM +, Eric Dumazet wrote: > On Fri, Oct 13, 2017 at 5:09 PM, Martin KaFai Lau wrote: > > On Fri, Oct 13, 2017 at 10:08:07PM +, Wei Wang wrote: > >> From: Wei Wang > >> > >> In order to not dirty the cacheline too often, we try to only update > >> dst->__use

[PATCH] net: ceph: mark expected switch fall-throughs

2017-10-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- net/ceph/ceph_hash.c | 12 +++- net/ceph/messenger.c | 1 + net/ceph/mon_client.c | 1 + 3 files changed, 13 insertions(+), 1 deletion(-

Re: [PATCH net-next 00/10] korina cleanups/optimizations

2017-10-15 Thread Florian Fainelli
On October 15, 2017 9:46:02 AM PDT, Roman Yeryomin wrote: >On 2017-10-15 19:38, Florian Fainelli wrote: >> On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin >> wrote: >>> TX optimizations have led to ~15% performance increase (35->40Mbps) >>> in local tx usecase (tested with iperf v3.2). >> >>

[PATCH] xen/9pfs: mark expected switch fall-through in xen_9pfs_front_changed

2017-10-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- This code was test

Re: [RFC PATCH v2 5/5] wave: Added TCP Wave

2017-10-15 Thread Eric Dumazet
On Sat, 2017-10-14 at 13:47 +0200, Natale Patriciello wrote: > TCP Wave (TCPW) replaces the window-based transmission paradigm of the > standard TCP with a burst-based transmission, the ACK-clock scheduling > with a self-managed timer and the RTT-based congestion control loop > with an Ack-based Ca

Re: [RFC PATCH v2 3/5] tcp: added get_segs_per_round

2017-10-15 Thread Eric Dumazet
On Sat, 2017-10-14 at 13:47 +0200, Natale Patriciello wrote: > Usually, the pacing time is provided per-segment. In some occasion, this > time refers to the time between a group of segments. With this commit, add > the possibility for the congestion control module to tell the TCP socket > how many

Re: [RFC PATCH v2 2/5] tcp: implemented pacing_expired

2017-10-15 Thread Eric Dumazet
On Sat, 2017-10-14 at 13:47 +0200, Natale Patriciello wrote: > Inform the congestion control that the pacing timer, previously set, > has expired. The commit does not consider situations in which another > kind of timer has expired (e.g., a tail loss probe, a retransmission > timer...) > > Signed-

routing UAPI mismatch invalid state behavior?

2017-10-15 Thread Alexander Aring
Hi, I figure out some problem, easy to reproduce: # setup dummy $ modprobe dummy $ ip link set dummy0 up # issue $ ip route replace default via 169.254.65.37 dev dummy0 RTNETLINK answers: Network is unreachable so it will forbid me to do that, but: $ ip route replace 169.254.65.37 dev dummy0 $

[PATCH] ipv6: addrconf: Use normal debugging style

2017-10-15 Thread Joe Perches
Remove local ADBG macro and use netdev_dbg/pr_debug Miscellanea: o Remove unnecessary debug message after allocation failure as there already is a dump_stack() on the failure paths o Leave the allocation failure message on snmp6_alloc_dev as there is one code path that does not do a dump_stac

Re: [PATCH net-next 00/10] korina cleanups/optimizations

2017-10-15 Thread Roman Yeryomin
On 2017-10-15 19:38, Florian Fainelli wrote: On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin wrote: TX optimizations have led to ~15% performance increase (35->40Mbps) in local tx usecase (tested with iperf v3.2). Could you avoid empty commit messages and write a paragraph or two for each

Re: [PATCH net-next 00/10] korina cleanups/optimizations

2017-10-15 Thread Florian Fainelli
On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin wrote: >TX optimizations have led to ~15% performance increase (35->40Mbps) >in local tx usecase (tested with iperf v3.2). Could you avoid empty commit messages and write a paragraph or two for each commit that explains what and why are you chan

[PATCH net-next 10/10] net: korina: bump version

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 8fa60d1fe022..fc8e80487507 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ether

[PATCH net-next 07/10] net: korina: move tx to napi context

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 79 +++ 1 file changed, 20 insertions(+), 59 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index a076b0c49e6e..f606f1e01af1 100644 --- a/drivers/net

[PATCH net-next 09/10] net: korina: use dma api instead of dma_cache_* functions

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 44 ++- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 9520fa1e35a2..8fa60d1fe022 100644 --- a/drivers/net

[PATCH net-next 08/10] net: korina: optimize tx_full condition

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index f606f1e01af1..9520fa1e35a2 100644 --- a/drivers/net/ethernet/korina.c +++ b

[PATCH net-next 01/10] net: korina: optimize korina_send_packet logic

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 76 ++- 1 file changed, 24 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 7cecd9dbc111..84b2654e2d06 100644 --- a/drivers/net

[PATCH net-next 02/10] net: korina: reorder functions

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 317 +- 1 file changed, 158 insertions(+), 159 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 84b2654e2d06..5545f86aac4a 100644 --- a/drivers/n

[PATCH net-next 05/10] net: korina: remove unused korina_private members

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 64ae32af7539..59d4554c43c9 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @

[PATCH net-next 03/10] net: korina: introduce and use interrupt disable/enable helpers

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 83 +-- 1 file changed, 48 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 5545f86aac4a..04c1a3f38a79 100644 --- a/drivers/net

[PATCH net-next 00/10] korina cleanups/optimizations

2017-10-15 Thread Roman Yeryomin
TX optimizations have led to ~15% performance increase (35->40Mbps) in local tx usecase (tested with iperf v3.2). Roman Yeryomin (10): net: korina: optimize korina_send_packet logic net: korina: reorder functions net: korina: introduce and use interrupt disable/enable helpers net: korina:

[PATCH net-next 06/10] net: korina: optimize tx descriptor flags processing

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 59d4554c43c9..a076b0c49e6e 100644 --- a/drivers/net/ethernet/korina.c ++

[PATCH net-next 04/10] net: korina: optimize tx/rx interrupt handlers

2017-10-15 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 04c1a3f38a79..64ae32af7539 100644 --- a/drivers/net/ethernet/kor

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread David Ahern
On 10/15/17 9:59 AM, Ido Schimmel wrote: > On Sun, Oct 15, 2017 at 09:24:07AM -0600, David Ahern wrote: >> On 10/15/17 1:50 AM, Ido Schimmel wrote: >>> On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: ipv6_add_addr is called in process context with rtnl lock held (e.g., manual

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread Ido Schimmel
On Sun, Oct 15, 2017 at 09:24:07AM -0600, David Ahern wrote: > On 10/15/17 1:50 AM, Ido Schimmel wrote: > > On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: > >> ipv6_add_addr is called in process context with rtnl lock held > >> (e.g., manual config of an address) or during softirq pro

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-15 Thread Herbert Xu
On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: > > Changes from v8: > - Remove the translation of EAGAIN return code to the > previous return code of EBUSY for the user space > interface of algif as no one seems to rely on it as > requested by Herbert Xu. Sorry, but I forg

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread David Ahern
On 10/15/17 1:50 AM, Ido Schimmel wrote: > On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: >> ipv6_add_addr is called in process context with rtnl lock held >> (e.g., manual config of an address) or during softirq processing >> (e.g., autoconf and address from a router advertisement).

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-15 Thread Masahiro Yamada
2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > +static int ave_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + u32 ave_id; > + struct ave_private *priv; > + const struct ave_soc_data *data; >

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-15 Thread Paweł Staszewski
Previously attached graphs was for: 4.14.0-rc4-next-20171012 from git: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git In kernel drivers. Just tested by replacing cards in server from 8x10G based on 82599 to 02:00.0 Ethernet controller: Intel Corporation Ethernet Controller

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-10-15 Thread Masahiro Yamada
2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > DT bindings for the AVE ethernet controller found on Socionext's > UniPhier platforms. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > --- > .../bindings/net/socionext,uniphier-ave4.txt | 53 > ++ > 1 fil

Re: [PATCH] ipvs: Fix inappropriate output of procfs

2017-10-15 Thread Julian Anastasov
Hello, On Sun, 15 Oct 2017, KUWAZAWA Takuya wrote: > Information about ipvs in different network namespace can be seen via procfs. > > How to reproduce: > > # ip netns add ns01 > # ip netns add ns02 > # ip netns exec ns01 ip a add dev lo 127.0.0.1/8 > # ip netns exec ns02 ip a

[REGRESSION] rtl8723bs (r8723bs) WiFi stopped working on 4.14 on Chuwi Hi12 (Intel CherryTrail SoC)

2017-10-15 Thread Михаил Новоселов , ШЭМ Думалогия
Hello, I've found a regression in kernel 4.14, the last tested kernel was the yesterday daily build http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/ , it worked on 4.12 and 4.13 and now on 4.14 it is able to scan for available networks, but is not able to get an IP adress. I reported a bug t

Re: [PATCH net-next] ipv6: only update __use and lastusetime once per jiffy at most

2017-10-15 Thread Paolo Abeni
On Fri, 2017-10-13 at 17:09 -0700, Martin KaFai Lau wrote: > On Fri, Oct 13, 2017 at 10:08:07PM +, Wei Wang wrote: > > From: Wei Wang > > > > In order to not dirty the cacheline too often, we try to only update > > dst->__use and dst->lastusetime at most once per jiffy. > > > > As dst->last

[PATCH] ipvs: Fix inappropriate output of procfs

2017-10-15 Thread KUWAZAWA Takuya
Information about ipvs in different network namespace can be seen via procfs. How to reproduce: # ip netns add ns01 # ip netns add ns02 # ip netns exec ns01 ip a add dev lo 127.0.0.1/8 # ip netns exec ns02 ip a add dev lo 127.0.0.1/8 # ip netns exec ns01 ipvsadm -A -t 10.1.1.1:80 # ip

[PATCH net 4/6] rtnetlink: bring NETDEV_CHANGEUPPER event process back in rtnetlink_event

2017-10-15 Thread Xin Long
libteam needs this event notification in userspace when dev's master dev has been changed. After this, the redundant notifications issue would be fixed in the later patch 'rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink'. Fixes: b6b36eb23a46 ("rtnetlink: Do not generate notifications fo

[PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink

2017-10-15 Thread Xin Long
The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really work after status & DO_SETLINK_MODIFIED, as: DO_SETLINK_MODIFIED 0x1 DO_SETLINK_NOTIFY 0x3 Considering that notifications are suppposed to be sent only when status have the flag DO_SETLINK_NOTIFY, the right check would be:

[PATCH net 6/6] rtnetlink: do not set notification for tx_queue_len in do_setlink

2017-10-15 Thread Xin Long
NETDEV_CHANGE_TX_QUEUE_LEN event process in rtnetlink_event would send a notification for userspace and tx_queue_len's setting in do_setlink would trigger NETDEV_CHANGE_TX_QUEUE_LEN. So it shouldn't set DO_SETLINK_NOTIFY status for this change to send a notification any more. Signed-off-by: Xin L

[PATCH net 1/6] rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_event

2017-10-15 Thread Xin Long
Commit 085e1a65f04f ("rtnetlink: Do not generate notifications for MTU events") tried to fix the redundant notifications issue when ip link set mtu by removing NETDEV_CHANGEMTU event process in rtnetlink_event. But it also resulted in no notification generated when dev's mtu is changed via other m

[PATCH net 3/6] rtnetlink: bring NETDEV_POST_TYPE_CHANGE event process back in rtnetlink_event

2017-10-15 Thread Xin Long
As I said in patch 'rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_event', removing NETDEV_POST_TYPE_CHANGE event was not the right fix for the redundant notifications issue. So bring this event process back to rtnetlink_event and the old redundant notifications issue would be f

[PATCH net 2/6] rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN event process back in rtnetlink_event

2017-10-15 Thread Xin Long
The same fix for changing mtu in the patch 'rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_event' is needed for changing tx_queue_len. Note that the redundant notifications issue for tx_queue_len will be fixed in the later patch 'rtnetlink: do not send notification for tx_queue_

[PATCH net 0/6] rtnetlink: a bunch of fixes for userspace notifications in changing dev properties

2017-10-15 Thread Xin Long
Whenever any property of a link, address, route, etc. changes by whatever way, kernel should notify the programs that listen for such events in userspace. The patchet "rtnetlink: Cleanup user notifications for netdev events" tried to fix a redundant notifications issue, but it also introduced a si

RFC: making cn_proc work in {pid,user} namespaces

2017-10-15 Thread Aleksa Sarai
Hi all, At the moment, cn_proc is not usable by containers or container runtimes. In addition, all connectors have an odd relationship with init_net (for example, /proc/net/connectors only exists in init_net). There are two main use-cases that would be perfect for cn_proc, which is the reason

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-15 Thread Petr Vorel
Hi Mark, > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -1,6 +1,6 @@ > > -#!/bin/sh > > +#!/bin/bash > Funny - ^^^ choosing bash explicitly while > removing the bashism? Eh, this is really silly, sorry. I've sent a patc

[PATCH iproute2 1/1] tests: Revert back /bin/sh in shebang

2017-10-15 Thread Petr Vorel
This was added by mistake in commit ecd44e68 ("tests: Remove bashisms (s/source/.)") Signed-off-by: Petr Vorel --- testsuite/tests/ip/route/add_default_route.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/r

[PATCH v9 02/20] crypto: ccp: use -EAGAIN for transient busy indication

2017-10-15 Thread Gilad Ben-Yossef
Replace -EBUSY with -EAGAIN when reporting transient busy indication in the absence of backlog. Signed-off-by: Gilad Ben-Yossef Reviewed-by: Gary R Hook --- Please squash this patch with the previous one when merging upstream. drivers/crypto/ccp/ccp-crypto-main.c | 8 +++- drivers/crypto

[PATCH v9 00/20] simplify crypto wait for async op

2017-10-15 Thread Gilad Ben-Yossef
Many users of kernel async. crypto services have a pattern of starting an async. crypto op and than using a completion to wait for it to end. This patch set simplifies this common use case in two ways: First, by separating the return codes of the case where a request is queued to a backlog due to

[PATCH v9 03/20] net: use -EAGAIN for transient busy indication

2017-10-15 Thread Gilad Ben-Yossef
Replace -EBUSY with -EAGAIN when handling transient busy indication in the absence of backlog. Signed-off-by: Gilad Ben-Yossef --- Please squash this patch with the previous one when merging upstream. net/ipv4/ah4.c | 2 +- net/ipv4/esp4.c | 2 +- net/ipv6/ah6.c | 2 +- net/ipv6/esp6.c | 2

[PATCH v9 09/20] crypto: move drbg to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
DRBG is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating crypto request memory allocation may use GFP_KERNEL which should be perfectly fine as the code is obviously sleeping for

[PATCH v9 06/20] crypto: introduce crypto wait for async op

2017-10-15 Thread Gilad Ben-Yossef
Invoking a possibly async. crypto op and waiting for completion while correctly handling backlog processing is a common task in the crypto API implementation and outside users of it. This patch adds a generic implementation for doing so in preparation for using it across the board instead of hand

[PATCH v9 07/20] crypto: move algif to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
algif starts several async crypto ops and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/af_alg.c | 27 --- crypto/algif_aead.c | 8 crypto/algif_hash.c | 30 ++-

[PATCH v9 15/20] ima: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
ima starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 56 +++-- 1 file changed, 17 insertions(+), 39 deleti

[PATCH v9 11/20] crypto: move testmgr to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
testmgr is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also provides a test of the generic crypto async. wait code. Signed-off-by: Gilad Ben-Yossef --- crypto/testmgr.c | 204 ++---

[PATCH v9 13/20] dm: move dm-verity to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
dm-verity is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also avoids a future potential data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait prio

[PATCH v9 14/20] cifs: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
cifs starts an async. crypto op and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/fs/cif

[PATCH v9 12/20] fscrypt: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
fscrypt starts several async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- fs/crypto/crypto.c | 28 fs/crypto/fname.c | 36 ++-- fs/cry

[PATCH v9 20/20] crypto: adapt api sample to use async. op wait

2017-10-15 Thread Gilad Ben-Yossef
The code sample is waiting for an async. crypto op completion. Adapt sample to use the new generic infrastructure to do the same. This also fixes a possible data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait pr

[PATCH v9 19/20] crypto: mediatek: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
The mediatek driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Ryder Lee --- drivers/crypto/mediatek/mtk-aes.c | 31 +-- 1 file changed, 5 insertions(+), 26 d

[PATCH v9 17/20] crypto: talitos: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
The talitos driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/talitos.c | 38 +- 1 file changed, 5 insertions(+), 33 deletions(-) diff --git

[PATCH v9 18/20] crypto: qce: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
The qce driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/qce/sha.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/drivers/c

[PATCH v9 16/20] crypto: tcrypt: move to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
tcrypt starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/tcrypt.c | 84 + 1 file changed, 25 insertions(+), 59 deletions(-) diff --git

[PATCH v9 10/20] crypto: move gcm to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
gcm is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/gcm.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/crypto/gcm.c b/crypto/gcm.c index 8

[PATCH v9 08/20] crypto: move pub key to generic async completion

2017-10-15 Thread Gilad Ben-Yossef
public_key_verify_signature() is starting an async crypto op and waiting for it to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/asymmetric_keys/public_key.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) d

[PATCH v9 04/20] crypto: remove redundant backlog checks on EBUSY

2017-10-15 Thread Gilad Ben-Yossef
Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef --- crypto/ahash.c| 12 +++- crypto/cts.c | 6 ++ crypto/lrw.c

[PATCH v9 05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

2017-10-15 Thread Gilad Ben-Yossef
Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef Acked-by: Boris Brezillon --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/c

[PATCH v9 01/20] crypto: change transient busy return code to -EAGAIN

2017-10-15 Thread Gilad Ben-Yossef
The crypto API was using the -EBUSY return value to indicate both a hard failure to submit a crypto operation into a transformation provider when the latter was busy and the backlog mechanism was not enabled as well as a notification that the operation was queued into the backlog when the backlog m

RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

2017-10-15 Thread Yuval Mintz
> > >> This patchset adds a new hardware offload type in mqprio before > adding > > >> mqprio hardware offload support in hns3 driver. Apparently Dave has already acceptedAmirtha's changes to mqprio: https://marc.info/?l=linux-netdev&m=150803219824053&w=2 so I guess you need to revise your pa

Re: [PATCH net-next 4/5] mlxsw: spectrum: router: Add support for address validator notifier

2017-10-15 Thread Ido Schimmel
On Fri, Oct 13, 2017 at 04:02:12PM -0700, David Ahern wrote: > Add support for inetaddr_validator and inet6addr_validator. The > notifiers provide a means for validating ipv4 and ipv6 addresses > before the addresses are installed and on failure the error > is propagated back to the user. > > Sign

Re: [PATCH net-next 2/5] net: ipv6: Make inet6addr_validator a blocking notifier

2017-10-15 Thread Ido Schimmel
On Fri, Oct 13, 2017 at 04:02:10PM -0700, David Ahern wrote: > inet6addr_validator chain was added by commit 3ad7d2468f79f ("Ipvlan > should return an error when an address is already in use") to allow > address validation before changes are committed and to be able to > fail the address change wit

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread Ido Schimmel
On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: > ipv6_add_addr is called in process context with rtnl lock held > (e.g., manual config of an address) or during softirq processing > (e.g., autoconf and address from a router advertisement). > > Currently, ipv6_add_addr calls rcu_read_l