On Fri, Sep 22, 2017 at 09:49:10PM -0700, Y Song wrote:
> On Fri, Sep 22, 2017 at 9:23 AM, Edward Cree wrote:
> > On 22/09/17 16:16, Alexei Starovoitov wrote:
> >> looks like we're converging on
> >> "be16/be32/be64/le16/le32/le64 #register" for BPF_END.
> >> I guess it can live with that. I would
Currently, the aes_ccm.c and aes_gcm.c are almost line by line
copy of each other. This patch reduce code redundancy by moving
the code in these two files to crypto/aead_api.c to make it a
higher level aead api. The aes_ccm.c and aes_gcm.c are removed
and all the functions are now implemented in th
From: Zhu Yanjun
Date: Fri, 22 Sep 2017 10:20:21 -0400
> In the xmit/rx fastpath, the function dma_map_single rarely fails.
> Therefore, add an unlikely() optimization to this error check
> conditional.
>
> Signed-off-by: Zhu Yanjun
Applied to net-next, thanks.
From: Subash Abhinov Kasiviswanathan
Date: Thu, 21 Sep 2017 18:00:36 -0600
> Xiaolong reported a suspicious rcu_dereference_check in the device
> unregister notifier callback. Since we do not dereference the
> rx_handler_data, it's ok to just check for the value of the pointer.
> Note that this s
Hi Tom,
On Thu, Sep 21, 2017 at 09:43:02AM -0700, Tom Herbert wrote:
> Please see the cover letter for the original GTP kernel patches dated
> May 10, 2016. My first question on those was "Is there a timeline for
> adding IPv6 support?". To which Pablo replied that there was a
> preliminary patch
Hi Andreas,
On Wed, Sep 20, 2017 at 05:37:52PM +0200, Andreas Schultz wrote:
> I think we had this discussion before. The sending IP and port are not part
> of the identity of the PDP context. So IMHO the sender is permitted
> to change the source IP at random.
Thanks for the reminder: You are co
The kbuild test robot reports the following:
drivers/staging//rtlwifi/phydm/phydm_dig.c: In function 'odm_pause_dig':
drivers/staging//rtlwifi/phydm/phydm_dig.c:494:45: warning: array subscript
is below array bounds [-Warray-bounds]
odm_write_dig(dm, dig_tab->pause_dig_value[max_level]
From: Cong Wang
Date: Thu, 21 Sep 2017 16:43:00 -0700
> @@ -421,27 +427,6 @@ static int cls_bpf_set_parms(struct net *net, struct
> tcf_proto *tp,
> return 0;
> }
>
> -static u32 cls_bpf_grab_new_handle(struct tcf_proto *tp,
> -struct cls_bpf_head *head)
From: Christophe JAILLET
Date: Fri, 22 Sep 2017 01:01:11 +0200
> All the error handling paths 'goto error', except this one.
> We should also go to error in this case, or some resources will be
> leaking.
>
> Signed-off-by: Christophe JAILLET
Applied, thank you.
Eric Dumazet wrote:
> On Sat, 2017-09-23 at 21:26 +0200, Florian Westphal wrote:
> > Reviewed-by: David Ahern
> > Signed-off-by: Florian Westphal
> > ---
> > Changes since v3: don't add rtnl assertion, I placed the assertion
> > in my working tree instead as a reminder.
> >
> > net/core/rtne
On Sat, 2017-09-23 at 21:26 +0200, Florian Westphal wrote:
> Reviewed-by: David Ahern
> Signed-off-by: Florian Westphal
> ---
> Changes since v3: don't add rtnl assertion, I placed the assertion
> in my working tree instead as a reminder.
>
> net/core/rtnetlink.c | 11 +--
> 1 file ch
This patch fixes the following checkpatch.pl warning: fix
Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ...
then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Yurii Pavlenko
---
drivers/staging/irda/drivers/au1k_ir.c | 40 +++---
1 fi
Key length can't be negative.
Leave comparisons against nla_len() signed just in case truncated attribute
can sneak in there.
Space savings:
add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-7 (-7)
function old new delta
pneigh_delete
Neigh entry size can't be negative.
Space savings:
add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-7 (-7)
function old new delta
lowpan_neigh_construct25 24 -1
clip_seq_sub_iter
From: Eric Dumazet
As measured in my prior patch ("sch_netem: faster rb tree removal"),
rbtree_postorder_for_each_entry_safe() is nice looking but much slower
than using rb_next() directly, except when tree is small enough
to fit in CPU caches (then the cost is the same)
Also note that there is
This got rejected by gmail once. Let's see if it works now.
On Thursday, September 21, 2017 8:22:45 PM CEST Andrey Konovalov wrote:
> On Wed, Sep 20, 2017 at 9:55 PM, Johannes Berg
> wrote:
> > On Wed, 2017-09-20 at 21:27 +0200, Christian Lamparter wrote:
> >
> >> It seems this is caused as a res
Reviewed-by: David Ahern
Signed-off-by: Florian Westphal
---
Changes since v2:
this hunk was part of patch #4.
net/core/rtnetlink.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 625342d27c
Acked-by: David Ahern
Signed-off-by: Florian Westphal
---
Changes since v1: indent all lines with tabs, not spaces
tools/testing/selftests/net/rtnetlink.sh | 42
1 file changed, 42 insertions(+)
diff --git a/tools/testing/selftests/net/rtnetlink.sh
b/tools/te
Reviewed-by: David Ahern
Signed-off-by: Florian Westphal
---
Changes since v3: don't add rtnl assertion, I placed the assertion
in my working tree instead as a reminder.
net/core/rtnetlink.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b
it can be switched to rcu.
Reviewed-by: David Ahern
Signed-off-by: Florian Westphal
---
Changes since v2: remove ASSERT_RTNL.
net/core/rtnetlink.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index e858a2b48d7e..c69
similar to earlier patches, split out more parts of this function to
better see what is happening and where we assume rtnl is locked.
Reviewed-by: David Ahern
Signed-off-by: Florian Westphal
---
changes since v2: split this patch into two, last submission also
added netnsid helper, which was m
rtnl_fill_ifinfo currently requires caller to hold the rtnl mutex.
Unfortunately the function is quite large which makes it harder to see
which spots require the lock, which spots assume it and which ones could
do without.
Add helpers to factor out the ifindex dumping, one can use rcu to avoid
rtn
First patch adds a rudimentary vrf test case.
Remaining patches split large rtnl_fill_ifinfo into smaller chunks
to better see which parts
1. require rtnl
2. do not require it at all
3. rely on rtnl locking now but could be converted
I removed all the ASSERT_RTNL spots that v1 and v2 added,
i wi
Eric Dumazet wrote:
> On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote:
> > We can use rcu here to make this safe even if we would not hold rtnl:
> > qdisc_destroy uses call_rcu to free the Qdisc struct.
>
>
> Where do you see call_rcu() called from qdisc_destroy() ?
>
> You missed thi
From: Eric Dumazet
While running TCP tests involving netem storing millions of packets,
I had the idea to speed up tfifo_reset() and did experiments.
I tried the rbtree_postorder_for_each_entry_safe() method that is
used in skb_rbtree_purge() but discovered it was slower than the
current tfifo_r
On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote:
> We can use rcu here to make this safe even if we would not hold rtnl:
> qdisc_destroy uses call_rcu to free the Qdisc struct.
Where do you see call_rcu() called from qdisc_destroy() ?
You missed this commit I guess
752fbcc33405d6f8249
On 09/23/2017 09:57 AM, Colin King wrote:
> From: Colin Ian King
>
> Currently p->phy is being null checked in several places to avoid
> null pointer dereferences on p->phy, however, the final call
> to phy_attached_info on p->phy when p->phy will perform a null
> pointer dereference. Fix this
On 9/22/17 12:10 AM, Florian Westphal wrote:
> Switch it to rcu.
>
> rtnl_link_slave_info_fill on to other hand does need rtnl mutex for now so
> add an annotation to its caller as a reminder.
>
> Signed-off-by: Florian Westphal
> ---
> Change since v1:
> - don't add ASSERT_RTNL to rtnl_link_
On 9/22/17 12:10 AM, Florian Westphal wrote:
> ifalias is currently protected by rtnl mutex, add assertion
> as a reminder.
>
> Signed-off-by: Florian Westphal
> ---
> net/core/rtnetlink.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/rtnetlink
On Sat, 2017-09-23 at 17:57 +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently p->phy is being null checked in several places to avoid
> null pointer dereferences on p->phy, however, the final call
> to phy_attached_info on p->phy when p->phy will perform a null
> pointer dereference.
On 9/22/17 12:10 AM, Florian Westphal wrote:
> +static noinline_for_stack int rtnl_fill_vf(struct sk_buff *skb,
> +struct net_device *dev,
> +u32 ext_filter_mask)
> +{
> + struct nlattr *vfinfo;
> + int i, num_v
On 9/22/17 12:10 AM, Florian Westphal wrote:
> +kci_test_vrf()
> +{
> + vrfname="test-vrf"
> + ret=0
> +
> + ip link show type vrf 2>/dev/null
> + if [ $? -ne 0 ]; then
> + echo "SKIP: vrf: iproute2 too old"
> + return 0
> + fi
> +
> + ip link add "$v
On 9/22/17 12:10 AM, Florian Westphal wrote:
> We can use rcu here to make this safe even if we would not hold rtnl:
> qdisc_destroy uses call_rcu to free the Qdisc struct.
>
> Signed-off-by: Florian Westphal
> ---
> net/core/rtnetlink.c | 16 ++--
> 1 file changed, 14 insertions(+),
On 9/22/17 12:10 AM, Florian Westphal wrote:
> rtnl_fill_ifinfo currently requires caller to hold the rtnl mutex.
> Unfortunately the function is quite large which makes it harder to see
> which spots need the lock, which spots assume it and which ones could do
> without.
>
> Add helpers to factor
On 9/22/17 12:10 AM, Florian Westphal wrote:
> Cc: David Ahern
> Signed-off-by: Florian Westphal
> ---
> tools/testing/selftests/net/rtnetlink.sh | 42
>
> 1 file changed, 42 insertions(+)
Acked-by: David Ahern
From: Fathi Boudra
Date: Sat, 23 Sep 2017 14:27:15 +0300
> On 23 September 2017 at 04:20, David Miller wrote:
>> From: Orson Zhai
>> Date: Fri, 22 Sep 2017 18:17:17 +0800
>>
>>> The TPACKET_V3 test of PACKET_TX_RING will fail with kernel version
>>> lower than v4.11. Supported code of tx ring w
From: Colin Ian King
Currently p->phy is being null checked in several places to avoid
null pointer dereferences on p->phy, however, the final call
to phy_attached_info on p->phy when p->phy will perform a null
pointer dereference. Fix this by simply moving the call into
the previous code block t
On Fri, Sep 22, 2017 at 05:35:18PM -0700, Felix Manlunas wrote:
> From: Veerasenareddy Burru
This is kind of interesting. So you do this once. It could be before
the RTC driver has probed, so it is 1970. It could be before the NTP
daemon has started, and so the host clock will later jump, or stre
> > So when i look at these patches, i try to make sure the general use
> > cases works, not just the plain boring Ethernet switch box use cases
> > :-)
>
> So when doing it, we did think about multi-ASIC situations, so I think it
> should
> fit :)
Maybe, maybe not. DSA is multi switch. That is
From: yuan linyu
it seems no need to keep tun_get() and __tun_get() at same time.
Signed-off-by: yuan linyu
---
drivers/net/tun.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 3c9985f..206bc6c 100644
> The point is: Once both external ports are in "forwarding", I see no way
> to prevent traffic flowing directly between the external ports.
Generally, there are port vectors. Port X can send frames only to Port
Y.
If you don't have that, there are possibilities with VLANs. Each port
is given a u
On Sat, Sep 23, 2017 at 6:25 PM, Dan Carpenter wrote:
> Fundamentally, the "pos" pointer points to "cb->args[2]" which is a long.
> In the current code, we only use the high 32 bits and cast it as an
> int. That works on little endian systems but will fail on big endian
> systems.
>
> Fixes: d25a
On 23 September 2017 at 04:20, David Miller wrote:
> From: Orson Zhai
> Date: Fri, 22 Sep 2017 18:17:17 +0800
>
>> The TPACKET_V3 test of PACKET_TX_RING will fail with kernel version
>> lower than v4.11. Supported code of tx ring was add with commit id
>> <7f953ab2ba46: af_packet: TX_RING support
reset the driver's DCB state in couple of places
where it was missing.
Signed-off-by: Casey Leedom
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 15 +++
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h | 1 +
drivers/net/ethernet/chelsio/cxgb4/cx
Fundamentally, the "pos" pointer points to "cb->args[2]" which is a long.
In the current code, we only use the high 32 bits and cast it as an
int. That works on little endian systems but will fail on big endian
systems.
Fixes: d25adbeb0cdb ("sctp: fix an use-after-free issue in sctp_sock_dump")
S
Den 22. sep. 2017 22:08, skrev Andrew Lunn:
I'm wondering how this is supposed to work. Please add a good comment
here, since the hardware is forcing you to do something odd.
Maybe it would be a good idea to save the STP state in chip. And then
when chip->is_bridged is set true, change the stat
On 09/22/2017 04:21 PM, Andrew Lunn wrote:
> On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote:
>> On 09/21/2017 06:26 PM, Andrew Lunn wrote:
+static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,
+ struct mlxsw_sp_mr_route *mr_
47 matches
Mail list logo
