Re: TCP fast retransmit issues

2017-07-27 Thread Christoph Paasch
Hello, On Wed, Jul 26, 2017 at 7:32 AM, Eric Dumazet wrote: > On Wed, 2017-07-26 at 15:42 +0200, Willy Tarreau wrote: >> On Wed, Jul 26, 2017 at 06:31:21AM -0700, Eric Dumazet wrote: >> > On Wed, 2017-07-26 at 14:18 +0200, Klavs Klavsen wrote: >> > > the 192.168.32.44 is a Centos 7 box. >> > >> >

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread David.Wu
Hi Florian, 在 2017/7/28 0:54, Florian Fainelli 写道: - if you need knowledge about this PHY connection type prior to binding the PHY device and its driver (that is, before of_phy_connect()) we could add a boolean property e.g: "phy-is-internal" that allows us to know that, or we can have a new phy

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread David.Wu
Hi Andrew, 在 2017/7/27 21:48, Andrew Lunn 写道: I think we need to discuss this. This PHY appears to be on an MDIO bus, it uses a standard PHY driver, and it appears to be using an RMII interface. So it is just an ordinary PHY. Internal is supposed to be something which is not ordinary, does not

Re: TCP fast retransmit issues

2017-07-27 Thread Klavs Klavsen
The network guys know what caused it. Appearently on (atleast some) Cisco equipment the feature: TCP Sequence Number Randomization is enabled by default. It would most definetely be beneficial if Linux handled SACK "not working" better than it does - but then I might never have found the cu

Re: After a while of system running no incoming UDP any more?

2017-07-27 Thread Marc Haber
On Mon, Jul 24, 2017 at 04:19:10PM +0200, Paolo Abeni wrote: > Once that a system enter the buggy status, do the packets reach the > relevant socket's queue? > > ss -u > nstat |grep -e Udp -e Ip > > will help checking that. I now have the issue on one machine, a Xen guest acting as authoritative

[PATCH] netfilter: SYNPROXY: fix process non tcp packet bug in {ipv4,ipv6}_synproxy_hook

2017-07-27 Thread Lin Zhang
In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, but the real server maybe reply an icmp error packet related to the exist tcp conntrack, so we will access wrong tcp data. For fix it, we simply pass IP_CT_RELATED_REPLY packets. Signed-off-by: Lin Zhang --- net/ipv4/netfilte

Re: [RFC] switchdev: generate phys_port_name in the core

2017-07-27 Thread Jiri Pirko
Fri, Jul 28, 2017 at 07:35:07AM CEST, j...@resnulli.us wrote: >Fri, Jul 28, 2017 at 04:31:22AM CEST, jakub.kicin...@netronome.com wrote: >>On Thu, 27 Jul 2017 13:30:44 +0300, Or Gerlitz wrote: >>> > want to add port splitting support, for example, reporting the name on >>> > physical ports will bec

Re: [RFC] switchdev: generate phys_port_name in the core

2017-07-27 Thread Jiri Pirko
Fri, Jul 28, 2017 at 04:31:22AM CEST, jakub.kicin...@netronome.com wrote: >On Thu, 27 Jul 2017 13:30:44 +0300, Or Gerlitz wrote: >> > want to add port splitting support, for example, reporting the name on >> > physical ports will become more of a necessity. >> >> > If we adopt Jiri's suggestion

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Kurt Van Dijck
> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec r

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-27 Thread Cong Wang
On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: > On 7/26/17 12:27 PM, Roopa Prabhu wrote: >> agreed...so looks like the check in v3 should be >> >> >> + if ( rt == net->ipv6.ip6_null_entry || >> +(rt->dst.error && >> + #ifdef CONFIG_IPV6_MULTIPLE_TABLES >> + rt

Re: Possible race in hysdn.ko

2017-07-27 Thread isdn
Hello Anton, first of all, this code was developed by other people and I never managed to get one of these cards - so I do not know so much about this driver at all. Unfortunately the firm behind hysdn do not longer exist and was taken over by Hermstedt AG years ago and even Hermstedt AG is not lo

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-27 Thread Leon Romanovsky
On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM > > To: Salil Mehta > > Cc: da...@da

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-07-27 Thread Andrew Lunn
On Thu, Jul 27, 2017 at 06:49:05PM -0700, Antoine Tenart wrote: > Hi Andrew, > > On Wed, Jul 26, 2017 at 06:08:06PM +0200, Andrew Lunn wrote: > > On Mon, Jul 24, 2017 at 03:48:33PM +0200, Antoine Tenart wrote: > > > > > > + if (priv->hw_version != MVPP22) > > > + return 0; > > > + > > >

Dear Talented

2017-07-27 Thread Kim Sharma
Dear Talented, I am Talent Scout For BLUE SKY FILM STUDIO, Present Blue sky Studio a Film Corporation Located in the United State, is Soliciting for the Right to use Your Photo/Face and Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED Stereoscope 3D Movie-The Story of

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 11:50:45AM +0800, Jason Wang wrote: > > > On 2017年07月28日 11:46, Michael S. Tsirkin wrote: > > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > > + if (old_prog) > > > > > + bpf_p

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jakub Kicinski
On Fri, 28 Jul 2017 06:46:40 +0300, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > + if (old_prog) > > > > + bpf_prog_put(old_prog); > > > > + rcu_assign_pointer(tu

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jason Wang
On 2017年07月28日 11:46, Michael S. Tsirkin wrote: On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: + old_prog = rtnl_dereference(tun->xdp_prog); + if (old_prog) + bpf_prog_put(old_prog); + rcu_assign_pointer(tun->xdp_prog, prog); Is this OK? Could thi

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > + if (old_prog) > > > + bpf_prog_put(old_prog); > > > + rcu_assign_pointer(tun->xdp_prog, prog); > > Is this OK? Could this lead to the program getting freed and then > > d

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jason Wang
On 2017年07月28日 11:13, Jakub Kicinski wrote: On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX, sin

Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 18:11:32 +, Levin, Alexander (Sasha Levin) wrote: > This is useful for directly looking up a task based on class id rather than > having to scan through all open file descriptors. > > Signed-off-by: Sasha Levin > --- > > Changes in V2: > - Addressed comments from Cong Wa

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were c

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Ding Tianhong
On 2017/7/28 1:49, Alexander Duyck wrote: > On Wed, Jul 26, 2017 at 6:08 PM, Ding Tianhong > wrote: >> >> >> On 2017/7/27 2:26, Casey Leedom wrote: >>> By the way Ding, two issues: >>> >>> 1. Did we ever get any acknowledgement from either Intel or AMD >>> on this patch? I know that we

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Ding Tianhong
On 2017/7/28 2:42, Raj, Ashok wrote: > Hi Casey > >> | Still no Intel and AMD guys has ack this, this is what I am worried about, >> | should I ping some man again ? > > > I can ack the patch set for Intel specific changes. Now that the doc is made > public :-). > Good, Thanks. :) > Can you

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Ding Tianhong
On 2017/7/28 1:44, Casey Leedom wrote: > | From: Ding Tianhong > | Sent: Wednesday, July 26, 2017 6:01 PM > | > | On 2017/7/27 3:05, Casey Leedom wrote: > | > > | > Ding, send me a note if you'd like me to work that [cxgb4vf patch] up > | > for you. > | > | Ok, you could send the change log and

Re: [RFC] switchdev: generate phys_port_name in the core

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 19:31:22 -0700, Jakub Kicinski wrote: > +static size_t rtnl_port_info_size(void) > +{ > + size_t port_info_size = nla_total_size(0) + /* nest IFLA_PORT_INFO */ nla_total_size(4) + /* TYPE */ > + nla_total_size(4)

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: > From: Roopa Prabhu > > Forward Error Correction (FEC) modes i.e Base-R > and Reed-Solomon modes are introduced in 25G/40G/100G standards > for providing good BER at high speeds. Various networking devices > which support 25G/40G/100G provi

[RFC] switchdev: generate phys_port_name in the core

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 13:30:44 +0300, Or Gerlitz wrote: > > want to add port splitting support, for example, reporting the name on > > physical ports will become more of a necessity. > > > If we adopt Jiri's suggestion of returning structured data it will be > > very easy to give user space type a

Re: [PATCH net-next 08/18] net: mvpp2: make the phy optional

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:20:00PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:38PM +0200, Antoine Tenart wrote: > > SFP ports do not necessarily need to have an Ethernet PHY between the > > SoC and the actual physical port. However, the driver currently makes > > the "phy

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:08:06PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:33PM +0200, Antoine Tenart wrote: > > > > + if (priv->hw_version != MVPP22) > > + return 0; > > + > > + /* Set the SMI PHY address */ > > + if (of_property_read_u32(port->phy_n

Re: [PATCH net-next 04/18] net: mvpp2: move the mii configuration in the ndo_open path

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:11:11PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:34PM +0200, Antoine Tenart wrote: > > This moves the mii configuration in the ndo_open path, to allow handling > > different mii configurations later and to switch between these > > configuratio

Re: [PATCH v4 net-next] net: systemport: Support 64bit statistics

2017-07-27 Thread Florian Fainelli
On 07/27/2017 05:43 PM, Jianming.qiao wrote: > When using Broadcom Systemport device in 32bit Platform, ifconfig can > only report up to 4G tx,rx status, which will be wrapped to 0 when the > number of incoming or outgoing packets exceeds 4G, only taking > around 2 hours in busy network environment

[PATCH v4 net-next] net: systemport: Support 64bit statistics

2017-07-27 Thread Jianming.qiao
When using Broadcom Systemport device in 32bit Platform, ifconfig can only report up to 4G tx,rx status, which will be wrapped to 0 when the number of incoming or outgoing packets exceeds 4G, only taking around 2 hours in busy network environment (such as streaming). Therefore, it makes hard for ne

Re: [PATCH v3 net-next 0/2] liquidio: standardization and cleanup

2017-07-27 Thread David Miller
From: Felix Manlunas Date: Wed, 26 Jul 2017 12:09:45 -0700 > From: Rick Farrington > > This patchset corrects some non-standard macro usage. > > 1. Replaced custom MIN macro with use of standard 'min_t'. > 2. Removed cryptic and misleading macro 'CAST_ULL'. > > change log: > V1 -> V2: > 1.

Re: [PATCH net-next] net: phy: Remove stale comments referencing timer

2017-07-27 Thread David Miller
From: Florian Fainelli Date: Wed, 26 Jul 2017 12:05:38 -0700 > Since commit a390d1f379cf ("phylib: convert state_queue work to > delayed_work"), the PHYLIB state machine was converted to use delayed > workqueues, yet some functions were still referencing the PHY library > timer in their comments,

Re: [PATCH net-next 0/3] nfp: extend firmware request logic

2017-07-27 Thread David Miller
From: Jakub Kicinski Date: Wed, 26 Jul 2017 11:09:45 -0700 > We have been pondering for some time how to support loading different > application firmwares onto NFP. We want to support both users selecting > one of the firmware images provided by Netronome (which are optimized > for different use

Re: [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS

2017-07-27 Thread David Miller
From: Arnd Bergmann Date: Wed, 26 Jul 2017 17:13:59 +0200 > I still see build errors in randconfig builds and have had this > patch for a while to locally work around it: > > drivers/built-in.o: In function `xgene_mdio_probe': > mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_reg

Re: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency

2017-07-27 Thread David Miller
From: Arnd Bergmann Date: Wed, 26 Jul 2017 17:14:00 +0200 > The driver attempts to 'select MDIO_DEVICE', but the code > is actually a loadable module when PHYLIB=m: > > drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function > `bcm_ns_usb3_mdiodev_phy_write': > phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_

[PATCH net-next v2 1/3] net: ethtool: add support for forward error correction modes

2017-07-27 Thread Roopa Prabhu
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FE

[PATCH net-next v2 3/3] cxgb4: ethtool forward error correction management support

2017-07-27 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c index 26eb0

[PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-27 Thread Roopa Prabhu
From: Roopa Prabhu Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FEC encodi

[PATCH net-next v2 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

2017-07-27 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152 ++--- 1 file changed, 117 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index db41

RE: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-27 Thread Salil Mehta
Hi Leon > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Sunday, July 23, 2017 2:16 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil

[RFC PATCH net-next 3/6] tcp: remove low_latency sysctl

2017-07-27 Thread Florian Westphal
this option was used by the removed prequeue code, it has no effect anymore. Signed-off-by: Florian Westphal --- Documentation/networking/ip-sysctl.txt | 7 +-- include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 3 +++ net/ipv4/tcp_ipv4.c

[RFC PATCH net-next 2/6] tcp: reindent two spots after prequeue removal

2017-07-27 Thread Florian Westphal
These two branches are now always true, remove the conditional. objdiff shows no changes. Signed-off-by: Florian Westphal --- net/ipv4/tcp_input.c | 50 +++--- 1 file changed, 23 insertions(+), 27 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/i

[RFC PATCH net-next 5/6] tcp: remove CA_ACK_SLOWPATH

2017-07-27 Thread Florian Westphal
re-indent tcp_ack, and remove CA_ACK_SLOWPATH; it is always set now. Signed-off-by: Florian Westphal --- include/net/tcp.h | 5 ++--- net/ipv4/tcp_input.c| 35 --- net/ipv4/tcp_westwood.c | 31 --- 3 files changed, 22 inserti

[RFC PATCH net-next 4/6] tcp: remove header prediction

2017-07-27 Thread Florian Westphal
Like prequeue, I am not sure this is overly useful nowadays. If we receive a train of packets, GRO will aggregate them if the headers are the same (HP predates GRO by several years) so we don't get a per-packet benefit, only a per-aggregated-packet one. Signed-off-by: Florian Westphal --- inclu

[RFC PATCH net-next 6/6] tcp: remove unused mib counters

2017-07-27 Thread Florian Westphal
was used by tcp prequeue, TCPFORWARDRETRANS use was removed in january. Signed-off-by: Florian Westphal --- include/uapi/linux/snmp.h | 8 net/ipv4/proc.c | 8 2 files changed, 16 deletions(-) diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h index d

[RFC net-next 0/6] tcp: remove prequeue and header prediction

2017-07-27 Thread Florian Westphal
This RFC removes tcp prequeueing and header prediction support. After a hallway discussion with Eric Dumazet some maybe-not-so-useful-anymore TCP stack features came up, HP and Prequeue among these. So this RFC proposes to axe both. In brief, TCP prequeue assumes a single-process-blocking-read d

[RFC PATCH net-next 1/6] tcp: remove prequeue support

2017-07-27 Thread Florian Westphal
prequeue is a tcp receive optimization that moves part of rx processing from bh to process context. This only works if the socket being processed belongs to a process that blocks in recv on this socket. In practice, this doesn't happen anymore that often, as servers normally use an event driven (

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/27/2017 02:39 PM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: >> This change causes boot failures for me on my APM Mustang system running >> Fedora rawhide: >> >> [ 16.669089] Synchronous External Abort: synchronous external abort >> (0x960 >

Re: [PATCH v3 1/3] ptp: introduce ptp auxiliary worker

2017-07-27 Thread Grygorii Strashko
On 07/27/2017 03:08 PM, Richard Cochran wrote: On Wed, Jul 26, 2017 at 05:11:36PM -0500, Grygorii Strashko wrote: @@ -217,6 +231,19 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, mutex_init(&ptp->pincfg_mux); init_waitqueue_head(&ptp->tsev_wq); + if (p

[PATCH] net: tc35815: fix spelling mistake: "Intterrupt" -> "Interrupt"

2017-07-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in printk message Signed-off-by: Colin Ian King --- drivers/net/ethernet/toshiba/tc35815.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c i

[PATCH] wl3501_cs: fix spelling mistake: "Insupported" -> "Unsupported"

2017-07-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in printk message Signed-off-by: Colin Ian King --- drivers/net/wireless/wl3501_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c index acec0d9ec422..

[PATCH] mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

2017-07-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in mwifiex_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/mwifiex/tdls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireles

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: > This change causes boot failures for me on my APM Mustang system running > Fedora rawhide: > > [ 16.669089] Synchronous External Abort: synchronous external abort > (0x960 > [ 16.669099] Internal error: : 9610 [#1] SMP

Re: Performance regression with virtio_net

2017-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 04:14:30PM -0500, Seth Forshee wrote: > On Thu, Jul 27, 2017 at 11:38:52PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2017 at 12:09:42PM -0500, Seth Forshee wrote: > > > I'm seeing a performance regression with virtio_net that looks to have > > > started in 4.12-rc

Re: Performance regression with virtio_net

2017-07-27 Thread Seth Forshee
On Thu, Jul 27, 2017 at 11:38:52PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 27, 2017 at 12:09:42PM -0500, Seth Forshee wrote: > > I'm seeing a performance regression with virtio_net that looks to have > > started in 4.12-rc1. I only see it in one context though, downloading > > snap packages

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Franklin S Cooper Jr
On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: >> > >> I'm fine with switching to using bitrate instead of speed. Kurk was >> originally the one that suggested to use the term arbitration and data >> since thats how the spec refers to it. Whi

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/13/2017 01:57 AM, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > This change fixes following problem > > [1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 > > which leads to a missing ethernet interface (reproducable at least on > Gigabyte MP30-AR0 and

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-27 Thread Salil Mehta
Hi Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, July 27, 2017 7:05 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vg

RE: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-27 Thread Salil Mehta
Hi Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Sunday, July 23, 2017 6:24 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger

Re: Performance regression with virtio_net

2017-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 12:09:42PM -0500, Seth Forshee wrote: > I'm seeing a performance regression with virtio_net that looks to have > started in 4.12-rc1. I only see it in one context though, downloading > snap packages from the Ubuntu snap store. For example: > > > https://api.snapcraft.io/a

Re: [PATCH V2 net] Revert "vhost: cache used event for better performance"

2017-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 11:22:05AM +0800, Jason Wang wrote: > This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it > was reported to break vhost_net. We want to cache used event and use > it to check for notification. The assumption was that guest won't move > the event idx back,

Re: [PATCH v3 1/3] ptp: introduce ptp auxiliary worker

2017-07-27 Thread Richard Cochran
On Wed, Jul 26, 2017 at 05:11:36PM -0500, Grygorii Strashko wrote: > @@ -217,6 +231,19 @@ struct ptp_clock *ptp_clock_register(struct > ptp_clock_info *info, > mutex_init(&ptp->pincfg_mux); > init_waitqueue_head(&ptp->tsev_wq); > > + if (ptp->info->do_aux_work) { > +

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread Roopa Prabhu
On Thu, Jul 27, 2017 at 9:25 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the rt->dst.error check. > > Bef

[PATCH net-next] liquidio: bump up driver version to match newer NIC firmware

2017-07-27 Thread Felix Manlunas
Bump up driver version to match newer NIC firmware. Also update nic_rx_stats (a struct common to host driver and firmware) by adding a new field: fw_total_fwd_bytes. Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 5 +++

I NEED YOUR URGENT HELP AND CORPERATION

2017-07-27 Thread IBRAHIM KABORE
Dear Friend I am contacting you on a business deal of $9,500,000.00 Million United States Dollars, ready for transfer into your own personal account and if we make this claim, we will share it on the ratio of 50% / 50% basis, I would like to assure you that it be 100% risk free and it will be l

[PATCH net] bpf: don't indicate success when copy_from_user fails

2017-07-27 Thread Daniel Borkmann
err in bpf_prog_get_info_by_fd() still holds 0 at that time from prior check_uarg_tail_zero() check. Explicitly return -EFAULT instead, so user space can be notified of buggy behavior. Fixes: 1e2709769086 ("bpf: Add BPF_OBJ_GET_INFO_BY_FD") Signed-off-by: Daniel Borkmann --- kernel/bpf/syscall.c

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Oliver Hartkopp
On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: I'm fine with switching to using bitrate instead of speed. Kurk was originally the one that suggested to use the term arbitration and data since thats how the spec refers to it. Which I do agree with. But your right that in the drivers (stru

Re: [PATCH RFC 11/13] phylink: add support for MII ioctl access to Clause 45 PHYs

2017-07-27 Thread Andrew Lunn
On Tue, Jul 25, 2017 at 03:03:28PM +0100, Russell King wrote: > Add support for reading and writing the clause 45 MII registers. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Raj, Ashok
Hi Casey > | Still no Intel and AMD guys has ack this, this is what I am worried about, > | should I ping some man again ? I can ack the patch set for Intel specific changes. Now that the doc is made public :-). Can you/Ding resend the patch series, i do have the most recent v7, some of the com

RE: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Wyborny, Carolyn
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Florian Fainelli > Sent: Thursday, July 27, 2017 10:58 AM > To: Andrew Lunn ; Brown, Aaron F > > Cc: John W. Linville ; netdev@vger.kernel.org; intel- > wired-...@lists.osuosl.or

Re: [PATCHv2 iproute2] utils: return default family when rtm_family is not RTNL_FAMILY_IPMR/IP6MR

2017-07-27 Thread Stephen Hemminger
On Thu, 27 Jul 2017 12:03:02 +0200 Phil Sutter wrote: > On Thu, Jul 27, 2017 at 05:44:15PM +0800, Hangbin Liu wrote: > > When we get a multicast route, the rtm_type is RTN_MULTICAST, but the > > rtm_family may be AF_INET. If we only check the type with RTNL_FAMILY_IPMR, > > we will get malformed

Re: [PATCH] netns: more input validation

2017-07-27 Thread Stephen Hemminger
On Tue, 25 Jul 2017 15:30:31 +0200 Matteo Croce wrote: > ip netns accepts invalid input as namespace name like an empty string or a > string longer than the maximum file name length. > Check that the netns name is not empty and less than or equal to NAME_MAX. > > Signed-off-by: Matteo Croce Su

Re: [PATCH iproute2] geneve: support for modifying geneve device

2017-07-27 Thread Stephen Hemminger
On Tue, 25 Jul 2017 19:11:43 -0700 Girish Moodalbail wrote: > Ability to change geneve device attributes was added to kernel through > commit 5b861f6baa3a ("geneve: add rtnl changelink support"), however one > cannot do the same through ip-link(8) command. Changing the allowed > geneve device at

Re: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Andrew Lunn
> I recall someone mentioning that there were plans to have phylib support > [Q]SFP[+] modules as well. I am very interested in that work, if someone > has patches/plans I would like to take a look. Hi Jon The first part was posted yesterday: https://www.spinics.net/lists/netdev/msg445767.html

[PATCH v2] net: inet: diag: expose sockets cgroup classid

2017-07-27 Thread Levin, Alexander (Sasha Levin)
This is useful for directly looking up a task based on class id rather than having to scan through all open file descriptors. Signed-off-by: Sasha Levin --- Changes in V2: - Addressed comments from Cong Wang (use nla_put_u32()) include/uapi/linux/inet_diag.h | 1 + net/ipv4/inet_diag.c

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-27 Thread Florian Fainelli
On 07/27/2017 11:01 AM, Salil Mehta wrote: > Hi Florian, > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Sunday, July 23, 2017 6:05 PM >> To: Salil Mehta; da...@davemloft.net >> Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); >> mehta.salil@gm

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread David Ahern
On 7/27/17 10:25 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the rt->dst.error check. > > Before fix: >

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-27 Thread Salil Mehta
Hi Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Sunday, July 23, 2017 6:05 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger

Re: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Florian Fainelli
On 07/27/2017 08:37 AM, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 12:40:01AM +, Brown, Aaron F wrote: >>> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >>> Of John W. Linville >>> Sent: Friday, July 21, 2017 11:12 AM >>> To: netdev@vger.kernel.org >>> Cc: intel-

RE: [PATCH V4 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-27 Thread Salil Mehta
Hi Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Sunday, July 23, 2017 5:54 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Alexander Duyck
On Wed, Jul 26, 2017 at 6:08 PM, Ding Tianhong wrote: > > > On 2017/7/27 2:26, Casey Leedom wrote: >> By the way Ding, two issues: >> >> 1. Did we ever get any acknowledgement from either Intel or AMD >> on this patch? I know that we can't ensure that, but it sure would >> be nice sinc

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Casey Leedom
| From: Ding Tianhong | Sent: Wednesday, July 26, 2017 6:01 PM | | On 2017/7/27 3:05, Casey Leedom wrote: | > | > Ding, send me a note if you'd like me to work that [cxgb4vf patch] up | > for you. | | Ok, you could send the change log and I could put it in the v8 version | together, will you base

Re: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Jonathan Toppins
On 07/27/2017 11:37 AM, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 12:40:01AM +, Brown, Aaron F wrote: >>> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >>> Of John W. Linville >>> Sent: Friday, July 21, 2017 11:12 AM >>> To: netdev@vger.kernel.org >>> Cc: intel-

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread Corentin Labbe
On Thu, Jul 27, 2017 at 09:54:01AM -0700, Florian Fainelli wrote: > On 07/27/2017 06:48 AM, Andrew Lunn wrote: > > On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: > >> To make internal phy work, need to configure the phy_clock, > >> phy cru_reset and related registers. > >> > >> Signed-of

Performance regression with virtio_net

2017-07-27 Thread Seth Forshee
I'm seeing a performance regression with virtio_net that looks to have started in 4.12-rc1. I only see it in one context though, downloading snap packages from the Ubuntu snap store. For example: https://api.snapcraft.io/api/v1/snaps/download/b8X2psL1ryVrPt5WEmpYiqfr5emixTd7_1797.snap which red

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread Florian Fainelli
On 07/27/2017 06:48 AM, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: >> To make internal phy work, need to configure the phy_clock, >> phy cru_reset and related registers. >> >> Signed-off-by: David Wu >> --- >> changes in v2: >> - Use the standard "phy-mode" pro

Re: [PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-27 Thread Florian Fainelli
On 07/27/2017 05:55 AM, David Wu wrote: > Support internal ephy currently. > > Signed-off-by: David Wu > --- > changes in v2: > - Alphabetic order for Kconfig and Makefile. > - Add analog register init. > - Disable auto-mdix for workround. > - Rename config > > drivers/net/phy/Kconfig|

Re: [PATCH net] xen-netback: correctly schedule rate-limited queues

2017-07-27 Thread David Miller
From: Jean-Louis Dupond Date: Thu, 27 Jul 2017 10:21:56 +0200 > Op 2017-06-22 17:16, schreef David Miller: >> From: Wei Liu >> Date: Wed, 21 Jun 2017 10:21:22 +0100 >> >>> Add a flag to indicate if a queue is rate-limited. Test the flag in >>> NAPI poll handler and avoid rescheduling the queue

[PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread Hangbin Liu
After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly instead of dump route info. Fix it by remove the rt->dst.error check. Before fix: \# ip -6 route add prohibit 2003::/64 dev eth1 \# ip -6

Possible race in hysdn.ko

2017-07-27 Thread Anton Volkov
Hello. While searching for races in the Linux kernel I've come across "drivers/isdn/hysdn/hysdn.ko" module. Here is a question that I came up with while analysing results. Lines are given using the info from Linux v4.12. In hysdn_proclog.c file in put_log_buffer function a non-standard type of s

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-27 Thread Hangbin Liu
Hi David, On Wed, Jul 26, 2017 at 01:00:26PM -0600, David Ahern wrote: > >> I don't think so. If I add a prohibit route and use the fibmatch > >> attribute, I want to see the route from the FIB that was matched. > > > > > > yes, exactly. wouldn't 'rt != net->ipv6.ip6_prohibit_entry' above let >

RE: [PATCH V4 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS

2017-07-27 Thread Salil Mehta
Hi Leon, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Sunday, July 23, 2017 2:12 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil...

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-27 Thread Salil Mehta
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Sunday, July 23, 2017 6:26 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker.

Re: qmi_wwan: Null pointer dereference when removing driver

2017-07-27 Thread Nathaniel Roach
At some point in the suspend procedure the error occurs, so the first suspend works but subsequent ones fail with something like "timeout waiting for processes to suspend". I just assumed it happened before the suspend happens but was too late to be a hindrance. Presumably the driver dies duri

Re: qmi_wwan: Null pointer dereference when removing driver

2017-07-27 Thread Dan Williams
On Thu, 2017-07-27 at 13:31 +0800, Nathaniel Roach wrote: > Unsure at which point was added, but issue not present in stock > debian 4.11 kernel. > > Running on a Thinkpad X220 with coreboot. > > I'm building from upstream. When I attempt to remove the qmi_wwan > module (which also happens pre-su

Re: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Andrew Lunn
On Thu, Jul 27, 2017 at 12:40:01AM +, Brown, Aaron F wrote: > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > > Of John W. Linville > > Sent: Friday, July 21, 2017 11:12 AM > > To: netdev@vger.kernel.org > > Cc: intel-wired-...@lists.osuosl.org; John W. Linville

Re: [PATCH net-next v2 07/10] net: dsa: lan9303: Added basic offloading of unicast traffic

2017-07-27 Thread Egil Hjelmeland
On 27. juli 2017 15:31, Andrew Lunn wrote: I think you are over-simplifying here. Say i have a layer 2 VPN and i bridge port 1 and the VPN? The software bridge still wants to do STP on port 1, in order to solve loops. Problem is that the mainline lan9303_separate_ports() does its work by setti

[net V2 14/14] net/mlx5: Fix mlx5_add_flow_rules call with correct num of dests

2017-07-27 Thread Saeed Mahameed
From: Paul Blakey When adding ethtool steering rule with action DISCARD we wrongly pass a NULL dest with dest_num 1 to mlx5_add_flow_rules(). What this error seems to have caused is sending VPORT 0 (MLX5_FLOW_DESTINATION_TYPE_VPORT) as the fte dest instead of no dests. We have fte action correctl

  1   2   >