[PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X

2017-07-18 Thread Martin Hundebøll
Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390 ports 9 & 10') added support for setting the CMODE for the 6390X family, but only enabled it for 9290 and 6390 - and left out 6390X. Fix support for setting the CMODE on 6390X also by assigning mv88e6390x_port_set_cmode() to t

[PATCH] net/sunrpc/xprt_sock: fix regression in connection error reporting.

2017-07-18 Thread NeilBrown
Commit 3d4762639dd3 ("tcp: remove poll() flakes when receiving RST") in v4.12 changed the order in which ->sk_state_change() and ->sk_error_report() are called when a socket is shut down - sk_state_change() is now called first. This causes xs_tcp_state_change() -> xs_sock_mark_closed() -> xprt_di

Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()

2017-07-18 Thread Sean Wang
On Tue, 2017-07-18 at 15:48 -0500, Gustavo A. R. Silva wrote: > Remove useless local variable _condition_ and the code related. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread Jason Wang
On 2017年07月19日 04:13, Michael S. Tsirkin wrote: On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote: Hi: This series brings two optimizations for virtio-net XDP: - avoid reset during XDP set - turn off offloads on demand I'm glad to see this take shape - this can be extended to optim

Re: [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on XDP set

2017-07-18 Thread Jason Wang
On 2017年07月19日 04:07, Michael S. Tsirkin wrote: On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: Current XDP implementation want guest offloads feature to be disabled s/want/wants/ on qemu cli. on the device. This is inconvenient and means guest can't benefit from offloads if

Re: [PATCH net-next 4/5] virtio-net: do not reset during XDP set

2017-07-18 Thread Jason Wang
On 2017年07月19日 03:49, Michael S. Tsirkin wrote: On Mon, Jul 17, 2017 at 08:44:00PM +0800, Jason Wang wrote: We used to reset during XDP set, the main reason is we need allocate extra headroom for header adjustment but there's no way to know the headroom of exist receive buffer. This works buy

Re: [PATCH net-next 3/5] virtio-net: switch to use new ctx API for small buffer

2017-07-18 Thread Jason Wang
On 2017年07月19日 03:20, Michael S. Tsirkin wrote: what's needed is ability to store the headroom there. virtio-net: switch to use ctx API for small buffers Use ctx API to store headroom for small buffers. Following patches will retrieve this info and use it for XDP. On Mon, Jul 17, 2017 at 08:

Re: [PATCH net-next 2/5] virtio-net: pack headroom into ctx for mergeable buffer

2017-07-18 Thread Jason Wang
On 2017年07月19日 02:59, Michael S. Tsirkin wrote: On Mon, Jul 17, 2017 at 08:43:58PM +0800, Jason Wang wrote: Pack headroom into ctx, then during XDP set, we could know the size of headroom and copy if needed. This is required for avoiding reset on XDP. Not really when XDP is set - it's when bu

[PATCH ethtool net] ethtool: fix the rx vs tx mixup in set channel message

2017-07-18 Thread Jakub Kicinski
When set channels (ethtool -L) doesn't modify any settings a message is printed which contains the current parameters: # ethtool -L em1 no channel parameters changed, aborting current values: tx 4 rx 1 other 0 combined 0 or # ethtool -L em1 rx 4 rx unmodified, ignoring no channel parameters chan

Re: [PATCH] rtlwifi: remove useless code

2017-07-18 Thread Larry Finger
On 07/18/2017 03:41 PM, Gustavo A. R. Silva wrote: Remove useless local variables last_read_point and last_txw_point and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 -- 1 file changed, 6 deletions(-) Acked-by: Larry

[net-next v3 2/5] ixgbe: Enable LASI interrupts for X552 devices

2017-07-18 Thread Jeff Kirsher
From: Tony Nguyen Enable LASI interrupts on X552 devices in order to receive notifications of link configurations of the external PHY and support the configuration of the internal iXFI link since iXFI does not support auto-negotiation. This is not required for X553 devices; add a check to avoid

[net-next v3 1/5] ixgbe: Ensure MAC filter was added before setting MACVLAN

2017-07-18 Thread Jeff Kirsher
From: Tony Nguyen This patch adds a check to ensure that adding the MAC filter was successful before setting the MACVLAN. If it was unsuccessful, propagate the error. Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_s

[net-next v3 3/5] ixgbe: Update NW_MNG_IF_SEL support for X553

2017-07-18 Thread Jeff Kirsher
From: Tony Nguyen The MAC register NW_MNG_IF_SEL fields have been redefined for X553. These changes impact the iXFI driver code flow. Since iXFI is only supported in X552, add MAC checks for iXFI flows. Signed-off-by: Tony Nguyen Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-o

[net-next v3 4/5] ixgbe: Do not support flow control autonegotiation for X553

2017-07-18 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for fiber on X553. Add device ID checks in ixgbe_device_supports_autoneg_fc() to return the appropriate value. Signed-off-by: Tony Nguyen Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- dr

[net-next v3 5/5] ixgbe: Disable flow control for XFI

2017-07-18 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for XFI. Make sure that ixgbe_device_supports_autoneg_fc() returns false and hw->fc.disable_fc_autoneg is set to true to avoid running the fc_autoneg function for that device. Signed-off-by: Tony Nguyen Signed-off-by: Emil Tantilo

[net-next v3 0/5][pull request] 10GbE Intel Wired LAN Driver Updates 2017-07-18

2017-07-18 Thread Jeff Kirsher
This series contains updates to ixgbe only. Tony provides all of the changes in the series, starting with adding a check to ensure that adding a MAC filter was successful, before setting the MACVLAN. In order to receive notifications of link configurations of the external PHY and support the conf

Re: [PATCH iproute2 net-next] bridge: this patch adds json support for bridge mdb show

2017-07-18 Thread Stephen Hemminger
On Fri, 7 Jul 2017 15:24:16 -0700 Roopa Prabhu wrote: > From: Nikhil Gajendrakumar > > This patch adds json output to bridge mdb show > > Normal Output: > $ bridge -d -s mdb show > dev br0 port swp3 grp 239.0.0.1 temp vid 128 172.26 > dev br0 port swp3 grp 239.0.0.1 temp vid 64 172.26 > dev

Re: [PATCH RFC, iproute2] tc/mqprio: Add support to configure bandwidth rate limit through mqprio

2017-07-18 Thread Stephen Hemminger
On Fri, 14 Jul 2017 18:26:13 -0700 Amritha Nambiar wrote: > Support bandwidth rate limit information for a traffic > class in addition to the number of TCs and associated > queue configuration data. This is supported in the new > hardware offload mode in mqprio by setting the value of > 'hw' opti

Re: [PATCH iproute2] tc: fix typo in manpage

2017-07-18 Thread Stephen Hemminger
On Fri, 7 Jul 2017 15:08:33 +0200 Matteo Croce wrote: > Fix a typo in the 'tc' manpage and reword some sentences. > > Signed-off-by: Matteo Croce Applied, thanks.

Re: [PATCH iproute2 -master 0/3] BPF updates

2017-07-18 Thread Stephen Hemminger
On Mon, 17 Jul 2017 17:18:49 +0200 Daniel Borkmann wrote: > Couple of misc updates related to BPF. First removes a BPF sample > that is long legacy (pre BPF fs times), then we add support for the > loader to be able to take care of map in map, and last but not least > we dump id and whether prog

[PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-18 Thread Jianming.qiao
Signed-off-by: Jianming.qiao --- drivers/net/ethernet/broadcom/bcmsysport.c | 52 +++--- drivers/net/ethernet/broadcom/bcmsysport.h | 9 -- 2 files changed, 55 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethern

Re: [PATCH iproute2 net-next] iproute: extend route get for mpls routes

2017-07-18 Thread Stephen Hemminger
On Fri, 7 Jul 2017 15:08:11 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch extends route get to support mpls specific > route attributes like RTA_NEWDST. > > Input: > RTA_DST - input label > RTA_NEWDST - labels in packet for multipath selection > > By default the getroute hand

Re: [PATCH] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

2017-07-18 Thread Stephen Hemminger
On Mon, 10 Jul 2017 14:08:31 +0200 Matteo Croce wrote: > Hi Phil, > > I noticed that your patch still leaves an uncovered scenario, the one where > the > namespace name is "." or "..". > Calling 'ip netns del ..' will remove /var/run which is a symlink to /run on > most systems causing some dae

[git][98ed5bb] rvbd/rbt-kernel : bnx2-fix

2017-07-18 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: bnx2-fix Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and port extra skbuff operating routines used

[PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-18 Thread Girish Moodalbail
This patch adds changelink rtnl operation support for geneve devices and the code changes involve: - add geneve_quiesce() which quiesces the geneve device data path for both TX and RX. This lets us perform the changelink operation atomically w.r.t data path. Also add geneve_unquiesce() t

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-18 Thread Benjamin Poirier
On 2017/07/18 10:21, Lennart Sorensen wrote: > Commit 16ecba59bc333d6282ee057fb02339f77a880beb has apparently broken > at least the 82574L under heavy load (as in load heavy enough to cause > packet drops). In this case, when running in MSI-X mode, the Other > Causes interrupt fires about 3000 tim

[PATCH net-next 1/3] bluetooth: 6lowpan dev_close never returns error

2017-07-18 Thread Stephen Hemminger
The function dev_close in current kernel will never return an error. Later changes will make it void. Signed-off-by: Stephen Hemminger --- net/bluetooth/6lowpan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index ab3b65

[PATCH net-next 3/3] net: make dev_close and related functions void

2017-07-18 Thread Stephen Hemminger
There is no useful return value from dev_close. All paths return 0. Change dev_close and helper functions to void. Signed-off-by: Stephen Hemminger --- include/linux/netdevice.h | 4 ++-- net/core/dev.c| 26 +++--- 2 files changed, 13 insertions(+), 17 deletions(

[PATCH net-next 2/3] hns: remove useless void cast

2017-07-18 Thread Stephen Hemminger
There is no need to cast away return value of dev_close. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hn

[PATCH net-next 0/3] net: make dev_close void

2017-07-18 Thread Stephen Hemminger
Noticed while working on other changes. Why is dev_close() returning int, it should be void. Should also change ndo_close to be void, but that requires more work and someone with more coccinelle foo (smpl) than me. Stephen Hemminger (3): bluetooth: 6lowpan dev_close never returns error hns: r

Re: [PATCH 0/5] Netfilter fixes for net

2017-07-18 Thread David Miller
From: Florian Westphal Date: Tue, 18 Jul 2017 23:11:57 +0200 > David Miller wrote: >> What about that change Eric Dumazet was talking about with Florian >> that stopped instantiating conntrack by default in new namespaces? > > Seems more appropriate for -next. If you prefer net instead, let me

Re: [PATCH] net: Convert to using %pOF instead of full_name

2017-07-18 Thread David Miller
From: Rob Herring Date: Tue, 18 Jul 2017 16:43:19 -0500 > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring Acked-by: David S. Miller

[PATCH] net: Convert to using %pOF instead of full_name

2017-07-18 Thread Rob Herring
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Andrew Lunn Cc: Vivien Didelot Cc: Florian Fainelli Cc: Madalin Bucur Cc: Douglas Mill

A buggy behavior for Linux TCP Reno and HTCP

2017-07-18 Thread Wei Sun
Hi there, We find a buggy behavior when using Linux TCP Reno and HTCP in low bandwidth or highly congested network environments. In a simple word, their undo functions may mistakenly double the cwnd, leading to a more aggressive behavior in a highly congested scenario. The detailed reason: The

Re: [PATCH 0/5] Netfilter fixes for net

2017-07-18 Thread Florian Westphal
David Miller wrote: > What about that change Eric Dumazet was talking about with Florian > that stopped instantiating conntrack by default in new namespaces? Seems more appropriate for -next. If you prefer net instead, let me know and I'll get to work.

[PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables cpu_id_modulus and cpu_id. Such variables are initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the follo

[PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable _condition_ and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable fw_dump_ops. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic pat

Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:50:15PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

[PATCH] net: tulip: remove useless code in tulip_init_one()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable multiport_cnt and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c ind

Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:53:48PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

[PATCH] rtlwifi: remove useless code

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variables last_read_point and last_txw_point and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/dri

[PATCH] wireless: airo: remove unnecessary static in writerids()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local function pointer _writer_. Such pointer is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic

[PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables cpu_id_modulus and cpu_id. Such variables are initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the follo

[PATCH net-next] net: dsa: unexport dsa_is_port_initialized

2017-07-18 Thread Vivien Didelot
The dsa_is_port_initialized helper is only used by dsa_switch_resume and dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to dsa.c. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 - net/dsa/dsa.c | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote: > Hi: > > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand I'm glad to see this take shape - this can be extended to optimize virtnet_get_headroom so we don't wast

Re: [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on XDP set

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: > Current XDP implementation want guest offloads feature to be disabled s/want/wants/ > on qemu cli. on the device. > This is inconvenient and means guest can't benefit from > offloads if XDP is not used. This patch tries to address th

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread Andrew Lunn
> I know this looks boring, I do not particularly enjoy it myself, but I > think this is also important. I don't mind fixing the poking function as > well in the near future. It would be great if you do. It could be as simple as using phy_ethtool_get_eee() and phy_ethtool_set_eee(). Andrew

Re: [PATCH net-next 4/5] virtio-net: do not reset during XDP set

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:44:00PM +0800, Jason Wang wrote: > We used to reset during XDP set, the main reason is we need allocate > extra headroom for header adjustment but there's no way to know the > headroom of exist receive buffer. This works buy maybe complex and may > cause the network down

[PATCH net-next] net/packet: remove unused PGV_FROM_VMALLOC definition.

2017-07-18 Thread Rami Rosen
This patch removes the definition of PGV_FROM_VMALLOC from af_packet.c. The PGV_FROM_VMALLOC definition was already removed by commit 441c793a5650 ("net: cleanup unused macros in net directory"), and its usage was removed even before by commit c56b4d90123b ("af_packet: remove pgv.flags"); but it

Re: [PATCH net-next 3/5] virtio-net: switch to use new ctx API for small buffer

2017-07-18 Thread Michael S. Tsirkin
what's needed is ability to store the headroom there. virtio-net: switch to use ctx API for small buffers Use ctx API to store headroom for small buffers. Following patches will retrieve this info and use it for XDP. On Mon, Jul 17, 2017 at 08:43:59PM +0800, Jason Wang wrote: > Switch to use ctx

Re: [PATCH v3 00/10] constify net attribute_group structures.

2017-07-18 Thread David Miller
From: Arvind Yadav Date: Tue, 18 Jul 2017 15:13:44 +0530 > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with const > attribute_group. So mark the non-const structs as const. Series applied, thanks.

Re: [PATCH 0/5] Netfilter fixes for net

2017-07-18 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 18 Jul 2017 12:13:54 +0200 > The following patchset contains Netfilter fixes for your net tree, > they are: > > 1) Missing netlink message sanity check in nfnetlink, patch from >Mateusz Jurczyk. > > 2) We now have netfilter per-netns hooks, so let's kill g

[PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-18 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options [mss 65476,

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread Vivien Didelot
Hi David, David Miller writes: > However, in this particular case, this issue was brought to Vivien's > attention multiple times in the past. > > And I think the direct PHY poking issue is much more important than > these seemingly endless reorganizations of the driver that Vivien is > doing. >

Re: [PATCH net v2] udp: preserve skb->dst if required for IP options processing

2017-07-18 Thread David Miller
From: Paolo Abeni Date: Tue, 18 Jul 2017 11:57:55 +0200 > Eric noticed that in udp_recvmsg() we still need to access > skb->dst while processing the IP options. > Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") > skb->dst is no more available at recvmsg() time and bad things > wi

Re: [PATCH net-next 2/5] virtio-net: pack headroom into ctx for mergeable buffer

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:43:58PM +0800, Jason Wang wrote: > Pack headroom into ctx, then during XDP set, we could know the size of > headroom and copy if needed. This is required for avoiding reset on > XDP. Not really when XDP is set - it's when buffers are used. virtio-net: pack headroom into

Re: [patch net-next 00/22] mlxsw: Preparations for IPv6 UC router

2017-07-18 Thread David Miller
From: Jiri Pirko Date: Tue, 18 Jul 2017 10:10:08 +0200 > From: Jiri Pirko > > Ido says: > > The purpose of this set is to prepare the driver for the introduction of > IPv6 FIB offload. It's mainly composed of small and non-functional > changes, that either add the IPv6 equivalent of existing I

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-18 Thread Shaohua Li
On Mon, Jul 17, 2017 at 09:02:57PM -0700, Eric Dumazet wrote: > On Mon, 2017-07-17 at 14:53 -0700, Shaohua Li wrote: > > On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > > > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > > > From: Shaohua Li > > > > > > > > Please see bel

Re: [PATCH net-next 2/2] liquidio: Add support to create management interface

2017-07-18 Thread Jakub Kicinski
On Mon, 17 Jul 2017 12:52:17 -0700, Felix Manlunas wrote: > From: VSR Burru > > This patch adds support to create a virtual ethernet interface to > communicate with Linux on LiquidIO adapter for management. > > Signed-off-by: VSR Burru > Signed-off-by: Srinivasa Jampala > Signed-off-by: Satana

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread Michael S. Tsirkin
On Tue, Jul 18, 2017 at 11:24:42AM -0700, David Miller wrote: > From: Jason Wang > Date: Mon, 17 Jul 2017 20:43:56 +0800 > > > This series brings two optimizations for virtio-net XDP: > > > > - avoid reset during XDP set > > - turn off offloads on demand > > > > Please review. > > Michael, ple

Re: [PATCH] atm: zatm: Fix an error handling path in 'zatm_init_one()'

2017-07-18 Thread David Miller
From: Christophe JAILLET Date: Mon, 17 Jul 2017 19:42:41 +0200 > If 'dma_set_mask_and_coherent()' fails, we must undo the previous > 'pci_request_regions()' call. > Adjust corresponding 'goto' to jump at the right place of the error > handling path. > > Signed-off-by: Christophe JAILLET Applie

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread David Miller
From: Jason Wang Date: Mon, 17 Jul 2017 20:43:56 +0800 > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand > > Please review. Michael, please review Jason's changes. Thanks.

Re: [PATCH] ipv4: ipv6: initialize treq->txhash in cookie_v[46]_check()

2017-07-18 Thread David Miller
From: Alexander Potapenko Date: Mon, 17 Jul 2017 12:35:58 +0200 > KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), > which originated from the TCP request socket created in > cookie_v6_check(): ... > Similar error is reported for cookie_v4_check(). > > Signed-off-by: Alexan

Re: [PATCH] ppp: Fix false xmit recursion detect with two ppp devices

2017-07-18 Thread David Miller
From: gfree.w...@vip.163.com Date: Mon, 17 Jul 2017 18:34:42 +0800 > From: Gao Feng > > The global percpu variable ppp_xmit_recursion is used to detect the ppp > xmit recursion to avoid the deadlock, which is caused by one CPU tries to > lock the xmit lock twice. But it would report false recurs

Re: [PATCH net-next 0/10] xfrm: remove flow cache

2017-07-18 Thread David Miller
From: Florian Westphal Date: Mon, 17 Jul 2017 13:57:17 +0200 > After RCU-ification of ipsec packet path there are no major scalability > issues anymore without flow cache. > > We still incur a performance hit, which comes mostly from the extra xfrm > dst allocation/freeing. > The last patch in t

Re: [PATCH net-next 11/11] net: switchdev: Remove bridge bypass support from switchdev

2017-07-18 Thread Vivien Didelot
Arkadi Sharshevsky writes: > Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded > through the bridge code, making the switchdev's SELF bridge bypass > implementation to be redundant. This implies several changes: > - No need for dump infra in switchdev, DSA's special case is h

Re: [PATCH net-next 00/12] net: dsa: mv88e6xxx: cleanup capabilities

2017-07-18 Thread David Miller
From: Vivien Didelot Date: Mon, 17 Jul 2017 13:03:34 -0400 > This patch series removes the remaining capabilities as well as the > flags bitmap in the info structures. Most of them are turned into ops, > or new info members. > > There is no mv88e6xxx_cap enum or bitmap flags anymore, only > mv88

Re: [PATCH net-next 10/11] net: bridge: Remove FDB deletion through switchdev object

2017-07-18 Thread Vivien Didelot
Arkadi Sharshevsky writes: > At this point no driver supports FDB add/del through switchdev object > but rather via notification chain, thus, it is removed. > > Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot

Re: [PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA

2017-07-18 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > +typedef int dsa_fdb_dump_cb_t(const unsigned char *addr, u16 vid, > + u16 ndm_state, void *data); Can I ask you to change u16 ndm_state for bool is_static at the same time? Ethernet switches do not need to report more than that.

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread David Miller
From: Florian Fainelli Date: Tue, 18 Jul 2017 09:01:01 -0700 > On 07/17/2017 02:10 PM, David Miller wrote: >> From: Andrew Lunn >> Date: Mon, 17 Jul 2017 23:04:05 +0200 >> >>> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote: From: Vivien Didelot Date: Mon, 17 Jul 2017 15

Re: Use sock_diag instead of procfs for new address families?

2017-07-18 Thread David Miller
From: Stefan Hajnoczi Date: Tue, 18 Jul 2017 17:18:06 +0100 > I am implementing userspace access to socket information for AF_VSOCK. > A few hours into writing and testing a /proc/net/vsock seq_file I > noticed that ss(8) prefers NETLINK_SOCK_DIAG over procfs. > > Before potentially wasting time

Re: [PATCH net-next 08/11] net: dsa: Remove redundant MDB dump support

2017-07-18 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > Currently the MDB HW database is synced with the bridge's one, thus, > There is no need to support special dump functionality. > > Signed-off-by: Arkadi Sharshevsky > --- > drivers/net/dsa/microchip/ksz_common.c | 9 - > drivers/net/dsa/mv88e6xx

Re: [PATCH net-next 07/11] net: dsa: Remove support for bypass bridge port attributes/vlan set

2017-07-18 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > The bridge port attributes/vlan for DSA devices should be set only > from bridge code. Furthermore, The vlans are synced totally with the > bridge so there is no need for special dump support. > > Signed-off-by: Arkadi Sharshevsky > --- > drivers/net/dsa

Re: [PATCH net-next 06/11] net: dsa: Add support for querying supported bridge flags

2017-07-18 Thread Vivien Didelot
Arkadi Sharshevsky writes: > The DSA drivers do not support bridge flags offload. Yet, this attribute > should be added in order for the bridge to fail when one tries set a > flag on the port, as explained in commit dc0ecabd6231 ("net: switchdev: > Add support for querying supported bridge flags

Re: [PATCH net-next 05/11] net: dsa: Remove support for FDB add/del via SELF

2017-07-18 Thread Vivien Didelot
Arkadi Sharshevsky writes: > FDB add/del can be added via switchdev notification chain. Thus the support > for configuration via switchdev objects can be removed. > > Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot

Re: [PATCH net-next 04/11] net: dsa: Add support for learning FDB through notification

2017-07-18 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -451,6 +451,7 @@ void unregister_switch_driver(struct dsa_switch_driver > *type); > struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev); > > struct net_device *dsa_dev_to_net_device(struct

Re: [PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

2017-07-18 Thread Arun Parameswaran
Hi David, On 17-07-10 06:44 AM, Rob Herring wrote: > On Thu, Jul 06, 2017 at 10:37:57AM -0700, Arun Parameswaran wrote: >> Add SoC specific compatibility strings to the Broadcom DTE >> based PTP clock binding document. >> >> Fixed the document heading and node name. >> >> Fixes: 80d6076140b2 ("dt-

Re: Use sock_diag instead of procfs for new address families?

2017-07-18 Thread Stephen Hemminger
On Tue, 18 Jul 2017 17:18:06 +0100 Stefan Hajnoczi wrote: > I am implementing userspace access to socket information for AF_VSOCK. > A few hours into writing and testing a /proc/net/vsock seq_file I > noticed that ss(8) prefers NETLINK_SOCK_DIAG over procfs. > > Before potentially wasting time i

Use sock_diag instead of procfs for new address families?

2017-07-18 Thread Stefan Hajnoczi
I am implementing userspace access to socket information for AF_VSOCK. A few hours into writing and testing a /proc/net/vsock seq_file I noticed that ss(8) prefers NETLINK_SOCK_DIAG over procfs. Before potentially wasting time implementing a legacy interface that won't be accepted, I thought it mi

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread Florian Fainelli
On 07/17/2017 02:10 PM, David Miller wrote: > From: Andrew Lunn > Date: Mon, 17 Jul 2017 23:04:05 +0200 > >> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote: >>> From: Vivien Didelot >>> Date: Mon, 17 Jul 2017 15:32:52 -0400 >>> Hi Andrew, Andrew Lunn writes: >>

[Resend, PATCH v1] ISDN: eicon: switch to use native bitmaps

2017-07-18 Thread Andy Shevchenko
Two arrays are clearly bit maps, so, make that explicit by converting to bitmap API and remove custom helpers. Note sig_ind() uses out of boundary bit to (looks like) protect against potential bitmap_empty() checks for the same bitmap. This patch removes that since: 1) that didn't guarantee atomi

[PATCH net-next] sfc: Add ethtool -m support for QSFP modules

2017-07-18 Thread Martin Habets
This also adds support for non-QSFP modules attached to QSFP. Signed-off-by: Martin Habets --- drivers/net/ethernet/sfc/mcdi_port.c | 224 +++--- 1 file changed, 181 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/sfc/mcdi_port.c b/drivers/net/ethe

RE: [PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes

2017-07-18 Thread Ricardo Farrington
My apologies Leon - I did not infer that the subject line should have been changed from your previous correspondence. I will correct it. Rick -Original Message- From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Monday, July 17, 2017 11:23 PM To: Manlunas, Felix Cc: da...@davemloft.

Attention To me and get back to me urgent

2017-07-18 Thread Mrs.Meliana Trump
Attention:Beneficiary I am Meliana Trump, and I am writing to inform you about your Bank Check Draft brought back 16/07/2017 by the United Embassy Mr John Moore from the government of Benin Republic in the white house Washington DC been mandated to be deliver to your home address once you reconfi

commit 16ecba59 breaks 82574L under heavy load.

2017-07-18 Thread Lennart Sorensen
Commit 16ecba59bc333d6282ee057fb02339f77a880beb has apparently broken at least the 82574L under heavy load (as in load heavy enough to cause packet drops). In this case, when running in MSI-X mode, the Other Causes interrupt fires about 3000 times per second, but not due to link state changes. Un

[PATCH net-next 03/11] net: dsa: Remove switchdev dependency from DSA switch notifier chain

2017-07-18 Thread Arkadi Sharshevsky
Currently, the switchdev objects are embedded inside the DSA notifier info. This patch removes this dependency. This is done as a preparation stage before adding support for learning FDB through the switchdev notification chain. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Florian Fainelli Rev

[PATCH net-next 08/11] net: dsa: Remove redundant MDB dump support

2017-07-18 Thread Arkadi Sharshevsky
Currently the MDB HW database is synced with the bridge's one, thus, There is no need to support special dump functionality. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/microchip/ksz_common.c | 9 - drivers/net/dsa/mv88e6xxx/chip.c | 24 include/

[PATCH net-next 02/11] net: dsa: Remove prepare phase for FDB

2017-07-18 Thread Arkadi Sharshevsky
The prepare phase for FDB add is unneeded because most of DSA devices can have failures during bus transactions (SPI, I2C, etc.), thus, the prepare phase cannot guarantee success of the commit stage. The support for learning FDB through notification chain, which will be introduced in the following

[PATCH net-next 04/11] net: dsa: Add support for learning FDB through notification

2017-07-18 Thread Arkadi Sharshevsky
Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. In case of a successful FDB add a notification is sent back to bridge. In case of hw FDB del failure the static FDB will be deleted from the bridge, thus, the interface is moved to down

[PATCH net-next 06/11] net: dsa: Add support for querying supported bridge flags

2017-07-18 Thread Arkadi Sharshevsky
The DSA drivers do not support bridge flags offload. Yet, this attribute should be added in order for the bridge to fail when one tries set a flag on the port, as explained in commit dc0ecabd6231 ("net: switchdev: Add support for querying supported bridge flags by hardware"). Signed-off-by: Arkadi

[PATCH net-next 01/11] net: dsa: Change DSA slave FDB API to be switchdev independent

2017-07-18 Thread Arkadi Sharshevsky
In order to support FDB add/del to be on a notifier chain the slave API need to be changed to be switchdev independent. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 12 +--- drivers/net/dsa/b53/

[PATCH net-next 10/11] net: bridge: Remove FDB deletion through switchdev object

2017-07-18 Thread Arkadi Sharshevsky
At this point no driver supports FDB add/del through switchdev object but rather via notification chain, thus, it is removed. Signed-off-by: Arkadi Sharshevsky --- net/bridge/br_fdb.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c

[PATCH net-next 11/11] net: switchdev: Remove bridge bypass support from switchdev

2017-07-18 Thread Arkadi Sharshevsky
Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded through the bridge code, making the switchdev's SELF bridge bypass implementation to be redundant. This implies several changes: - No need for dump infra in switchdev, DSA's special case is handled privately. - Remove obj_dump

[PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA

2017-07-18 Thread Arkadi Sharshevsky
>From all switchdev devices only DSA requires special FDB dump. This is due to lack of ability for syncing the hardware learned FDBs with the bridge. Due to this it is removed from switchdev and moved inside DSA. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 18

[PATCH net-next 07/11] net: dsa: Remove support for bypass bridge port attributes/vlan set

2017-07-18 Thread Arkadi Sharshevsky
The bridge port attributes/vlan for DSA devices should be set only from bridge code. Furthermore, The vlans are synced totally with the bridge so there is no need for special dump support. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 44 -

[PATCH net-next 05/11] net: dsa: Remove support for FDB add/del via SELF

2017-07-18 Thread Arkadi Sharshevsky
FDB add/del can be added via switchdev notification chain. Thus the support for configuration via switchdev objects can be removed. Signed-off-by: Arkadi Sharshevsky --- net/dsa/slave.c | 12 1 file changed, 12 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 8278d

[PATCH net-next 00/11] Change DSA's FDB API and perform switchdev cleanup

2017-07-18 Thread Arkadi Sharshevsky
The patchset moves the DSA driver into learning static FDB entries via the switchdev notification chain rather then by using bridge bypass SELF flag. The DSA drivers cannot sync the software bridge with hardware learned entries and use the switchdev's implementation of bypass FDB dumping. Because

[PATCH] NET: dwmac: Make dwmac reset unconditional

2017-07-18 Thread Eugeniy Paltsev
Unconditional reset dwmac before HW init if reset controller is present. In existing implementation we reset dwmac only after second module probing: (module load -> unload -> load again [reset happens]) Now we reset dwmac at every module load: (module load [reset happens] -> unload -> load again

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-07-18 Thread Andrew Lunn
On Tue, Jul 18, 2017 at 09:52:51AM -0300, Fabio Estevam wrote: > On Tue, Jul 18, 2017 at 9:48 AM, Sergei Shtylyov > wrote: > > On 07/18/2017 03:39 PM, Fabio Estevam wrote: > > > >>>Won't this result in kernel WARNING when GPIO is disabled? > > > > > >GPIO support, I was going to type... >

  1   2   >