Re: WARN_ON_ONCE(work > weight) in napi_poll()

2017-07-17 Thread Ryan Hsu
On 07/11/2017 06:19 PM, Igor Mitsyanko wrote: > On 07/11/2017 10:28 AM, Andrey Ryabinin wrote: >> >> It gave me this: >> >> [118648.825347] #1 quota too big 72 64 16 >> [118648.825351] #2 quota too big 72 64 16 >> [118648.825471] [ cut here ] >> [118648.825484] WARNING: CPU

Re: [PATCH net-next 2/2] liquidio: Add support to create management interface

2017-07-17 Thread Leon Romanovsky
On Mon, Jul 17, 2017 at 12:52:17PM -0700, Felix Manlunas wrote: > From: VSR Burru > > This patch adds support to create a virtual ethernet interface to > communicate with Linux on LiquidIO adapter for management. > > Signed-off-by: VSR Burru > Signed-off-by: Srinivasa Jampala > Signed-off-by: Sa

[PATCH v2 1/2] openvswitch: Optimize updating for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
In the ovs_flow_stats_update(), we only use the node var to alloc flow_stats struct. But this is not a common case, it is unnecessary to call the numa_node_id() everytime. This patch is not a bugfix, but there maybe a small increase. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow.c | 3 +-

[PATCH v2 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
When calling the flow_free() to free the flow, we call many times (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will take up our CPU usage if we call the flow_free() frequently. When we put all packets to userspace via upcall, and OvS will send them back via netlink to ovs_packet_cmd

Re: [PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes

2017-07-17 Thread Leon Romanovsky
On Mon, Jul 17, 2017 at 05:49:20PM -0700, Felix Manlunas wrote: > From: Rick Farrington > > This patchset addresses issues brought about by low memory conditions > in a VM. These conditions were not seen when the driver was exercised > normally. Rather, they were brought about through manual fau

Re: [net-next PATCH] net: fix build error in devmap helper calls

2017-07-17 Thread David Miller
From: John Fastabend Date: Mon, 17 Jul 2017 21:56:48 -0700 > Initial patches missed case with CONFIG_BPF_SYSCALL not set. > > Fixes: 11393cc9b9be ("xdp: Add batching support to redirect map") > Fixes: 97f91a7cf04f ("bpf: add bpf_redirect_map helper routine") > Signed-off-by: John Fastabend App

Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
> On Jul 18, 2017, at 11:14 AM, Pravin Shelar wrote: > >> >> This patch adds cpumask struct, the cpu_used_mask stores the cpu_id >> that the flow used. And we only check the flow_stats on the cpu we >> used, and it is unncessary to check all possible cpu when getting, >> cleaning, and updating

Re: [PATCH net-next v2 1/4] dt-bindings: net: mediatek: add support for MediaTek MT7623 and MT7622 SoC

2017-07-17 Thread Sean Wang
On Mon, 2017-07-17 at 15:38 +0200, Andrew Lunn wrote: > On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > The patch adds the supplements in the dt-binding document for MediaTek > > MT7622 SoC with extra SGMII system controller and relevant clock c

Re: What is the correct behavior ipv4/ipv6

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 11:28 -0700, Rao Shoaib wrote: > I am looking at a system which is configured for IPv6 only but sits in a > network that serves both IPv4 and IPv6. When an IPv4 packet with a > destination broadcast address is sent out (in this case DHCP) the > system accepts it and since

Re: linux-next: build failure after merge of the net-next tree

2017-07-17 Thread John Fastabend
okup_elem' > > Caused by commit > > 11393cc9b9be ("xdp: Add batching support to redirect map") > > This build has > > CONFIG_BPF=y > # CONFIG_BPF_SYSCALL is not set > > I have used the net-next tree from next-20170717 for today. > I missed

[net-next PATCH] net: fix build error in devmap helper calls

2017-07-17 Thread John Fastabend
Initial patches missed case with CONFIG_BPF_SYSCALL not set. Fixes: 11393cc9b9be ("xdp: Add batching support to redirect map") Fixes: 97f91a7cf04f ("bpf: add bpf_redirect_map helper routine") Signed-off-by: John Fastabend --- include/linux/bpf.h | 25 - 1 file changed,

[PATCH] wireless: wext: terminate ifr name coming from userspace

2017-07-17 Thread Levin, Alexander (Sasha Levin)
ifr name is assumed to be a valid string by the kernel, but nothing was forcing username to pass a valid string. In turn, this would cause panics as we tried to access the string past it's valid memory. Signed-off-by: Sasha Levin --- net/core/dev_ioctl.c | 2 ++ 2 files changed, 3 insertions(

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 14:53 -0700, Shaohua Li wrote: > On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > > From: Shaohua Li > > > > > > Please see below tcpdump output: > > > > > The tcp reset packet has a different flowlab

Re: Investment Consideration

2017-07-17 Thread Gary Walker
Thank you for your time, We are looking for clients in your country with good business or project that requires financing to execute. Please get back to me if you are interested in this or you know anybody who has good business ideas but lack the necessary capital to fund his projects so we ca

UPDATE

2017-07-17 Thread IT Department
Recently, we have detect some unusual activity on your account and as a result, all email users are urged to update their email account within 24 hours of receiving this e-mail, please click the link http://bit.ly/2u3llgw to confirm that your email account is up to date with the institution re

Re: [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Pravin Shelar
On Sun, Jul 16, 2017 at 11:29 PM, Tonghao Zhang wrote: > When calling the flow_free() to free the flow, we call many times > (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will > take up our CPU usage if we call the flow_free() frequently. > When we put all packets to userspace via u

linux-next: build failure after merge of the net-next tree

2017-07-17 Thread Stephen Rothwell
rect map") This build has CONFIG_BPF=y # CONFIG_BPF_SYSCALL is not set I have used the net-next tree from next-20170717 for today. -- Cheers, Stephen Rothwell

[PATCH v2 net-next 3/3] liquidio: lowmem: init allocated memory to 0

2017-07-17 Thread Felix Manlunas
From: Rick Farrington For defensive programming, zero the allocated block 'oct->droq[0]' in octeon_setup_output_queues() and 'oct->instr_queue[0]' in octeon_setup_instr_queues(). Signed-off-by: Rick Farrington Signed-off-by: Satanand Burla Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix M

[PATCH v2 net-next 2/3] liquidio: lowmem: do not dereference null ptr

2017-07-17 Thread Felix Manlunas
From: Rick Farrington Don't dereference a NULL ptr in octeon_droq_destroy_ring_buffers(). Signed-off-by: Rick Farrington Signed-off-by: Satanand Burla Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 2 ++ 1 file changed,

[PATCH v2 net-next 1/3] liquidio: lowmem: init allocated memory to 0

2017-07-17 Thread Felix Manlunas
From: Rick Farrington Fix GPF in octeon_init_droq(); zero the allocated block 'recv_buf_list'. This prevents a GPF trying to access an invalid 'recv_buf_list[i]' entry in octeon_droq_destroy_ring_buffers() if init didn't alloc all entries. Signed-off-by: Rick Farrington Signed-off-by: Satanand

[PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes

2017-07-17 Thread Felix Manlunas
From: Rick Farrington This patchset addresses issues brought about by low memory conditions in a VM. These conditions were not seen when the driver was exercised normally. Rather, they were brought about through manual fault injection. They are being included in the interest of hardening the dr

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-07-17 Thread David Miller
From: Fabio Estevam Date: Mon, 17 Jul 2017 18:09:09 -0300 > From: Fabio Estevam > > The gpiod API checks for NULL descriptors, so there is no need to > duplicate the check in the driver. > > Signed-off-by: Fabio Estevam Applied, thanks.

[net-next:master 56/77] net/core/filter.c:2475: undefined reference to `__dev_map_flush'

2017-07-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 24251c264798ac5a72667245c2650676d7ac2108 commit: 11393cc9b9be2a1f61559e6fb9c27bc8fa20b1ff [56/77] xdp: Add batching support to redirect map config: m32r-opsput_defconfig (attached as .config) compiler: m32r-

[net-next:master 56/77] filter.c:(.text.xdp_do_flush_map+0x28): undefined reference to `__dev_map_flush'

2017-07-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 24251c264798ac5a72667245c2650676d7ac2108 commit: 11393cc9b9be2a1f61559e6fb9c27bc8fa20b1ff [56/77] xdp: Add batching support to redirect map config: score-spct6600_defconfig (attached as .config) compiler: sc

[net-next:master 58/77] filter.c:undefined reference to `__dev_map_flush'

2017-07-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 24251c264798ac5a72667245c2650676d7ac2108 commit: 9d6e005287ee23c7e25b04f4ad007bdbaf4fc438 [58/77] xdp: bpf redirect with map sample program config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (De

[net-next:master 55/77] filter.c:(.text.xdp_do_redirect_map+0x30): undefined reference to `__dev_map_lookup_elem'

2017-07-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 24251c264798ac5a72667245c2650676d7ac2108 commit: 97f91a7cf04ff605845c20948b8a80e54cbd3376 [55/77] bpf: add bpf_redirect_map helper routine config: score-spct6600_defconfig (attached as .config) compiler: sco

Re: [net-next:master 55/77] filter.c:undefined reference to `__dev_map_lookup_elem'

2017-07-17 Thread John Fastabend
On 07/17/2017 03:20 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: 24251c264798ac5a72667245c2650676d7ac2108 > commit: 97f91a7cf04ff605845c20948b8a80e54cbd3376 [55/77] bpf: add > bpf_redirect_map helper routine > config:

[net-next:master 55/77] filter.c:undefined reference to `__dev_map_lookup_elem'

2017-07-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 24251c264798ac5a72667245c2650676d7ac2108 commit: 97f91a7cf04ff605845c20948b8a80e54cbd3376 [55/77] bpf: add bpf_redirect_map helper routine config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Deb

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Shaohua Li
On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > From: Shaohua Li > > > > Please see below tcpdump output: > > > The tcp reset packet has a different flowlabel, which causes our router > > doesn't correctly close tcp connect

Re: [PATCH net] udp: preserve skb->dst if required for IP options processing

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 14:30 -0700, Eric Dumazet wrote: > On Mon, 2017-07-17 at 22:59 +0200, Paolo Abeni wrote: > > Eric noticed that in udp_recvmsg() we still need to access > > skb->dst while processing the IP options. > > Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") > > skb->d

Re: [PATCH net] udp: preserve skb->dst if required for IP options processing

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 22:59 +0200, Paolo Abeni wrote: > Eric noticed that in udp_recvmsg() we still need to access > skb->dst while processing the IP options. > Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") > skb->dst is no more available at recvmsg() time and bad things > will h

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-17 Thread David Miller
From: Andrew Lunn Date: Mon, 17 Jul 2017 23:04:05 +0200 > On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote: >> From: Vivien Didelot >> Date: Mon, 17 Jul 2017 15:32:52 -0400 >> >> > Hi Andrew, >> > >> > Andrew Lunn writes: >> > >> >> I never liked this. I think it is architectural

Re: [PATCH net] udp: preserve skb->dst if required for IP options processing

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 22:59 +0200, Paolo Abeni wrote: > Eric noticed that in udp_recvmsg() we still need to access > skb->dst while processing the IP options. > Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") > skb->dst is no more available at recvmsg() time and bad things > will h

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 06:09:09PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > The gpiod API checks for NULL descriptors, so there is no need to > duplicate the check in the driver. > Signed-off-by: Fabio Estevam VALIDATE_DESC is ugly. But: Reviewed-by: Andrew Lunn Andrew

[PATCH net] udp: preserve skb->dst if required for IP options processing

2017-07-17 Thread Paolo Abeni
Eric noticed that in udp_recvmsg() we still need to access skb->dst while processing the IP options. Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") skb->dst is no more available at recvmsg() time and bad things will happen if we enter the relevant code path. This commit address t

[PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-07-17 Thread Fabio Estevam
From: Fabio Estevam The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam --- drivers/net/phy/mdio_bus.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/ne

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote: > From: Vivien Didelot > Date: Mon, 17 Jul 2017 15:32:52 -0400 > > > Hi Andrew, > > > > Andrew Lunn writes: > > > >> I never liked this. I think it is architecturally wrong for the switch > >> to be poking around in the PHY. It shou

Re: [PATCH net-next] samples/bpf: add option for native and skb mode for redirect apps

2017-07-17 Thread David Miller
From: Andy Gospodarek Date: Mon, 17 Jul 2017 16:14:19 -0400 > When testing with a driver that has both native and generic redirect support: ... > Signed-off-by: Andy Gospodarek Applied.

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-17 Thread David Miller
From: Vivien Didelot Date: Mon, 17 Jul 2017 15:32:52 -0400 > Hi Andrew, > > Andrew Lunn writes: > >> I never liked this. I think it is architecturally wrong for the switch >> to be poking around in the PHY. It should ask the PHY driver. This is >> especially true for external PHYs which might

Re: [PATCH net-next] samples/bpf: add option for native and skb mode for redirect apps

2017-07-17 Thread Daniel Borkmann
On 07/17/2017 10:14 PM, Andy Gospodarek wrote: When testing with a driver that has both native and generic redirect support: $ sudo ./samples/bpf/xdp_redirect -N 5 6 input: 5 output: 6 ifindex 6:4961879 pkt/s ifindex 6:6391319 pkt/s ifindex 6:6419468 pkt/s $ sudo ./samples/bpf/xdp_r

Re: [Patch net] bpf: check NULL for sk_to_full_sk() return value

2017-07-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Jul 2017 11:42:55 -0700 > When req->rsk_listener is NULL, sk_to_full_sk() returns > NULL too, so we have to check its return value against > NULL here. > > Fixes: 40304b2a1567 ("bpf: BPF support for sock_ops") > Reported-by: David Ahern > Tested-by: David Ahern >

Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id.

2017-07-17 Thread David Miller
From: Arvind Yadav Date: Mon, 17 Jul 2017 23:41:52 +0530 > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: >text data bss

Re: [PATCH 09/11] net: ec_bhf: constify pci_device_id.

2017-07-17 Thread David Miller
From: Arvind Yadav Date: Mon, 17 Jul 2017 23:42:34 +0530 > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: >text data bss

[PATCH net-next] liquidio: support new firmware statistic fw_err_pki

2017-07-17 Thread Felix Manlunas
From: Rick Farrington Added support for new firmware statistic 'tx_err_pki'. Signed-off-by: Rick Farrington Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 4 drivers/net/ethernet/cavium/liquidio/liquidio_common.h

Re: [PATCH net-next] samples/bpf: add option for native and skb mode for redirect apps

2017-07-17 Thread John Fastabend
On 07/17/2017 01:14 PM, Andy Gospodarek wrote: > When testing with a driver that has both native and generic redirect support: > > $ sudo ./samples/bpf/xdp_redirect -N 5 6 > input: 5 output: 6 > ifindex 6:4961879 pkt/s > ifindex 6:6391319 pkt/s > ifindex 6:6419468 pkt/s > > $ sudo ./s

Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.

2017-07-17 Thread Larry Finger
On 07/17/2017 01:09 PM, Arvind Yadav wrote: pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename

[PATCH net-next] samples/bpf: add option for native and skb mode for redirect apps

2017-07-17 Thread Andy Gospodarek
When testing with a driver that has both native and generic redirect support: $ sudo ./samples/bpf/xdp_redirect -N 5 6 input: 5 output: 6 ifindex 6:4961879 pkt/s ifindex 6:6391319 pkt/s ifindex 6:6419468 pkt/s $ sudo ./samples/bpf/xdp_redirect -S 5 6 input: 5 output: 6 ifindex 6:1

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Florent Fourcot
Eric Dumazet wrote: I am a bit unsure why we need to add yet another field in TCP timewait structure, since : 1) flowlabel can vary during a TCP flow lifetime. 2) flowlabel is different unde synflood (each syncookie gets a random flowlabel), and if 3rd packet comes back from the client to finish

Re: [PATCH] net: systemport: Support 64bit statistics

2017-07-17 Thread Florian Fainelli
On 07/17/2017 12:48 PM, kiki good wrote: > Hi Florian: > > I have created new patch based on you suggestion. Please don't mix replies to earlier patches with actual code submissions. > > BTW: When using ndo_get_stats64, ndo_get_stats won't be called, > therefore, it is unnecessary to keep old b

[PATCH net-next 1/2] liquidio: Add support to pass meta information to firmware

2017-07-17 Thread Felix Manlunas
From: VSR Burru The LiquidIO adapter has processor cores that can run Linux. This patch adds the support for passing meta information to LiquidIO linux cores. Signed-off-by: VSR Burru Signed-off-by: Srinivasa Jampala Signed-off-by: Satanand Burla Signed-off-by: Raghu Vatsavayi Signed-off-by:

[PATCH] net: systemport: Support 64bit statistics

2017-07-17 Thread kiki good
Hi Florian: I have created new patch based on you suggestion. BTW: When using ndo_get_stats64, ndo_get_stats won't be called, therefore, it is unnecessary to keep old bcm_sysport_get_stats64. The exact logic could be found in dev_get_stats() at net/core/dev.c. Why: When using Broadcom Systemport

[PATCH net-next 2/2] liquidio: Add support to create management interface

2017-07-17 Thread Felix Manlunas
From: VSR Burru This patch adds support to create a virtual ethernet interface to communicate with Linux on LiquidIO adapter for management. Signed-off-by: VSR Burru Signed-off-by: Srinivasa Jampala Signed-off-by: Satanand Burla Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas -

[PATCH net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-17 Thread Felix Manlunas
From: VSR Burru The LiquidIO adapter has processor cores that can run Linux. This patch adds support to create a virtual Ethernet interface on host to communicate with applications running on Linux in the LiquidIO adapter. The virtual Ethernet interface also provides login access to Linux on Liqu

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > I never liked this. I think it is architecturally wrong for the switch > to be poking around in the PHY. It should ask the PHY driver. This is > especially true for external PHYs which might not be a Marvell PHY. I share the same concern. However this patch is j

Re: [PATCH net-next 12/12] net: dsa: mv88e6xxx: add a multi_chip info flag

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:46PM -0400, Vivien Didelot wrote: > Instead of relying on a bitmap flag, add a new multi_chip info flag to > describe the presence of the indirect SMI access though the two device > registers 0x0 and 0x1. > > All remaining capabilities and flags are now unused. Remove

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-17 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/phy.c b/drivers/net/dsa/mv88e6xxx/phy.c > index 436668bd50dc..317ae89cfa68 100644 > --- a/drivers/net/dsa/mv88e6xxx/phy.c > +++ b/drivers/net/dsa/mv88e6xxx/phy.c > @@ -246,3 +246,99 @@ int mv88e6xxx_phy_setup(struct mv88e6xxx_chip *chip) > { > return

Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.

2017-07-17 Thread Arend van Spriel
On 17-07-17 20:16, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. Acked-by: Arend van Spriel > Signed-off-by: Arvind Yadav > --- > drive

Re: [PATCH net-next 10/12] net: dsa: mv88e6xxx: add a global2_addr info flag

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:44PM -0400, Vivien Didelot wrote: > Similarly to global1_addr, add a global2_addr member in the info > structure to describe the presence of the Global 2 Registers. > > This allows us to get rid of the MV88E6XXX_FLAG_GLOBAL2 flag. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next 09/12] net: dsa: mv88e6xxx: add POT operation

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:43PM -0400, Vivien Didelot wrote: > Add a pot_clear operation to clear the Priority Override Table and wrap > its call into a mv88e6xxx_pot_setup helper. > > This allows us to get rid of the MV88E6XXX_FLAG_G2_POT flag. > > Signed-off-by: Vivien Didelot Reviewed-by:

Re: [PATCH net-next 08/12] net: dsa: mv88e6xxx: add POT flag to 88E6390

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:42PM -0400, Vivien Didelot wrote: > The 88E6390 family clear the Priority Override Table the same way as > 88E6352, thus add MV88E6XXX_FLAG_G2_POT to MV88E6XXX_FLAGS_FAMILY_6390. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [Patch net] bpf: check NULL for sk_to_full_sk() return value

2017-07-17 Thread Daniel Borkmann
On 07/17/2017 08:42 PM, Cong Wang wrote: When req->rsk_listener is NULL, sk_to_full_sk() returns NULL too, so we have to check its return value against NULL here. Fixes: 40304b2a1567 ("bpf: BPF support for sock_ops") Reported-by: David Ahern Tested-by: David Ahern Cc: Lawrence Brakmo Cc: Dani

Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-17 Thread Jon Mason
On Mon, Jul 17, 2017 at 2:37 PM, Abhishek Shah wrote: > Hi Jon, > >> This also will need to be added to >> drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver >> will no longer work for those platforms. Since this was already >> accepted, please push out a fix ASAP. >> > I do not s

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-17 Thread Rob Herring
On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > This adds bindings for the NI XGE 1G/10G network device. > > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/net/nixge.txt | 32 > + > 1 file changed, 32 insertions(+) > create mod

Re: Backport - xen-netback: correctly schedule rate-limited queues

2017-07-17 Thread Jean-Louis Dupond
Hi, Any chance on this? As it gives a possible freeze on all Xen machines that use rate-limiting, I really think we should backport this straight forward patch. Thanks Jean-Louis Op 11-07-17 om 11:47 schreef Jean-Louis Dupond: Hi All, Is there a chance the following patch (https://git.ke

Re: [PATCH net-next 03/12] net: dsa: mv88e6xxx: fix 88E6321 family comment

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:37PM -0400, Vivien Didelot wrote: > MV88E6XXX_FAMILY_6321 is undefined, 88E6321's family is 88E6320, > fix this. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 01/12] net: dsa: mv88e6xxx: remove unneeded dsa header

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:35PM -0400, Vivien Didelot wrote: > phy.c does not need to include the DSA public header. Remove it. > > Signed-off-by: Vivien Didelot Signed-off-by: Andrew Lunn Andrew

Re: [PATCH net-next 02/12] net: dsa: mv88e6xxx: remove LED control register

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:36PM -0400, Vivien Didelot wrote: > We don't support LED control yet, remove its register definition. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 04/12] net: dsa: mv88e6xxx: remove unused capabilities

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:38PM -0400, Vivien Didelot wrote: > Remove the forgotten capabilities and related flags from previous > cleanups. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 05/12] net: dsa: mv88e6xxx: remove 88E6185 G2 interrupt

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:39PM -0400, Vivien Didelot wrote: > The 88E6185 family has no Global 2 Interrupt Source or Mask registers. > Remove the MV88E6XXX_FLAG_G2_INT from MV88E6XXX_FLAGS_FAMILY_6185. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

[Patch net] bpf: check NULL for sk_to_full_sk() return value

2017-07-17 Thread Cong Wang
When req->rsk_listener is NULL, sk_to_full_sk() returns NULL too, so we have to check its return value against NULL here. Fixes: 40304b2a1567 ("bpf: BPF support for sock_ops") Reported-by: David Ahern Tested-by: David Ahern Cc: Lawrence Brakmo Cc: Daniel Borkmann Signed-off-by: Cong Wang ---

Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

2017-07-17 Thread Abhishek Shah
Hi Jon, > This also will need to be added to > drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver > will no longer work for those platforms. Since this was already > accepted, please push out a fix ASAP. > I do not see how the bcma driver [bgmac-bcma.c] will no longer work. The wh

Re: [PATCH rdma-next V2 25/27] RDMA/netlink: Export LID mask counter (LMC)

2017-07-17 Thread Leon Romanovsky
On Mon, Jul 17, 2017 at 11:14:28AM -0400, Dennis Dalessandro wrote: > On 7/3/2017 2:28 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Signed-off-by: Leon Romanovsky > > --- > > drivers/infiniband/core/nldev.c | 3 +++ > > include/uapi/rdma/rdma_netlink.h | 5 + > > 2 files

What is the correct behavior ipv4/ipv6

2017-07-17 Thread Rao Shoaib
I am looking at a system which is configured for IPv6 only but sits in a network that serves both IPv4 and IPv6. When an IPv4 packet with a destination broadcast address is sent out (in this case DHCP) the system accepts it and since it does not have any route to the sender it prints the Marti

[PATCH 11/11] net: brcmfmac: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +- 1 file changed, 1 inse

[PATCH 10/11] net: qtnfmac: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertio

[PATCH 00/11] constify net pci_device_id

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Arvind Yadav (11): [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id. [PATCH 02/11] rtlwifi: rtl8192se: const

[PATCH 02/11] rtlwifi: rtl8192se: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 28171040 03857 f11 realtek/rtlwi

[PATCH 09/11] net: ec_bhf: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 5113 384 054971579 drivers/net/e

[PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 2833 945 123790 ece realtek/rtlwi

[PATCH 08/11] net: cadence: macb: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 791 336 01127 467 net/ethernet/

[PATCH 06/11] rtlwifi: rtl8188ee: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 3090 912 04002 fa2 realtek/rtlwi

[PATCH 03/11] rtlwifi: rtl8821ae: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 2491 960 03451 d7b realtek/rtlwi

[PATCH 05/11] rtlwifi: rtl8723be: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 3032 912 03944 f68 realtek/rtlwi

[PATCH 07/11] rtlwifi: rtl8192ee: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1899 928 02827 b0b realtek/rtlwi

[PATCH 04/11] rtlwifi: rtl8723ae: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 2775 912 03687 e67 realtek/rtlwi

Re: BUG triggered in tcp_openreq_init_rwin most likely due to 13d3b1ebe2876

2017-07-17 Thread David Ahern
On 7/17/17 11:23 AM, Cong Wang wrote: > I bet req->rsk_listener is NULL, I guess we need the following fix: > > diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h > index 360c082e885c..d41d40ac3efd 100644 > --- a/include/linux/bpf-cgroup.h > +++ b/include/linux/bpf-cgroup.h > @@

Re: [PATCH net-next 06/12] net: dsa: mv88e6xxx: add number of Global 2 IRQs

2017-07-17 Thread Andrew Lunn
On Mon, Jul 17, 2017 at 01:03:40PM -0400, Vivien Didelot wrote: > Similarly to g1_irqs, add a g2_irqs member to the info structure to > indicates the presence of the Global 2 Interrupt Source and Mask > registers. > > At the same time, provide helpers and document the registers since they > differ

[PATCH] atm: zatm: Fix an error handling path in 'zatm_init_one()'

2017-07-17 Thread Christophe JAILLET
If 'dma_set_mask_and_coherent()' fails, we must undo the previous 'pci_request_regions()' call. Adjust corresponding 'goto' to jump at the right place of the error handling path. Signed-off-by: Christophe JAILLET --- drivers/atm/zatm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] ipv4: ipv6: initialize treq->txhash in cookie_v[46]_check()

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 12:35 +0200, Alexander Potapenko wrote: > KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), > which originated from the TCP request socket created in > cookie_v6_check(): > Similar error is reported for cookie_v4_check(). > > Signed-off-by: Alexander Pota

Re: [PATCH net-next] net: Revert "net: add function to allocate sk_buff head without data area"

2017-07-17 Thread David Miller
From: Florian Westphal Date: Mon, 17 Jul 2017 18:56:54 +0200 > It was added for netlink mmap tx, there are no callers in the tree. > The commit also added a check for skb->head != NULL in kfree_skb path, > remove that too -- all skbs ought to have skb->head set. > > Signed-off-by: Florian Westph

Re: [PATCH v2 RFC 0/13] Remove UDP Fragmentation Offload support

2017-07-17 Thread David Miller
From: David Miller Date: Fri, 07 Jul 2017 10:43:26 +0100 (WEST) > This is an RFC patch series, based upon some discussions with > various developers, that removes UFO offloading. > > Very few devices support this operation, it's usefullness is > quesitonable at best, and it adds a non-trivial am

Re: BUG triggered in tcp_openreq_init_rwin most likely due to 13d3b1ebe2876

2017-07-17 Thread Cong Wang
On Sun, Jul 16, 2017 at 4:47 PM, David Ahern wrote: > Hi: > > I am getting the following while testing IPv6 changes: > > [ 3904.250981] TCP: request_sock_TCPv6: Possible SYN flooding on port > 12345. Sending cookies. Check SNMP counters. > [ 3904.252862] >

Re: [net-next PATCH 09/12] bpf: add bpf_redirect_map helper routine

2017-07-17 Thread John Fastabend
On 07/17/2017 10:00 AM, Alexei Starovoitov wrote: > On 7/17/17 9:29 AM, John Fastabend wrote: >> + * int bpf_redirect_map(key, map, flags) >> + * redirect to endpoint in map >> + * @key: index in map to lookup >> + * @map: fd of map to do lookup in >> + * @flags: -- > > could you p

[PATCH net-next 05/12] net: dsa: mv88e6xxx: remove 88E6185 G2 interrupt

2017-07-17 Thread Vivien Didelot
The 88E6185 family has no Global 2 Interrupt Source or Mask registers. Remove the MV88E6XXX_FLAG_G2_INT from MV88E6XXX_FLAGS_FAMILY_6185. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/drive

[PATCH net-next 08/12] net: dsa: mv88e6xxx: add POT flag to 88E6390

2017-07-17 Thread Vivien Didelot
The 88E6390 family clear the Priority Override Table the same way as 88E6352, thus add MV88E6XXX_FLAG_G2_POT to MV88E6XXX_FLAGS_FAMILY_6390. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/d

[PATCH net-next 00/12] net: dsa: mv88e6xxx: cleanup capabilities

2017-07-17 Thread Vivien Didelot
This patch series removes the remaining capabilities as well as the flags bitmap in the info structures. Most of them are turned into ops, or new info members. There is no mv88e6xxx_cap enum or bitmap flags anymore, only mv88e6xxx_info and mv88e6xxx_ops structures. While reviewing and documenting

[PATCH net-next 07/12] net: dsa: mv88e6xxx: distinguish Global 2 Rsvd2CPU

2017-07-17 Thread Vivien Didelot
The 88E6185 family only has one 16-bit register to mark the 16 802.1D reserved multicast addresses in the range of 01:80:C2:00:00:0x as MGMT. The 88E6352 family also has one 16-bit register to mark the 16 GARP reserved multicast addresses in the range of 01:80:C2:00:00:2x as MGMT. Split the exist

[PATCH net-next 03/12] net: dsa: mv88e6xxx: fix 88E6321 family comment

2017-07-17 Thread Vivien Didelot
MV88E6XXX_FAMILY_6321 is undefined, 88E6321's family is 88E6320, fix this. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 53b088166c28

[PATCH net-next 10/12] net: dsa: mv88e6xxx: add a global2_addr info flag

2017-07-17 Thread Vivien Didelot
Similarly to global1_addr, add a global2_addr member in the info structure to describe the presence of the Global 2 Registers. This allows us to get rid of the MV88E6XXX_FLAG_GLOBAL2 flag. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c| 28 +++- d

[PATCH net-next 06/12] net: dsa: mv88e6xxx: add number of Global 2 IRQs

2017-07-17 Thread Vivien Didelot
Similarly to g1_irqs, add a g2_irqs member to the info structure to indicates the presence of the Global 2 Interrupt Source and Mask registers. At the same time, provide helpers and document the registers since they differ a bit between 88E6352 and 88E6390 families. This allows us to get rid of t

  1   2   3   >