On Sun, May 28, 2017 at 5:23 AM, Jes Sorensen wrote:
> On 05/27/2017 05:02 PM, Or Gerlitz wrote:
>>
>> On Sat, May 27, 2017 at 12:16 AM, Jes Sorensen
>> wrote:
>>>
>>> This gets rid of the temporary #ifdef spaghetti and allows the code to
>>> compile without offload support enabled.
>> I am pret
On Sat, May 27, 2017 at 5:11 PM, David Miller wrote:
> From: Y Song
> Date: Sat, 27 May 2017 13:52:27 -0700
>
>> On Sat, May 27, 2017 at 1:23 PM, Y Song wrote:
>>>
>>> From verifier error message:
>>> ==
>>> 0: (bf) r6 = r1
>>>
>>> 1: (18) r9 = 0xffee
>>>
>>> 3: (69) r0 = *(u16 *)(r6 +16
On 5/27/17 7:02 PM, kbuild test robot wrote:
> Hi David,
>
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/David-Ahern/net-another-round-of-extack-handling-for-routing/20170528-062659
> config: ia64-allmodconfig (attached as .config)
> compiler
On 05/27/2017 05:02 PM, Or Gerlitz wrote:
On Sat, May 27, 2017 at 12:16 AM, Jes Sorensen wrote:
This gets rid of the temporary #ifdef spaghetti and allows the code to
compile without offload support enabled.
Hi Jes,
I am pretty sure we can do that exercise you're up to without any
spaghetti
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: a3995460491d4570af8e99ad34ddf6d1948254d9
commit: 6335e9f2446b44139ac0722a81759a2b2f90bb4c [329/368] net: dsa: mv88e6xxx:
mv88e6390X SERDES support
config: i386-randconfig-i1-05241633 (attached as .config)
co
Hi David,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/David-Ahern/net-another-round-of-extack-handling-for-routing/20170528-062659
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
wget
https:/
For accessing PCIe ctrl memory we depend on the BAR aperture being
large enough to reach all registers. Since the BAR aperture can
be set in the flash make sure the driver won't oops the kernel
when the PCIe configuration is unusual.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netron
If ioremap of PCIe ctrl memory failed we can still get to it through
PCI config space, therefore we allow ioremap() to fail. When if fails,
however, we must leave all the IOMEM pointers as NULL. Currently we
would calculate csr and em pointers, adding offsets to the potential
NULL value and there
We only kick RX free buffer queue controller every NFP_NET_FL_BATCH
(currently 16) entries. This means that we will always kick the QC
when write ring index is divisable by NFP_NET_FL_BATCH. There is
no need to keep counts.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/n
We want to support extendable commands, where newer versions
of the management FW may provide more information. Zero out
the communication buffer before passing control to NSP. This
way if management FW is old and only fills in first N bytes,
the remaining ones will be zeros which extended ABI fi
From: Pablo Cascón
Expose FW app ability to change MAC address at runtime. Make sure
we only depend on it if FW app advertised the right capability.
Signed-off-by: Pablo Cascón
Reviewed-by: Jakub Kicinski
---
.../net/ethernet/netronome/nfp/nfp_net_common.c| 44 +-
dri
We currently print reserved BAR mappings info as we create them.
This makes the probe logs longer than necessary. Print into a
buffer instead and log all the info as a single line.
Signed-off-by: Jakub Kicinski
---
.../net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 19 +++
There is currently no timeout to the resource and lock acquiring
loops. We printed warnings and depended on user sending a signal
to the waiting process to stop the waiting. This doesn't work
very well when wait happens out of a work queue. The simplest
example of that is PCI probe. When user l
This series brings updates to core PCI code, SR-IOV, exposes
firmware's capability to change MAC address at runtime and HWMON
interfaces.
The PCI code updates include resiliency improvement in conditions
which are quite unusual, but still shouldn't make the driver oops.
We also handle very lar
PCI subsystem has support for drivers limiting the number of VFs
available below what the IOV capability claims. Make use of it.
While at it remove the #ifdef/#endif on CONFIG_PCI_IOV, it was
there to avoid unnecessary warnings in case device read failed
but kernel doesn't have SR-IOV support any
Ring pointers are unsigned. Fix the print formats to avoid
showing users negative values.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_deb
nfp_cpp_{read,write}() helpers perform device memory mapping (setting
the PCIe -> NOC translation BARs) and accessing it. They, however,
currently implicitly expect that the length of entire operation will
fit in one BAR translation window. There is a number of 16MB windows
available, and we don'
From: David Brunecz
Add support for retrieving temperature and power sensor and limits via NSP.
Signed-off-by: David Brunecz
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/Makefile| 1 +
drivers/net/ethernet/netronome/nfp/nfp_hwmon.c | 190 +
Adding ring size to index calculation is pointless, since index
will be masked with ring size - 1.
Suggested-by: David Laight
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
From: Y Song
Date: Sat, 27 May 2017 13:52:27 -0700
> On Sat, May 27, 2017 at 1:23 PM, Y Song wrote:
>>
>> From verifier error message:
>> ==
>> 0: (bf) r6 = r1
>>
>> 1: (18) r9 = 0xffee
>>
>> 3: (69) r0 = *(u16 *)(r6 +16)
>>
>> invalid bpf_context access off=16 size=2
>> ==
>>
>> The
From: Felix Manlunas
Date: Sat, 27 May 2017 08:56:33 -0700
> From: VSR Burru
>
> Add support for OVS offload. By default PF driver runs in basic NIC mode
> as usual. To run in OVS mode, use the insmod parameter "fw_type=ovs".
>
> For OVS mode, create a management interface for communication
From: Florian Fainelli
Date: Sat, 27 May 2017 10:42:25 -0700
> Some Ethernet drivers will attach/connect to a PHY device before calling
> register_netdevice() which is responsible for calling
> netdev_register_kobject()
> which would do the network device's kobject initialization. In such a case
Move filter struct to ip_common.h as struct link_filter.
Signed-off-by: David Ahern
---
ip/ip_common.h | 20
ip/ipaddress.c | 22 +-
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/ip/ip_common.h b/ip/ip_common.h
index 450b45ac2b60..2b3cf
Change print_linkinfo_brief to take the filter as an input arg.
If the arg is NULL, use the global filter in ipaddress.c.
Signed-off-by: David Ahern
---
ip/ip_common.h | 3 ++-
ip/ipaddress.c | 35 ---
ip/iplink.c| 2 +-
3 files changed, 23 insertions(+), 17
Refactor ip address to export its capability to save a list of nlmsg's
for links and its link filter. Use both to add an 'ip vrf show' command
to list all configured VRF with table id.
David Ahern (4):
ip address: Export ip_linkaddr_list
ip address: Move filter struct to ip_common.h
ip addre
Add show command to list all configured VRF and their table ids.
Signed-off-by: David Ahern
---
ip/ipvrf.c| 153 --
man/man8/ip-vrf.8 | 11
2 files changed, 159 insertions(+), 5 deletions(-)
diff --git a/ip/ipvrf.c b/ip/ipvrf.c
i
ipaddr_list_flush_or_save generates a list of nlmsg's for links and
optionally for addresses. Move the code into ip_linkaddr_list and
export it along with the supporting infrastructure.
API to use this function is:
struct nlmsg_chain linfo = { NULL, NULL};
struct nlmsg_chain ainfo
From: Vivien Didelot
Date: Fri, 26 May 2017 18:02:42 -0400
> mv88e6xxx_serdes_power returns an error, so no need to print an error
> message inside of it. Rather print it in its caller when the error is
> ignored, which is in the mv88e6xxx_port_disable void function.
>
> Catch and return its err
From: Vladislav Yasevich
Date: Sat, 27 May 2017 10:14:33 -0400
> First is the patch to add IFLA_EVENT attribute to the netlink message. It
> supports only currently white-listed events.
> Like before, this is just an attribute that gets added to the rtnetlink
> message only when the messaged was
From: Firo Yang
Date: Fri, 26 May 2017 22:37:38 +0800
> syszkaller fuzzer triggered a divide by zero, when set calibration
> through ioctl().
>
> To fix it, test 'bitrate' if it is negative or 0, just return -EINVAL.
>
> Reported-by: Andrey Konovalov
> Signed-off-by: Firo Yang
Applied, thank
From: Shawn Guo
Date: Sat, 27 May 2017 16:13:34 +0800
> On Fri, May 26, 2017 at 03:02:42PM -0400, David Miller wrote:
>> From: Andrew Lunn
>> Date: Fri, 26 May 2017 01:44:42 +0200
>>
>> > The mv88e6xxx switch driver allows the size of the attached EEPROM to
>> > be described in DT. This propert
mpls_route_add and mpls_route_del have the same checks on the label.
Move to a helper. Avoid duplicate extack messages in the next patch.
Signed-off-by: David Ahern
---
net/mpls/af_mpls.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/net/m
nla_get_via is only used in af_mpls.c. Remove declaration from internal.h
and move up in af_mpls.c before first use. Code move only; no
functional change intended.
Signed-off-by: David Ahern
---
net/mpls/af_mpls.c | 96 ++---
net/mpls/internal.h |
err is initialized to EINVAL and not used before it is set again.
Remove the unnecessary initialization.
Signed-off-by: David Ahern
---
net/mpls/af_mpls.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index a953fcf169ba..94b3317232a6 100644
--- a/ne
Pass extack arg down to lwtunnel_build_state and the build_state callbacks.
Add messages for failures in lwtunnel_build_state, and add the extarg to
nla_parse where possible in the build_state callbacks.
Signed-off-by: David Ahern
---
include/linux/netlink.h | 10 ++
include/net/lwtunn
Pass extack down to lwtunnel_valid_encap_type and
lwtunnel_valid_encap_type_attr. Add messages for unknown
or unsupported encap types.
Signed-off-by: David Ahern
---
include/net/lwtunnel.h | 13 +
net/core/lwtunnel.c | 18 +-
net/ipv4/fib_frontend.c | 6 --
Fill in extack for errors in build_state for mpls lwt encap including
passing extack to nla_get_labels and adding error messages for failures
in it.
Signed-off-by: David Ahern
---
net/mpls/af_mpls.c | 49 ++--
net/mpls/internal.h | 2 +-
ne
Add error messages for failures in adding and deleting mpls routes.
This covers most of the annoying EINVAL errors.
Signed-off-by: David Ahern
---
net/mpls/af_mpls.c | 125
net/mpls/internal.h | 2 +-
2 files changed, 87 insertions(+), 40 d
fib_table_insert and fib_table_delete have the same checks on the prefix
and length. Refactor into a helper. Avoids duplicate extack messages in
the next patch.
Signed-off-by: David Ahern
---
net/ipv4/fib_trie.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
d
This set focuses on passing extack through lwtunnel and MPLS with
additional catches for IPv4 route add and minor cleanups in MPLS
encountered passing the extack arg around.
v2
- mindful of bloat adding duplicate messages
+ refactored prefix and prefix length checks in ipv4's fib_table_insert
Add extack error message for invalid prefix length and invalid prefix.
Example of the latter is a route spec containing 172.16.100.1/24, where
the /24 mask means the lower 8-bits should be 0. Amazing how easy that
one is to overlook when an EINVAL is returned.
Signed-off-by: David Ahern
---
incl
On Tue, May 9, 2017 at 7:52 PM, Niklas Cassel wrote:
> From: Niklas Cassel
Commit message?
> seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> - i, (unsigned int)virt_to_phys(ep),
> + i, (unsigned int)
ieee80211_tx_status() is only one of the possible ways a driver can
report a handled packet, some drivers call this for every packet while
others calls it rarely or never.
In order to invoke the TX LED in the non-status reporting cases this
patch pushes the call to ieee80211_led_tx() into
ieee8021
Dear Friend.
Greetings.
My Name is Mustapha Ali, I am a banker by profession. I am from
Ouagadougou, Burkina Faso, West Africa. My reason of contacting you is
to transfer an abandoned fund $5M US Dollars to your account if you
agree with me.
The owner of this fund died since 2003 with his Next O
On 5/27/17 8:14 AM, Vladislav Yasevich wrote:
> Whenever a user changes bonding options, a NETDEV_CHANGEINFODATA
> notificatin is generated which results in a rtnelink message to
> be sent. While runnig 'ip monitor', we can actually see 2 messages,
> one a result of the event, and the other a resu
On 5/27/17 8:14 AM, Vladislav Yasevich wrote:
> When netdev events happen, a rtnetlink_event() handler will send
> messages for every event in it's white list. These messages contain
> current information about a particular device, but they do not include
> the iformation about which event just ha
On Sat, May 27, 2017 at 12:16 AM, Jes Sorensen wrote:
> This gets rid of the temporary #ifdef spaghetti and allows the code to
> compile without offload support enabled.
Hi Jes,
I am pretty sure we can do that exercise you're up to without any
spaghetti cooking and even put more code under that
On Sat, May 27, 2017 at 8:18 PM, Tom Herbert wrote:
> I think the problem is I don't know what you're dealing with. The only
> thing I can derive from the commit log is that tos and ttl are being
> extracted, but I don't know why they are needed.
The current case for matching on TTL I am dealing
On Sat, May 27, 2017 at 1:23 PM, Y Song wrote:
>
> From verifier error message:
> ==
> 0: (bf) r6 = r1
>
> 1: (18) r9 = 0xffee
>
> 3: (69) r0 = *(u16 *)(r6 +16)
>
> invalid bpf_context access off=16 size=2
> ==
>
> The offset 16 of struct __sk_buff is hash.
> What instruction #3 tries
>From verifier error message:
==
0: (bf) r6 = r1
1: (18) r9 = 0xffee
3: (69) r0 = *(u16 *)(r6 +16)
invalid bpf_context access off=16 size=2
==
The offset 16 of struct __sk_buff is hash.
What instruction #3 tries to do is to access 2 bytes of the hash value
instead of full 4 bytes.
T
GREETINGS,
I AM BORTE ,I WAS DIAGNOSE WITH OVARIAN CANCER,WHICH DOCTORS HAVE
CONFIRMED THAT I HAVE ONLY FEW WEEKS TO LIVE, SO I HAVE DECIDED TO
DONATE EVERYTHING I HAVE TO THE ORPHANAGE AND THE POOR WIDOWS THROUGH
YOU IN YOUR AREA.PLEASE KINDLY REPLY ME ONLY ON MY EMAIL ADDRES HERE
(borteog
Some Ethernet drivers will attach/connect to a PHY device before calling
register_netdevice() which is responsible for calling netdev_register_kobject()
which would do the network device's kobject initialization. In such a case,
sysfs_create_link() would return -ENOENT because the network device's
On Sat, May 27, 2017 at 9:31 AM, Or Gerlitz wrote:
> On Thu, May 25, 2017 at 7:22 PM, Tom Herbert wrote:
>> On Thu, May 25, 2017 at 6:24 AM, Or Gerlitz wrote:
>>> Add support for dissection of ip tos and ttl and ipv6 traffic-class
>>> and hoplimit. Both are dissected into the same struct.
>
>>>
On Thu, May 25, 2017 at 7:22 PM, Tom Herbert wrote:
> On Thu, May 25, 2017 at 6:24 AM, Or Gerlitz wrote:
>> Add support for dissection of ip tos and ttl and ipv6 traffic-class
>> and hoplimit. Both are dissected into the same struct.
>> Uses similar call to ip dissection function as with tcp, ar
On Thu, May 25, 2017 at 6:42 PM, Tom Herbert wrote:
> On Thu, May 25, 2017 at 6:24 AM, Or Gerlitz wrote:
>> Add support for dissection of ip tos and ttl and ipv6 traffic-class
>> and hoplimit. Both are dissected into the same struct.
>> --- a/include/net/flow_dissector.h
>> +++ b/include/net/flo
On 2017-05-22 14:26:44 [-0700], Eric Dumazet wrote:
> On Mon, May 22, 2017 at 12:26 PM, Sebastian Andrzej Siewior
> wrote:
> > Since commit 217f69743681 ("net: busy-poll: allow preemption in
> > sk_busy_loop()") there is an explicit do_softirq() invocation after
> > local_bh_enable() has been invo
From: VSR Burru
Add support for OVS offload. By default PF driver runs in basic NIC mode
as usual. To run in OVS mode, use the insmod parameter "fw_type=ovs".
For OVS mode, create a management interface for communication with NIC
firmware. This communication channel uses PF0's I/O rings.
Bum
On May 26, 2017 8:34:18 PM PDT, Florian Fainelli wrote:
>Some Ethernet drivers will attach/connect to a PHY device before
>calling
>register_netdevice() which is responsible for calling
>netdev_register_kobject()
>which would do the network device's kobject initialization. In such a
>case,
>sysfs_
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -148,17 +148,18 @@ void __ndisc_fill_addr_option(struct sk_buff *skb, int
> type, void *data,
> space -= data_len;
> - if (space > 0)
> - memset(opt, 0, space);
> +
> + memset(opt, 0, space);
This can't be right.
A
On Sat, May 27, 2017 at 06:38:14AM +0200, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
Hi Julia
Thanks for the patch. However, Vivien already submitted a patch.
Andrew
When netdev events happen, a rtnetlink_event() handler will send
messages for every event in it's white list. These messages contain
current information about a particular device, but they do not include
the iformation about which event just happened. So, it is impossible
to tell what just happen
Add IFLA_EVENT handling so that event types can be viewed with
'monitor' command. This gives a little more information for why
a given message was receivied.
Signed-off-by: Vladislav Yasevich
---
include/linux/if_link.h | 11 +++
ip/ipaddress.c | 21 +
2 fil
Whenever a user changes bonding options, a NETDEV_CHANGEINFODATA
notificatin is generated which results in a rtnelink message to
be sent. While runnig 'ip monitor', we can actually see 2 messages,
one a result of the event, and the other a result of state change
that is generated bo netdev_state_c
First is the patch to add IFLA_EVENT attribute to the netlink message. It
supports only currently white-listed events.
Like before, this is just an attribute that gets added to the rtnetlink
message only when the messaged was generated as a result of a netdev event.
In my case, this is necessary s
On 5/27/17 12:00 AM, Roopa Prabhu wrote:
> On Fri, May 26, 2017 at 11:18 AM, David Miller wrote:
>> From: Roopa Prabhu
>> Date: Thu, 25 May 2017 10:42:32 -0700
>>
>>> This series adds a new RTM_F_FIB_MATCH flag to return matched fib result
>>> with RTM_GETROUTE. This is useful for applications an
On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote:
> By now, stmmac_pci_info only contains a single entry.
_For now_.
> Register this
> directly with the PCI device table, removing one indirection.
I am not sure this patch is needed.
Next time something comes up we would need to extend this an
On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote:
> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.
> struct stmmac_pci_dmi_data {
> - const char *name;
> - const char *asset_tag;
> - unsigned int func;
> + int func;
> int phy_addr;
> };
Ca
On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote:
> Move the special case for the early Galileo firmware into
> quark_default_setup. This allows to use stmmac_pci_find_phy_addr for
> non-quark cases.
> ret = stmmac_pci_find_phy_addr(pdev, info);
> - if (ret < 0)
> - r
On Sat, May 27, 2017 at 4:13 PM, Andy Shevchenko
wrote:
> On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote:
>> Make stmmac_default_data compatible with stmmac_pci_info.setup and use
>> an info structure for all devices. This allows to make the probing more
>> regular.
> Or converting defines fi
On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote:
> Make stmmac_default_data compatible with stmmac_pci_info.setup and use
> an info structure for all devices. This allows to make the probing more
> regular.
> +#define STMMAC_DEVICE(vendor_id, dev_id, info) { \
> + PCI_DEVICE(vendor
I want to store the value of snd_cwnd when a congestion event occurs
(value before snd_cwnd is reduced), and the new value of snd_cwnd (the
value it has been reduced to). In other words: the congestion window
before and after a congestion event occurs.
I'm uncertain where (and how) it would be log
On 2017/5/26 3:49, Alexander Duyck wrote:
> On Thu, May 25, 2017 at 6:35 AM, Ding Tianhong
> wrote:
>>
>> On 2017/5/9 8:48, Casey Leedom wrote:
>>>
>>> | From: Alexander Duyck
>>> | Date: Saturday, May 6, 2017 11:07 AM
>>> |
>>> | | From: Ding Tianhong
>>> | | Date: Fri, May 5, 2017 at 8:08 P
Fri, May 26, 2017 at 06:55:25PM CEST, xiyou.wangc...@gmail.com wrote:
>On Fri, May 26, 2017 at 7:54 AM, David Miller wrote:
>> And I also didn't find the boolean logic hard to understand at all.
>>
>> It is in fact a very common pattern to pass a "create" boolean into
>> lookup functions, to tell
Fri, May 26, 2017 at 04:54:43PM CEST, da...@davemloft.net wrote:
>From: Jiri Pirko
>Date: Fri, 26 May 2017 07:53:52 +0200
>
>> Thu, May 25, 2017 at 06:14:56PM CEST, da...@davemloft.net wrote:
>>>From: Cong Wang
>>>Date: Tue, 23 May 2017 09:42:37 -0700
>>>
tcf_chain_get() always creates a new
Fri, May 26, 2017 at 04:59:12PM CEST, da...@davemloft.net wrote:
>From: Jiri Pirko
>Date: Fri, 26 May 2017 09:21:29 +0200
>
>> From: Jiri Pirko
>>
>> Alhough I believe that this create/nocreate dance is completelly
>> pointless, at least make it a bit nicer and easier to read.
>> Push the decisi
On Fri, May 26, 2017 at 03:02:42PM -0400, David Miller wrote:
> From: Andrew Lunn
> Date: Fri, 26 May 2017 01:44:42 +0200
>
> > The mv88e6xxx switch driver allows the size of the attached EEPROM to
> > be described in DT. This property is missing from the binding
> > documentation. Add it. And ma
On Fri, May 26, 2017 at 01:44:44AM +0200, Andrew Lunn wrote:
> Two of the Ethernet switches on this board have EEPROMs connected.
> Add the eeprom-length property to the device tree, making it possible
> to access the EEPROM using ethtool -e.
>
> Signed-off-by: Andrew Lunn
Applied with a bit upd
77 matches
Mail list logo
