Re: [RFC] skbuff: introduce skb_put_zero()

2017-05-25 Thread Johannes Berg
On Thu, 2017-05-25 at 13:01 -0400, David Miller wrote: > From: Johannes Berg > Date: Wed, 24 May 2017 09:07:47 +0200 > > > From: Johannes Berg > >  > > This pattern was introduced a number of times in mac80211 just now, > > and since it's present in a number of other places it makes sense > > to

[patch net-next 10/18] mlxsw: spectrum_router: Allocate FID prior to RIF configuration

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel The following patches are going to re-arrange the FID and RIF code, so that when the RIF is configured to the device based on the information present in the RIF struct (which points to a FID). For this reason, move the FID allocation to just before the RIF configuration. Sign

[patch net-next 12/18] mlxsw: spectrum_router: Extend the RIF struct

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel Currently, when a Subport RIF is configured, the LAG status and VLAN of the underlying port are read from the port itself. This is problematic, as we would like to have common code to configure all types of RIFs, which aren't necessarily bound to a port. Instead, embed the RIF

[patch net-next 11/18] mlxsw: spectrum_router: Allocate RIF prior to its configuration

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel In the following patches the RIF's configuration function is going to expect a RIF struct with all the necessary information. Therefore, allocate the RIF just before it's configured to the device. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/m

[patch net-next 08/18] mlxsw: spectrum: Don't create FIDs upon creation of VLAN uppers

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel Up until now we used to create FIDs upon the creation of VLAN uppers on top of the VLAN-aware bridge. This was done so that in case a router interface (RIF) was configured on top of the bridge, the FID would already be there. Instead, simplify the code and only create the FID

[patch net-next 13/18] mlxsw: spectrum_router: Configure RIFs based on RIF struct

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel All the information necessary for the configuration of RIFs can now be found in the RIF struct itself, so reduce the arguments list. This gets us one step closer to the common RIF core. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlx

[patch net-next 16/18] mlxsw: spectrum_router: Determine VR first when creating RIF

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel All RIF types are associated with a virtual router (VR), so determine VR first when creating a RIF. That way, we can more easily integrate the common RIF core in the following patches. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxs

[patch net-next 14/18] mlxsw: spectrum_router: Destroy RIF only based on its struct

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel Now that all the information to create a RIF is contained within the RIF struct itself, we can also simplify the destruction logic. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 12 ++-- 1 file chan

[patch net-next 15/18] mlxsw: spectrum_router: Flood packets to router after RIF creation

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel If a packet ingress the router but can't be assigned an ingress RIF, it's dropped. Therefore, in the case of RIF configured on top of a bridge, it makes sense to start flooding broadcast packets to the router only after the RIF was created. Signed-off-by: Ido Schimmel Signed

[patch net-next 17/18] mlxsw: spectrum: Implement common FID core

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel The device supports three types of FIDs. 802.1Q and 802.1D FIDs for VLAN-aware and VLAN-unaware bridges (respectively) and rFIDs to transport packets to the router block. The different users (e.g., bridge, router, ACLs) of the FIDs infrastructure need not know about the intern

[patch net-next 09/18] mlxsw: spectrum: Replace vPorts with Port-VLAN

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel As explained in the cover letter, since the introduction of the bridge offload in the mlxsw driver, information related to the offloaded bridge and bridge ports was stored in the individual port struct, mlxsw_sp_port. This lead to a bloated struct storing both physical propert

[patch net-next 03/18] mlxsw: spectrum: Set port's mode according to FID mappings

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel We currently transition the port to "Virtual mode" upon the creation of its first VLAN upper, as we need to classify incoming packets to a FID using {Port, VID} and not only the VID. However, it's more appropriate to transition the port to this mode when the {Port, VID} are ac

[patch net-next 04/18] mlxsw: spectrum: Introduce Port-VLAN structure

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel This is the first step in the transition from the vPort model to a unified Port-VLAN structure. The new structure is defined and created / destroyed upon invocation of the 8021q ndos, but it's not actually used throughout the code. Subsequent patches will initialize it correct

[patch net-next 18/18] mlxsw: spectrum_router: Implement common RIF core

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel The mlxsw driver currently implements three types of RIFs. VLAN and FID RIFs for L3 interfaces on top of VLAN-aware and VLAN-unaware bridges (respectively) and Subport RIFs for all other L3 interfaces. All the RIF types follow a common configuration procedure, which only diffe

[patch net-next 07/18] mlxsw: spectrum: Don't lose bridge port device during enslavement

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel Currently, when port netdevs (or their uppers) are enslaved to a bridge, we simply propagate the CHANGEUPPER event all the way down and lose the context of the actual netdevice used as the bridge port. This leads to a lot of information hanging off the ports (and vPorts), whic

[patch net-next 05/18] mlxsw: spectrum: Change signature of FID leave function

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel When a vPort is destroyed, it leaves the FID it's currently mapped to (if any) and drops the reference. The FID's leave function expects to get the vPort as its argument, but this will have to change when the vPort model is retired. Change the function signature to expect a Po

[patch net-next 00/18] mlxsw: Improve extensibility

2017-05-25 Thread Jiri Pirko
From: Jiri Pirko Ido says: Since the initial introduction of the bridge offload in commit 56ade8fe3fe1 ("mlxsw: spectrum: Add initial support for Spectrum ASIC") the per-port struct was used to store both physical properties of the port as well as logical bridge properties such as learning and a

[patch net-next 06/18] mlxsw: spectrum_router: Replace vPorts with Port-VLAN

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel We're going to get rid of vPorts completely later in the patchset, but the router code is self-contained, so it's a good candidate to start the transition with. Convert all the functions that expects to operate on a vPort to operate on a Port-VLAN instead. Signed-off-by: Ido

[patch net-next 02/18] bridge: Export multicast enabled state

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel During enslavement to a bridge, after the CHANGEUPPER is sent, the multicast enabled state of the bridge isn't propagated down to the offloading driver unless it's changed. This patch allows such drivers to query the multicast enabled state from the bridge, so that they'll be

[patch net-next 01/18] bridge: Export VLAN filtering state

2017-05-25 Thread Jiri Pirko
From: Ido Schimmel It's useful for drivers supporting bridge offload to be able to query the bridge's VLAN filtering state. Currently, upon enslavement to a bridge master, the offloading driver will only learn about the bridge's VLAN filtering state after the bridge device was already linked wit

A bug report for Linux TCP congestion control algorithms

2017-05-25 Thread Wei Sun
Hi there, we find a special case for Linux TCP undo operations where tp->snd_cwnd could be extremely large (e.g., 4294967294) by two consecutive cwnd undo operations when using reno/veno/vegas/highspeed/HTCP/yeah/westwood/hybla/illinois/scalable/lp congestion control algorithms in the latest long-

[PATCH v2 net-next 1/3] perf, bpf: Add BPF support to all perf_event types

2017-05-25 Thread Alexei Starovoitov
From: Teng Qin Allow BPF program to attach to all perf_event types supported by the current bpf and perf code logic, including HW_CACHE, RAW, and dynamic pmu events. Also add support for reading these event counters using bpf_perf_event_read() helper. Signed-off-by: Teng Qin Signed-off-by: Ale

[PATCH v2 net-next 3/3] bpf: update perf event helper functions documentation

2017-05-25 Thread Alexei Starovoitov
From: Teng Qin This commit updates documentation of the bpf_perf_event_output and bpf_perf_event_read helpers to match their implementation. Signed-off-by: Teng Qin Signed-off-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 11 +++ tools/include/uapi/linux/bpf.h | 11 +

[PATCH v2 net-next 2/3] samples/bpf: add samples for more perf event types

2017-05-25 Thread Alexei Starovoitov
From: Teng Qin This commit adds test code to attach BPF to HW_CACHE and RAW type events and updates clean-up logic to disable the perf events before closing pmu_fd. This commit also adds test code to read SOFTWARE, HW_CACHE, RAW and dynamic pmu events from BPF program using bpf_perf_event_read()

[PATCH v2 net-next 0/3] bpf: Add BPF support to all perf_event

2017-05-25 Thread Alexei Starovoitov
v1->v2: address Peter's feedback. Refactor patch 1 to allow attaching bpf programs to all event types and reading counters from all of them as well patch 2 - more tests patch 3 - address Dave's feedback and document bpf_perf_event_read() and bpf_perf_event_output() properly Teng Qin (3): perf, b

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-25 Thread Florian Fainelli
On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" wrote: >In gmane.linux.kernel sean.w...@mediatek.com wrote: >> From: Sean Wang > >> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >> Mediatek router platforms such as MT7623A or MT7623N platform which >> includes 7-port G

Re: [Patch net-next] net_sched: only create filter chains for new filters/actions

2017-05-25 Thread Jiri Pirko
Thu, May 25, 2017 at 06:14:56PM CEST, da...@davemloft.net wrote: >From: Cong Wang >Date: Tue, 23 May 2017 09:42:37 -0700 > >> tcf_chain_get() always creates a new filter chain if not found >> in existing ones. This is totally unnecessary when we get or >> delete filters, new chain should be only c

Re: Deleting a dynamic mac entry..

2017-05-25 Thread Manohar Kumar
On Wed, May 24, 2017 at 6:11 PM, Toshiaki Makita wrote: > On 2017/05/25 3:05, Manohar Kumar wrote: >> Thanks, Toshiaki. >> >> What is the right way to set the default_pvid using the bridge command >> ? I tried this, which fails.. >> >> root@net-3:~# ip link set dev vxlan0 name untagged type vlan i

Re: please revert. Was: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-25 Thread Alexei Starovoitov
On Fri, May 26, 2017 at 12:13:27AM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Thu, 25 May 2017 20:58:32 -0700 > > > Dave, please revert this Innova fpga stuff. > > I think you pushed it by accident, since it was mixed with > > other valid changes. > > The discussion didn't conc

Re: please revert. Was: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-25 Thread David Miller
From: Alexei Starovoitov Date: Thu, 25 May 2017 20:58:32 -0700 > Dave, please revert this Innova fpga stuff. > I think you pushed it by accident, since it was mixed with > other valid changes. > The discussion didn't conclude. > Myself and Jes are clearly against such changes. > It definitely nee

please revert. Was: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-25 Thread Alexei Starovoitov
On Tue, May 23, 2017 at 02:44:02PM +0300, Saeed Mahameed wrote: > From: Ilan Tayari > > Mellanox Innova is a NIC with ConnectX and an FPGA on the same > board. The FPGA is a bump-on-the-wire and thus affects operation of > the mlx5_core driver on the ConnectX ASIC. > > Add basic support for Inno

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread David Miller
From: Stephen Hemminger Date: Thu, 25 May 2017 15:05:02 -0700 > Ok, the issue is that lockdep is being stupid and thinking that > seqcount's behave like locks. Well.. they do. That's why they have that annotation.

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-25 Thread Alexei Starovoitov
On Thu, May 25, 2017 at 05:20:04AM +, Ilan Tayari wrote: > > If you do want this, then splitting some of the logic to a > separate kernel object will not gain anything useful (logic would stay > the same), and just pollute the exported symbol table and open up the door > for issues of inter-mo

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

2017-05-25 Thread Alexei Starovoitov
On Thu, May 25, 2017 at 05:38:26PM -0700, David Daney wrote: > Since the eBPF machine has 64-bit registers, we only support this in > 64-bit kernels. As of the writing of this commit log test-bpf is showing: > > test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed] > > All current test cas

[PATCH] mwifiex: simplify the code around ra_list

2017-05-25 Thread Shawn Lin
We don't need to check if the list is empty separately as we could use list_first_entry_or_null to cover it. Signed-off-by: Shawn Lin --- drivers/net/wireless/marvell/mwifiex/tdls.c | 7 ++- drivers/net/wireless/marvell/mwifiex/wmm.c | 8 ++-- 2 files changed, 4 insertions(+), 11 delet

[PATCH 3/5] MIPS: Add some instructions to uasm.

2017-05-25 Thread David Daney
Follow on patches for eBPF JIT require these additional instructions: insn_bgtz, insn_blez, insn_ddivu, insn_dmultu, insn_dsbh, insn_dshd, insn_dsllv, insn_dsra32, insn_dsrav, insn_dsrlv, insn_lbu, insn_movn, insn_movz, insn_multu, insn_nor, insn_sb, insn_sh, insn_slti, insn_dinsu ...

[PATCH 5/5] MIPS: Add support for eBPF JIT.

2017-05-25 Thread David Daney
Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed] All current test cases are successfully compiled. Signed-off-by: David Daney --- arch/mips

[PATCH 4/5] MIPS: Sort uasm enum opcode elements.

2017-05-25 Thread David Daney
The enum opcode list started out sorted, but many elements have since been added. Resort it. No functional change. Signed-off-by: David Daney --- arch/mips/mm/uasm.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/mips/mm/uasm.c b/arc

[PATCH 2/5] MIPS: Correctly define DBSHFL type instruction opcodes.

2017-05-25 Thread David Daney
DSHD was incorrectly classified as being BSHFL, and DSHD was missing altogether. Signed-off-by: David Daney --- arch/mips/include/uapi/asm/inst.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h ind

[PATCH 1/5] MIPS: Optimize uasm insn lookup.

2017-05-25 Thread David Daney
Instead of doing a linear search through the insn_table for each instruction, use the opcode as direct index into the table. This will give constant time lookup performance as the number of supported opcodes increases. Make the tables const as they are only ever read. For uasm-mips.c sort the tab

[PATCH 0/5] MIPS: Implement eBPF JIT.

2017-05-25 Thread David Daney
The first four patches improve MIPS uasm in preparation for use by the JIT. The final patch is the eBPF JIT implementation. I am CCing netdev@ and the BPF maintainers for their comments, but would expect Ralf to merge via the MIPS tree if and when it all looks good. David Daney (5): MIPS: Opti

Re:Re: [PATCH net-next] net: rps: Add the rfs_needed check when record flow hash

2017-05-25 Thread Gao Feng
Hi David & Eric, At 2017-05-26 01:11:41, "David Miller" wrote: >From: gfree.w...@vip.163.com >Date: Wed, 24 May 2017 15:35:59 +0800 > >> >> +static inline void sock_rps_record_flow_hash(__u32 hash) >> +{ >> +#ifdef CONFIG_RPS >> +if (static_key_false(&rfs_needed)) >> +_sock_rps_

[PATCH 1/2] net: dsa: mv88e6xxx: Add eeprom-length to binding

2017-05-25 Thread Andrew Lunn
The binding documentation for the mv88e6xxx switch is missing the eeprom-length property, which has been implemented since May 2016, commit f8cd8753def0 ("dsa: mv88e6xxx: Handle eeprom-length property") Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 4

[PATCH 0/2] Document and use eeprom-length property

2017-05-25 Thread Andrew Lunn
The mv88e6xxx switch driver allows the size of the attached EEPROM to be described in DT. This property is missing from the binding documentation. Add it. And make use of it on the ZII Devel B board. David, Shawn, please could you talk amongs yourself to decide who takes what. Andrew Lunn (2):

[PATCH 2/2] ARM: VF610: ZII devel b: Add switch eeprom-length properties

2017-05-25 Thread Andrew Lunn
Two of the Ethernet switches on this board have EEPROMs connected. Add the eeprom-length property to the device tree, making it possible to access the EEPROM using ethtool -e. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [PATCH v3 net-next 5/5] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable

2017-05-25 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > static int mv88e6xxx_serdes_power(struct mv88e6xxx_chip *chip, int port, > bool on) > { > - if (chip->info->ops->serdes_power) > - return chip->info->ops->serdes_power(chip, port, on); > + int err = 0; > > -

Re: [PATCH v3 net-next 1/5] net: dsa: mv88e6xxx: Move phy functions into phy.[ch]

2017-05-25 Thread Vivien Didelot
Andrew Lunn writes: > The upcoming SERDES support will need to make use of PHY functions. Move > them out into a file of there own. No code changes. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

[PATCH v3 net-next 4/5] net: dsa: mv88e6xxx: mv88e6390X SERDES support

2017-05-25 Thread Andrew Lunn
The mv88e6390X family has 8 SERDES lanes. These can be used for 2 10Gbps ports, ports 9 or 10. If these ports are used at slower speeds, the SERDES lanes become available for other ports for 1000Base-X. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v3 net-next 3/5] net: dsa: mv88e6xxx: Remove SERDES flag

2017-05-25 Thread Andrew Lunn
Now that we use an op for SERDES operations, we don't need a flag for it. Remove it. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 23 ++- drivers/net/dsa/mv88e6xxx/phy.c | 3 --- 2 files changed, 2 insertions(+), 2

[PATCH v3 net-next 5/5] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable

2017-05-25 Thread Andrew Lunn
Implement the port enable/disable callbacks, which enable/disable the SERDES interfaces, if applicable. This should save a bit of power/heat. We also need to enable SERDES on CPU and DSA ports, so keep the existing call to the op, but make it conditional. Signed-off-by: Andrew Lunn --- drivers/

[PATCH v3 net-next 2/5] net: dsa: mv88e6xxx: Refactor mv88e6352 SERDES code into an op

2017-05-25 Thread Andrew Lunn
The mv88e6390 family has a different SERDES implementation. Refactor the mv88e6352 code into an ops function, so we can later add the mv88e6390 code. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/Makefile| 1 + drivers/net/dsa/mv88e6xxx/chip.c |

[PATCH v3 net-next 1/5] net: dsa: mv88e6xxx: Move phy functions into phy.[ch]

2017-05-25 Thread Andrew Lunn
The upcoming SERDES support will need to make use of PHY functions. Move them out into a file of there own. No code changes. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/Makefile| 1 + drivers/net/dsa/mv88e6xxx/chip.c | 233 +--- drivers/net/dsa

[PATCH v3 net-next 0/5] net: dsa: mv88e6xxx: Add basic SERDES support

2017-05-25 Thread Andrew Lunn
Some of the Marvell switches are SERDES interface, which must be powered up before packets can be passed. This is particularly true on the 6390, where the SERDES defaults to down, probably to save power. This series refactors the existing SERDES support for the 6352, and adds 6390 support. v2: S

Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-25 Thread Julian Anastasov
Hello, On Thu, 25 May 2017, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & > >

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Francois Romieu
David Miller : > From: Joshua Emele > Date: Wed, 24 May 2017 15:43:18 -0700 [...] > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > > the HW queue. Because sky2_hw_down can be called from a process context, > > the call to u64_stats_update_begin can result in deadlock.

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Stephen Hemminger
On Thu, 25 May 2017 13:21:58 -0700 Joshua Emele wrote: > On Thu, May 25, 2017 at 10:54 AM, Stephen Hemminger > wrote: > > > > On Wed, 24 May 2017 15:43:18 -0700 > > Joshua Emele wrote: > > > > > From: Joshua Emele > > > > > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuc

[PATCH net] ipv4: add reference counting to metrics

2017-05-25 Thread Eric Dumazet
From: Eric Dumazet Andrey Konovalov reported crashes in ipv4_mtu() I could reproduce the issue with KASAN kernels, between 10.246.7.151 and 10.246.7.152 : 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & 2) At the same time run following loop : while : do ip ro add 10.246.7.152 de

Re: [PATCH net-next] net: ethernet: ax88796: support generating a random mac address

2017-05-25 Thread Andrew Lunn
On Thu, May 25, 2017 at 10:55:11PM +0200, Uwe Kleine-König wrote: > Instead of falling back to 00:00:00:00:00:00 generate a random address > if none is provided via platform data or from the the device's register > space. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next] net: ethernet: ax88796: support generating a random mac address

2017-05-25 Thread David Miller
From: Uwe Kleine-König Date: Thu, 25 May 2017 22:57:41 +0200 > Hello David, > > On Thu, May 25, 2017 at 10:55:11PM +0200, Uwe Kleine-König wrote: >> Instead of falling back to 00:00:00:00:00:00 generate a random address >> if none is provided via platform data or from the the device's register >

Re: [PATCH net-next] net: ethernet: ax88796: support generating a random mac address

2017-05-25 Thread Uwe Kleine-König
Hello David, On Thu, May 25, 2017 at 10:55:11PM +0200, Uwe Kleine-König wrote: > Instead of falling back to 00:00:00:00:00:00 generate a random address > if none is provided via platform data or from the the device's register s/the the/the/ should I resend for this, or can you fixup at commit ti

[PATCH net-next] net: ethernet: ax88796: support generating a random mac address

2017-05-25 Thread Uwe Kleine-König
Instead of falling back to 00:00:00:00:00:00 generate a random address if none is provided via platform data or from the the device's register space. Signed-off-by: Uwe Kleine-König --- drivers/net/ethernet/8390/ax88796.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethe

[PATCH net] net: ethernet: ax88796: don't call free_irq without request_irq first

2017-05-25 Thread Uwe Kleine-König
The function ax_init_dev (which is called only from the driver's .probe function) calls free_irq in the error path without having requested the irq in the first place. So drop the free_irq call in the error path. Fixes: 825a2ff1896e ("AX88796 network driver") Signed-off-by: Uwe Kleine-König ---

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-25 Thread Jes Sorensen
On 05/25/2017 06:40 AM, Saeed Mahameed wrote: On Thu, May 25, 2017 at 8:20 AM, Ilan Tayari wrote: -Original Message- Can you put it into different driver? Dumping everything into by far the biggest nic driver already is already huge headache in terms on maintainability, debugging and ba

[PATCH net,v2] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
This fix addresses two problems in the way the DSCP field is formulated on the encapsulating header of IPv6 tunnels. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195661 1) The IPv6 tunneling code was manipulating the DSCP field of the encapsulating packet using the 32b flowlabel. Since

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread David Miller
From: Peter Dawson Date: Fri, 26 May 2017 06:08:42 +1000 > On Thu, 25 May 2017 15:49:14 -0400 (EDT) > David Miller wrote: > >> Still not correct, you need to use a "Fixes: " tag of the form: >> >> Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") >> >> And it must

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Joshua Emele
On Thu, May 25, 2017 at 10:54 AM, Stephen Hemminger wrote: > > On Wed, 24 May 2017 15:43:18 -0700 > Joshua Emele wrote: > > > From: Joshua Emele > > > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > > the HW queue. Because sky2_hw_down can be called from a process cont

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
On Thu, 25 May 2017 15:49:14 -0400 (EDT) David Miller wrote: > Still not correct, you need to use a "Fixes: " tag of the form: > > Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") > > And it must appear of the first line of tags, before signoffs and acks, > with no

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread David Miller
From: Peter Dawson Date: Fri, 26 May 2017 05:46:27 +1000 > On Thu, 25 May 2017 12:11:17 -0400 (EDT) > David Miller wrote: > >> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 >> >> This is not the correct way to use the Fixes: tag. >> >> You should specify the commit that introd

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-05-25 Thread Alexander Duyck
On Thu, May 25, 2017 at 6:35 AM, Ding Tianhong wrote: > > On 2017/5/9 8:48, Casey Leedom wrote: >> >> | From: Alexander Duyck >> | Date: Saturday, May 6, 2017 11:07 AM >> | >> | | From: Ding Tianhong >> | | Date: Fri, May 5, 2017 at 8:08 PM >> | | >> | | According the suggestion, I could only th

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
On Thu, 25 May 2017 12:11:17 -0400 (EDT) David Miller wrote: > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 > > This is not the correct way to use the Fixes: tag. > > You should specify the commit that introduced the regression > between 4.9.x and 4.10.x, and that you are fixin

Re: [PATCH net-next 6/6] net: mpls: minor cleanups

2017-05-25 Thread Joe Perches
On Thu, 2017-05-25 at 14:56 -0400, David Miller wrote: > From: David Ahern > Date: Wed, 24 May 2017 21:54:42 -0600 > > > Noticed these doing the extack support: > > - nla_get_via is only used in af_mpls.c so remove from internal.h >  ... > > @@ -43,6 +43,9 @@ static void rtmsg_lfib(int event, u32

[PATCH v2 net-next 1/4] net: phy: marvell: #defines for copper and fibre pages

2017-05-25 Thread Andrew Lunn
Replace magic numbers for PHY pages with symbolic names. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 88cd97b44ba6..bb067026353a 10

[PATCH v2 net-next 0/4] More marvell phy cleanups

2017-05-25 Thread Andrew Lunn
This patchset continues the cleanup of the Marvell PHY driver. These phys use pages to allow more than the 32 registers that fit into the MDIO address space. Cleanup the code used for changing pages. v2 Reverse christmas tree Andrew Lunn (4): net: phy: marvell: #defines for copper and fibre pa

[PATCH v2 net-next 2/4] net: phy: marvell: More hidden page changes refactored

2017-05-25 Thread Andrew Lunn
EXT_ADDR_PAGE is the same meaning as MII_MARVELL_PHY_PAGE, i.e. change page. Replace it will calls to the helpers. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 62 +++ 1 file changed, 46 insertions(+), 16 deletions(-) diff --git a/driver

[PATCH v2 net-next 4/4] net: phy: marvell: Uniform page names

2017-05-25 Thread Andrew Lunn
Bring all the page names together, remove the repeats, and make them uniform. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 94 +++ 1 file changed, 46 insertions(+), 48 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy

[PATCH v2 net-next 3/4] net: phy: marvell: helper to get and set page

2017-05-25 Thread Andrew Lunn
There is a common pattern of first reading the currently selected page and then changing to another page. Add a helper to do this. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 75 --- 1 file changed, 31 insertions(+), 44 deletions(-) dif

Re: [PATCH net-next 6/6] net: mpls: minor cleanups

2017-05-25 Thread David Miller
From: David Ahern Date: Wed, 24 May 2017 21:54:42 -0600 > Noticed these doing the extack support: > - nla_get_via is only used in af_mpls.c so remove from internal.h ... > @@ -43,6 +43,9 @@ static void rtmsg_lfib(int event, u32 label, struct > mpls_route *rt, > struct nlmsg

Re: [PATCH] bonding: Don't update slave->link until ready to commit

2017-05-25 Thread David Miller
From: Nithin Nayak Sujir Date: Wed, 24 May 2017 19:45:17 -0700 > In the loadbalance arp monitoring scheme, when a slave link change is > detected, the slave->link is immediately updated and slave_state_changed > is set. Later down the function, the rtnl_lock is acquired and the > changes are comm

Re: [PATCH net-next] ibmvnic: Enable TSO support

2017-05-25 Thread David Miller
From: David Miller Date: Thu, 25 May 2017 14:46:26 -0400 (EDT) > From: Thomas Falcon > Date: Wed, 24 May 2017 21:29:26 -0500 > >> The feature is also enabled by a module parameter. >> This parameter is necessary because TSO can not easily be >> enabled or disabled in firmware without reinitiali

Re: [PATCH net-next] ibmvnic: Enable TSO support

2017-05-25 Thread David Miller
From: Thomas Falcon Date: Wed, 24 May 2017 21:29:26 -0500 > The feature is also enabled by a module parameter. > This parameter is necessary because TSO can not easily be > enabled or disabled in firmware without reinitializing the driver. Sorry, this is unacceptable. When I say no module param

Re: [PATCH net-next 0/2] be2net: patch-set

2017-05-25 Thread David Miller
From: Suresh Reddy Date: Wed, 24 May 2017 22:24:37 -0400 > Hi Dave, Please consider applying these two patches to net-next Series applied.

Re: [PATCH] test_bpf: Add a couple of tests for BPF_JSGE.

2017-05-25 Thread David Miller
From: David Daney Date: Wed, 24 May 2017 16:35:49 -0700 > Some JITs can optimize comparisons with zero. Add a couple of > BPF_JSGE tests against immediate zero. > > Signed-off-by: David Daney Applied, thank you. This reminds me that I should add support for "branch on register" to the sparc6

Re: [PATCH net v2] sctp: fix ICMP processing if skb is non-linear

2017-05-25 Thread Vlad Yasevich
On 05/25/2017 01:14 PM, Davide Caratti wrote: > sometimes ICMP replies to INIT chunks are ignored by the client, even if > the encapsulated SCTP headers match an open socket. This happens when the > ICMP packet is carried by a paged skb: use skb_header_pointer() to read > packet contents beyond the

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Stephen Hemminger
On Wed, 24 May 2017 15:43:18 -0700 Joshua Emele wrote: > From: Joshua Emele > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > the HW queue. Because sky2_hw_down can be called from a process context, > the call to u64_stats_update_begin can result in deadlock. > > Bec

[PATCH net-next] liquidio: fix inaccurate count of napi-processed rx packets reported to Octeon

2017-05-25 Thread Felix Manlunas
From: Prasad Kanneganti lio_enable_irq (called by napi poll) is reporting to Octeon an inaccurate count of processed rx packets causing Octeon to eventually stop forwarding packets to the host. Fix it by using this formula for an accurate count: processed rx packets = droq->pkt_count - droq

RE: [PATCH net-next] liquidio: fix rare pci_driver.probe failure of VF driver

2017-05-25 Thread Chickles, Derek
Looks good to me. Derek > -Original Message- > From: Manlunas, Felix > Sent: Thursday, May 25, 2017 10:42 AM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; Vatsavayi, Raghu ; > Chickles, Derek ; Burla, Satananda > ; Kanneganti, Prasad > > Subject: [PATCH net-next] liquidio: fix

Re: [PATCH net v2 0/5] Various BPF fixes

2017-05-25 Thread David Miller
From: Daniel Borkmann Date: Thu, 25 May 2017 01:05:04 +0200 > Follow-up to fix incorrect pruning when alignment tracking is > in use and to properly clear regs after call to not leave stale > data behind, also a fix that adds bpf_clone_redirect to the > bpf_helper_changes_pkt_data helper and expo

[PATCH net-next v2 4/8] net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup

2017-05-25 Thread Roopa Prabhu
From: David Ahern Convert inet_rtm_getroute to use ip_route_input_rcu and ip_route_output_key_hash_rcu passing the fib_result arg to both. The rcu lock is held through the creation of the response, so the rtable/dst does not need to be attached to the skb and is passed to rt_fill_info directly.

[PATCH net-next v2 5/8] net: ipv4: Save trie prefix to fib lookup result

2017-05-25 Thread Roopa Prabhu
From: David Ahern Prefix is needed for returning matching route spec on get route request. Signed-off-by: David Ahern Signed-off-by: Roopa Prabhu --- include/net/ip_fib.h | 1 + net/ipv4/fib_trie.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/ip_fib.h b/include/net/ip_fi

[PATCH net-next v2 8/8] net: ipv6: RTM_GETROUTE: return matched fib result when requested

2017-05-25 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to return matched fib result when RTM_F_FIB_MATCH flag is specified in RTM_GETROUTE request. This is useful for user-space applications/controllers wanting to query a matching route. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 34 ++

[PATCH net-next v2 6/8] net: ipv4: add new RTM_F_FIB_MATCH flag for use with RTM_GETROUTE

2017-05-25 Thread Roopa Prabhu
From: Roopa Prabhu This flag when specified will return matched fib result in response to a RTM_GETROUTE query. Signed-off-by: Roopa Prabhu --- include/uapi/linux/rtnetlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h ind

[PATCH net-next v2 7/8] net: ipv4: RTM_GETROUTE: return matched fib result when requested

2017-05-25 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to return matched fib result when RTM_F_FIB_MATCH flag is specified in RTM_GETROUTE request. This is useful for user-space applications/controllers wanting to query a matching route. Signed-off-by: Roopa Prabhu --- net/ipv4/route.c | 13 +++--

[PATCH net-next v2 3/8] net: ipv4: Remove event arg to rt_fill_info

2017-05-25 Thread Roopa Prabhu
From: David Ahern rt_fill_info has 1 caller with the event set to RTM_NEWROUTE. Given that remove the arg and use RTM_NEWROUTE directly in rt_fill_info. Signed-off-by: David Ahern Signed-off-by: Roopa Prabhu --- net/ipv4/route.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) di

[PATCH net-next v2 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-25 Thread Roopa Prabhu
From: David Ahern A later patch wants access to the fib result on an output route lookup with the rcu lock held. Refactor __ip_route_output_key_hash, pushing the logic between rcu_read_lock ... rcu_read_unlock into a new helper with the fib_result as an input arg. To keep the name length under c

[PATCH net-next v2 2/8] net: ipv4: refactor ip_route_input_noref

2017-05-25 Thread Roopa Prabhu
From: David Ahern A later patch wants access to the fib result on an input route lookup with the rcu lock held. Refactor ip_route_input_noref pushing the logic between rcu_read_lock ... rcu_read_unlock into a new helper that takes the fib_result as an input arg. Signed-off-by: David Ahern Signe

[PATCH net-next v2 0/8] net: extend RTM_GETROUTE to return fib result

2017-05-25 Thread Roopa Prabhu
From: Roopa Prabhu This series adds a new RTM_F_FIB_MATCH flag to return matched fib result with RTM_GETROUTE. This is useful for applications and protocols in userspace wanting to query the selected route. examples (with patched iproute2): ipv4: $ip route show default via 192.168.0.2 dev e

[PATCH net-next] liquidio: fix rare pci_driver.probe failure of VF driver

2017-05-25 Thread Felix Manlunas
From: Prasad Kanneganti There's a rare pci_driver.probe failure of the VF driver that's caused by PF/VF handshake going out of sync. The culprit is octeon_mbox_write() who ignores an ack timeout condition; it just keeps unconditionally writing all elements of mbox_cmd->data[] even when the other

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread David Miller
From: Joshua Emele Date: Wed, 24 May 2017 15:43:18 -0700 > From: Joshua Emele > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > the HW queue. Because sky2_hw_down can be called from a process context, > the call to u64_stats_update_begin can result in deadlock. > > B

Re: [PATCH] arp: fixed -Wuninitialized compiler warning

2017-05-25 Thread David Miller
From: Ihar Hrachyshka Date: Wed, 24 May 2017 15:19:35 -0700 > Commit 7d472a59c0e5ec117220a05de6b370447fb6cb66 ("arp: always override > existing neigh entries with gratuitous ARP") introduced a compiler > warning: > > net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in > this

Re: [PATCH net] tcp: avoid fastopen API to be used on AF_UNSPEC

2017-05-25 Thread David Miller
From: Wei Wang Date: Wed, 24 May 2017 09:59:31 -0700 > Fastopen API should be used to perform fastopen operations on the TCP > socket. It does not make sense to use fastopen API to perform disconnect > by calling it with AF_UNSPEC. The fastopen data path is also prone to > race conditions and bug

  1   2   >