Hi Dave,
this patch has not been superceeded by anything, can you explain why
it has been marked as such in patchworks?
I think you're being overbearing by requiring this to be marked BROKEN
and I would like you to explore other ways with the authors to fix
whatever perceived problems you thin
On Sun, May 14, 2017 at 08:57:34AM -0500, Eric W. Biederman wrote:
> Greg Kroah-Hartman writes:
>
> > On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote:
> >> From: Mahesh Bandewar
> >>
> >> A process inside random user-ns should not load a module, which is
> >> currently possible.
On Sun, May 14, 2017 at 07:42:08PM -0700, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Sun, May 14, 2017 at 3:45 AM, Greg Kroah-Hartman
> wrote:
> > On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote:
> >> From: Mahesh Bandewar
> >>
> [...]
> >> Now try to create a bridge inside this
On 2017-05-10 21:49, Andy Duan wrote:
> From: Stefan Agner Sent: Thursday, May 11, 2017 12:08 PM
>>To: Andy Duan
>>Cc: David Miller ; and...@lunn.ch;
>>feste...@gmail.com; netdev@vger.kernel.org; linux-
>>ker...@vger.kernel.org
>>Subject: Re: [PATCH] net: fec: select queue depending on VLAN prior
Hi Stephen,
Comments inline.
>On Fri, 12 May 2017 05:02:37 +
>"Kashyap, Saurav" wrote:
>
>> Hi,
>>
>> I am using upstream kernel 4.11.0 and base is RHEL 7.2. I am playing around
>> with TAP devices and created it using following commands
>> ===
>> ip tuntap add tap10 mode tap
>> ip ad
From: Björn Töpel
In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames")
i40e_build_skb updates the page_offset field with an incorrect offset,
which can lead to data corruption. This patch updates page_offset
correctly, by properly setting truesize.
Note that the bug only appears on arc
On Sun, May 14, 2017 at 10:01:34PM +0300, Yuval Shaia wrote:
> On Fri, May 12, 2017 at 09:10:51AM +0300, Yuval Shaia wrote:
> > Signed-off-by: Yuval Shaia
> > ---
> > v0 -> v1:
> > * s/"min_t("/"min_t(int"
> > v1 -> v2:
> > * Use min3 instead of min_t twice
> > v2 -> v3:
> > * Change c
2017-05-15 2:31 GMT+02:00 Alexander Duyck :
> On Sun, May 14, 2017 at 10:56 AM, Björn Töpel wrote:
>> From: Björn Töpel
>>
>> In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames")
>> i40e_build_skb updates the page_offset field with an incorrect offset,
>> which can lead to data corrupti
The function x25_init is not properly unregister related resources
on error handler.It is will result in kernel oops if x25_init init
failed, so add right unregister call on error handler.
Signed-off-by: linzhang
---
net/x25/af_x25.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
d
On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin" wrote:
> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski
> >
> > Signed-off-by: Maciej Fijalkowski
>
> I prefer the original form - ; isn't a full statement.
>
> > ---
> > drivers/net/
On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski
>
> Signed-off-by: Maciej Fijalkowski
Acked-by: Michael S. Tsirkin
But you really want to fix the subject. Make it less verbose
drop upper case and add info about module. Something like:
virtio_ne
On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski
>
> Signed-off-by: Maciej Fijalkowski
I prefer the original form - ; isn't a full statement.
> ---
> drivers/net/virtio_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --gi
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski
>
> Signed-off-by: Maciej Fijalkowski
This is not a complex value.
> ---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_n
On Sun, May 14, 2017 at 3:45 AM, Greg Kroah-Hartman
wrote:
> On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote:
>> From: Mahesh Bandewar
>>
[...]
>> Now try to create a bridge inside this newly created net-ns which would
>> mean bridge module need to be loaded.
>> # ip link ad
Signed-off-by: linzhang
---
net/bluetooth/af_bluetooth.c | 2 +-
net/caif/caif_socket.c | 2 +-
net/kcm/kcmsock.c| 2 +-
net/nfc/af_nfc.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.
Hi Dave,
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of David Miller
> Sent: Sunday, May 14, 2017 7:44 PM
> To: bart.vanass...@sandisk.com
> Cc: h...@lst.de; netdev@vger.kernel.org; linux-r...@vger.kernel.org;
> sta..
From: Daniel Borkmann
Date: Sun, 14 May 2017 16:31:10 +0200
> On 05/13/2017 04:28 AM, David Miller wrote:
>> @@ -823,10 +825,27 @@ static int check_pkt_ptr_alignment(const struct
>> bpf_reg_state *reg,
>> }
>>
>> static int check_val_ptr_alignment(const struct bpf_reg_state *reg,
>> -
From: Bart Van Assche
Date: Sun, 14 May 2017 19:08:50 +
> What is your plan to avoid that applications start using and
> depending on AF_SMC?
The API is out there already so we are out of luck, and neither
you nor I nor anyone else can "stop" this from happening.
On Sun, May 14, 2017 at 10:56 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames")
> i40e_build_skb updates the page_offset field with an incorrect offset,
> which can lead to data corruption. This patch updates page_offset
> correctly.
>
>
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski
Hi Maciek
Please include some commit message, even if it is just the checkpatch
error you are fixing.
Please include the subsystem/driver you are patch in the subject line.
Also, your subject of Fix E
On Sun, 2017-05-14 at 16:14 -0600, David Ahern wrote:
> On 5/14/17 3:00 PM, Johannes Berg wrote:
> > On Sat, 2017-05-13 at 19:29 +0200, Jan Moskyto Matejka wrote:
> > >
> > > > When adding a route to the skb, track whether it contains at
> > > > least
> > > > 1
> > > > route. If not, it means the
On 5/14/17 3:00 PM, Johannes Berg wrote:
> On Sat, 2017-05-13 at 19:29 +0200, Jan Moskyto Matejka wrote:
>>
>>> When adding a route to the skb, track whether it contains at least
>>> 1
>>> route. If not, it means the next route in the dump is larger than
>>> the
>>> given buffer. Detect this condit
On Sat, 2017-05-13 at 19:29 +0200, Jan Moskyto Matejka wrote:
>
> > When adding a route to the skb, track whether it contains at least
> > 1
> > route. If not, it means the next route in the dump is larger than
> > the
> > given buffer. Detect this condition and error out of the dump -
> > returni
On Sun, 2017-05-14 at 11:51 -0400, David Miller wrote:
> From: Christoph Hellwig
> Date: Sun, 14 May 2017 07:58:48 +0200
>
> > this patch has not been superceeded by anything, can you explain why
> > it has been marked as such in patchworks?
>
> I think you're being overbearing by requiring this
On Fri, May 12, 2017 at 09:10:51AM +0300, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia
> ---
> v0 -> v1:
> * s/"min_t("/"min_t(int"
> v1 -> v2:
> * Use min3 instead of min_t twice
> v2 -> v3:
> * Change commit log header message to reflect the changes made in
> v2
> v3
Hi Maciej,
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.12-rc1 next-20170512]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Maciek-Fijalkowski/Fix-ERROR-trailing-stat
From: Maciej Fijalkowski
Signed-off-by: Maciej Fijalkowski
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio
From: Maciej Fijalkowski
Signed-off-by: Maciej Fijalkowski
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f20dfb8..6c8170c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virt
From: Maciej Fijalkowski
Signed-off-by: Maciej Fijalkowski
---
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 6c8170c..5d71e9f 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_n
From: Björn Töpel
In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames")
i40e_build_skb updates the page_offset field with an incorrect offset,
which can lead to data corruption. This patch updates page_offset
correctly.
Note that the bug only appears on architectures where PAGE_SIZE is
Hi,
is there a canonical way to use a device's UUID to generate a MAC
inside the kernel? If I add it, where does it belong into?
Regards
Oliver
From: Christoph Hellwig
Date: Sun, 14 May 2017 07:58:48 +0200
> this patch has not been superceeded by anything, can you explain why
> it has been marked as such in patchworks?
I think you're being overbearing by requiring this to be marked BROKEN
and I would like you to explore other ways with
On 05/13/2017 04:28 AM, David Miller wrote:
Just like packet pointers, track the known alignment of MAP pointers.
In order to facilitate the state tracking, move the register offset
field into where there is an unused 32-bit padding slot on 64-bit.
The check logic is the same as for packet poi
Greg Kroah-Hartman writes:
> On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote:
>> From: Mahesh Bandewar
>>
>> A process inside random user-ns should not load a module, which is
>> currently possible. As demonstrated in following scenario -
>>
>> Create namespaces; especially a
On 05/04/2017 11:55 AM, Daniel Borkmann wrote:
On 05/04/2017 11:28 AM, David Lebrun wrote:
On 05/04/2017 11:13 AM, Daniel Borkmann wrote:
Hi David,
I'm getting the following build error from e8493916a8ed ("iproute:
add support for SR-IPv6 lwtunnel encapsulation"). Reverting your
commit makes i
On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote:
> From: Mahesh Bandewar
>
> A process inside random user-ns should not load a module, which is
> currently possible. As demonstrated in following scenario -
>
> Create namespaces; especially a user-ns and become root inside.
>
IPoIB doesn't support striding RQ at the moment, for this
we need to explicitly choose non striding RQ in IPoIB init,
even if the HW supports it.
Fixes: 8f493ffd88ea ("net/mlx5e: IPoIB, RX steering RSS RQTs and TIRs")
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/ipoi
From: Yishai Hadas
Root flow table is dynamically changed by the underlying flow steering
layer, and IPoIB/ULPs have no idea what will be the root flow table in
the future, hence we need a dynamic infrastructure to move Underlay QPs
with the root flow table.
Fixes: b3ba51498bdd ("net/mlx5: Refac
Fail-safe support patches introduced a trivial bug,
setup tc callback is doing a wrong check of the netdevice state,
the fix is simply to invert the condition.
Fixes: 6f9485af4020 ("net/mlx5e: Fail safe tc setup")
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.
Hi Dave,
This series contains some mlx5 fixes for net.
Please pull and let me know if there's any problem.
For -stable:
("net/mlx5e: Fix ethtool pause support and advertise reporting") kernels >= 4.8
("net/mlx5e: Use the correct pause values for ethtool advertising") kernels >=
4.8
v1->v2:
Dro
From: Gal Pressman
Query the operational pause from firmware (PFCC register) instead of
always passing zeros.
Fixes: 665bc53969d7 ("net/mlx5e: Use new ethtool get/set link ksettings API")
Signed-off-by: Gal Pressman
Cc: kernel-t...@fb.com
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet
From: Gal Pressman
Pause bit should set when RX pause is on, not TX pause.
Also, setting Asym_Pause is incorrect, and should be turned off.
Fixes: 665bc53969d7 ("net/mlx5e: Use new ethtool get/set link ksettings API")
Signed-off-by: Gal Pressman
Cc: kernel-t...@fb.com
Signed-off-by: Saeed Maham
Current memset is using incorrect type of variable, causing the
upper-half of the strucutre to be left uninitialized and causing:
ethernet/qlogic/qed/qed_init_fw_funcs.c: In function
'qed_set_rfs_mode_disable':
ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void *)&ramline+4)'
is
Hello!
On 5/13/2017 5:56 PM, Andrew Lunn wrote:
[...]
+static int ksz_reset_switch(struct dsa_switch *ds)
+{
+ struct ksz_device *dev = ds->priv;
+ u8 data8;
+ u16 data16;
+ u32 data32;
+
...
+
+ memset(dev->vlan_cache, 0, sizeof(*dev->vlan_cache) * dev->num_v
On Fri, May 12, 2017 at 7:13 PM, David Miller wrote:
> From: Saeed Mahameed
> Date: Fri, 12 May 2017 14:56:45 +0300
>
>> From: Gal Pressman
>>
>> Add a spinlock to prevent races when querying statistics, for example
>> querying counters in the middle of a non atomic memcpy() operation in
>> mlx5
Do not allow using eth and udp header types if non-extended pedit kABI
is being used. Other protocol parsers already have this check.
Signed-off-by: Amir Vadai
---
tc/p_eth.c | 3 +++
tc/p_udp.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/tc/p_eth.c b/tc/p_eth.c
index ad3e28f80eb6..2
Using retain for fields longer than 32 bits is not supported.
Do not allow user to do it.
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 3 ++-
tc/m_pedit.c| 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
index 7f482
'ex' attribute should be placed after 'action pedit' and not after
'munge'.
Signed-off-by: Amir Vadai
---
tc/m_pedit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 6498dd91b471..7ef2acc52bce 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@
Add support for modifying IPv6 headers using pedit.
Signed-off-by: Amir Vadai
---
man/man8/tc-pedit.8 | 30 ++
tc/Makefile | 1 +
tc/m_pedit.c| 43 +++--
tc/p_ip.c | 17 +-
tc/p_ip6.c | 91 +++
Hi,
This patchset introduces pedit IPv6 support.
Almost all IPv6 header fields are editable now (src, dst, flow_lbl,
payload_len, next_hdr and hoplimit).
The patch uses the new extended pedit netlink and will fail the operation if
kernel has no support or user didn't use the 'ex' keyword.
In addit
50 matches
Mail list logo
