Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-04-11 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On Thu, 30 Mar 2017 08:53:32 +0200 > Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > > So this is something I missed while the original code was merged, but > > > > the concept > > > > looks a bit weird: why do we do any "allocation" while a ha

[PATCH rdma-next v1 04/12] IB/opa-vnic: Virtual Network Interface Controller (VNIC) netdev

2017-04-11 Thread Vishwanathapura, Niranjana
OPA VNIC netdev function supports Ethernet functionality over Omni-Path fabric by encapsulating Ethernet packets inside Omni-Path packet header. It allocates a rdma netdev device and interfaces with the network stack to provide standard Ethernet network interfaces. It overrides HFI1 device's netdev

[PATCH rdma-next v1 05/12] IB/opa-vnic: VNIC Ethernet Management (EM) structure definitions

2017-04-11 Thread Vishwanathapura, Niranjana
Define VNIC EM MAD structures and the associated macros. These structures are used for information exchange between VNIC EM agent (EMA) on the host and the Ethernet manager. These include the virtual ethernet switch (vesw) port information, vesw port mac table, summay and error counters, vesw port

[PATCH rdma-next v1 02/12] IB/opa-vnic: RDMA NETDEV interface

2017-04-11 Thread Vishwanathapura, Niranjana
Add rdma netdev interface to ib device structure allowing rdma netdev devices to be allocated by ib clients. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- include/rdma/ib_verbs.h | 28 1 file changed, 28 inserti

[PATCH rdma-next v1 10/12] IB/hfi1: OPA_VNIC RDMA netdev support

2017-04-11 Thread Vishwanathapura, Niranjana
Add support to create and free OPA_VNIC rdma netdev devices. Implement netstack interface functionality including xmit_skb, receive side NAPI etc. Also implement rdma netdev control functions. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura Signed

[PATCH rdma-next v1 08/12] IB/opa-vnic: VNIC Ethernet Management Agent (VEMA) interface

2017-04-11 Thread Vishwanathapura, Niranjana
OPA VNIC EMA interface functions are the management interfaces to the OPA VNIC netdev. Add support to add and remove VNIC ports. Implement the required GET/SET management interface functions and processing of new management information. Add support to send trap notifications upon various events lik

[PATCH rdma-next v1 12/12] IB/hfi1: VNIC SDMA support

2017-04-11 Thread Vishwanathapura, Niranjana
HFI1 VNIC SDMA support enables transmission of VNIC packets over SDMA. Map VNIC queues to SDMA engines and support halting and wakeup of the VNIC queues. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- drivers/infiniband/hw/hfi1/Makefile|

[PATCH rdma-next v1 01/12] IB/opa-vnic: Virtual Network Interface Controller (VNIC) documentation

2017-04-11 Thread Vishwanathapura, Niranjana
Add OPA VNIC design document explaining the VNIC architecture and the driver design. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- Documentation/infiniband/opa_vnic.txt | 153 ++ 1 file changed, 153 insertion

[PATCH rdma-next v1 11/12] IB/hfi1: Virtual Network Interface Controller (VNIC) HW support

2017-04-11 Thread Vishwanathapura, Niranjana
HFI1 HW specific support for VNIC functionality. Dynamically allocate a set of contexts for VNIC when the first vnic port is instantiated. Allocate VNIC contexts from user contexts pool and return them back to the same pool while freeing up. Set aside enough MSI-X interrupts for VNIC contexts and a

[PATCH rdma-next v1 06/12] IB/opa-vnic: VNIC statistics support

2017-04-11 Thread Vishwanathapura, Niranjana
OPA VNIC driver statistics support maintains various counters including standard netdev counters and the Ethernet manager defined counters. Add the Ethtool hook to read the counters. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- drivers/inf

[PATCH rdma-next v1 07/12] IB/opa-vnic: VNIC MAC table support

2017-04-11 Thread Vishwanathapura, Niranjana
OPA VNIC MAC table contains the MAC address to DLID mappings provided by the Ethernet manager. During transmission, the MAC table provides the MAC address to DLID translation. Implement MAC table using simple hash list. Also provide support to update/query the MAC table by Ethernet manager. Review

[PATCH rdma-next v1 03/12] IB/opa-vnic: Virtual Network Interface Controller (VNIC) interface

2017-04-11 Thread Vishwanathapura, Niranjana
Define OPA VNIC interface between hardware independent VNIC functionality and the hardware dependent VNIC functionality. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- include/rdma/ib_verbs.h | 1 + include/rdma/opa_vnic.h | 141 ++

[PATCH rdma-next v1 00/12] Omni-Path Virtual Network Interface Controller (VNIC)

2017-04-11 Thread Vishwanathapura, Niranjana
ChangeLog: = v0 => v1: a) changes as required by new kernel base (for-4.12) b) moved rdma netdev interface into a separate patch c) Return specific error code if specified rdma netdev type is not supported d) Some minor fixes (no changes to overall design or interface) v0: Initial post @

[PATCH rdma-next v1 09/12] IB/opa-vnic: VNIC Ethernet Management Agent (VEMA) function

2017-04-11 Thread Vishwanathapura, Niranjana
OPA VEMA function interfaces with the Infiniband MAD stack to exchange the management information packets with the Ethernet Manager (EM). It interfaces with the OPA VNIC netdev function to SET/GET the management information. The information exchanged with the EM includes class port details, encapsu

Re: [PATCH rfc 0/6] Automatic affinity settings for nvme over rdma

2017-04-11 Thread Christoph Hellwig
On Mon, Apr 10, 2017 at 01:05:50PM -0500, Steve Wise wrote: > I'll test cxgb4 if you convert it. :) That will take a lot of work. The problem with cxgb4 is that it allocatesd all the interrupts at device enable time, but then only allocates them to ULDs when they attached, while this scheme assum

[PATCH RFC ipsec-next 13/14] xfrm: Add encapsulation header offsets while SKB is not encrypted

2017-04-11 Thread Steffen Klassert
From: Ilan Tayari Both esp4 and esp6 used to assume that the SKB payload is encrypted and therefore the inner_network and inner_transport offsets are not relevant. When doing crypto offload in the NIC, this is no longer the case and the NIC driver needs these offsets so it can do TX TCP checksum

[PATCH RFC ipsec-next 14/14] xfrm: Prepare the GRO codepath for hardware offloading.

2017-04-11 Thread Steffen Klassert
On IPsec hardware offloading, we already get a secpath with valid state attached when the packet enters the GRO handlers. So check for hardware offload and skip the state lookup in this case. Signed-off-by: Steffen Klassert --- net/ipv4/esp4_offload.c | 42 ++-

[PATCH RFC ipsec-next 10/14] xfrm: Add xfrm_replay_overflow functions for offloading

2017-04-11 Thread Steffen Klassert
This patch adds functions that handles IPsec sequence numbers for GSO segments and TSO offloading. We need to calculate and update the sequence numbers based on the segments that GSO/TSO will generate. We need this to keep software and hardware sequence number counter in sync. Signed-off-by: Steff

[PATCH RFC ipsec-next 09/14] esp: Add gso handlers for esp4 and esp6

2017-04-11 Thread Steffen Klassert
This patch extends the xfrm_type by an encap function pointer and implements esp4_gso_encap and esp6_gso_encap. These functions doing the basic esp encapsulation for a GSO packet. In case the GSO packet needs to be segmented in software, we add gso_segment functions. This codepath is going to be us

[PATCH RFC ipsec-next 07/14] esp4: Reorganize esp_output

2017-04-11 Thread Steffen Klassert
We need a fallback for ESP at layer 2, so split esp_output into generic functions that can be used at layer 3 and layer 2 and use them in esp_output. We also add esp_xmit which is used for the layer 2 fallback. Signed-off-by: Steffen Klassert --- include/net/esp.h | 16 +++ net/ipv4/esp4.

[PATCH RFC ipsec-next 08/14] esp6: Reorganize esp_output

2017-04-11 Thread Steffen Klassert
We need a fallback for ESP at layer 2, so split esp6_output into generic functions that can be used at layer 3 and layer 2 and use them in esp_output. We also add esp6_xmit which is used for the layer 2 fallback. Signed-off-by: Steffen Klassert --- include/net/esp.h | 3 + net/ipv6/esp6.

[PATCH RFC ipsec-next 06/14] esp6: Remame esp_input_done2

2017-04-11 Thread Steffen Klassert
We are going to export the ipv4 and the ipv6 version of esp_input_done2. They are not static anymore and can't have the same name. So rename the ipv6 version to esp6_input_done2. Signed-off-by: Steffen Klassert --- net/ipv6/esp6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH RFC ipsec-next 05/14] xfrm: Add an IPsec hardware offloading API

2017-04-11 Thread Steffen Klassert
This patch adds all the bits that are needed to do IPsec hardware offload for IPsec states and ESP packets. We add xfrmdev_ops to the net_device. xfrmdev_ops has function pointers that are needed to manage the xfrm states in the hardware and to do a per packet offloading decision. Joint work with:

[PATCH RFC ipsec-next 11/14] esp: Use a synchronous crypto algorithm on offloading.

2017-04-11 Thread Steffen Klassert
We need a fallback algorithm for crypto offloading to a NIC. This is because packets can be rerouted to other NICs that don't support crypto offloading. The fallback is going to be implemented at layer2 where we know the final output device but can't handle asynchronous returns fron the crypto laye

[PATCH RFC ipsec-next 12/14] net: Add a xfrm validate function to validate_xmit_skb

2017-04-11 Thread Steffen Klassert
When we do IPsec offloading, we need a fallback for packets that were targeted to be IPsec offloaded but rerouted to a device that does not support IPsec offload. For that we add a function that checks the offloading features of the sending device and and flags the requirement of a fallback before

[PATCH RFC ipsec-next 03/14] xfrm: Move device notifications to a sepatate file

2017-04-11 Thread Steffen Klassert
This is needed for the upcomming IPsec device offloading. Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 1 + net/xfrm/Makefile | 2 +- net/xfrm/xfrm_device.c | 43 +++ net/xfrm/xfrm_policy.c | 17 + 4 files changed, 46

[PATCH RFC ipsec-next 0/14] IPsec hardware offloding API

2017-04-11 Thread Steffen Klassert
This patchset adds the basic infrastructure for IPsec hardware offloading, it creates a configuration API and adjusts the packet path. Patch 1 adds the needed netdev features to configure IPsec offloads. Patch 2 - 4 prepares for IPsec hardware offloading. Patch 5 implements the IPsec hardware of

[PATCH RFC ipsec-next 02/14] xfrm: Add a xfrm type offload.

2017-04-11 Thread Steffen Klassert
We add a struct xfrm_type_offload so that we have the offloaded codepath separated to the non offloaded codepath. With this the non offloade and the offloaded codepath can coexist. Signed-off-by: Steffen Klassert --- include/net/xfrm.h| 28 +++- net/xfrm/xfrm_state.c | 73 ++

[PATCH RFC ipsec-next 01/14] net: Add ESP offload features

2017-04-11 Thread Steffen Klassert
This patch adds netdev features to configure IPsec offloads. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 8 +++- include/linux/netdevice.h | 1 + include/linux/skbuff.h | 2 ++ net/core/ethtool.c | 3 +++ 4 files changed, 13 insertions(+)

[PATCH RFC ipsec-next 04/14] xfrm: Add mode handlers for IPsec on layer 2

2017-04-11 Thread Steffen Klassert
This patch adds a gso_segment and xmit callback for the xfrm_mode and implement these functions for tunnel and transport mode. Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 10 ++ net/ipv4/xfrm4_mode_transport.c | 32 net/ipv4/xfrm

[PATCH next] bonding: handle link transition from FAIL to UP correctly

2017-04-11 Thread Mahesh Bandewar
From: Mahesh Bandewar When link transitions from LINK_FAIL to LINK_UP, the commit phase is not called. This leads to an erroneous state causing slave-link state to get stuck in "going down" state while its speed and duplex are perfectly fine. This issue is a side-effect of splitting link-set into

[PATCH v2 net-next] net: dwc-xlgmac: add the initial ethtool support

2017-04-11 Thread Jie Deng
It is necessary to provide ethtool support for displaying and modifying parameters of dwc-xlgmac. Signed-off-by: Jie Deng --- v1->v2: - remove begin() method which is unnecessary drivers/net/ethernet/synopsys/Makefile | 3 +- drivers/net/ethernet/synopsys/dwc-xlgmac-common

Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support

2017-04-11 Thread Jie Deng
On 2017/4/11 22:47, David Miller wrote: > From: Jie Deng > Date: Tue, 11 Apr 2017 16:14:04 +0800 > >> It is necessary to provide ethtool support for displaying and >> modifying parameters of dwc-xlgmac. >> >> Signed-off-by: Jie Deng > I don't see why you cannot allow the statistics to be obtaine

[PATCH v2 3/3] of: Make of_match_node() an inline stub for CONFIG_OF=n

2017-04-11 Thread Florian Fainelli
Make of_match_node() an inline function when CONFIG_OF=n which allows the compiler to eliminate warnings about unused variables. Signed-off-by: Florian Fainelli --- include/linux/of.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/of.h b/include/linux/of.h

[PATCH v2 0/3] of: Make of_match_node() an inline stub for CONFIG_OF=n

2017-04-11 Thread Florian Fainelli
Hi all, This patch series makes of_match_node() an inline stub for CONFIG_OF=n. kbuild reported two build errors which are fixed as preriquisite patches. This is based on Linus' master, not sure which tree would merge this, Frank's? Thanks! Florian Fainelli (3): mfd: max8998: Remove CONFIG_OF

[PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match

2017-04-11 Thread Florian Fainelli
A subsequent patch is going to make of_match_node() an inline stub when CONFIG_OF is disabled which will properly take care of having the compiler eliminate the variable. To avoid more #ifdef/#else, just always make the match table available. Signed-off-by: Florian Fainelli --- drivers/mfd/max89

[PATCH v2 2/3] net: macb: Remove CONFIG_OF around DT match table

2017-04-11 Thread Florian Fainelli
A subsequent patch is going to make of_match_node() an inline stub when CONFIG_OF is disabled, which will let the compiler eliminate unused variables. In order not to clutter the code more, remove the CONFIG_OF #ifdef such that macb_dt_ids and what it references are always defined. Signed-off-by:

[PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread gfree . wind
From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric like ip6_default_advm

RE: [PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread Gao Feng
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Joe Perches > Sent: Wednesday, April 12, 2017 11:57 AM > To: gfree.w...@foxmail.com; da...@davemloft.net; kuz...@ms2.inr.ac.ru; > jmor...@namei.org; netdev@vger.kernel.org > Cc: Ga

Re: [PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread Joe Perches
On Wed, 2017-04-12 at 10:32 +0800, gfree.w...@foxmail.com wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c more trivia: > @@ -1250,14 +1250,11 @@ static void set_class_tag(struct rtable *rt, u32 tag) > > static unsigned int ipv4_default_advmss(const struct dst_entry *dst) > { > -

[PATCH v2 06/10] ftgmac100: Rename ftgmac100_setup_mac to ftgmac100_initial_mac

2017-04-11 Thread Benjamin Herrenschmidt
To remove more confusion. This function is about obtaining the initial MAC address at driver probe time. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac1

RE: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()

2017-04-11 Thread weiyongjun (A)
Hi David, > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, April 12, 2017 11:03 AM > To: weiyj...@gmail.com > Cc: j...@mellanox.com; arka...@mellanox.com; weiyongjun (A) > ; netdev@vger.kernel.org > Subject: Re: [PATCH net-next] devlink: fix return

[PATCH v2 05/10] ftgmac100: Rename ftgmac100_set_mac to ftgmac100_write_mac_addr

2017-04-11 Thread Benjamin Herrenschmidt
To avoid confusion with the ndo callback and generally be clearer about the purpose of that function Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100

[PATCH v2 09/10] ftgmac100: Make ring sizes configurable via ethtool

2017-04-11 Thread Benjamin Herrenschmidt
We set an arbitrary max at 1024 since we pre-allocate the actual descriptor arrays and skb arrays to the full size to keep the code a bit simpler and avoid allocation failures in the reset task. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 204

[PATCH v2 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

2017-04-11 Thread Benjamin Herrenschmidt
The documentation describes NETIF_F_IP_CSUM as deprecated so let's switch to NETIF_F_HW_CSUM and use the helper to handle unhandled protocols. Signed-off-by: Benjamin Herrenschmidt -- v2. - Properly fallback on unknown IP protocols (side effect of fixing a reported coding style issue as we

[PATCH v2 10/10] ftgmac100: Set default ring sizes to 128 entries

2017-04-11 Thread Benjamin Herrenschmidt
I haven't seen any improvement above that size on the machines I've tested with. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethe

[PATCH v2 08/10] ftgmac100: Add more register inits in ftgmac100_init_hw()

2017-04-11 Thread Benjamin Herrenschmidt
Clear stale interrupts on entry, configure FIFO sizes, set FIFO thresholds, configure interrupt mitigation. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/net/etherne

[PATCH v2 02/10] ftgmac100: Use device "compatible" property, not machine.

2017-04-11 Thread Benjamin Herrenschmidt
We test for aspeed chips to handle a couple of special cases, but we do that by checking the machine type which isn't right. Instead check the actual device compatible property. This also updates the dtsi files for the aspeed SoC to match. Signed-off-by: Benjamin Herrenschmidt --- arch/arm/boot

[PATCH v2 03/10] ftgmac100: Disable HW checksum generation on AST2400, enable on others

2017-04-11 Thread Benjamin Herrenschmidt
We found out that HW checksum generation only works from AST2500 onward. This disables it on AST2400 and removes the "no-hw-checksum" properties in the device-trees. The problem we had wasn't related to NC-SI. Also rework the logic testing for that property so it can be used to disable HW checksum

[PATCH v2 07/10] ftgmac100: Open code remaining register writes

2017-04-11 Thread Benjamin Herrenschmidt
The helpers just take space but don't provide much value. Simple one line comments are more explanatory. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 53 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/drive

[PATCH v2 04/10] ftgmac100: Set netdev->hw_features

2017-04-11 Thread Benjamin Herrenschmidt
So features can be turned on/off via ethtool Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index bd

[PATCH v2 00/10] ftgmac100: Rework batch 4 - Misc

2017-04-11 Thread Benjamin Herrenschmidt
This is v2 of the fourth batch of updates to the ftgmac100 driver. This is a bunch of misc cleanups and fixes, such as properly disabling HW checksum generation on AST2400 where it's known to be broken and some chip init updates. This also adds the ability to turn HW checksum on/off and configure

[PATCH net-next v1 1/1] L2TP device MTU setup - tunnel socket needs a lock

2017-04-11 Thread R. Parameswaran
The MTU overhead calculation in L2TP device set-up merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff needs to be adjusted to lock the tunnel socket while referencing the sub-data structures to derive the socket's IP overhead. --- include/linux/net.h | 2 +- net/l2tp/l2tp_eth.c | 2 ++ ne

Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()

2017-04-11 Thread David Miller
From: Wei Yongjun Date: Mon, 10 Apr 2017 13:11:06 + > From: Wei Yongjun > > Fix the retrn value check which testing the wrong variable > in devlink_dpipe_header_put(). > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") > Signed-off-by: Wei Yongjun This doesn't apply

Re: [PATCH net-next 00/10] net/smc: patches for net-next

2017-04-11 Thread David Miller
From: Ursula Braun Date: Mon, 10 Apr 2017 14:57:55 +0200 > here are some patches for net/smc. Most important are > improvements for socket closing. Series applied to net-next, thanks.

RE: [PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread Gao Feng
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Wednesday, April 12, 2017 10:03 AM > To: gfree.w...@foxmail.com; da...@davemloft.net; kuz...@ms2.inr.ac.ru; > jmor...@namei.org; netdev@vger.kernel.org > Cc: Gao Feng > Subject: Re: [PATCH net-next 1/1] net: ipv4: R

[PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread gfree . wind
From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric like ip6_default_advm

Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation

2017-04-11 Thread David Miller
From: ido...@idosch.org Date: Mon, 10 Apr 2017 14:59:26 +0300 > From: Ido Schimmel > > First patch adds a missing ndo_uninit() in the bridge driver, which is a > prerequisite for the second patch that actually fixes the oops. > > Please consider both patches for 4.4.y, 4.9.y and 4.10.y Series

Re: [PATCH] net: stmmac: use netif_set_real_num_{rx,tx}_queues

2017-04-11 Thread David Miller
From: Joao Pinto Date: Mon, 10 Apr 2017 11:32:14 +0100 > In the submission of the lastest multiple buffer patch set, this fix was lost. > I am sending this patch to put it right again. The fix was originally proposed > by Arnd Bergmann. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Joao Pin

Re: [PATCH] smsc95xx: Add comments to the registers definition

2017-04-11 Thread David Miller
From: Andrew Lunn Date: Mon, 10 Apr 2017 15:52:51 +0200 > Hi Martin > >> @@ -2032,7 +2032,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet >> *dev, >> skb_push(skb, 4); >> tx_cmd_b = (u32)(skb->len - 4); >> if (csum) >> -tx_cmd_b |= TX_CMD_B_CSUM_ENABLE; >>

Re: [PATCH net-next,1/3] hv_netvsc: Use per socket hash when available

2017-04-11 Thread David Miller
From: Haiyang Zhang Date: Sat, 8 Apr 2017 17:53:59 -0700 > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index f24c289..0a129cb 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -211,9 +211,14 @@ static u16 netvsc_selec

Re: [PATCH net-next v2] net: allow configuring default qdisc

2017-04-11 Thread David Miller
From: Stephen Hemminger Date: Sat, 8 Apr 2017 15:39:46 -0400 > Since 3.12 it has been possible to configure the default queuing > discipline via sysctl. This patch adds ability to configure the > default queue discipline in kernel configuration. This is useful for > environments where configurin

Re: [PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread Joe Perches
On Wed, 2017-04-12 at 09:36 +0800, gfree.w...@foxmail.com wrote: > From: Gao Feng > > 1. Don't get the metric RTAX_ADVMSS of dst. > There are two reasons. > 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss > before invoke default_advmss. > 2) The ipv4_default_advmss is used to

[PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-11 Thread gfree . wind
From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric like ip6_default_advm

Re: Network driver "test suite"

2017-04-11 Thread Florian Fainelli
Hi, On 04/11/2017 05:16 PM, Benjamin Herrenschmidt wrote: > Hi folks ! > > Does anybody knows of an existing kind of automated "test suite" for a > network/ethernet driver ? > > IE. Something we could run both on the "tested" driver and a cross-over > "known good" peer (possibly the latter set

linux-next: manual merge of the net-next tree with the pci tree

2017-04-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/pci/msi.c include/linux/pci.h between commit: 688769f643bf ("PCI/MSI: Make pci_msi_shutdown() and pci_msix_shutdown() static") from the pci tree and commit: 4244de1c64de ("PCI: remove pci_enable_msix") f

Network driver "test suite"

2017-04-11 Thread Benjamin Herrenschmidt
Hi folks ! Does anybody knows of an existing kind of automated "test suite" for a network/ethernet driver ? IE. Something we could run both on the "tested" driver and a cross-over "known good" peer (possibly the latter set to promisc & no offload for proper analysis), that would out the driver t

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

2017-04-11 Thread Benjamin Herrenschmidt
On Tue, 2017-04-11 at 20:03 -0400, David Miller wrote: > > From: Benjamin Herrenschmidt > Date: Wed, 12 Apr 2017 09:36:05 +1000 > > > I should call the helper when I don't recognize the protocol type in > > the IP header, not just when the main skb protocol type is not IP. > > That's correct. >

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

2017-04-11 Thread David Miller
From: Benjamin Herrenschmidt Date: Wed, 12 Apr 2017 09:36:05 +1000 > I should call the helper when I don't recognize the protocol type in > the IP header, not just when the main skb protocol type is not IP. That's correct. > BTW. I'm not too familiar with how encapsulation works these days. I >

[PATCH net-next v2 0/8] rtnetlink: Cleanup user notifications for netdev events

2017-04-11 Thread David Ahern
Vlad's recent patch to add the event type to rtnetlink notifications points out a number of redundant or unnecessary notifications sent to userspace for events that are essentially internal to the kernel. Trim the list to put a dent in the notification storm. v2 - rebased to top of net-next with I

[PATCH net-next v2 4/8] rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event

2017-04-11 Thread David Ahern
Changing the master device for a link generates many messages; the one generated for POST_TYPE_CHANGE is redundant: [LINK]11: dummy1: mtu 1500 qdisc noqueue master br1 state UNKNOWN group default link/ether 02:02:02:02:02:03 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue mas

[PATCH net-next v2 5/8] rtnetlink: Do not generate notifications for PRECHANGEUPPER event

2017-04-11 Thread David Ahern
PRECHANGEUPPER is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 8cfb9e3c1f6e..10df445bb818 100644 --- a/net/core/rtnetlink.c +++

[PATCH net-next v2 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-11 Thread David Ahern
Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1: mtu 1490 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:

[PATCH net-next v2 2/8] rtnetlink: Do not generate notification for UDP_TUNNEL_PUSH_INFO

2017-04-11 Thread David Ahern
NETDEV_UDP_TUNNEL_PUSH_INFO is an internal notifier; nothing userspace can do so don't generate a netlink notification. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 79ab43796b08..58722bf10

[PATCH net-next v2 8/8] rtnetlink: Do not generate notifications for NETDEV_CHANGE_TX_QUEUE_LEN event

2017-04-11 Thread David Ahern
Changing tx queue length generates identical messages: [LINK]22: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:04:f4:b7:5c:d2 brd ff:ff:ff:ff:ff:ff promiscuity 0 dummy numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 [LINK]22: dummy1: mtu 1500

[PATCH net-next v2 7/8] rtnetlink: Do not generate notifications for NETDEV_CHANGEUPPER event

2017-04-11 Thread David Ahern
NETDEV_CHANGEUPPER is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b70e915be66d..ef93f6c983f3 100644 --- a/net/core/rtnetlink.c

[PATCH net-next v2 6/8] rtnetlink: Do not generate notifications for CHANGELOWERSTATE event

2017-04-11 Thread David Ahern
CHANGELOWERSTATE is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 10df445bb818..b70e915be66d 100644 --- a/net/core/rtnetlink.c ++

[PATCH net-next v2 3/8] rtnetlink: Do not generate notifications for CHANGEADDR event

2017-04-11 Thread David Ahern
Changing hardware address generates redundant messages: [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:02:02:02:02:02 brd ff:ff:f

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

2017-04-11 Thread Benjamin Herrenschmidt
On Wed, 2017-04-12 at 08:06 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2017-04-11 at 11:27 -0400, David Miller wrote: > > > I'll fix it in a next spin if Dave wants it that way but > > > otherwise > > > I'm keen to leave it as it is. > > > > Please fix this and respin. > > > > Meanwhile get t

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-11 Thread Florian Fainelli
On 04/11/2017 04:14 PM, Andrew Lunn wrote: >> To give some more background and rational for this change. >> >> On a platform where we have a parent MDIO bus, backed by the >> mdio-bcm-unimac.c driver, we also register a slave MII bus (through >> net/dsa/dsa2.c) which is parented to this UniMAC MDIO

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

2017-04-11 Thread Willem de Bruijn
On Mon, Apr 10, 2017 at 3:23 PM, Dave Jones wrote: > On Mon, Apr 10, 2017 at 07:03:30PM +, alexander.le...@verizon.com wrote: > > Hi all, > > > > I seem to be hitting this use-after-free on a -next kernel using trinity: > > > > [ 531.036054] BUG: KASAN: use-after-free in > prb_retire_rx

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-11 Thread Andrew Lunn
> To give some more background and rational for this change. > > On a platform where we have a parent MDIO bus, backed by the > mdio-bcm-unimac.c driver, we also register a slave MII bus (through > net/dsa/dsa2.c) which is parented to this UniMAC MDIO bus through an > assignment of of_node. This s

Re: [PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

2017-04-11 Thread David Daney
On 04/11/2017 02:54 PM, Daniel Borkmann wrote: On 04/11/2017 11:30 PM, David Daney wrote: When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT

Re: [PATCH v2 iproute2 net-next 2/2] iproute: Add support for MPLS LWT ttl attribute

2017-04-11 Thread David Ahern
On 4/11/17 2:37 AM, Robert Shearman wrote: > Add support for setting and displaying the ttl attribute > for MPLS IP lighweight tunnels. > > Signed-off-by: Robert Shearman > --- > ip/iproute_lwtunnel.c | 31 +-- > man/man8/ip-route.8.in | 9 - > 2 files chang

Re: [PATCH v2 iproute2 net-next 1/2] iproute: Add support for ttl-propagation attribute

2017-04-11 Thread David Ahern
On 4/11/17 2:37 AM, Robert Shearman wrote: > Add support for setting and displaying the ttl-propagation attribute > initially used by MPLS to control propagation of MPLS TTL to IPv4/IPv6 > TTL/hop-limit on popping final label on a per-route basis. > > Signed-off-by: Robert Shearman > --- > ip/ip

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-11 Thread Florian Fainelli
On 04/10/2017 02:42 PM, Florian Fainelli wrote: > A MDIO bus driver can set phy_mask to indicate which PHYs should be > probed and which should not. Right now, of_mdiobus_register() always > sets mdio->phy_mask to ~0 which means: don't probe anything yourself, > and let the Device Tree scanning do

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

2017-04-11 Thread Benjamin Herrenschmidt
On Tue, 2017-04-11 at 11:27 -0400, David Miller wrote: > > I'll fix it in a next spin if Dave wants it that way but otherwise > > I'm keen to leave it as it is. > > Please fix this and respin. > > Meanwhile get the coding style rules changed if you disagree with > them.  A patch series review is

Re: [PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

2017-04-11 Thread Daniel Borkmann
On 04/11/2017 11:30 PM, David Daney wrote: When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT code to a file. This file can then be disassemb

[PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

2017-04-11 Thread David Daney
When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT code to a file. This file can then be disassembled off line. Typical usage in this case mig

[PATCH] xen/9pfs: use %d format specifier instead of %u for a signed int

2017-04-11 Thread Colin King
From: Colin Ian King variable i is a signed int, so use the %d print format specifier instead of %u. Fixes two warnings by cppcheck. Signed-off-by: Colin Ian King --- net/9p/trans_xen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xe

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Andrew Lunn
> +#ifdef CONFIG_NET_DSA_LEGACY > static const char *mv88e6xxx_drv_probe(struct device *dsa_dev, > struct device *host_dev, int sw_addr, > void **priv) > @@ -4256,6 +4257,7 @@ static const char *mv88e6xxx_drv_probe(struct de

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Florian Fainelli
On 04/11/2017 01:52 PM, Vivien Didelot wrote: > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, > which is true by default. > > DSA drivers without

Re: [PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

2017-04-11 Thread Simon Horman
On Mon, Apr 10, 2017 at 03:50:44PM -0400, Aaron Conole wrote: > There are no in-tree callers of this function and it isn't exported. > > Signed-off-by: Aaron Conole Thanks, applied to ipvs-next.

[PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Vivien Didelot
This patch moves as is the legacy DSA code from dsa.c to legacy.c, except the few shared symbols which remain in dsa.c. Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, which is true by default. DSA drivers without legacy support don't need the probe function as well as dri

Re: vlan tagging problem

2017-04-11 Thread Greg Rose
On Tue, 2017-04-11 at 15:36 -0400, carl h wrote: > Hi > > Hope this is right place to ask this. Looking for help regarding vlan > tagging done by the 8021q driver. > > I tried to manually configure a vlan on my target device. I use these > 2 vlan config commands, then I ping an IP address and sni

Re: [PATCH 06/12] audit: Use timespec64 to represent audit timestamps

2017-04-11 Thread Paul Moore
On Sat, Apr 8, 2017 at 1:58 PM, Deepa Dinamani wrote: >> I have no problem merging this patch into audit/next for v4.12, would >> you prefer me to do that so at least this patch is merged? > > This would be fine. > But, I think whoever takes the last 2 deletion patches should also take them. > I'm

Re: [PATCH v3 1/5] netlink: extended ACK reporting

2017-04-11 Thread Johannes Berg
On Tue, 2017-04-11 at 13:42 -0400, David Miller wrote: > > Then, the library needs to be extended to enable this handling to > > modify the way it needs to handle errors, together with the > > setsockopt(). So I'd tend to agree, but * it was easy to solve this, with the flags I added * the fla

vlan tagging problem

2017-04-11 Thread carl h
Hi Hope this is right place to ask this. Looking for help regarding vlan tagging done by the 8021q driver. I tried to manually configure a vlan on my target device. I use these 2 vlan config commands, then I ping an IP address and sniff the packets to look for the vlan tag in the messages. vc

Re: [PATCH net-next v5 2/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

2017-04-11 Thread R Parameswaran
Hi Guillaume, Please see inline: On Tue, Apr 11, 2017 at 10:05 AM, Guillaume Nault wrote: > On Tue, Apr 11, 2017 at 09:39:58AM -0700, R Parameswaran wrote: >> Hi Guillaume, >> >> On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault >> wrote: >> > On Wed, Apr 05, 2017 at 05:00:07PM -0700, R. Parame

Re: [PATCH v3 1/5] netlink: extended ACK reporting

2017-04-11 Thread David Ahern
On 4/11/17 1:05 PM, David Miller wrote: > From: David Ahern > Date: Tue, 11 Apr 2017 12:57:59 -0600 > >> On 4/11/17 11:42 AM, David Miller wrote: >>> David, if you have a specific case where it's absolutely impossible >>> to resolve this when the library is converted to support extended >>> ACKs,

  1   2   3   >