On Mon, 2017-04-03 at 07:24 +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote:
>
> > Have you run lockdep tests on this?
>
> Good idea. For some reason I run it regularly on powerpc but it never
> occurred to me to try it on that 800Mhz ARM11 :-)
That wa
Hi Thomas
I tested the SMSC on other platform (+ stmmac), not on SPEAr.
ok for reset, keep the radar on clock. Hmm, can you attach a piece of
log file to see the failure?
Regards
Peppe
On 4/2/2017 11:30 PM, Thomas Petazzoni wrote:
Hello,
On Thu, 23 Mar 2017 11:33:23 +0100, Giuseppe CAVALLA
Add support for the net stats64 counters to the usbnet core. With that
in place put the hooks into every usbnet driver to use it.
This is a strait forward addition of 64bit counters for RX and TX packet
and byte counts. It is done in the same style as for the other net drivers
that support stats64
On Sun, Apr 2, 2017 at 10:30 PM, Michael S. Tsirkin wrote:
> On Sun, Apr 02, 2017 at 04:10:11PM -0400, Willem de Bruijn wrote:
>> From: Willem de Bruijn
>>
>> Convert virtio-net to a standard napi tx completion path. This enables
>> better TCP pacing using TCP small queues and increases single st
Hi Sean,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget
https
On Sun, Apr 2, 2017 at 10:47 PM, Michael S. Tsirkin wrote:
> On Sun, Apr 02, 2017 at 04:10:12PM -0400, Willem de Bruijn wrote:
>> From: Willem de Bruijn
>>
>> Amortize the cost of virtual interrupts by doing both rx and tx work
>> on reception of a receive interrupt if tx napi is enabled. With
>>
Hi David,
I formatted a patch to support vrf flow passed by iptables(mangle table). And
previously, we lost the flow.oif which would result in a routing look-up
failure. This patch wraps vrf response flow with the correct master interface
by using the skb->dev, which was set to the real ingress
Hi David,
On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote:
From: kbuild test robot
Date: Sat, 1 Apr 2017 07:50:55 +0800
drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1
in function 'hns_enable_serdes_lb' with return type bool
Return statements in
On Sun, Apr 02, 2017 at 04:10:12PM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Amortize the cost of virtual interrupts by doing both rx and tx work
> on reception of a receive interrupt if tx napi is enabled. With
> VIRTIO_F_EVENT_IDX, this suppresses most explicit tx completion
>
From: kbuild test robot
Date: Sat, 1 Apr 2017 07:50:55 +0800
> drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of
> 0/1 in function 'hns_enable_serdes_lb' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
On Sun, 2017-04-02 at 15:29 -0700, Florian Fainelli wrote:
> Le 04/02/17 à 14:30, Joe Perches a écrit :
> > Add all the currently available SPEED_ strings.
> >
> > Signed-off-by: Joe Perches
>
> Considering that PHYLIB does not support anything > 10Gbs at the moment,
> I am not sure how useful t
From: Grygorii Strashko
Date: Fri, 31 Mar 2017 18:41:23 -0500
> In case, if TX watchdog is fired some or all netdev TX queues will be
> stopped and as part of recovery it is required not only to drain and
> reinitailize CPSW TX channeles, but also wake up stoppted TX queues what
> doesn't happen
From: Sowmini Varadhan
Date: Fri, 31 Mar 2017 15:56:29 -0700
> A couple of minor bugfixes that showed up during testing
Series applied, thanks.
From: Eric Dumazet
Date: Fri, 31 Mar 2017 14:59:25 -0700
> From: Eric Dumazet
>
> It seems the code does not match the intent.
>
> This broke packetdrill, and probably other programs.
>
> Fixes: 6c7c98bad488 ("sock: avoid dirtying sk_stamp, if possible")
> Signed-off-by: Eric Dumazet
> Cc: P
From: a...@linux-foundation.org
Date: Fri, 31 Mar 2017 13:09:41 -0700
> From: Andrew Morton
> Subject: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: fix build with
> gcc-4.4.4
>
> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function
> 'mlx5e_set_rxfh':
> drivers/net/ethern
From: a...@linux-foundation.org
Date: Fri, 31 Mar 2017 13:09:38 -0700
> From: Andrew Morton
> Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c: fix build with
> gcc-4.4.4
>
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function
> 'mlx5e_redirect_rqts':
> drivers/net/etherne
From: Joao Pinto
Date: Fri, 31 Mar 2017 14:22:02 +0100
> Sending again, because forgot to include net-dev.
>
> The QoS IP does not accept AVB capabilities to default/queue 0, this way we
> guarantee 75% bandwidth for AVB. This patch assures that only queues >= 1
> gets CBS confgured. Additional
On Sun, Apr 02, 2017 at 04:10:11PM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Convert virtio-net to a standard napi tx completion path. This enables
> better TCP pacing using TCP small queues and increases single stream
> throughput.
>
> The virtio-net driver currently cleans tx
Hi all,
Today's linux-next merge of the net-next tree got conflicts in:
tools/testing/selftests/bpf/Makefile
tools/testing/selftests/bpf/test_verifier.c
between commit:
02ea80b1850e ("bpf: add various verifier test cases for self-tests")
from the net tree and commits:
6882804c916b ("s
Hi Sean,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
repr
Le 04/02/17 à 14:30, Joe Perches a écrit :
> Add all the currently available SPEED_ strings.
>
> Signed-off-by: Joe Perches
Considering that PHYLIB does not support anything > 10Gbs at the moment,
I am not sure how useful that is except if we wanted to re-use
phy_speed_to_str() in other places o
Number of sockets is limited by 16-bit, so 64-bit allocation will never
happen.
16-bit ops are the worst code density-wise on x86_64 because of
additional prefix (66).
Space savings:
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
function
From: Benjamin Herrenschmidt
Date: Mon, 03 Apr 2017 07:21:08 +1000
> What is your preference when a couple of patches in a series of about a
> dozen get updated as a result of reviews ? Just send updates to those
> few or resend the whole series ?
>
> In the latter case I'll wait a bit longer fo
Make ->hash_count, ->low_watermark and ->high_watermark unsigned int
and propagate unsignedness to other variables.
This change doesn't change code generation because these fields aren't
used in 64-bit contexts but make it anyway: these fields can't be
negative numbers.
Signed-off-by: Alexey Dobr
Hash size can't negative so "unsigned int" is logically correct.
Propagate "unsigned int" to loop counters.
Space savings:
add/remove: 0/0 grow/shrink: 2/2 up/down: 6/-18 (-12)
function old new delta
flow_cache_flush_tasklet
Flow keys aren't 4GB+ numbers so 64-bit arithmetic is excessive.
Space savings (I'm not sure what CSWTCH is):
add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-48 (-48)
function old new delta
flow_cache_lookup
On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote:
> On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote:
> > Add all the currently available SPEED_ strings.
[]
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
[]
> > @@ -1487,6 +1487,7 @@ enum ethtool_link_mod
On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote:
> Add all the currently available SPEED_ strings.
>
> Signed-off-by: Joe Perches
> ---
> drivers/net/phy/phy.c| 14 ++
> include/uapi/linux/ethtool.h | 1 +
> 2 files changed, 15 insertions(+)
>
> diff --git a/dri
On Sun, 2017-04-02 at 20:28 +0200, Andrew Lunn wrote:
> Please consider using phy_print_status().
So in a subsequent (not yet posted) patch, I add Pause support. I
noticed that phy_print_status() doesn't distinguish between full
and partial (asym) pause support.
Is that intentional ?
Otherwise,
Hello,
On Thu, 23 Mar 2017 11:33:23 +0100, Giuseppe CAVALLARO wrote:
> > Further research has revealed that everything is working fine on a
> > platform with a Gigabit PHY connected via GMII.
> >
> > However, on a different platform (which I'm using) with a 10/100 PHY
> > connected via MII, DMA_R
Add all the currently available SPEED_ strings.
Signed-off-by: Joe Perches
---
drivers/net/phy/phy.c| 14 ++
include/uapi/linux/ethtool.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index d019bbf42c31..e7d0367a1455 100
On Sun, 2017-04-02 at 13:35 +1000, Benjamin Herrenschmidt wrote:
> + } else if (priv->cur_speed) {
> + /* No link, just return. Leave the HW alone so it can
> + * continue draining the tx ring.
> + */
> + netdev_info(netdev, "Link down
On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote:
> Have you run lockdep tests on this?
Good idea. For some reason I run it regularly on powerpc but it never
occurred to me to try it on that 800Mhz ARM11 :-)
Cheers,
Ben.
Hi Dave !
What is your preference when a couple of patches in a series of about a
dozen get updated as a result of reviews ? Just send updates to those
few or resend the whole series ?
In the latter case I'll wait a bit longer for more comments.
Cheers,
Ben.
On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote:
> Have you run lockdep tests on this? I think it is normal to take the
> rtnl lock first, then the phydev lock. Try some ethtool operations
> and see if you get a splat.
You are right. I actually realized that was wrong last night ;-) It
will s
On Sun, 2017-04-02 at 20:28 +0200, Andrew Lunn wrote:
> > + if (new_speed) {
> > + netdev_info(netdev, "Link up at %d Mbit/s %s
> > duplex\n",
> > + new_speed,
> > + phydev->duplex == DUPLEX_FULL ? "full"
> > : "half");
> > + } else if (priv
On Sun, 2017-04-02 at 13:35 +1000, Benjamin Herrenschmidt wrote:
> + /* Block PHY polling */
> + if (netdev->phydev)
> + mutex_lock(&netdev->phydev->lock);
> +
> + rtnl_lock();
Self-given brown paper bag, those two need to be taken the other way
around. I'll send an
From: Willem de Bruijn
Prepare virtio-net for tx napi by converting existing napi code to
use helper functions. This also deduplicates some logic.
Signed-off-by: Willem de Bruijn
Signed-off-by: Jason Wang
---
drivers/net/virtio_net.c | 65 ++--
1 fi
From: Willem de Bruijn
Convert virtio-net to a standard napi tx completion path. This enables
better TCP pacing using TCP small queues and increases single stream
throughput.
The virtio-net driver currently cleans tx descriptors on transmission
of new packets in ndo_start_xmit. Latency depends o
From: Willem de Bruijn
Amortize the cost of virtual interrupts by doing both rx and tx work
on reception of a receive interrupt if tx napi is enabled. With
VIRTIO_F_EVENT_IDX, this suppresses most explicit tx completion
interrupts for bidirectional workloads.
Signed-off-by: Willem de Bruijn
---
From: Willem de Bruijn
Add napi for virtio-net transmit completion processing.
Based on previous patchsets by Jason Wang:
[RFC V7 PATCH 0/7] enable tx interrupts for virtio-net
http://lkml.iu.edu/hypermail/linux/kernel/1505.3/00245.html
Changes:
RFC -> v1:
- dropped vhost interrupt m
On Sat, Apr 1, 2017 at 12:14 AM, wrote:
> From: Gao Feng
>
> Define one new macro TCP_MAX_WSCALE instead of literal number '14',
> and use U16_MAX instead of 65535 as the max value of TCP window.
> There is another minor change, use rounddown(space, mss) instead of
> (space / mss) * mss;
>
> Sig
> +static void ftgmac100_reset_task(struct work_struct *work)
> +{
> + struct ftgmac100 *priv = container_of(work, struct ftgmac100,
> + reset_task);
> + struct net_device *netdev = priv->netdev;
> + int err;
> +
> + netdev_dbg(netdev, "Rese
> + if (new_speed) {
> + netdev_info(netdev, "Link up at %d Mbit/s %s duplex\n",
> + new_speed,
> + phydev->duplex == DUPLEX_FULL ? "full" : "half");
> + } else if (priv->cur_speed) {
> + /* No link, just return. Leave
Breaking the include loop netdevice.h, dsa.h, devlink.h broke this
driver, it depends on includes brought in by these headers. Adding
linux/of.h fixes it.
Fixes: ed0e39e97d34 ("net: break include loop netdevice.h, dsa.h, devlink.h")
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/faraday/ftg
On Sun, 2017-04-02 at 10:14 -0700, Eric Dumazet wrote:
> Could that be that netfilter does not abort earlier if TCP header is
> completely wrong ?
>
Yes, I wonder if this patch would be better, unless we replicate the
th->doff sanity check in all netfilter modules dissecting TCP frames.
diff --
On Sun, 2017-04-02 at 19:52 +0300, Denys Fedoryshchenko wrote:
> On 2017-04-02 15:32, Eric Dumazet wrote:
> > On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote:
> >> > */
> >> I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for
> >> curiosity, if this condition are
On 2017-04-02 15:32, Eric Dumazet wrote:
On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote:
> */
I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for
curiosity, if this condition are triggered. Is it fine like that?
Sure.
It didnt triggered WARN_ON, and with both pa
Fixes rsync et.al. regression since 3.19...
The following changes since commit c02ed2e75ef4c74e41e421acb4ef1494671585e8:
Linux 4.11-rc4 (2017-03-26 14:15:16 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-davem
for you t
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
extensions/libarpt_mangle.c | 2 +-
extensions/libip6t_rt.c | 2 +-
extensions/lib
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
iptables/nft-arp.c | 4 ++--
iptables/xtables-arp.c | 12 ++--
2 files change
This will allow ULPs to intelligently locate threads based
on completion vector cpu affinity mappings. In case the
driver does not expose a get_vector_affinity callout, return
NULL so the caller can maintain a fallback logic.
Signed-off-by: Sagi Grimberg
---
include/rdma/ib_verbs.h | 24
Use the geneic block layer affinity mapping helper. Also,
limit nr_hw_queues to the rdma device number of irq vectors
as we don't really need more.
Signed-off-by: Sagi Grimberg
---
drivers/nvme/host/rdma.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/nvme/host/rdma.
Like pci and virtio, we add a rdma helper for affinity
spreading. This achieves optimal mq affinity assignments
according to the underlying rdma device affinity maps.
Signed-off-by: Sagi Grimberg
---
block/Kconfig | 5
block/Makefile | 1 +
block/blk-mq-rdma.c
generic api takes care of spreading affinity similar to
what mlx5 open coded (and even handles better asymmetric
configurations). Ask the generic API to spread affinity
for us, and feed him pre_vectors that do not participate
in affinity settings (which is an improvement to what we
had before).
Th
Simply refer to the generic affinity mask helper.
Signed-off-by: Sagi Grimberg
---
drivers/infiniband/hw/mlx5/main.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers/infiniband/hw/mlx5/main.c
index 4dc0a8785fe0..b12bc2294895 100644
---
Now that we have a generic code to allocate an array
of irq vectors and even correctly spread their affinity,
correctly handle cpu hotplug events and more, were much
better off using it.
Signed-off-by: Sagi Grimberg
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
drivers/net/ethe
This patch set is aiming to automatically find the optimal
queue <-> irq multi-queue assignments in storage ULPs (demonstrated
on nvme-rdma) based on the underlying rdma device irq affinity
settings.
First two patches modify mlx5 core driver to use generic API
to allocate array of irq vectors with
On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote:
> > */
> I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for
> curiosity, if this condition are triggered. Is it fine like that?
Sure.
On 2017-04-02 15:19, Eric Dumazet wrote:
On Sun, 2017-04-02 at 04:54 -0700, Eric Dumazet wrote:
On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote:
> Eric Dumazet wrote:
> > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i +=
optlen(opt, i)) {
> > + for (i = si
On Sun, 2017-04-02 at 04:54 -0700, Eric Dumazet wrote:
> On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote:
> > Eric Dumazet wrote:
> > > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i +=
> > > optlen(opt, i)) {
> > > + for (i = sizeof(struct tcphdr); i < tcp_hdrlen -
On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote:
> Eric Dumazet wrote:
> > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i +=
> > optlen(opt, i)) {
> > + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i +=
> > optlen(opt, i)) {
> > if (
On 2017-04-02 14:45, Florian Westphal wrote:
Eric Dumazet wrote:
- for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i +=
optlen(opt, i)) {
+ for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i +=
optlen(opt, i)) {
if (opt[i] == TCPOPT_MSS && opt[i+1]
Eric Dumazet wrote:
> - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i +=
> optlen(opt, i)) {
> + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i +=
> optlen(opt, i)) {
> if (opt[i] == TCPOPT_MSS && opt[i+1] == TCPOLEN_MSS) {
>
Good day,
Welcome to our Private Placement Portfolio.
I am a Staff of a Venture Capital Firm specializing in Growth Capital
Investments/Loans.We seek to invest in Projects with Public and Private sectors
in a broad range of areas including Real estate, Agriculture, Energy, Oil and
Gas, emergin
On Sun, 2017-04-02 at 10:43 +0300, Denys Fedoryshchenko wrote:
> Repost, due being sleepy missed few important points.
>
> I am searching reasons of crashes for multiple conntrack enabled
> servers, usually they point to conntrack, but i suspect use after free
> might be somewhere else,
> so i t
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
iptables/ip6tables-save.c | 2 +-
iptables/iptables-save.c
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/netfilter/ipset/ip_set_core.c | 2 +-
net/netfilter/ipv
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/bridge/netfilter/nft_meta_bridge.c | 2 +-
1 file c
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/nft_fib_ipv6.c | 2 +-
1 file changed, 1
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/ipv4/netfilter/nft_fib_ipv4.c | 2 +-
1 file changed, 1
When an incoming frame is tagged or when GRO is disabled, the skb
handled to vxlan_xmit() doesn't contain a valid transport header
offset. This makes ND proxying fail.
We combine two changes: replace use of skb_transport_offset() and ensure
the necessary amount of skb is linear just before using i
Repost, due being sleepy missed few important points.
I am searching reasons of crashes for multiple conntrack enabled
servers, usually they point to conntrack, but i suspect use after free
might be somewhere else,
so i tried to enable KASAN.
And seems i got something after few hours, and it l
I am searching reasons of crashes for multiple NAT servers, and tried to
enable KASAN.
It seems i got something, and it looks very possible related to all
crashes, because on all that servers i have MSS.
[25181.855611]
==
[25181.
74 matches
Mail list logo
