Re: [PATCH] nl80211: fix dumpit error path RTNL deadlocks

2017-03-15 Thread Johannes Berg
On Wed, 2017-03-15 at 14:59 -0700, David Miller wrote: > From: Johannes Berg > Date: Wed, 15 Mar 2017 14:29:13 +0100 > > > From: Johannes Berg > >  > > Sowmini pointed out Dmitry's RTNL deadlock report to me, and it > turns out > > to be perfectly accurate - there are various error paths that mi

[PATCH v2 net-next] r8152: simply the arguments

2017-03-15 Thread Hayes Wang
Replace &tp->napi with napi and tp->netdev with netdev. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 227e1fd..4b85e95

[PATCH net-next] r8152: simply the arguments

2017-03-15 Thread Hayes Wang
Replace &tp->napi with napi and tp->netdev with netdev. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 227e1fd..e480e9

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Alexei Starovoitov
On Wed, Mar 15, 2017 at 07:48:04PM -0700, Eric Dumazet wrote: > On Wed, Mar 15, 2017 at 6:56 PM, Alexei Starovoitov > wrote: > > On Wed, Mar 15, 2017 at 06:07:16PM -0700, Eric Dumazet wrote: > >> On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: > >> > >> > yes. and we have 'xdp_tx_full

Re: [PATCH net-next 0/7] drivers: net: xgene: Bug fixes and errata workarounds

2017-03-15 Thread David Miller
From: Iyappan Subramanian Date: Wed, 15 Mar 2017 13:27:14 -0700 > This patch set addresses bug fixes and errata workarounds. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Quan Nguyen Series applied.

Re: linux-next: WARNING: CPU: 1 PID: 19544 at net/bridge/br_fdb.c:109 br_fdb_find+0x19d/0x1b0

2017-03-15 Thread Cong Wang
On Wed, Mar 15, 2017 at 6:12 PM, Andrei Vagin wrote: > Hello, > > We execute CRIU tests for linux-next and here is a new warning: > [ 178.930950] [ cut here ] > [ 178.930960] WARNING: CPU: 1 PID: 19544 at net/bridge/br_fdb.c:109 > br_fdb_find+0x19d/0x1b0 > [ 178.930961]

[PATCH v2] net: mvneta: support suspend and resume

2017-03-15 Thread Jane Li
Add basic support for handling suspend and resume. Signed-off-by: Jane Li --- Since v1: - add mvneta_conf_mbus_windows() and mvneta_bm_port_init() in mvneta_resume() drivers/net/ethernet/marvell/mvneta.c | 62 --- 1 file changed, 58 insertions(+), 4 deletions(-)

Re: [PATCH v2] net: mvneta: support suspend and resume

2017-03-15 Thread Jisheng Zhang
On Thu, 16 Mar 2017 11:19:10 +0800 Jane Li wrote: > Add basic support for handling suspend and resume. > > Signed-off-by: Jane Li > --- > Since v1: > - add mvneta_conf_mbus_windows() and mvneta_bm_port_init() in mvneta_resume() > > drivers/net/ethernet/marvell/mvneta.c | 62 >

Re: [PATCH] net: mvneta: support suspend and resume

2017-03-15 Thread Jane Li
Hi Jisheng, On 2017年03月15日 15:18, Jisheng Zhang wrote: Hi Jane, On Wed, 15 Mar 2017 15:08:34 +0800 Jane Li wrote: Add basic support for handling suspend and resume. Signed-off-by: Jane Li --- drivers/net/ethernet/marvell/mvneta.c | 44 +++ 1 file changed

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Eric Dumazet
On Wed, Mar 15, 2017 at 6:56 PM, Alexei Starovoitov wrote: > On Wed, Mar 15, 2017 at 06:07:16PM -0700, Eric Dumazet wrote: >> On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: >> >> > yes. and we have 'xdp_tx_full' counter for it that we monitor. >> > When tx ring and mtu are sized prop

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Alexei Starovoitov
On Wed, Mar 15, 2017 at 06:07:16PM -0700, Eric Dumazet wrote: > On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: > > > yes. and we have 'xdp_tx_full' counter for it that we monitor. > > When tx ring and mtu are sized properly, we don't expect to see it > > incrementing at all. This is

[PATCH net-next 1/6] bpf: move fixup_bpf_calls() function

2017-03-15 Thread Alexei Starovoitov
no functional change. move fixup_bpf_calls() to verifier.c it's being refactored in the next patch Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- kernel/bpf/syscall.c | 56 -- kernel/bpf/verifier.c | 57 ++

[PATCH net-next 5/6] bpf: inline htab_map_lookup_elem()

2017-03-15 Thread Alexei Starovoitov
Optimize: bpf_call bpf_map_lookup_elem map->ops->map_lookup_elem htab_map_lookup_elem __htab_map_lookup_elem into: bpf_call __htab_map_lookup_elem to improve performance of JITed programs. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- kernel/bpf/hashtab.

[PATCH net-next 4/6] bpf: add helper inlining infra and optimize map_array lookup

2017-03-15 Thread Alexei Starovoitov
Optimize bpf_call -> bpf_map_lookup_elem() -> array_map_lookup_elem() into a sequence of bpf instructions. When JIT is on the sequence of bpf instructions is the sequence of native cpu instructions with significantly faster performance than indirect call and two function's prologue/epilogue. Signe

[PATCH net-next 2/6] bpf: refactor fixup_bpf_calls()

2017-03-15 Thread Alexei Starovoitov
reduce indent and make it iterate over instructions similar to convert_ctx_accesses(). Also convert hard BUG_ON into soft verifier error. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- kernel/bpf/verifier.c | 76 --- 1 file change

[PATCH net-next 0/6] bpf: inline bpf_map_lookup_elem()

2017-03-15 Thread Alexei Starovoitov
bpf_map_lookup_elem() is one of the most frequently used helper functions. Improve JITed program performance by inlining this helper. bpf_map_typebefore after hash58M 74M array 174M280M The values are number of lookups per second in ideal conditions measured by

[PATCH net-next 6/6] samples/bpf: add map_lookup microbenchmark

2017-03-15 Thread Alexei Starovoitov
$ map_perf_test 128 speed of HASH bpf_map_lookup_elem() in lookups per second w/o JIT w/JIT before 46M 58M after 42M 74M perf report before: 54.23% map_perf_test [kernel.kallsyms] [k] __htab_map_lookup_elem 14.24% map_perf_test [kernel.kallsy

[PATCH net-next 3/6] bpf: adjust insn_aux_data when patching insns

2017-03-15 Thread Alexei Starovoitov
convert_ctx_accesses() replaces single bpf instruction with a set of instructions. Adjust corresponding insn_aux_data while patching. It's needed to make sure subsequent 'for(all insn)' loops have matching insn and insn_aux_data. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- k

[PATCH] net: ipv6: set route type for anycast routes

2017-03-15 Thread David Ahern
Anycast routes have the RTF_ANYCAST flag set, but when dumping routes for userspace the route type is not set to RTN_ANYCAST. Make it so. Fixes: 58c4fb86eabcb ("[IPV6]: Flag RTF_ANYCAST for anycast routes") CC: Hideaki YOSHIFUJI Signed-off-by: David Ahern --- net/ipv6/route.c | 2 ++ 1 file cha

linux-next: WARNING: CPU: 1 PID: 19544 at net/bridge/br_fdb.c:109 br_fdb_find+0x19d/0x1b0

2017-03-15 Thread Andrei Vagin
Hello, We execute CRIU tests for linux-next and here is a new warning: [ 178.930950] [ cut here ] [ 178.930960] WARNING: CPU: 1 PID: 19544 at net/bridge/br_fdb.c:109 br_fdb_find+0x19d/0x1b0 [ 178.930961] Modules linked in: [ 178.930966] CPU: 1 PID: 19544 Comm: criu Not

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 18:07 -0700, Eric Dumazet wrote: > On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: > > > yes. and we have 'xdp_tx_full' counter for it that we monitor. > > When tx ring and mtu are sized properly, we don't expect to see it > > incrementing at all. This is somethi

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: > yes. and we have 'xdp_tx_full' counter for it that we monitor. > When tx ring and mtu are sized properly, we don't expect to see it > incrementing at all. This is something in our control. 'Our' means > humans that setup the environmen

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Alexei Starovoitov
On Wed, Mar 15, 2017 at 04:34:51PM -0700, Eric Dumazet wrote: > > > > > -/* We recover from out of memory by scheduling our napi poll > > > > > - * function (mlx4_en_process_cq), which tries to allocate > > > > > - * all missing RX buffers (call to mlx4_en_refill_rx_buffers). > > > > > +/* Under me

[PATCH net-next] net/8021q: create device with all possible features in wanted_features

2017-03-15 Thread Andrei Vagin
wanted_features is a set of features which have to be enabled if a hardware allows that. Currently when a vlan device is created, its wanted_features is set to current features of its base device. The problem is that the base device can get new features and they are not propagated to vlan-s of th

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread Shannon Nelson
On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_de

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 16:45 -0700, David Miller wrote: > Ok, I guess we can remove it in that case. I'm still a bit disappointed > as I was always hoping someone would find a way to make this work even > in the presence of NAT. Nat are good, Nat are good. I can't find this hilarious video we wa

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread David Miller
From: Tom Lendacky Date: Wed, 15 Mar 2017 17:52:44 -0500 > On 3/15/2017 5:41 PM, David Miller wrote: >> From: Tom Lendacky >> Date: Wed, 15 Mar 2017 17:40:51 -0500 >> >>> On 3/15/2017 5:37 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 15:11:23 -0500 > Newe

Re: [PATCH net] MAINTAINERS: remove MACVLAN and VLAN entries

2017-03-15 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 15 Mar 2017 18:39:46 +0100 > macvlan.c file seems to be both in VLAN and MACVLAN DRIVER, so remove > the MACVLAN DRIVER since this is redundant. > > I propose with this patch to remove the VLAN (802.1Q) entry so this just > falls into the NETWORKING [GENERAL].

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread David Miller
From: Florian Westphal Date: Wed, 15 Mar 2017 23:57:26 +0100 > AFAIU we only have two alternatives, removal of the randomization feature > or switch to a offset computed via hash(saddr, daddr, secret). > > Unless there are more comments I'll look into doing the latter tomorrow. No, I'll apply t

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Mar 2017 15:59:01 -0700 > On Wed, 2017-03-15 at 15:40 -0700, David Miller wrote: >> From: Soheil Hassas Yeganeh >> Date: Wed, 15 Mar 2017 16:30:45 -0400 >> >> > Note that this cache was already broken for caching timestamps of >> > multiple machines behind a NAT

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread Tom Lendacky
On 3/15/2017 5:52 PM, Tom Lendacky wrote: On 3/15/2017 5:41 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 17:40:51 -0500 On 3/15/2017 5:37 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 15:11:23 -0500 Newer hardware does not provide a cumulative payl

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 16:06 -0700, Alexei Starovoitov wrote: > On Wed, Mar 15, 2017 at 06:21:29AM -0700, Eric Dumazet wrote: > > On Tue, 2017-03-14 at 21:06 -0700, Alexei Starovoitov wrote: > > > On Tue, Mar 14, 2017 at 08:11:43AM -0700, Eric Dumazet wrote: > > > > +static struct page *mlx4_alloc_p

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread Tom Lendacky
On 3/15/2017 5:37 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 15:11:23 -0500 Newer hardware does not provide a cumulative payload length when multiple descriptors are needed to handle the data. Once the MTU increases beyond the size that can be handled by a single descrip

Re: [PATCH v2 net-next] mlx4: Better use of order-0 pages in RX path

2017-03-15 Thread Alexei Starovoitov
On Wed, Mar 15, 2017 at 06:21:29AM -0700, Eric Dumazet wrote: > On Tue, 2017-03-14 at 21:06 -0700, Alexei Starovoitov wrote: > > On Tue, Mar 14, 2017 at 08:11:43AM -0700, Eric Dumazet wrote: > > > +static struct page *mlx4_alloc_page(struct mlx4_en_priv *priv, > > > + st

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 15:40 -0700, David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Wed, 15 Mar 2017 16:30:45 -0400 > > > Note that this cache was already broken for caching timestamps of > > multiple machines behind a NAT sharing the same address. > > That's the documented, well establ

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread Florian Westphal
David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Wed, 15 Mar 2017 16:30:45 -0400 > > > Note that this cache was already broken for caching timestamps of > > multiple machines behind a NAT sharing the same address. > > That's the documented, well established, limitation of time-wait > r

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread Willy Tarreau
Hi David, On Wed, Mar 15, 2017 at 03:40:44PM -0700, David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Wed, 15 Mar 2017 16:30:45 -0400 > > > Note that this cache was already broken for caching timestamps of > > multiple machines behind a NAT sharing the same address. > > That's the docum

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread Tom Lendacky
On 3/15/2017 5:41 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 17:40:51 -0500 On 3/15/2017 5:37 PM, David Miller wrote: From: Tom Lendacky Date: Wed, 15 Mar 2017 15:11:23 -0500 Newer hardware does not provide a cumulative payload length when multiple descriptors are ne

[PATCH net] ibmvnic: Free tx/rx scrq pointer array when releasing sub-crqs

2017-03-15 Thread Nathan Fontenot
The pointer array for the tx/rx sub crqs should be free'ed when releasing the tx/rx sub crqs. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c in

Re: net/udp: slab-out-of-bounds Read in udp_recvmsg

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 15:08 -0700, David Miller wrote: > From: Eric Dumazet > Date: Wed, 15 Mar 2017 09:10:33 -0700 > > > @@ -692,12 +692,17 @@ void __sock_recv_timestamp(struct msghdr *msg, struct > > sock *sk, > > ktime_to_timespec_cond(shhwtstamps->hwtstamp, tss.ts + 2)) > >

Re: [PATCH net] net: properly release sk_frag.page

2017-03-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Mar 2017 13:21:28 -0700 > From: Eric Dumazet > > I mistakenly added the code to release sk->sk_frag in > sk_common_release() instead of sk_destruct() > > TCP sockets using sk->sk_allocation == GFP_ATOMIC do no call > sk_common_release() at close time, thus leak

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread David Miller
From: Tom Lendacky Date: Wed, 15 Mar 2017 15:11:23 -0500 > Newer hardware does not provide a cumulative payload length when multiple > descriptors are needed to handle the data. Once the MTU increases beyond > the size that can be handled by a single descriptor, the SKB does not get > built prope

Re: [PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread David Miller
From: Tom Lendacky Date: Wed, 15 Mar 2017 17:40:51 -0500 > On 3/15/2017 5:37 PM, David Miller wrote: >> From: Tom Lendacky >> Date: Wed, 15 Mar 2017 15:11:23 -0500 >> >>> Newer hardware does not provide a cumulative payload length when >>> multiple >>> descriptors are needed to handle the data.

Re: [PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 15 Mar 2017 16:30:45 -0400 > Note that this cache was already broken for caching timestamps of > multiple machines behind a NAT sharing the same address. That's the documented, well established, limitation of time-wait recycling. People who enable it, need

Re: [PATCH net] net: bcmgenet: Do not suspend PHY if Wake-on-LAN is enabled

2017-03-15 Thread David Miller
From: Florian Fainelli Date: Wed, 15 Mar 2017 12:57:21 -0700 > Suspending the PHY would be putting it in a low power state where it > may no longer allow us to do Wake-on-LAN. > > Fixes: cc013fb48898 ("net: bcmgenet: correctly suspend and resume PHY device") > Signed-off-by: Florian Fainelli A

Re: [PATCH net-next v2 0/3] net: dsa: check out-of-range ageing time

2017-03-15 Thread David Miller
From: Vivien Didelot Date: Wed, 15 Mar 2017 15:53:47 -0400 > The ageing time limits supported by DSA drivers vary depending on the > switch model. If a driver returns -ERANGE for out-of-range values, the > switchdev commit phase will fail with the following stacktrace: ... > This patchset fixes

Re: [Bug 194723] connect() to localhost stalls after 4.9 -> 4.10 upgrade

2017-03-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Mar 2017 14:40:34 -0700 > Finally time to get rid of buggy tw_recycle, that apparently some > distros set to one. It's not buggy, it's just not designed in a way that it can work in the presence of NAT. So yes, indeed, NO DISTRO SHOULD CHANGE THE VALUE TO "1" by

Re: [net-next PATCH 0/2] Add support for passing more information in mqprio offload

2017-03-15 Thread David Miller
From: Alexander Duyck Date: Wed, 15 Mar 2017 10:39:12 -0700 > This patch series lays the groundwork for future work to allow us to make > full use of the mqprio options when offloading them to hardware. > > Currently when we specify the hardware offload for mqprio the queue > configuration is co

Re: [PATCH 00/10] Netfilter fixes for net

2017-03-15 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 15 Mar 2017 18:01:02 +0100 > The following patchset contains Netfilter fixes for your net tree, a > rather large batch of fixes targeted to nf_tables, conntrack and bridge > netfilter. More specifically, they are: > > 1) Don't track fragmented packets if the so

Re: [PATCH net] net/openvswitch: Set the ipv6 source tunnel key address attribute correctly

2017-03-15 Thread David Miller
From: Or Gerlitz Date: Wed, 15 Mar 2017 18:10:47 +0200 > When dealing with ipv6 source tunnel key address attribute > (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel > dst ip, fix that. > > Fixes: 6b26ba3a7d95 ('openvswitch: netlink attributes for IPv6 tunneling') > Signed-off-b

Re: net/udp: slab-out-of-bounds Read in udp_recvmsg

2017-03-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Mar 2017 09:10:33 -0700 > @@ -692,12 +692,17 @@ void __sock_recv_timestamp(struct msghdr *msg, struct > sock *sk, > ktime_to_timespec_cond(shhwtstamps->hwtstamp, tss.ts + 2)) > empty = 0; > if (!empty) { > + unsigned int

Re: [PATCH] netxen_nic: remove redundant check if retries is zero

2017-03-15 Thread David Miller
From: Colin King Date: Wed, 15 Mar 2017 15:31:58 + > From: Colin Ian King > > At the end of the timeout loop, retries will always be zero so > the check for zero is redundant so remove it. Also replace > printk with pr_err as recommended by checkpatch. > > Signed-off-by: Colin Ian King

Re: [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-15 Thread Pablo Neira Ayuso
On Wed, Mar 15, 2017 at 10:16:19PM +0100, Linus Lüssing wrote: > On Wed, Mar 15, 2017 at 07:15:39PM +0100, Pablo Neira Ayuso wrote: > > Could you update ebtables dnat to check if the ethernet address > > matches the one of the input bridge interface, so we mangle the > > ->pkt_type accordingly from

Re: [PATCH] nl80211: fix dumpit error path RTNL deadlocks

2017-03-15 Thread David Miller
From: Johannes Berg Date: Wed, 15 Mar 2017 14:29:13 +0100 > From: Johannes Berg > > Sowmini pointed out Dmitry's RTNL deadlock report to me, and it turns out > to be perfectly accurate - there are various error paths that miss unlock > of the RTNL. > > To fix those, change the locking a bit to

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

2017-03-15 Thread David Miller
From: Shubham Bansal Date: Wed, 15 Mar 2017 17:43:44 +0530 >> You can't truncate, but you'll have to build 64-bit ops using 32-bit >> registers. > > A small example would help a lot. You can simply perform 64-bit operations in C code and see what gcc outputs for that code on this 32-bit target

[PATCH v2] net: sun: sungem: rix a possible null dereference

2017-03-15 Thread Philippe Reynes
The function gem_begin_auto_negotiation dereference the pointer ep before testing if it's null. This patch add a check on ep before dereferencing it. Fixes: 92552fdd557 ("net: sun: sungem: use new api ethtool_{get|set}_link_ksettings") Reported-by: Dan Carpenter Signed-off-by: Philippe Reynes -

Re: [PATCH] net: sun: sungem: rix a possible null dereference

2017-03-15 Thread Philippe Reynes
Hi Sergei, On 3/15/17, Sergei Shtylyov wrote: > Hello! > > On 3/15/2017 12:23 AM, Philippe Reynes wrote: > >> The function gem_begin_auto_negotiation dereference >> the pointer ep before testing if it's null. This >> patch add a check on ep before dereferencing it. >> >> This issue was added by t

Re: [PATCH v3 net-next 00/11] net: stmmac: prepare dma operations for multiple queues

2017-03-15 Thread David Miller
From: Joao Pinto Date: Wed, 15 Mar 2017 11:04:44 + > As agreed with David Miller, this patch-set is the second of 3 to enable > multiple queues in stmmac. > > This second one concentrates on dma operations adding functionalities as: > a) DMA Operation Mode configuration per channel and done

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-03-15 Thread Pablo Neira Ayuso
Hi Harald, On Wed, Mar 15, 2017 at 08:10:38PM +0100, Harald Welte wrote: > I've modified the patch slightly, see below (compile-tested, but not > otherwise tested yet). Basically rename the flags attribute to 'role', > expand the commit log and removed unrelated cosmetic changes. > > I've also p

Re: Fw: [Bug 194723] connect() to localhost stalls after 4.9 -> 4.10 upgrade

2017-03-15 Thread Eric Dumazet
On Wed, 2017-03-15 at 13:36 -0700, Stephen Hemminger wrote: > > Begin forwarded message: > > Date: Wed, 15 Mar 2017 19:41:59 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 194723] connect() to localhost stalls after 4.9 -> 4.10 upgrade > > > h

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-15 Thread Jarod Wilson
On 2017-03-13 7:07 PM, David Arcari wrote: When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change. Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the assignment ndev->mtu = new

Re: [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-15 Thread Linus Lüssing
On Wed, Mar 15, 2017 at 07:15:39PM +0100, Pablo Neira Ayuso wrote: > Could you update ebtables dnat to check if the ethernet address > matches the one of the input bridge interface, so we mangle the > ->pkt_type accordingly from there, instead of doing this from the > core? Actually, that was the

Re: [PATCH net-next v2 0/3] net: dsa: check out-of-range ageing time

2017-03-15 Thread Andrew Lunn
> This patchset fixes this by adding ageing_time_min and ageing_time_max > fields to the dsa_switch structure, which can optionally be set by a DSA > driver. > > If provided, the DSA core will check for out-of-range values in the > SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME prepare phase and return -ERA

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-15 Thread Jarod Wilson
On 2017-03-08 4:33 PM, David Arcari wrote: When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change. Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the assignment ndev->mtu = new

Fw: [Bug 194723] connect() to localhost stalls after 4.9 -> 4.10 upgrade

2017-03-15 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 15 Mar 2017 19:41:59 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 194723] connect() to localhost stalls after 4.9 -> 4.10 upgrade https://bugzilla.kernel.org/show_bug.cgi?id=194723 --- Comment #15 from Lutz Vi

[PATCH net-next 1/2] tcp: remove per-destination timestamp cache

2017-03-15 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Commit 8a5bd45f6616 (tcp: randomize tcp timestamp offsets for each connection) randomizes TCP timestamps per connection. After this commit, there is no guarantee that the timestamps received from the same destination are monotonically increasing. As a result, the per-d

[PATCH net-next 2/2] tcp: remove tcp_tw_recycle

2017-03-15 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh The tcp_tw_recycle was already broken for connections behind NAT, since the per-destination timestamp is not monotonically increasing for multiple machines behind a single destination address. After the randomization of TCP timestamp offsets in commit 8a5bd45f6616 (tc

[PATCH net] net: properly release sk_frag.page

2017-03-15 Thread Eric Dumazet
From: Eric Dumazet I mistakenly added the code to release sk->sk_frag in sk_common_release() instead of sk_destruct() TCP sockets using sk->sk_allocation == GFP_ATOMIC do no call sk_common_release() at close time, thus leaking one (order-3) page. iSCSI is using such sockets. Fixes: 5640f768583

[PATCH net-next 5/7] drivers: net: xgene: Add workaround for errata 10GE_1

2017-03-15 Thread Iyappan Subramanian
From: Quan Nguyen This patch implements workaround for errata 10GE_1: 10Gb Ethernet port FIFO threshold default values are incorrect. Signed-off-by: Quan Nguyen Signed-off-by: Toan Le Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen --- drivers/net/ethernet/apm/xgene/xgene_enet_xgm

[PATCH net-next 4/7] drivers: net: xgene: Fix Rx checksum validation logic

2017-03-15 Thread Iyappan Subramanian
This patch fixes Rx checksum validation logic and adds NETIF_F_RXCSUM flag. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27 +++- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_

[PATCH net-next 6/7] drivers: net: xgene: Add workaround for errata 10GE_8/ENET_11

2017-03-15 Thread Iyappan Subramanian
This patch implements workaround for errata 10GE_8 and ENET_11: "HW reports length error for valid 64 byte frames with len <46 bytes" by recovering them from error. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen Signed-off-by: Toan Le Tested-by: Fushen Chen --- drivers/net/ethe

[PATCH net-next 3/7] drivers: net: xgene: Fix wrong logical operation

2017-03-15 Thread Iyappan Subramanian
From: Quan Nguyen This patch fixes the wrong logical OR operation by changing it to bit-wise OR operation. Fixes: 3bb502f83080 ("drivers: net: xgene: fix statistics counters race condition") Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgen

[PATCH net-next 0/7] drivers: net: xgene: Bug fixes and errata workarounds

2017-03-15 Thread Iyappan Subramanian
This patch set addresses bug fixes and errata workarounds. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- Iyappan Subramanian (3): drivers: net: xgene: Fix Rx checksum validation logic drivers: net: xgene: Add workaround for errata 10GE_8/ENET_11 MAINTAINERS: Update X-G

[PATCH net-next 2/7] drivers: net: xgene: Fix hardware checksum setting

2017-03-15 Thread Iyappan Subramanian
From: Quan Nguyen This patch fixes the hardware checksum settings by properly program the classifier. Otherwise, packet may be received with checksum error on X-Gene1 SoC. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 1 + d

[PATCH net-next 1/7] drivers: net: phy: xgene: Fix mdio write

2017-03-15 Thread Iyappan Subramanian
From: Quan Nguyen This patches fixes a typo in the argument to xgene_enet_wr_mdio_csr(). Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/phy/mdio-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/ne

[PATCH net-next 7/7] MAINTAINERS: Update X-Gene SoC ethernet maintainer

2017-03-15 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar Signed-off-by: Quan Nguyen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cefda30..632e762 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -896,6 +896,7 @@ F: arch/arm64/boot/dts/

Re: [PATCH net-next v2 2/3] net: dsa: check out-of-range ageing time value

2017-03-15 Thread Florian Fainelli
On 03/15/2017 12:53 PM, Vivien Didelot wrote: > If a DSA switch driver cannot program an ageing time value due to it > being out-of-range, switchdev will raise a stack trace before failing. > > To fix this, add ageing_time_min and ageing_time_max members to the > dsa_switch in order for the switch

Re: [PATCH net-next v2 1/3] net: dsa: dsa_fastest_ageing_time return unsigned

2017-03-15 Thread Florian Fainelli
On 03/15/2017 12:53 PM, Vivien Didelot wrote: > The ageing time is defined as unsigned int, so make > dsa_fastest_ageing_time return an unsigned int instead of int. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH net] amd-xgbe: Fix jumbo MTU processing on newer hardware

2017-03-15 Thread Tom Lendacky
Newer hardware does not provide a cumulative payload length when multiple descriptors are needed to handle the data. Once the MTU increases beyond the size that can be handled by a single descriptor, the SKB does not get built properly by the driver. The driver will now calculate the size of the d

Darlehen angebot 3 %

2017-03-15 Thread Frau SCHMIDT
Sehr geehrte Damen und Herren, Haben Sie Interesse über einer finanziellen Darlehen zu 3%??? kontaktieren Sie mich für mehr Details und Bedingungen. ich kann all jenen helfen, wer ein Darlehen benötigen. Ich kann Ihnen biete ein darlehen in hohe von 10.000.000 € Meine mail: info@rschmidt.onli

Re: [PATCH net-next v2 3/3] net: dsa: mv88e6xxx: specify ageing time limits

2017-03-15 Thread Florian Fainelli
On 03/15/2017 12:53 PM, Vivien Didelot wrote: > Now that DSA has ageing time limits, specify them when registering a > switch so that out-of-range values are handled correctly by the core. > > Signed-off-by: Vivien Didelot > Reported-by: Jason Cobham Reviewed-by: Florian Fainelli -- Florian

Re: [net-next v2 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-15

2017-03-15 Thread David Miller
From: Jeff Kirsher Date: Wed, 15 Mar 2017 02:25:33 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

[PATCH net] net: bcmgenet: Do not suspend PHY if Wake-on-LAN is enabled

2017-03-15 Thread Florian Fainelli
Suspending the PHY would be putting it in a low power state where it may no longer allow us to do Wake-on-LAN. Fixes: cc013fb48898 ("net: bcmgenet: correctly suspend and resume PHY device") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 -- 1 file chan

[PATCH net-next v2 1/3] net: dsa: dsa_fastest_ageing_time return unsigned

2017-03-15 Thread Vivien Didelot
The ageing time is defined as unsigned int, so make dsa_fastest_ageing_time return an unsigned int instead of int. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index c34872e1febc..cec47

[PATCH net-next v2 2/3] net: dsa: check out-of-range ageing time value

2017-03-15 Thread Vivien Didelot
If a DSA switch driver cannot program an ageing time value due to it being out-of-range, switchdev will raise a stack trace before failing. To fix this, add ageing_time_min and ageing_time_max members to the dsa_switch in order for the switch drivers to optionally specify their supported ageing ti

[PATCH net-next v2 0/3] net: dsa: check out-of-range ageing time

2017-03-15 Thread Vivien Didelot
The ageing time limits supported by DSA drivers vary depending on the switch model. If a driver returns -ERANGE for out-of-range values, the switchdev commit phase will fail with the following stacktrace: # brctl setageing br0 4 [ 8530.082179] WARNING: CPU: 0 PID: 910 at net/switchdev/swit

[PATCH net-next v2 3/3] net: dsa: mv88e6xxx: specify ageing time limits

2017-03-15 Thread Vivien Didelot
Now that DSA has ageing time limits, specify them when registering a switch so that out-of-range values are handled correctly by the core. Signed-off-by: Vivien Didelot Reported-by: Jason Cobham --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/n

Re: [PATCH net] fjes: Fix wrong netdevice feature flags

2017-03-15 Thread David Miller
From: Taku Izumi Date: Wed, 15 Mar 2017 13:47:50 +0900 > This patch fixes netdev->features for Extended Socket network device. > > Currently Extended Socket network device's netdev->feature claims > NETIF_F_HW_CSUM, however this is completely wrong. There's no feature > of checksum offloading. >

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-03-15 Thread Harald Welte
On Wed, Mar 15, 2017 at 08:10:38PM +0100, Harald Welte wrote: > I've modified the patch slightly, see below (compile-tested, but not > otherwise tested yet). Basically rename the flags attribute to 'role', > expand the commit log and removed unrelated cosmetic changes. I also have a version again

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-03-15 Thread Harald Welte
Hi Pablo, On Wed, Mar 15, 2017 at 06:23:48PM +0100, Pablo Neira Ayuso wrote: > On Wed, Mar 15, 2017 at 05:39:16PM +0100, Harald Welte wrote: > > > > I would definitely like to see this move forward, particularly in order > > to test the GGSN-side code. > > Agreed. I've modified the patch slight

Re: [RFC v1 for accelerated IPoIB 14/25] net/mlx5: Enable flow-steering for IB link

2017-03-15 Thread Leon Romanovsky
On Mon, Mar 13, 2017 at 08:31:25PM +0200, Erez Shitrit wrote: > > Get the relevant capabilities if supports ipoib_enhanced_offloads and > init the flow steering table accordingly. > > Signed-off-by: Erez Shitrit > --- > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 10 +- > drivers/

[PATCH net] MAINTAINERS: remove MACVLAN and VLAN entries

2017-03-15 Thread Pablo Neira Ayuso
macvlan.c file seems to be both in VLAN and MACVLAN DRIVER, so remove the MACVLAN DRIVER since this is redundant. I propose with this patch to remove the VLAN (802.1Q) entry so this just falls into the NETWORKING [GENERAL]. Signed-off-by: Pablo Neira Ayuso --- @David, please just place this in n

Re: net/sctp: recursive locking in sctp_do_peeloff

2017-03-15 Thread Cong Wang
On Wed, Mar 15, 2017 at 5:52 AM, Marcelo Ricardo Leitner wrote: > On Tue, Mar 14, 2017 at 09:52:15PM -0700, Cong Wang wrote: >> Instead of checking for the status of the sock, I believe the following >> one-line fix should do the trick too. Can you give it a try? >> >> diff --git a/net/sctp/socket

Re: [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-15 Thread Pablo Neira Ayuso
On Wed, Mar 15, 2017 at 03:27:20PM +0100, Linus Lüssing wrote: > On Wed, Mar 15, 2017 at 11:42:11AM +0100, Pablo Neira Ayuso wrote: > > I'm missing then why redirect is not then just enough for Linus usecase. > > For my usecase, the MAC address is configured by the user from a > Web-UI. It may or

[net-next PATCH 2/2] mqprio: Modify mqprio to pass user parameters via ndo_setup_tc.

2017-03-15 Thread Alexander Duyck
From: Amritha Nambiar The configurable priority to traffic class mapping and the user specified queue ranges are used to configure the traffic class, overriding the hardware defaults when the 'hw' option is set to 0. However, when the 'hw' option is non-zero, the hardware QOS defaults are used.

Re: [RFC v1 for accelerated IPoIB 05/25] IB/ipoib: Support ipoib acceleration options callbacks

2017-03-15 Thread Leon Romanovsky
On Wed, Mar 15, 2017 at 09:58:02AM -0600, Jason Gunthorpe wrote: > On Wed, Mar 15, 2017 at 08:47:51AM +0200, Leon Romanovsky wrote: > > On Tue, Mar 14, 2017 at 10:00:21AM -0600, Jason Gunthorpe wrote: > > > On Tue, Mar 14, 2017 at 04:42:55PM +0200, Erez Shitrit wrote: > > > > >> + if (!hca->a

[net-next PATCH 1/2] mqprio: Change handling of hw u8 to allow for multiple hardware offload modes

2017-03-15 Thread Alexander Duyck
From: Alexander Duyck This patch is meant to allow for support of multiple hardware offload type for a single device. There is currently no bounds checking for the hw member of the mqprio_qopt structure. This results in us being able to pass values from 1 to 255 with all being treated the same.

Re: [PATCH net] net/openvswitch: Set the ipv6 source tunnel key address attribute correctly

2017-03-15 Thread Joe Stringer
On 15 March 2017 at 09:28, Jiri Benc wrote: > On Wed, 15 Mar 2017 18:10:47 +0200, Or Gerlitz wrote: >> When dealing with ipv6 source tunnel key address attribute >> (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel >> dst ip, fix that. >> >> Fixes: 6b26ba3a7d95 ('openvswitch: netlin

[net-next PATCH 0/2] Add support for passing more information in mqprio offload

2017-03-15 Thread Alexander Duyck
This patch series lays the groundwork for future work to allow us to make full use of the mqprio options when offloading them to hardware. Currently when we specify the hardware offload for mqprio the queue configuration is completely ignored and the hardware is only notified of the total number o

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

2017-03-15 Thread Pablo Neira Ayuso
On Wed, Mar 15, 2017 at 05:39:16PM +0100, Harald Welte wrote: > Hi Jonas, > > are you working on the review feedback that was provided back in early > February? I think there were some comments like > * remove unrelated cosmetic change in comment > * change from FLAGS to a dedicated MODE netlink

  1   2   3   >