[patch net-next 1/2] ipv4: fib: Move FIB notification code to a separate file

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel Most of the code concerned with the FIB notification chain currently resides in fib_trie.c, but this isn't really appropriate, as the FIB notification chain is also used for FIB rules. Therefore, it makes sense to move the common FIB notification code to a separate file and ha

[patch net-next 2/2] ipv4: fib: Remove redundant argument

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel We always pass the same event type to fib_notify() and fib_rules_notify(), so we can safely drop this argument. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- include/net/ip_fib.h| 9 +++-- net/ipv4/fib_notifier.c | 4 ++-- net/ipv4/fib_rules.c| 5

[patch net-next 0/2] ipv4: fib: FIB notifications cleanup

2017-03-09 Thread Jiri Pirko
From: Jiri Pirko Ido says: The first patch moves the core FIB notification code to a separate file, so that code related to FIB rules is placed in fib_rules.c and not fib_trie.c. The reason for the change will become even more apparent in follow-up patchset where we extend the FIB rules notifica

[patch net-next 04/10] mlxsw: spectrum: Destroy RIFs based on last removed address

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel We only use the RIF reference count to determine when the last IP address was removed, but instead we can just test 'in_dev->ifa_list'. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 7 +++ drivers/net/ethernet

[patch net-next 10/10] mlxsw: spectrum_router: Make abort mechanism VR-aware

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel When the abort mechanism is invoked it binds the first virtual router (VR) to an LPM tree and inserts a default route to direct packets to the CPU. With VRFs, we can have router interfaces (RIFs) bound to multiple VRs, so we need to make sure packets are trapped from all VRs a

[patch net-next 05/10] mlxsw: spectrum_router: Allow more route types to be programmed

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel Allow 'unreachable', 'blackhole' and 'prohibit' route types to be programmed into the device by sending any packet hitting them to the CPU. This is needed so that users will be able to program a default route into the VRF's table, thereby preventing lookup from leaking to othe

[patch net-next 06/10] mlxsw: spectrum_router: Place RIF related code with router code

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel The inetaddr notification block is currently implemented in the main driver file, but this isn't really appropriate, as it mainly creates and destroys router interfaces (RIFs) which belong with the rest of the router code. This will become even more apparent later on when we'l

[patch net-next 09/10] mlxsw: spectrum_router: Explicitly Associate RIFs with VRs

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel Up until now we implicitly associated all the router interfaces (RIFs) with the first virtual router (VR). This must be changed in order to enable VRF offload. Otherwise, a packet received via a VRF slave would do a FIB lookup in the same table used by other VRFs. Instead, bin

[patch net-next 03/10] mlxsw: spectrum: Associate PVID vPort with appropriate netdev

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel When a VLAN device is configured on top of a LAG device (f.e., bond0.10), a vPort is created on top of each of the LAG's slaves and its 'dev' pointer is set to the VLAN device. This is in contrast to the implicit PVID vPort (representing 'bond0'), whose 'dev' pointer keeps poi

[patch net-next 07/10] mlxsw: spectrum_router: Simplify LPM tree allocation

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel When looking for a new LPM tree we should always consider all the unused trees. It doesn't matter if the new tree is required due to changes in currently used prefixes inside an existing routing table or because a route was inserted into an empty table. Both cases are function

[patch net-next 08/10] mlxsw: spectrum_router: Refactor virtual router handling

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel A virtual router (VR) is an entity within the device to which routing tables and interfaces can be bound to. It can be used to implement VRFs. In the initial implementation we associated the VR with a specific protocol (e.g., IPv4) and an LPM tree. However, this isn't really a

[patch net-next 02/10] mlxsw: spectrum: Don't assume upper device's type

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel When an upper device is configured on top of a vPort we make sure it's a bridge master during PRECHANGEUPPER and fail otherwise. Therefore, when CHANGEUPPER is later received we don't bother checking the upper's type. Make the code more extendable in preparation for VRF uppers

[patch net-next 01/10] mlxsw: spectrum: Sanitize bridge's upper devices

2017-03-09 Thread Jiri Pirko
From: Ido Schimmel We're going to allow bridges stacked on top of port netdevs to be enslaved to a VRF, but for now, only VLAN uppers of the VLAN-aware bridge are supported. Sanitize any other bridge upper. This is consistent with the way we sanitize port netdevs' uppers. Signed-off-by: Ido Sch

[patch net-next 00/10] mlxsw: Preparations for VRF offload

2017-03-09 Thread Jiri Pirko
From: Jiri Pirko Ido says: This patchset aims to prepare the mlxsw driver for VRF offload. The follow-up patchsets that introduce VRF support can be found here: https://github.com/idosch/linux/tree/idosch-next The first four patches are mainly concerned with the netdevice notification block. Th

[PATCH net] rxrpc: Wake up the transmitter if Rx window size increases on the peer

2017-03-09 Thread David Howells
The RxRPC ACK packet may contain an extension that includes the peer's current Rx window size for this call. We adjust the local Tx window size to match. However, the transmitter can stall if the receive window is reduced to 0 by the peer and then reopened. This is because the normal way that th

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-09 Thread Subash Abhinov Kasiviswanathan
Well, then you need to make sure ipprot->early_demux is read once in the callers, like ip_rcv_finish(), otherwise compiler could read it twice and we could deref a NULL pointer. ipprot = rcu_dereference(inet_protos[protocol]); if (ipprot && ipprot->early_demux) { ipprot->early_demux(skb);

Re: [PATCH net] net: phy: marvell: Fix double free of hwmon device

2017-03-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Mar 2017 20:53:31 +0100 > The hwmon temperature sensor devices is registered using a devm_hwmon > API call. The marvell_release() would then manually free the device, > not using a devm_hmon API, resulting in the device being removed > twice, leading to a crash in

RE: [PATCH net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-09 Thread Mintz, Yuval
> > We can't just require a new firmware version in the driver, as users > > most likely won't have it by the time they install the new kernel. So > > you'll have to support the old firmware version as well. > > Why not? That has been the paradigm forever. > > The new firmware version is already

RE: [PATCH net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-09 Thread Mintz, Yuval
> We can't just require a new firmware version in the driver, as users most > likely won't have it by the time they install the new kernel. So you'll have > to > support the old firmware version as well. Why not? That has been the paradigm forever. The new firmware version is already available

[PATCH net, v2] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jon Maxwell
As Eric Dumazet pointed out this also needs to be fixed in IPv6. v2: Contains the IPv6 tcp/Ipv6 dccp patches as well. We have seen a few incidents lately where a dst_enty has been freed with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that dst_entry. If the conditions/timings ar

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-09 Thread Subash Abhinov Kasiviswanathan
On 2017-03-09 20:42, Tom Herbert wrote: On Thu, Mar 9, 2017 at 7:31 PM, Subash Abhinov Kasiviswanathan wrote: Certain system process significant unconnected UDP workload. It would be preferrable to disable UDP early demux for those systems and enable it for TCP only. Presumably you want this

Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jonathan Maxwell
On Fri, Mar 10, 2017 at 3:23 PM, Eric Dumazet wrote: > On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote: >> As Eric Dumazet pointed out this also needs to be fixed in IPv6. >> v1: Contains the IPv6 patch as well. > >> Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") >> C

[PATCH v4 net-next 1/1] net: Eliminate duplicated codes by creating one new function in_dev_select_addr

2017-03-09 Thread fgao
From: Gao Feng There are two duplicated loops codes which used to select right address in current codes. Now eliminate these codes by creating one new function in_dev_select_addr. Signed-off-by: Gao Feng --- v4: Drop the first patch in series, per David Ahern v3: Add the cover letter, per Dav

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-09 Thread Eric Dumazet
On Thu, 2017-03-09 at 20:31 -0700, Subash Abhinov Kasiviswanathan wrote: > Certain system process significant unconnected UDP workload. > It would be preferrable to disable UDP early demux for those systems > and enable it for TCP only. > +void tcp_v4_early_demux_configure(int enable) > +{ > +

Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Eric Dumazet
On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote: > As Eric Dumazet pointed out this also needs to be fixed in IPv6. > v1: Contains the IPv6 patch as well. > Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") > Cc: Eric Garver > Cc: Hannes Sowa > Signed-off-by: Jon Maxwe

Re: [PATCHv2 net-next 0/7] sctp: add receiver-side procedures for stream reconf asoc reset and add streams and response

2017-03-09 Thread Xin Long
On Fri, Mar 10, 2017 at 12:11 PM, Xin Long wrote: > Patch 2/7, 4/7, 5/7, 6/7 are to implement the process of asoc reset request, > add streams requests and all kinds of responses. > > Patch 1/7 and 3/7 are ahead of 2/7 and 4/7 to add two event notification > for asoc reset and add streams. > > Pat

[PATCHv2 net-next 5/7] sctp: implement receiver-side procedures for the Add Incoming Streams Request Parameter

2017-03-09 Thread Xin Long
This patch is to implement Receiver-Side Procedures for the Add Incoming Streams Request Parameter described in rfc6525 section 5.2.6. It is also to fix that it shouldn't have add streams when sending addstrm in request, as the process in peer will handle it by sending a addstrm out request back.

[PATCHv2 net-next 6/7] sctp: implement receiver-side procedures for the Reconf Response Parameter

2017-03-09 Thread Xin Long
This patch is to implement Receiver-Side Procedures for the Re-configuration Response Parameter in rfc6525 section 5.2.7. sctp_process_strreset_resp would process the response for any kind of reconf request, and the stream reconf is applied only when the response result is success. Signed-off-by:

[PATCHv2 net-next 4/7] sctp: implement receiver-side procedures for the Add Outgoing Streams Request Parameter

2017-03-09 Thread Xin Long
This patch is to add Receiver-Side Procedures for the Add Outgoing Streams Request Parameter described in section 5.2.5. It is also to improve sctp_chunk_lookup_strreset_param, so that it can be used for processing addstrm_out request. Signed-off-by: Xin Long --- include/net/sctp/sm.h | 4 ++

[PATCHv2 net-next 7/7] sctp: add get and set sockopt for reconf_enable

2017-03-09 Thread Xin Long
This patchset is to add SCTP_RECONFIG_SUPPORTED sockopt, it would set and get asoc reconf_enable value when asoc_id is set, or it would set and get ep reconf_enalbe value if asoc_id is 0. It is also to add sysctl interface for users to set the default value for reconf_enable. After this patch, st

[PATCHv2 net-next 3/7] sctp: add support for generating add stream change event notification

2017-03-09 Thread Xin Long
This patch is to add Stream Change Event described in rfc6525 section 6.1.3. Signed-off-by: Xin Long --- include/net/sctp/ulpevent.h | 4 include/uapi/linux/sctp.h | 15 +++ net/sctp/ulpevent.c | 28 3 files changed, 47 insertions(+) diff

[PATCHv2 net-next 1/7] sctp: add support for generating assoc reset event notification

2017-03-09 Thread Xin Long
This patch is to add Association Reset Event described in rfc6525 section 6.1.2. Signed-off-by: Xin Long --- include/net/sctp/ulpevent.h | 4 include/uapi/linux/sctp.h | 15 +++ net/sctp/ulpevent.c | 28 3 files changed, 47 insertions(+)

[PATCHv2 net-next 2/7] sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter

2017-03-09 Thread Xin Long
This patch is to implement Receiver-Side Procedures for the SSN/TSN Reset Request Parameter described in rfc6525 section 6.2.4. The process is kind of complicate, it's wonth having some comments from section 6.2.4 in the codes. Signed-off-by: Xin Long --- include/net/sctp/sm.h | 4 +++ net/s

Re: [PATCH v3 net-next 1/2] net: Avoid unnessary loop when master_idx is invalid in inet_select_addr

2017-03-09 Thread Feng Gao
Hi David, On Fri, Mar 10, 2017 at 11:58 AM, David Ahern wrote: > On 3/9/17 7:52 PM, f...@ikuai8.com wrote: >> From: Gao Feng >> >> When master_idx is invalid, it is zero. It is unnecessary to iterate >> all netdevs. Because l3mdev_master_ifindex_rcu(dev) != master_idx must >> be true. >> Now put

[PATCHv2 net-next 0/7] sctp: add receiver-side procedures for stream reconf asoc reset and add streams and response

2017-03-09 Thread Xin Long
Patch 2/7, 4/7, 5/7, 6/7 are to implement the process of asoc reset request, add streams requests and all kinds of responses. Patch 1/7 and 3/7 are ahead of 2/7 and 4/7 to add two event notification for asoc reset and add streams. Patch 7/7 is the last patch for implementing rfc6525 sctp stream r

Re: [PATCH v3 net-next 1/2] net: Avoid unnessary loop when master_idx is invalid in inet_select_addr

2017-03-09 Thread David Ahern
On 3/9/17 7:52 PM, f...@ikuai8.com wrote: > From: Gao Feng > > When master_idx is invalid, it is zero. It is unnecessary to iterate > all netdevs. Because l3mdev_master_ifindex_rcu(dev) != master_idx must > be true. > Now put this loop into the condition block when master_idx is valid. you are s

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-09 Thread Tom Herbert
On Thu, Mar 9, 2017 at 7:31 PM, Subash Abhinov Kasiviswanathan wrote: > Certain system process significant unconnected UDP workload. > It would be preferrable to disable UDP early demux for those systems > and enable it for TCP only. > Presumably you want this for performance reasons. Can you prov

[PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-09 Thread Subash Abhinov Kasiviswanathan
Certain system process significant unconnected UDP workload. It would be preferrable to disable UDP early demux for those systems and enable it for TCP only. v1->v2: Change function pointer instead of adding conditional as suggested by Stephen. Signed-off-by: Subash Abhinov Kasiviswanathan Sugge

[PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jon Maxwell
As Eric Dumazet pointed out this also needs to be fixed in IPv6. v1: Contains the IPv6 patch as well. We have seen a few incidents lately where a dst_enty has been freed with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that dst_entry. If the conditions/timings are right a crash

[PATCH v3 net-next 0/2] net: Refine the inet_select_addr codes

2017-03-09 Thread fgao
From: Gao Feng This collection contains two patches used to refine the inet_select_addr codes. Gao Feng (2): net: Avoid unnessary loop when master_idx is invalid in inet_select_addr net: Eliminate duplicated codes by creating one new function in_dev_select_addr net/ipv4/devine

[PATCH v3 net-next 1/2] net: Avoid unnessary loop when master_idx is invalid in inet_select_addr

2017-03-09 Thread fgao
From: Gao Feng When master_idx is invalid, it is zero. It is unnecessary to iterate all netdevs. Because l3mdev_master_ifindex_rcu(dev) != master_idx must be true. Now put this loop into the condition block when master_idx is valid. Signed-off-by: Gao Feng --- v3: Add the cover letter, per Dav

Re: [PATCH net-next v2 2/2] mpls: allow TTL propagation from IP packets to be configured

2017-03-09 Thread David Ahern
On 3/7/17 5:46 PM, Robert Shearman wrote: > @@ -78,6 +70,29 @@ static int mpls_xmit(struct sk_buff *skb) > > tun_encap_info = mpls_lwtunnel_encap(dst->lwtstate); > > + /* Obtain the ttl */ > + if (dst->ops->family == AF_INET) { > + if (tun_encap_info->ttl_propagate ==

[PATCH v3 net-next 2/2] net: Eliminate duplicated codes by creating one new function in_dev_select_addr

2017-03-09 Thread fgao
From: Gao Feng There are two duplicated loops codes which used to select right address in current codes. Now eliminate these codes by creating one new function in_dev_select_addr. Signed-off-by: Gao Feng --- v3: Add cover letter v2: Correct the comit log and remove useless braces, per Sergei

Re: [PATCH net-next v2 1/2] mpls: allow TTL propagation to IP packets to be configured

2017-03-09 Thread David Ahern
On 3/7/17 5:46 PM, Robert Shearman wrote: > diff --git a/include/net/netns/mpls.h b/include/net/netns/mpls.h > index d29203651c01..58e0e46c4a5c 100644 > --- a/include/net/netns/mpls.h > +++ b/include/net/netns/mpls.h > @@ -10,7 +10,9 @@ struct ctl_table_header; > > struct netns_mpls { > si

Re: [PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

2017-03-09 Thread David Miller
From: Doug Berger Date: Thu, 9 Mar 2017 16:58:42 -0800 > v2: Accidentally sent the wrong set after rebasing. > > This collection contains a number of fixes for minor issues with the > bcmgenet driver most of which were present in the initial submission > of the driver. ... Series applied, tha

Re: [PATCH v2] udp: avoid ufo handling on IP payload compression packets

2017-03-09 Thread David Miller
From: Alexey Kodanev Date: Thu, 9 Mar 2017 13:56:46 +0300 > commit c146066ab802 ("ipv4: Don't use ufo handling on later transformed > packets") and commit f89c56ce710a ("ipv6: Don't use ufo handling on > later transformed packets") added a check that 'rt->dst.header_len' isn't > zero in order to

Re: [PATCH v2 net-next 2/2] net: Eliminate duplicated codes by creating one new function in_dev_select_addr

2017-03-09 Thread David Miller
When you change any patch in a patch series, you must repost the entire patch series with a proper cover letter rather than just the patches which change. Thanks.

Re: [patch net-next 0/2] mlxsw: spectrum: Add support for VLAN offload for cls_flower

2017-03-09 Thread David Miller
From: Jiri Pirko Date: Thu, 9 Mar 2017 09:25:18 +0100 > This patchset adds support to offload VLAN modify TC action and adds support > to offload cls_flower rules that include VID and PCP matching. Series applied, thanks Jiri.

Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove

2017-03-09 Thread Andrew Lunn
> -static int _mv88e6xxx_atu_cmd(struct mv88e6xxx_chip *chip, u16 fid, u16 cmd) > -{ > - u16 val; > - int err; > - > - if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G1_ATU_FID)) { > - err = mv88e6xxx_g1_write(chip, GLOBAL_ATU_FID, fid); > - if (err) > -

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-09 Thread David Miller
From: Tom Lendacky Date: Thu, 9 Mar 2017 17:48:23 -0600 > Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() > and enable_irq() when an interrupt is received to process Rx packets. If > the napi_complete_done() return value isn't checked an unbalanced enable > for the IRQ

Re: [PATCH net] rxrpc: rxrpc_kernel_send_data() needs to handle failed call better

2017-03-09 Thread David Miller
From: David Howells Date: Thu, 09 Mar 2017 08:10:32 + > If rxrpc_kernel_send_data() is asked to send data through a call that has > already failed (due to a remote abort, received protocol error or network > error), then return the associated error code saved in the call rather than > ESHUTDO

Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:14PM -0500, Vivien Didelot wrote: > All Marvell switch chips have an ATU accessed using the same Global (1) > register layout. Only the handling of the FID differs as more bits were > necessary to support more and more databases. > > Add and use a fresh documented imp

Re: [PATCH net-next] tcp: rename *_sequence_number() to *_seq_and_tsoff()

2017-03-09 Thread David Miller
From: Alexey Kodanev Date: Thu, 9 Mar 2017 13:53:55 +0300 > The functions that are returning tcp sequence number also setup > TS offset value, so rename them to better describe their purpose. > > No functional changes in this patch. > > Suggested-by: Eric Dumazet > Signed-off-by: Alexey Kodan

Re: [PATCH net] net: Work around lockdep limitation in sockets that use sockets

2017-03-09 Thread David Miller
From: David Howells Date: Thu, 09 Mar 2017 08:09:05 + > Lockdep issues a circular dependency warning when AFS issues an operation > through AF_RXRPC from a context in which the VFS/VM holds the mmap_sem. > > The theory lockdep comes up with is as follows: ... > However, lockdep's theory is

Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-09 Thread David Miller
From: Jon Maxwell Date: Thu, 9 Mar 2017 12:15:21 +1100 > We have seen a few incidents lately where a dst_enty has been freed > with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that > dst_entry. If the conditions/timings are right a crash then ensues when the > freed dst_entry

Re: [PATCH] net: ks8851: Added support for half-duplex SPI

2017-03-09 Thread David Miller
From: Sergey Shcherbakov Date: Thu, 9 Mar 2017 02:58:14 +0200 > In original driver was implemented support for half- > and full-duplex modes, but it was not enabled. Instead > of it ks8851_rx_1msg method always returns "true" that > means "full-duplex" mode. > > This patch replaces hard-coded f

Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:13PM -0500, Vivien Didelot wrote: > Marvell switch chips which can be interconnected have an ATU Learn2All > feature which allows chosen ports to also learn newly added addresses. > > Enable this feature and mark the DSA links as so called "Message Ports". Hi Vivien

Re: [PATCH net-next v2 1/2] mpls: allow TTL propagation to IP packets to be configured

2017-03-09 Thread David Ahern
On 3/7/17 5:46 PM, Robert Shearman wrote: > @@ -244,24 +245,33 @@ static bool mpls_egress(struct mpls_route *rt, struct > sk_buff *skb, > payload_type = ip_hdr(skb)->version; > > switch (payload_type) { > - case MPT_IPV4: { > - struct iphdr *hdr4 = ip_hdr(skb)

Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:13PM -0500, Vivien Didelot wrote: > Marvell switch chips which can be interconnected have an ATU Learn2All > feature which allows chosen ports to also learn newly added addresses. > > Enable this feature and mark the DSA links as so called "Message Ports". > > Signed

Re: [PATCH-v4-RESEND 1/4] vsock: track pkt owner vsock

2017-03-09 Thread Stefan Hajnoczi
On Fri, Mar 03, 2017 at 09:25:54AM +0800, Peng Tao wrote: > On Fri, Mar 3, 2017 at 5:13 AM, David Miller wrote: > > From: Peng Tao > > Date: Wed, 1 Mar 2017 11:56:24 +0800 > > > >> So that we can cancel a queued pkt later if necessary. > >> > >> Reviewed-by: Stefan Hajnoczi > >> Signed-off-by:

[PATCH v2 net-next 2/2] net: Eliminate duplicated codes by creating one new function in_dev_select_addr

2017-03-09 Thread fgao
From: Gao Feng There are two duplicated loops codes which used to select right address in current codes. Now eliminate these codes by creating one new function in_dev_select_addr. Signed-off-by: Gao Feng --- v2: Correct the comit log and remove useless braces, per Sergei v1: Initial Version

Re: [PATCH v2 net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > When using the internal PHY it must be powered up when the MII is probed > or the PHY will not be detected. Since the PHY is powered up at reset > this has not been a problem. However, when the kernel is restarted with > kexec the PHY will likely be po

Re: [PATCH v2 net 7/8] net: bcmgenet: add begin/complete ethtool ops

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > From: Edwin Chan > > Make sure clock is enabled for ethtool ops. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Edwin Chan > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > v2: Accidentally sent the wrong set after rebasing. > > This collection contains a number of fixes for minor issues with the > bcmgenet driver most of which were present in the initial submission > of the driver. This entire series looks great, thanks

Re: [PATCH v2 net 8/8] net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > The bcmgenet_tx_reclaim() function is used to reclaim transmit > resources in different places within the driver. Most of them > should not affect the state of the transmit flow control. > > This commit relocates the logic for waking tx queues based on

Re: [PATCH v2 net 5/8] net: bcmgenet: synchronize irq0 status between the isr and task

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > Add a spinlock to ensure that irq0_stat is not unintentionally altered > as the result of preemption. Also removed unserviced irq0 interrupts > and removed irq1_stat since there is no bottom half service for those > interrupts. > > Fixes: 1c1008c793fa

Re: [PATCH v2 net 2/8] net: bcmgenet: correct MIB access of UniMAC RUNT counters

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > The gap between the Tx status counters and the Rx RUNT counters is now > being added to allow correct reporting of the registers. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainell

Re: [PATCH v2 net 4/8] net: bcmgenet: power down internal phy if open or resume fails

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > Since the internal PHY is powered up during the open and resume > functions it should be powered back down if the functions fail. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainell

Re: [PATCH v2 net 3/8] net: bcmgenet: reserved phy revisions must be checked first

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > The reserved gphy_rev value of 0x01ff must be tested before the old > or new scheme for GPHY major versioning are tested, otherwise it will > be treated as 0xff00 according to the old scheme. > > Fixes: b04a2f5b9ff5 ("net: bcmgenet: add support for new

Re: [PATCH v2 net 1/8] net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values

2017-03-09 Thread Florian Fainelli
On 03/09/2017 04:58 PM, Doug Berger wrote: > The location of the RBUF overflow and error counters has moved between > different version of the GENET MAC. This commit corrects the driver to > read from the correct locations depending on the version of the GENET > MAC. > > Fixes: 1c1008c793fa ("net

Re: [PATCH net 0/4] bnxt_en: Misc. small fixes.

2017-03-09 Thread David Miller
From: Michael Chan Date: Wed, 8 Mar 2017 18:44:31 -0500 > Fixes include moving the initial function reset, notifying the RDMA driver > during tx timeout, setting dcbx_cap properly depending on whether the > firmware agent is running or not, and an autoneg related improvement. Series applied, t

Re: [PATCH net-next 2/2] net: Eliminate duplicated codes by creating one new function in_dev_select_addr

2017-03-09 Thread Feng Gao
Hi Sergei, On Tue, Mar 7, 2017 at 11:46 PM, Sergei Shtylyov wrote: > Hello! > > On 03/07/2017 05:51 PM, f...@ikuai8.com wrote: > >> From: Gao Feng >> >> There are two duplicated loop codes which used to select right > > >Just "loops". > >> address in current codes. Now eliminate these codes

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-09 Thread David Miller
From: Yasuaki Ishimatsu Date: Wed, 8 Mar 2017 16:05:18 -0500 > The fjes driver is used only by FUJITSU servers and almost of all > servers in the world never use it. But currently if ACPI PNP0C02 > is defined in the ACPI table, the following message is always shown: > > "FUJITSU Extended Socket

Re: [PATCH next 0/5] bonding: winter cleanup

2017-03-09 Thread David Miller
From: Mahesh Bandewar Date: Wed, 8 Mar 2017 10:55:45 -0800 > Few cleanup patches that I have accumulated over some time now. > > (a) First two patches are basically to move the work-queue initialization > from every ndo_open / bond_open operation to once at the beginning while > port cr

Re: [PATCH v2] net: initialize msg.msg_flags in recvfrom

2017-03-09 Thread David Miller
From: Alexander Potapenko Date: Wed, 8 Mar 2017 18:08:16 +0100 > KMSAN reports a use of uninitialized memory in put_cmsg() because > msg.msg_flags in recvfrom haven't been initialized properly. > The flag values don't affect the result on this path, but it's still a > good idea to initialize the

Re: [PATCH] tun: remove copyright printing

2017-03-09 Thread David Miller
From: Corentin Labbe Date: Wed, 8 Mar 2017 16:46:57 +0100 > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > > Signed-off-by: Corentin L

[PATCH net-next] liquidio: optimize DMA in NUMA systems

2017-03-09 Thread Felix Manlunas
From: VSR Burru Optimize DMA in NUMA systems by allocating memory from NUMA node that NIC is plugged in to; DMA will no longer cross NUMA nodes. If NIC IRQs are pinned to a local CPU, that CPU's access to the DMA'd data is also optimized. Signed-off-by: VSR Burru Signed-off-by: Felix Manlunas

[PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

2017-03-09 Thread Doug Berger
v2: Accidentally sent the wrong set after rebasing. This collection contains a number of fixes for minor issues with the bcmgenet driver most of which were present in the initial submission of the driver. Some bugs were uncovered by inspection prior to the upcoming update for GENETv5 support: n

[PATCH v2 net 1/8] net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values

2017-03-09 Thread Doug Berger
The location of the RBUF overflow and error counters has moved between different version of the GENET MAC. This commit corrects the driver to read from the correct locations depending on the version of the GENET MAC. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Doug

[PATCH v2 net 3/8] net: bcmgenet: reserved phy revisions must be checked first

2017-03-09 Thread Doug Berger
The reserved gphy_rev value of 0x01ff must be tested before the old or new scheme for GPHY major versioning are tested, otherwise it will be treated as 0xff00 according to the old scheme. Fixes: b04a2f5b9ff5 ("net: bcmgenet: add support for new GENET PHY revision scheme") Signed-off-by: Doug Berg

[PATCH v2 net 2/8] net: bcmgenet: correct MIB access of UniMAC RUNT counters

2017-03-09 Thread Doug Berger
The gap between the Tx status counters and the Rx RUNT counters is now being added to allow correct reporting of the registers. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 11 +++ 1 file chang

[PATCH v2 net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII

2017-03-09 Thread Doug Berger
When using the internal PHY it must be powered up when the MII is probed or the PHY will not be detected. Since the PHY is powered up at reset this has not been a problem. However, when the kernel is restarted with kexec the PHY will likely be powered down when the kernel starts so it will not be

[PATCH v2 net 7/8] net: bcmgenet: add begin/complete ethtool ops

2017-03-09 Thread Doug Berger
From: Edwin Chan Make sure clock is enabled for ethtool ops. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Edwin Chan Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 18 ++ 1 file changed, 18 insertions(+) diff --gi

[PATCH v2 net 8/8] net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim

2017-03-09 Thread Doug Berger
The bcmgenet_tx_reclaim() function is used to reclaim transmit resources in different places within the driver. Most of them should not affect the state of the transmit flow control. This commit relocates the logic for waking tx queues based on freed resources to the napi polling function where i

[PATCH v2 net 4/8] net: bcmgenet: power down internal phy if open or resume fails

2017-03-09 Thread Doug Berger
Since the internal PHY is powered up during the open and resume functions it should be powered back down if the functions fail. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 1 file changed, 4 in

[PATCH v2 net 5/8] net: bcmgenet: synchronize irq0 status between the isr and task

2017-03-09 Thread Doug Berger
Add a spinlock to ensure that irq0_stat is not unintentionally altered as the result of preemption. Also removed unserviced irq0 interrupts and removed irq1_stat since there is no bottom half service for those interrupts. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by:

[PATCH net 0/8] net: bcmgenet: minor bug fixes

2017-03-09 Thread Doug Berger
This collection contains a number of fixes for minor issues with the bcmgenet driver most of which were present in the initial submission of the driver. Some bugs were uncovered by inspection prior to the upcoming update for GENETv5 support: net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_

[PATCH net 1/8] net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values

2017-03-09 Thread Doug Berger
From: Doug Berger The location of the RBUF overflow and error counters has moved between different version of the GENET MAC. This commit corrects the driver to read from the correct locations depending on the version of the GENET MAC. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet: add

[PATCH net 3/8] net: bcmgenet: reserved phy revisions must be checked first

2017-03-09 Thread Doug Berger
From: Doug Berger The reserved gphy_rev value of 0x01ff must be tested before the old or new scheme for GPHY major versioning are tested, otherwise it will be treated as 0xff00 according to the old scheme. refs #SWLINUX-4311 Fixes: b04a2f5b9ff5 ("net: bcmgenet: add support for new GENET PHY rev

[PATCH net 4/8] net: bcmgenet: power down internal phy if open or resume fails

2017-03-09 Thread Doug Berger
From: Doug Berger Since the internal PHY is powered up during the open and resume functions it should be powered back down if the functions fail. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/b

[PATCH net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII

2017-03-09 Thread Doug Berger
From: Doug Berger When using the internal PHY it must be powered up when the MII is probed or the PHY will not be detected. Since the PHY is powered up at reset this has not been a problem. However, when the kernel is restarted with kexec the PHY will likely be powered down when the kernel star

[PATCH net 2/8] net: bcmgenet: correct MIB access of UniMAC RUNT counters

2017-03-09 Thread Doug Berger
From: Doug Berger The gap between the Tx status counters and the Rx RUNT counters is now being added to allow correct reporting of the registers. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/b

[PATCH net 8/8] net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim

2017-03-09 Thread Doug Berger
From: Doug Berger The bcmgenet_tx_reclaim() function is used to reclaim transmit resources in different places within the driver. Most of them should not affect the state of the transmit flow control. This commit relocates the logic for waking tx queues based on freed resources to the napi poll

[PATCH net 7/8] net: bcmgenet: add begin/complete ethtool ops

2017-03-09 Thread Doug Berger
From: Edwin Chan Make sure clock is enabled for ethtool ops. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Edwin Chan Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 18 ++ 1 file changed, 18 inse

[PATCH net 5/8] net: bcmgenet: synchronize irq0 status between the isr and task

2017-03-09 Thread Doug Berger
From: Doug Berger Add a spinlock to ensure that irq0_stat is not unintentionally altered as the result of preemption. Also removed unserviced irq0 interrupts and removed irq1_stat since there is no bottom half service for those interrupts. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet

Re: [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time setter

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:12PM -0500, Vivien Didelot wrote: > Move the ATU ageing time setter code in the new global1_atu.c file, and > add an mv88e6xxx_atu_setup helper to configure and initialize the ATU. I would of done this as two patches. Currently, it is not clear why you are adding the

Re: [PATCH net-next 0/9] nfp: CRC32 RSS hash, port name reporting and misc fastpath cleanups

2017-03-09 Thread David Miller
From: Jakub Kicinski Date: Wed, 8 Mar 2017 08:56:59 -0800 > This series adds support for CRC32 RSS hash function to kernel API > of which NFP driver immediately makes use. There is also a > .ndo_get_phys_port_name() implementation conforming to switchdev > name format. Small patch takes advan

Re: [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority override op

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:23PM -0500, Vivien Didelot wrote: > Add a new operation to disable the DA, SA and VTU priority override. > > Setting such limit is not likely to be used soon, so provide a > port_disable_pri_override operation directly. This can be changed later > for port_set_pri_ove

Re: [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn limit op

2017-03-09 Thread Andrew Lunn
On Thu, Mar 09, 2017 at 06:33:22PM -0500, Vivien Didelot wrote: > Add a new operation to disable the limiting of learnt MAC addresses. > > Setting such limit is not likely to be used soon, so provide a > port_disable_learn_limit operation directly. This can be changed later > for port_set_learn_li

Re: [PATCH net-next v2] net/socket: use per af lockdep classes for sk queues

2017-03-09 Thread David Miller
From: Paolo Abeni Date: Thu, 9 Mar 2017 13:54:08 +0100 > Currently the sock queue's spin locks get their lockdep > classes by the default init_spin_lock() initializer: > all socket families get - usually, see below - a single > class for rx, another specific class for tx, etc. > This can lead to

  1   2   3   >