please get back to me

2017-01-18 Thread Quatif Group of Companies.
-- Dear Friend, I would like to discuss a very important issue with you. I am writing to find out if this is your valid email. Please, let me know if this email is valid Kind regards Adrien Saif Attorney to Quatif Group of Companies

[PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-18 Thread Eric Dumazet
From: Eric Dumazet A driver using dev_alloc_page() must not reuse a page allocated from emergency memory reserve. Otherwise all packets using this page will be immediately dropped, unless for very specific sockets having SOCK_MEMALLOC bit set. This issue might be hard to debug, because only a f

Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-01-18 Thread Doug Ledford
On Wed, 2017-01-18 at 14:42 +0530, Selvin Xavier wrote: > On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky > wrote: > > > > It is better to use already existing macros - min() > > cq->max_cql = min(entries, MAX_CQL_PER_POLL); > > > > I afraid that you can't avoid the respinning, you have more th

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-18 Thread Leon Romanovsky
On Wed, Jan 18, 2017 at 01:45:14PM -0800, Bart Van Assche wrote: > On 01/18/2017 10:31 AM, Jason Gunthorpe wrote: > > I think it depends on what this tool is supposed to cover, but based > > on the description, I would start with netlink-only. > > > > The only place verbs covers a similar ground is

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread Doug Ledford
On Thu, 2017-01-19 at 00:38 -0500, David Miller wrote: > From: Tom Herbert > Date: Wed, 18 Jan 2017 21:22:53 -0800 > > > In principle I  agree, but as I previously wrote backporting this > > driver is already a bear. We need to do something here as this is > > quickly approaching being infeasible

Re: [PATCH] stmmac: adding EEE to GMAC4

2017-01-18 Thread Rayagond Kokatanur
On Thu, Dec 29, 2016 at 10:40 PM, Joao Pinto wrote: > This patch adds Energy Efficiency Ethernet to GMAC4. > > Signed-off-by: Joao Pinto > --- > drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 12 + > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 59 > +++ > 2

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-18 Thread Leon Romanovsky
On Wed, Jan 18, 2017 at 07:50:26PM +0200, Or Gerlitz wrote: > On Wed, Jan 18, 2017 at 7:33 PM, Leon Romanovsky wrote: > > On Wed, Jan 18, 2017 at 06:48:21PM +0200, Or Gerlitz wrote: > >> On Wed, Jan 18, 2017 at 5:19 PM, Ariel Almog > >> wrote: > > >> What's wrong with the RDMA netlink infrastructu

[PATCH net] MAINTAINERS: update cxgb4 maintainer

2017-01-18 Thread Hariprasad Shenai
Ganesg will be taking over as maintainer from now Signed-off-by: Hariprasad Shenai --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c36976d3bd1a..af3456d33a18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3564,7 +3564,7 @@ F:

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread David Miller
From: Tom Herbert Date: Wed, 18 Jan 2017 21:22:53 -0800 > In principle I agree, but as I previously wrote backporting this > driver is already a bear. We need to do something here as this is > quickly approaching being infeasible to backport. Even if we don't > restructure the directories I'd st

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread Tom Herbert
On Wed, Jan 18, 2017 at 9:32 AM, David Miller wrote: > From: Saeed Mahameed > Date: Mon, 16 Jan 2017 22:30:29 +0200 > >>> But please bear with me here, what if we queue this patch up to -stable ? > > You've got to be seriously kidding me that your idea is to submit an > incredibly diruptive drive

Re: [PATCH net-next] macb: Common code to enable ptp support for SAMA5Dx platforms.

2017-01-18 Thread Harini Katakam
On Wed, Jan 18, 2017 at 11:02 PM, Nicolas Ferre wrote: > Le 18/01/2017 à 09:57, Andrei Pistirica a écrit : >> This patch does the following: >> - add GEM-PTP interface >> - registers and bitfields for TSU are named according to SAMA5Dx data sheet >> - PTP support based on platform capability > > T

[PATCH net] gianfar: Do not reuse pages from emergency reserve

2017-01-18 Thread Eric Dumazet
From: Eric Dumazet A driver using dev_alloc_page() must not reuse a page that had to use emergency memory reserve. Otherwise all packets using this page will be immediately dropped, unless for very specific sockets having SOCK_MEMALLOC bit set. This issue might be hard to debug, because only a

linux-next: build failure after merge of the rcu tree

2017-01-18 Thread Stephen Rothwell
Hi Paul, After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/smc/af_smc.c:102:16: error: 'SLAB_DESTROY_BY_RCU' undeclared here (not in a function) .slab_flags = SLAB_DESTROY_BY_RCU, ^ Caused by commit c7a545924ca1 ("mm: Rename SL

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-18 Thread Jason Wang
On 2017年01月18日 23:15, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-18 Thread Jason Wang
On 2017年01月18日 23:18, Michael S. Tsirkin wrote: On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: On 2017年01月18日 02:27, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced

[PATCH net-next v4] bridge: multicast to unicast

2017-01-18 Thread Linus Lüssing
From: Felix Fietkau Implements an optional, per bridge port flag and feature to deliver multicast packets to any host on the according port via unicast individually. This is done by copying the packet per host and changing the multicast destination MAC to a unicast one accordingly. multicast-to-

Re: [PATCH] Avoid in6_addr redefinition

2017-01-18 Thread David Miller
From: Zheng Ruoqin Date: Thu, 19 Jan 2017 10:25:16 +0800 > Due to both and being included, the > in6_addr is being redefined: once from the C library headers and once > from the kernel headers. This causes some build failures with for > example the musl C library. > > In order to fix this, u

[PATCH] Avoid in6_addr redefinition

2017-01-18 Thread Zheng Ruoqin
Due to both and being included, the in6_addr is being redefined: once from the C library headers and once from the kernel headers. This causes some build failures with for example the musl C library. In order to fix this, use just the C library header . Original patch taken from http://git.alp

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Andy Lutomirski
On Wed, Jan 18, 2017 at 4:59 PM, Tejun Heo wrote: > Hello, Andy. > > On Wed, Jan 18, 2017 at 04:18:04PM -0800, Andy Lutomirski wrote: >> To map cgroup -> hook, a simple array in each cgroup structure works. >> To map (cgroup, netns) -> hook function, the natural approach would be >> to have some k

[PATCH v6 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Patches to create the make and configuration files. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/Kconfig | 20 ++

[PATCH v6 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-18 Thread Alexander Loktionov
From: David VomLehn This series introduces the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. This series introduces the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v1: Initial version v2: o Make necessary drivers/net/ethernet changes to integrate softwa

[PATCH v6 03/13] net: ethernet: aquantia: Add ring support code

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add code to support the transmit and receive ring buffers. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c

[PATCH v6 02/13] net: ethernet: aquantia: Common functions and definitions

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/ne

[PATCH v6 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add common functions for Atlantic hardware abstraction layer. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- .../aquantia/atlantic/hw_atl/hw_atl_utils.c

[PATCH v6 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions.

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add Atlantic A0 and B0 specific functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 905 +++

[PATCH v6 11/13] net: ethernet: aquantia: Ethtool support

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add the driver interfaces required for support by the ethtool utility. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- .../net/ethernet/aquantia/atlantic/a

[PATCH v6 07/13] net: ethernet: aquantia: Vector operations

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add functions to manululate the vector of receive and transmit rings. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel.Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlanti

[PATCH v6 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Modify the drivers/net/ethernet/{Makefile,Kconfig} file to make them a part of the network drivers build. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- d

[PATCH v6 10/13] net: ethernet: aquantia: Hardware interface and utility functions

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add functions to interface with the hardware and some utility functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atla

[PATCH v6 05/13] net: ethernet: aquantia: Support for NIC-specific code

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add support for code specific to the Atlantic NIC. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 273

[PATCH v6 12/13] net: ethernet: aquantia: Receive side scaling

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add definitions that support receive side scaling. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_rss.h | 26 +++

[PATCH v6 08/13] net: ethernet: aquantia: PCI operations

2017-01-18 Thread Alexander Loktionov
From: David VomLehn Add functions that handle the PCI bus interface. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- .../net/ethernet/aquantia/atlantic/aq_pci_func.c | 345 +

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Mickaël Salaün
On 19/01/2017 01:18, Andy Lutomirski wrote: >>> it explicitly respects the cgroup hierarchy. It shows up in >>> /proc/cgroups, and I had no problem mounting a cgroupfs instance with >>> perf_event enabled. So I'm not sure what you mean. >> >> That all it's doing is providing membership informati

RE: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-18 Thread YUAN Linyu
> -Original Message- > From: Zefir Kurtisi [mailto:zefir.kurt...@neratec.com] > > ... on the other hand, having direct RW access to MDIO regs can ease your life > greatly during bring-up / debugging of PHYs. > > Attached is a patch we are using to track down PHY problems at register lev

Re: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-18 Thread Andrew Lunn
> I will add two ethtool command in kernel to read and write register in PHY. Write access will get NACKed by me. Read only please. > ethtool can use these command to dump what user want, there is no > more work to PHY driver. Please think about how you handle PHYs with pages. This needs to be

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Tejun Heo
Hello, Andy. On Wed, Jan 18, 2017 at 04:18:04PM -0800, Andy Lutomirski wrote: > To map cgroup -> hook, a simple array in each cgroup structure works. > To map (cgroup, netns) -> hook function, the natural approach would be > to have some kind of hash, and that would be slower. This code is > inte

prb_retire_rx_blk_timer_expired use-after-free

2017-01-18 Thread Dave Jones
RSI looks kinda like slab poison here, so re-using a free'd ptr ? general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.10.0-rc4-think+ #2 task: 81e16500 task.stack: 81e0 RIP: 0010:prb_retire_rx_blk_timer_expired+0x42/0x130

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Andy Lutomirski
On Wed, Jan 18, 2017 at 2:41 PM, Tejun Heo wrote: > Helloo, Andy. > > On Mon, Jan 16, 2017 at 09:18:36PM -0800, Andy Lutomirski wrote: >> Perhaps this is a net feature, though, not a cgroup feature. This >> would IMO make a certain amount of sense. Iptables cgroup matches, >> for example, logica

[PATCH net-next v3] bridge: multicast to unicast

2017-01-18 Thread Linus Lüssing
Implements an optional, per bridge port flag and feature to deliver multicast packets to any host on the according port via unicast individually. This is done by copying the packet per host and changing the multicast destination MAC to a unicast one accordingly. multicast-to-unicast works on top o

sales--【充电站+新能源汽车展】 2017第八届中国(广州)国际新能源汽车工业展 (G-YD2-C50-Me)

2017-01-18 Thread eaebtqp
中华人民共和国商务部引导支持展会 国家级国际性汽车充电设备展贸平台   2017第八届中国(广州)国际新能源汽车工业展览会 (NEA 2017) The 8th Guangzhou International New Energy Automobiles Industry Expo 2017   2017第八届中国(广州)国际充电站技术装备展览会 (EVE 2017) The 8th Guangzhou International Electric Vehicle Supply Equipments Expo 2017     【 展 会 信 息 】   ■ 展览日期 2017年06月02—

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-18 Thread Arun Easi
This will be addressed in v2 of the series. The warning pops up when CONFIG_DCB is not set. Thanks. Regards, -Arun On Tue, 17 Jan 2017, 6:35am, kbuild test robot wrote: > Hi Arun, > > [auto build test WARNING on net-next/master] > [also build test WARNING on v4.10-rc4 next-20170117] > [if your

[PATCH next 0/3] use netdev_is_rx_handler_busy() in few known cases

2017-01-18 Thread Mahesh Bandewar
From: Mahesh Bandewar netdev_rx_handler_register() was recently split into two parts - (a) check if the handler is used, (b) register the new handler, parts. This is helpful in scenarios like bonding where at the time of registration there is too much state to unwind and it should check if the d

[PATCH next 3/3] macvlan: use netdev_is_rx_handler_busy instead of checking specific type

2017-01-18 Thread Mahesh Bandewar
From: Mahesh Bandewar netdev_is_rx_handler_busy() check is a superset of netif_is_ipvlan_port() check and hence should be preferred. Signed-off-by: Mahesh Bandewar --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/

[PATCH next 1/3] net: remove duplicate code.

2017-01-18 Thread Mahesh Bandewar
From: Mahesh Bandewar netdev_rx_handler_register() checks to see if the handler is already busy which was recently separated into netdev_is_rx_handler_busy(). So use the same function inside register() to avoid code duplication. Essentially this change should be a no-op Signed-off-by: Mahesh Ban

[PATCH next 2/3] ipvlan: use netdev_is_rx_handler_busy instead of checking specific type

2017-01-18 Thread Mahesh Bandewar
From: Mahesh Bandewar IPvlan checks if the master device is already used by checking a specific device (here it's macvlan device). This is technically not sufficient and it should just ensure the rx_handler is busy or not. This would be a super check that includes macvlan and any other that has a

Re: [PATCH v3 1/2] bpf: add a longest prefix match trie map implementation

2017-01-18 Thread Alexei Starovoitov
On Wed, Jan 18, 2017 at 03:30:14PM +0100, David Herrmann wrote: > Hi > > On Sat, Jan 14, 2017 at 5:55 PM, Alexei Starovoitov wrote: > > Another alternative is to extend samples/bpf/map_perf_test > > It has perf tests for most map types today (including lru) > > and trie would be natural addition

linux-next: build warning after merge of the net tree

2017-01-18 Thread Stephen Rothwell
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:546:6: warning: unused variable 'ncv' [-Wunused-

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Tejun Heo
Helloo, Andy. On Mon, Jan 16, 2017 at 09:18:36PM -0800, Andy Lutomirski wrote: > Perhaps this is a net feature, though, not a cgroup feature. This > would IMO make a certain amount of sense. Iptables cgroup matches, > for example, logically are an iptables (i.e., net) feature. The Yeap. > pro

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-18 Thread David Miller
From: David Miller Date: Wed, 18 Jan 2017 16:37:14 -0500 (EST) > From: Russell King - ARM Linux > Date: Wed, 18 Jan 2017 00:14:03 + > >> Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an >> unnecessary dependency for quite a large amount of the kernel. There's >> very l

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread David Miller
From: Tobias Klauser Date: Wed, 18 Jan 2017 17:45:01 +0100 > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()"). > > However, some dri

Re: [PATCH net] bpf: don't trigger OOM killer under pressure with map alloc

2017-01-18 Thread David Miller
From: Daniel Borkmann Date: Wed, 18 Jan 2017 15:14:17 +0100 > This patch adds two helpers, bpf_map_area_alloc() and bpf_map_area_free(), > that are to be used for map allocations. Using kmalloc() for very large > allocations can cause excessive work within the page allocator, so i) fall > back ea

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-18 Thread Tejun Heo
Hello, Michal. On Tue, Jan 17, 2017 at 02:58:30PM +0100, Michal Hocko wrote: > This would require using hierarchical cgroup iterators to iterate over It does behave hierarchically. > tasks. As per Andy's testing this doesn't seem to be the case. I haven't That's not what Andy's testing showed.

Re: [PATCH net-next] lwtunnel: remove device arg to lwtunnel_build_state

2017-01-18 Thread David Miller
From: David Ahern Date: Tue, 17 Jan 2017 15:08:41 -0800 > Nothing about lwt state requires a device reference, so remove the > input argument. > > Signed-off-by: David Ahern This is going to conflict with the module loading patch, why don't you respin this the next time I merge net into net-ne

Re: [PATCH net v2] lwtunnel: fix autoload of lwt modules

2017-01-18 Thread David Miller
From: David Ahern Date: Tue, 17 Jan 2017 14:57:36 -0800 > Trying to add an mpls encap route when the MPLS modules are not loaded > hangs. For example: ... > The problem is that lwtunnel_build_state is called with rtnl lock > held preventing mpls_init from registering. > > Given the potential re

Re: [PATCH net-next v4 00/10] net: dsa: Support for pdata in dsa2

2017-01-18 Thread Florian Fainelli
On 01/18/2017 01:50 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 17 Jan 2017 15:21:42 -0800 > >> This is not exactly new, and was sent before, although back then, I did not >> have an user of the pre-declared MDIO board information, but now we do. Note >> that I have additional c

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-18 Thread Russell King - ARM Linux
On Wed, Jan 18, 2017 at 04:37:14PM -0500, David Miller wrote: > From: Russell King - ARM Linux > Date: Wed, 18 Jan 2017 00:14:03 + > > > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > > unnecessary dependency for quite a large amount of the kernel. There's > > very l

Re: [PATCH net] bnxt_en: Fix "uninitialized variable" bug in TPA code path.

2017-01-18 Thread David Miller
From: Michael Chan Date: Tue, 17 Jan 2017 22:07:19 -0500 > In the TPA GRO code path, initialize the tcp_opt_len variable to 0 so > that it will be correct for packets without TCP timestamps. The bug > caused the SKB fields to be incorrectly set up for packets without > TCP timestamps, leading to

Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]

2017-01-18 Thread David Miller
From: Vivien Didelot Date: Tue, 17 Jan 2017 20:41:39 -0500 > Now that the DSA Ethernet switches are true Linux devices, the CPU > switch is not necessarily the first one. If its address is higher than > the second switch on the same MDIO bus, its index will be 1, not 0. > > Avoid any confusion b

Re: [PATCH net-next 1/2] net: dsa: store CPU switch structure in the tree

2017-01-18 Thread David Miller
From: Vivien Didelot Date: Tue, 17 Jan 2017 20:41:38 -0500 > Store a dsa_switch pointer to the CPU switch in the tree instead of only > its index. This avoids the need to initialize it to -1. > > Signed-off-by: Vivien Didelot Applied.

Re: fq_codel and skb->hash

2017-01-18 Thread Andrew Collins
On 01/17/2017 08:14 AM, Eric Dumazet wrote: Right, but that might add overhead in cases we do not need skb->hash after IPsec . I've heard IPsec is already quite slow :/ I've been running with the following change locally with good results: --- a/net/sched/sch_fq_codel.c +++ b/net/sched/sch_fq_

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-18 Thread David Miller
From: Russell King - ARM Linux Date: Wed, 18 Jan 2017 00:14:03 + > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the

Re: [PATCH net] net: phy: bcm63xx: Utilize correct config_intr function

2017-01-18 Thread David Miller
From: Florian Fainelli Date: Tue, 17 Jan 2017 16:26:55 -0800 > From: Daniel Gonzalez Cabanelas > > Commit a1cba5613edf ("net: phy: Add Broadcom phy library for common > interfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr() > which would appear to do the right thing, except that

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-18 Thread David Miller
From: Russell King - ARM Linux Date: Wed, 18 Jan 2017 21:46:28 + > On Wed, Jan 18, 2017 at 04:37:14PM -0500, David Miller wrote: >> From: Russell King - ARM Linux >> Date: Wed, 18 Jan 2017 00:14:03 + >> >> > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an >> > unne

Re: [PATCH net-next v4 00/10] net: dsa: Support for pdata in dsa2

2017-01-18 Thread David Miller
From: Florian Fainelli Date: Tue, 17 Jan 2017 15:21:42 -0800 > This is not exactly new, and was sent before, although back then, I did not > have an user of the pre-declared MDIO board information, but now we do. Note > that I have additional changes queued up to have b53 register platform data

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-18 Thread Bart Van Assche
On 01/18/2017 10:31 AM, Jason Gunthorpe wrote: > I think it depends on what this tool is supposed to cover, but based > on the description, I would start with netlink-only. > > The only place verbs covers a similar ground is in 'device > capabilities' - for some of that you might want to open a ne

[PATCH] net: qcom/emac: claim the irq only when the device is opened

2017-01-18 Thread Timur Tabi
During reset, functions emac_mac_down() and emac_mac_up() are called, so we don't want to free and claim the IRQ unnecessarily. Move those operations to open/close. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 14 -- drivers/net/ethernet/qualcomm/ema

Re: [PATCH] net: ethernet: ti: davinci_cpdma: correct check on NULL in set rate

2017-01-18 Thread David Miller
From: Ivan Khoronzhuk Date: Wed, 18 Jan 2017 02:28:06 +0200 > Check "ch" on NULL first, then get ctlr. > > Signed-off-by: Ivan Khoronzhuk Applied, thanks.

Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 14:04 -0700, Andrew Collins wrote: > The fq_codel qdisc currently always regenerates the skb flow hash. > This wastes some cycles and prevents flow seperation in cases where > the traffic has been encrypted and can no longer be understood by the > flow dissector. > > Change i

Re: [PATCH net-next V5 0/3] vhost_net tx batching

2017-01-18 Thread David Miller
From: Jason Wang Date: Wed, 18 Jan 2017 15:02:00 +0800 > This series tries to implement tx batching support for vhost. This was > done by using MSG_MORE as a hint for under layer socket. The backend > (e.g tap) can then batch the packets temporarily in a list and > submit it all once the number o

Re: [PATCH v3 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering

2017-01-18 Thread David Miller
From: Mao Wenan Date: Wed, 18 Jan 2017 08:50:05 +0800 > Relax ordering(RO) is one feature of 82599 NIC, to enable this feature can > enhance the performance for some cpu architecure, such as SPARC and so on. > Currently it only supports one special cpu architecture(SPARC) in 82599 > driver to ena

Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-18 Thread David Miller
From: Sainath Grandhi Date: Tue, 17 Jan 2017 16:03:06 -0800 > +static void ipvtap_count_tx_dropped(struct tap_dev *tap) > +{ > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct > ipvtap_dev, tap); ... > +static void ipvtap_count_rx_dropped(struct tap_dev *tap) > +{ > +

Re: [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation

2017-01-18 Thread David Miller
From: Sainath Grandhi Date: Tue, 17 Jan 2017 16:03:03 -0800 > @@ -46,22 +51,52 @@ static struct cdev macvtap_cdev; > #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \ > NETIF_F_TSO6 | NETIF_F_UFO) > > +static void macvtap_count_tx_dropped(struct tap_

Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API

2017-01-18 Thread David Miller
From: Sainath Grandhi Date: Tue, 17 Jan 2017 16:03:02 -0800 > +int tap_create_cdev(struct cdev *tap_cdev, > + dev_t *tap_major, const char *device_name) > +{ > + int err; > + > + err = alloc_chrdev_region(tap_major, 0, TAP_NUM_DEVS, device_name); > + > + if (err) > +

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-18 Thread David Miller
From: Vineeth Remanan Pillai Date: Wed, 18 Jan 2017 09:02:17 -0800 > > On 01/15/2017 10:24 PM, Juergen Gross wrote: >> On 13/01/17 18:55, Remanan Pillai wrote: >>> From: Vineeth Remanan Pillai >>> >>> During an OOM scenario, request slots could not be created as skb >>> allocation fails. So the

Re: [PATCH net-next 0/2] net: ipv6: simplify rt6_fill_node

2017-01-18 Thread David Miller
From: David Ahern Date: Tue, 17 Jan 2017 15:51:06 -0800 > Remove a couple of unnecessary input arguments to rt6_fill_node. Looks good, series applied, thanks.

[PATCH net-next] csum: eliminate sparse warning in remcsum_unadjust()

2017-01-18 Thread Lance Richardson
Cast second parameter of csum_sub() from __sum16 to __wsum. Signed-off-by: Lance Richardson --- include/net/checksum.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/checksum.h b/include/net/checksum.h index 35d0fab..aef2b2b 100644 --- a/include/net/checksum.h ++

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-18 Thread Leon Romanovsky
On Wed, Jan 18, 2017 at 07:50:26PM +0200, Or Gerlitz wrote: > On Wed, Jan 18, 2017 at 7:33 PM, Leon Romanovsky wrote: > > On Wed, Jan 18, 2017 at 06:48:21PM +0200, Or Gerlitz wrote: > >> On Wed, Jan 18, 2017 at 5:19 PM, Ariel Almog > >> wrote: > > >>> As of today, there is no single, simple, tool

[PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary

2017-01-18 Thread Andrew Collins
The fq_codel qdisc currently always regenerates the skb flow hash. This wastes some cycles and prevents flow seperation in cases where the traffic has been encrypted and can no longer be understood by the flow dissector. Change it to use the prexisting flow hash if one exists, and only regenerate

Re: [PATCH v3] audit: log 32-bit socketcalls

2017-01-18 Thread Paul Moore
On Tue, Jan 17, 2017 at 11:07 AM, Richard Guy Briggs wrote: > 32-bit socketcalls were not being logged by audit on x86_64 systems. > Log them. This is basically a duplicate of the call from > net/socket.c:sys_socketcall(), but it addresses the impedance mismatch > between 32-bit userspace process

Re: resend: tcp: performance issue with fastopen connections (mss > window)

2017-01-18 Thread Neal Cardwell
On Wed, Jan 18, 2017 at 1:16 PM, Eric Dumazet wrote: > > On Wed, Jan 18, 2017 at 10:13 AM, Yuchung Cheng wrote: > > On Wed, Jan 18, 2017 at 9:35 AM, Eric Dumazet wrote: > >> > >> On Wed, Jan 18, 2017 at 9:32 AM, Alexey Kodanev > >> wrote: > >> > Hi Eric, > >> > > >> > On 01/13/2017 08:07 PM, Al

Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]

2017-01-18 Thread Florian Fainelli
On 01/18/2017 04:50 AM, Andrew Lunn wrote: > On Tue, Jan 17, 2017 at 08:41:39PM -0500, Vivien Didelot wrote: >> Now that the DSA Ethernet switches are true Linux devices, the CPU >> switch is not necessarily the first one. If its address is higher than >> the second switch on the same MDIO bus, its

Re: [PATCH net-next 1/2] net: dsa: store CPU switch structure in the tree

2017-01-18 Thread Florian Fainelli
On 01/17/2017 05:41 PM, Vivien Didelot wrote: > Store a dsa_switch pointer to the CPU switch in the tree instead of only > its index. This avoids the need to initialize it to -1. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net] net: fix harmonize_features() vs NETIF_F_HIGHDMA

2017-01-18 Thread David Miller
From: Eric Dumazet Date: Wed, 18 Jan 2017 12:12:17 -0800 > From: Eric Dumazet > > Ashizuka reported a highmem oddity and sent a patch for freescale > fec driver. > > But the problem root cause is that core networking stack > must ensure no skb with highmem fragment is ever sent through > a dev

Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]

2017-01-18 Thread Florian Fainelli
On 01/17/2017 05:41 PM, Vivien Didelot wrote: > Now that the DSA Ethernet switches are true Linux devices, the CPU > switch is not necessarily the first one. If its address is higher than > the second switch on the same MDIO bus, its index will be 1, not 0. > > Avoid any confusion by using dst->cp

RE: [PATCH iproute2] Revert "man pages: add man page for skbmod action"

2017-01-18 Thread Rosen, Rami
Acked-by: Rami Rosen -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jiri Benc Sent: Wednesday, January 18, 2017 14:37 To: netdev@vger.kernel.org Cc: Lucas Bates ; Jamal Hadi Salim ; Stephen Hemminger Subject: [PATCH iproute2] Re

[PATCH net-next] vxlan: preserve type of dst_port parm for encap_bypass_if_local()

2017-01-18 Thread Lance Richardson
Eliminate sparse warning by maintaining type of dst_port as __be16. Signed-off-by: Lance Richardson --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index ca7196c..19b1653 100644 --- a/drivers/net/vxlan.c +++ b/

Re: fq_codel and skb->hash

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 13:21 -0700, Andrew Collins wrote: > > Any interest in me spinning a real patch for this? I agree that it'd be > better > if we were guaranteed to get a pre-encryption flow hash for any IPsec traffic, > but in my particular case I don't care, as I control the HW and can ma

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-18 Thread Vineeth Remanan Pillai
On 01/18/2017 12:10 PM, David Miller wrote: This v2 never made it into patchwork. I don't know why, so please resend it to netdev with the accumulated reviewed-by etc. tags added. Thanks. Sorry about that. Will resend as a separate thread right away. Thanks

Re: [PATCH v2 0/2] xen-netback: fix memory leaks on XenBus disconnect

2017-01-18 Thread David Miller
From: Igor Druzhinin Date: Tue, 17 Jan 2017 20:49:36 + > Just split the initial patch in two as proposed by Wei. > > Since the approach for locking netdev statistics is inconsistent (tends not > to have any locking at all) accross the kernel we'd better to rely on our > internal lock for thi

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 10:18 -0800, Pravin Shelar wrote: \ > Right, this high mem check should be decoupled from csum check. I must say I am surprised nobody hit this problem before today. linux-3.10 is more than 3 years old.

[PATCH net] net: fix harmonize_features() vs NETIF_F_HIGHDMA

2017-01-18 Thread Eric Dumazet
From: Eric Dumazet Ashizuka reported a highmem oddity and sent a patch for freescale fec driver. But the problem root cause is that core networking stack must ensure no skb with highmem fragment is ever sent through a device that does not assert NETIF_F_HIGHDMA in its features. We need to call

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-18 Thread David Miller
This v2 never made it into patchwork. I don't know why, so please resend it to netdev with the accumulated reviewed-by etc. tags added. Thanks.

Re: [PATCH net 0/3] ethtool fix

2017-01-18 Thread David Miller
From: Tariq Toukan Date: Tue, 17 Jan 2017 19:19:16 +0200 > This patchset from Eran contains a fix to ethtool set_channels, where the call > to get_channels with an uninitialized parameter might result in garbage > fields. > It also contains two followup changes in our mlx4/mlx5 Eth drivers. > >

Re: [PATCH] netfilter: ipt_CLUSTERIP: fix build error without procfs

2017-01-18 Thread Pablo Neira Ayuso
On Fri, Jan 13, 2017 at 04:41:03PM +0100, Arnd Bergmann wrote: > We can't access c->pde if CONFIG_PROC_FS is disabled: > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_config_find_get': > net/ipv4/netfilter/ipt_CLUSTERIP.c:147:9: error: 'struct clusterip_config' > has no member name

Re: [PATCHv4 net-next 0/6] sctp: add sender-side procedures for stream reconf ssn reset request chunk

2017-01-18 Thread David Miller
From: Xin Long Date: Wed, 18 Jan 2017 00:44:41 +0800 > Patch 6/6 is to implement sender-side procedures for the Outgoing > and Incoming SSN Reset Request Parameter described in rfc6525 > section 5.1.2 and 5.1.3 > > Patches 1-5/6 are ahead of it to define some apis and asoc members > for it. > >

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-18 Thread Konrad Rzeszutek Wilk
On Wed, Jan 18, 2017 at 10:31:32AM -0500, Sowmini Varadhan wrote: > As I was playing around with pf_packet, I accidentally wrote > a buggy application program that bzero'ed the msghdr, then set > up the msg_name, msg_namelen correctly, and then did a sendmsg > on the pf_packet/SOCK_RAW fd. > > Thi

Re: Initializing MAC address at run-time

2017-01-18 Thread Uwe Kleine-König
Hello, On Wed, Jan 18, 2017 at 03:03:57PM +0100, Mason wrote: > When my system boots up, eth0 is given a seemingly random MAC address. > > [0.950734] nb8800 26000.ethernet eth0: MAC address ba:de:d6:38:b8:38 > [0.957334] nb8800 26000.ethernet eth0: MAC address 6e:f1:48:de:d6:c4 > > > Th

[net-next 2/4] tipc: add functionality to lookup multicast destination nodes

2017-01-18 Thread Jon Maloy
As a further preparation for the upcoming 'replicast' functionality, we add some necessary structs and functions for looking up and returning a list of all nodes that host destinations for a given multicast message. Reviewed-by: Parthasarathy Bhuvaragan Acked-by: Ying Xue Signed-off-by: Jon Malo

[net-next 0/4] tipc: emulate multicast through replication

2017-01-18 Thread Jon Maloy
TIPC multicast messages are currently distributed via L2 broadcast or IP multicast to all nodes in the cluster, irrespective of the number of real destinations of the message. In this series we introduce an option to transport messages via replication ("replicast") across a selected number of unic

[net-next 1/4] tipc: add function for checking broadcast support in bearer

2017-01-18 Thread Jon Maloy
As a preparation for the 'replicast' functionality we are going to introduce in the next commits, we need the broadcast base structure to store whether bearer broadcast is available at all from the currently used bearer or bearers. We do this by adding a new function tipc_bearer_bcast_support() to

  1   2   3   >