Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr()

2016-12-31 Thread Lorenzo Colitti
On Sat, Dec 31, 2016 at 8:42 AM, Eric Biggers wrote: > ->setattr() was recently implemented for socket files to sync the socket > inode's uid to the new 'sk_uid' member of struct sock. It does this by > copying over the ia_uid member of struct iattr. However, ia_uid is > actually only valid when

Re: [PATCH] drop_monitor: add missing call to genlmsg_end

2016-12-31 Thread Neil Horman
On Sat, Dec 31, 2016 at 09:11:57PM +0100, Reiter Wolfgang wrote: > Update nlmsg_len field with genlmsg_end to enable userspace processing > using nlmsg_next helper. Also adds error handling. > > Signed-off-by: Reiter Wolfgang > --- > net/core/drop_monitor.c | 33 -

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-12-31 Thread Ansis Atteka
On Wed, Nov 30, 2016 at 3:58 AM, Hayes Wang wrote: > Mark Lord > [...] >> > Not sure why, because there really is no other way for the data to >> > appear where it does at the beginning of that URB buffer. >> > >> > This does seem a rather unexpected burden to place upon someone >> > reporting a

Re: [PATCH v1 0/2] bpf: add longest prefix match map

2016-12-31 Thread Alexei Starovoitov
On Fri, Dec 30, 2016 at 12:25 PM, David Miller wrote: > From: Daniel Mack > Date: Thu, 29 Dec 2016 18:28:53 +0100 > >> This patch set adds a longest prefix match algorithm that can be used >> to match IP addresses to a stored set of ranges. It is exposed as a >> bpf map type. >> >> Internally, da

Re: [PATCH net-next V3 3/3] tun: rx batching

2016-12-31 Thread Stephen Hemminger
On Fri, 30 Dec 2016 13:20:51 +0800 Jason Wang wrote: > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index cd8e02c..a268ed9 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -75,6 +75,10 @@ > > #include > > +static int rx_batched; > +module_param(rx_batched, int, 0444);

Re: [PATCH] Introduce a sysctl that modifies the value of PROT_SOCK.

2016-12-31 Thread Stephen Hemminger
On Fri, 30 Dec 2016 20:11:11 -0800 Krister Johansen wrote: > > +config LOWPORT_SYSCTL > + bool "Adjust reserved port range via sysctl" > + depends on SYSCTL > + help > + This allows the administrator to adjust the reserved port range > + using a sysctl. This looks like

Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.

2016-12-31 Thread Arnd Bergmann
On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote: > > On 12/29/2016 11:37 PM, Greentime Hu wrote: > > Signed-off-by: Greentime Hu > > This is not enough, you need to add a Device Tree binding document under > Documentation/devicetree/bindings/net/ which documents this compat

Re: Bug w/ (policy) routing

2016-12-31 Thread David Ahern
On 12/30/16 4:00 PM, Olivier Brunel wrote: > Hi, > > (Please cc me as I'm not subscribed to the list, thanks.) > > I'm trying to set things up using some policy routing, and having some > weird issues I can't really explain. It looks to me like there might be > a bug somewhere... > > This is don

[PATCH] drop_monitor: add missing call to genlmsg_end

2016-12-31 Thread Reiter Wolfgang
Update nlmsg_len field with genlmsg_end to enable userspace processing using nlmsg_next helper. Also adds error handling. Signed-off-by: Reiter Wolfgang --- net/core/drop_monitor.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/net/core/dro

Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.

2016-12-31 Thread Florian Fainelli
On 12/29/2016 11:37 PM, Greentime Hu wrote: > Signed-off-by: Greentime Hu This is not enough, you need to add a Device Tree binding document under Documentation/devicetree/bindings/net/ which documents this compatible string, as well as additional properties that may be required to describe thi

Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr()

2016-12-31 Thread David Miller
From: Eric Biggers Date: Fri, 30 Dec 2016 17:42:32 -0600 > From: Eric Biggers > > ->setattr() was recently implemented for socket files to sync the socket > inode's uid to the new 'sk_uid' member of struct sock. It does this by > copying over the ia_uid member of struct iattr. However, ia_uid

Re: [PATCH net-next V3 3/3] tun: rx batching

2016-12-31 Thread David Miller
From: Jason Wang Date: Fri, 30 Dec 2016 13:20:51 +0800 > @@ -1283,10 +1314,15 @@ static ssize_t tun_get_user(struct tun_struct *tun, > struct tun_file *tfile, > skb_probe_transport_header(skb, 0); > > rxhash = skb_get_hash(skb); > + > #ifndef CONFIG_4KSTACKS > - local_bh_disab

Re: [PATCH net-next] af_packet: Provide a TPACKET_V2 compatible Tx path for TPACKET_V3

2016-12-31 Thread Sowmini Varadhan
On (12/30/16 23:59), Willem de Bruijn wrote: > > Actually I'm not averse to looking at extensions (or at least, > > place-holders) to allow variable sized slots- do you have any > > suggestions? > > It is probably enough to just enforce that tp_next_offset is always > sane. Either that it points t

ping: What's the purpose of rate limit?

2016-12-31 Thread Guan Xin
Hello, Excuse me, I searched but didn't find an answer -- What's the purpose of setting a limit to the "-i" and "-l" parameters of ping for non-root users? It seems that this is only intended to prevent accidental misuse because these restrictions can be easily worked around by starting multiple