Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-26 Thread Roi Dayan
On 27/11/2016 06:47, Roi Dayan wrote: On 27/11/2016 02:33, Daniel Borkmann wrote: On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: [...] Ok, strange, qdisc_destroy() calls into ops->destroy(),

Re: Crash due to mutex genl_lock called from RCU context

2016-11-26 Thread Cong Wang
On Sat, Nov 26, 2016 at 6:26 PM, Eric Dumazet wrote: > > Are you telling me inet_release() is called when we close() the first > file descriptor ? > > fd1 = socket() > fd2 = dup(fd1); > close(fd2) -> release() ??? Sorry, I didn't express myself clearly, I meant your change, if exclude the SOCK_RC

RE: [PATCH] net: fec: turn on device when extracting statistics

2016-11-26 Thread Andy Duan
From: Nikita Yushchenko Sent: Friday, November 25, 2016 6:02 PM >To: Andy Duan ; David S. Miller >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe >Reynes ; Johannes Berg ; >netdev@vger.kernel.org; linux-ker...@vger.kernel.org >Cc: Chris Healy ; Nikita Yushchenko > >Subject: [PATCH] n

Xmas Offer

2016-11-26 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact ( julieleac...@gmail.com ) for claims.

[PATCH net-next 2/4] Documentation: net: phy: Add a paragraph about pause frames/flow control

2016-11-26 Thread Florian Fainelli
Describe that the Ethernet MAC controller is ultimately responsible for dealing with proper pause frames/flow control advertisement and enabling, and that it is therefore allowed to have it change phydev->supported/advertising with SUPPORTED_Pause and SUPPORTED_AsymPause. Signed-off-by: Florian Fa

[PATCH net-next 3/4] Documentation: net: phy: Add blurb about RGMII

2016-11-26 Thread Florian Fainelli
RGMII is a recurring source of pain for people with Gigabit Ethernet hardware since it may require PHY driver and MAC driver level configuration hints. Document what are the expectations from PHYLIB and what options exist. Signed-off-by: Florian Fainelli --- Documentation/networking/phy.txt | 56

[PATCH net-next 0/4] Documentation: net: phy: Improve documentation

2016-11-26 Thread Florian Fainelli
Hi all, This patch series addresses discussions and feedback that was recently received on the mailing-list in the area of: flow control/pause frames, interpretation of phy_interface_t and finally add some links to useful standards documents. Florian Fainelli (4): Documentation: net: phy: remov

[PATCH net-next 1/4] Documentation: net: phy: remove description of function pointers

2016-11-26 Thread Florian Fainelli
Remove the function pointers documentation which duplicates information found in include/linux/phy.h. Maintaining documentation about two different locations just does not work, but the code is less likely to be outdated. Signed-off-by: Florian Fainelli --- Documentation/networking/phy.txt | 35

[PATCH net-next 4/4] Documentation: net: phy: Add links to several standards documents

2016-11-26 Thread Florian Fainelli
Add links to the IEEE 802.3-2008 document, and the RGMII v1.3 and v2.0 revisions of the standard. Signed-off-by: Florian Fainelli --- Documentation/networking/phy.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/networking/phy.txt b/Documentation/networking/phy.t

Re: [PATCH 2/2] net: phy: realtek: fix enabling of the TX-delay for RTL8211F

2016-11-26 Thread Florian Fainelli
On 11/25/2016 05:12 AM, Martin Blumenstingl wrote: > The old logic always enabled the TX-delay when the phy-mode was set to > PHY_INTERFACE_MODE_RGMII. There are dedicated phy-modes which tell the > PHY driver to enable the RX and/or TX delays: > - PHY_INTERFACE_MODE_RGMII should disable the RX a

Re: [PATCH 1/2] Documentation: devicetree: clarify usage of the RGMII phy-modes

2016-11-26 Thread Florian Fainelli
On 11/25/2016 05:12 AM, Martin Blumenstingl wrote: > RGMII requires special RX and/or TX delays depending on the actual > hardware circuit/wiring. These delays can be added by the MAC, the PHY > or the designer of the circuit (the latter means that no delay has to > be added by PHY or MAC). > The

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-26 Thread Roi Dayan
On 27/11/2016 02:33, Daniel Borkmann wrote: On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: [...] Ok, strange, qdisc_destroy() calls into ops->destroy(), where ingress drops its entire chain via

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Sven-Haegar, On Fri, 25 Nov 2016 05:06:53 +0100 (CET) Sven-Haegar Koch wrote: > > Somehow this problem description really reminds me of a report on > netdev a bit ago, which the following patch fixed: > > commit 9ee6c5dc816aa8256257f2cd4008a9291ec7e985 > Author: Lance Richardson > Date:

ip manpage comments

2016-11-26 Thread Jon LaBadie
Though not new to *nix, I am new to using the ip(8) command. Thus some of my historical assumptions about ip may be wrong. It seems that an inclusive manpage for the ip command was broken up into a shorter ip(8) manpage and 15 or more ip-(8) manpages. I'm basing this assumption on long, inclusive

Re: Crash due to mutex genl_lock called from RCU context

2016-11-26 Thread Eric Dumazet
On Sat, 2016-11-26 at 18:08 -0800, Cong Wang wrote: > On Fri, Nov 25, 2016 at 8:54 PM, Eric Dumazet wrote: > > > > Oh well, this wont work, since sk->sk_destruct will be called from RCU > > callback. > > > > Grabbing the mutex should not be done from netlink_sock_destruct() but > > from netlink_re

Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-26 Thread Eric Dumazet
On Sun, 2016-11-27 at 00:47 +0200, Saeed Mahameed wrote: > On Fri, Nov 25, 2016 at 5:46 PM, Eric Dumazet wrote: > As you see here in SRIOV mode (PF only) reads sw stats from FW. > Tariq, I think we need to fix this. Sure, my patch does not change this at all. If mlx4_is_master() is false, the

Re: Crash due to mutex genl_lock called from RCU context

2016-11-26 Thread Cong Wang
On Fri, Nov 25, 2016 at 8:54 PM, Eric Dumazet wrote: > > Oh well, this wont work, since sk->sk_destruct will be called from RCU > callback. > > Grabbing the mutex should not be done from netlink_sock_destruct() but > from netlink_release() But you also change the behavior of cb.done(), currently

Re: [PATCH net-next 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

2016-11-26 Thread kbuild test robot
Hi Francis, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yuchung-Cheng/tcp-sender-chronographs-instrumentation/20161127-041428 config: arm-spear6xx_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 repro

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

2016-11-26 Thread Stephen Rothwell
Hi Eli, [Just for Dave's information] On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote: > > Similar to commit ae148b085876 > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"), > sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets > might not be properl

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Eli, On Sun, 27 Nov 2016 11:54:41 +1100 Stephen Rothwell wrote: > > On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: > > > > I think this is similar to the bug I fixed in commit ae148b085876 > > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"). > > > > I can reproduc

Re: netlink: GPF in sock_sndtimeo

2016-11-26 Thread Cong Wang
On Sat, Nov 26, 2016 at 7:44 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in sock_sndtimeo: > https://gist.githubusercontent.com/dvyukov/c19cadd309791cf5cb9b2bf936d3f48d/raw/1743ba0211079a5465d039512b427bc6b59b1a76/gistfile1.txt > > On commit 16ae16c6e5616c084168740990f

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
Hi Rami, On 26.11.2016 16:48, Rami Rosen wrote: >> @@ -0,0 +1,28 @@ >> +config NET_VENDOR_ALACRITECH >> +bool "Alacritech devices" >> +default y >> +---help--- >> + If you have a network (Ethernet) card belonging to this class, >> say Y. >> + >> + Note

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Eli, On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: > > I think this is similar to the bug I fixed in commit ae148b085876 > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"). > > I can reproduce a similar problem by applying xfrm to sit traffic. > TSO/GSO packets are

[PATCH net-next 4/4] bnxt_en: Add PFC statistics.

2016-11-26 Thread Michael Chan
Report PFC statistics to ethtool -S and DCBNL. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 23 --- 3

[PATCH net-next 0/4] bnxt_en: Add DCBNL support.

2016-11-26 Thread Michael Chan
This series adds DCBNL operations to support host-based IEEE DCBX. Michael Chan (4): bnxt_en: Re-factor bnxt_setup_tc(). bnxt_en: Update firmware header file to include DCB command structs. bnxt_en: Implement DCBNL to support host-based DCBX. bnxt_en: Add PFC statistics. drivers/net/ethe

[PATCH net-next 2/4] bnxt_en: Update firmware header file to include DCB command structs.

2016-11-26 Thread Michael Chan
Get and store the max number of lossless TCs the hardware can support. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 326 ++ 3 f

[PATCH net-next 3/4] bnxt_en: Implement DCBNL to support host-based DCBX.

2016-11-26 Thread Michael Chan
Support only IEEE DCBX initially. Add IEEE DCBNL ops and functions to get and set the hardware DCBX parameters. The DCB code is conditional on Kconfig CONFIG_BNXT_DCB. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 10 + drivers/net/ethernet/broadcom/bnxt/Make

[PATCH net-next 1/4] bnxt_en: Re-factor bnxt_setup_tc().

2016-11-26 Thread Michael Chan
Add a new function bnxt_setup_mq_tc() to handle MQPRIO. This new function will be called during ETS setup when we add DCBNL in the next patch. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 f

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-26 Thread Daniel Borkmann
On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: [...] Ok, strange, qdisc_destroy() calls into ops->destroy(), where ingress drops its entire chain via tcf_destroy_chain(), so that will be NULL even

[PATCH net] net, sched: respect rcu grace period on cls destruction

2016-11-26 Thread Daniel Borkmann
Roi reported a crash in flower where tp->root was NULL in ->classify() callbacks. Reason is that in ->destroy() tp->root is set to NULL via RCU_INIT_POINTER(). It's problematic for some of the classifiers, because this doesn't respect RCU grace period for them, and as a result, still outstanding re

Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-26 Thread Saeed Mahameed
On Fri, Nov 25, 2016 at 5:46 PM, Eric Dumazet wrote: > From: Eric Dumazet > > mlx4 stats are chaotic because a deferred work queue is responsible > to update them every 250 ms. > Hello Eric, Well the only historical reason for this deferred work is that we query FW for some counters which might

Re: [PATCH 1/1] NET: usb: cdc_ncm: adding MBIM RESET_FUNCTION request and modifying ncm bind common code

2016-11-26 Thread Bjørn Mork
Bjørn Mork writes: > Finally, I found my modems (or at least a number of them) again today. > But I'm sorry to say, that the troublesome Huawei E3372h-153 is still > giving us a hard time. It does not work with your patch. The symptom is > the same as earlier: The modem returns MBIM frames with

[GIT] Networking

2016-11-26 Thread David Miller
1) Fix leak in fsl/fman driver, from Dan Carpenter. 2) Call flow dissector initcall earlier than any networking driver can register and start to use it, from Eric Dumazet. 3) Some dup header fixes from Geliang Tang. 4) TIPC link monitoring compat fix from Jon Paul Maloy. 5) Link changes req

[PATCH] amd-xgbe: Fix unused suspend handlers build warning

2016-11-26 Thread Borislav Petkov
From: Borislav Petkov Fix: drivers/net/ethernet/amd/xgbe/xgbe-main.c:835:12: warning: ‘xgbe_suspend’ defined but not used [-Wunused-function] drivers/net/ethernet/amd/xgbe/xgbe-main.c:855:12: warning: ‘xgbe_resume’ defined but not used [-Wunused-function] I see it during randconfi

Re: net: GPF in eth_header

2016-11-26 Thread Eric Dumazet
2016-11-26 12:05 GMT-08:00 Eric Dumazet : >> Hi Eric, >> >> The crash happens when the kernel tries to access shadow for nonmapped >> memory. >> >> The issue here is an integer overflow which happens in >> neigh_resolve_output(). >> skb_network_offset(skb) can return negative number, but __skb_pu

Re: [PATCH 1/1] NET: usb: cdc_ncm: adding MBIM RESET_FUNCTION request and modifying ncm bind common code

2016-11-26 Thread Bjørn Mork
Finally, I found my modems (or at least a number of them) again today. But I'm sorry to say, that the troublesome Huawei E3372h-153 is still giving us a hard time. It does not work with your patch. The symptom is the same as earlier: The modem returns MBIM frames with 32bit headers. So for now,

[PATCH net-next 4/6] tcp: instrument how long TCP is limited by insufficient send buffer

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch measures the amount of time when TCP runs out of new data to send to the network due to insufficient send buffer, while TCP is still busy delivering (i.e. write queue is not empty). The goal is to indicate either the send buffer autotuning or user SO_SNDBUF setting ha

[PATCH net-next 5/6] tcp: export sender limits chronographs to TCP_INFO

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch exports all the sender chronograph measurements collected in the previous patches to TCP_INFO interface. Note that busy time exported includes all the other sending limits (rwnd-limited, sndbuf-limited). Internally the time unit is jiffy but externally the measurement

[PATCH net-next 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch exports the sender chronograph stats via the socket SO_TIMESTAMPING channel. Currently we can instrument how long a particular application unit of data was queued in TCP by tracking SOF_TIMESTAMPING_TX_SOFTWARE and SOF_TIMESTAMPING_TX_SCHED. Having these sender chrono

[PATCH net-next 1/6] tcp: instrument tcp sender limits chronographs

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch implements the skeleton of the TCP chronograph instrumentation on sender side limits: 1) idle (unspec) 2) busy sending data other than 3-4 below 3) rwnd-limited 4) sndbuf-limited The limits are enumerated 'tcp_chrono'. Since a connect

[PATCH net-next 0/6] tcp: sender chronographs instrumentation

2016-11-26 Thread Yuchung Cheng
This patch set provides instrumentation on TCP sender limitations. While developing the BBR congestion control, we noticed that TCP sending process is often limited by factors unrelated to congestion control: insufficient sender buffer and/or insufficient receive window/buffer to saturate the netwo

[PATCH net-next 2/6] tcp: instrument how long TCP is busy sending

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch measures TCP busy time, which is defined as the period of time when sender has data (or FIN) to send. The time starts when data is buffered and stops when the write queue is flushed by ACKs or error events. Note the busy time does not include SYN time, unless data is

[PATCH net-next 3/6] tcp: instrument how long TCP is limited by receive window

2016-11-26 Thread Yuchung Cheng
From: Francis Yan This patch measures the total time when the TCP stops sending because the receiver's advertised window is not large enough. Note that once the limit is lifted we are likely in the busy status if we have data pending. Signed-off-by: Francis Yan Signed-off-by: Yuchung Cheng Sig

Re: net: GPF in eth_header

2016-11-26 Thread Eric Dumazet
> Hi Eric, > > The crash happens when the kernel tries to access shadow for nonmapped memory. > > The issue here is an integer overflow which happens in neigh_resolve_output(). > skb_network_offset(skb) can return negative number, but __skb_pull() > accepts unsigned int as len. > As a result, the l

unsuscribe

2016-11-26 Thread seba
unsuscribe

Re: net: stmmac: Meson GXBB: attempting to execute userspace memory

2016-11-26 Thread Ben Dooks
On 2016-11-26 07:53, Heinrich Schuchardt wrote: For Odroid C2 I have compiled kernel 4.9.0-rc6-next-20161124-1-gbf7e142 with one additional patch https://github.com/xypron/kernel-odroid-c2/blob/master/patch/0001-stmmac-RTL8211F-Meson-GXBB-TX-throughput-problems.patch I repeatedly see fault

Re: net: GPF in eth_header

2016-11-26 Thread Andrey Konovalov
On Sat, Nov 26, 2016 at 7:28 PM, 'Eric Dumazet' via syzkaller wrote: > On Sat, Nov 26, 2016 at 9:30 AM, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers GPF in eth_header: >> >> https://gist.githubusercontent.com/dvyukov/613cadf05543b55a419f237e419cd495/raw/5471231523d1a07c3de5

Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include

2016-11-26 Thread Rami Rosen
Acked-by: Rami Rosen On 26 November 2016 at 09:23, Alexei Starovoitov wrote: > this #include is unnecessary and brings whole set of > other headers into cgroup-defs.h. Remove it. > > Fixes: 3007098494be ("cgroup: add support for eBPF programs") > Signed-off-by: Alexei Starovoitov > --- > inclu

Re: net: GPF in eth_header

2016-11-26 Thread Eric Dumazet
On Sat, Nov 26, 2016 at 9:30 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in eth_header: > > https://gist.githubusercontent.com/dvyukov/613cadf05543b55a419f237e419cd495/raw/5471231523d1a07c3de55f11f87472c2816ee06c/gistfile1.txt > > On commit 16ae16c6e5616c084168740990fc

net: BUG in unix_notinflight

2016-11-26 Thread Dmitry Vyukov
Hello, I am hitting the following BUG while running syzkaller fuzzer: kernel BUG at net/unix/garbage.c:149! invalid opcode: [#1] SMP DEBUG_PAGEALLOC KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 23491 Comm: syz-executor Not tainted 4.9.0-rc5+ #41 Hardwa

net: GPF in eth_header

2016-11-26 Thread Dmitry Vyukov
Hello, The following program triggers GPF in eth_header: https://gist.githubusercontent.com/dvyukov/613cadf05543b55a419f237e419cd495/raw/5471231523d1a07c3de55f11f87472c2816ee06c/gistfile1.txt On commit 16ae16c6e5616c084168740990fc508bda6655d4 (Nov 24). BUG: unable to handle kernel paging reques

Re: wl1251 & mac address & calibration data

2016-11-26 Thread Pali Rohár
On Thursday 24 November 2016 19:46:01 Aaro Koskinen wrote: > Hi, > > On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > > Proprietary, signed and closed bootloader NOLO does not support DT. > > So for booting you need to append DTS file to kernel image. > > > > U-Boot is optional and c

Re: wl1251 & mac address & calibration data

2016-11-26 Thread Pavel Machek
On Thu 2016-11-24 20:46:01, Aaro Koskinen wrote: > Hi, > > On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > > Proprietary, signed and closed bootloader NOLO does not support DT. So > > for booting you need to append DTS file to kernel image. > > > > U-Boot is optional and can be used

Re: net: deadlock on genl_mutex

2016-11-26 Thread Eric Dumazet
On Sat, Nov 26, 2016 at 9:04 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers deadlock warnings on genl_mutex: > > https://gist.githubusercontent.com/dvyukov/65e33d053e507d2ab0bf6ae83d989585/raw/b3c640ec58e894b50bcbf255c471406466cfa5d0/gistfile1.txt > > On commit 16ae16c6e5616c

net: deadlock on genl_mutex

2016-11-26 Thread Dmitry Vyukov
Hello, The following program triggers deadlock warnings on genl_mutex: https://gist.githubusercontent.com/dvyukov/65e33d053e507d2ab0bf6ae83d989585/raw/b3c640ec58e894b50bcbf255c471406466cfa5d0/gistfile1.txt On commit 16ae16c6e5616c084168740990fc508bda6655d4 (Nov 24). BUG: sleeping function calle

net: GPF in rt6_get_cookie

2016-11-26 Thread Dmitry Vyukov
Hello, I got several GPFs in rt6_get_cookie while running syzkaller: general protection fault: [#1] SMP DEBUG_PAGEALLOC KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 2 PID: 10156 Comm: syz-executor Not tainted 4.9.0-rc5+ #54 Hardware name: QEMU Standard PC (i4

Re: netlink: GPF in sock_sndtimeo

2016-11-26 Thread Eric Dumazet
CC Richard Guy Briggs On Sat, Nov 26, 2016 at 7:44 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in sock_sndtimeo: > https://gist.githubusercontent.com/dvyukov/c19cadd309791cf5cb9b2bf936d3f48d/raw/1743ba0211079a5465d039512b427bc6b59b1a76/gistfile1.txt > > On commit 16a

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Rami Rosen
Hi, Lino, ... > @@ -0,0 +1,28 @@ > +config NET_VENDOR_ALACRITECH > +bool "Alacritech devices" > +default y > +---help--- > + If you have a network (Ethernet) card belonging to this class, say > Y. > + > + Note that the answer to this question doesn't dir

netlink: GPF in sock_sndtimeo

2016-11-26 Thread Dmitry Vyukov
Hello, The following program triggers GPF in sock_sndtimeo: https://gist.githubusercontent.com/dvyukov/c19cadd309791cf5cb9b2bf936d3f48d/raw/1743ba0211079a5465d039512b427bc6b59b1a76/gistfile1.txt On commit 16ae16c6e5616c084168740990fc508bda6655d4 (Nov 24). general protection fault: [#1] SMP

[PATCH net-next 04/10] net/mlx5: Add DCBX firmware commands support

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen Add set/query commands for DCBX_PARAM register Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 20 include/linux/mlx5/driver.h| 7 +++ include/linux/mlx5/port.h

[PATCH net-next 07/10] net/mlx5e: Add support for ethtool self diagnostics test

2016-11-26 Thread Saeed Mahameed
From: Kamal Heib The self diagnostics test implementaion include the following features: 1. Link Test: Check that link is in up state. 2. Speed Test: Check that link was negotiated correctly. 3. Health Test: Check the device health. Signed-off-by: Kamal Heib Signed-off-by: Saeed Mahameed ---

[PATCH net-next 02/10] net/mlx5e: Support DCBX CEE API

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen Add DCBX CEE API interface for ConnectX-4. Configurations are stored in a temporary structure and are applied to the card's firmware when the CEE's setall callback function is called. Note: priority group in CEE is equivalent to traffic class in ConnectX-4 hardware spec.

[PATCH net-next 01/10] net/mlx5e: Add qos capability check

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen Make sure firmware supports qos before exposing the DCB API. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/

[PATCH net-next 09/10] net/mlx5e: Moves pflags to priv->params

2016-11-26 Thread Saeed Mahameed
From: Shaker Daibes pflags is a configuration parameter for the netdev, naturally it belongs to priv->params. Also introduce MLX5E_GET_PFLAG Signed-off-by: Shaker Daibes Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 16 +--- drivers/net/e

[PATCH net-next 06/10] net/mlx5e: Add DCBX control interface

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen Use setdcbx interface to set the DCBX mode to firmware or os. If setdcbx is called with mode value of zero, the DCBX mode is set to firmware. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 27 ++

[PATCH net-next 03/10] net/mlx5e: Read ETS settings directly from firmware

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen Issue description: Current implementation saves the ETS settings from user in a temporal soft copy and returns this settings when user queries the ETS settings. With the new DCBX firmware, the ETS settings can be changed by firmware when the DCBX is in firmware controlled mode.

[PATCH net-next 05/10] net/mlx5e: ConnectX-4 firmware support for DCBX

2016-11-26 Thread Saeed Mahameed
From: Huy Nguyen This patch sets up the infrastructure to support the new DCBX firmware. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 + drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 92 ++ drive

[PATCH net-next 08/10] net/mlx5e: Add support for loopback selftest

2016-11-26 Thread Saeed Mahameed
Extend the self diagnostic tests to support loopback test. The loopback test doesn't require the offline flag, it will use the generic dev_queue_xmit and a dedicated packet_type to capture and verify mlx5e selftest loopback packets. Signed-off-by: Saeed Mahameed Signed-off-by: Kamal Heib --- d

[PATCH net-next 10/10] net/mlx5e: Add CQE compression user control

2016-11-26 Thread Saeed Mahameed
From: Shaker Daibes The user can now override the automatic driver decision using the rx_cqe_compress flag, which is the preference for CQE compression. The flag is initialized with the automatic driver decision. Signed-off-by: Shaker Daibes Signed-off-by: Saeed Mahameed --- drivers/net/ether

[PATCH net-next 00/10] Mellanox 100G mlx5 DCBX and ethtool updates

2016-11-26 Thread Saeed Mahameed
Hi Dave, This series provides the following mlx5 updates: >From Huy: DCBX CEE API and DCBX firmware/host modes support. - 1st patch ensures the dcbnl_rtnl_ops is published only when the qos capability bits is on. - 2nd patch adds the support for CEE interfaces into mlx5 dcbnl_rtnl

Re: net: stmmac: Meson GXBB: attempting to execute userspace memory

2016-11-26 Thread Heinrich Schuchardt
On 11/26/2016 10:08 AM, Martin Blumenstingl wrote: > Hello Heinrich, > > On Sat, Nov 26, 2016 at 8:53 AM, Heinrich Schuchardt > wrote: >> For Odroid C2 I have compiled kernel >> 4.9.0-rc6-next-20161124-1-gbf7e142 >> with one additional patch >> https://github.com/xypron/kernel-odroid-c2/blob/

Re: Gigabit ethernet driver for Alacritechs SLIC devices (v3)

2016-11-26 Thread Lino Sanfilippo
On 26.11.2016 13:20, Lino Sanfilippo wrote: > v3: > - dont add defines to pci.h but instead put it into the drivers header file This should of course be "pci_ids.h". Regards, Lino

[PATCH v3 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-11-26 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git://linuxtv.

[PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit) coppe

Gigabit ethernet driver for Alacritechs SLIC devices (v3)

2016-11-26 Thread Lino Sanfilippo
Hi, this is the third version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepte

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-26 Thread Daniel Borkmann
On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: Ok, strange, qdisc_destroy() calls into ops->destroy(), where ingress drops its entire chain via tcf_destroy_chain(), so that will be NULL eventually. The tps are freed by call_rcu() as well as qdi

Re: net: stmmac: Meson GXBB: attempting to execute userspace memory

2016-11-26 Thread Martin Blumenstingl
Hello Heinrich, On Sat, Nov 26, 2016 at 8:53 AM, Heinrich Schuchardt wrote: > For Odroid C2 I have compiled kernel > 4.9.0-rc6-next-20161124-1-gbf7e142 > with one additional patch > https://github.com/xypron/kernel-odroid-c2/blob/master/patch/0001-stmmac-RTL8211F-Meson-GXBB-TX-throughput-prob