[PATCH 2/3] vhost: better detection of available buffers

2016-11-08 Thread Jason Wang
We should use vq->last_avail_idx instead of vq->avail_idx in the checking of vhost_vq_avail_empty() since latter is the cached avail index from guest but we want to know if there's pending available buffers in the virtqueue. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 2 +- 1 file chan

[PATCH 3/3] vhost_net: tx support batching

2016-11-08 Thread Jason Wang
This patch tries to utilize tuntap rx batching by peeking the tx virtqueue during transmission, if there's more available buffers in the virtqueue, set MSG_MORE flag for a hint for tuntap to batch the packets. The maximum number of batched tx packets were specified through a module parameter: tx_ba

[PATCH 1/3] tuntap: rx batching

2016-11-08 Thread Jason Wang
Backlog were used for tuntap rx, but it can only process 1 packet at one time since it was scheduled during sendmsg() synchronously in process context. This lead bad cache utilization so this patch tries to do some batching before call rx NAPI. This is done through: - accept MSG_MORE as a hint fro

[PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4

2016-11-08 Thread Zhiyi Sun
There are rx_ring_num queues. Each queue will load xdp prog. So bpf_prog_add() should add rx_ring_num to ref_cnt. Signed-off-by: Zhiyi Sun --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4

Re: [PATCH for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

2016-11-08 Thread Leon Romanovsky
On Fri, Nov 04, 2016 at 04:36:31PM +, Salil Mehta wrote: > From: "Wei Hu (Xavier)" > > When using CM to establish connections, qp number that was freed > just now will be rejected by ib core. To fix these problem, We > change qpn allocation to round-robin mode. We added the round-robin > mode

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-08 Thread Leon Romanovsky
On Fri, Nov 04, 2016 at 04:36:25PM +, Salil Mehta wrote: > From: "Wei Hu (Xavier)" > > This patch modified the logic of allocating memory using APIs in > hns RoCE driver. We used kcalloc instead of kmalloc_array and > bitmap_zero. And When kcalloc failed, call vzalloc to alloc > memory. > > Si

Re: Virtio_net support vxlan encapsulation package TSO offload discuss

2016-11-08 Thread Jason Wang
On 2016年11月08日 19:58, Zhangming (James, Euler) wrote: On 2016年11月08日 19:17, Jason Wang wrote: On 2016年11月08日 19:13, Jason Wang wrote: Cc Michael On 2016年11月08日 16:34, Zhangming (James, Euler) wrote: In container scenario, OVS is installed in the Virtual machine, and all the containers conn

Re: [PATCH] net: ipv4: ip_send_unicast_reply should set oif only if it is L3 master

2016-11-08 Thread Lorenzo Colitti
On Wed, Nov 9, 2016 at 7:50 AM, David Ahern wrote: > @@ -1577,7 +1577,8 @@ void ip_send_unicast_reply(struct sock *sk, struct > sk_buff *skb, Tested-by: Lorenzo Colitti This fixes the IPv4 test, thanks. I notice that 4.8 didn't have e0d56fdd73, so if this patch can get into 4.9 then there will

[v16, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-11-08 Thread Yangbo Lu
The eSDHC of T4240-R1.0-R2.0 has incorrect vender version and spec version. Acturally the right version numbers should be VVN=0x13 and SVN = 0x1. This patch adds the GUTS driver support for eSDHC driver to match SoC. And fix host version to avoid that incorrect version numbers break down the ADMA d

[v16, 6/7] base: soc: Check for NULL SoC device attributes

2016-11-08 Thread Yangbo Lu
From: Geert Uytterhoeven If soc_device_match() is used to check the value of a specific attribute that is not present for the current SoC, the kernel crashes with a NULL pointer dereference. Fix this by explicitly checking for the absence of a needed property, and considering this a non-match.

[v16, 2/7] dt: bindings: move guts devicetree doc out of powerpc directory

2016-11-08 Thread Yangbo Lu
Move guts devicetree doc to Documentation/devicetree/bindings/soc/fsl/ since it's used by not only PowerPC but also ARM. And add a specification for 'little-endian' property. Signed-off-by: Yangbo Lu Acked-by: Rob Herring Acked-by: Scott Wood Acked-by: Arnd Bergmann --- Changes for v4:

[PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

2016-11-08 Thread Ricky Liang
kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): unreferenced object 0xffc0a2914780 (size 192): comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) hex dump (first 32 bytes): 00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@ 07 10

Re: net/sctp: null-ptr-deref in sctp_inet_listen

2016-11-08 Thread Xin Long
On Wed, Nov 9, 2016 at 2:46 AM, Andrey Konovalov wrote: > Hi Xin, > > Your patch seems to be fixing the issue. > > Tested-by: Andrey Konovalov > > Thanks! > > On Tue, Nov 8, 2016 at 11:06 AM, Xin Long wrote: >> On Tue, Nov 8, 2016 at 5:44 AM, Andrey Konovalov >> wrote: >>> Hi, >>> >>> I've got

[v16, 4/7] MAINTAINERS: add entry for Freescale SoC drivers

2016-11-08 Thread Yangbo Lu
Add maintainer entry for Freescale SoC drivers including the QE library and the GUTS driver now. Also add maintainer for QE library. Signed-off-by: Yangbo Lu Acked-by: Scott Wood Acked-by: Qiang Zhao Acked-by: Arnd Bergmann --- Changes for v8: - Added this patch Changes for v9:

[v16, 5/7] base: soc: introduce soc_device_match() interface

2016-11-08 Thread Yangbo Lu
From: Arnd Bergmann We keep running into cases where device drivers want to know the exact version of the a SoC they are currently running on. In the past, this has usually been done through a vendor specific API that can be called by a driver, or by directly accessing some kind of version regist

[v16, 1/7] ARM64: dts: ls2080a: add device configuration node

2016-11-08 Thread Yangbo Lu
Add the dts node for device configuration unit that provides general purpose configuration and status for the device. Signed-off-by: Yangbo Lu Acked-by: Scott Wood Acked-by: Arnd Bergmann --- Changes for v5: - Added this patch Changes for v6: - None Changes for v7: - Non

[v16, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

2016-11-08 Thread Yangbo Lu
The global utilities block controls power management, I/O device enabling, power-onreset(POR) configuration monitoring, alternate function selection for multiplexed signals,and clock control. This patch adds a driver to manage and access global utilities block. Initially only reading SVR and regis

[v16, 0/7] Fix eSDHC host version register bug

2016-11-08 Thread Yangbo Lu
This patchset is used to fix a host version register bug in the T4240-R1.0-R2.0 eSDHC controller. To match the SoC version and revision, 15 previous version patchsets had tried many methods but all of them were rejected by reviewers. Such as - dts compatible method - syscon method

[PATCHv2 net] igmp: do not remove igmp souce list info when set link down

2016-11-08 Thread Hangbin Liu
In commit 24cf3af(igmp: call ip_mc_clear_src...), we forgot to remove igmpv3_clear_delrec() in ip_mc_down(), which also called ip_mc_clear_src(). This make us clear all IGMPv3 source filter info after NETDEV_DOWN. Move igmpv3_clear_delrec() to ip_mc_destroy_dev() and then no need ip_mc_clear_src()

Re: 484611357c19 introduces arbitrary kernel write bug (root-only)

2016-11-08 Thread Josef Bacik
On 11/08/2016 07:23 PM, Jann Horn wrote: In 484611357c19 (not in any stable kernel yet), functionality is introduced that allows root (and afaics nobody else, since nobody else is allowed to perform pointer arithmetic) to basically write to (and read from) arbitrary kernel memory. There are multi

Re: [v2] cw1200: Don't leak memory if krealloc failes

2016-11-08 Thread Kalle Valo
Johannes Thumshirn wrote: > The call to krealloc() in wsm_buf_reserve() directly assigns the newly > returned memory to buf->begin. This is all fine except when krealloc() > failes we loose the ability to free the old memory pointed to by > buf->begin. If we just create a temporary variable to ass

Re: brcmfmac: proto: add callback for queuing TX data

2016-11-08 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > So far our core code was calling brcmf_fws_process_skb which wasn't > a proper thing to do. If case of devices using msgbuf protocol fwsignal > shouldn't be used. It was an unnecessary extra layer simply calling > a protocol specifix txdata function.

Re: [PATCH] wireless: fix bogus maybe-uninitialized warning

2016-11-08 Thread Kalle Valo
Arnd Bergmann writes: > The hostap_80211_rx() function is supposed to set up the mac addresses > for four possible cases, based on two bits of input data. For > some reason, gcc decides that it's possible that none of the these > four cases apply and the addresses remain uninitialized: > > driver

Re: 484611357c19 introduces arbitrary kernel write bug (root-only)

2016-11-08 Thread Andy Lutomirski
On Tue, Nov 8, 2016 at 4:23 PM, Jann Horn wrote: > In 484611357c19 (not in any stable kernel yet), functionality is > introduced that allows root (and afaics nobody else, since nobody else > is allowed to perform pointer arithmetic) to basically write to (and > read from) arbitrary kernel memory.

484611357c19 introduces arbitrary kernel write bug (root-only)

2016-11-08 Thread Jann Horn
In 484611357c19 (not in any stable kernel yet), functionality is introduced that allows root (and afaics nobody else, since nobody else is allowed to perform pointer arithmetic) to basically write to (and read from) arbitrary kernel memory. There are multiple bugs in the validation logic: - A bit

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-11-08 Thread Andy Lutomirski
On Tue, Nov 8, 2016 at 4:03 PM, Alexei Starovoitov wrote: > On Tue, Nov 08, 2016 at 03:51:40PM -0800, Andy Lutomirski wrote: >> On Tue, Nov 8, 2016 at 3:28 PM, John Stultz wrote: >> > This patch adds logic to allows a process to migrate other tasks >> > between cgroups if they have CAP_SYS_RESOUR

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
> "Arun" == Arun Easi writes: >> It's fine to post the patches split up to ease the review >> process. But whatever we commit must obviously be bisectable. Arun> If it is alright with you, we would like to have all of our Arun> initial patches for the driver (qedi) squashed as a single commi

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-11-08 Thread Alexei Starovoitov
On Tue, Nov 08, 2016 at 03:51:40PM -0800, Andy Lutomirski wrote: > On Tue, Nov 8, 2016 at 3:28 PM, John Stultz wrote: > > This patch adds logic to allows a process to migrate other tasks > > between cgroups if they have CAP_SYS_RESOURCE. > > > > In Android (where this feature originated), the Acti

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Arun Easi
Martin, On Tue, 8 Nov 2016, 3:49pm -, Martin K. Petersen wrote: > > "Arun" == Arun Easi writes: > > Arun, > > Arun> qedi is the new iSCSI driver, which we are trying to submit, for > Arun> our 41000 series CNA. This patch series were broken up into > Arun> logical blocks for review pur

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-11-08 Thread Andy Lutomirski
On Tue, Nov 8, 2016 at 3:28 PM, John Stultz wrote: > This patch adds logic to allows a process to migrate other tasks > between cgroups if they have CAP_SYS_RESOURCE. > > In Android (where this feature originated), the ActivityManager tracks > various application states (TOP_APP, FOREGROUND, BACKG

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
> "Arun" == Arun Easi writes: Arun, Arun> qedi is the new iSCSI driver, which we are trying to submit, for Arun> our 41000 series CNA. This patch series were broken up into Arun> logical blocks for review purpose, but were not made to compile Arun> individually. It is our impression that thi

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Arun Easi
so build test ERROR on v4.9-rc4] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Manish-Rangankar/qed-Add-support-for-hardware-offloaded-iSCSI/20161108-180027 > config: i

Re: [PATCH] net: ethernet: ti: davinci_cpdma: free memory while channel destroy

2016-11-08 Thread Grygorii Strashko
On 11/08/2016 07:16 AM, Ivan Khoronzhuk wrote: While create/destroy channel operation memory is not freed. It was supposed that memory is freed while driver remove. But a channel can be created and destroyed many times while changing number of channels with ethtool. Based on net-next/master

Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks

2016-11-08 Thread Grygorii Strashko
On 11/03/2016 12:40 PM, Johan Hovold wrote: Make sure to drop the references taken by of_get_child_by_name() and bus_find_device() before returning from cpsw_phy_sel(). Note that holding a reference to the cpsw-phy-sel device does not prevent the devres-managed private data from going away. F

Re: [PATCH] net/netfilter: Fix use uninitialized warn in nft_range_eval()

2016-11-08 Thread Pablo Neira Ayuso
On Mon, Nov 07, 2016 at 08:41:14AM -0700, Shuah Khan wrote: > Fix the following warn: > >CC [M] net/netfilter/nft_range.o > 8601,8605c9105 > net/netfilter/nft_range.c: In function ‘nft_range_eval’: > net/netfilter/nft_range.c:45:5: warning: ‘mismatch’ may be used > uninitialized in this fu

Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-11-08 Thread Greg
On Tue, 2016-11-08 at 22:29 +0100, Phil Sutter wrote: > Commit 7b8179c780a1a ("iproute2: Add new command to ip link to > enable/disable VF spoof check") tried to add support for > IFLA_VF_SPOOFCHK in a backwards-compatible manner, but aparently overdid > it: parse_rtattr_nested() handles missing at

Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

2016-11-08 Thread Pablo Neira Ayuso
On Fri, Nov 04, 2016 at 11:58:44AM +0100, Simon Horman wrote: > On Thu, Nov 03, 2016 at 05:14:03PM -0700, Cong Wang wrote: > > family.maxattr is the max index for policy[], the size of > > ops[] is determined with ARRAY_SIZE(). > > > > Reported-by: Andrey Konovalov > > Tested-by: Andrey Konovalov

[PATCH] net: ipv4: ip_send_unicast_reply should set oif only if it is L3 master

2016-11-08 Thread David Ahern
Lorenzo noted an Android unit test failed due to commit e0d56fdd7342: "The expectation in the test was that the RST replying to a SYN sent to a closed port should be generated with oif=0. In other words it should not prefer the interface where the SYN came in on, but instead should follow w

Re: [PATCH 7/8] tools lib bpf: fix maps resolution

2016-11-08 Thread Wangnan (F)
Hi Eric, During testing this patch I find a segfault, please see inline comment. In addition, since both the BPF map array and map names should be done after symbol table is collected, merging bpf_object__init_maps and bpf_object__init_maps_name would be a good practice, making code simpler. So

[PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-08 Thread chris.roth
From: Allan Chou Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to Gigabit

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Keller, Jacob E
On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > The 82580 and related devices offer a frequency resolution of about > 0.029 ppb.  This patch lets users of the device benefit from the > increased frequency resolution when tuning the clock. > > Signed-off-by: Richard Cochran > --- Addi

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Keller, Jacob E
On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > The 82580 and related devices offer a frequency resolution of about > 0.029 ppb.  This patch lets users of the device benefit from the > increased frequency resolution when tuning the clock. > > Signed-off-by: Richard Cochran > --- >  dr

[PATCH] tools lib bpf: fix maps resolution

2016-11-08 Thread Wang Nan
From: Eric Leblond It is not correct to assimilate the elf data of the maps section to an array of map definition. In fact the sizes differ. The offset provided in the symbol section has to be used instead. This patch fixes a bug causing a elf with two maps not to load correctly. Wang Nan added

Re: [PATCH net-next 0/3] PHC frequency fine tuning

2016-11-08 Thread Keller, Jacob E
On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > This series expands the PTP Hardware Clock subsystem by adding a > method that passes the frequency tuning word to the the drivers > without dropping the low order bits.  Keeping those bits is useful > for > drivers whose frequency resolut

[PATCH net-next 3/3] ptp: dp83640: Use the high resolution frequency method.

2016-11-08 Thread Richard Cochran
The dp83640 has a frequency resolution of about 0.029 ppb. This patch lets users of the device benefit from the increased frequency resolution when tuning the clock. Signed-off-by: Richard Cochran --- drivers/net/phy/dp83640.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Richard Cochran
The 82580 and related devices offer a frequency resolution of about 0.029 ppb. This patch lets users of the device benefit from the increased frequency resolution when tuning the clock. Signed-off-by: Richard Cochran --- drivers/net/ethernet/intel/igb/igb_ptp.c | 16 1 file cha

[PATCH net-next 0/3] PHC frequency fine tuning

2016-11-08 Thread Richard Cochran
This series expands the PTP Hardware Clock subsystem by adding a method that passes the frequency tuning word to the the drivers without dropping the low order bits. Keeping those bits is useful for drivers whose frequency resolution is higher than 1 ppb. The appended script (below) runs a simple

[PATCH net-next 1/3] ptp: Introduce a high resolution frequency adjustment method.

2016-11-08 Thread Richard Cochran
The internal PTP Hardware Clock (PHC) interface limits the resolution for frequency adjustments to one part per billion. However, some hardware devices allow finer adjustment, and making use of the increased resolution improves synchronization measurably on such devices. This patch adds an altern

Re: [PATCH] bpf: Remove unused but set variables

2016-11-08 Thread Alexei Starovoitov
On Tue, Nov 08, 2016 at 04:40:28PM +0100, Tobias Klauser wrote: > Remove the unused but set variables min_set and max_set in > adjust_reg_min_max_vals to fix the following warning when building with > 'W=1': > > kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used > [-Wunu

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-08 Thread Vidya Sagar Ravipati
On Thu, Nov 3, 2016 at 6:24 AM, Gal Pressman wrote: > > > On 25/10/2016 05:50, Vidya Sagar Ravipati wrote: >> SET FEC option: >> root@tor: ethtool --set-fec swp1 encoding [off | RS | BaseR | auto] autoneg >> [off | on] >> >> Encoding: Types of encoding >> Off: Turning off any encoding >> RS

[iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-11-08 Thread Phil Sutter
Commit 7b8179c780a1a ("iproute2: Add new command to ip link to enable/disable VF spoof check") tried to add support for IFLA_VF_SPOOFCHK in a backwards-compatible manner, but aparently overdid it: parse_rtattr_nested() handles missing attributes perfectly fine in that it will leave the relevant fie

[iproute PATCH 2/2] ipaddress: Print IFLA_VF_QUERY_RSS_EN setting

2016-11-08 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ipaddress.c | 8 1 file changed, 8 insertions(+) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index df0f1b9c94c58..c9f769fb748e4 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -405,6 +405,14 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfin

[iproute PATCH 0/2] Resend: Simplify and enhance vf_info parsing

2016-11-08 Thread Phil Sutter
This patch series got lost in a discussion about whether the code the first patch removes is necessary or not - static analysis as well as my tests showed it is not. Therefore resending this with updated description of patch 1 to contain the discussion's gist. Phil Sutter (2): ipaddress: Simplif

Re: [PATCH net-next 1/2] bnxt_en: do not call napi_hash_add()

2016-11-08 Thread Michael Chan
On Tue, Nov 8, 2016 at 11:06 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > This is automatically done from netif_napi_add(), and we want to not > export napi_hash_add() anymore in the following patch. > > Signed-off-by: Eric Dumazet > Cc: Michael Chan Acked-by: Michael Chan

Re: [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause

2016-11-08 Thread Timur Tabi
On 11/07/2016 10:30 AM, Timur Tabi wrote: I'm still don't understand 100% how these flags really work, because I just can't shake the feeling that they should not be set for every phy. If these flags are supposed to be turned on universally, then why are they even an option? So I've been giv

Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization

2016-11-08 Thread Geert Uytterhoeven
Hi Florian, On Tue, Nov 8, 2016 at 8:42 PM, Florian Fainelli wrote: > On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote: >> Currently the renesas-irqc driver uses postcore_initcall(). >> >> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the >> IRQC's probe will be deferred, which c

Re: net/l2tp: use-after-free write in l2tp_ip6_close

2016-11-08 Thread Andrey Konovalov
Hi Cong, Tried with your patch, still seeing the reports. Thanks! On Tue, Nov 8, 2016 at 12:02 AM, Cong Wang wrote: > On Mon, Nov 7, 2016 at 2:35 PM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >> ==

Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization

2016-11-08 Thread Florian Fainelli
On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote: > Currently the renesas-irqc driver uses postcore_initcall(). > > However, the new CPG/MSSR driver uses subsys_initcall(). Hence the > IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to > not find its interrupt on R-Car Gen2 and

[PATCH v2] irqchip/renesas-irqc: Postpone driver initialization

2016-11-08 Thread Geert Uytterhoeven
Currently the renesas-irqc driver uses postcore_initcall(). However, the new CPG/MSSR driver uses subsys_initcall(). Hence the IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem does not support deferred pr

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-08 Thread Alexander Duyck
On Tue, Nov 8, 2016 at 10:37 AM, Corinna Vinschen wrote: > On Nov 8 09:16, Hisashi T Fujinaka wrote: >> On Tue, 8 Nov 2016, Corinna Vinschen wrote: >> > On Nov 8 15:06, Cao jin wrote: >> > > When running as guest, under certain condition, it will oops as >> > > following. >> > > writel() in igb

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-08 Thread Sven Eckelmann
On Dienstag, 8. November 2016 09:43:01 CET Eric Dumazet wrote: [...] > Sure, but your patch 13/17 should address this right away. [...] Fair enough. I've asked Simon to resubmit the patches with the "consume_skb -> conditional kfree_skb/consume_skb" patch squashed into patch 13. Kind regards,

Re: [PATCH net-next v4] cadence: Add LSO support.

2016-11-08 Thread Florian Fainelli
On 11/08/2016 05:41 AM, Rafal Ozieblo wrote: > New Cadence GEM hardware support Large Segment Offload (LSO): > TCP segmentation offload (TSO) as well as UDP fragmentation > offload (UFO). Support for those features was added to the driver. > > Signed-off-by: Rafal Ozieblo > --- > -#define MACB_M

[PATCH net-next 2/2] net: napi_hash_add() is no longer exported

2016-11-08 Thread Eric Dumazet
From: Eric Dumazet There are no more users except from net/core/dev.c napi_hash_add() can now be static. Signed-off-by: Eric Dumazet Cc: Michael Chan --- include/linux/netdevice.h | 11 --- net/core/dev.c|3 +-- 2 files changed, 1 insertion(+), 13 deletions(-) diff

[PATCH net-next 1/2] bnxt_en: do not call napi_hash_add()

2016-11-08 Thread Eric Dumazet
From: Eric Dumazet This is automatically done from netif_napi_add(), and we want to not export napi_hash_add() anymore in the following patch. Signed-off-by: Eric Dumazet Cc: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drive

Re: [PATCH v3 4/4] posix-timers: make it configurable

2016-11-08 Thread John Stultz
On Tue, Nov 8, 2016 at 10:19 AM, Nicolas Pitre wrote: > On Tue, 8 Nov 2016, John Stultz wrote: > >> One spot of concern is that the >> tools/testing/selftests/timers/posix_timers.c test hangs testing >> virtual itimers. Looking through the code I'm not seeing where an >> error case is missed. >> >

Re: net/sctp: null-ptr-deref in sctp_inet_listen

2016-11-08 Thread Andrey Konovalov
Hi Xin, Your patch seems to be fixing the issue. Tested-by: Andrey Konovalov Thanks! On Tue, Nov 8, 2016 at 11:06 AM, Xin Long wrote: > On Tue, Nov 8, 2016 at 5:44 AM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >> kasan:

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-08 Thread Alan Stern
On Tue, 8 Nov 2016, Bjørn Mork wrote: > Alan Stern writes: > > > On Tue, 8 Nov 2016, Kai-Heng Feng wrote: > > > >> Hi, > >> > >> On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: > >> > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: > >> >> Sometimes cdc_mbim failed to probe if run

Re: linux-next: Tree for Nov 8 (netdev, netfilter)

2016-11-08 Thread Randy Dunlap
On 11/07/16 23:38, Stephen Rothwell wrote: > Hi all, > > Changes since 20161028: on i386 or x86_64: net/built-in.o: In function `nf_sk_lookup_slow_v4': (.text+0x97414): undefined reference to `udp4_lib_lookup' when these are not enabled: #if IS_ENABLED(CONFIG_NETFILTER_XT_MATCH_SOCKET) || \

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-08 Thread Corinna Vinschen
On Nov 8 09:16, Hisashi T Fujinaka wrote: > On Tue, 8 Nov 2016, Corinna Vinschen wrote: > > On Nov 8 15:06, Cao jin wrote: > > > When running as guest, under certain condition, it will oops as following. > > > writel() in igb_configure_tx_ring() results in oops, because hw->hw_addr > > > is NULL.

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-08 Thread Hisashi T Fujinaka
On Tue, 8 Nov 2016, Hisashi T Fujinaka wrote: Incidentally we're just looking for a solution to that problem too. Do three patches to fix the same problem at rougly the same time already qualify as freak accident? FTR, I attached my current patch, which I was planning to submit after some exter

Re: [PATCH v3 4/4] posix-timers: make it configurable

2016-11-08 Thread Nicolas Pitre
On Tue, 8 Nov 2016, John Stultz wrote: > One spot of concern is that the > tools/testing/selftests/timers/posix_timers.c test hangs testing > virtual itimers. Looking through the code I'm not seeing where an > error case is missed. > > The strace looks like: > ... > write(1, "Testing posix timers

RE: Is there a maximum bytes in flight limitation in the tcp stack? -->limit in scp

2016-11-08 Thread De Schepper, Koen (Nokia - BE)
Seems to be a limitation in the application. We used scp, and it (still) seems to limit the bytes in flight. Using our own application, we didn't see a limit indeed. Thanks for your response, and sorry for the noise... Koen. > -Original Message- > From: Yuchung Cheng [mailto:ych...@goog

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

2016-11-08 Thread Anna Schumaker
On 11/08/2016 12:43 PM, Ross Zwisler wrote: > On Tue, Nov 08, 2016 at 07:42:59AM -0500, Anna Schumaker wrote: >> On 11/08/2016 07:09 AM, Jeff Layton wrote: >>> On Tue, 2016-11-08 at 06:53 -0500, Jeff Layton wrote: On Mon, 2016-11-07 at 22:42 -0700, Ross Zwisler wrote: > > I've got a vi

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

2016-11-08 Thread Ross Zwisler
On Tue, Nov 08, 2016 at 07:42:59AM -0500, Anna Schumaker wrote: > On 11/08/2016 07:09 AM, Jeff Layton wrote: > > On Tue, 2016-11-08 at 06:53 -0500, Jeff Layton wrote: > >> On Mon, 2016-11-07 at 22:42 -0700, Ross Zwisler wrote: > >>> > >>> I've got a virtual machine that has some NFS mounts, and wit

Re: [PATCH v3 4/4] posix-timers: make it configurable

2016-11-08 Thread John Stultz
On Mon, Nov 7, 2016 at 2:14 PM, Nicolas Pitre wrote: > Some embedded systems have no use for them. This removes about > 22KB from the kernel binary size when configured out. > > Corresponding syscalls are routed to a stub logging the attempt to > use those syscalls which should be enough of a clu

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-08 Thread Eric Dumazet
On Tue, 2016-11-08 at 18:28 +0100, Sven Eckelmann wrote: > On Dienstag, 8. November 2016 08:59:49 CET Eric Dumazet wrote: > [...] > > > +free_skb: > > > consume_skb(skb); > > > - return NET_RX_SUCCESS; > > > + > > > + return ret; > > > } > > > > > > Okay, but we do have kfree_skb() and consume

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-08 Thread Sven Eckelmann
On Dienstag, 8. November 2016 08:59:49 CET Eric Dumazet wrote: [...] > > +free_skb: > > consume_skb(skb); > > - return NET_RX_SUCCESS; > > + > > + return ret; > > } > > > Okay, but we do have kfree_skb() and consume_skb() and they should be > used appropriately. Yes, this patch is one p

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-08 Thread Hisashi T Fujinaka
On Tue, 8 Nov 2016, Corinna Vinschen wrote: On Nov 8 15:06, Cao jin wrote: When running as guest, under certain condition, it will oops as following. writel() in igb_configure_tx_ring() results in oops, because hw->hw_addr is NULL. While other register access won't oops kernel because they use

Re: Why are IPv6 host and anycast routes referencing lo device?

2016-11-08 Thread Hannes Frederic Sowa
On 08.11.2016 02:08, David Ahern wrote: > > Can anyone explain why host routes and anycast routes for IPv6 are added with > the device set to loopback versus the device with the address: > > local ::1 dev lo proto none metric 0 pref medium > local 2000:1:: dev lo proto none metric 0 pref m

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-08 Thread Eric Dumazet
On Tue, 2016-11-08 at 17:45 +0100, Simon Wunderlich wrote: > From: Sven Eckelmann > > Receiving functions in Linux consume the supplied skbuff. Doing the same in > the batadv_rx_handler functions makes the behavior more similar to the rest > of the Linux network code. > > Signed-off-by: Sven Eck

[PATCH 01/17] batman-adv: Introduce missing headers for genetlink restructure

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann Fixes: 56989f6d8568 ("genetlink: mark families as __ro_after_init") Fixes: 2ae0f17df1cd ("genetlink: use idr to track families") Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/netlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 08/17] batman-adv: Simple (re)broadcast avoidance

2016-11-08 Thread Simon Wunderlich
From: Linus Lüssing With this patch, (re)broadcasting on a specific interfaces is avoided: * No neighbor: There is no need to broadcast on an interface if there is no node behind it. * Single neighbor is source: If there is just one neighbor on an interface and if this neighbor is the one w

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-08 Thread Bjørn Mork
Alan Stern writes: > On Tue, 8 Nov 2016, Kai-Heng Feng wrote: > >> Hi, >> >> On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: >> > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> >> [9.305626] cdc_mbim: probe

Re: [PATCH v3 0/4] make POSIX timers optional with some Kconfig help

2016-11-08 Thread Thomas Gleixner
On Mon, 7 Nov 2016, Nicolas Pitre wrote: > Many embedded systems don't need the full POSIX timer support. > Configuring them out provides a nice kernel image size reduction. > > When POSIX timers are configured out, the PTP clock subsystem should be > left out as well. However a bunch of ethernet

[PATCH 10/17] batman-adv: Count all non-success TX packets as dropped

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann A failure during the submission also causes dropped packets. batadv_interface_tx should therefore also increase the DROPPED counter for these returns. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/soft-interface.c | 2 +- 1 file changed,

[PATCH 05/17] batman-adv: Remove unnecessary lockdep in batadv_mcast_mla_list_free

2016-11-08 Thread Simon Wunderlich
From: Linus Lüssing batadv_mcast_mla_list_free() just frees some leftovers of a local feast in batadv_mcast_mla_update(). No lockdep needed as it has nothing to do with bat_priv->mcast.mla_list. Signed-off-by: Linus Lüssing Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- ne

[PATCH 04/17] batman-adv: Add wrapper for ARP reply creation

2016-11-08 Thread Simon Wunderlich
From: Linus Lüssing Removing duplicate code. Signed-off-by: Linus Lüssing Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/distributed-arp-table.c | 67 -- 1 file changed, 40 insertions(+), 27 deletions(-) diff --git a/net/batm

[PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann Receiving functions in Linux consume the supplied skbuff. Doing the same in the batadv_rx_handler functions makes the behavior more similar to the rest of the Linux network code. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/bat_iv_ogm.c

[PATCH 11/17] batman-adv: Consume skb in batadv_frag_send_packet

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann Sending functions in Linux consume the supplied skbuff. Doing the same in batadv_frag_send_packet avoids the hack of returning -1 (-EPERM) to signal the caller that he is responsible for cleaning up the skb. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich ---

[PATCH 09/17] batman-adv: use consume_skb for non-dropped packets

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann kfree_skb assumes that an skb is dropped after an failure and notes that. consume_skb should be used in non-failure situations. Such information is important for dropmonitor netlink which tells how many packets were dropped and where this drop happened. Signed-off-by: Sven E

[PATCH 14/17] batman-adv: Remove dev_queue_xmit return code exception

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann No caller of batadv_send_skb_to_orig is expecting the results to be -1 (-EPERM) anymore when the skbuff was not consumed. They will instead expect that the skbuff is always consumed. Having such return code filter is therefore not needed anymore. Signed-off-by: Sven Eckelman

[PATCH 02/17] batman-adv: Mark batadv_netlink_ops as const

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann The genl_ops don't need to be written by anyone and thus can be moved in a ro memory range. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/netlin

[PATCH 15/17] batman-adv: Disallow mcast src address for data frames

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann The routing checks are validating the source mac address of the outer ethernet header. They reject every source mac address which is a broadcast address. But they also have to reject any multicast mac addresses. Signed-off-by: Sven Eckelmann [s...@simonwunderlich.de: fix co

[PATCH 06/17] batman-adv: Remove unused skb_reset_mac_header()

2016-11-08 Thread Simon Wunderlich
From: Linus Lüssing During broadcast queueing, the skb_reset_mac_header() sets the skb to a place invalid for a MAC header, pointing right into the batman-adv broadcast packet. Luckily, no one seems to actually use eth_hdr(skb) afterwards until batadv_send_skb_packet() resets the header to a vali

[PATCH 16/17] batman-adv: Disallow zero and mcast src address for mgmt frames

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann The routing check for management frames is validating the source mac address in the outer ethernet header. It rejects every source mac address which is a broadcast address. But it also has to reject the zero-mac address and multicast mac addresses. Signed-off-by: Sven Eckelm

[PATCH 03/17] batman-adv: Close two alignment holes in batadv_hard_iface

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 673a22e..c9db184 100644 --- a/net/batman-adv/types.h +++ b

[PATCH 17/17] batman-adv: Reject unicast packet with zero/mcast dst address

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann An unicast batman-adv packet cannot be transmitted to a multicast or zero mac address. So reject incoming packets which still have these classes of addresses as destination mac address in the outer ethernet header. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderli

[PATCH 07/17] batman-adv: Use own timer for multicast TT and TVLV updates

2016-11-08 Thread Simon Wunderlich
From: Linus Lüssing Instead of latching onto the OGM period, this patch introduces a worker dedicated to multicast TT and TVLV updates. The reasoning is, that upon roaming especially the translation table should be updated timely to minimize connectivity issues. With BATMAN V, the idea is to gr

[PATCH 12/17] batman-adv: Consume skb in batadv_send_skb_to_orig

2016-11-08 Thread Simon Wunderlich
From: Sven Eckelmann Sending functions in Linux consume the supplied skbuff. Doing the same in batadv_send_skb_to_orig avoids the hack of returning -1 (-EPERM) to signal the caller that he is responsible for cleaning up the skb. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich ---

[PATCH 00/17] pull request for net-next: batman-adv 2016-11-08

2016-11-08 Thread Simon Wunderlich
davem-20161027' of git://git.open-mesh.org/linux-merge (2016-10-29 16:26:50 -0400) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20161108 for you to fetch changes up to 33581cefe4d182d99e9f8a66156507b06e7c9265: batman-adv: Reje

  1   2   >