Re: [net-next PATCH 3/3] qdisc: catch misconfig of attaching qdisc to tx_queue_len zero device

2016-11-07 Thread Jesper Dangaard Brouer
On Mon, 7 Nov 2016 22:14:37 -0800 Maciej Żenczykowski wrote: > Just FYI: > > I'm tangentially aware of internal Google code that: > - expects a bonding device running HTB with non-zero txqueuelen > - wants to remove HTB and get a noqueue interface (the normal default > for bonding) > > The co

[PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-11-07 Thread Jan Beulich
For single items being collected this should be preferred as being more typesafe (as the compiler can check format string and to-be-written-to variable match) and more efficient (requiring one less parameter to be passed). Signed-off-by: Jan Beulich --- v3: For consistency with other code don't c

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-07 Thread Kai-Heng Feng
Hi, On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 >> >> This can be solved by increase its pm usage

RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Madalin-Cristian Bucur
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 07, 2016 5:55 PM > > From: Madalin-Cristian Bucur > Date: Mon, 7 Nov 2016 15:43:26 + > > >> From: David Miller [mailto:da...@davemloft.net] > >> Sent: Thursday, November 03, 2016 9:58 PM >

[PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-07 Thread Cao jin
When running as guest, under certain condition, it will oops as following. writel() in igb_configure_tx_ring() results in oops, because hw->hw_addr is NULL. While other register access won't oops kernel because they use wr32/rd32 which have a defense against NULL pointer. [ 141.225449] pciepo

[PATCH v2 5/6] qedi: Add support for iSCSI session management.

2016-11-07 Thread Manish Rangankar
This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun E

[PATCH v2 6/6] qedi: Add support for data path.

2016-11-07 Thread Manish Rangankar
This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c| 1272 ++

RE: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-11-07 Thread Y.B. Lu
Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, November 08, 2016 5:20 AM > To: Y.B. Lu > Cc: linuxppc-...@lists.ozlabs.org; linux-...@vger.kernel.org; > ulf.hans...@linaro.org; Scott Wood; Mark Rutland; Greg Kroah-Hartman; X.B. > Xie; M.H. Lian

Re: [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-07 Thread Greg KH
On Mon, Nov 07, 2016 at 04:44:20PM -0600, Chris Roth wrote: > From: Allan Chou > > Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet > Bridge Controller (Vendor=04b4 ProdID=3610). > > Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems > with the Kensington SD4600P USB-C Un

Re: linux-next: manual merge of the net-next tree with the net tree

2016-11-07 Thread Cong Wang
On Mon, Nov 7, 2016 at 5:25 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/netlink/genetlink.c > > between commit: > > 00ffc1ba02d8 ("genetlink: fix a memory leak on error path") > > from the net tree and commit: > > 2ae0f17

Re: [net-next PATCH 3/3] qdisc: catch misconfig of attaching qdisc to tx_queue_len zero device

2016-11-07 Thread Maciej Żenczykowski
Just FYI: I'm tangentially aware of internal Google code that: - expects a bonding device running HTB with non-zero txqueuelen - wants to remove HTB and get a noqueue interface (the normal default for bonding) The code currently removes HTB, which gets us to mq, sets txqueuelen to 0, adds a pfifo

Re: [Intel-wired-lan] [PATCH] igb: drop field "tail" of struct igb_ring

2016-11-07 Thread Cao jin
On 11/08/2016 12:12 PM, Alexander Duyck wrote: On Monday, November 7, 2016, Cao jin mailto:caoj.f...@cn.fujitsu.com>> wrote: We removed head because it isn't really accessed very often, it is only really used for when the ring is configured. Tail is accessed every time we add a descrip

Re: [PATCH] net: alteon: acenic: use new api ethtool_{get|set}_link_ksettings

2016-11-07 Thread Jes Sorensen
On 11/05/16 11:17, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/alteon/acenic.c | 65 ++--- > 1 files changed, 35

net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

2016-11-07 Thread Ross Zwisler
I've got a virtual machine that has some NFS mounts, and with a newly compiled kernel based on v4.9-rc3 I see the following warning/info message: [ 42.750181] === [ 42.750192] [ INFO: suspicious RCU usage. ] [ 42.750203] 4.9.0-rc3-2-g7b6e7de #3 Not tainted [

Re: Is there a maximum bytes in flight limitation in the tcp stack?

2016-11-07 Thread Yuchung Cheng
On Thu, Nov 3, 2016 at 9:37 AM, De Schepper, Koen (Nokia - BE) wrote: > > Hi, > > We experience some limit on the maximum packets in flight which seem not to > be related with the receive or write buffers. Does somebody know if there is > an issue with a maximum of around 1MByte (or sometimes 2M

Re: [PATCH net 1/1] driver: macvlan: Destroy new macvlan port if macvlan_common_newlink failed.

2016-11-07 Thread Gao Feng
Hi David, On Tue, Nov 8, 2016 at 9:33 AM, David Miller wrote: > From: f...@ikuai8.com > Date: Fri, 4 Nov 2016 10:28:49 +0800 > >> From: Gao Feng >> >> When there is no existing macvlan port in lowdev, one new macvlan port >> would be created. But it doesn't be destoried when something failed la

Re: Why are IPv6 host and anycast routes referencing lo device?

2016-11-07 Thread David Ahern
On 11/7/16 7:26 PM, YOSHIFUJI Hideaki wrote: > Once I tried I did not work. > You could try again to see what happens. I did and both worked fine in quick POC testing. I'll do more in-depth testing and send a patch. Thanks.

Re: [Intel-wired-lan] [PATCH] igb: drop field "tail" of struct igb_ring

2016-11-07 Thread Cao jin
On 11/08/2016 02:49 AM, Alexander Duyck wrote: On Mon, Nov 7, 2016 at 4:44 AM, Cao jin wrote: Under certain condition, I find guest will oops on writel() in igb_configure_tx_ring(), because hw->hw_address is NULL. While other register access won't oops kernel because they use wr32/rd32 which

Re: Why are IPv6 host and anycast routes referencing lo device?

2016-11-07 Thread YOSHIFUJI Hideaki
Hi, David Ahern wrote: > > Can anyone explain why host routes and anycast routes for IPv6 are added with > the device set to loopback versus the device with the address: > > local ::1 dev lo proto none metric 0 pref medium > local 2000:1:: dev lo proto none metric 0 pref medium > local 20

linux-next: manual merge of the rdma-leon-test tree with the net-next tree

2016-11-07 Thread Stephen Rothwell
Hi Leon, Today's linux-next merge of the rdma-leon-test tree got a conflict in: drivers/infiniband/core/roce_gid_mgmt.c between commit: 453d39329ad0 ("IB/core: Flip to the new dev walk API") from the net-next tree and commit: e4b4d6b5d8c2 ("IB/core: Remove debug prints after allocation

Re: [lkp] [net] af1fee9821: BUG:spinlock_trylock_failure_on_UP_on_CPU

2016-11-07 Thread Ye Xiaolong
On 11/07, Allan W. Nielsen wrote: >Hi, > >I tried to get this "lkp" up and running, but I had some troubles gettting >these scripts to work. Hi, Allan Could you tell us what troubles you have met when trying the "lkp qemu" tool, it would be better if you could paste some log so we can help to imp

Re: [net PATCH] fib_trie: Correct /proc/net/route off by one error

2016-11-07 Thread David Miller
From: Alexander Duyck Date: Fri, 04 Nov 2016 15:11:57 -0400 > The display of /proc/net/route has had a couple issues due to the fact that > when I originally rewrote most of fib_trie I made it so that the iterator > was tracking the next value to use instead of the current. > > In addition it ha

Re: [PATCH] Documentation: networking: dsa: Update tagging protocols

2016-11-07 Thread David Miller
From: Fabian Mewes Date: Fri, 4 Nov 2016 13:16:14 +0100 > Add Qualcomm QCA tagging introduced in cafdc45c9 to the > list of supported protocols. > > Signed-off-by: Fabian Mewes Applied.

Re: [PATCH net-next v3] cadence: Add LSO support.

2016-11-07 Thread David Miller
From: Rafal Ozieblo Date: Fri, 4 Nov 2016 11:40:18 + > + if (IPPROTO_UDP == (((struct iphdr > *)skb_network_header(skb))->protocol)) This is simply "ip_hdr(skb)->protocol", please use it everywhere you have this ugly cast thing in this change. Thanks.

Re: [PATCH] virtio-net: drop legacy features in virtio 1 mode

2016-11-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 4 Nov 2016 12:55:36 +0200 > Virtio 1.0 spec says VIRTIO_F_ANY_LAYOUT and VIRTIO_NET_F_GSO are > legacy-only feature bits. Do not negotiate them in virtio 1 mode. Note > this is a spec violation so we need to backport it to stable/downstream > kernels. > > C

Re: [PATCH net 1/1] driver: macvlan: Destroy new macvlan port if macvlan_common_newlink failed.

2016-11-07 Thread David Miller
From: f...@ikuai8.com Date: Fri, 4 Nov 2016 10:28:49 +0800 > From: Gao Feng > > When there is no existing macvlan port in lowdev, one new macvlan port > would be created. But it doesn't be destoried when something failed later. > It casues some memleak. > > Now add one flag to indicate if new

Re: [PATCH] net: icmp6_send should use dst dev to determine L3 domain

2016-11-07 Thread David Miller
From: David Ahern Date: Thu, 3 Nov 2016 16:17:26 -0700 > icmp6_send is called in response to some event. The skb may not have > the device set (skb->dev is NULL), but it is expected to have a dst set. > Update icmp6_send to use the dst on the skb to determine L3 domain. > > Fixes: ca254490c8dfd

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-07 Thread David Miller
From: Soheil Hassas Yeganeh Date: Thu, 3 Nov 2016 18:24:27 -0400 > From: Soheil Hassas Yeganeh > > Do not set sk_err when dequeuing errors from the error queue. > Doing so results in: > a) Bugs: By overwriting existing sk_err values, it possibly >hides legitimate errors. It is also incorre

linux-next: manual merge of the net-next tree with the net tree

2016-11-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/netlink/genetlink.c between commit: 00ffc1ba02d8 ("genetlink: fix a memory leak on error path") from the net tree and commit: 2ae0f17df1cd ("genetlink: use idr to track families") from the net-next tree. I fi

Re: [PATCH] vxlan: hide unused local variable

2016-11-07 Thread David Miller
From: Pravin Shelar Date: Mon, 7 Nov 2016 16:25:54 -0800 > On Mon, Nov 7, 2016 at 2:21 PM, Arnd Bergmann wrote: >> On Monday, November 7, 2016 2:16:30 PM CET Pravin Shelar wrote: >>> On Monday, November 7, 2016, Arnd Bergmann wrote: >>> >>> > A bugfix introduced a harmless warning in v4.9-rc4:

RE: [PATCH] igb/e1000: correct register comments

2016-11-07 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Cao jin > Sent: Wednesday, November 2, 2016 12:20 AM > To: linux-ker...@vger.kernel.org; netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > > Subject: [PATCH] igb/e1000: corr

Re: [net-next PATCH 0/3] qdisc and tx_queue_len cleanups for IFF_NO_QUEUE devices

2016-11-07 Thread David Miller
From: Jesper Dangaard Brouer Date: Thu, 03 Nov 2016 14:55:56 +0100 > This patchset is a cleanup for IFF_NO_QUEUE devices. It will > hopefully help userspace get a more consistent behavior when attaching > qdisc to such virtual devices. Series applied, thanks Jesper.

Re: [PATCH] igmp: Make igmp group member RFC 3376 compliant

2016-11-07 Thread David Miller
From: Michal Tesar Date: Thu, 3 Nov 2016 10:38:34 +0100 > 2. If the received Query is a General Query, the interface timer is > used to schedule a response to the General Query after the > selected delay. Any previously pending response to a General > Query is canceled. > --8<-- >

Why are IPv6 host and anycast routes referencing lo device?

2016-11-07 Thread David Ahern
Can anyone explain why host routes and anycast routes for IPv6 are added with the device set to loopback versus the device with the address: local ::1 dev lo proto none metric 0 pref medium local 2000:1:: dev lo proto none metric 0 pref medium local 2000:1::3 dev lo proto none metric 0

Re: [PATCH] vxlan: hide unused local variable

2016-11-07 Thread Pravin Shelar
On Mon, Nov 7, 2016 at 2:21 PM, Arnd Bergmann wrote: > On Monday, November 7, 2016 2:16:30 PM CET Pravin Shelar wrote: >> On Monday, November 7, 2016, Arnd Bergmann wrote: >> >> > A bugfix introduced a harmless warning in v4.9-rc4: >> > >> > drivers/net/vxlan.c: In function 'vxlan_group_used': >>

RE: [PATCH] igb: Workaround for igb i210 firmware issue.

2016-11-07 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Chris J Arges > Sent: Wednesday, November 2, 2016 7:14 AM > To: j...@henneberg-systemdesign.com > Cc: intel-wired-...@lists.osuosl.org; Chris J Arges > ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; linux-

RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Madalin-Cristian Bucur
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 07, 2016 6:40 PM > > From: Madalin-Cristian Bucur > Date: Mon, 7 Nov 2016 16:32:16 + > > >> From: David Miller [mailto:da...@davemloft.net] > >> Sent: Monday, November 07, 2016 5:55 PM > >> > >> From: Madalin-Cristian

Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Josh Triplett
On Mon, Nov 07, 2016 at 05:41:38PM -0500, Nicolas Pitre wrote: > On Mon, 7 Nov 2016, Josh Triplett wrote: > > > [snipping large patch] > > > > One suggestion that might make this patch easier to review: you might > > consider first regenerating the unchanged parser with Bison 3.0.4, then > > rege

Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-07 Thread Stephen Suryaputra Lin
I did the temporary clearing/restoring rt_gateway following the deleted function check_peer_redir(). But, looking again at the function the assigning of peer->redirect_learned.a4 to rt_gateway can be permanent because restoring to the old_gw only happens on errors. I have updated the patch to use

Re: net/l2tp: use-after-free write in l2tp_ip6_close

2016-11-07 Thread Cong Wang
On Mon, Nov 7, 2016 at 2:35 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > == > BUG: KASAN: use-after-free in l2tp_ip6_close+0x239/0x2a0 at addr > 8800677276d8 > W

[PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-07 Thread Chris Roth
From: Allan Chou Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to Gigabit

[PATCH net,v2] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-07 Thread Stephen Suryaputra Lin
ICMP redirects behavior is different after the commit above. An email requesting the explanation on why the behavior needs to be different was sent earlier to netdev (https://patchwork.ozlabs.org/patch/687728/). Since there isn't a reply yet, I decided to prepare this formal patch. In v2.6 kernel,

net/l2tp: use-after-free write in l2tp_ip6_close

2016-11-07 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: == BUG: KASAN: use-after-free in l2tp_ip6_close+0x239/0x2a0 at addr 8800677276d8 Write of size 8 by task a.out/8668 CPU: 0 PID: 8668 Comm: a.out Not tain

Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Nicolas Pitre
On Mon, 7 Nov 2016, Josh Triplett wrote: > [snipping large patch] > > One suggestion that might make this patch easier to review: you might > consider first regenerating the unchanged parser with Bison 3.0.4, then > regenerating it again after the "imply" change. I think that'd > eliminate quite

Re: [PATCH v3 0/4] make POSIX timers optional with some Kconfig help

2016-11-07 Thread Nicolas Pitre
On Mon, 7 Nov 2016, Nicolas Pitre wrote: > Many embedded systems don't need the full POSIX timer support. > Configuring them out provides a nice kernel image size reduction. > > When POSIX timers are configured out, the PTP clock subsystem should be > left out as well. However a bunch of ethernet

Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Josh Triplett
[snipping large patch] One suggestion that might make this patch easier to review: you might consider first regenerating the unchanged parser with Bison 3.0.4, then regenerating it again after the "imply" change. I think that'd eliminate quite a lot of noise in this patch. - Josh Triplett

[PATCH] rtnl: reset calcit fptr in rtnl_unregister()

2016-11-07 Thread Mathias Krause
To avoid having dangling function pointers left behind, reset calcit in rtnl_unregister(), too. This is no issue so far, as only the rtnl core registers a netlink handler with a calcit hook which won't be unregistered, but may become one if new code makes use of the calcit hook. Fixes: c7ac8679be

Re: [PATCH] vxlan: hide unused local variable

2016-11-07 Thread Arnd Bergmann
On Monday, November 7, 2016 2:16:30 PM CET Pravin Shelar wrote: > On Monday, November 7, 2016, Arnd Bergmann wrote: > > > A bugfix introduced a harmless warning in v4.9-rc4: > > > > drivers/net/vxlan.c: In function 'vxlan_group_used': > > drivers/net/vxlan.c:947:21: error: unused variable 'sock6'

[PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Nicolas Pitre
Signed-off-by: Nicolas Pitre --- scripts/kconfig/zconf.hash.c_shipped | 30 +- scripts/kconfig/zconf.tab.c_shipped | 1581 -- 2 files changed, 753 insertions(+), 858 deletions(-) diff --git a/scripts/kconfig/zconf.hash.c_shipped b/scripts/kconfig/zconf.hash.c_

[PATCH v3 4/4] posix-timers: make it configurable

2016-11-07 Thread Nicolas Pitre
Some embedded systems have no use for them. This removes about 22KB from the kernel binary size when configured out. Corresponding syscalls are routed to a stub logging the attempt to use those syscalls which should be enough of a clue if they were disabled without proper consideration. They are:

[PATCH v3 3/4] ptp_clock: allow for it to be optional

2016-11-07 Thread Nicolas Pitre
In order to break the hard dependency between the PTP clock subsystem and ethernet drivers capable of being clock providers, this patch provides simple PTP stub functions to allow linkage of those drivers into the kernel even when the PTP subsystem is configured out. Drivers must be ready to accept

[PATCH v3 1/4] kconfig: introduce the "imply" keyword

2016-11-07 Thread Nicolas Pitre
The "imply" keyword is a weak version of "select" where the target config symbol can still be turned off, avoiding those pitfalls that come with the "select" keyword. This is useful e.g. with multiple drivers that want to indicate their ability to hook into a secondary subsystem while allowing the

[PATCH v3 0/4] make POSIX timers optional with some Kconfig help

2016-11-07 Thread Nicolas Pitre
Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* the later in their Kconf

net/sctp: null-ptr-deref in sctp_inet_listen

2016-11-07 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in: CPU: 1 PID: 3851 Comm: a.out Not tainted 4.9.0-rc4+ #3

Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-11-07 Thread Arnd Bergmann
On Monday, October 31, 2016 9:35:33 AM CET Y.B. Lu wrote: > > > > I don't see any of the contents of this header referenced by the soc > > driver any more. I think you can just drop this patch. > > > > [Lu Yangbo-B47093] This header file was included by guts.c. > The guts driver used macro SVR_M

[PATCH] vxlan: hide unused local variable

2016-11-07 Thread Arnd Bergmann
A bugfix introduced a harmless warning in v4.9-rc4: drivers/net/vxlan.c: In function 'vxlan_group_used': drivers/net/vxlan.c:947:21: error: unused variable 'sock6' [-Werror=unused-variable] This hides the variable inside of the same #ifdef that is around its user. The extraneous initialization i

[PATCH net-next v2 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-07 Thread Asbjoern Sloth Toennesen
These assignments follow this pattern: unsigned int foo:1; struct nlattr *nla = info->attrs[bar]; if (nla) foo = nla_get_flag(nla); /* expands to: foo = !!nla */ This could be simplified to: if (nla) foo = 1; but lets just remove the condition and use the

[PATCH net-next v2 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-07 Thread Asbjoern Sloth Toennesen
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_core.c | 2 +- net/l2tp/l2tp_ppp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index a

[PATCH net-next v2 2/5] net: l2tp: only set L2TP_ATTR_UDP_CSUM if AF_INET

2016-11-07 Thread Asbjoern Sloth Toennesen
Only set L2TP_ATTR_UDP_CSUM in l2tp_nl_tunnel_send() when it's running over IPv4. This prepares the code to also have IPv6 specific attributes. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/l2

[PATCH net-next v2 1/5] net: l2tp: change L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-07 Thread Asbjoern Sloth Toennesen
The attributes L2TP_ATTR_UDP_ZERO_CSUM6_RX and L2TP_ATTR_UDP_ZERO_CSUM6_TX are used as flags, but is defined as a u8 in a comment. This patch redocuments them as flags. Adding nla_policy entries would break API, so not doing that. CC: Tom Herbert Signed-off-by: Asbjoern Sloth Toennesen --- in

Re: [PATCH net-next 1/5] net: l2tp: fix L2TP_ATTR_UDP_CSUM attribute type

2016-11-07 Thread Asbjørn Sloth Tønnesen
Hi David, Thanks for the review. On Mon, 07 Nov 2016 13:08:45 -0500 (EST), David Miller wrote: > From: Asbjoern Sloth Toennesen > Date: Fri, 4 Nov 2016 22:48:34 + > > > L2TP_ATTR_UDP_CSUM is a flag, and gets read with > > nla_get_flag, but it is defined as NLA_U8 in > > the nla_policy. >

[PATCH net-next v2 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-07 Thread Asbjoern Sloth Toennesen
This patch causes the proper attribute flags to be set, in the case that IPv6 UDP checksums are disabled, so that userspace ie. `ip l2tp show tunnel` knows about it. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH net] ibmvnic: Start completion queue negotiation at server-provided optimum values

2016-11-07 Thread John Allen
Use the opt_* fields to determine the starting point for negotiating the number of tx/rx completion queues with the vnic server. These contain the number of queues that the vnic server estimates that it will be able to allocate. While renegotiation may still occur, using the opt_* fields will reduc

Re: [net-next PATCH 0/3] qdisc and tx_queue_len cleanups for IFF_NO_QUEUE devices

2016-11-07 Thread Jesper Dangaard Brouer
On Mon, 07 Nov 2016 13:13:44 -0500 (EST) David Miller wrote: > From: Jesper Dangaard Brouer > Date: Thu, 03 Nov 2016 14:55:56 +0100 > > > This patchset is a cleanup for IFF_NO_QUEUE devices. It will > > hopefully help userspace get a more consistent behavior when attaching > > qdisc to such vi

[PATCH v2] net: icmp_route_lookup should use rt dev to determine L3 domain

2016-11-07 Thread David Ahern
icmp_send is called in response to some event. The skb may not have the device set (skb->dev is NULL), but it is expected to have an rt. Update icmp_route_lookup to use the rt on the skb to determine L3 domain. Fixes: 613d09b30f8b ("net: Use VRF device index for lookups on TX") Signed-off-by: Davi

Re: [PATCH] net-ipv6: on device mtu change do not add mtu to mtu-less routes

2016-11-07 Thread Hannes Frederic Sowa
On 04.11.2016 22:51, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Routes can specify an mtu explicitly or inherit the mtu from > the underlying device - this inheritance is implemented in > dst->ops->mtu handlers ip6_mtu() and ip6_blackhole_mtu(). > > Currently changing the mtu of

net/tcp: warning in tcp_recvmsg

2016-11-07 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: [ cut here ] WARNING: CPU: 1 PID: 9957 at net/ipv4/tcp.c:1766 tcp_recvmsg+0x19d7/0x26e0 net/ipv4/tcp.c:1765 Modules linked in: CPU: 1 PID: 9957 Comm: syz-executor Not tainted 4.9.0-rc4+ #352 Hardwa

[PATCH net-next] net-gro: avoid reorders

2016-11-07 Thread Eric Dumazet
From: Eric Dumazet Receiving a GSO packet in dev_gro_receive() is not uncommon in stacked devices, or devices partially implementing LRO/GRO like bnx2x. GRO is implementing the aggregation the device was not able to do itself. Current code causes reorders, like in following case : For a given f

Re: [Intel-wired-lan] [PATCH] igb: drop field "tail" of struct igb_ring

2016-11-07 Thread Alexander Duyck
On Mon, Nov 7, 2016 at 4:44 AM, Cao jin wrote: > Under certain condition, I find guest will oops on writel() in > igb_configure_tx_ring(), because hw->hw_address is NULL. While other > register access won't oops kernel because they use wr32/rd32 which have > a defense against NULL pointer. The oop

Re: [PATCH 7/8] tools lib bpf: fix maps resolution

2016-11-07 Thread Eric Leblond
Hi, On Tue, 2016-11-08 at 02:23 +0800, Wangnan (F) wrote: > Hi Eric, > > Are you still working in this patch set? Sorry to lag on this, I've been taken by a series of other projects. I did not yet reworked it yet but I was planning to do a bit on it this week. > > Now I know why maps section i

Re: [PATCH 7/8] tools lib bpf: fix maps resolution

2016-11-07 Thread Wangnan (F)
Hi Eric, Are you still working in this patch set? Now I know why maps section is not a simple array from a patch set from Joe Stringer: https://www.mail-archive.com/netdev@vger.kernel.org/msg135088.html So I think this patch is really useful. Are you going to resend the whole patch set? If no

Re: [PATCH net-next 0/2] udp: do fwd memory scheduling on dequeue

2016-11-07 Thread David Miller
From: Paolo Abeni Date: Fri, 4 Nov 2016 11:28:57 +0100 > After commit 850cbaddb52d ("udp: use it's own memory accounting schema"), > the udp code needs to acquire twice the receive queue spinlock on dequeue. > > This patch series remove the need for the second lock at skb free time, > moving th

Re: [PATCH net] bpf: fix map not being uncharged during map creation failure

2016-11-07 Thread David Miller
From: Daniel Borkmann Date: Fri, 4 Nov 2016 00:56:31 +0100 > In map_create(), we first find and create the map, then once that > suceeded, we charge it to the user's RLIMIT_MEMLOCK, and then fetch > a new anon fd through anon_inode_getfd(). The problem is, once the > latter fails f.e. due to RLI

Re: [PATCH net v2 0/4] net: fix device reference leaks

2016-11-07 Thread David Miller
From: Johan Hovold Date: Thu, 3 Nov 2016 18:40:18 +0100 > This series fixes a number of device reference leaks (and one of_node > leak) due to failure to drop the references taken by bus_find_device() > and friends. > > Note that the final two patches have been compile tested only. ... > v2 >

Re: [PATCH net] bpf: fix htab map destruction when extra reserve is in use

2016-11-07 Thread David Miller
From: Daniel Borkmann Date: Fri, 4 Nov 2016 00:01:19 +0100 > Commit a6ed3ea65d98 ("bpf: restore behavior of bpf_map_update_elem") > added an extra per-cpu reserve to the hash table map to restore old > behaviour from pre prealloc times. When non-prealloc is in use for a > map, then problem is th

Re: [PATCH net-next 0/2] sfc: enable 4-tuple UDP RSS hashing

2016-11-07 Thread David Miller
From: Edward Cree Date: Thu, 3 Nov 2016 22:10:31 + > EF10 based NICs have configurable RSS hash fields, and can be made to take the > ports into the hash on UDP (they already do so for TCP). This patch series > enables this, in order to improve spreading of UDP traffic. What does the chip d

Re: [PATCH net] sctp: assign assoc_id earlier in __sctp_connect

2016-11-07 Thread David Miller
From: Marcelo Ricardo Leitner Date: Thu, 3 Nov 2016 17:03:41 -0200 > sctp_wait_for_connect() currently already holds the asoc to keep it > alive during the sleep, in case another thread release it. But Andrey > Konovalov and Dmitry Vyukov reported an use-after-free in such > situation. > > Prob

Re: [PATCH] net: icmp_route_lookup should use rt dev to determine L3 domain

2016-11-07 Thread David Miller
From: David Ahern Date: Thu, 3 Nov 2016 10:13:39 -0700 > icmp_send is called in response to some event. The skb may not have > the device set (skb->dev is NULL), but it is expected to have an rt. > Update icmp_route_lookup to use the rt on the skb to determine L3 > domain. > > Fixes: 613d09b30f

Re: [PATCH net-next] net: Update raw socket bind to consider l3 domain

2016-11-07 Thread David Miller
From: David Ahern Date: Thu, 3 Nov 2016 09:25:00 -0700 > Binding a raw socket to a local address fails if the socket is bound > to an L3 domain: > > $ vrf-test -s -l 10.100.1.2 -R -I red > error binding socket: 99: Cannot assign requested address > > Update raw_bind to look consider i

Re: [net-next PATCH 0/3] qdisc and tx_queue_len cleanups for IFF_NO_QUEUE devices

2016-11-07 Thread David Miller
From: Jesper Dangaard Brouer Date: Thu, 03 Nov 2016 14:55:56 +0100 > This patchset is a cleanup for IFF_NO_QUEUE devices. It will > hopefully help userspace get a more consistent behavior when attaching > qdisc to such virtual devices. I'm still thinking about this. My reservation about this i

Re: [PATCH v6 0/7] add NS2 support to bgmac

2016-11-07 Thread David Miller
From: Jon Mason Date: Fri, 4 Nov 2016 01:10:55 -0400 > Changes in v6: > * Use a common bgmac_phy_connect_direct (per Rafal Milecki) > * Rebased on latest net-next > * Added Reviewed-by to the relevant patches > > > Changes in v5: > * Change a pr_err to netdev_err (per Scott Branden) > * Rewor

Re: [PATCH net-next 1/5] net: l2tp: fix L2TP_ATTR_UDP_CSUM attribute type

2016-11-07 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Fri, 4 Nov 2016 22:48:34 + > L2TP_ATTR_UDP_CSUM is a flag, and gets read with > nla_get_flag, but it is defined as NLA_U8 in > the nla_policy. > > It appears that this is only publicly used in > iproute2, where it's broken, because it's used as > a NLA_F

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-11-07 Thread Martin Blumenstingl
Hi Peppe, On Mon, Nov 7, 2016 at 11:59 AM, Giuseppe CAVALLARO wrote: > In the meantime, I will read again the thread just to see if > there is something I am missing. if you are re-reading this thread: please note that there are two devices in discussion here! Both are using the Amlogic S905 (GXB

Re: [lkp] [net] af1fee9821: BUG:spinlock_trylock_failure_on_UP_on_CPU

2016-11-07 Thread Andrew Lunn
On Mon, Nov 07, 2016 at 02:27:14PM +0100, Allan W. Nielsen wrote: > Hi, > > I tried to get this "lkp" up and running, but I had some troubles gettting > these scripts to work. > > But it seems like it can be reproduced using th eprovided config file, and > qemu. > > Here is what I did: > > # r

[PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames

2016-11-07 Thread Timur Tabi
Pause frames are used to enable flow control. A MAC can send and receive pause frames in order to throttle traffic. However, the PHY must be configured to allow those frames to pass through. Reviewed-by: Florian Fainelli Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-ma

[PATCH 2/2] [v2] net: qcom/emac: enable flow control if requested

2016-11-07 Thread Timur Tabi
If the PHY has been configured to allow pause frames, then the MAC should be configured to generate and/or accept those frames. Signed-off-by: Timur Tabi --- v2: fix calculation when TXFC should be set drivers/net/ethernet/qualcomm/emac/emac-mac.c | 9 + 1 file changed, 5 insertions(+)

[PATCH 0/2] net: qcom/emac: ensure that pause frames are enabled

2016-11-07 Thread Timur Tabi
The qcom emac driver experiences significant packet loss (through frame check sequence errors) if flow control is not enabled and the phy is not configured to allow pause frames to pass through it. Therefore, we need to enable flow control and force the phy to pass pause frames. Timur Tabi (2):

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread David Miller
From: Madalin-Cristian Bucur Date: Mon, 7 Nov 2016 16:32:16 + >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Monday, November 07, 2016 5:55 PM >> >> From: Madalin-Cristian Bucur >> Date: Mon, 7 Nov 2016 15:43:26 + >> >> >> From: David Miller [

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Joakim Tjernlund
On Wed, 2016-11-02 at 22:17 +0200, Madalin Bucur wrote: > This introduces the Freescale Data Path Acceleration Architecture > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > the Freescale DPAA QorIQ platforms. Ni

Re: [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause

2016-11-07 Thread Timur Tabi
On 11/01/2016 01:35 PM, Florian Fainelli wrote: So in premise, this is good, and is exactly what I have in mind for the series that I am cooking, but if we apply this alone, without a change in drivers/net/phy/phy.c which adds SUPPORTED_Pause | SUPPORTED_AsymPause to phydev->features, we are basi

Re: [PATCH 00/12] xen: add common function for reading optional value

2016-11-07 Thread Jarkko Sakkinen
On Mon, Nov 07, 2016 at 11:08:09AM +, David Vrabel wrote: > On 31/10/16 16:48, Juergen Gross wrote: > > There are multiple instances of code reading an optional unsigned > > parameter from Xenstore via xenbus_scanf(). Instead of repeating the > > same code over and over add a service function d

Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-07 Thread David Miller
From: Eric Dumazet Date: Mon, 07 Nov 2016 08:08:52 -0800 > In any case, rt is a shared object at that time, so even temporarily > clearing/restoring rt_gateway seems wrong to me. > > I would rather call __ipv4_neigh_lookup(dst->dev, new_gw) directly at > this point. Agreed.

Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-07 Thread Eric Dumazet
On Mon, 2016-11-07 at 10:04 -0500, Stephen Suryaputra Lin wrote: > ICMP redirects behavior is different after the commit above. An email > requesting the explanation on why the behavior needs to be different > was sent earlier to netdev (https://patchwork.ozlabs.org/patch/687728/). > Since there is

Re: [net PATCH] fib_trie: Correct /proc/net/route off by one error

2016-11-07 Thread Jason Baron
On 11/04/2016 03:11 PM, Alexander Duyck wrote: The display of /proc/net/route has had a couple issues due to the fact that when I originally rewrote most of fib_trie I made it so that the iterator was tracking the next value to use instead of the current. In addition it had an off by 1 error w

RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Madalin-Cristian Bucur
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, November 03, 2016 9:58 PM > > From: Madalin Bucur > Date: Wed, 2 Nov 2016 22:17:26 +0200 > > > This introduces the Freescale Data Path Acceleration Architecture > > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) >

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread David Miller
From: Madalin-Cristian Bucur Date: Mon, 7 Nov 2016 15:43:26 + >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Thursday, November 03, 2016 9:58 PM >> >> Why? By clearing this, you disallow an important fundamental way to do >> performane testing, via pktgen. > > The Tx path in D

Re: [PATCH net-next 06/11] net: l3mdev: remove redundant calls

2016-11-07 Thread David Ahern
On 11/7/16 3:13 AM, Lorenzo Colitti wrote: > What should we do here? It would seem that now that > netif_index_is_l3_master has been resurrected, it's appropriate to use > it here as well. The user-visible behaviour changed only two months > ago. Unless we think that RSTs should always mirror the i

[PATCH] net/netfilter: Fix use uninitialized warn in nft_range_eval()

2016-11-07 Thread Shuah Khan
Fix the following warn: CC [M] net/netfilter/nft_range.o 8601,8605c9105 net/netfilter/nft_range.c: In function ‘nft_range_eval’: net/netfilter/nft_range.c:45:5: warning: ‘mismatch’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (mismatch) ^ Signed-off-by: Sh

[PATCH/RFC net-next] ravb: Add dma_unmap_single in ravb_ring_free

2016-11-07 Thread Simon Horman
From: Kazuya Mizuguchi The kernel panic occurs with "swiotlb buffer is full" message after repeating suspend and resume, because dma_map_single of ravb_ring_format and ravb_start_xmit is not released. This patch adds dma_unmap_single in ravb_ring_free, and fixes its problem. Signed-off-by: Kazuy

[PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-07 Thread Stephen Suryaputra Lin
ICMP redirects behavior is different after the commit above. An email requesting the explanation on why the behavior needs to be different was sent earlier to netdev (https://patchwork.ozlabs.org/patch/687728/). Since there isn't a reply yet, I decided to prepare this formal patch. In v2.6 kernel,

  1   2   >