Re: Funding Approved In Minutes!

2016-10-17 Thread ottow
Good Day, Financing shouldn't be a mystery for you, contact us for help today. Easy Funding Service is here to help you solve out all your outstanding debts and be free for good..We have come to conclusion that its high time a person can buy his own house, good cars, established good business,

[PATCH] vlan: Remove unnecessary comparison of unsigned against 0

2016-10-17 Thread Tobias Klauser
args.u.name_type is of type unsigned int and is always >= 0. This fixes the following GCC warning: net/8021q/vlan.c: In function ‘vlan_ioctl_handler’: net/8021q/vlan.c:574:14: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-off-by: Tobias Klauser ---

Re: [PATCH net] bnx2: fix locking when netconsole is used

2016-10-17 Thread Ivan Vecera
Dne 17.10.2016 v 19:21 David Miller napsal(a): From: Ivan Vecera Date: Mon, 17 Oct 2016 18:20:31 +0200 diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index 27f11a5..9c408413 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b/drivers/net/ethernet/

[PATCH net v2] bnx2: fix locking when netconsole is used

2016-10-17 Thread Ivan Vecera
Functions bnx2_reg_rd_ind(), bnx2_reg_wr_ind() and bnx2_ctx_wr() can be called with IRQs disabled when netconsole is enabled. So they should use spin_{,un}lock_irq{save,restore} instead of _bh variants. Example call flow: bnx2_poll() ->bnx2_poll_link() ->bnx2_phy_int() ->bnx2_set_remot

Re: [PATCH 00/28] Reenable maybe-uninitialized warnings

2016-10-17 Thread Christoph Hellwig
On Tue, Oct 18, 2016 at 12:03:28AM +0200, Arnd Bergmann wrote: > This is a set of patches that I hope to get into v4.9 in some form > in order to turn on the -Wmaybe-uninitialized warnings again. Hi Arnd, I jsut complained to Geert that I was introducing way to many bugs or pointless warnings for

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Roopa Prabhu
On 10/17/16, 5:17 PM, Roopa Prabhu wrote: > On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: [snip] inline below more data/context.. + +struct sample_packet_metadata { +int sample_size; +int orig_size; +int ifindex; +}; + >>> This metadata does not look

Useless debug warning "netlink: 16 bytes leftover after parsing attributes"

2016-10-17 Thread Marcel Holtmann
Hi, so lately I am seeing a bunch of these warnings: netlink: 16 bytes leftover after parsing attributes.. While they give you the process name, they are still useless to track down the message that causes them. I find them even more useless since an updated userspace on an older kernel can tr

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-17 Thread Tom Herbert
On Mon, Oct 17, 2016 at 8:35 PM, Lawrence Brakmo wrote: > Yuchung and Eric, thank you for your comments. > > It looks like I need to think more about this patch. I was trying > to reduce the likelihood of reordering (which seems even more > important based on Eric¹s comment on pacing), but it seem

[PATCH net-next] r8152: add new products of Lenovo

2016-10-17 Thread Hayes Wang
Add the following four products of Lenovo and sort the order of the list. VID PID 0x17ef 0x3062 0x17ef 0x3069 0x17ef 0x720c 0x17ef 0x7214 Signed-off-by: Hayes Wang --- drivers/net/usb/cdc_ether.c | 28 ++

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-17 Thread Lawrence Brakmo
Yuchung and Eric, thank you for your comments. It looks like I need to think more about this patch. I was trying to reduce the likelihood of reordering (which seems even more important based on Eric¹s comment on pacing), but it seems like the only way to prevent reordering is to only re-hash after

[PATCH net-next 06/11] ixgbe: Flip to the new dev walk API

2016-10-17 Thread David Ahern
Convert ixgbe users to new dev walk API. This is just a code conversion; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 132 -- 1 file changed, 82 insertions(+), 50 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 10/11] net: Add warning if any lower device is still in adjacency list

2016-10-17 Thread David Ahern
Lower list should be empty just like upper. Signed-off-by: David Ahern --- net/core/dev.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index a9fe14908b44..c6bbf310d407 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5219,6 +5219,20 @@

[PATCH net-next 11/11] net: dev: Improve debug statements for adjacency tracking

2016-10-17 Thread David Ahern
Adjacency code only has debugs for the insert case. Add debugs for the remove path and make both consistently worded to make it easier to follow the insert and removal with reference counts. In addition, change the BUG to a WARN_ON. A missing adjacency at removal time is not cause for a panic. Si

[PATCH net-next 04/11] IB/core: Flip to the new dev walk API

2016-10-17 Thread David Ahern
Convert rdma_is_upper_dev_rcu, handle_netdev_upper and ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern --- drivers/infiniband/core/core_priv.h | 9 +

[PATCH net-next 05/11] IB/ipoib: Flip to new dev walk API

2016-10-17 Thread David Ahern
Convert ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 37 +-- 1 file changed, 2

[PATCH net-next 07/11] mlxsw: Flip to the new dev walk API

2016-10-17 Thread David Ahern
Convert mlxsw users to new dev walk API. This is just a code conversion; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 37 -- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 08/11] rocker: Flip to the new dev walk API

2016-10-17 Thread David Ahern
Convert rocker to the new dev walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern --- drivers/net/ethernet/rocker/rocker_main.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-)

[PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-17 Thread David Ahern
This patch introduces netdev_walk_all_upper_dev_rcu, netdev_walk_all_lower_dev and netdev_walk_all_lower_dev_rcu. These functions recursively walk the adj_list of devices to determine all upper and lower devices. The functions take a callback function that is invoked for each device in the list. I

[PATCH net-next 03/11] net: bonding: Flip to the new dev walk API

2016-10-17 Thread David Ahern
Convert alb_send_learning_packets and bond_has_this_ip to use the new netdev_walk_all_upper_dev_rcu API. In both cases this is just a code conversion; no functional change is intended. v2 - removed typecast of data and simplified bond_upper_dev_walk Signed-off-by: David Ahern --- drivers/net/bo

[PATCH net-next 01/11] net: Remove refnr arg when inserting link adjacencies

2016-10-17 Thread David Ahern
Commit 93409033ae65 ("net: Add netdev all_adj_list refcnt propagation to fix panic") propagated the refnr to insert and remove functions tracking the netdev adjacency graph. However, for the insert path the refnr can only be 1. Accordingly, remove the refnr argument to make that clear. ie., the ref

[PATCH net-next 09/11] net: Remove all_adj_list and its references

2016-10-17 Thread David Ahern
Only direct adjacencies are maintained. All upper or lower devices can be learned via the new walk API which recursively walks the adj_list for upper devices or lower devices. Signed-off-by: David Ahern --- include/linux/netdevice.h | 25 -- net/core/dev.c| 223 -

[PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

2016-10-17 Thread David Ahern
The netdev adjacency tracking is failing to create proper dependencies for some topologies. For example this topology ++ | myvrf | ++ || | +-+ | | macvlan | | +-+ || +---

Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

2016-10-17 Thread Gao Feng
Hi David, On Tue, Oct 18, 2016 at 9:36 AM, David Miller wrote: > > It never makes sense to send the same patch for both net and net-next. > > If it's a bug fix, it goes to 'net'. And it will be eventually > be naturally merged into 'net-next'. > > Otherwise, if it's a new feature, cleanup, or op

Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

2016-10-17 Thread David Miller
It never makes sense to send the same patch for both net and net-next. If it's a bug fix, it goes to 'net'. And it will be eventually be naturally merged into 'net-next'. Otherwise, if it's a new feature, cleanup, or optimization it goes to 'net-next'.

Re: [PATCH 1/1] net: vlan: Use sizeof instead of literal number

2016-10-17 Thread Feng Gao
On Tue, Oct 18, 2016 at 8:44 AM, wrote: > From: Gao Feng > > Use sizeof variable instead of literal number to enhance the readability. > > Signed-off-by: Gao Feng > --- > net/8021q/vlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/

[PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

2016-10-17 Thread fgao
From: Gao Feng Use sizeof variable instead of literal number to enhance the readability. Signed-off-by: Gao Feng --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 8de138d..5a3903b 100644 --- a/net/8021q/vlan.c

[PATCH 1/1] net: vlan: Use sizeof instead of literal number

2016-10-17 Thread fgao
From: Gao Feng Use sizeof variable instead of literal number to enhance the readability. Signed-off-by: Gao Feng --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 8de138d..5a3903b 100644 --- a/net/8021q/vlan.c

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-17 Thread David Ahern
On 10/17/16 6:21 AM, Stephen Hemminger wrote: > > No if/else needed. No cast of void * ptr need. Use const if possible? > so much of the stack does not use const and trying to add it for this API does not work -- the upper or lower device is passed to the callbacks and those callbacks invoke o

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Roopa Prabhu
On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: > > Some comments: > IIUC, the main struggle seems to be whether the redirect to dummy0 > is useful or not? i.e instead of just letting the packets go up the > stack on eth1? yep, correct...given existing workflow for the non-offloaded case is to recei

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Jeff Kirsher
On Mon, 2016-10-17 at 18:47 -0400, Sowmini Varadhan wrote: > On (10/17/16 15:37), Jeff Kirsher wrote: > > > Reviewed-by: Alexander Duyck > >  > > Sowmini, can you re-submit this to intel-wired-lan but without the RFC > in > > the title? > > V4 resubmitted.. I think I just inadvertently forgot to

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
On (10/17/16 15:37), Jeff Kirsher wrote: > > Reviewed-by: Alexander Duyck > > Sowmini, can you re-submit this to intel-wired-lan but without the RFC in > the title? V4 resubmitted.. I think I just inadvertently forgot to add Alex as the reviewed-by.. could you please fix that (or I can resubmit

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Jeff Kirsher
On Mon, 2016-10-17 at 15:29 -0700, Alexander Duyck wrote: > On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan > wrote: > > > > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > > passed down an sk_buff that has the network and transport > > header in the paged data, so it needs to make

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Alexander Duyck
On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the headlen bytes to calculate the

[PATCH 28/28] Kbuild: bring back -Wmaybe-uninitialized warning

2016-10-17 Thread Arnd Bergmann
Traditionally, we have always had warnings about uninitialized variables enabled, as this is part of -Wall, and generally a good idea [1], but it also always produced false positives, mainly because this is a variation of the halting problem and provably impossible to get right in all cases [2]. V

[PATCH 27/28] rocker: fix maybe-uninitialized warning

2016-10-17 Thread Arnd Bergmann
In some rare configurations, we get a warning about the 'index' variable being used without an initialization: drivers/net/ethernet/rocker/rocker_ofdpa.c: In function ‘ofdpa_port_fib_ipv4.isra.16.constprop’: drivers/net/ethernet/rocker/rocker_ofdpa.c:2425:92: warning: ‘index’ may be used uniniti

[PATCH 21/28] net/hyperv: avoid uninitialized variable

2016-10-17 Thread Arnd Bergmann
The hdr_offset variable is only if we deal with a TCP or UDP packet, but as the check surrounding its usage tests for skb_is_gso() instead, the compiler has no idea if the variable is initialized or not at that point: drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_start_xmit’: drivers/net/hy

[PATCH 20/28] net: bcm63xx: avoid referencing uninitialized variable

2016-10-17 Thread Arnd Bergmann
gcc found a reference to an uninitialized variable in the error handling of bcm_enet_open, introduced by a recent cleanup: drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open' drivers/net/ethernet/broadcom/bcm63xx_enet.c:1129:2: warning: 'phydev' may be used uninitialized in

[PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

2016-10-17 Thread Arnd Bergmann
A bugfix added a sanity check around the assignment and use of the 'is_11d' variable, which looks correct to me, but as the function is rather complex already, this confuses the compiler to the point where it can no longer figure out if the variable is always initialized correctly: brcm80211/brcmf

[PATCH 01/28] [v2] netfilter: nf_tables: avoid uninitialized variable warning

2016-10-17 Thread Arnd Bergmann
The newly added nft_range_eval() function handles the two possible nft range operations, but as the compiler warning points out, any unexpected value would lead to the 'mismatch' variable being used without being initialized: net/netfilter/nft_range.c: In function 'nft_range_eval': net/netfilter/n

[PATCH 00/28] Reenable maybe-uninitialized warnings

2016-10-17 Thread Arnd Bergmann
This is a set of patches that I hope to get into v4.9 in some form in order to turn on the -Wmaybe-uninitialized warnings again. After talking to Linus in person at Linaro Connect about this, I spent some time on finding all the remaining warnings, and this is the resulting patch series. More deta

[PATCH net] soreuseport: do not export reuseport_add_sock()

2016-10-17 Thread Eric Dumazet
From: Eric Dumazet reuseport_add_sock() is not used from a module, no need to export it. Signed-off-by: Eric Dumazet --- net/core/sock_reuseport.c |1 - 1 file changed, 1 deletion(-) diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c index e92b759d906c..9a1a352fd1eb 100644

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
On (10/17/16 12:49), Alexander Duyck wrote: > >> > /* Currently only IPv4/IPv6 with TCP is supported */ > >> > switch (hdr.ipv4->version) { > >> > case IPVERSION: > >> > /* access ihl as u8 to avoid unaligned access on ia64 */ > >> > hlen = (h

[PATCH v3 RFC 0/2] ixgbe: ixgbe_atr() bug fixes

2016-10-17 Thread Sowmini Varadhan
Two bug fixes: - ixgbe_atr() should check for protocol == udp in the skb->encapsulation case (instead of !=) - ixgbe_atr() should make sure the non-paged data has the needed network/transport header for computing l4_proto. v3: Alex Duyck comments Sowmini Varadhan (2): ixgbe: ixgbe_atr() sho

[PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be passed down an sk_buff that has the network and transport header in the paged data, so it needs to make sure these headers are available in the headlen bytes to calculate the l4_proto. This patch expect that network and transport headers ar

[PATCH V3 RFC 1/2] ixgbe: ixgbe_atr() should access udp_hdr(skb) only for UDP packets

2016-10-17 Thread Sowmini Varadhan
Commit 9f12df906cd8 ("ixgbe: Store VXLAN port number in network order") incorrectly checks for hdr.ipv4->protocol != IPPROTO_UDP in ixgbe_atr(). This check should be for "==" instead. Signed-off-by: Sowmini Varadhan --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1

[PATCH 1/3 net v2] ibmvnic: Driver Version 1.0.1

2016-10-17 Thread Thomas Falcon
Increment driver version to reflect features that have been added since release. Signed-off-by: Thomas Falcon --- Sorry about the extra noise. v2: revise version format to be consistent with other IBM virtual drivers --- drivers/net/ethernet/ibm/ibmvnic.h | 2 +- 1 file changed, 1 insertion(+),

Re: Need help with mdiobus_register and phy

2016-10-17 Thread Timur Tabi
Zefir Kurtisi wrote: Anyway, since the SGMII reset is required, instead of reverting the patch in full I suggest to move the SGMII power down from at803x_suspend() and do a SerDes power cycle in at803x_resume(). Could you please test if the patch below fixes the problem? I have never seen th

Re: [PATCH net-next 2/2] bpf: add initial suite for selftests

2016-10-17 Thread Alexei Starovoitov
On Mon, Oct 17, 2016 at 02:28:36PM +0200, Daniel Borkmann wrote: > Add a start of a test suite for kernel selftests. This moves test_verifier > and test_maps over to tools/testing/selftests/bpf/ along with various > code improvements and also adds a script for invoking test_bpf module. > The test s

Re: [PATCH net-next 1/2] bpf: add various tests around spill/fill of regs

2016-10-17 Thread Alexei Starovoitov
On Mon, Oct 17, 2016 at 02:28:35PM +0200, Daniel Borkmann wrote: > Add several spill/fill tests. Besides others, one that performs xadd > on the spilled register, one ldx/stx test where different types are > spilled from two branches and read out from common path. Verfier does > handle all correctl

Re: [PATCH -next] net: wan: slic_ds26522: Remove .owner field for driver

2016-10-17 Thread Javier Martinez Canillas
Hello Wei, On 10/17/2016 11:51 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Remove .owner field if calls are used which set it automatically. > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: Wei Yongjun > --- > drivers/net/wan/slic_ds26522.c | 1 - >

Re: [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code

2016-10-17 Thread Javier Martinez Canillas
Hello Wei, On 10/17/2016 11:50 AM, Wei Yongjun wrote: > From: Wei Yongjun > > module_spi_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun > --- > drivers/net/wan/slic_ds26522.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote: > From: Jarod Wilson > Date: Mon, 17 Oct 2016 15:54:02 -0400 > > > For the most part, every patch does the same essential thing: removes the > > MTU range checking from the drivers' ndo_change_mtu function, puts those > > ranges into t

[PATCH net v2] flow_dissector: Check skb for VLAN only if skb specified.

2016-10-17 Thread Eric Garver
Fixes a panic when calling eth_get_headlen(). Noticed on i40e driver. Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") Signed-off-by: Eric Garver --- net/core/flow_dissector.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ne

[PATCH 2/3 net] ibmvnic: Fix GFP_KERNEL allocation in interrupt context

2016-10-17 Thread Thomas Falcon
Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index bfe17d9..928bf8a 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net

[PATCH 3/3 net] ibmvnic: Update MTU after device initialization

2016-10-17 Thread Thomas Falcon
It is possible for the MTU to be changed during the initialization process with the VNIC Server. Ensure that the net device is updated to reflect the new MTU. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e

[PATCH 1/3 net] ibmvnic: Driver Version 1.01

2016-10-17 Thread Thomas Falcon
Increment driver version to reflect features that have been added since release. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h index

[PATCH net] flow_dissector: Check skb for VLAN only if skb specified.

2016-10-17 Thread Eric Garver
From: Eric Garver Fixes a panic when calling eth_get_headlen(). Noticed on i40e driver. Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") Signed-off-by: Eric Garver --- net/core/flow_dissector.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

Re: [PATCH net] flow_dissector: Check skb for VLAN only if skb specified.

2016-10-17 Thread Eric Garver
On Mon, Oct 17, 2016 at 04:21:57PM -0400, Eric Garver wrote: > From: Eric Garver > > Fixes a panic when calling eth_get_headlen(). Noticed on i40e driver. > > Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from > skb->vlan_tci") > Signed-off-by: Eric Garver Oops. Messe

Re: [PATCH net-next 03/15] ethernet/intel: use core min/max MTU checking

2016-10-17 Thread Jakub Kicinski
Looks better, unfortunately, I can't test since net-next also seem to make nfs implode on my setup. On Mon, 17 Oct 2016 15:54:05 -0400, Jarod Wilson wrote: > @@ -7187,6 +7180,11 @@ static int e1000_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > netdev->vlan_feature

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jarod Wilson
On Mon, Oct 17, 2016 at 04:07:12PM -0400, Jarod Wilson wrote: > On Mon, Oct 17, 2016 at 01:25:53PM -0400, David Miller wrote: > > From: Jakub Kicinski > > Date: Mon, 17 Oct 2016 18:20:49 +0100 > > > > > Hm. I must be missing something really obvious. I just booted > > > net-next an hour ago and

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jarod Wilson
On Mon, Oct 17, 2016 at 01:25:53PM -0400, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 17 Oct 2016 18:20:49 +0100 > > > Hm. I must be missing something really obvious. I just booted > > net-next an hour ago and couldn't set MTU to anything larger than 1500 > > on either nfp or igb.

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-17 Thread David Miller
From: Jarod Wilson Date: Mon, 17 Oct 2016 15:54:02 -0400 > For the most part, every patch does the same essential thing: removes the > MTU range checking from the drivers' ndo_change_mtu function, puts those > ranges into the core net_device min_mtu and max_mtu fields, and where > possible, remov

[PATCH net-next 04/15] ethernet/marvell: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
mvneta: min_mtu 68, max_mtu 9676 - mtu validation routine mostly did range check, merge back into mvneta_change_mtu for simplicity mvpp2: min_mtu 68, max_mtu 9676 - mtu validation routine mostly did range check, merge back into mvpp2_change_mtu for simplicity pxa168_eth: min_mtu 68, max_mtu 9

[PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
Now that the network stack core min/max MTU checking infrastructure is in place, time to start making drivers use it. We'll start with the easiest ones, the ethernet drivers, split roughly by vendor, with a catch-all patch at the end. For the most part, every patch does the same essential thing: r

[PATCH net-next 03/15] ethernet/intel: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
e100: min_mtu 68, max_mtu 1500 - remove e100_change_mtu entirely, is identical to old eth_change_mtu, and no longer serves a purpose. No need to set min_mtu or max_mtu explicitly, as ether_setup() will already set them to 68 and 1500. e1000: min_mtu 46, max_mtu 16110 e1000e: min_mtu 68, max_m

[PATCH net-next 06/15] ethernet/qlogic: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
qede: min_mtu 46, max_mtu 9600 - Put define for max in qede.h qlcnic: min_mtu 68, max_mtu 9600 CC: netdev@vger.kernel.org CC dept-gelinuxnic...@qlogic.com CC: Yuval Mintz CC: Ariel Elior Signed-off-by: Jarod Wilson --- drivers/net/ethernet/qlogic/qede/qede.h | 5 +++-- drivers/net/et

[PATCH net-next 07/15] ethernet/realtek: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
8139cp: min_mtu 60, max_mtu 4096 8139too: min_mtu 68, max_mtu 1770 r8169: min_mtu 60, max_mtu depends on chipset, 1500 to 9k-ish CC: netdev@vger.kernel.org CC: Realtek linux nic maintainers Signed-off-by: Jarod Wilson --- drivers/net/ethernet/realtek/8139cp.c | 8 drivers/net/ether

[PATCH net-next 01/15] ethernet/atheros: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
atl2: min_mtu 40, max_mtu 1504 - Remove a few redundant defines that already have equivalents in if_ether.h. atl1: min_mtu 42, max_mtu 10218 atl1e: min_mtu 42, max_mtu 8170 atl1c: min_mtu 42, max_mtu 6122/1500 - GbE hardware gets a max_mtu of 6122, slower hardware gets 1500. alx: min_mtu 34

[PATCH net-next 02/15] ethernet/broadcom: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
tg3: min_mtu 60, max_mtu 9000/1500 bnxt: min_mtu 60, max_mtu 9000 bnx2x: min_mtu 46, max_mtu 9600 - Fix up ETH_OVREHEAD -> ETH_OVERHEAD while we're in here, remove duplicated defines from bnx2x_link.c. bnx2: min_mtu 46, max_mtu 9000 - Use more standard ETH_* defines while we're at it. bcm63xx

[PATCH net-next 05/15] ethernet/mellanox: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
mlx4: min_mtu 46, max_mtu depends on hardware mlx5: min_mtu 68, max_mtu depends on hardware CC: netdev@vger.kernel.org CC: Tariq Toukan CC: Saeed Mahameed Signed-off-by: Jarod Wilson --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 8 drivers/net/ethernet/mellanox/mlx5/core/e

[PATCH net-next 14/15] ethernet/toshiba: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
gelic_net: min_mtu 64, max_mtu 1518 - remove gelic_net_change_mtu now that it is redundant spidernet: min_Mtu 64, max_mtu 2294 - remove spiter_net_change_mtu now that it is redundant CC: netdev@vger.kernel.org CC: Geoff Levand CC: Ishizaki Kou Signed-off-by: Jarod Wilson --- drivers/net/ether

[PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware - Removed change_mtu, does nothing productive anymore sundance: min_mtu 68, max_mtu 8191 CC: netdev@vger.kernel.org CC: Denis Kirjanov Signed-off-by: Jarod Wilson --- drivers/net/ethernet/dlink/dl2k.c | 22 --

[PATCH net-next 08/15] ethernet/sun: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
cassini: min_mtu 60, max_mtu 9000 niu: min_mtu 68, max_mtu 9216 sungem: min_mtu 68, max_mtu 1500 (comments say jumbo mode is broken) sunvnet: min_mtu 68, max_mtu 65535 - removed sunvnet_change_mut_common as it does nothing now CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers

[PATCH net-next 12/15] ethernet/ibm: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
ehea: min_mtu 68, max_mtu 9022 - remove ehea_change_mtu, it's now redundant emac: min_mtu 46, max_mtu 1500 or whatever gets read from OF CC: netdev@vger.kernel.org CC: Douglas Miller Signed-off-by: Jarod Wilson --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 13 - drivers/net/ether

[PATCH net-next 15/15] ethernet: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
et131x: min_mtu 64, max_mtu 9216 altera_tse: min_mtu 64, max_mtu 1500 amd8111e: min_mtu 60, max_mtu 9000 bnad: min_mtu 46, max_mtu 9000 macb: min_mtu 68, max_mtu 1500 or 10240 depending on hardware capability xgmac: min_mtu 46, max_mtu 9000 cxgb2: min_mtu 68, max_mtu 9582 (pm3393) or 9600 (vs

[PATCH net-next 10/15] ethernet/neterion: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
s2io: min_mtu 46, max_mtu 9600 vxge: min_mtu 68, max_mtu 9600 CC: netdev@vger.kernel.org CC: Jon Mason Signed-off-by: Jarod Wilson --- drivers/net/ethernet/neterion/s2io.c | 9 - drivers/net/ethernet/neterion/vxge/vxge-config.h | 2 +- drivers/net/ethernet/neterion/vxge/vxg

[PATCH net-next 11/15] ethernet/cavium: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
liquidio: min_mtu 68, max_mtu 16000 thunder: min_mtu 64, max_mtu 9200 CC: netdev@vger.kernel.org CC: Sunil Goutham CC: Robert Richter CC: Derek Chickles CC: Satanand Burla CC: Felix Manlunas CC: Raghu Vatsavayi Signed-off-by: Jarod Wilson --- drivers/net/ethernet/cavium/liquidio/lio_main.

[PATCH net-next 13/15] ethernet/tile: use core min/max MTU checking

2016-10-17 Thread Jarod Wilson
tilegx: min_mtu 68, max_mtu 1500 or 9000, depending on modparam - remove tile_net_change_mtu now that it is fully redundant tilepro: min_mtu 68, max_mtu 1500 - hardware supports jumbo packets up to 10226, but it's not implemented or tested yet, according to code comments CC: netdev@vger.kernel.

[PATCH v3 3/4] net: smc91x: take into account half-word workaround

2016-10-17 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa-

[PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

2016-10-17 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree/bi

[PATCH v3 2/4] net: smc91x: isolate u16 writes alignment workaround

2016-10-17 Thread Robert Jarzmik
Writes to u16 has a special handling on 3 PXA platforms, where the hardware wiring forces these writes to be u32 aligned. This patch isolates this handling for PXA platforms as before, but enables this "workaround" to be set up dynamically, which will be the case in device-tree build types. This

[PATCH v3 1/4] ARM: pxa: enhance smc91x platform data

2016-10-17 Thread Robert Jarzmik
Instead of having the smc91x driver relying on machine_is_*() calls, provide this data through platform data, ie. idp, mainstone and stargate. This way, the driver doesn't need anymore machine_is_*() calls, which wouldn't work anymore with a device-tree build. Signed-off-by: Robert Jarzmik ---

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Alexander Duyck
On Mon, Oct 17, 2016 at 12:18 PM, Sowmini Varadhan wrote: > On (10/17/16 11:15), Alexander Duyck wrote: >> I would say you probably only need the first check here for skb->data >> and could probably skip the second part. You will be testing for >> skb_tail_pointer in all the other tests you added

[PATCH v3 0/4] support smc91x on mainstone and devicetree

2016-10-17 Thread Robert Jarzmik
This serie aims at bringing support to mainstone board on a device-tree based build, as what is already in place for legacy mainstone. The bulk of the mainstone "specific" behavior is that a u16 write doesn't work on a address of the form 4*n + 2, while it works on 4*n. The legacy workaround was

[PATCH v2 net-next 7/7] fou: Support flow dissection

2016-10-17 Thread Tom Herbert
This patch performs flow dissection for GUE and FOU. This is an optional feature on the receiver and is set by FOU_ATTR_DEEP_HASH netlink configuration. When enable the UDP socket flow_dissect function is set to fou_flow_dissect or gue_flow_dissect as appropriate. These functions return FLOW_DIS_RE

[PATCH v2 net-next 5/7] udp: Add UDP flow dissection functions to IPv4 and IPv6

2016-10-17 Thread Tom Herbert
Add per protocol offload callbacks for flow_dissect to UDP for IPv4 and IPv6. The callback functions extract the port number information and with the packet addresses (given in an argument with type flow_dissector_key_addrs) it performs a lookup on the UDP socket. If a socket is found and flow_diss

[PATCH v2 net-next 6/7] udp: UDP tunnel flow dissection infrastructure

2016-10-17 Thread Tom Herbert
Add infrastructure to allow UDP tunnels to setup flow dissecion. Signed-off-by: Tom Herbert --- include/net/udp_tunnel.h | 5 + net/ipv4/udp_tunnel.c| 5 + 2 files changed, 10 insertions(+) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index 02c5be0..81d2584 10064

[PATCH v2 net-next 0/7] udp: Flow dissection for tunnels

2016-10-17 Thread Tom Herbert
Now that we have a means to perform a UDP socket lookup without taking a reference, it is feasible to have flow dissector crack open UDP encapsulated packets. Generally, we would expect that the UDP source port or the flow label in IPv6 would contain enough entropy about the encapsulated flow. Howe

[PATCH v2 net-next 3/7] udp: Add socket lookup functions with noref

2016-10-17 Thread Tom Herbert
Create udp4_lib_lookup_noref and udp6_lib_lookup_noref. These perfrom a socket lookup on addresses and ports without taking a reference. Signed-off-by: Tom Herbert --- include/net/udp.h | 8 net/ipv4/udp.c| 8 net/ipv6/udp.c| 10 ++ 3 files changed, 26 inserti

[PATCH v2 net-next 1/7] ipv6: Fix Makefile conditional to use CONFIG_INET

2016-10-17 Thread Tom Herbert
ipv6 directory was being built based on CONFIG_NET not CONFIG_INET. Signed-off-by: Tom Herbert --- net/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/Makefile b/net/Makefile index 4cafaa2..82ffb91 100644 --- a/net/Makefile +++ b/net/Makefile @@ -17,7 +17,7 @@ ob

[PATCH v2 net-next 2/7] flow_dissector: Limit processing of next encaps and extensions

2016-10-17 Thread Tom Herbert
Flow dissector does not limit the number of encapsulated packets or IPv6 header extensions that will be processed. This could easily be suceptible to DOS attack-- for instance a 1500 byte packet could contain 75 IPIP headers. This patch places limits on the number of encapsulations and IPv6 extens

[PATCH v2 net-next 4/7] udp: UDP flow dissector

2016-10-17 Thread Tom Herbert
Add infrastructure for performing per protocol flow dissection and support flow dissection in UDP payloads (e.g. flow dissection on a UDP encapsulated tunnel. The per protocol flow dissector is called by flow_dissect function in the offload_callbacks of a protocol. The arguments of this function i

Re: [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail

2016-10-17 Thread David Miller
From: "Mintz, Yuval" Date: Mon, 17 Oct 2016 19:10:10 + >> Using list_move_tail() instead of list_del() + list_add_tail(). > >> Signed-off-by: Wei Yongjun > > Thanks. > Acked-by: Yuval Mintz Applied, thanks.

nfs NULL-dereferencing in net-next

2016-10-17 Thread Jakub Kicinski
Hi! I'm hitting this reliably on net-next, HEAD at 3f3177bb680f ("fsl/fman: fix error return code in mac_probe()"). [ 23.409633] BUG: unable to handle kernel NULL pointer dereference at 0172 [ 23.418716] IP: [] rpc_clnt_xprt_switch_has_addr+0xc/0x40 [sunrpc] [ 23.427574] PGD 8

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

2016-10-17 Thread Sowmini Varadhan
On (10/17/16 11:15), Alexander Duyck wrote: > I would say you probably only need the first check here for skb->data > and could probably skip the second part. You will be testing for > skb_tail_pointer in all the other tests you added so this check is > redundant anyway. > > Also you might want t

Re: [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail

2016-10-17 Thread Mintz, Yuval
> Using list_move_tail() instead of list_del() + list_add_tail(). > Signed-off-by: Wei Yongjun Thanks. Acked-by: Yuval Mintz

Re: [PATCH 4/4] gpio: ptxpmb-ext-cpld: Document bindings of PTXPMB extended CPLD

2016-10-17 Thread Pantelis Antoniou
Hi Rob, > On Oct 10, 2016, at 23:19 , Rob Herring wrote: > > On Fri, Oct 07, 2016 at 06:19:34PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Add device tree bindings document for the GPIO driver of >> Juniper's PTXPMB extended CPLD. >> >> Signed-off-by: Georgi Vlaev >> [Ported

Re: [PATCH 08/10] mtd: flash-sam: Bindings for Juniper's SAM FPGA flash

2016-10-17 Thread Pantelis Antoniou
Hi Rob, > On Oct 10, 2016, at 23:07 , Rob Herring wrote: > > gOn Fri, Oct 07, 2016 at 06:18:36PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Add binding document for Junipers Flash IP block present >> in the SAM FPGA on PTX series of routers. >> >> Signed-off-by: Georgi Vlaev

Re: [PATCH 2/4] mfd: ptxpmb-ext-cpld: Add documentation for PTXPMB extended CPLD

2016-10-17 Thread Pantelis Antoniou
Hi Rob, > On Oct 10, 2016, at 23:10 , Rob Herring wrote: > > On Fri, Oct 07, 2016 at 06:19:32PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Add DT bindings document for the PTXPMB extended CPLD device. >> >> Signed-off-by: Georgi Vlaev >> [Ported from Juniper kernel] >> Signe

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-17 Thread Richard Cochran
On Mon, Oct 17, 2016 at 01:36:45PM -0500, Julia Cartwright wrote: > While that is certainly the case, and would explain the most egregious > of measured latency spikes, it doesn't invalidate the test if you > consider the valuable data point(s) to be the minimum and/or median > latencies. Well, co

  1   2   3   >