Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-08 Thread Krister Johansen
Hi Cong, Thanks for the follow-up. On Thu, Oct 06, 2016 at 12:01:15PM -0700, Cong Wang wrote: > On Wed, Oct 5, 2016 at 11:11 PM, Krister Johansen > > pernet_operations pointer. The code in register_pernet_subsys() makes > > no attempt to check for duplicates. If we add a pointer that's already >

[PATCH net-next 5/5] be2net: Enable VF link state setting for BE3

2016-10-08 Thread Sriharsha Basavapatna
From: Suresh Reddy The VF link state setting feature now works on BE3 chips too from FW ver 11.1.192.0 onwards. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH net-next 1/5] be2net: Provide an alternate way to read pf_num for BEx chips

2016-10-08 Thread Sriharsha Basavapatna
The driver gets the pf_num for Skyhawk and Lancer using GET_FUNC_CONFIG FW command. But since that command is not supported in BEx, we need to get it from some other command. Otherwise TPE recovery would fail since all NIC PFs would end up with a func num of 0. There's a pci function number field i

[PATCH net-next 0/5] be2net: patch-set

2016-10-08 Thread Sriharsha Basavapatna
Hi David, The following patch set contains a few bug fixes. Please consider applying this to the net-next tree. Thanks. Patch-1 Obtains proper PF number for BEx chips Patch-2 Fixes a FW update issue seen with BEx chips Patch-3 Updates copyright string Patch-4 Fixes TX stats for TSO packets Patch-

[PATCH net-next 2/5] be2net: NCSI FW section should be properly updated with ethtool for BE3

2016-10-08 Thread Sriharsha Basavapatna
The driver has a check to ensure that NCSI FW section is updated only if the current FW version in the card supports it. This FW version check is done using memcmp() which obviously fails in some cases. Fix this by breaking up the version string into integer version components and comparing them.

[PATCH net-next 3/5] be2net: Update Copyright string in be_hw.h

2016-10-08 Thread Sriharsha Basavapatna
This patch updates the year and company name in the copyright string in be_hw.h. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_hw.h b/drivers/net/etherne

[PATCH net-next 4/5] be2net: Fix TX stats for TSO packets

2016-10-08 Thread Sriharsha Basavapatna
TX stats update does not take into account headers which get duplicated when the TSO packet is split into segments by HW. Fix this for both tunneled (vxlan) and non-tunneled TSO packets. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 14 -- 1 f

[PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

2016-10-08 Thread Hangbin Liu
Discovered by Phil's covscan. The final return statement is never reached. This is not inherently clear from looking at the code, so change the conditional to a switch() statement which should clarify this. CC: Phil Sutter Signed-off-by: Hangbin Liu --- devlink/devlink.c | 17 -

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-08 Thread Rob Herring
On Thu, Oct 06, 2016 at 08:47:13AM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Mark Rutland writes: > > > >> On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: > >>> Mark Rutland writes: > >>> > >>> reg-u16-align4 tells that a specific hardware doesn't support 16 b

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-08 Thread Rob Herring
On Mon, Oct 03, 2016 at 05:42:29PM +0100, Mark Rutland wrote: > On Mon, Oct 03, 2016 at 05:09:13PM +0100, Russell King - ARM Linux wrote: > > Please note that the binding doc for smsc,lan91c111.txt is slightly wrong > > on two counts: > > > > 1) compatible property: > > > > compatible = "smsc,lan

Re: Code quality and XDP

2016-10-08 Thread Tom Herbert
On Fri, Oct 7, 2016 at 9:28 PM, Jesper Dangaard Brouer wrote: > > On Sat, 8 Oct 2016 07:25:01 +0900 Tom Herbert wrote: > >> One concern raised at netdev concerning XDP is how are we going to >> maintain code quality, security, and correctness of programs being >> loaded. With kernel bypass it is

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Meelis Roos
> > That did not go well - bisect found the following commit but that does > > not seem to be related at all. So probably the reproducibility is not > > 100% but more random. > > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will > test further. It gets stranger and stran

[PATCH] net: ti: netcp_ethss: use new api ethtool_{get|set}_link_ksettings

2016-10-08 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/ti/netcp_ethss.c | 42 +++- 1 files changed, 25 insertions(+), 17 deletions(-) diff --git a/drivers/ne

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Meelis Roos
> On Sat, Oct 8, 2016 at 10:15 PM, Meelis Roos wrote: > >> That did not go well - bisect found the following commit but that does > >> not seem to be related at all. So probably the reproducibility is not > >> 100% but more random. > > > > Now I reproduced the bug even with 4.7-rc1 so it is older

Re: [PATCH 09/10] net: phy: Add MDIO driver for Juniper's SAM FPGA

2016-10-08 Thread Georgi Vlaev
Hi Andrew, On 16-10-07 23:13:26, Andrew Lunn wrote: > On Fri, Oct 07, 2016 at 06:18:37PM +0300, Pantelis Antoniou wrote: > > From: Georgi Vlaev > > > > Add driver for the MDIO IP block present in Juniper's > > SAM FPGA. > > > > This driver supports only Clause 45 of the 802.3 spec. > > > > Not

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Siva Reddy Kallam
On Sat, Oct 8, 2016 at 10:15 PM, Meelis Roos wrote: >> That did not go well - bisect found the following commit but that does >> not seem to be related at all. So probably the reproducibility is not >> 100% but more random. > > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Wi

[PATCH] net: ti: cpsw: use new api ethtool_{get|set}_link_ksettings

2016-10-08 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/ti/cpsw.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Meelis Roos
> That did not go well - bisect found the following commit but that does > not seem to be related at all. So probably the reproducibility is not > 100% but more random. Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will test further. > > > 4c5773f9f5462dcb372857813918bb

RE: Accelerated receive flow steering (aRFS) for UDP

2016-10-08 Thread Chopra, Manish
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Saturday, October 08, 2016 5:08 AM > To: Chopra, Manish > Cc: netdev@vger.kernel.org; ma...@mellanox.com; t...@herbertland.com > Subject: Re: Accelerated receive flow steering (aRFS) for UDP > > On Fri, 2016

[PATCH] Add support for ethtool operations such as get_regs_len(),

2016-10-08 Thread VENKAT PRASHANTH B U
From: Venkat Prashanth B U Signed-off-by: Venkat Prashanth B U --- drivers/net/ethernet/rdc/r6040.c | 75 1 file changed, 75 insertions(+) diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c index cb29ee2..eb7667a 100644 ---

Re: pull request: bluetooth 2016-10-08

2016-10-08 Thread David Miller
From: Johan Hedberg Date: Sat, 8 Oct 2016 14:29:14 +0300 > Here are a couple of Bluetooth fixes for the 4.9 kernel: > > - Firmware download fix for Atheros controllers > - Fixes to the content of LE scan response > - New USB ID for a Marvell chipset > > Please let me know if there are any is

pull request: bluetooth 2016-10-08

2016-10-08 Thread Johan Hedberg
Hi Dave, Here are a couple of Bluetooth fixes for the 4.9 kernel: - Firmware download fix for Atheros controllers - Fixes to the content of LE scan response - New USB ID for a Marvell chipset Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since c

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Meelis Roos
> I am testing 4.8 on my sparcs and got this on Sun V210 (sparc64). This > is reproducible. 4.8.0-rc3-00013 did not have this problem, will bisect > when I get some time. That did not go well - bisect found the following commit but that does not seem to be related at all. So probably the reprod

Re: [PATCH] wan/fsl_ucc_hdlc: Fix size used in dma_free_coherent()

2016-10-08 Thread Christophe LEROY
Le 07/10/2016 à 22:58, Christophe JAILLET a écrit : Size used with 'dma_alloc_coherent()' and 'dma_free_coherent()' should be consistent. Here, the size of a pointer is used in dma_alloc... and the size of the pointed structure is used in dma_free... This has been spotted with coccinelle, usin

RE: [PATCH 3/3] net: fec: align IP header in hardware

2016-10-08 Thread Andy Duan
From: Eric Nelson Sent: Friday, September 30, 2016 9:27 PM > To: David Laight ; netdev@vger.kernel.org > Cc: li...@arm.linux.org.uk; and...@lunn.ch; Andy Duan > ; ota...@ossystems.com.br; > eduma...@google.com; troy.ki...@boundarydevices.com; > da...@davemloft.net; u.kleine-koe...@pengutronix.de >

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-08 Thread Jamal Hadi Salim
On 16-10-06 08:49 PM, Cong Wang wrote: On Thu, Oct 6, 2016 at 5:17 PM, Jamal Hadi Salim wrote: I dont believe we need to bother with the return code in this case. Why? For a quick example, STOLEN vs. SHOT: result = tc_classify(skb, filter, &res, false); if (result >= 0) { #