Re: [PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-06 Thread David Miller
From: Paul Durrant Date: Thu, 6 Oct 2016 15:47:10 +0100 > In the case when a frontend only negotiates a single queue with xen- > netback it is possible for a skbuff with a s/w hash to result in a > hash extra_info segment being sent to the frontend even when no hash > algorithm has been configure

Re: [PATCH][RESEND] dt-bindings: net: renesas-ravb: Add support for R8A7796 RAVB

2016-10-06 Thread Simon Horman
On Tue, Oct 04, 2016 at 07:45:46PM +0300, Laurent Pinchart wrote: > Add a new compatible string for the R8A7796 (M3-W) RAVB. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven Acked-by: Simon Horman > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- >

Re: [PATCH] drivers: net: phy: Correct duplicate MDIO_XGENE entry

2016-10-06 Thread David Miller
From: Laura Abbott Date: Thu, 6 Oct 2016 11:22:51 -0700 > An extra entry for MDIO_XGENE got added during merging. > Delete it. > > Reviewed-by: Andrew Lunn > Signed-off-by: Laura Abbott Applied, thanks.

Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM

2016-10-06 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 6 Oct 2016 16:44:53 +0200 > If NO_DMA=y: > > drivers/built-in.o: In function `emac_probe': > emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops' > emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops' > emac.c:(.text+0x378112

Re: [PATCH net-next v3 0/3] net: ethernet: mediatek: check the hw lro capability by the chip id instead of the dtsi

2016-10-06 Thread David Miller
From: Nelson Chang Date: Thu, 6 Oct 2016 19:44:00 +0800 > The series modify to check if hw lro is supported by the chip id. > > changes since v3: > - Refine mtk_is_hwlro_supported() function > > changes since v2: > - Refine mtk_get_chip_id() function > > changes since v1: > - Because hw lro st

Re: [PATCH net-next 00/13] rxrpc: Fixes

2016-10-06 Thread David Miller
From: David Howells Date: Thu, 06 Oct 2016 11:03:56 +0100 > This set of patches contains a bunch of fixes: ... Pulled, thanks David.

Re: [PATCH net] netlink: do not enter direct reclaim from netlink_dump()

2016-10-06 Thread David Miller
From: Eric Dumazet Date: Thu, 06 Oct 2016 04:13:18 +0900 > From: Eric Dumazet > > Since linux-3.15, netlink_dump() can use up to 16384 bytes skb > allocations. > > Due to struct skb_shared_info ~320 bytes overhead, we end up using > order-3 (on x86) page allocations, that might trigger direct

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-06 Thread Cong Wang
On Mon, Oct 3, 2016 at 11:40 PM, Maciej Żenczykowski wrote: >> Please remove the const qualifier and the casts to be consistent >> with how we handle this elsewhere. >> >> Thanks. > > I can of course trivially make that change. > > But: > > (on net-next/master) > git grep 'extra[12].*=.*\(void *[*

Re: [PATCH net] packet: call fanout_release, while UNREGISTERING a netdev

2016-10-06 Thread David Miller
From: Anoob Soman Date: Wed, 5 Oct 2016 15:12:54 +0100 > If a socket has FANOUT sockopt set, a new proto_hook is registered > as part of fanout_add(). When processing a NETDEV_UNREGISTER event in > af_packet, __fanout_unlink is called for all sockets, but prot_hook which was > registered as part

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Cong Wang
On Thu, Oct 6, 2016 at 5:17 PM, Jamal Hadi Salim wrote: > I dont believe we need to bother with the return code in this case. Why? For a quick example, STOLEN vs. SHOT: result = tc_classify(skb, filter, &res, false); if (result >= 0) { #ifdef CONFIG_NET_CLS_ACT

Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

2016-10-06 Thread David Miller
From: Mike Looijmans Date: Wed, 5 Oct 2016 16:03:08 +0200 > The KSZ9031 skew registers contain an offset, the chip's default value > is "neutral" which does not add any skew. Programming a 0 into a skew > property will actually set it the maximal negative adjustment and not > to a neutral positi

Re: [PATCH v2 net-next] net: phy: Add Wake-on-LAN driver for Microsemi PHYs.

2016-10-06 Thread David Miller
From: Raju Lakkaraju Date: Wed, 5 Oct 2016 14:19:27 +0530 > From: Raju Lakkaraju > > Wake-on-LAN (WoL) is an Ethernet networking standard that allows > a computer/device to be turned on or awakened by a network message. > > VSC8531 PHY can support this feature configure by driver set function

Re: [net-next PATCH] drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay

2016-10-06 Thread David Miller
From: Mugunthan V N Date: Tue, 4 Oct 2016 19:07:29 +0530 > Add support to enable CPSW RGMII internal delay (id mode) bits > when rgmii internal delay is configured in phy. > > Signed-off-by: Mugunthan V N Applied.

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Cong Wang
On Thu, Oct 6, 2016 at 12:38 PM, Eric Dumazet wrote: > And another quick grep shows that out of 142 drivers, only one [1] of > them (incorrectly) checks netif_receive_skb() return value. > act_mirred is not a driver, apparently. > Real question is more like : what is the impact of propagating a

Re: [PATCH][V2] net: hns: Add missing \n to end of dev_err messages, tidy up text

2016-10-06 Thread David Miller
From: Colin King Date: Tue, 4 Oct 2016 13:57:01 +0100 > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. Also > fix grammer, spelling mistake and add white spaces to various > error messages. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: axienet: Add missing \n to end of dev_err messages

2016-10-06 Thread David Miller
From: Colin King Date: Tue, 4 Oct 2016 12:11:41 +0100 > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: ps3_gelic: Add missing \n to end of deb_dbg message

2016-10-06 Thread David Miller
From: Colin King Date: Tue, 4 Oct 2016 12:15:54 +0100 > From: Colin Ian King > > Trival fix, dev_dbg message is missing a \n, so add it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH v2 net-next 0/7] xen-netback: guest rx side refactor

2016-10-06 Thread David Miller
From: Paul Durrant Date: Tue, 4 Oct 2016 10:29:11 +0100 > This series refactors the guest rx side of xen-netback: > > - The code is moved into its own source module. > > - The prefix variant of GSO handling is retired (since it is no longer > in common use, and alternatives exist). > > - The

Re: [net-next 00/13] fsl/fman: cleanup and small fixes

2016-10-06 Thread David Miller
From: Madalin Bucur Date: Tue, 4 Oct 2016 10:30:24 +0300 > This series contains fixes for the DPAA FMan driver. > Adding myself as maintainer of the driver. > > The following are changes since commit > a4cc96d1f0170b779c32c6b2cc58764f5d2cdef0 > net: phy: Add Edge-rate driver for Microsemi PHYs

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Jamal Hadi Salim
On 16-10-06 01:30 PM, Cong Wang wrote: On Thu, Oct 6, 2016 at 6:30 AM, Shmulik Ladkani wrote: Hi, On Mon, Oct 3, 2016 at 12:45 PM, Cong Wang wrote: On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani wrote: skb2->skb_iif = skb->dev->ifindex; skb2->dev = dev; - err = dev_

[PATCH net-next 1/2] drivers: net: xgene: fix: Use GPIO to get link status

2016-10-06 Thread Iyappan Subramanian
The link value reported by the link status register is not reliable when no SPF module inserted. This patchset fixes this issue by using GPIO to determine the link status. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 6 ++

[PATCH net-next 2/2] arm64: xgene: defconfig: Enable Standby GPIO

2016-10-06 Thread Iyappan Subramanian
Enable CONFIG_GPIO_XGENE_SB. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index eadf485..be52a00 100644 --- a/arch/arm64/configs/defc

[PATCH net-next 0/2] drivers: net: xgene: fix: Use GPIO to get link status

2016-10-06 Thread Iyappan Subramanian
Since the link value reported by the link status register is not reliable if no SPF module inserted, this patchset fixes the issue by using GPIO to determine the link status when no module inserted. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- Iyappan Subramanian (2): dri

Re: [PATCH] drivers: net: phy: Correct duplicate MDIO_XGENE entry

2016-10-06 Thread Florian Fainelli
On 10/06/2016 11:22 AM, Laura Abbott wrote: > An extra entry for MDIO_XGENE got added during merging. > Delete it. > > Reviewed-by: Andrew Lunn > Signed-off-by: Laura Abbott Acked-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Eric Dumazet
On Thu, 2016-10-06 at 10:30 -0700, Cong Wang wrote: > On Thu, Oct 6, 2016 at 6:30 AM, Shmulik Ladkani > wrote: > > Hi, > > > > On Mon, Oct 3, 2016 at 12:45 PM, Cong Wang wrote: > >> On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani > >> wrote: > >>> skb2->skb_iif = skb->dev->ifindex; > >>

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-06 Thread Cong Wang
On Wed, Oct 5, 2016 at 11:11 PM, Krister Johansen wrote: > > I'm not sure. The reason I didn't take this approach from the outset is > that all of TC's callers of tcf_register_action pass a pointer to a > static structure as their *ops argument. The existence of code that > checks the action for

[PATCH] drivers: net: phy: Correct duplicate MDIO_XGENE entry

2016-10-06 Thread Laura Abbott
An extra entry for MDIO_XGENE got added during merging. Delete it. Reviewed-by: Andrew Lunn Signed-off-by: Laura Abbott --- drivers/net/phy/Kconfig | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 5078a0d..2651c8d

RE: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-06 Thread Williams, Mitch A
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Koehrer Mathias (ETAS/ESW5) > Sent: Thursday, October 06, 2016 12:02 AM > To: Julia Cartwright ; Kirsher, Jeffrey T > ; Greg > Cc: netdev@vger.kernel.org; intel-wired-...@lists.o

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Cong Wang
On Thu, Oct 6, 2016 at 6:30 AM, Shmulik Ladkani wrote: > Hi, > > On Mon, Oct 3, 2016 at 12:45 PM, Cong Wang wrote: >> On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani >> wrote: >>> skb2->skb_iif = skb->dev->ifindex; >>> skb2->dev = dev; >>> - err = dev_queue_xmit(skb2); >>>

Re: [PATCH] netfilter: xt_hashlimit: Add missing ULL suffixes for 64-bit constants

2016-10-06 Thread Vishwanath Pai
On 10/06/2016 09:40 AM, Geert Uytterhoeven wrote: > diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c > index 2fab0c65aa94b666..b89b688e9d01a2d1 100644 > --- a/net/netfilter/xt_hashlimit.c > +++ b/net/netfilter/xt_hashlimit.c > @@ -431,7 +431,7 @@ static void htable_put(struc

Re: Duplicate MDIO_XGENE Kconfig entries

2016-10-06 Thread Andrew Lunn
On Thu, Oct 06, 2016 at 09:01:27AM -0700, Laura Abbott wrote: > Hi, > > While working on the Fedora tree today, I noticed that there > seem to be two entries for CONFIG_MDIO_XGENE. It looks like > this might have been fall out from d75b4a22b255 ("net: phy: > Sort Makefile and Kconfig"). I can subm

Duplicate MDIO_XGENE Kconfig entries

2016-10-06 Thread Laura Abbott
Hi, While working on the Fedora tree today, I noticed that there seem to be two entries for CONFIG_MDIO_XGENE. It looks like this might have been fall out from d75b4a22b255 ("net: phy: Sort Makefile and Kconfig"). I can submit the following if this isn't fixed up elsewhere already diff --git a/d

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Joe Perches
On Thu, 2016-10-06 at 13:00 +, David Laight wrote: > From: Joe Perches > > Sent: 06 October 2016 12:39 > > On Thu, 2016-10-06 at 09:41 +, David Laight wrote: > > > From: Joe Perches > > > > No worries, and bool is the same ,size as u8. > > > That is not guaranteed at all. > > > One of the A

[PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-06 Thread Paul Durrant
In the case when a frontend only negotiates a single queue with xen- netback it is possible for a skbuff with a s/w hash to result in a hash extra_info segment being sent to the frontend even when no hash algorithm has been configured. (The ndo_select_queue() entry point makes sure the hash is not

Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

2016-10-06 Thread Geert Uytterhoeven
On Thu, Oct 6, 2016 at 4:12 PM, Timur Tabi wrote: > Geert Uytterhoeven wrote: >> >> Probably, I don't do UML allmodconfig builds. >> >> Gr{oetje,eeting}s, > > > Would you mind submitting another version of your patch that includes > HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in

[PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM

2016-10-06 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `emac_probe': emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops' emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops' emac.c:(.text+0x378112): undefined reference to `bad_dma_ops' emac.c:(.text+0x378146): undefine

Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM

2016-10-06 Thread Timur Tabi
Geert Uytterhoeven wrote: Add dependencies on HAS_DMA and HAS_IOMEM to fix this. Signed-off-by: Geert Uytterhoeven Acked-by: Timur Tabi -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,

Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

2016-10-06 Thread Timur Tabi
Geert Uytterhoeven wrote: config QCOM_EMAC tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support" + depends on HAS_DMA I think it needs to depend on HAS_IOMEM as well, to fix this error in arch/um: drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_

Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

2016-10-06 Thread Timur Tabi
Geert Uytterhoeven wrote: Probably, I don't do UML allmodconfig builds. Gr{oetje,eeting}s, Would you mind submitting another version of your patch that includes HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot? -- Qualcomm Datacenter Technologies, Inc. as an affilia

Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

2016-10-06 Thread Geert Uytterhoeven
On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi wrote: > Geert Uytterhoeven wrote: >> >> config QCOM_EMAC >> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet >> support" >> + depends on HAS_DMA > > > I think it needs to depend on HAS_IOMEM as well, to fix this error in > arch

[PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

2016-10-06 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `emac_probe': emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops' emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops' emac.c:(.text+0x378112): undefined reference to `bad_dma_ops' emac.c:(.text+0x378146): undefine

Re: 4.9-rc0: nf_hooks_ingress missing, breaking compilation

2016-10-06 Thread Aaron Conole
Pavel Machek writes: > Hi! Hi Pavel, > In kernel based on edadd0e, I get plenty of errors such as: In this case, I screwed up - sincere apologies. Enabling CONFIG_NETFILTER_INGRESS will work around this error for the time being, while the fix makes it way through the various trees. > net/net

[PATCH] strparser: Propagate correct error code in strp_recv()

2016-10-06 Thread Geert Uytterhoeven
With m68k-linux-gnu-gcc-4.1: net/strparser/strparser.c: In function ‘strp_recv’: net/strparser/strparser.c:98: warning: ‘err’ may be used uninitialized in this function Pass "len" (which is an error code when negative) instead of the uninitialized "err" variable to fix this. Fixes: 43a0

[PATCH] netfilter: xt_hashlimit: Add missing ULL suffixes for 64-bit constants

2016-10-06 Thread Geert Uytterhoeven
On 32-bit (e.g. with m68k-linux-gnu-gcc-4.1): net/netfilter/xt_hashlimit.c: In function ‘user2credits’: net/netfilter/xt_hashlimit.c:476: warning: integer constant is too large for ‘long’ type ... net/netfilter/xt_hashlimit.c:478: warning: integer constant is too large for ‘long’

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-06 Thread Shmulik Ladkani
Hi, On Mon, Oct 3, 2016 at 12:45 PM, Cong Wang wrote: > On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani > wrote: >> skb2->skb_iif = skb->dev->ifindex; >> skb2->dev = dev; >> - err = dev_queue_xmit(skb2); >> + if (tcf_mirred_act_direction(m_eaction) & AT_EGRESS) >> +

Re: [PATCH net-next 11/14] rxrpc: Make rxrpc_send_packet() take a connection not a transport [ver #2]

2016-10-06 Thread Geert Uytterhoeven
Hi David, On Wed, Jun 22, 2016 at 6:04 PM, David Howells wrote: > Make rxrpc_send_packet() take a connection not a transport as part of the > phasing out of the rxrpc_transport struct. > > Whilst we're at it, rename the function to rxrpc_send_data_packet() to > differentiate it from the other pac

RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread David Laight
From: Joe Perches > Sent: 06 October 2016 12:39 > On Thu, 2016-10-06 at 09:41 +, David Laight wrote: > > From: Joe Perches > > > No worries, and bool is the same ,size as u8. > > That is not guaranteed at all. > > One of the ARM ABI defined bool to be the size of int. > > Really? What kernel

web.upgrades

2016-10-06 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

Re: [PATCH 3/3] mac80211: multicast to unicast conversion

2016-10-06 Thread Johannes Berg
On Thu, 2016-10-06 at 13:53 +0200, michael-dev wrote: > Am 05.10.2016 13:58, schrieb Johannes Berg: > > > > > > Anyway, perhaps this needs to change to take DMS/per-station into > > account? > > > > Then again, this kind of setting - global multicast-to-unicast - > > fundamentally *cannot* be do

Re: [PATCH 3/3] mac80211: multicast to unicast conversion

2016-10-06 Thread michael-dev
Am 05.10.2016 13:58, schrieb Johannes Berg: Anyway, perhaps this needs to change to take DMS/per-station into account? Then again, this kind of setting - global multicast-to-unicast - fundamentally *cannot* be done on a per-station basis, since if you enable it for one station and not for anoth

[PATCH net-next v3 3/3] net: ethernet: mediatek: remove hwlro property in the device tree

2016-10-06 Thread Nelson Chang
Since the proper way to check the hw lro capability is by the chip id, hwlro property in the device tree should be removed. Signed-off-by: Nelson Chang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/binding

[PATCH net-next v3 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi

2016-10-06 Thread Nelson Chang
Because hw lro started to be supported from MT7623, the proper way to check if the feature is capable is to judge by the chip id instead of by the dtsi. Signed-off-by: Nelson Chang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 14 -- drivers/net/ethernet/mediatek/mtk_eth_soc.h |

[PATCH net-next v3 0/3] net: ethernet: mediatek: check the hw lro capability by the chip id instead of the dtsi

2016-10-06 Thread Nelson Chang
The series modify to check if hw lro is supported by the chip id. changes since v3: - Refine mtk_is_hwlro_supported() function changes since v2: - Refine mtk_get_chip_id() function changes since v1: - Because hw lro started to be supported from MT7623, the proper way to check if the feature is

[PATCH net-next v3 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-06 Thread Nelson Chang
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers in mtk_probe(). Signed-off-by: Nelson Chang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 29 + drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 + 2 files changed, 34 insertions(+) di

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Joe Perches
On Thu, 2016-10-06 at 09:41 +, David Laight wrote: > From: Joe Perches > > No worries, and bool is the same ,size as u8. > That is not guaranteed at all. > One of the ARM ABI defined bool to be the size of int. Really? What kernel has sizeof(_Bool) != 1 ?

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-06 Thread Florian Fainelli
On 10/05/2016 12:18 AM, Andrew Lunn wrote: + phydev->mdix = ETH_TP_MDI_AUTO; >>> >>> Humm, interesting. The only other driver supporting mdix is the >>> Marvell one. It does not do this, it leaves it to its default value of >>> ETH_TP_MDI_INVALID. It does however interpret ETH_TP_MDI_INV

Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

2016-10-06 Thread Florian Fainelli
On 10/05/2016 07:03 AM, Mike Looijmans wrote: > The KSZ9031 skew registers contain an offset, the chip's default value > is "neutral" which does not add any skew. Programming a 0 into a skew > property will actually set it the maximal negative adjustment and not > to a neutral position as one would

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-06 Thread Florian Fainelli
On 09/28/2016 01:24 PM, Andrew Lunn wrote: >> static int vsc85xx_wol_set(struct phy_device *phydev, >> struct ethtool_wolinfo *wol) >> { >> @@ -227,6 +281,7 @@ static int vsc85xx_default_config(struct phy_device >> *phydev) >> int rc; >> u16 reg_val; >> >> +

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-06 Thread Henri Roosen
On 10/06/2016 09:01 AM, Koehrer Mathias (ETAS/ESW5) wrote: Hi all, Hi Mathias, Although, to be clear, it isn't the fact that there exists 8 threads, it's that the device is firing all 8 interrupts at the same time. The time spent in hardirq context just waking up all 8 of those threads (a

[PATCH net 11/13] afs: Check for fatal error when in waiting for ack state

2016-10-06 Thread David Howells
When it's in the waiting-for-ACK state, the AFS filesystem needs to check the result of rxrpc_kernel_recv_data() any time it is notified to see if it is indicating a fatal error. If this is the case, it needs to mark the call completed otherwise the call just sits there and never goes away. Signe

[PATCH net 10/13] rxrpc: Return negative error code to kernel service

2016-10-06 Thread David Howells
In rxrpc_kernel_recv_data(), when we return the error number incurred by a failed call, we must negate it before returning it as it's stored as positive (that's what we have to pass back to userspace). Signed-off-by: David Howells --- net/rxrpc/recvmsg.c |2 +- 1 file changed, 1 insertion(+

[PATCH net 13/13] rxrpc: Don't request an ACK on the last DATA packet of a call's Tx phase

2016-10-06 Thread David Howells
Don't request an ACK on the last DATA packet of a call's Tx phase as for a client there will be a reply packet or some sort of ACK to shift phase. If the ACK is requested, OpenAFS sends a REQUESTED-ACK ACK with soft-ACKs in it and doesn't follow up with a hard-ACK. If we don't set the flag, OpenA

[PATCH net 04/13] rxrpc: Only ping for lost reply in client call

2016-10-06 Thread David Howells
When a reply is deemed lost, we send a ping to find out the other end received all the request data packets we sent. This should be limited to client calls and we shouldn't do this on service calls. Signed-off-by: David Howells --- net/rxrpc/input.c |3 ++- 1 file changed, 2 insertions(+),

[PATCH net 09/13] rxrpc: Add missing notification

2016-10-06 Thread David Howells
The call's background processor work item needs to notify the socket when it completes a call so that recvmsg() or the AFS fs can deal with it. Without this, call expiry isn't handled. Signed-off-by: David Howells --- net/rxrpc/call_event.c |1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH net 12/13] rxrpc: Need to produce an ACK for service op if op takes a long time

2016-10-06 Thread David Howells
We need to generate a DELAY ACK from the service end of an operation if we start doing the actual operation work and it takes longer than expected. This will hard-ACK the request data and allow the client to release its resources. To make this work: (1) We have to set the ack timer and propose a

[PATCH net 08/13] rxrpc: Queue the call on expiry

2016-10-06 Thread David Howells
When a call expires, it must be queued for the background processor to deal with otherwise a service call that is improperly terminated will just sit there awaiting an ACK and won't expire. Signed-off-by: David Howells --- net/rxrpc/call_event.c | 10 ++ 1 file changed, 6 insertions(+

[PATCH net 07/13] rxrpc: Partially handle OpenAFS's improper termination of calls

2016-10-06 Thread David Howells
OpenAFS doesn't always correctly terminate client calls that it makes - this includes calls the OpenAFS servers make to the cache manager service. It should end the client call with either: (1) An ACK that has firstPacket set to one greater than the seq number of the reply DATA packet with t

[PATCH net 06/13] rxrpc: Fix loss of PING RESPONSE ACK production due to PING ACKs

2016-10-06 Thread David Howells
Separate the output of PING ACKs from the output of other sorts of ACK so that if we receive a PING ACK and schedule transmission of a PING RESPONSE ACK, the response doesn't get cancelled by a PING ACK we happen to be scheduling transmission of at the same time. If a PING RESPONSE gets lost, the

[PATCH net-next 00/13] rxrpc: Fixes

2016-10-06 Thread David Howells
This set of patches contains a bunch of fixes: (1) Fix an oops on incoming call to a local endpoint without a bound service. (2) Only ping for a lost reply in a client call (this is inapplicable to service calls). (3) Fix maybe uninitialised variable warnings in the ACK/ABORT sendi

[PATCH net 01/13] rxrpc: Accesses of rxrpc_local::service need to be RCU managed

2016-10-06 Thread David Howells
struct rxrpc_local->service is marked __rcu - this means that accesses of it need to be managed using RCU wrappers. There are two such places in rxrpc_release_sock() where the value is checked and cleared. Fix this by using the appropriate wrappers. Signed-off-by: David Howells --- net/rxrpc/

[PATCH net 03/13] rxrpc: Fix oops on incoming call to serviceless endpoint

2016-10-06 Thread David Howells
If an call comes in to a local endpoint that isn't listening for any incoming calls at the moment, an oops will happen. We need to check that the local endpoint's service pointer isn't NULL before we dereference it. Signed-off-by: David Howells --- net/rxrpc/call_accept.c |2 +- 1 file cha

[PATCH net 05/13] rxrpc: Fix warning by splitting rxrpc_send_call_packet()

2016-10-06 Thread David Howells
Split rxrpc_send_data_packet() to separate ACK generation (which is more complicated) from ABORT generation. This simplifies the code a bit and fixes the following warning: In file included from ../net/rxrpc/output.c:20:0: net/rxrpc/output.c: In function 'rxrpc_send_call_packet': net/rxrpc/ar-int

[PATCH net 02/13] rxrpc: Fix duplicate const

2016-10-06 Thread David Howells
Remove a duplicate const keyword. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |2 +- net/rxrpc/misc.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index d38dffd78085..4954e6e25819 100644 --- a

[PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-06 Thread Cyrill Gorcunov
In criu we are actively using diag interface to collect sockets present in the system when dumping applications. And while for unix, tcp, udp[lite], packet, netlink it works as expected, the raw sockets do not have. Thus add it. v2: - add missing sock_put calls in raw_diag_dump_one (by eric.dumaz

RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread David Laight
From: Of Joe Perches ... > No worries, and bool is the same size as u8. That is not guaranteed at all. One of the ARM ABI defined bool to be the size of int. David

Re: [PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing

2016-10-06 Thread Jiri Benc
On Wed, 5 Oct 2016 22:22:13 -0700, Pravin Shelar wrote: > User can turn off TX vlan offload for OVS internal device that would > allow vlan tagged packet with vlan header on the skb-data. This case > will cause issue here. Good catch. This is the feedback I hoped for, not the bikesheding about a v

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Johan Hedberg
Hi, On Thu, Oct 06, 2016, Joe Perches wrote: > On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote: > > I believe you are wrong. bit addressability does not matter, cpu can > > definitely get the bit values. > > > > u8 foo:1; > > u8 bar:1; > > u8 baz:1; > > > > should take 1 byte, where > > >

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Joe Perches
On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote: > I believe you are wrong. bit addressability does not matter, cpu can > definitely get the bit values. > > u8 foo:1; > u8 bar:1; > u8 baz:1; > > should take 1 byte, where > > bool foo, bar, baz; > > will take more like 3. Definitely true.

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Pavel Machek
On Wed 2016-10-05 15:28:51, Joe Perches wrote: > On Thu, 2016-10-06 at 00:13 +0200, Pavel Machek wrote: > > On Wed 2016-10-05 12:15:34, Joe Perches wrote: > > > On Wed, 2016-10-05 at 21:11 +0200, Pavel Machek wrote: > > > > On Wed 2016-10-05 10:53:16, Joe Perches wrote: > [] > > > > > trivia: > > >

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-06 Thread Koehrer Mathias (ETAS/ESW5)
Hi all, > > Although, to be clear, it isn't the fact that there exists 8 threads, it's > that the device is > firing all 8 interrupts at the same time. The time spent in hardirq context > just waking > up all 8 of those threads (and the cyclictest wakeup) is enough to cause your > regression. >