[PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-02 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This disallows setting /proc/sys/net/ipv6/conf/*/router_solicitations to values below -1. -1 continues to mean an unlimited number of retransmits. Note: this depends on 'ipv6 addrconf: remove addrconf_sysctl_hop_limit()' Signed-off-by: Maciej Żenczykowski --- net/ip

[net-next 0/2][pull request] 100GbE Intel Wired LAN Driver Updates 2016-10-02

2016-10-02 Thread Jeff Kirsher
This series contains updates to fm10k only. Jake fixes an issue where PTP applications requesting software timestamps may complain that the requested mode is not supported, so add a generic callback for those drivers that have software transmit timestamp support enabled. Then provides a trivial c

[net-next 1/2] fm10k: use generic ethtool_op_get_ts_info callback

2016-10-02 Thread Jeff Kirsher
From: Jacob Keller This generic callback is for drivers which have software Tx timestamp support enabled. Without this, PTP applications requesting software timestamps may complain that the requested mode is not supported. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: J

[net-next 2/2] fm10k: wrap long line for alloc_workqueue

2016-10-02 Thread Jeff Kirsher
From: Jacob Keller Trivial change here to cleanup a checkpatch.pl warning that got introduced when changing to alloc_workqueue. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 3 ++- 1 file changed, 2 inse

[PATCH v2 1/2] net: stmmac: use phydev from struct net_device

2016-10-02 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- Changelog: v2: - rem

[PATCH v2 2/2] net: stmmac: use new api ethtool_{get|set}_link_ksettings

2016-10-02 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- Changelog: v2: - no change on this patch .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 97 +++ 1 files changed, 56 insertions(+)

Re: [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock

2016-10-02 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 1 Oct 2016 00:56:37 +0300 > There is no need to clk_disable_unprepare(dev->clk) > before it was initialized. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied.

Re: [PATCH net-next 0/7] rxrpc: More fixes and adjustments

2016-10-02 Thread David Miller
From: David Howells Date: Fri, 30 Sep 2016 22:40:11 +0100 > > This set of patches contains some more fixes and adjustments: > > (1) Actually display the retransmission indication previously added to the > tx_data trace. > > (2) Switch to Congestion Avoidance mode properly at cwnd==ssthr

Re: [PATCH net-next v2 0/3] openvswitch: mpls fix and clean up

2016-10-02 Thread David Miller
From: Jiri Benc Date: Fri, 30 Sep 2016 19:08:04 +0200 > Convert to the new mpls skb layout the last remaining place in openvswitch, > forgotten on the mpls GSO rework. The GSO rework also allows for some > cleanup in the third patch. Series applied, thanks.

Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning

2016-10-02 Thread David Miller
From: Arnd Bergmann Date: Fri, 30 Sep 2016 18:17:09 +0200 > Build-testing this driver with -Wmaybe-uninitialized gives a new > false-positive > warning that I can't really explain: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function > 'mlx5e_configure_flower': > drivers/net/ethern

Re: [PATCH 2/2] mlxsw: spectrum_router: avoid potential uninitialized data usage

2016-10-02 Thread David Miller
From: Arnd Bergmann Date: Fri, 30 Sep 2016 18:17:10 +0200 > If fi->fib_nhs is zero, the router interface pointer is uninitialized, as > shown by > this warning: > > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function > 'mlxsw_sp_router_fib_event': > drivers/net/ethernet/mellanox

Re: pull-request: mac80211-next 2016-09-30

2016-10-02 Thread David Miller
From: Johannes Berg Date: Fri, 30 Sep 2016 18:14:36 +0200 > Last pull request before the merge window, since it's about to open :) > It seems that everyone finally agreed on the NAN (neighbor awareness > networking) APIs, so we have that, along with some other things. > > Let me know if there's

Re: [PATCH] cxgb4: unexport cxgb4_dcb_enabled

2016-10-02 Thread David Miller
From: Arnd Bergmann Date: Fri, 30 Sep 2016 18:15:33 +0200 > A recent cleanup marked cxgb4_dcb_enabled as 'static', which is correct, but > this ignored > how the symbol is also exported. In addition, the export can be compiled out > when modules > are disabled, causing a harmless compiler warni

Re: [PATCH] net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

2016-10-02 Thread David Miller
From: Arnd Bergmann Date: Fri, 30 Sep 2016 18:13:49 +0200 > With the newly added support for IFLA_VF_VLAN_LIST netlink messages, > we get a warning about potential uninitialized variable use in > the parsing of the user input when enabling the -Wmaybe-uninitialized > warning: > > net/core/rtnetl

Re: [PATCH net v2] net: pktgen: fix pkt_size

2016-10-02 Thread David Miller
From: Paolo Abeni Date: Fri, 30 Sep 2016 16:56:45 +0200 > The commit 879c7220e828 ("net: pktgen: Observe needed_headroom > of the device") increased the 'pkt_overhead' field value by > LL_RESERVED_SPACE. > As a side effect the generated packet size, computed as: > > /* Eth + IPh + UDPh + m

Re: [PATCH v2] net: fec: set mac address unconditionally

2016-10-02 Thread David Miller
From: Gavin Schenk Date: Fri, 30 Sep 2016 11:46:10 +0200 > If the mac address origin is not dt, you can only safely assign a mac > address after "link up" of the device. If the link is off the clocks are > disabled and because of issues assigning registers when clocks are off the > new mac addres

Re: [PATCH] net: ethernet: mediatek: mark symbols static where possible

2016-10-02 Thread David Miller
From: Baoyou Xie Date: Fri, 30 Sep 2016 15:48:50 +0800 > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/mediatek/mtk_eth_soc.c:2041:5: warning: no previous > prototype for 'mtk_get_link_ksettings' [-Wmissing-prototypes] > drivers/net/ethernet/mediatek/mtk_eth_soc.c:2052:

Re: [PATCH] cxgb4: mark cxgb_setup_tc() static

2016-10-02 Thread David Miller
From: Baoyou Xie Date: Fri, 30 Sep 2016 15:34:25 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:2715:5: warning: no previous > prototype for 'cxgb_setup_tc' [-Wmissing-prototypes] > > In fact, this function is only used in the file in w

[net-next:master 249/527] emac-mac.c:undefined reference to `bad_dma_ops'

2016-10-02 Thread kbuild test robot
Hi Timur, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d4ef9f72128d414ad83b27b49312faa971d77382 commit: b9b17debc69d27cd55e21ee51a5ba7fc50a426cf [249/527] net: emac: emac gigabit ethernet controller driver config

Re: [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

2016-10-02 Thread David Miller
From: Maciej Żenczykowski Date: Thu, 29 Sep 2016 00:33:43 -0700 > From: Maciej Żenczykowski > > This is an effective no-op in terms of user observable behaviour. > > By preventing the overwrite of non-null extra1/extra2 fields > in addrconf_sysctl() we can enable the use of proc_dointvec_minma

[PATCH] vmxnet3: Wake queue from reset work

2016-10-02 Thread Benjamin Poirier
vmxnet3_reset_work() expects tx queues to be stopped (via vmxnet3_quiesce_dev -> netif_tx_disable). However, this races with the netif_wake_queue() call in netif_tx_timeout() such that the driver's start_xmit routine may be called unexpectedly, triggering one of the BUG_ON in vmxnet3_map_pkt with a

Re: [PATCH] netfilter: bridge: clarify bridge/netfilter message

2016-10-02 Thread David Miller
From: Stefan Agner Date: Wed, 28 Sep 2016 15:05:28 -0700 > When using bridge without bridge netfilter enabled the message > displayed is rather confusing and leads to belive that a deprecated > feature is in use. Use IS_MODULE to be explicit that the message only > affects users which use bridge

Re: [PATCH v2 net-next 1/2] net: centralize net_device min/max MTU checking

2016-10-02 Thread David Miller
From: Jakub Sitnicki Date: Fri, 30 Sep 2016 11:37:24 +0200 > On Wed, Sep 28, 2016 at 10:20 PM GMT, Jarod Wilson wrote: >> While looking into an MTU issue with sfc, I started noticing that almost >> every NIC driver with an ndo_change_mtu function implemented almost >> exactly the same range check

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-02 Thread Jamal Hadi Salim
On 16-10-01 11:13 PM, Krister Johansen wrote: A tc_action_ops structure is visibile as soon as it is placed in the act_base list. When tcf_regsiter_action adds an item to this list and drops act_mod_lock, registration is not complete until register_pernet_subsys() finishes. If two threads attem

Re: [PATCH] Add netdev all_adj_list refcnt propagation to fix panic

2016-10-02 Thread David Miller
From: Andrew Collins Date: Wed, 28 Sep 2016 13:04:42 -0600 > On 09/28/2016 12:06 PM, David Ahern wrote: >> Andrew Collins posted this patch as RFC in March: >> http://patchwork.ozlabs.org/patch/603101/ >> >> It has apparently fallen through the cracks and never applied. >> >> It solves a refc

linux-next: manual merge of the net-next tree with Linus' tree

2016-10-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sctp/sctp_diag.c between commit: 1cceda784980 ("sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock") from Linus' tree and commit: d545caca827b ("net: inet: diag: expose the socket mark to privileged

linux-next: manual merge of the net-next tree with Linus' tree

2016-10-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sctp/outqueue.c between commit: be4947bf46cb ("sctp: change to check peer prsctp_capable when using prsctp polices") from Linus' tree and commit: 2c89791eeb6f ("sctp: remove the unnecessary state check in sctp

[PATCH 1/2] net: stmmac: use phydev from struct net_device

2016-10-02 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- .../net/ethernet/stm

[PATCH 2/2] net: stmmac: use new api ethtool_{get|set}_link_ksettings

2016-10-02 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 97 +++ 1 files changed, 56 insertions(+), 41 deletions(-) diff --git a/drivers/ne

Re: [PATCH] net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

2016-10-02 Thread Tariq Toukan
Hi Arnd, On 30/09/2016 7:38 PM, Arnd Bergmann wrote: On Friday 30 September 2016, Eric Dumazet wrote: @@ -1753,6 +1753,9 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr **tb) len++; } + if (len == 0) +

UK Chemical Consultants

2016-10-02 Thread UK Chemical Consultants
Dear Customer, Are You having A problem In Your Anti-breeze Negative Defaced notes and spending too much money just to clean your deface Currency ? You are at the right place Now* the Chemicals marketing company AID FOR FEDERAL RESERVE BOARD DEPARTMENT OF TREASURY will be there for you. It impre

[GIT] Networking

2016-10-02 Thread David Miller
1) Fix wrong TCP checksums on MTU probing when checksum offloading is disabled, from Douglas Caetano dos Santos. 2) Fix qdisc backlog updates in qfq and sfb schedulers, from Cong Wang. 3) Route lookup flow key protocol value is wrong in ip6gre_xmit_other(), fix from Lance Richardson. 4) S

[PATCH 2/2] net: mv643xx_eth: use new api ethtool_{get|set}_link_ksettings

2016-10-02 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/marvell/mv643xx_eth.c | 84 +-- 1 files changed, 53 insertions(+), 31 deletions(-) diff --git a/drivers/ne

[PATCH 1/2] net: mv643xx_eth: use phydev from struct net_device

2016-10-02 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet

Re: rhashtable - rhashtable_insert_fast failed

2016-10-02 Thread Helge Deller
Hi Herbert, On 08.06.2016 04:39, Herbert Xu wrote: > On Tue, Jun 07, 2016 at 04:47:28PM +0200, Helge Deller wrote: >> On 07.06.2016 16:16, Herbert Xu wrote: >>> On Tue, Jun 07, 2016 at 04:13:50PM +0200, Helge Deller wrote: What warnings do you mean specifically? Some specific CONFIG_ opt

[PATCH] ptp: Fix resource leak in case of error

2016-10-02 Thread Christophe JAILLET
A call to 'ida_simple_remove()' is missing in the error handling path. This as been spotted with the following coccinelle script which tries to detect missing 'ida_simple_remove()' call in error handling paths. /// @@ expression x; identifier l; @@ * x = ida_simple_get(...); ..