Re: [PATCH] fs/select: add vmalloc fallback for select(2)

2016-09-22 Thread Hillf Danton
> > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > with the number of fds passed. We had a customer report page allocation > failures of order-4 for this allocation. This is a costly order, so it might > easily fail, as the VM expects such allocation to have a lower-

[net-next 1/5] igb: fix non static symbol warning

2016-09-22 Thread Jeff Kirsher
From: Wei Yongjun Fixes the following sparse warning: drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: symbol 'igb_rxnfc_write_vlan_prio_filter' was not declared. Should it be static? Signed-off-by: Wei Yongjun Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/ne

[net-next 2/5] igbvf: bump version to igbvf-2.4.0

2016-09-22 Thread Jeff Kirsher
From: Todd Fujinaka Bump version to match other igbvf drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ne

[net-next 4/5] igb: restore PPS signal on igb_ptp_reset

2016-09-22 Thread Jeff Kirsher
From: Jacob Keller When a reset occurs, the PPS SYS_WRAP interrupt was not re-enabled which resulted in disabling of the PPS signaling. Fix this by recording when the interrupt is on and ensuring that we re-enable it every time we reset. Signed-off-by: Jacob Keller Tested-by: Aaron Brown Signe

[net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-22

2016-09-22 Thread Jeff Kirsher
This series contains updates to igb, igbvf and PCI quirks. Wei Yongjun makes a function static to shut up sparse. Todd bumps the igb and igbvf version, which is long overdue. Jake fixes an issue where the PPS SYS_WRAP interrupt was not re-enabled after a reset, which resulted in disabling of the

[net-next 5/5] PCI: disable FLR for 82579 device

2016-09-22 Thread Jeff Kirsher
From: Sasha Neftin 82579 has a problem reattaching itself after the device is detached. The bug was reported by Redhat. The suggested fix is to disable FLR capability in PCIe configuration space. Reproduction: Attach the device to a VM, then detach and try to attach again. Fix: Disable FLR capa

[net-next 3/5] igb: bump version to igb-5.4.0

2016-09-22 Thread Jeff Kirsher
From: Todd Fujinaka Bump igb version to match other igb drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/ig

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-22 Thread Jiri Pirko
Thu, Sep 22, 2016 at 09:26:57PM CEST, jakub.kicin...@netronome.com wrote: >Switches and modern SR-IOV enabled NICs may multiplex traffic from >representators and control messages over single set of hardware queues. >Control messages and muxed traffic may need ordered delivery. > >Those requirements

Re: [PATCHv2 iproute2 0/2] ip rule: merger iprule_flush and add selector support

2016-09-22 Thread Phil Sutter
On Fri, Sep 23, 2016 at 11:25:53AM +0800, Hangbin Liu wrote: > When merge iprule_flush() and iprule_list_or_save(). Renamed > rtnl_filter_t filter to filter_fn because we want to use global > variable 'filter' to filter nlmsg in the next patch. > > Hangbin Liu (2): > ip rule: merge ip rule flush

[PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-22 Thread sean.wang
From: Sean Wang fix typo in Documentation/devicetree/bindings/net/mediatek-net.txt Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-22 Thread sean.wang
From: Sean Wang add phy-mode "trgmii" to Documentation/devicetree/bindings/net/ethernet.txt Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/ethernet.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

RE: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-22 Thread Yotam Gigi
>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Friday, September 23, 2016 1:40 AM >To: Yotam Gigi ; da...@davemloft.net; >netdev@vger.kernel.org; Roman Mashak >Subject: Re: [PATCH net] act_ife: Add support for machines with hard_header_len >!= mac_len > >On 1

[net-next v2 01/10] i40e: fix setting user defined RSS hash key

2016-09-22 Thread Jeff Kirsher
From: Alan Brady Previously, when using ethtool to change the RSS hash key, ethtool would report back saying the old key was still being used and no error was reported. It was unclear whether it was being reported incorrectly or being set incorrectly. Debugging revealed 'i40e_set_rxfh()' return

[net-next v2 03/10] i40e: return correct opcode to VF

2016-09-22 Thread Jeff Kirsher
From: Mitch Williams This conditional is backward, so the driver responds back to the VF with the wrong opcode. Do the old switcheroo to fix this. Change-ID: I384035b0fef8a3881c176de4b4672009b3400b25 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drive

[net-next v2 07/10] i40evf: Fix link state event handling

2016-09-22 Thread Jeff Kirsher
From: Sridhar Samudrala Currently disabling the link state from PF via ip link set enp5s0f0 vf 0 state disable doesn't disable the CARRIER on the VF. This patch updates the carrier and starts/stops the tx queues based on the link state notification from PF. PF: enp5s0f0, VF: enp5s2

[net-next v2 04/10] i40e: Fix to check for NULL

2016-09-22 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes an issue in the virt channel code, where a return from i40e_find_vsi_from_id was not checked for NULL when applicable. Without this patch, there is a risk for panic and static analysis tools complain. This patch fixes the problem by adding the check and addi

[net-next v2 08/10] i40evf: remove unnecessary error checking against i40evf_up_complete

2016-09-22 Thread Jeff Kirsher
From: Bimmy Pujari Function i40evf_up_complete() always returns success. Changed this to a void type and removed the code that checks the return status and prints an error message. Change-ID: I8c400f174786b9c855f679e470f35af292fb50ad Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-

[net-next v2 09/10] i40e: Limit TX descriptor count in cases where frag size is greater than 16K

2016-09-22 Thread Jeff Kirsher
From: Alexander Duyck The i40e driver was incorrectly assuming that we would always be pulling no more than 1 descriptor from each fragment. It is in fact possible for us to end up with the case where 2 descriptors worth of data may be pulled when a frame is larger than one of the pieces generat

[net-next v2 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-22

2016-09-22 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Sridhar fixes link state event handling by updating the carrier and starts/stops the Tx queues based on the link state notification from PF. Brady fixes an issue where a user defined RSS hash key was not being set because a user defined indire

[net-next v2 06/10] i40e: avoid potential null pointer dereference when assigning len

2016-09-22 Thread Jeff Kirsher
From: Colin Ian King There is a sanitcy check for desc being null in the first line of function i40evf_debug_aq. However, before that, aq_desc is cast from desc, and aq_desc is being dereferenced on the assignment of len, so this could be a potential null pointer deference. Fix this by moving t

[net-next v2 10/10] i40evf: remove unnecessary error checking against i40e_shutdown_adminq

2016-09-22 Thread Jeff Kirsher
From: Lihong Yang The i40e_shutdown_adminq function never returns failure. There is no need to check the non-0 return value. Clean up the unnecessary error checking and warning against it. Change-ID: Ibb616f09cfb93bd1a872ebf3241a15fb8354b31b Signed-off-by: Lihong Yang Tested-by: Andrew Bowers

[net-next v2 02/10] i40e: fix "dump port" command when NPAR enabled

2016-09-22 Thread Jeff Kirsher
From: Alan Brady When using the debugfs to issue the "dump port" command with NPAR enabled, the firmware reports back with invalid argument. The issue occurs because the pf->mac_seid was used to perform the query. This is fine when NPAR is disabled because the switch ID == pf->mac_seid, however

[net-next v2 05/10] i40e: Fix for extra byte swap in tunnel setup

2016-09-22 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes an issue where we were byte swapping the port parameter, then byte swapping it again in function execution. Obviously, that's unnecessary, so take it out of the function calls. Without this patch, the udp based tunnel configuration would not be correct. Cha

Re: [PATCH net-next 0/4] net: dsa: add port fast ageing

2016-09-22 Thread Florian Fainelli
On 09/22/2016 01:49 PM, Vivien Didelot wrote: > Today the DSA drivers are in charge of flushing the MAC addresses > associated to a port when its STP state changes from Learning or > Forwarding, to Disabled or Blocking or Listening. > > This makes the drivers more complex and hides this generic

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Shmulik Ladkani
Hi, On Thu, 22 Sep 2016 19:40:15 -0400 Jamal Hadi Salim wrote: > On 16-09-22 09:21 AM, Shmulik Ladkani wrote: > > From: Shmulik Ladkani > > > > Up until now, 'action mirred' supported only egress actions (either > > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > > > This patch implements the corres

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 14:30:53 +0300, Sergei Shtylyov wrote: >>Hello. > >On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> adds PHY-mode "trgmii" as an extension for the operation mode of the >> PHY interface for PHY_INTERFACE_MODE_TRGMII. .. deleted >> swit

[PATCHv2 iproute2 2/2] ip rule: add selector support

2016-09-22 Thread Hangbin Liu
Signed-off-by: Hangbin Liu --- ip/iprule.c| 180 +++-- man/man8/ip-rule.8 | 6 +- 2 files changed, 180 insertions(+), 6 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index e18505f..42fb6af 100644 --- a/ip/iprule.c +++ b/ip/iprule.c

[PATCHv2 iproute2 1/2] ip rule: merge ip rule flush and list, save together

2016-09-22 Thread Hangbin Liu
iprule_flush() and iprule_list_or_save() both call function rtnl_wilddump_request() and rtnl_dump_filter(). So merge them together just like other files do. Signed-off-by: Hangbin Liu --- ip/iprule.c | 121 +++- 1 file changed, 54 insertion

[PATCHv2 iproute2 0/2] ip rule: merger iprule_flush and add selector support

2016-09-22 Thread Hangbin Liu
When merge iprule_flush() and iprule_list_or_save(). Renamed rtnl_filter_t filter to filter_fn because we want to use global variable 'filter' to filter nlmsg in the next patch. Hangbin Liu (2): ip rule: merge ip rule flush and list, save together ip rule: add selector support ip/iprule.c

Re: [PATCH] net: VRF: Fix receiving multicast traffic

2016-09-22 Thread Mark Tomlinson
On 09/23/2016 10:41 AM, David Ahern wrote: > On 9/22/16 4:10 PM, Mark Tomlinson wrote: >> On 09/23/2016 03:14 AM, David Ahern wrote: >>> l3mdev devices do not support IPv4 multicast so checking mcast against that >>> device should not be working at all. For that reason I was fine with the >>> ch

Re: [PATCH iproute2 2/2] ip rule: add selector support

2016-09-22 Thread Hangbin Liu
2016-09-22 16:45 GMT+08:00 Phil Sutter : > On Thu, Sep 22, 2016 at 02:28:49PM +0800, Hangbin Liu wrote: > [...] >> diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 >> index 3508d80..ec0e31d 100644 >> --- a/man/man8/ip-rule.8 >> +++ b/man/man8/ip-rule.8 >> @@ -15,7 +15,8 @@ ip-rule \- routing po

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 19:48:47 +0300, Sergei Shtylyov wrote: >On 09/22/2016 07:16 PM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt > >These changes are unrelated to each other, so there should be 2 separate

[PATCH net] tcp: fix a compile error in DBGUNDO()

2016-09-22 Thread Eric Dumazet
From: Eric Dumazet If DBGUNDO() is enabled (FASTRETRANS_DEBUG > 1), a compile error will happen, since inet6_sk(sk)->daddr became sk->sk_v6_daddr Fixes: efe4208f47f9 ("ipv6: make lookups simpler and faster") Signed-off-by: Eric Dumazet --- net/ipv4/tcp_input.c |3 +-- 1 file changed, 1 ins

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-22 Thread David Miller
From: Sergei Shtylyov Date: Thu, 22 Sep 2016 20:08:47 +0300 >Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. I'll wait longer next time.

Re: [PATCH v2] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Alexei Starovoitov
On Thu, Sep 22, 2016 at 09:56:47PM +0200, Mickaël Salaün wrote: > This fix a pointer leak when an unprivileged eBPF program read a pointer > value from the context. Even if is_valid_access() returns a pointer > type, the eBPF verifier replace it with UNKNOWN_VALUE. The register > value containing a

Re: [PATCH net-next 0/4] net: dsa: add port fast ageing

2016-09-22 Thread Andrew Lunn
On Thu, Sep 22, 2016 at 04:49:20PM -0400, Vivien Didelot wrote: > Today the DSA drivers are in charge of flushing the MAC addresses > associated to a port when its STP state changes from Learning or > Forwarding, to Disabled or Blocking or Listening. > > This makes the drivers more complex and hid

Re: [PATCH iproute2 0/2] ip rule: merger iprule_flush and add selector support

2016-09-22 Thread Stephen Hemminger
On Thu, 22 Sep 2016 14:28:47 +0800 Hangbin Liu wrote: > When merge iprule_flush() and iprule_list_or_save(). Renamed > rtnl_filter_t filter to filter_fn because we want to use global > variable 'filter' to filter nlmsg in the next patch. > > Hangbin Liu (2): > ip rule: merge ip rule flush and

Re: [PATCH iproute2] ip: Use specific slave id

2016-09-22 Thread Stephen Hemminger
On Tue, 20 Sep 2016 18:02:12 +0800 Hangbin Liu wrote: > The original bond/bridge/vrf and slaves use same id, which make people > confused. Use bond/bridge/vrf_slave as id name will make code more clear. > > Acked-by: Phil Sutter > Signed-off-by: Hangbin Liu > --- Applied

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Jamal Hadi Salim
On 16-09-22 09:21 AM, Shmulik Ladkani wrote: From: Shmulik Ladkani Up until now, 'action mirred' supported only egress actions (either TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). This patch implements the corresponding ingress actions TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. This allows attachin

Re: [PATCH iproute2] misc/ss: tcp cwnd should be unsigned

2016-09-22 Thread Stephen Hemminger
On Thu, 22 Sep 2016 16:40:28 +0800 Hangbin Liu wrote: > tcp->snd_cwd is a u32, but ss treats it like a signed int. This may > results in negative bandwidth calculations. > > Signed-off-by: Hangbin Liu Sure applied.

Re: [PATCH iproute2] ss: Support displaying and filtering on socket marks.

2016-09-22 Thread Stephen Hemminger
On Thu, 22 Sep 2016 01:02:50 +0900 Lorenzo Colitti wrote: > This allows the user to dump sockets with a given mark (via > "fwmark = 0x1234/0x1234" or "fwmark = 12345", etc.) , and to > display the socket marks of dumped sockets. > > The relevant kernel commits are: d545caca827b ("net: inet: diag

[PATCH net-next 2/3] bpf: use bpf_get_smp_processor_id_proto instead of raw one

2016-09-22 Thread Daniel Borkmann
Same motivation as in commit 80b48c445797 ("bpf: don't use raw processor id in generic helper"), but this time for XDP typed programs. Thus, allow for preemption checks when we have DEBUG_PREEMPT enabled, and otherwise use the raw variant. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoit

[PATCH net-next 3/3] bpf: add helper to invalidate hash

2016-09-22 Thread Daniel Borkmann
Add a small helper that complements 36bbef52c7eb ("bpf: direct packet write and access for helpers for clsact progs") for invalidating the current skb->hash after mangling on headers via direct packet write. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- include/uapi/linux/bpf.

[PATCH net-next 1/3] bpf: use skb_to_full_sk helper in bpf_skb_under_cgroup

2016-09-22 Thread Daniel Borkmann
We need to use skb_to_full_sk() helper introduced in commit bd5eb35f16a9 ("xfrm: take care of request sockets") as otherwise we miss tcp synack messages, since ownership is on request socket and therefore it would miss the sk_fullsock() check. Use skb_to_full_sk() as also done similarly in the bpf_

Re: [Patch net] sch_sfb: keep backlog updated with qlen

2016-09-22 Thread Jamal Hadi Salim
On 16-09-18 07:22 PM, Cong Wang wrote: Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim cheers, jamal

[PATCH net-next 0/3] Few minor BPF helper improvements

2016-09-22 Thread Daniel Borkmann
Just a few minor improvements around BPF helpers, first one is a fix but given this late stage and that it's not really a critical one, I think net-next is just fine. For details please see the individual patches. Thanks! Daniel Borkmann (3): bpf: use skb_to_full_sk helper in bpf_skb_under_cgro

Re: [Patch net] sch_qfq: keep backlog updated with qlen

2016-09-22 Thread Jamal Hadi Salim
On 16-09-18 07:22 PM, Cong Wang wrote: Reported-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim cheers, jamal

Re: [Patch net-next] net_sched: check NULL on error path in route4_change()

2016-09-22 Thread Jamal Hadi Salim
On 16-09-18 06:52 PM, Cong Wang wrote: On error path in route4_change(), 'f' could be NULL, so we should check NULL before calling tcf_exts_destroy(). Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()") Reported-by: kbuild test robot Cc: Jamal Hadi Salim Signed-

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 19:34 -0300, Marcelo Ricardo Leitner wrote: > On Sat, Aug 27, 2016 at 07:37:54AM -0700, Eric Dumazet wrote: > > +bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb) > > +{ > > + u32 limit = sk->sk_rcvbuf + sk->sk_sndbuf; > ^^^ > ... >

Re: [PATCH net 1/2] act_ife: Fix external mac header on encode

2016-09-22 Thread Jamal Hadi Salim
On 16-09-22 08:55 AM, Yotam Gigi wrote: On ife encode side, external mac header is copied from the original packet and may be overridden if the user requests. Before, the mac header copy was done from memory region that might not be accessible anymore, as skb_cow_head might free it and copy the p

[PATCH net-next] drivers: net: xgene: Fix MSS programming

2016-09-22 Thread Iyappan Subramanian
Current driver programs static value of MSS in hardware register for TSO offload engine to segment the TCP payload regardless the MSS value provided by network stack. This patch fixes this by programming hardware registers with the stack provided MSS value. Since the hardware has the limitation o

Re: [PATCH] net: VRF: Fix receiving multicast traffic

2016-09-22 Thread David Ahern
On 9/22/16 4:10 PM, Mark Tomlinson wrote: > > On 09/23/2016 03:14 AM, David Ahern wrote: >> >> l3mdev devices do not support IPv4 multicast so checking mcast against that >> device should not be working at all. For that reason I was fine with the >> change in the previous patch. ie., you want th

Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-22 Thread Jamal Hadi Salim
On 16-09-21 08:54 AM, Yotam Gigi wrote: Without that fix, the following could occur: - On encode ingress, the total amount of skb_pushes (in lines 751 and 753) was more than specified in cow. - On machines with hard_header_len > mac_len, the packet format was not Just curious: What hardwar

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-09-22 Thread Marcelo Ricardo Leitner
On Sat, Aug 27, 2016 at 07:37:54AM -0700, Eric Dumazet wrote: > +bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb) > +{ > + u32 limit = sk->sk_rcvbuf + sk->sk_sndbuf; ^^^ ... > + if (!skb->data_len) > + skb->truesize = SKB_TRUESIZE(skb_e

Re: [PATCH] net: VRF: Fix receiving multicast traffic

2016-09-22 Thread Mark Tomlinson
On 09/23/2016 03:14 AM, David Ahern wrote: > > l3mdev devices do not support IPv4 multicast so checking mcast against that > device should not be working at all. For that reason I was fine with the > change in the previous patch. ie., you want the real ingress device there not > the vrf device.

[PATCH 2/7] hv_netvsc: dev hold/put reference to VF

2016-09-22 Thread sthemmin
From: Stephen Hemminger The netvsc driver holds a pointer to the virtual function network device if managing SR-IOV association. In order to ensure that the VF network device does not disappear, it should be using dev_hold/dev_put to get a reference count. Signed-off-by: Stephen Hemminger ---

[PATCH 4/7] hv_netvsc: improve VF device matching

2016-09-22 Thread sthemmin
From: Stephen Hemminger The code to associate netvsc and VF devices can be made less error prone by using a better matching algorithms. On registration, use the permanent address which avoids any possible issues caused by device MAC address being changed. For all other callbacks, search by the n

[PATCH 5/7] hv_netvsc: use RCU to protect vf_netdev

2016-09-22 Thread sthemmin
From: Stephen Hemminger The vf_netdev pointer in the netvsc device context can simply be protected by RCU because network device destruction is already RCU synchronized. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2 +- drivers/net/hyperv/netvsc_drv.c | 29 +

[PATCH 6/7] hv_netvsc: remove VF in flight counters

2016-09-22 Thread sthemmin
From: Stephen Hemminger Since VF reference is now protected by RCU, no longer need the VF usage counter and can use device flags to see whether to inject or not. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |3 +- drivers/net/hyperv/netvsc_drv.c | 81 ++---

[PATCH net-next 0/7] hv_netvsc changes

2016-09-22 Thread sthemmin
From: Stephen Hemminger These are mostly about improving the handling of interaction between the virtual network device (netvsc) and the SR-IOV VF network device. Stephen Hemminger (7): hv_netvsc: use consume_skb hv_netvsc: dev hold/put reference to VF hv_netvsc: simplify callback event co

[PATCH 1/7] hv_netvsc: use consume_skb

2016-09-22 Thread sthemmin
From: Stephen Hemminger Packets that are transmitted in normal path should use consume_skb instead of kfree_skb. This allows for better tracing of packet drops. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/7] hv_netvsc: simplify callback event code

2016-09-22 Thread sthemmin
From: Stephen Hemminger The callback handler for netlink events can be simplified: * Consolidate check for netlink callback events about this driver itself. * Ignore non-Ethernet devices. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 28 ++--

[PATCH 7/7] hv_netvsc: count multicast packets received

2016-09-22 Thread sthemmin
From: Stephen Hemminger Useful for debugging issues with multicast and SR-IOV to keep track of number of received multicast packets. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2 ++ drivers/net/hyperv/netvsc_drv.c |9 - 2 files changed, 10 insertions(

rfc: Are any of the seq_pad() uses really necessary?

2016-09-22 Thread Joe Perches
$ git grep -w seq_pad net net/ipv4/fib_trie.c:seq_pad(seq, '\n'); net/ipv4/ping.c:seq_pad(seq, '\n'); net/ipv4/tcp_ipv4.c:seq_pad(seq, '\n'); net/ipv4/udp.c: seq_pad(seq, '\n'); net/phonet/socket.c:seq_pad(seq, '\n'); net/phonet/socket.c:seq_pad(seq, '\n'); net/sctp/

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-22 Thread Sowmini Varadhan
On (09/22/16 01:52), David Miller wrote: > Alternatively we can do Alexander Duyck's trick, by pushing > the headers into the frag list, forcing a pull and realignment > by the next protocol layer. What is the "Alexander Duyck trick" (hints about module or commit id, where this can be found, pleas

Re: [PATCH] L2TP:Adjust intf MTU, add underlay L3, overlay L2

2016-09-22 Thread R. Parameswaran
On Thu, 22 Sep 2016, Derek Fawcus wrote: > On Wed, Sep 21, 2016 at 02:11:04pm -0700, R. Parameswaran wrote: > > > [snip] > > > @@ -206,6 +209,46 @@ static void l2tp_eth_show(struct seq_file *m, void > > *arg) > > } > > #endif > [snip] > > > + > > static int l2tp_eth_create(struct net *net,

[PATCH v2 net-next 1/2] bnx2x: allocate mac filtering 'mcast_list' in PAGE_SIZE increments

2016-09-22 Thread Jason Baron
From: Jason Baron Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for 'mcast_list' to be done in

[PATCH v2 net-next 2/2] bnx2x: allocate mac filtering pending list in PAGE_SIZE increments

2016-09-22 Thread Jason Baron
From: Jason Baron Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for the pending list to be don

[PATCH v2 net-next 0/2] bnx2x: page allocation failure

2016-09-22 Thread Jason Baron
Hi, While configuring ~500 multicast addrs, we ran into high order page allocation failures. They don't need to be high order, and thus I'm proposing to split them into at most PAGE_SIZE allocations. Below is a sample failure. Thanks, -Jason [1201902.617882] bnx2x: [bnx2x_set_mc_list:12374(eth

[PATCH net-next 0/4] net: dsa: add port fast ageing

2016-09-22 Thread Vivien Didelot
Today the DSA drivers are in charge of flushing the MAC addresses associated to a port when its STP state changes from Learning or Forwarding, to Disabled or Blocking or Listening. This makes the drivers more complex and hides this generic switch logic. This patchset introduces a new optional por

[PATCH net-next 3/4] net: dsa: b53: implement DSA port fast ageing

2016-09-22 Thread Vivien Didelot
Remove the fast ageing logic from b53_br_set_stp_state and implement the new DSA switch port_fast_age operation instead. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/driver

[PATCH net-next 2/4] net: dsa: add port fast ageing

2016-09-22 Thread Vivien Didelot
Today the DSA drivers are in charge of flushing the MAC addresses associated to a port when its STP state changes from Learning or Forwarding, to Disabled or Blocking or Listening. This makes the drivers more complex and hides the generic switch logic. Introduce a new optional port_fast_age operat

[PATCH net-next 1/4] net: dsa: add port STP state helper

2016-09-22 Thread Vivien Didelot
Add a void helper to set the STP state of a port, checking first if the required routine is provided by the driver. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 9ec

[PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-22 Thread R. Parameswaran
>From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 From: "R. Parameswaran" Date: Thu, 22 Sep 2016 13:19:25 -0700 Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2 Take into account all of the tunnel encapsulation headers when setting up the MTU on the L2TP l

[PATCH net-next 4/4] net: dsa: mv88e6xxx: implement DSA port fast ageing

2016-09-22 Thread Vivien Didelot
Now that the DSA layer handles port fast ageing on correct STP change, simplify _mv88e6xxx_port_state and implement mv88e6xxx_port_fast_age. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 45 1 file changed, 23 insertions(+), 22 dele

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 13:34 -0700, Eric Dumazet wrote: > On Thu, 2016-09-22 at 22:27 +0200, Paolo Abeni wrote: > > On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > > > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > > > > > I think that the idea behind using atomic ops directly

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 22:27 +0200, Paolo Abeni wrote: > On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > > > I think that the idea behind using atomic ops directly on > > > sk_forward_alloc is to avoid adding other fields to the

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Paolo Abeni
On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > I think that the idea behind using atomic ops directly on > > sk_forward_alloc is to avoid adding other fields to the udp_socket. > > > > If we can add some fields to the udp_sock

[PATCH v2] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then allowed to leak. Moreover, this prevented unprivileged

Re: [PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
On 22/09/2016 21:41, Daniel Borkmann wrote: > On 09/22/2016 08:35 PM, Mickaël Salaün wrote: >> This fix a pointer leak when an unprivileged eBPF program read a pointer >> value from the context. Even if is_valid_access() returns a pointer >> type, the eBPF verifier replace it with UNKNOWN_VALUE. T

Re: [PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Daniel Borkmann
On 09/22/2016 08:35 PM, Mickaël Salaün wrote: This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then allowe

[RFC] net: store port/representative id in metadata_dst

2016-09-22 Thread Jakub Kicinski
Switches and modern SR-IOV enabled NICs may multiplex traffic from representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to comfortably use TC infrastructure today unless we have a way o

Fwd: Re: nfs broken on Fedora-24, 32-bit?

2016-09-22 Thread Ben Greear
This is probably not an NFS specific issue, though I guess possibly it is. Forwarding to netdev in case someone wants to take a look at it. Thanks, Ben Forwarded Message Subject: Re: nfs broken on Fedora-24, 32-bit? Date: Fri, 16 Sep 2016 16:31:51 -0700 From: Ben Greear Org

CONGRATULATIONS !!!

2016-09-22 Thread Cheveron Texaco
Attention Winner, Congratulations !!! Your email Address has won you a substantial amount of 1 Million United States dollars in the just concluded Chevron Texaco Promo-Lottery. You are to contact your claim agent for claims process at Email: chevron.claimsagent1...@gmail.com Best Regards

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
On Thu, Sep 22, 2016, at 19:20, Cong Wang wrote: > > I don't think it is a big issue but wanted the writes to the > > rtnl_msg_handlers array to be strictly serialized. I was working on > > adding this to other places, too. Maybe better for net-next even? > > But they are called during boot, why i

[PATCH v3] tcp: fix wrong checksum calculation on MTU probing

2016-09-22 Thread Douglas Caetano dos Santos
With TCP MTU probing enabled and offload TX checksumming disabled, tcp_mtu_probe() calculated the wrong checksum when a fragment being copied into the probe's SKB had an odd length. This was caused by the direct use of skb_copy_and_csum_bits() to calculate the checksum, as it pads the fragment bein

Re: [PATCH 2/2] net: thunderx: Support for byte queue limits

2016-09-22 Thread Florian Fainelli
On 09/22/2016 02:05 AM, sunil.kovv...@gmail.com wrote: > From: Sunil Goutham > > This patch adds support for byte queue limits > > Signed-off-by: Sunil Goutham Where is the code that calls netdev_tx_reset_queue()? This is needed in the function that brings down the interface, did your test sur

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 21:27 +0300, Shmulik Ladkani wrote: > On Thu, 22 Sep 2016 07:54:13 -0700 Eric Dumazet > wrote: > > Hmm... we probably need to apply the full rcu protection before this > > patch. > > > > https://patchwork.ozlabs.org/patch/667680/ > > Are you referring to order of applicati

Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

2016-09-22 Thread Vishwanath Pai
Thanks for pointing this out, I will reorder the fields to: struct hashlimit_cfg2 { __u64 avg;/* Average secs between packets * scale */ __u64 burst; __u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */ This should fix the hole and avoid padding. -Vishwanath On 09/22/201

[PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then allowed to leak. Moreover, this prevented unprivileged

Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani
On Thu, 22 Sep 2016 09:05:04 -0700 Stephen Hemminger wrote: > On Thu, 22 Sep 2016 12:31:10 +0300 > Shmulik Ladkani wrote: > > > + > > +static const char *action_name(int action) > > +{ > > + static const char * const names[] = { > > + [TCA_VLAN_ACT_POP] = "pop", > > + [TCA

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Shmulik Ladkani
On Thu, 22 Sep 2016 07:54:13 -0700 Eric Dumazet wrote: > Hmm... we probably need to apply the full rcu protection before this > patch. > > https://patchwork.ozlabs.org/patch/667680/ Are you referring to order of application into net-next? This patch seems to present no new tcf_mirred_params mem

Re: XDP (eXpress Data Path) documentation

2016-09-22 Thread Jesper Dangaard Brouer
On Tue, 20 Sep 2016 11:08:44 +0200 Jesper Dangaard Brouer wrote: > As promised, I've started documenting the XDP eXpress Data Path): > > [1] > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > IMHO the documentation have reached a stage where it is useful for t

[PATCH][V2] cxgb4: fix signed wrap around when decrementing index idx

2016-09-22 Thread Colin King
From: Colin Ian King Change predecrement compare to post decrement compare to avoid an unsigned integer wrap-around comparison when decrementing idx in the while loop. For example, when idx is zero, the current situation will predecrement idx in the while loop, wrapping idx to the maximum signed

[PATCH v2 iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani
The 'vlan modify' action allows to replace an existing 802.1q tag according to user provided settings. It accepts same arguments as the 'vlan push' action. For example, this replaces vid 6 with vid 5: # tc filter add dev veth0 parent : pref 1 protocol 802.1q \ basic match 'meta(vlan ma

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

2016-09-22 Thread Vlastimil Babka
On 09/22/2016 07:07 PM, Eric Dumazet wrote: On Thu, 2016-09-22 at 18:56 +0200, Vlastimil Babka wrote: On 09/22/2016 06:49 PM, Eric Dumazet wrote: > On Thu, 2016-09-22 at 18:43 +0200, Vlastimil Babka wrote: >> The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows >> with the

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Cong Wang
On Thu, Sep 22, 2016 at 6:41 AM, Hannes Frederic Sowa wrote: > On 22.09.2016 15:03, Eric Dumazet wrote: >> On Thu, 2016-09-22 at 13:03 +0200, Hannes Frederic Sowa wrote: >>> Signed-off-by: Hannes Frederic Sowa >>> --- >>> net/core/net_namespace.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-22 Thread Sergei Shtylyov
Hello. On 09/22/2016 03:22 PM, David Miller wrote: By default, GMAC0 is connected to built-in switch called MT7530 through the proprietary interface called Turbo RGMII (TRGMII). TRGMII also supports well for RGMII as generic external PHY uses but requires some slight changes to the setup of TRG

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 18:56 +0200, Vlastimil Babka wrote: > On 09/22/2016 06:49 PM, Eric Dumazet wrote: > > On Thu, 2016-09-22 at 18:43 +0200, Vlastimil Babka wrote: > >> The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > >> with the number of fds passed. We had a custome

Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

2016-09-22 Thread Jan Engelhardt
On Thursday 2016-09-22 18:43, Vishwanath Pai wrote: >+struct hashlimit_cfg2 { >+ __u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */ >+ __u64 avg;/* Average secs between packets * scale */ >+ __u64 burst; /* Period multiplier for upper limit. */ This would have different si

  1   2   3   >