[PATCH v2] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-09-03 Thread Brenden Blanco
Depending on the preempt mode, the bpf_prog stored in xdp_prog may be freed despite the use of call_rcu inside bpf_prog_put. The situation is possible when running in PREEMPT_RCU=y mode, for instance, since the rcu callback for destroying the bpf prog can run even during the bh handling in the mlx4

Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

2016-09-03 Thread Julian Calaby
Hi All, On Mon, Aug 8, 2016 at 5:39 PM, Christophe JAILLET wrote: > This patch should be a no-op. It just simplifies code by using the name of > a variable instead of its type when calling 'sizeof'. > > Signed-off-by: Christophe JAILLET Reviewed-by: Julian Calaby Thanks, -- Julian Calaby E

Re: [PATCH 4/4] net: smsc911x: Move interrupt allocation to open/stop

2016-09-03 Thread Andrew Lunn
> > Hmm, I didn't see where this code got moved to... > >Ah, it's the duplicated code... you should've either explicitly > stated that in the change log or done this in a separate patch, I > think. Hi Sergei Maybe you should read the comments I made :-) Andrew

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

2016-09-03 Thread Julian Calaby
Hi All, On Tue, Aug 30, 2016 at 3:05 AM, Joe Perches wrote: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches This all looks correct to me. I wish you'd

Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

2016-09-03 Thread Julian Calaby
Hi All, On Sun, Sep 4, 2016 at 2:43 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/pro

Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling

2016-09-03 Thread Alison Chaiken
I asked on 2016-06-07 17:19:43 [-0700]: >>cpsw_rx_poll() is called even when there is essentially no network >>traffic, so I'm not sure how to tell if NAPI is working as intended. On Thu, Jun 9, 2016 at 5:37 AM, Sebastian Andrzej Siewior wrote: > You should see an invocation of __raise_softirq_i

Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

2016-09-03 Thread Sergei Shtylyov
On 09/01/2016 11:15 PM, Jeremy Linton wrote: Move phy startup/shutdown into the smsc911x_open/stop routines. This allows the module to be unloaded because phy_connect_direct is no longer always holding the module use count. This one change also resolves a number of other problems. The link stat

Re: [PATCH 4/4] net: smsc911x: Move interrupt allocation to open/stop

2016-09-03 Thread Sergei Shtylyov
On 09/03/2016 10:23 PM, Sergei Shtylyov wrote: The /proc/irq/xx information is incorrect for smsc911x because the request_irq is happening before the register_netdev has the proper device name. Moving it to the open also fixes the case of when the device is renamed. Reported-by: Will Deacon Si

Re: [PATCH 4/4] net: smsc911x: Move interrupt allocation to open/stop

2016-09-03 Thread Sergei Shtylyov
On 09/01/2016 11:15 PM, Jeremy Linton wrote: The /proc/irq/xx information is incorrect for smsc911x because the request_irq is happening before the register_netdev has the proper device name. Moving it to the open also fixes the case of when the device is renamed. Reported-by: Will Deacon Sign

Re: wcn36xx: Implement print_reg indication

2016-09-03 Thread Kalle Valo
Bjorn Andersson wrote: > Some firmware versions sends a "print register indication", handle this > by printing out the content. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson This doesn't apply anymore, please rebase. -- Sent by pwcli https://patchwork.kernel.org/patch/9208737/

Re: ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-03 Thread Kalle Valo
Giedrius Statkevi?ius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the

Re: [ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

2016-09-03 Thread Eric Garver
Pravin, Thanks for the feedback. Some replies below. Thanks. Eric. On Fri, Sep 02, 2016 at 02:42:30PM -0700, pravin shelar wrote: > On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > > Add support for 802.1ad including the ability to push and pop double > > tagged vlans. Add support for 802.1

Re: [v2,1/1] brcmfmac: fix pmksa->bssid usage

2016-09-03 Thread Kalle Valo
Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const u8 *bssid; > > contrary to struct brcmf_pmksa, which uses: > > u8 bssid[ETH_ALEN]; > > Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address > of this field (of type u8**), not the

Re: zd1211rw: fix spelling mistake "firmeware" -> "firmware"

2016-09-03 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks, 1 patch applied to wireless-drivers-next.git: b46b599328e6 zd1211rw: fix spelling mistake "firmeware" -> "firmware" --

Re: [PATCH 1/2] Revert "af_unix: Fix splice-bind deadlock"

2016-09-03 Thread Shmulik Ladkani
On Fri, 2 Sep 2016 11:09:23 -0700 (PDT) Linus Torvalds wrote: > From: Linus Torvalds > Date: Thu, 1 Sep 2016 14:56:49 -0700 > Subject: [PATCH 1/2] Revert "af_unix: Fix splice-bind deadlock" > > This reverts commit c845acb324aa85a39650a14e7696982ceea75dc1. > > It turns out that it just replaces

[PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

2016-09-03 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistakes in dev_dbg message. Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/dri

[PATCH][V2] ath10k: fix memory leak on caldata on error exit path

2016-09-03 Thread Colin King
From: Colin Ian King caldata is not being free'd on the error exit path, causing a memory leak and data definitely should not be freed. Free caldata instead of data. Thanks to Kalle Valo for spotting that data should not be free'd. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/at

Re: [PATCH] ath10k: fix memory leak on caldata on error exit path

2016-09-03 Thread Colin Ian King
On 02/09/16 16:45, Valo, Kalle wrote: > Colin King writes: > >> From: Colin Ian King >> >> caldata is not being free'd on the error exit path, causing >> a memory leak. kfree it to fix the leak. >> >> Signed-off-by: Colin Ian King >> --- >> drivers/net/wireless/ath/ath10k/pci.c | 1 + >> 1 fil

Re: [PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-03 Thread Giedrius Statkevičius
Some more users complaining about this: https://bbs.archlinux.org/viewtopic.php?id=215978 On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop

Re: [ovs-dev] [PATCH net-next v21 4/4] openvswitch: report error on VLAN nlattr in ovs_key_from_nlattrs()

2016-09-03 Thread Eric Garver
On Fri, Sep 02, 2016 at 02:42:41PM -0700, pravin shelar wrote: > On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > > With 802.1ad support these are parsed and set upfront by > > parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called. > > As such we should never see a VLAN attrib

[PATCH 1/1] vxlan: make the struct nlattr variable const

2016-09-03 Thread zyjzyj2000
From: Zhu Yanjun The struct nlattr variable should not be changed. Signed-off-by: Zhu Yanjun --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f605a36..ce65897 100644 --- a/drivers/net/vxlan.c +++ b/d

Re: 6pack: stack-out-of-bounds in sixpack_receive_buf

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer I've got the following report: BUG: KASAN: stack-out-of-bounds in sixpack_receive_buf+0xf8a/0x1450 at addr 880037fbf850 Read of size 1 by task syz-executor/6759 page:eadfefc0 count:0 mapcount:0 mapping: (null) index:0x0 flags: 0x1fffc

6pack: stack-out-of-bounds in sixpack_receive_buf

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer I've got the following report: BUG: KASAN: stack-out-of-bounds in sixpack_receive_buf+0xf8a/0x1450 at addr 880037fbf850 Read of size 1 by task syz-executor/6759 page:eadfefc0 count:0 mapcount:0 mapping: (null) index:0x0 flags: 0x1fffc

Re: fix:rtl8xxxu_core: mark symbols static where possible

2016-09-03 Thread Jes Sorensen
Kalle Valo writes: > Baoyou Xie wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >> [-Wmi

[PATCH v3 nf] netfilter: seqadj: Fix one possible panic in seqadj when mem is exhausted

2016-09-03 Thread fgao
From: Gao Feng When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj extension. But the function nf_ct_seqadj_init doesn't check if get valid seqadj pointer by the nfct_seqadj, while other functions perform the sanity check. So the system would be panic when nfct_seqadj_ext_ad

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-09-03 Thread Dmitry Vyukov
On Tue, Mar 22, 2016 at 1:32 PM, Dmitry Vyukov wrote: > On Tue, Mar 22, 2016 at 9:09 AM, Jiri Slaby wrote: >> On 03/21/2016, 04:58 PM, Jiri Slaby wrote: >>> Hello, >>> >>> On 03/18/2016, 09:52 PM, Tejun Heo wrote: On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: >>> I have not

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-09-03 Thread Kalle Valo
Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. > > Signed-off-by: Javier Martinez Canillas What's the conclusion with this patch? Should I drop it or take it?

Re: fix:rtl8xxxu_core: mark symbols static where possible

2016-09-03 Thread Kalle Valo
Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the rtl8xxxu rtl8xxxu_core.c when building with W=1: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no > previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] > > In fa

Re: [v4] brcmfmac: add missing header dependencies

2016-09-03 Thread Kalle Valo
Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: > no previous prototype for '__brcmf_err' [-Wmissing-prototypes] > > In fact, this function is declared in brcmfmac/debug.h, so this patch > adds

Re: [1/1] mwifiex: remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > for_each_property_of_node is only executed if the > property prop is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git: 2f69e67058fb mwifiex: remove superfluous condition -- Sent by

Re: [1/1] mwifiex: key_material_v2 remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git: b0d80f19c14f mwifiex: key_material_v2 remo

Re: mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

2016-09-03 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The IEEE80211_STYPE_ACTION case is missing a break in the switch > statement, causing it to fall through to the default case that > reports a debug message about an unknown frame subtype. Fix this > by adding in the missing break statement. > > S

Re: [1/2] mwifiex: fix the length parameter of a memset

2016-09-03 Thread Kalle Valo
Christophe Jaillet wrote: > In 'mwifiex_get_ver_ext', we have: >struct mwifiex_ver_ext ver_ext; > >memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); > > This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. > Remove the ambiguity by using the variable nam

Re: [1/1,v2] rtlwifi: remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > If sta == NULL, the changed line will not be reached. > So no need to check that sta != NULL here. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git: f898005ff99f rtlwifi: remove superfluous condit

Re: wl3501_cs: Add spinlock to wl3501_reset

2016-09-03 Thread Kalle Valo
Pavel Andrianov wrote: > Likely wl3501_reset should acquire spinlock as wl3501_{open, close}. > One of calls of wl3501_reset has been already protected. > The others were unprotected and might lead to a race condition. > The patch adds spinlock into the wl3501_reset and removes it from > wl3501_t

[PATCH net-next v5 2/2] net: ethernet: mediatek: enhance RX path by aggregating more SKBs into NAPI

2016-09-03 Thread sean.wang
From: Sean Wang The patch adds support for aggregating more SKBs feed into NAPI in order to get more benefits from generic receive offload (GRO) by peeking at the RX ring status and moving more packets right before returning from NAPI RX polling handler if NAPI budgets are still available and som

[PATCH net-next v5 1/2] net: ethernet: mediatek: enhance RX path by reducing the frequency of the memory barrier used

2016-09-03 Thread sean.wang
From: Sean Wang The patch makes move wmb() to outside the loop that could help RX path handling more faster although that RX descriptors aren't freed for DMA to use as soon as possible, but based on my experiment and the result shows it still can reach about 943Mbpis without performance drop that

[PATCH net-next v5 0/2] net: ethernet: mediatek: add enhancements to RX path

2016-09-03 Thread sean.wang
From: Sean Wang Changes since v1: - fix message typos and add coverletter Changes since v2: - split from the previous series for submitting add enhancements as a series targeting 'net-next' and add indents before comments. Changes since v3: - merge the patch using PDMA RX path - fixed the in

Re: Centralizing support for TCAM?

2016-09-03 Thread Jiri Pirko
Fri, Sep 02, 2016 at 08:49:34PM CEST, john.fastab...@gmail.com wrote: >On 16-09-02 10:18 AM, Florian Fainelli wrote: >> Hi all, >> > >Hi Florian, > >> (apologies for the long CC list and the fact that I can't type correctly >> email addresses) >> > >My favorite topic ;) > >> While working on addi