[net-next 11/15] i40e: Initialize pointer in client_release function

2016-08-19 Thread Jeff Kirsher
From: Harshitha Ramamurthy The function i40e_client_release has a print statement that uses an adapter pointer which is not initialized if a previous if statement is not true. Hence, intialize it in the right place. Change-ID: I1afdaa2c46771ac42be56edcc41bb56b455b06c8 Signed-off-by: Harshitha Ra

[net-next 12/15] i40e: Remove XSTRINGIFY macro definitions and uses

2016-08-19 Thread Jeff Kirsher
From: Joe Perches Use __stringify instead. Signed-off-by: Joe Perches Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h| 4 drivers/net/ethernet/intel/i40e/i40e_client.h | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) d

[net-next 13/15] i40e: Correcting mutex usage in client code

2016-08-19 Thread Jeff Kirsher
From: Avinash Dayanand Correcting the mutex usage, in client_subtask(), mutex_unlock has to be called just before client_del_instance() since this function opens and later closes the same mutex again. Similarly in client_is_registered removing the mutex since it closes the mutex twice. This is a

Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

2016-08-19 Thread Xin Long
> Ah, I see what you're doing. Ok, this makes some sense, at least on the > receive > side, when you get a cookie unpacked and modify the remote peers address list, > it makes sense to check for duplicates. On the local side however, I would, > instead of checking it when the list gets copied, I

Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when reentrant

2016-08-19 Thread Feng Gao
On Sat, Aug 20, 2016 at 5:48 AM, Guillaume Nault wrote: > On Fri, Aug 19, 2016 at 11:16:41PM +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> PPP channel holds one spinlock before send frame. But the skb may >> select the same PPP channel with wrong route policy. As a result, >> the skb reac

[net-next 15/15] i40evf: Open RDMA Client after reset

2016-08-19 Thread Jeff Kirsher
From: Avinash Dayanand RDMA client is closed during the PF reset and needs to be opened again. Setting the flag so that RDMA client is opened in watchdog() function. Change-ID: I507b1e4cbd05528cdff68fd360ef3dcac8901263 Signed-off-by: Avinash Dayanand Tested-by: Andrew Bowers Signed-off-by: Jef

[net-next 14/15] i40e/i40evf: Fix indentation

2016-08-19 Thread Jeff Kirsher
Several defines and code comments were indented with spaces instead of tabs, correct the issue to make indentation consistent. Change-ID: I0dc6bbb990ec4a9e856acc9ec526d876181f092c Signed-off-by: Jeff Kirsher Tested-by: Andrew Bowers --- drivers/net/ethernet/intel/i40e/i40e.h | 131 +

[PATCH net-next] cxgb4/cxgb4vf: Add support for IFLA_VF_VLAN

2016-08-19 Thread Hariprasad Shenai
Adds support for ndo_set_vf_vlan for cxgb4 driver Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h index 6b0528913687..f354f

Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal number

2016-08-19 Thread Feng Gao
Sorry, I forget to modify the title. I will sent another update. On Sat, Aug 20, 2016 at 2:28 AM, Guillaume Nault wrote: > On Fri, Aug 19, 2016 at 05:55:26PM +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> 1. Use PPP_ALLSTATIONS/PPP_UI instead of literal 0xff/0x03; >> 2. Use one static con

[net-next 07/15] i40e: Fix byte ordering in ARP NS code for X722

2016-08-19 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes byte ordering problems found when enabling this feature support. Without this patch, the feature will not work correctly. This patch fixes the definitions to have the correct byte order. Change-ID: Ic7489fbcbe2195df7be62ff5e359201b827cefe6 Signed-off-by: Ca

[net-next 09/15] i40e: use matching format identifiers

2016-08-19 Thread Jeff Kirsher
From: Heinrich Schuchardt i is defined as int but output as %u several times. Adjust the format identifiers. Signed-off-by: Heinrich Schuchardt Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 +- 1 file chan

[net-next 10/15] i40e: Check client is open before calling client ops

2016-08-19 Thread Jeff Kirsher
From: Catherine Sullivan We were having a race between the completion of the client open and calls to the client ops so don't call a client op unless we are sure the client is open. Change-Id: I741f4f2aa4fcbfdad3e40da1b005856c396b Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers

[net-next 08/15] i40e: Add support for HMC resource and profile for X722

2016-08-19 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds support for HMC resource and profile cmds for X722 firmware. Change-ID: Icc332101f38ab15d1bfa167823100eb4f6822f7e Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h

[net-next 02/15] i40e: fix broken i40e_config_rss_aq function

2016-08-19 Thread Jeff Kirsher
From: Jacob Keller X722 hardware requires using the admin queue to configure RSS. This function was previously re-written in commit e69ff813af35 ("i40e: rework the functions to configure RSS with similar parameters"). However, the previous refactor did not work correctly for a few reasons (a) it

[net-next 05/15] i40evf: report link speed

2016-08-19 Thread Jeff Kirsher
From: Mitch Williams The PF driver tells us the link speed, so do something with that information. Add link speed to log messages, and report speed through ethtool. Change-Id: I279dc9540cc5203376406050a3e8d67e128d5882 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff K

[net-next 03/15] i40e: use configured RSS key and lookup table in i40e_vsi_config_rss

2016-08-19 Thread Jeff Kirsher
From: Jacob Keller A previous refactor added support to store user configuration for VSIs, so that extra VSIs such as for VMDq can use this information when configuring. Unfortunately the i40e_vsi_config_rss function was missed in this refactor, and the values were being ignored. Fix this by chec

[net-next 06/15] i40e: refactor tail_bump check

2016-08-19 Thread Jeff Kirsher
From: Carolyn Wyborny This patch refactors tail bump check. Change-ID: Ide0e19171d67d90cb2b06b8dcd4fa791ae120160 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++ drivers/net/ethernet/intel/i40evf

[net-next 01/15] i40e: move i40e_vsi_config_rss below i40e_get_rss_aq

2016-08-19 Thread Jeff Kirsher
From: Jacob Keller Move this function below the two functions related to configuring RSS via the admin queue. This helps co-locate the two functions, and made it easier to spot a bug in the first i40e_config_rss_aq function as compared to the i40e_get_rss_aq function. Signed-off-by: Jacob Keller

[net-next 04/15] i40e: use alloc_workqueue instead of create_singlethread_workqueue

2016-08-19 Thread Jeff Kirsher
From: Jacob Keller Replace calls to create_singlethread_workqueue instead with alloc_workqueue as is style with other Intel drivers. This provides more control over workqueue creation, and allows explicit setting of the desired mode of operation. It also makes it more obvious that driver name con

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-08-19

2016-08-19 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Jake provides several patches, first just moves a function to co-locate the two functions related to configuring RSS via the admin queue, which should help in spotting bugs when comparing the two functions. Fixed an issue where commit e69ff813

[PATCH] mlx5/core: Use memdup_user() rather than duplicating its implementation

2016-08-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 20 Aug 2016 07:50:09 +0200 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. * Return directly if this copy operation failed. Signed-off-by: Markus Elfring -

Re: [PATCH net] vmxnet3: fix tx data ring copy for variable size

2016-08-19 Thread David Miller
From: Shrikrishna Khare Date: Fri, 19 Aug 2016 10:33:42 -0700 > 'Commit 3c8b3efc061a ("vmxnet3: allow variable length transmit data ring > buffer")' changed the size of the buffers in the tx data ring from a > fixed size of 128 bytes to a variable size. > > However, while copying data to the dat

Re: [PATCHv2,net-next] samples/bpf: Add tunnel set/get tests.

2016-08-19 Thread David Miller
From: William Tu Date: Fri, 19 Aug 2016 11:55:44 -0700 > The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, > and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native > tunnel device is created in a namespace to interact with a lwtunnel > device out of the namesp

Re: [PATCH net-next] hv_netvsc: Implement batching of receive completions

2016-08-19 Thread David Miller
From: Haiyang Zhang Date: Fri, 19 Aug 2016 14:47:09 -0700 > From: Haiyang Zhang > > The existing code uses busy retry when unable to send out receive > completions due to full ring buffer. It also gives up retrying after limit > is reached, and causes receive buffer slots not being recycled. >

Re: [net] ixgbe: Do not clear RAR entry when clearing VMDq for SAN MAC

2016-08-19 Thread David Miller
From: Jeff Kirsher Date: Fri, 19 Aug 2016 20:58:26 -0700 > From: Alexander Duyck > > The RAR entry for the SAN MAC address was being cleared when we were > clearing the VMDq pool bits. In order to prevent this we need to add > an extra check to protect the SAN MAC from being cleared. > > Fixe

Re: [RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Aug 2016 21:07:52 -0700 > Here is an example of a system I had in the past. > > 8 cpus (num_possible_cpus() returns 8) > > Cpus were numbered : 0, 1, 2, 3, 8, 9, 10, 11 : (nr_cpu_ids = 12) > > I am pretty sure they are still alive. > > Since you want an arra

Re: [RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread Eric Dumazet
On Fri, 2016-08-19 at 18:09 -0700, David Miller wrote: > From: Eric Dumazet > Date: Fri, 19 Aug 2016 12:56:56 -0700 > > > On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote: > >> Instead of using flow stats per NUMA node, use it per CPU. When using > >> megaflows, the stats lo

[net] ixgbe: Do not clear RAR entry when clearing VMDq for SAN MAC

2016-08-19 Thread Jeff Kirsher
From: Alexander Duyck The RAR entry for the SAN MAC address was being cleared when we were clearing the VMDq pool bits. In order to prevent this we need to add an extra check to protect the SAN MAC from being cleared. Fixes: 6e982aeae ("ixgbe: Clear stale pool mappings") Signed-off-by: Alexande

[PATCH iproute2] ss: fix build with musl libc

2016-08-19 Thread Gustavo Zacarias
UINT_MAX usage requires limits.h, so include it. Signed-off-by: Gustavo Zacarias --- misc/ss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/ss.c b/misc/ss.c index e758f57..3b268d9 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -26,6 +26,7 @@ #include #include #include +#include

Re: [PATCH 4/5] driver core: set up ownership of class devices in sysfs

2016-08-19 Thread Stephen Hemminger
On Tue, 16 Aug 2016 15:33:14 -0700 Dmitry Torokhov wrote: > static struct kobj_type device_ktype = { > .release= device_release, > .sysfs_ops = &dev_sysfs_ops, > .namespace = device_namespace, > + .get_ownership = device_get_ownership, > }; > OT - I w

Re: [RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Aug 2016 12:56:56 -0700 > On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote: >> Instead of using flow stats per NUMA node, use it per CPU. When using >> megaflows, the stats lock can be a bottleneck in scalability. > > ... > >> >> flo

Re: [PATCH] net/irda: remove pointless assignment/check

2016-08-19 Thread David Miller
From: Vegard Nossum Date: Fri, 19 Aug 2016 18:08:57 +0200 > We've already set sk to sock->sk and dereferenced it, so if it's NULL > we would have crashed already. Moreover, if it was NULL we would have > crashed anyway when jumping to 'out' and trying to unlock the sock. > Furthermore, if we had

Re: [patch net] mlxsw: spectrum_buffers: Fix pool value handling in mlxsw_sp_sb_tc_pool_bind_set

2016-08-19 Thread David Miller
From: Jiri Pirko Date: Fri, 19 Aug 2016 14:43:48 +0200 > From: Jiri Pirko > > Pool index has to be converted by get_pool helper to work correctly for > egress pool. In mlxsw the egress pool index starts from 0. > > Fixes: 0f433fa0ecc ("mlxsw: spectrum_buffers: Implement shared buffer > config

Re: [PATCH net-next] qed: utilize FW 8.10.10.0

2016-08-19 Thread David Miller
Applied.

Re: [PATCH 1/1] l2tp: Fix the connect status check in pppol2tp_getname

2016-08-19 Thread David Miller
From: f...@ikuai8.com Date: Fri, 19 Aug 2016 13:36:23 +0800 > From: Gao Feng > > The sk->sk_state is bits flag, so need use bit operation check > instead of value check. > > Signed-off-by: Gao Feng Applied.

Re: [net-next 0/4][pull request] 10GbE Intel Wired LAN Driver Updates 2016-08-18

2016-08-19 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Aug 2016 23:03:32 -0700 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net v2] sctp: linearize early if it's not GSO

2016-08-19 Thread David Miller
From: Marcelo Ricardo Leitner Date: Thu, 18 Aug 2016 14:58:35 -0300 > Because otherwise when crc computation is still needed it's way more > expensive than on a linear buffer to the point that it affects > performance. > > It's so expensive that netperf test gives a perf output as below: ... >

Re: [PATCH net-next 0/5] net: dsa: bcm_sf2: Platform conversion

2016-08-19 Thread David Miller
From: Florian Fainelli Date: Thu, 18 Aug 2016 15:30:11 -0700 > This patch series converts the bcm_sf2 driver from a traditional DSA driver > into a platform_device driver and makes it use the new DSA binding that Andrew > introduced in the latest merge window. > > Prior attempts used to coerce t

Re: [PATCH net-next 0/3] Fix mv88e6xxx wait function

2016-08-19 Thread David Miller
From: Andrew Lunn Date: Fri, 19 Aug 2016 00:01:54 +0200 > The mv88e6xxx wait function can be upset of the system has nots of > other things to do and a sleep takes a lot longer than expected. Fix > this be using a fixed number of iterations, rather than a fixed > walkclock time. > > Witht that c

Re: [PATCH net-next 0/2] PHY Kconfig and Makefile cleanup

2016-08-19 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Aug 2016 23:56:04 +0200 > The Ethernet PHY directory has slowly been getting more entries. > Split the entries in the Makefile and Kconfig into MDIO bus drivers > and PHYs. Within these two groups, sort them. This should reduce merge > conflicts and aid finding wha

Re: [PATCH net] tcp: md5: remove tcp_md5_hash_header()

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Aug 2016 09:49:55 -0700 > From: Eric Dumazet > > After commit 19689e38eca5 ("tcp: md5: use kmalloc() backed scratch > areas") this function is no longer used. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net] net: ipv4: fix sparse error in fib_good_nh()

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Aug 2016 10:19:34 -0700 > From: Eric Dumazet > > Fixes following sparse errors : > > net/ipv4/fib_semantics.c:1579:61: warning: incorrect type in argument 2 > (different base types) > net/ipv4/fib_semantics.c:1579:61:expected unsigned int [unsigned] > [user

Re: [PATCH net] udp: include addrconf.h

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Aug 2016 09:59:12 -0700 > From: Eric Dumazet > > Include ipv4_rcv_saddr_equal() definition to avoid this sparse error : > > net/ipv4/udp.c:362:5: warning: symbol 'ipv4_rcv_saddr_equal' was not > declared. Should it be static? > > Signed-off-by: Eric Dumazet

Re: [PATCH net] sit: ipip6_valid_ip_proto() is static

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Aug 2016 10:03:55 -0700 > From: Eric Dumazet > > Fixes this sparse error : > net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not > declared. Should it be static? > > > Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4") > Signed-off-by: Eric

Re: [PATCH] ibmvnic: Handle backing device failover and reinitialization

2016-08-19 Thread David Miller
From: Thomas Falcon Date: Thu, 18 Aug 2016 11:37:51 -0500 > An upcoming feature of IBM VNIC protocol is the ability to configure > redundant backing devices for a VNIC client. In case of a failure > on the current backing device, the driver will receive a signal > from the hypervisor indicating t

Re: [PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-08-19 Thread David Miller
From: Dmitry Torokhov Date: Tue, 16 Aug 2016 15:33:10 -0700 > There are objects in /sys hierarchy (/sys/class/net/) that logically belong > to a namespace/container. Unfortunately all sysfs objects start their life > belonging to global root, and while we could change ownership manually, > keepin

Re: [PATCH net-next] net: hns: Add reset function support for RoCE driver

2016-08-19 Thread David Miller
From: Lijun Ou Date: Thu, 18 Aug 2016 20:32:52 +0800 > It added reset function for RoCE driver. RoCE is a feature of hns. > In hip06 SoC, in RoCE reset process, it's needed to configure dsaf > channel reset, port and sl map info. Reset function of RoCE is > located in dsaf module, we only call it

Re: [PATCH net 00/10] Mellanox 100G mlx5 fixes 2016-08-16

2016-08-19 Thread David Miller
From: Saeed Mahameed Date: Thu, 18 Aug 2016 21:09:01 +0300 > This series includes some bug fixes for mlx5e driver. Series applied. > For -stable of 4.6.y and 4.7.y: > net/mlx5e: Use correct flow dissector key on flower offloading > net/mlx5: Fix pci error recovery flow > net/mlx5: A

Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

2016-08-19 Thread Philp Prindeville
Inline... On 08/17/2016 10:47 PM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng Use existing macros like PPP_ADDRESS, SC_COMP_PROT and sizeof fixed variables instead of original literal number to enhance readbility. BTW, the original pptp_rcv uses literal number "12" as the param

[PATCH 1/2] net: ethernet: renesas: ravb: use phydev from struct net_device

2016-08-19 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy_dev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/etherne

[PATCH 2/2] net: ethernet: renesas: ravb: use new api ethtool_{get|set}_link_ksettings

2016-08-19 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/renesas/ravb_main.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/rene

Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame

2016-08-19 Thread Guillaume Nault
On Thu, Aug 18, 2016 at 08:11:15AM -0600, Philp Prindeville wrote: > > It seems unlikely to me that this sort of locking problem hasn't existed > elsewhere before and that an entirely new mechanism for handling it is > needed... How are similar re-entrancy issues handled elsewhere? > Virtual devi

Re: [Feature Request] IP_BIND_ADDRESS_NO_PORT with port

2016-08-19 Thread Eric Dumazet
On Fri, 2016-08-19 at 23:41 +0300, Cristian Morales Vega wrote: > I would like a socket option that let's me share a source port as long > as the 4-tuples are unique in a UDP socket *and* specify which source > port that is. > It would be similar to IP_BIND_ADDRESS_NO_PORT. It would do exactly > th

Re: [PATCH] gianfar: prevent fragmentation in DSA environments

2016-08-19 Thread Andrew Lunn
> Nice improvement. Thanks > But what's so special about 8? When talking to Marvell Switch chips, there are two different headers which can be added. The DSA header is 4 bytes, and the EDSA header is 8 bytes. However, if there is already a VLAN header, when using EDSA, it will replace the VLAN h

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-19 Thread Greg
On Fri, 2016-08-19 at 14:32 -0700, Alexander Duyck wrote: > The i40e hardware has support for SCTP filtering via Rx NFC however the > default configuration expects us to include the verification tag as a part > of the filter. In order to support that I need to be able to transfer that > data throu

Re: [PATCH v2 1/1] ppp: Fix one deadlock issue of PPP when send frame

2016-08-19 Thread Guillaume Nault
On Fri, Aug 19, 2016 at 06:52:58AM +0800, Feng Gao wrote: > Hi Guillaume, > > Thanks your detail analyses. > Now I think it is a good solution that just drop the packet and print > error log instead my original solution that supports reentrant. This > solution will not bring any side effects. > A

Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-19 Thread Jiri Kosina
On Thu, 18 Aug 2016, Cong Wang wrote: > Doesn't this mean we can now just remove the ingress case from > tc_dump_qdisc() and simply iterate the whole hash table? That'd be indeed a nice cleanup, but for that we'll have to make sure that the top-level ingress entry makes it to the hashtable as w

Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when reentrant

2016-08-19 Thread Guillaume Nault
On Fri, Aug 19, 2016 at 11:16:41PM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > PPP channel holds one spinlock before send frame. But the skb may > select the same PPP channel with wrong route policy. As a result, > the skb reaches the same channel path. It tries to get the same > spinlock

Re: [PATCH] gianfar: fix size of fragmented frames

2016-08-19 Thread Claudiu Manoil
Hi Zefir, [sorry if the message indentation is wrong ... webmail] From: Zefir Kurtisi Sent: Friday, August 19, 2016 8:11 PM To: Claudiu Manoil Subject: Re: [PATCH] gianfar: fix size of fragmented frames     Hi Claudiu, On 08/19/2016 06:46 PM, Claudiu Manoil wrote: >> -Original Message

Re: [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1

2016-08-19 Thread David Miller
From: Herbert Xu Date: Thu, 18 Aug 2016 16:48:54 +0800 > This series starts the process of getting rid of all raw rhashtable > walkers (e.g., using any of the rht_for_each helpers) from the > kernel. > > We need to do this before I can fix the resize kmalloc failure issue > by using multi-layere

Re: [PATCH 2/3] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

2016-08-19 Thread Kevin Hilman
Martin Blumenstingl writes: > The Ethernet controller available in Meson8b and GXBB SoCs is a Synopsys > DesignWare MAC IP core which is already supported by the stmmac driver. > > In addition to the standard stmmac driver some Meson8b / GXBB specific > registers have to be configured for the PHY

Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal number

2016-08-19 Thread David Miller
From: f...@ikuai8.com Date: Thu, 18 Aug 2016 15:05:19 +0800 > @@ -138,6 +138,8 @@ static const struct ppp_channel_ops pppol2tp_chan_ops = { > > static const struct proto_ops pppol2tp_ops; > > +static const unsigned char fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI}; > + > /* Helpers to obtain

Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

2016-08-19 Thread David Miller
From: f...@ikuai8.com Date: Thu, 18 Aug 2016 12:47:34 +0800 > @@ -54,6 +54,8 @@ static struct proto pptp_sk_proto __read_mostly; > static const struct ppp_channel_ops pptp_chan_ops; > static const struct proto_ops pptp_ops; > > +static const u8 fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI}; > +

Re: [PATCH] gianfar: prevent fragmentation in DSA environments

2016-08-19 Thread Claudiu Manoil
Hi Andrew, From: Andrew Lunn Sent: Friday, August 19, 2016 7:39 PM To: Claudiu Manoil Cc: Zefir Kurtisi; netdev@vger.kernel.org; claudiu.man...@freescale.com Subject: Re: [PATCH] gianfar: prevent fragmentation in DSA environments   > >> -#define GFAR_RXB_SIZE 1536 > >> +/* prevent fragmenatio

[net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-19 Thread Alexander Duyck
The i40e hardware has support for SCTP filtering via Rx NFC however the default configuration expects us to include the verification tag as a part of the filter. In order to support that I need to be able to transfer that data through the ethtool interface via a new structure. This patch adds a n

Re: [PATCH v2 1/2] ipv6: save route expiry in RTA_EXPIRES if RTF_EXPIRES set

2016-08-19 Thread Eric Dumazet
On Fri, 2016-08-19 at 18:41 +0200, Andrew Yourtchenko wrote: > This allows "ip -6 route save" to save the expiry for the routes > that have it, such that it can be correctly restored later by > "ip -6 route restore". > > If a route has RTF_EXPIRES set, generate RTA_EXPIRES value which > will be us

[Feature Request] IP_BIND_ADDRESS_NO_PORT with port

2016-08-19 Thread Cristian Morales Vega
I would like a socket option that let's me share a source port as long as the 4-tuples are unique in a UDP socket *and* specify which source port that is. It would be similar to IP_BIND_ADDRESS_NO_PORT. It would do exactly the same when you bind to port 0, but when you bind to a different port it w

Re: [PATCH v1 1/1] pppoe: l2tp: the PPPOX_CONNECTED should be used with bit operation

2016-08-19 Thread Guillaume Nault
On Fri, Aug 19, 2016 at 06:58:58AM +0800, Feng Gao wrote: > inline. > > On Fri, Aug 19, 2016 at 1:44 AM, Guillaume Nault wrote: > > On Thu, Aug 18, 2016 at 09:59:03AM +0800, f...@ikuai8.com wrote: > >> From: Gao Feng > >> > >> There are some codes in pppoe and l2tp which use the PPPOX_CONNECTED

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-19 Thread Alexander Duyck
On Fri, Aug 19, 2016 at 10:09 AM, David Ahern wrote: > As reported by Lennert the MPLS GSO code is failing to properly segment > large packets. There are a couple of problems: > > 1. the inner protocol is not set so the gso segment functions for inner >protocol layers are not getting run, and

[PATCH] cfg80211: Add stub for cfg80211_get_station()

2016-08-19 Thread Linus Lüssing
This allows modules using this function (currently: batman-adv) to compile even if cfg80211 is not built at all, thus relaxing dependencies. Signed-off-by: Linus Lüssing --- include/net/cfg80211.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/net/cfg80211.h b/include/net/c

Re: [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM

2016-08-19 Thread Tom Herbert
On Fri, Aug 19, 2016 at 12:28 PM, David Miller wrote: > From: Helmut Buchsbaum > Date: Fri, 19 Aug 2016 15:04:57 +0200 > >> When working on upgrading the v3.x kernels of our embedded devices >> to more recent 4.x kernels we noticed some of our proprietary networking >> stuff is broken. Further in

[PATCH net-next] hv_netvsc: Implement batching of receive completions

2016-08-19 Thread Haiyang Zhang
From: Haiyang Zhang The existing code uses busy retry when unable to send out receive completions due to full ring buffer. It also gives up retrying after limit is reached, and causes receive buffer slots not being recycled. This patch implements batching of receive completions. It also prevents

Re: [RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread Eric Dumazet
On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote: > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. ... > > flow_cache = kmem_cache_create("sw_flow", sizeof(struct sw_flow) > -

[RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread Thadeu Lima de Souza Cascardo
Instead of using flow stats per NUMA node, use it per CPU. When using megaflows, the stats lock can be a bottleneck in scalability. On a E5-2690 12-core system, usual throughput went from ~4Mpps to ~15Mpps when forwarding between two 40GbE ports with a single flow configured on the datapath. ---

[Patch net-next] net_sched: properly handle failure case of tcf_exts_init()

2016-08-19 Thread Cong Wang
After commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer array") we do dynamic allocation in tcf_exts_init(), therefore we need to handle the ENOMEM case properly. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/pkt_cls.h | 6 ++-- net/sched/cls_basic.c |

Re: [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM

2016-08-19 Thread David Miller
From: Helmut Buchsbaum Date: Fri, 19 Aug 2016 15:04:57 +0200 > When working on upgrading the v3.x kernels of our embedded devices > to more recent 4.x kernels we noticed some of our proprietary networking > stuff is broken. Further investigations brought up an issue with small > UDP packets (data

Re: [PATCH 1/1] l2tp: Fix the connect status check in pppol2tp_getname

2016-08-19 Thread Guillaume Nault
On Fri, Aug 19, 2016 at 01:36:23PM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The sk->sk_state is bits flag, so need use bit operation check > instead of value check. > Tested-by: Guillaume Nault

Re: [PATCH] samples/bpf: Add tunnel set/get tests.

2016-08-19 Thread William Tu
Thanks, I've submitted newer version. On Thu, Aug 18, 2016 at 9:10 PM, David Miller wrote: > From: William Tu > Date: Tue, 16 Aug 2016 07:03:01 -0700 > >> The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, >> and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A nat

[PATCHv2,net-next] samples/bpf: Add tunnel set/get tests.

2016-08-19 Thread William Tu
The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native tunnel device is created in a namespace to interact with a lwtunnel device out of the namespace, with metadata enabled. The bpf_skb_set_* program is attache

Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal number

2016-08-19 Thread Guillaume Nault
On Fri, Aug 19, 2016 at 05:55:26PM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > 1. Use PPP_ALLSTATIONS/PPP_UI instead of literal 0xff/0x03; > 2. Use one static const global fixed_ppphdr instead of two same > static variable ppph in two different functions; > 3. Use SEND_SHUTDOWN instead of

Re: [PATCH v2 2/2] ipv6: fixup RTF_* flags when restoring RTPROT_RA route from rtnetlink

2016-08-19 Thread Sergei Shtylyov
Hello. On 08/19/2016 07:41 PM, Andrew Yourtchenko wrote: Fix the flags for RA-derived routes that were saved via "ip -6 route save" and and subsequently restored via "ip -6 route restore", allowing the incoming router advertisements to update them, rather than complain about inability to do so.

Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

2016-08-19 Thread Neil Horman
On Fri, Aug 19, 2016 at 07:30:22PM +0800, Xin Long wrote: > From: Xin Long > > sctp.local_addr_list is a global address list that is supposed to include > all the local addresses. sctp updates this list according to NETDEV_UP/ > NETDEV_DOWN notifications. > > However, if multiple NICs have the s

[PATCH net] vmxnet3: fix tx data ring copy for variable size

2016-08-19 Thread Shrikrishna Khare
'Commit 3c8b3efc061a ("vmxnet3: allow variable length transmit data ring buffer")' changed the size of the buffers in the tx data ring from a fixed size of 128 bytes to a variable size. However, while copying data to the data ring, vmxnet3_copy_hdr continues to carry the old code that assumes fixe

Re: [PATCH] gianfar: prevent fragmentation in DSA environments

2016-08-19 Thread Andrew Lunn
> I don't fully understand why GFAR_RXB_SIZE has to be lower than > that, preventing the HW using all available memory - the freescale > guys most probably do. That will be because the cache invalidates in the DMA API are expensive. There is no point invalidating the whole 2K if you never make use

Re: [PATCH] gianfar: prevent fragmentation in DSA environments

2016-08-19 Thread Andrew Lunn
> >> -#define GFAR_RXB_SIZE 1536 > >> +/* prevent fragmenation by HW in DSA environments */ > >> +#define GFAR_RXB_SIZE (1536 + RXBUF_ALIGNMENT) > > > >Hi Zefir > > > >Using RXBUF_ALIGNMENT suggests this has something to do with > >alignment, not extra headers. > > > >How about > > > >/* Prevent fr

[PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-19 Thread David Ahern
As reported by Lennert the MPLS GSO code is failing to properly segment large packets. There are a couple of problems: 1. the inner protocol is not set so the gso segment functions for inner protocol layers are not getting run, and 2 MPLS labels for packets that use the "native" (non-OVS) MPL

[PATCH net-next 1/3] net: lwtunnel: Handle fragmentation

2016-08-19 Thread David Ahern
From: Roopa Prabhu Today mpls iptunnel lwtunnel_output redirect expects the tunnel output function to handle fragmentation. This is ok but can be avoided if we did not do the mpls output redirect too early. ie we could wait until ip fragmentation is done and then call mpls output for each ip frag

[PATCH net-next 3/3] net: veth: Set features for MPLS

2016-08-19 Thread David Ahern
veth does not really transmit packets only moves the skb from one netdev to another so gso and checksum is not really needed. Add the features to mpls_features to get the same benefit and performance with MPLS as without it. Reported-by: Lennert Buytenhek Signed-off-by: David Ahern --- drivers/

[PATCH v3 net-next 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic

2016-08-19 Thread David Ahern
This series fixes mtu and fragmentation for tunnels using lwtunnel output redirect, and fixes GSO for MPLS for locally originated traffic reported by Lennert Buytenhek. A follow on series will address fragmentation and GSO for forwarded MPLS traffic. Hardware offload of GSO with MPLS also needs to

Re: [RFC PATCH 0/5] Add eBPF hooks for cgroups

2016-08-19 Thread Thomas Graf
On 08/19/16 at 06:21pm, Pablo Neira Ayuso wrote: > On Fri, Aug 19, 2016 at 12:35:14PM +0200, Daniel Mack wrote: > > Also true. A cgroup can currently only hold one bpf program for each > > direction, and they are supposed to be set from one controlling instance > > in the system. However, it is pos

RE: [PATCH] gianfar: fix size of fragmented frames

2016-08-19 Thread Claudiu Manoil
>-Original Message- >From: Zefir Kurtisi [mailto:zefir.kurt...@neratec.com] >Sent: Friday, August 19, 2016 12:16 PM >To: netdev@vger.kernel.org >Cc: claudiu.man...@freescale.com >Subject: [PATCH] gianfar: fix size of fragmented frames > >The eTSEC RxBD 'Data Length' field is context depenin

Re: [PATCH] gianfar: prevent fragmentation in DSA environments

2016-08-19 Thread Zefir Kurtisi
On 08/19/2016 04:59 PM, Andrew Lunn wrote: > On Fri, Aug 19, 2016 at 11:16:14AM +0200, Zefir Kurtisi wrote: >> The eTSEC register MRBLR defines the maximum space in >> the RX buffers and is set to 1536 by gianfar. This >> reasonably covers the common use case where the MTU >> is kept at default 150

[PATCH v2 1/2] ipv6: save route expiry in RTA_EXPIRES if RTF_EXPIRES set

2016-08-19 Thread Andrew Yourtchenko
This allows "ip -6 route save" to save the expiry for the routes that have it, such that it can be correctly restored later by "ip -6 route restore". If a route has RTF_EXPIRES set, generate RTA_EXPIRES value which will be used to restore the flag and expiry value by already existing code in rtm_t

[PATCH v2 2/2] ipv6: fixup RTF_* flags when restoring RTPROT_RA route from rtnetlink

2016-08-19 Thread Andrew Yourtchenko
Fix the flags for RA-derived routes that were saved via "ip -6 route save" and and subsequently restored via "ip -6 route restore", allowing the incoming router advertisements to update them, rather than complain about inability to do so. Upon the restore of RA-derived saved routes, set the RTF_AD

[PATCH v2 0/2] ipv6: fix stuck RA-derived route in container after migration with criu

2016-08-19 Thread Andrew Yourtchenko
This patchset fixes the connectivity problem for containers with RA-derived default route, after they were migrated using criu: the default routes would lose their "expires" value and become stuck forever. The corresponding criu issue with the discussion is at https://github.com/xemul/criu/issues/1

Re: [v2 PATCH 3/3] netlink: Use rhashtable walk interface in diag dump

2016-08-19 Thread Herbert Xu
On Fri, Aug 19, 2016 at 06:32:37PM +0200, Thomas Graf wrote: > On 08/19/16 at 04:21pm, Herbert Xu wrote: > > This patch converts the diag dumping code to use the rhashtable > > walk code instead of going through rhashtable by hand. The lock > > nl_table_lock is now only taken while we process the

Re: [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init

2016-08-19 Thread Herbert Xu
On Fri, Aug 19, 2016 at 06:25:04PM +0200, Thomas Graf wrote: > On 08/18/16 at 04:50pm, Herbert Xu wrote: > > +/* Obsolete function, do not use in new code. */ > > +static inline int rhashtable_walk_init(struct rhashtable *ht, > > + struct rhashtable_iter *iter, gfp_

Re: [RFC PATCH 0/5] Add eBPF hooks for cgroups

2016-08-19 Thread Thomas Graf
On 08/19/16 at 06:31pm, Pablo Neira Ayuso wrote: > Why do you need global seccomp policies? The process knows better what > he needs to place in his sandbox, so attaching this from the process > itself makes more sense to me... Anyway, this reminds me to selinux. Two different objectives. The poin

Re: [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1

2016-08-19 Thread Thomas Graf
On 08/18/16 at 04:48pm, Herbert Xu wrote: > Dave/Tomas, please keep an eye out for any new patches that try > to introduce raw table walkers and nack them. Very nice work Herbert. I think we should move the rht_for_each_* macros to a private header or lib/rhashtable.c to discourage usage altogethe

Re: [v2 PATCH 3/3] netlink: Use rhashtable walk interface in diag dump

2016-08-19 Thread Thomas Graf
On 08/19/16 at 04:21pm, Herbert Xu wrote: > This patch converts the diag dumping code to use the rhashtable > walk code instead of going through rhashtable by hand. The lock > nl_table_lock is now only taken while we process the multicast > list as it's not needed for the rhashtable walk. > > Sig

  1   2   >