Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-30 Thread Leon Romanovsky
On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote: > Hello, > > On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > > Did you test this patch? Did you notice the memory reclaim path nature > > of this work? > > The conversion uses WQ_MEM_RECLAIM, which is standard for all >

Re: [PATCH] net: dsa: bcm_sf2: Unwind errors in correct order

2016-07-30 Thread David Miller
From: Florian Fainelli Date: Fri, 29 Jul 2016 12:35:57 -0700 > In case we cannot complete bcm_sf2_sw_setup() for any reason, and we > go to the out_unmap label, but the MDIO bus has not been registered yet, > we will hit the BUG condition in drivers/net/phy/mdio_bus.c about the > bus not being re

Re: [PATCH] net: tulip: fix spelling mistake: "attemping" -> "attempting"

2016-07-30 Thread David Miller
From: Colin King Date: Sat, 30 Jul 2016 17:47:07 +0100 > From: Colin Ian King > > trivial fix to spelling mistake in printk message > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH net] sctp: change to use TCP_CLOSE_WAIT as SCTP_SS_CLOSING

2016-07-30 Thread David Miller
From: Marcelo Ricardo Leitner Date: Sat, 30 Jul 2016 10:25:35 -0300 > On Sat, Jul 30, 2016 at 08:00:45PM +0800, Xin Long wrote: >> Prior to this patch, sctp defined TCP_CLOSING as SCTP_SS_CLOSING. >> TCP_CLOSING is such a special sk state in TCP that inet common codes >> even exclude it. >> >> F

Re: [PATCH net] sctp: allow receiving msg when TCP-style sk is in CLOSED state

2016-07-30 Thread David Miller
From: Xin Long Date: Sat, 30 Jul 2016 14:14:41 +0800 > Commit 141ddefce7c8 ("sctp: change sk state to CLOSED instead of > CLOSING in sctp_sock_migrate") changed sk state to CLOSED if the > assoc is closed when sctp_accept clones a new sk. > > If there is still data in sk receive queue, users wil

Re: [PATCH net] sctp: allow delivering notifications after receiving SHUTDOWN

2016-07-30 Thread David Miller
From: Xin Long Date: Sat, 30 Jul 2016 14:09:09 +0800 > Prior to this patch, once sctp received SHUTDOWN or shutdown with RD, > sk->sk_shutdown would be set with RCV_SHUTDOWN, and all events would > be dropped in sctp_ulpq_tail_event(). It would cause: > > 1. some notifications couldn't be receiv

Re: [PATCH net] sctp: fix the issue sctp requeue auth chunk incorrectly

2016-07-30 Thread David Miller
From: Xin Long Date: Sat, 30 Jul 2016 13:58:35 +0800 > sctp needs to queue auth chunk back when we know that we are going > to generate another segment. But commit f1533cce60d1 ("sctp: fix > panic when sending auth chunks") requeues the last chunk processed > which is probably not the auth chunk.

[PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-30 Thread Guodong Xu
Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO packets available in tx or rx, the LEDs will blink. For each hci registration, two triggers are added into LED subsystem: [hdev->name]-tx and [hdev-name]-rx. Refer to Documentation/leds/leds-class.txt for usage. Verified on

Re: [PATCH v2 net] tcp: consider recv buf for the initial window scale

2016-07-30 Thread David Miller
From: Soheil Hassas Yeganeh Date: Fri, 29 Jul 2016 09:34:02 -0400 > From: Soheil Hassas Yeganeh > > tcp_select_initial_window() intends to advertise a window > scaling for the maximum possible window size. To do so, > it considers the maximum of net.ipv4.tcp_rmem[2] and > net.core.rmem_max as t

Re: [PATCH net 0/3] macsec: reference counting fixes

2016-07-30 Thread David Miller
From: Sabrina Dubroca Date: Fri, 29 Jul 2016 15:37:52 +0200 > Patch 1 adds explicit reference counting on RXSCs, instead of the > current implicit reference counting using the RXSA's refcount. > > Patch 2 fixes possible kernel panics during module unload caused by an > RCU callback that schedule

Re: [PATCH v2 0/4] drivers: net: cpsw: fix driver loading/unloading

2016-07-30 Thread David Miller
From: Grygorii Strashko Date: Thu, 28 Jul 2016 20:50:33 +0300 > This series fixes set of isssues observed when CPSW driver module is > unloaded/loaded: > 1) rmmod: deadlock in cpdma_ctlr_destroy > 2) rmmod: L3 back-trace and crash if all net interfaces are down, because CPSW > can be powerred do

Re: [PATCH -next] net: ipv6: use list_move instead of list_del/list_add

2016-07-30 Thread David Miller
From: Wei Yongjun Date: Thu, 28 Jul 2016 16:19:03 + > Using list_move() instead of list_del() + list_add(). > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net] cxgb4/cxgb4vf: Fixes regression in perf when tx vlan offload is disabled

2016-07-30 Thread David Miller
From: Hariprasad Shenai Date: Thu, 28 Jul 2016 13:28:57 +0530 > The commit 637d3e997351 ("cxgb4: Discard the packet if the length is > greater than mtu") introduced a regression in the VLAN interface > performance when Tx VLAN offload is disabled. > > Check if skb is tagged, regardless of whethe

Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()

2016-07-30 Thread David Miller
From: Wei Yongjun Date: Thu, 28 Jul 2016 02:12:17 + > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] tipc: fix imbalance read_unlock_bh in __tipc_nl_add_monitor()

2016-07-30 Thread David Miller
From: Wei Yongjun Date: Thu, 28 Jul 2016 02:07:49 + > In the error handling case of nla_nest_start() failed read_unlock_bh() > is called to unlock a lock that had not been taken yet. sparse warns > about the context imbalance as the following: > > net/tipc/monitor.c:799:23: warning: > cont

Re: [PATCH net] 8139too:fix system hang when there is a tx timeout event.

2016-07-30 Thread David Miller
From: Chunhao Lin Date: Thu, 28 Jul 2016 02:39:57 +0800 > If tx timeout event occur, kernel will call rtl8139_tx_timeout_task() to reset > hardware. But in this function, driver does not stop tx and rx function before > reset hardware, that will cause system hang. > > In this patch, add stop tx

Re: [PATCH net 0/6] qed*: Small fixes series

2016-07-30 Thread David Miller
From: Yuval Mintz Date: Wed, 27 Jul 2016 14:45:18 +0300 > This contains several small [and straight-forward] fixes to qed* > drivers. > > Please consider applying this to `net'. Series applied, thanks.

[PATCH] net: thunderx: correct bound check in nic_config_loopback

2016-07-30 Thread Levin, Alexander
Off by one in nic_config_loopback would access an invalid arrat variable when vf id == MAX_LMAC. Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/dri

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-30 Thread kbuild test robot
Hi, [auto build test ERROR on net-next/master] [also build test ERROR on v4.7 next-20160729] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joe-Perches/qed-Add-and-use-specific-logging-functions

Re: [PATCH v5] net: sched: convert qdisc linked list to hashtable

2016-07-30 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc7] [also build test ERROR on next-20160729] [cannot apply to net/master net-next/master ipsec-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jir

Re: [PATCH 1/3] netfilter: nat: update hash bucket if nat changed after ct confirmed

2016-07-30 Thread Florian Westphal
fxp2001640...@gmail.com wrote: > From: Xiaoping Fan > > In some situations, NAT information is created after connection is > confirmed. That sounds like a bug. How can this happen? nf_nat_setup_info() is only safe for non-confirmed conntracks (not in hash table).

Re: [PATCH] Networking: Core: netpoll: Fixed a missing spin_unlock

2016-07-30 Thread Francois Romieu
Salil Kapur : [...] > diff --git a/net/core/netpoll.c b/net/core/netpoll.c > index fc75c9e..9124f76 100644 > --- a/net/core/netpoll.c > +++ b/net/core/netpoll.c > @@ -386,8 +386,10 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct > sk_buff *skb, >

[PATCH 3/3] netfilter: nat: don't assign a null snat rule to bridged traffic if no matching

2016-07-30 Thread fxp2001640163
From: Xiaoping Fan In some case, bridged packet will come back again for routing. When bridge netfilter is enabled, a null snat rule is assigned to bridged packet if no matching in nat chain. Then nat rule matching is skipped when packet comes back for routing. This result in private IP address e

[PATCH 2/3] netfilter: nat: snat created in route process just apply to routed traffic

2016-07-30 Thread fxp2001640163
From: Xiaoping Fan In some situations, packet goes through Linux twice, one for bridging, another for routing. If snat is created in bridging process, that means snat rule only matches bridged traffic. If snat is created in routing process, that means snat rule only matches routed traffic. If we

[PATCH 1/3] netfilter: nat: update hash bucket if nat changed after ct confirmed

2016-07-30 Thread fxp2001640163
From: Xiaoping Fan In some situations, NAT information is created after connection is confirmed. Since 5 tuple for reply direction is changed when creating NAT information, so we need to update hash bucket of connection. Signed-off-by: Xiaoping Fan --- include/net/netfilter/nf_conntrack.h | 5

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

2016-07-30 Thread Phil Sutter
On Sat, Jul 30, 2016 at 10:33:48AM -0300, Marcelo Ricardo Leitner wrote: > > > Em 30-07-2016 10:25, Xin Long escreveu: > >>> diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c > >>> index f69edcf219e51..0ad6033a7330c 100644 > >>> --- a/net/sctp/sctp_diag.c > >>> +++ b/net/sctp/sctp_diag.c >

[PATCH] net: tulip: fix spelling mistake: "attemping" -> "attempting"

2016-07-30 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in printk message Signed-off-by: Colin Ian King --- drivers/net/ethernet/dec/tulip/de4x5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c i

[PATCH 2/2] net: ethernet: marvell: mvneta: use new api ethtool_{get|set}_link_ksettings

2016-07-30 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move the mvneta driver to new api {get|set}_link_ksettings. We use the generic function phy_ethtool_get_link_ksettings, and update old mvneta_ethtool_set_settings to the new api. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/marvell

[PATCH 1/2] net: ethernet: marvell: mvneta: use phydev from struct net_device

2016-07-30 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy_dev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/etherne

[PATCH 2/2] net: ethernet: greth: use phy_ethtool_{get|set}_link_ksettings

2016-07-30 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/aeroflex/greth.c | 23 ++- 1 files changed, 2 insertions(+), 21 deletions(-) d

[PATCH 1/2] net: ethernet: greth: use phydev from struct net_device

2016-07-30 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/ae

[PATCH 1/2] net: ethernet: octeon: use phydev from struct net_device

2016-07-30 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/staging/octe

[PATCH 2/2] net: ethernet: octeon: use phy_ethtool_{get|set}_link_ksettings

2016-07-30 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. There was a check on CAP_NET_ADMIN in cvm_oct_set_settings, but this check is already done in dev_ethtool, so no need to repeat it before calling the generic f

Re: [PATCH RESEND nf] netfilter: avoid a race between nf_register_hook() and cleanup_net()

2016-07-30 Thread Eric W. Biederman
Michal Kubecek writes: > There is a race condition between nf_{,un}register_hook() and > cleanup_net() which can either trigger WARN check or cause a memory > leak. The scenario is like this (2a and 2b are alternatives): > > 1. cleanup_net() removes one or more struct net from net_namespace_list

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

2016-07-30 Thread Marcelo Ricardo Leitner
Em 30-07-2016 10:25, Xin Long escreveu: diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c index f69edcf219e51..0ad6033a7330c 100644 --- a/net/sctp/sctp_diag.c +++ b/net/sctp/sctp_diag.c @@ -40,10 +40,12 @@ static void inet_diag_msg_sctpasoc_fill(struct inet_diag_msg *r, } r

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

2016-07-30 Thread Xin Long
>> diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c >> index f69edcf219e51..0ad6033a7330c 100644 >> --- a/net/sctp/sctp_diag.c >> +++ b/net/sctp/sctp_diag.c >> @@ -40,10 +40,12 @@ static void inet_diag_msg_sctpasoc_fill(struct >> inet_diag_msg *r, >> } >> >> r->idiag_state = as

Re: [PATCH net] sctp: change to use TCP_CLOSE_WAIT as SCTP_SS_CLOSING

2016-07-30 Thread Marcelo Ricardo Leitner
On Sat, Jul 30, 2016 at 08:00:45PM +0800, Xin Long wrote: > Prior to this patch, sctp defined TCP_CLOSING as SCTP_SS_CLOSING. > TCP_CLOSING is such a special sk state in TCP that inet common codes > even exclude it. > > For instance, inet_accept thinks the accept sk's state never be > TCP_CLOSING,

Re: [PATCH net] sctp: fix the issue sctp requeue auth chunk incorrectly

2016-07-30 Thread Marcelo Ricardo Leitner
On Sat, Jul 30, 2016 at 01:58:35PM +0800, Xin Long wrote: > sctp needs to queue auth chunk back when we know that we are going > to generate another segment. But commit f1533cce60d1 ("sctp: fix > panic when sending auth chunks") requeues the last chunk processed > which is probably not the auth chu

Re: [PATCH net] sctp: allow delivering notifications after receiving SHUTDOWN

2016-07-30 Thread Marcelo Ricardo Leitner
On Sat, Jul 30, 2016 at 02:09:09PM +0800, Xin Long wrote: > Prior to this patch, once sctp received SHUTDOWN or shutdown with RD, > sk->sk_shutdown would be set with RCV_SHUTDOWN, and all events would > be dropped in sctp_ulpq_tail_event(). It would cause: > > 1. some notifications couldn't be rec

Re: [PATCH net] sctp: allow receiving msg when TCP-style sk is in CLOSED state

2016-07-30 Thread Marcelo Ricardo Leitner
On Sat, Jul 30, 2016 at 02:14:41PM +0800, Xin Long wrote: > Commit 141ddefce7c8 ("sctp: change sk state to CLOSED instead of > CLOSING in sctp_sock_migrate") changed sk state to CLOSED if the > assoc is closed when sctp_accept clones a new sk. > > If there is still data in sk receive queue, users

[PATCH net] sctp: change to use TCP_CLOSE_WAIT as SCTP_SS_CLOSING

2016-07-30 Thread Xin Long
Prior to this patch, sctp defined TCP_CLOSING as SCTP_SS_CLOSING. TCP_CLOSING is such a special sk state in TCP that inet common codes even exclude it. For instance, inet_accept thinks the accept sk's state never be TCP_CLOSING, or it will give a WARN_ON. TCP works well with that while SCTP may tr

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

2016-07-30 Thread Lino Sanfilippo
On 28.07.2016 21:12, Timur Tabi wrote: > >>> + if (ret) { >>> + netdev_err(adpt->netdev, >>> + "error:%d on request_irq(%d:%s flags:0)\n", ret, >>> + irq->irq, EMAC_MAC_IRQ_RES); >> >> freeing the irq is missing > > Will fix. > >>> + /* di

Re: [PATCH net-next 01/10] drivers: net: xgene: Fix kbuild warning

2016-07-30 Thread Arnd Bergmann
On Friday, July 29, 2016 5:33:54 PM CEST Iyappan Subramanian wrote: > This patch fixes the following kbuild warning, when ACPI was not enabled. > > >> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:878:23: warning: 'phy_dev' > >> may be used uninitialized in this function [-Wmaybe-uninitialized]

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-07-30 Thread Maxime Ripard
On Sat, Jul 30, 2016 at 09:30:01AM +0800, Chen-Yu Tsai wrote: > >> > > +static void sun8i_emac_unset_syscon(struct net_device *ndev) > >> > > +{ > >> > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > >> > > + u32 reg = 0; > >> > > + > >> > > + if (priv->variant == H3_EMAC) > >> > > +