Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 15 Jul 2016 23:11:15 -0700 > Sorry about that, would you like me to resubmit the patch ? That's not necessary.

Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

2016-07-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Jul 2016 16:42:01 -0700 > @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp) > for (i = 0; i < bp->tx_nr_rings; i++) { > txr = &bp->tx_ring[i]; > txq = netdev_get_tx_queue(bp->dev, i); > + __netif_tx

Re: [PATCH net v2] tcp_timer.c: Add kernel-doc function descriptions

2016-07-15 Thread David Miller
From: Richard Sailer Date: Sat, 16 Jul 2016 04:04:34 +0200 > This adds kernel-doc style descriptions for 6 functions and > fixes 1 typo. > > Signed-off-by: Richard Sailer > --- > Changes from v1: > * All comments are indented consistently > * Consistently no "." at end of function short des

Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread Nikolay Aleksandrov
> On Jul 15, 2016, at 10:56 PM, David Miller wrote: > > From: Nikolay Aleksandrov > Date: Thu, 14 Jul 2016 19:28:27 +0300 > >> In preparation for hardware offloading of ipmr/ip6mr we need an >> interface that allows to check (and later update) the age of entries. >> Relying on stats alone can

Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 14 Jul 2016 19:28:27 +0300 > In preparation for hardware offloading of ipmr/ip6mr we need an > interface that allows to check (and later update) the age of entries. > Relying on stats alone can show activity but not actual age of the entry, > furthermore when

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-15 Thread Alexei Starovoitov
On Fri, Jul 15, 2016 at 07:16:01PM -0700, Sargun Dhillon wrote: > > > On Thu, 14 Jul 2016, Alexei Starovoitov wrote: > > >On Wed, Jul 13, 2016 at 01:31:57PM -0700, Sargun Dhillon wrote: > >> > >> > >>On Wed, 13 Jul 2016, Alexei Starovoitov wrote: > >> > >>>On Wed, Jul 13, 2016 at 03:36:11AM -070

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-15 Thread Sargun Dhillon
On Thu, 14 Jul 2016, Alexei Starovoitov wrote: On Wed, Jul 13, 2016 at 01:31:57PM -0700, Sargun Dhillon wrote: On Wed, 13 Jul 2016, Alexei Starovoitov wrote: On Wed, Jul 13, 2016 at 03:36:11AM -0700, Sargun Dhillon wrote: Provides BPF programs, attached to kprobes a safe way to write to

[PATCH net v2] tcp_timer.c: Add kernel-doc function descriptions

2016-07-15 Thread Richard Sailer
This adds kernel-doc style descriptions for 6 functions and fixes 1 typo. Signed-off-by: Richard Sailer --- Changes from v1: * All comments are indented consistently * Consistently no "." at end of function short description line net/ipv4/tcp_timer.c | 81 +++

[PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread Nikolay Aleksandrov
In preparation for hardware offloading of ipmr/ip6mr we need an interface that allows to check (and later update) the age of entries. Relying on stats alone can show activity but not actual age of the entry, furthermore when there're tens of thousands of entries a lot of the hardware implementation

Re: [PATCH v2 1/2] net: ethernet: ethoc: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 09:59:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH 2/2] net: ethernet: xilinx: axienet: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 19:45:58 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: xilinx: axienet: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 19:45:57 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH 1/2] net: ethernet: tc35815: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 15:20:46 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH v2 2/2] net: ethernet: ethoc: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 09:59:12 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: tc35815: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 15:20:47 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: pasemi_mac: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 23:44:52 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH 2/2] net: ethernet: pasemi_mac: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Thu, 14 Jul 2016 23:44:53 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: smsc9420: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 10:36:21 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: amd: au1000_eth: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 12:05:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH 1/2] net: ethernet: smsc9420: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 10:36:20 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH 2/2] net: ethernet: ti: cpmac: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 12:39:02 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > There was a check on CAP_NET_ADMIN in cpmac_set_settings, but this > check is already don

Re: [PATCH 1/2] net: ethernet: ti: cpmac: use phydev from struct net_device

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 12:39:01 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net

Re: [PATCH 2/2] net: ethernet: amd: au1000_eth: use phy_ethtool_{get|set}_link_ksettings

2016-07-15 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 12:05:12 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > There was a check on CAP_NET_ADMIN in au1000_set_settings, but this > check is already do

[PATCH net] net: cavium: liquidio: Avoid dma_unmap_single on uninitialized ndata

2016-07-15 Thread Florian Fainelli
The label lio_xmit_failed is used 3 times through liquidio_xmit() but it always makes a call to dma_unmap_single() using potentially uninitialized variables from "ndata" variable. Out of the 3 gotos, 2 run after ndata has been initialized, and had a prior dma_map_single() call. Fix this by adding

[PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

2016-07-15 Thread Florian Fainelli
txr->dev_state is always manipulated after acquiring the transmit queue lock, except in bnxt_tx_enable(), which seems suspicious here, so also acquire the transmit queue lock before changing the value. Reported-by: coverity (CID 1339583) Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver

[PATCH net] net: nb8800: Fix SKB leak in nb8800_receive()

2016-07-15 Thread Florian Fainelli
In case nb8800_receive() fails to allocate a fragment, we would leak the SKB freshly allocated and just return, instead, free it. Reported-by: coverity (CID 1341750) Signed-off-by: Florian Fainelli --- drivers/net/ethernet/aurora/nb8800.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout()

2016-07-15 Thread Florian Fainelli
We should be using a logical check here instead of a bitwise operation to check if the device is closed already in et131x_tx_timeout(). Reported-by: coverity (CID 146498) Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net") Signed-off-by: Florian Fainelli ---

[PATCH v9 11/11] bpf: add sample for xdp forwarding and rewrite

2016-07-15 Thread Brenden Blanco
Add a sample that rewrites and forwards packets out on the same interface. Observed single core forwarding performance of ~10Mpps. Since the mlx4 driver under test recycles every single packet page, the perf output shows almost exclusively just the ring management and bpf program work. Slowdowns a

[PATCH v9 10/11] bpf: enable direct packet data write for xdp progs

2016-07-15 Thread Brenden Blanco
For forwarding to be effective, XDP programs should be allowed to rewrite packet data. This requires that the drivers supporting XDP must all map the packet memory as TODEVICE or BIDIRECTIONAL before invoking the program. Signed-off-by: Brenden Blanco --- kernel/bpf/verifier.c | 17

[PATCH v9 09/11] net/mlx4_en: add xdp forwarding and data write support

2016-07-15 Thread Brenden Blanco
A user will now be able to loop packets back out of the same port using a bpf program attached to xdp hook. Updates to the packet contents from the bpf program is also supported. For the packet write feature to work, the rx buffers are now mapped as bidirectional when the page is allocated. This o

[PATCH v9 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-15 Thread Brenden Blanco
The mlx4 driver by default allocates order-3 pages for the ring to consume in multiple fragments. When the device has an xdp program, this behavior will prevent tx actions since the page must be re-mapped in TODEVICE mode, which cannot be done if the page is still shared. Start by making the alloc

[PATCH v9 03/11] rtnl: add option for setting link xdp prog

2016-07-15 Thread Brenden Blanco
Sets the bpf program represented by fd as an early filter in the rx path of the netdev. The fd must have been created as BPF_PROG_TYPE_XDP. Providing a negative value as fd clears the program. Getting the fd back via rtnl is not possible, therefore reading of this value merely provides a bool wheth

[PATCH v9 05/11] Add sample for adding simple drop program to link

2016-07-15 Thread Brenden Blanco
Add a sample program that only drops packets at the BPF_PROG_TYPE_XDP_RX hook of a link. With the drop-only program, observed single core rate is ~20Mpps. Other tests were run, for instance without the dropcnt increment or without reading from the packet header, the packet rate was mostly unchange

[PATCH v9 07/11] bpf: add XDP_TX xdp_action for direct forwarding

2016-07-15 Thread Brenden Blanco
XDP enabled drivers must transmit received packets back out on the same port they were received on when a program returns this action. Signed-off-by: Brenden Blanco --- include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.

[PATCH v9 08/11] net/mlx4_en: break out tx_desc write into separate function

2016-07-15 Thread Brenden Blanco
In preparation for writing the tx descriptor from multiple functions, create a helper for both normal and blueflame access. Signed-off-by: Brenden Blanco --- drivers/infiniband/hw/mlx4/qp.c| 11 +-- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 127 + incl

[PATCH v9 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-15 Thread Brenden Blanco
Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. In tc/socket bpf programs, helpers linearize skb fragments as needed when the program touches the packet data. However, in the pursuit of speed, XDP programs will not be allowed to use these slower functions, especially if it involves allo

[PATCH v9 02/11] net: add ndo to setup/query xdp prog in adapter rx

2016-07-15 Thread Brenden Blanco
Add one new netdev op for drivers implementing the BPF_PROG_TYPE_XDP filter. The single op is used for both setup/query of the xdp program, modelled after ndo_setup_tc. Signed-off-by: Brenden Blanco --- include/linux/netdevice.h | 34 ++ net/core/dev.c

[PATCH v9 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-15 Thread Brenden Blanco
This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling eXpress Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early packet filtering, before even an skb has been all

[PATCH v9 01/11] bpf: add XDP prog type for early driver filter

2016-07-15 Thread Brenden Blanco
Add a new bpf prog type that is intended to run in early stages of the packet rx path. Only minimal packet metadata will be available, hence a new context type, struct xdp_md, is exposed to userspace. So far only expose the packet start and end pointers, and only in read mode. An XDP program must

Re: [PATCH net-next] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread Nikolay Aleksandrov
> On Jul 14, 2016, at 8:08 AM, Nikolay Aleksandrov > wrote: > > In preparation for hardware offloading of ipmr/ip6mr we need an > interface that allows to check (and later update) the age of entries. > Relying on stats alone can show activity but not actual age of the entry, > furthermore when

[PATCH net-next] bpf: bpf_event_entry_gen's alloc needs to be in atomic context

2016-07-15 Thread Daniel Borkmann
Should have been obvious, only called from bpf() syscall via map_update_elem() that calls bpf_fd_array_map_update_elem() under RCU read lock and thus this must also be in GFP_ATOMIC, of course. Fixes: 3b1efb196eee ("bpf, maps: flush own entries on perf map release") Signed-off-by: Daniel Borkmann

headsup: llvm now uses official bpf e_machine value

2016-07-15 Thread Alexei Starovoitov
just pushed Richard's patch https://github.com/llvm-mirror/llvm/commit/36b9c09330bfb5e771914cfe307588f30d5510d2 tested with bcc and different bpf loaders. Thankfully none of them rely on old and arguably buggy em_none value, so no breakage expected. if you're using special bpf elf loader, please t

Re: [PATCH net] net: bgmac: Fix infinite loop in bgmac_dma_tx_add()

2016-07-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Jul 2016 15:42:52 -0700 > Nothing is decrementing the index "i" while we are cleaning up the > fragments we could not successful transmit. > > Fixes: 9cde94506eacf ("bgmac: implement scatter/gather support") > Reported-by: coverity (CID 1352048) > Signed-off-

Re: [PATCH] igb: fix adjusting ptp timestamps for tx/rx latency

2016-07-15 Thread kbuild test robot
Hi, [auto build test ERROR on jkirsher-next-queue/dev-queue] [also build test ERROR on v4.7-rc7 next-20160715] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kshitiz-Gupta/igb-fix-adjusting-ptp

Re: [PATCH] net: fixup for tracepoint napi:napi_poll

2016-07-15 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 15 Jul 2016 23:55:20 +0200 > The recent change to tracepoint napi:napi_poll changed the order of > the parameters that perf scripts sees, the printk was correct. The > problem was that the new parameters (work and budget) were pushed > in front of dev_name

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

2016-07-15 Thread Alexei Starovoitov
On Fri, Jul 15, 2016 at 03:18:12PM -0700, John Fastabend wrote: > > nolock (pfifo_fast) > 1: 1440293 1421602 1409553 1393469 1424543 > 2: 1754890 1819292 1727948 1797711 1743427 > 4: 3282665 3344095 3315220 3332777 3348972 > 8: 2940079 1644450 2950777 2922085 2946310 > 12: 2042084 2610060 2857

[PATCH v2 iproute2] ss: Add option to suppress header line

2016-07-15 Thread David Ahern
Add option to suppress header line. When used the following line is not shown: "State Recv-Q Send-Q Local Address:Port Peer Address:Port" Signed-off-by: David Ahern --- v2 - rebased to master branch man/man8/ss.8 | 3 +++ misc/ss.c | 28 +++- 2 files changed,

[PATCH net-next] net: ipmr/ip6mr: add support for keeping an entry age

2016-07-15 Thread Nikolay Aleksandrov
In preparation for hardware offloading of ipmr/ip6mr we need an interface that allows to check (and later update) the age of entries. Relying on stats alone can show activity but not actual age of the entry, furthermore when there're tens of thousands of entries a lot of the hardware implementation

[PATCH net] net: bgmac: Fix infinite loop in bgmac_dma_tx_add()

2016-07-15 Thread Florian Fainelli
Nothing is decrementing the index "i" while we are cleaning up the fragments we could not successful transmit. Fixes: 9cde94506eacf ("bgmac: implement scatter/gather support") Reported-by: coverity (CID 1352048) Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.c | 2 +- 1

[PATCH iproute2] ss: Fix support for device filter by index

2016-07-15 Thread David Ahern
Support was recently added for device filters. The intent was to allow the device to be specified by name or index, and using the if%u format (dev == if5) or the simpler and more intuitive index alone (dev == 5). The latter case is broken since the index is not saved to the filter after the strtoul

Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

2016-07-15 Thread Paul Gortmaker
[Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms] On 15/07/2016 (Fri 14:12) Scott Wood wrote: > On Fri, 2016-07-15 at 12:43 -0400, Paul Gortmaker wrote: > > > +source "drivers/soc/fsl/qe/Kconfig" [...] > > > + > > > +config FSL_GUTS > > > +   bool > > > diff --git a/drivers/soc

[PATCH] igb: fix adjusting ptp timestamps for tx/rx latency

2016-07-15 Thread Kshitiz Gupta
Fix PHY delay compensation math in igb_ptp_tx_hwtstamp() and igb_ptp_rx_rgtstamp. Add PHY delay compensation in igb_ptp_rx_pktstamp(). In the IGB driver, there are two functions that retrieve timestamps received by the PHY - igb_ptp_rx_rgtstamp() and igb_ptp_rx_pktstamp(). The previous commit only

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

2016-07-15 Thread John Fastabend
On 16-07-15 04:23 AM, Jesper Dangaard Brouer wrote: > On Thu, 14 Jul 2016 17:07:33 -0700 > John Fastabend wrote: > >> On 16-07-14 04:42 PM, Alexei Starovoitov wrote: >>> On Wed, Jul 13, 2016 at 11:23:12PM -0700, John Fastabend wrote: This converts the pfifo_fast qdisc to use the alf_queue

Re: [PATCH 0 / 5] move the common CDC parser

2016-07-15 Thread Greg KH
On Fri, Jul 15, 2016 at 11:51:47AM -0700, David Miller wrote: > From: Oliver Neukum > Date: Thu, 14 Jul 2016 15:41:29 +0200 > > > Experience has shown that making all CDC drivers depend on usbnet > > is not practical, because some of them are not network drivers. > > So this patch moves the commo

[PATCH] net: fixup for tracepoint napi:napi_poll

2016-07-15 Thread Jesper Dangaard Brouer
The recent change to tracepoint napi:napi_poll changed the order of the parameters that perf scripts sees, the printk was correct. The problem was that the new parameters (work and budget) were pushed in front of dev_name. The new parameters obviously need to be appended to keep backward compatib

Re: [PATCH v3 2/8] thunderbolt: Updating device IDs

2016-07-15 Thread David Miller
From: "Levy, Amir (Jer)" Date: Fri, 15 Jul 2016 18:56:39 + > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: >> From: Amir Levy >> Date: Thu, 14 Jul 2016 14:28:16 +0300 >> >> > Adding the new Thunderbolt(TM) device IDs to the list. >> > >> > Signed-off-by: Amir Levy >> >> Unless these

Re: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-15 Thread Brenden Blanco
On Wed, Jul 13, 2016 at 08:40:59AM -0700, Brenden Blanco wrote: > On Wed, Jul 13, 2016 at 10:17:26AM +0300, Tariq Toukan wrote: > > > > On 13/07/2016 3:54 AM, Brenden Blanco wrote: > > >On Tue, Jul 12, 2016 at 02:18:32PM -0700, David Miller wrote: > > >>From: Brenden Blanco > > >>Date: Tue, 12 Ju

Re: [patch net 0/5] mlxsw: Couple of fixes

2016-07-15 Thread David Miller
From: Jiri Pirko Date: Fri, 15 Jul 2016 11:14:57 +0200 > Couple of fixes for mlxsw driver from Ido. Series applied, thanks.

Re: [PATCH net-next 1/2] macvtap: avoid hash calculating for single queue

2016-07-15 Thread David Miller
From: Jason Wang Date: Fri, 15 Jul 2016 03:46:30 -0400 > We decide the rxq through calculating its hash which is not necessary > if we only have one rx queue. So this patch skip this and just return > queue 0. Test shows 22% improving on guest rx pps. > > Before: 1201504 pkts/s > After: 1472731

Re: [PATCH net-next 2/2] macvtap: switch to use skb array

2016-07-15 Thread David Miller
From: Jason Wang Date: Fri, 15 Jul 2016 03:46:31 -0400 > This patch switch to use skb array instead of sk_receive_queue to > avoid spinlock contentions. Tests shows about 21% improvements for > guest rx pps: > > Before: 1472731 pkts/s > After: 1786289 pkts/s > > Signed-off-by: Jason Wang Loo

Re: [PATCH] r8152: add MODULE_VERSION

2016-07-15 Thread Grant Grundler
On Fri, Jul 15, 2016 at 2:25 PM, David Miller wrote: > From: Grant Grundler > Date: Thu, 14 Jul 2016 11:27:16 -0700 > >> ethtool -i provides a driver version that is hard coded. >> Export the same value via "modinfo". >> >> Signed-off-by: Grant Grundler > > Applied. Excellent - thank you. :) g

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2016-07-14

2016-07-15 Thread David Miller
From: Jeff Kirsher Date: Fri, 15 Jul 2016 00:02:00 -0700 > This series contains fixes to i40e and ixgbe. Pulled, thanks Jeff.

Re: [PATCH] r8152: add MODULE_VERSION

2016-07-15 Thread David Miller
From: Grant Grundler Date: Thu, 14 Jul 2016 11:27:16 -0700 > ethtool -i provides a driver version that is hard coded. > Export the same value via "modinfo". > > Signed-off-by: Grant Grundler Applied.

Re: [PATCH net-next v2 0/3] BPF event output helper improvements

2016-07-15 Thread David Miller
From: Daniel Borkmann Date: Thu, 14 Jul 2016 18:08:02 +0200 > This set adds improvements to the BPF event output helper to > support non-linear data sampling, here specifically, for skb > context. For details please see individual patches. The set > is based against net-next tree. > > v1 -> v2:

Re: [PATCH net] tcp: enable per-socket rate limiting of all 'challenge acks'

2016-07-15 Thread David Miller
From: Jason Baron Date: Thu, 14 Jul 2016 11:38:40 -0400 > From: Jason Baron > > The per-socket rate limit for 'challenge acks' was introduced in the > context of limiting ack loops: > > commit f2b2c582e824 ("tcp: mitigate ACK loops for connections as tcp_sock") > > And I think it can be exten

Re: [PATCH net-next] rxrpc: checking for IS_ERR() instead of NULL

2016-07-15 Thread David Miller
From: David Howells Date: Thu, 14 Jul 2016 15:47:01 +0100 > From: Dan Carpenter > > The rxrpc_lookup_peer() function returns NULL on error, it never returns > error pointers. > > Fixes: 8496af50eb38 ('rxrpc: Use RCU to access a peer's service connection > tree') > Signed-off-by: Dan Carpenter

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-15 Thread pravin shelar
On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman wrote: > Hi Pravin, > > On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote: >> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman >> wrote: > > ... > >> > diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c >> > index 0ea128eeeab2..86

Re: [PATCH 00/14] Present useful limits to user (v2)

2016-07-15 Thread H. Peter Anvin
,Johannes Weiner ,Alexei Starovoitov ,Arnaldo Carvalho de Melo ,Alexander Shishkin ,Balbir Singh ,Markus Elfring ,"David S. Miller" ,Nicolas Dichtel ,Andrew Morton ,Konstantin Khlebnikov ,Jiri Slaby ,Cyrill Gorcunov ,Michal Hocko ,Vlastimil Babka ,Dave Hansen ,Greg Kroah-Hartman ,Dan Carp

Re: [PATCH] dt: bindings: Add a generic ethernet device binding

2016-07-15 Thread Arnd Bergmann
On Wednesday, July 13, 2016 12:20:04 PM CEST Hans de Goede wrote: > +&mmc1 { > + non-removable; > + status = "okay"; > + > + sdio_wifi: sdio_wifi@1 { > + compatible = "generic,ethernet" > + reg = <1>; > + }; > +}; For discoverable buses, we norma

Question on IPv6 default route metrics

2016-07-15 Thread Petri Gynther
netdev: I have the same question as Jan in his original thread: http://lkml.iu.edu/hypermail/linux/kernel/1108.3/01897.html If a Linux device has multiple IPv6 default routes (e.g. via eth0 and wlan0), they all currently have the same metric 1024. But, wired route is normally preferred. So, it s

[PATCH net-next] sctp: fix GSO for IPv6

2016-07-15 Thread Marcelo Ricardo Leitner
commit 90017accff61 ("sctp: Add GSO support") didn't register SCTP GSO offloading for IPv6 and yet didn't put any restrictions on generating GSO packets while in IPv6, which causes all IPv6 GSO'ed packets to be silently dropped. The fix is to properly register the offload this time. Fixes: 90017a

[PATCH net-next] sctp: recvmsg should be able to run even if sock is in closing state

2016-07-15 Thread Marcelo Ricardo Leitner
Commit d46e416c11c8 missed to update some other places which checked for the socket being TCP-style AND Established state, as Closing state has some overlapping with the previous understanding of Established. Without this fix, one of the effects is that some already queued rx messages may not be r

Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

2016-07-15 Thread Scott Wood
On Fri, 2016-07-15 at 12:43 -0400, Paul Gortmaker wrote: > On Wed, May 4, 2016 at 11:12 PM, Yangbo Lu wrote: > > > > The global utilities block controls power management, I/O device > > enabling, power-onreset(POR) configuration monitoring, alternate > > function selection for multiplexed signals

Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support

2016-07-15 Thread Florian Fainelli
On 07/08/2016 02:07 AM, Linus Walleij wrote: > +static irqreturn_t smsc911x_pme_irq_thread(int irq, void *dev_id) > +{ > + struct net_device *dev = dev_id; > + struct smsc911x_data *pdata __maybe_unused = netdev_priv(dev); > + > + SMSC_TRACE(pdata, pm, "wakeup event"); > + /* This s

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-15 Thread Jesper Dangaard Brouer
On Fri, 15 Jul 2016 09:47:46 -0700 Alexei Starovoitov wrote: > On Fri, Jul 15, 2016 at 09:18:13AM -0700, Tom Herbert wrote: [..] > > > We don't need extra comlexity of figuring out number of rings and > > > struggling with lack of atomicity. > > > > We already have this problem with other per

Re: [PATCH 1/3] net: smsc911x: augment device tree bindings

2016-07-15 Thread Rob Herring
On Fri, Jul 08, 2016 at 11:07:30AM +0200, Linus Walleij wrote: > This adds device tree bindings for: > > - An optional GPIO line for releasing the RESET signal to the > SMSC911x devices > > - An optional PME (power management event) interrupt line that > can be utilized to wake up the system

Re: [PATCH iproute2] ss: Add option to suppress header line

2016-07-15 Thread David Ahern
On 7/15/16 11:20 AM, David Ahern wrote: Add option to suppress header line. When used the following line is not shown: "State Recv-Q Send-Q Local Address:Port Peer Address:Port" Signed-off-by: David Ahern --- man/man8/ss.8 | 3 +++ misc/ss.c | 28 +++- 2 file

Re: [PATCH iproute2] ss: Fix support for device filter by index

2016-07-15 Thread David Ahern
On 7/15/16 12:53 PM, Stephen Hemminger wrote: On Fri, 15 Jul 2016 09:29:28 -0700 David Ahern wrote: Support was recently added for device filters. The intent was to allow the device to be specified by name or index, and using the if%u format (dev == if5) or the simpler and more intuitive index

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

2016-07-15 Thread Levy, Amir (Jer)
On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > From: Amir Levy > Date: Thu, 14 Jul 2016 14:28:16 +0300 > > > Adding the new Thunderbolt(TM) device IDs to the list. > > > > Signed-off-by: Amir Levy > > Unless these PCI-IDs, all of them, are going to be used in multiple spots in > the > ke

Re: [PATCH iproute2] ss: Fix support for device filter by index

2016-07-15 Thread Stephen Hemminger
On Fri, 15 Jul 2016 09:29:28 -0700 David Ahern wrote: > Support was recently added for device filters. The intent was to allow > the device to be specified by name or index, and using the if%u format > (dev == if5) or the simpler and more intuitive index alone (dev == 5). > The latter case is bro

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-15 Thread David Miller
From: Philipp Zabel Date: Thu, 14 Jul 2016 16:29:43 +0200 > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > it via a boolean device tree property "micrel,fiber-mode". > If it is enabled, auto-negotiation is not supported. > The only available modes are 100base-fx (full duplex

Re: [PATCH 0 / 5] move the common CDC parser

2016-07-15 Thread David Miller
From: Oliver Neukum Date: Thu, 14 Jul 2016 15:41:29 +0200 > Experience has shown that making all CDC drivers depend on usbnet > is not practical, because some of them are not network drivers. > So this patch moves the common parser from usbnet into the messages > helpers of usbcore. > The rest of

Re: [PATCH v3 2/8] thunderbolt: Updating device IDs

2016-07-15 Thread David Miller
From: Amir Levy Date: Thu, 14 Jul 2016 14:28:16 +0300 > Adding the new Thunderbolt(TM) device IDs to the list. > > Signed-off-by: Amir Levy Unless these PCI-IDs, all of them, are going to be used in multiple spots in the kernel, it is not appropriate to add them here. They belong as private m

Re: [PATCH iproute2-master 1/2] man: Add devlink man pages to Makefile

2016-07-15 Thread Stephen Hemminger
On Wed, 13 Jul 2016 09:53:53 +0300 Ido Schimmel wrote: > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel > --- > man/man8/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/man8/Makefile b/man/man8/Makefile > index 929826e..9badbed 100644 > --- a/m

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-15 Thread Jesper Dangaard Brouer
On Fri, 15 Jul 2016 11:08:06 -0700 Tom Herbert wrote: > On Thu, Jul 14, 2016 at 12:25 AM, Jesper Dangaard Brouer > wrote: > > > > I would really really like to see the XDP program associated with the > > RX ring queues, instead of a single XDP program covering the entire NIC. > > (Just move the

Re: [iproute PATCH v4 0/5] Big C99 style initializer rework

2016-07-15 Thread Stephen Hemminger
On Wed, 13 Jul 2016 20:47:14 +0200 Phil Sutter wrote: > This is v4 of my C99-style initializer related patch series. The changes > since v3 are: > > - Use empty initializer instead of the universal zero initializer: > The latter one triggers warnings in older GCCs, and this appears to > be t

Re: [PATCH net-next 0/5] RDS: TCP: Enable mprds for rds-tcp

2016-07-15 Thread David Miller
From: Sowmini Varadhan Date: Thu, 14 Jul 2016 03:51:00 -0700 > The third, and final, installment for mprds-tcp changes. > > In Patch 3 of this set, if the transport support t_mp_capable, > we hash outgoing traffic across multiple paths. Additionally, even if > the transport is MP capable, we

Re: [patch v2 -next] wan/fsl_ucc_hdlc: info leak in uhdlc_ioctl()

2016-07-15 Thread David Miller
From: Dan Carpenter Date: Thu, 14 Jul 2016 14:16:53 +0300 > There is a 2 byte struct whole after line.loopback so we need to clear > that out to avoid disclosing stack information. > > Fixes: c19b6d246a35 ('drivers/net: support hdlc function for QE-UCC') > Signed-off-by: Dan Carpenter > --- > v

Re: [PATCH iproute2] ip route: restore route entries in correct order

2016-07-15 Thread Stephen Hemminger
On Tue, 12 Jul 2016 21:37:58 +0800 Xin Long wrote: > Sometimes we cannot restore route entries, because in kernel > [1] fib_check_nh() > [2] fib_valid_prefsrc() > cause some routes to depend on existence of others while adding. > > For example, we saved all the routes, and flushed all tables

Re: [PATCH v2] Add support for configuring Infiniband GUIDs

2016-07-15 Thread Stephen Hemminger
On Thu, 7 Jul 2016 16:09:03 -0500 Eli Cohen wrote: > Add two NLA's that allow configuration of Infiniband node or port GUIDs > by referencing the IPoIB net device set over the physical function. The > format to be used is as follows: > > ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:7

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-07-15 Thread David Miller
From: Matt Wilson Date: Thu, 14 Jul 2016 09:15:11 -0700 > On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote: >> On 2016/07/14 08:22, Matt Wilson wrote: >> [...] >> > >> > Dave and Benjamin, >> > >> > Do you want to see the interrupt moderation extensions to ethtool and >> > the s

Re: [PATCH iproute 0/5] iproute: ila and fou additions

2016-07-15 Thread Stephen Hemminger
On Thu, 14 Jul 2016 12:22:11 -0700 Tom Herbert wrote: > Patch set includes: > > - Allow configuring checksum mode for ila LWT (e.g. configure > checksum neutral > - Configuration for performing ila translations using netfilter hook > - fou encapsulation for ip6tnl and gre6 > - fou listener for

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-15 Thread Tom Herbert
On Thu, Jul 14, 2016 at 12:25 AM, Jesper Dangaard Brouer wrote: > > I would really really like to see the XDP program associated with the > RX ring queues, instead of a single XDP program covering the entire NIC. > (Just move the bpf_prog pointer to struct mlx4_en_rx_ring) > I think it would be he

Re: [PATCH] dt: bindings: Add a generic ethernet device binding

2016-07-15 Thread David Miller
From: Hans de Goede Date: Fri, 15 Jul 2016 08:40:00 +0200 > Hi, > > On 15-07-16 01:17, David Miller wrote: >> From: Hans de Goede >> Date: Wed, 13 Jul 2016 12:20:04 +0200 >> >>> On some boards (android tablets) different batches use different sdio >>> wifi modules. This is not a problem since s

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-15 Thread Tom Herbert
On Fri, Jul 15, 2016 at 9:47 AM, Alexei Starovoitov wrote: > On Fri, Jul 15, 2016 at 09:18:13AM -0700, Tom Herbert wrote: >> > attaching program to all rings at once is a fundamental part for correct >> > operation. As was pointed out in the past the bpf_prog pointer >> > in the ring design loses

Re: [PATCH] rndis_host: Set random MAC for ZTE MF910

2016-07-15 Thread Bjørn Mork
David Laight writes: > From: Bjørn Mork >> Sent: 13 July 2016 23:23 > ... >> Or how about the more generic?: >> >> if (bp[0] & 0x02) >> eth_hw_addr_random(net); >> else >> ether_addr_copy(net->dev_addr, bp); >> >> That would catch similar screwups from othe

[no subject]

2016-07-15 Thread Easy Loan Finance
I have a business loan for you @1% contact me for more info

Re: [PATCH net-next 2/4] net: bridge: rearrange flood vs unicast receive paths

2016-07-15 Thread Nikolay Aleksandrov
> On Jul 15, 2016, at 10:35 AM, Cong Wang wrote: > > On Wed, Jul 13, 2016 at 8:10 PM, Nikolay Aleksandrov > wrote: >> This patch removes one conditional from the unicast path by using the fact >> that skb is NULL only when the packet is multicast or is local. >> >> Signed-off-by: Nikolay Aleks

Re: [PATCH net-next 2/4] net: bridge: rearrange flood vs unicast receive paths

2016-07-15 Thread Cong Wang
On Wed, Jul 13, 2016 at 8:10 PM, Nikolay Aleksandrov wrote: > This patch removes one conditional from the unicast path by using the fact > that skb is NULL only when the packet is multicast or is local. > > Signed-off-by: Nikolay Aleksandrov > --- > net/bridge/br_input.c | 29 ++-

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

2016-07-15 Thread John Fastabend
On 16-07-15 03:09 AM, Jesper Dangaard Brouer wrote: > On Thu, 14 Jul 2016 17:09:43 -0700 > John Fastabend wrote: > static int pfifo_fast_enqueue(struct sk_buff *skb, struct Qdisc *qdisc, struct sk_buff **to_free) { - if (skb_queue_len(&qdisc->q) < q

  1   2   >