Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

2016-06-27 Thread oulijun
Hi, leon 在 2016/6/24 23:10, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:13PM +0800, Lijun Ou wrote: >> This patch added the operation for cmd, and added some functions >> for initializing eq table and selecting cmd mode. >> >> Signed-off-by: Wei Hu >> Signed-off-by: Nenglong Zhao >> Signe

[PATCH net-next 2/2] qede: Fix the static checker warnings.

2016-06-27 Thread Sudarsana Reddy Kalluru
Static checker warnings: drivers/net/ethernet/qlogic/qede/qede_ethtool.c:435 qede_get_coalesce() warn: passing casted pointer '&coal->rx_coalesce_usecs' to 'edev->ops->common->get_coalesce()' 32 vs 16. The u32 pointer is being typecasted to u16 which may fail for big-endian platforms. Fixes: d552

[PATCH net-next 1/2] qed: Fix static checker warnings.

2016-06-27 Thread Sudarsana Reddy Kalluru
Static checker warnings: drivers/net/ethernet/qlogic/qed/qed_int.c:2450 qed_init_cau_sb_entry() warn: always true condition '(cdev->rx_coalesce_usecs <= 255) => (0-255 <= 255)' drivers/net/ethernet/qlogic/qed/qed_int.c:2511 qed_int_cau_conf_sb() warn: always true condition '(p_hwfn->cdev->rx_coales

[PATCH net-next 0/2] qed*: Fix the static checker warnings.

2016-06-27 Thread Sudarsana Reddy Kalluru
The patch series addresses the static checker warnings introduced by the earlier patches related to qed/qede coalesce configuration support. Sudarsana Reddy Kalluru (2): qed: Fix static checker warnings. qede: Fix the static checker warnings. drivers/net/ethernet/qlogic/qed/qed.h |

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

2016-06-27 Thread Wei Hu (Xavier)
On 2016/6/27 16:31, oulijun wrote: Hi, Leon 在 2016/6/27 16:01, Leon Romanovsky 写道: On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: On 2016/6/24 22:59, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: This patch mainly added reset flow of RoC

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 08:22 +0200, Eric Dumazet wrote: > Follow the stack trace and add another cond_resched() where it is needed > then ? > > Lot of this code was written decade ago where nobody expected a root > user was going to try hard to crash its host ;) > > I did not check if the followi

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 14:09 +0800, Ding Tianhong wrote: > On 2016/6/28 13:13, Eric Dumazet wrote: > > On Tue, 2016-06-28 at 12:56 +0800, Ding Tianhong wrote: > >> The problem was occurs in my system that a lot of drviers register > >> its own handler to the notifiler call chain for netdev_chain, an

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Ding Tianhong
On 2016/6/28 13:13, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:56 +0800, Ding Tianhong wrote: >> The problem was occurs in my system that a lot of drviers register >> its own handler to the notifiler call chain for netdev_chain, and >> then create 4095 vlan dev for one nic, and add several ipv6

[PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-27 Thread Seymour, Shane M
In previous commit 01f83d69844d307be2aa6fea88b0e8fe5cbdb2f4 the following comments were added: "When peer uses tiny windows, there is no use in packetizing to sub-MSS pieces for the sake of SWS or making sure there are enough packets in the pipe for fast recovery." The test should be > TCP_MSS_DE

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-27 Thread John Fastabend
On 16-06-27 09:07 AM, Saeed Mahameed wrote: > From: Or Gerlitz > > Add the commands to set and show the mode of SRIOV E-Switch, > two modes are supported: > > * legacy : operating in the "old" L2 based mode (DMAC --> VF vport) > * offloads : offloading SW rules/policy (e.g Bridge/FDB or TC/Flo

Re: [PATCH net-next 6/9] net: hns: normalize two different loop

2016-06-27 Thread Daode Huang
On 2016/6/27 20:13, Andy Shevchenko wrote: On Mon, 2016-06-27 at 05:08 -0700, Joe Perches wrote: On Mon, 2016-06-27 at 15:00 +0300, Andy Shevchenko wrote: On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote: On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: From: Daode Huang There a

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 12:56 +0800, Ding Tianhong wrote: > The problem was occurs in my system that a lot of drviers register > its own handler to the notifiler call chain for netdev_chain, and > then create 4095 vlan dev for one nic, and add several ipv6 address > on each one of them, just like thi

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: > Hi everyone, > > I'm sorry to bother you. But I was confused. > > The IP ID check (flush_id) in inet_gro_receive is only used by > tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure > the order of skbs, >

[PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Ding Tianhong
The problem was occurs in my system that a lot of drviers register its own handler to the notifiler call chain for netdev_chain, and then create 4095 vlan dev for one nic, and add several ipv6 address on each one of them, just like this: for i in `seq 1 4095`; do ip link add link eth0 name eth0.$i

IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Tan Xiaojun
Hi everyone, I'm sorry to bother you. But I was confused. The IP ID check (flush_id) in inet_gro_receive is only used by tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure the order of skbs, like below: flush |= (__force int)(th->ack_seq ^ th

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

2016-06-27 Thread Joe Perches
On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote: > On 06/25/2016 05:46 PM, Joe Perches wrote: > > > > This debugging macro can expand to a lot of code. > > Make it a function to reduce code size. > > > > (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) > > $ size drivers/net/wirel

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Herbert Xu
On Mon, Jun 27, 2016 at 10:58:42AM -0700, Andy Lutomirski wrote: > > I wonder if it's worth switching from ahash to shash, though. It > would probably be simpler and faster. No shash is not appropriate here because it needs to hash skb frags which are SG lists. Cheers, -- Email: Herbert Xu Hom

Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Ding Tianhong
On 2016/6/28 3:50, Cong Wang wrote: > On Fri, Jun 24, 2016 at 7:46 PM, Ding Tianhong > wrote: >> diff --git a/kernel/notifier.c b/kernel/notifier.c >> index fd2c9ac..9c30411 100644 >> --- a/kernel/notifier.c >> +++ b/kernel/notifier.c >> @@ -92,6 +92,8 @@ static int notifier_call_chain(struct not

Re: [PATCH] geneve: fix max_mtu setting

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 6:27 PM, 严海双 wrote: > > On Jun 28, 2016, at 12:10 AM, Jesse Gross wrote: > > On Sun, Jun 26, 2016 at 6:13 PM, Haishuang Yan > wrote: > > > On Jun 26, 2016, at 8:35 PM, zhuyj wrote: > > + if (geneve->remote.sa.sa_family == AF_INET) > + max_mtu -= sizeo

[PATCH net-next v2 6/6] r8152: add byte_enable for ocp_read_word function

2016-06-27 Thread Hayes Wang
Add byte_enable for ocp_read_word() to replace reading 4 bytes data with reading the desired 2 bytes data. This is used to avoid the issue which is described in commit b4d99def0938 ("r8152: remove sram_read"). The origin method always reads 4 bytes data, and it may have problem when reading the PH

[PATCH net-next v2 5/6] r8152: support RTL8153B

2016-06-27 Thread Hayes Wang
Support new chip RTL8153B. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 560 +--- 1 file changed, 533 insertions(+), 27 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 3ccbff0..2fd4944 100644 --- a/drivers/

[PATCH net-next v2 0/6] r8152: support new chips

2016-06-27 Thread Hayes Wang
v2: Fix the commit message for patch #6. v1: In order to support new chips, adjust some codes. Then, add the settings for the new chips. Hayes Wang (6): r8152: add aldps_enable for rtl_ops r8152: add u1u2_enable for rtl_ops r8152: add power_cut_en for rtl_ops r8152: support the new chip 8

[PATCH net-next v2 4/6] r8152: support the new chip 8050

2016-06-27 Thread Hayes Wang
Support a new chip which has the product ID 0x8050. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a4f8a01..3ccbff0 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/u

[PATCH net-next v2 3/6] r8152: add power_cut_en for rtl_ops

2016-06-27 Thread Hayes Wang
Add power_cut_en() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f51d799..a4f8a01 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/

[PATCH net-next v2 1/6] r8152: add aldps_enable for rtl_ops

2016-06-27 Thread Hayes Wang
Add aldps_enable() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 11178f9..b253003 100644 --- a/drivers/net/usb/r8152.c +++ b/drive

[PATCH net-next v2 2/6] r8152: add u1u2_enable for rtl_ops

2016-06-27 Thread Hayes Wang
Add u1u2_enable() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index b253003..f51d799 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/u

Re: Supporting C45 PHY without ID registers

2016-06-27 Thread Moritz Fischer
Hi Andrew, On Mon, Jun 27, 2016 at 5:56 PM, Andrew Lunn wrote: > Does it have any ID registers at all? There is a vendor specific (to my knowledge) register at device 1 register 65535 ([1]) that could be read back. I haven't seen anyone else do that. Thanks, Moritz [1] http://www.xilinx.com

linux-next: manual merge of the net-next tree with the imx-mxs tree

2016-06-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/freescale/fec.h between commit: 293809055656 ("ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround") from the imx-mxs tree and commit: ff7566b8d71f ("net: fec: add inter

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-06-27 Thread Florian Fainelli
2016-06-27 18:05 GMT-07:00 Andrew Lunn : > On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: >> Hi all, >> >> This patch series adds support for platform data using the new code from >> net/dsa/dsa2.c. The motivation behind this is that we have a bit of in tree >> platforms (ar7, bc

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-06-27 Thread Andrew Lunn
On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: > Hi all, > > This patch series adds support for platform data using the new code from > net/dsa/dsa2.c. The motivation behind this is that we have a bit of in tree > platforms (ar7, bcm47xx, x86, others) that could be benefiting fr

Re: Supporting C45 PHY without ID registers

2016-06-27 Thread Andrew Lunn
On Mon, Jun 27, 2016 at 04:36:20PM -0700, Moritz Fischer wrote: > Hi all, > > I have a 10GigE PHY that I'm working with that has most of it's > functionality availabile via MDIO > in a clause 45 compliant fashion, however the usual probe method fails > since the id registers > are not implemented.

[PATCH net-next 3/6] net: dsa: Suffix function manipulating device_node with _dn

2016-06-27 Thread Florian Fainelli
Make it clear that these functions take a device_node structure pointer Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 3a782ceef716..bdde5d217326 100644 --- a/net/dsa/ds

[PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-06-27 Thread Florian Fainelli
Hi all, This patch series adds support for platform data using the new code from net/dsa/dsa2.c. The motivation behind this is that we have a bit of in tree platforms (ar7, bcm47xx, x86, others) that could be benefiting from the new dsa_register_switch() API model but do not support Device Tree, n

[PATCH net-next 2/6] net: dsa: Make most functions take a dsa_port argument

2016-06-27 Thread Florian Fainelli
In preparation for allowing platform data, and therefore no valid device_node pointer, make most DSA functions takes a pointer to a dsa_port structure whenever possible. While at it, introduce a dsa_port_is_valid() helper function which checks whether port->dn is NULL or not at the moment. Signed-

[PATCH net-next 4/6] net: dsa: Move ports assignment closer to error checking

2016-06-27 Thread Florian Fainelli
Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

2016-06-27 Thread Larry Finger
On 06/25/2016 05:46 PM, Joe Perches wrote: This debugging macro can expand to a lot of code. Make it a function to reduce code size. (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) $ size drivers/net/wireless/realtek/rtlwifi/built-in.o* text data bss dec hex

[PATCH net-next 6/6] net: dsa: Add support for platform data

2016-06-27 Thread Florian Fainelli
Allow drivers to use the new DSA API with platform data. Most of the code in net/dsa/dsa2.c does not rely so much on device_nodes and can get the same information from platform_data instead. Signed-off-by: Florian Fainelli --- include/linux/platform_data/dsa.h | 61 include/net

[PATCH net-next 5/6] net: dsa: Export dev_to_net_device()

2016-06-27 Thread Florian Fainelli
We are going to need this in net/dsa/dsa2.c as well, so make it avaialable. Signed-off-by: Florian Fainelli --- include/net/dsa.h | 1 + net/dsa/dsa.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 6de162c8283e..48dce1fd100a

[PATCH net-next 1/6] net: dsa: Pass device pointer to dsa_register_switch

2016-06-27 Thread Florian Fainelli
In preparation for allowing dsa_register_switch() to be supplied with device/platform data, pass down a struct device pointer instead of a struct device_node. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++ include/net/ds

Re: [RFC] tun: Support VIRTIO_NET_HDR_F_DATA_VALID in tun_get_user

2016-06-27 Thread Tom Herbert
On Fri, Jun 24, 2016 at 7:21 PM, Subash Abhinov Kasiviswanathan wrote: > Userspace applications might sometimes process packets from hardware > which has already validated checksum, perform trivial operations and > then queue them back to the network stack. By not recomputing the > checksum here,

Supporting C45 PHY without ID registers

2016-06-27 Thread Moritz Fischer
Hi all, I have a 10GigE PHY that I'm working with that has most of it's functionality availabile via MDIO in a clause 45 compliant fashion, however the usual probe method fails since the id registers are not implemented. I hacked up drivers/of/of_mdio.c to include something similar to of_get_phy_

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Tom Herbert
On Mon, Jun 27, 2016 at 3:53 PM, Cong Wang wrote: > On Mon, Jun 27, 2016 at 3:04 PM, Tom Herbert wrote: >> On Mon, Jun 27, 2016 at 2:49 PM, Cong Wang wrote: >>> On Mon, Jun 27, 2016 at 2:47 PM, Tom Herbert wrote: On Mon, Jun 27, 2016 at 2:44 PM, Cong Wang wrote: > On Mon, Jun 27

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Cong Wang
On Mon, Jun 27, 2016 at 3:04 PM, Tom Herbert wrote: > On Mon, Jun 27, 2016 at 2:49 PM, Cong Wang wrote: >> On Mon, Jun 27, 2016 at 2:47 PM, Tom Herbert wrote: >>> On Mon, Jun 27, 2016 at 2:44 PM, Cong Wang wrote: On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: > On Mon, Jun 27, 201

Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-06-27 Thread Andy Lutomirski
On Mon, Jun 27, 2016 at 3:30 PM, Marcel Holtmann wrote: > Hi Ingo, > SMP does ECB crypto on stack buffers. This is complicated and fragile, and it will not work if the stack is virtually allocated. Switch to the crypto_cipher interface, which is simpler and safer. Cc

[PATCH] tcp: add an ability to dump and restore window parameters

2016-06-27 Thread Andrey Vagin
We found that sometimes a restored tcp socket doesn't work. A reason of this bug is incorrect window parameters and in this case tcp_acceptable_seq() returns tcp_wnd_end(tp) instead of tp->snd_nxt. The other side drops packets with this seq, because seq is less than tp->rcv_nxt ( tcp_sequence() ).

Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-06-27 Thread Marcel Holtmann
Hi Ingo, >>> SMP does ECB crypto on stack buffers. This is complicated and >>> fragile, and it will not work if the stack is virtually allocated. >>> >>> Switch to the crypto_cipher interface, which is simpler and safer. >>> >>> Cc: Marcel Holtmann >>> Cc: Gustavo Padovan >>> Cc: Johan Hedber

[PATCH 2/2] net: ethernet: mvpp2: use phy_ethtool_{get|set}_link_ksettings

2016-06-27 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/marvell/mvpp2.c | 22 ++ 1 files changed, 2 insertions(+), 20 deletions(-) dif

[PATCH 1/2] net: ethernet: mvpp2: use phydev from struct net_device

2016-06-27 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Tom Herbert
On Mon, Jun 27, 2016 at 2:49 PM, Cong Wang wrote: > On Mon, Jun 27, 2016 at 2:47 PM, Tom Herbert wrote: >> On Mon, Jun 27, 2016 at 2:44 PM, Cong Wang wrote: >>> On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: > The stack doesn

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Cong Wang
On Mon, Jun 27, 2016 at 2:47 PM, Tom Herbert wrote: > On Mon, Jun 27, 2016 at 2:44 PM, Cong Wang wrote: >> On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: >>> On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: The stack doesn't trust the complete csum by hardware even when it is cor

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Tom Herbert
On Mon, Jun 27, 2016 at 2:44 PM, Cong Wang wrote: > On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: >> On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: >>> The stack doesn't trust the complete csum by hardware >>> even when it is correct. >> >> Can you explain that a little further? > > Sure

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Cong Wang
On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: > On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: >> The stack doesn't trust the complete csum by hardware >> even when it is correct. > > Can you explain that a little further? Sure, here is the code in __skb_checksum_complete(): /*

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Eric Dumazet
On Mon, 2016-06-27 at 11:31 -0700, Cong Wang wrote: > Not a problem of your patch, but it seems these allocations never > get freed once we start using tcp md5. Maybe we should free them > when the last socket using tcp md5 is gone? If we constantly allocate-deallocate these tiny blocks for occas

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Eric Dumazet
On Mon, 2016-06-27 at 10:58 -0700, Andy Lutomirski wrote: > Seems reasonable. > > I wonder if it's worth switching from ahash to shash, though. It > would probably be simpler and faster. Well, I have no opinion on this, I will let a crypto guy doing this change if he cares ;) Thanks.

Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device

2016-06-27 Thread Stephen Hemminger
On Mon, 27 Jun 2016 11:34:25 -0700 David Ahern wrote: > + case SSF_DEVCOND: > + { > + struct aafilter *a = (void *)f->pred; I don't like the wandering bracket left, but all the code has that. After this will change it to: case SSF_DEVCOND: {

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-27 Thread Stephen Hemminger
On Mon, 27 Jun 2016 20:23:02 +0200 Phil Sutter wrote: > Hi, > > On Mon, Jun 27, 2016 at 10:59:12AM -0700, Stephen Hemminger wrote: > > On Thu, 23 Jun 2016 17:34:08 + > > Phil Sutter wrote: > > > > > This is v3 of my C99-style initializer related patch series. The changes > > > since v2 are

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Or Gerlitz
On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: > The stack doesn't trust the complete csum by hardware > even when it is correct. Can you explain that a little further? > In the case we fix csum by ourself > probably it is safe to just mark it as completed by software. > This should shut up

[patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag()

2016-06-27 Thread Dan Carpenter
There is a static checker warning here "warn: mask and shift to zero" and the code sets "ring" to zero every time. From looking at how QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the qlcnic_83xx_hndl() should be removed. Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')

Re: [PATCH net-next 03/16] net/mlx5: E-Switch, Add miss rule for offloads mode

2016-06-27 Thread Or Gerlitz
On Mon, Jun 27, 2016 at 7:53 PM, Sergei Shtylyov wrote: >> +static int esw_add_fdb_miss_rule(struct mlx5_eswitch *esw) >> +{ >> + struct mlx5_flow_destination dest; >> + struct mlx5_flow_rule *flow_rule = NULL; >> + int match_header = 0; > > >This variable doesn't appear nec

Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain().

2016-06-27 Thread Cong Wang
On Fri, Jun 24, 2016 at 7:46 PM, Ding Tianhong wrote: > diff --git a/kernel/notifier.c b/kernel/notifier.c > index fd2c9ac..9c30411 100644 > --- a/kernel/notifier.c > +++ b/kernel/notifier.c > @@ -92,6 +92,8 @@ static int notifier_call_chain(struct notifier_block **nl, > #endif >

[PATCH net] bpf, perf: delay release of BPF prog after grace period

2016-06-27 Thread Daniel Borkmann
Commit dead9f29ddcc ("perf: Fix race in BPF program unregister") moved destruction of BPF program from free_event_rcu() callback to __free_event(), which is problematic if used with tail calls: if prog A is attached as trace event directly, but at the same time present in a tail call map used by an

Re: [PATCH v4 00/19] CALIPSO Implementation

2016-06-27 Thread Paul Moore
On Thu, Jun 23, 2016 at 3:21 PM, David Miller wrote: > From: Huw Davies > Date: Tue, 21 Jun 2016 10:55:48 +0100 > >> On Tue, Jun 21, 2016 at 05:39:28AM -0400, David Miller wrote: >>> From: Huw Davies >>> Date: Mon, 20 Jun 2016 14:36:40 +0100 >>> >>> > This patch series implements RFC 5570 - Comm

RE: [PATCH net-next 00/13] liquidio: updates and bug fixes

2016-06-27 Thread Vatsavayi, Raghu
Thanks Dave. Will make sure next time Double-signoffs are not there. Raghu. > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, June 25, 2016 9:09 AM > To: Vatsavayi, Raghu > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next 00/13] liquidio: upd

[PATCH v2 iproute2 0/6] Add support for vrf keyword

2016-06-27 Thread David Ahern
Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link, address, neigh, and route commands to improve the user experience listing data associated with vrfs, modifying routes or doing a rou

[PATCH iproute2 5/6] ip vrf: Add ipvrf_get_table

2016-06-27 Thread David Ahern
Add ipvrf_get_table to lookup table id for device name. Returns 0 on any error or if name is not a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 1 + ip/iplink_vrf.c | 66 + 2 files changed, 67 insertions(+) diff --git a/ip

[PATCH iproute2 6/6] ip route: Add support for vrf keyword

2016-06-27 Thread David Ahern
Add vrf keyword to 'ip route' commands. Allows: 1. Users can list routes by VRF name: $ ip route show vrf NAME VRF tables have all routes including local and broadcast routes. The VRF keyword filters LOCAL and BROADCAST routes; to see all routes the table option can be used. Or to

[PATCH iproute2 4/6] ip route: Change type mask to bitmask

2016-06-27 Thread David Ahern
Allow option to select multiple route types to show or exlude specific route types. Signed-off-by: David Ahern --- ip/iproute.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 8224d7ffa94b..aae693d17be8 100644 --- a/ip/iproute.c +

[PATCH iproute2 1/6] ip vrf: Add name_is_vrf

2016-06-27 Thread David Ahern
Add name_is_vrf function to determine if given name corresponds to a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 2 ++ ip/iplink_vrf.c | 53 + 2 files changed, 55 insertions(+) diff --git a/ip/ip_common.h b/ip/ip_common.h ind

[PATCH v2 iproute2 2/6] ip link/addr: Add support for vrf keyword

2016-06-27 Thread David Ahern
Add vrf keyword to 'ip link' and 'ip addr' commands (common list code). Allows: 1. Adding a link to a VRF $ ip link set NAME vrf NAME Removing a link from a VRF still uses 'ip link set NAME nomaster' 2. Showing links associated with a VRF: $ ip link show vrf NAME 3. List addres

[PATCH iproute2 3/6] ip neigh: Add support for keyword

2016-06-27 Thread David Ahern
Add vrf keyword to 'ip neigh' commands. Allows listing neighbor entries for all links associated with a given VRF. Signed-off-by: David Ahern --- ip/ipneigh.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 4ddb747e2086..3e4447

[PATCH v2 iproute2 1/3] ss: Refactor inet_show_sock

2016-06-27 Thread David Ahern
Extract parsing of sockstat and filter from inet_show_sock. While moving run_ssfilter into callers of inet_show_sock enable userspace filtering before the kill. Signed-off-by: David Ahern --- misc/ss.c | 75 --- 1 file changed, 48 inser

[PATCH v2 iproute2 3/3] ss: Add support to filter on device

2016-06-27 Thread David Ahern
Add support for device names in the filter. Example: root@kenny:~# ss -t 'sport == :22 && dev == red' State Recv-Q Send-Q Local Address:Port Peer Address:Port ESTAB 0 0 10.100.1.2%red:ssh 10.100.1.254:47814 ESTAB 0 0 2100:1

[PATCH v2 iproute2 0/3] ss: Add support to filter by device

2016-06-27 Thread David Ahern
Add support for specifying device name in the filter to ss. The kernel does not provide support for iface filtering, so if the user specifies 'dev == NAME' or 'dev != NAME' all filtering is done in userspace. I will send a patch to add support for iface filtering in the kernel, but the reality is

[PATCH v2 iproute2 2/3] ss: Allow ssfilter_bytecompile to return 0

2016-06-27 Thread David Ahern
Allow ssfilter_bytecompile to return 0 for filter ops the kernel does not support. If such an op is in the filter string then all filtering is done in userspace. Signed-off-by: David Ahern --- misc/ss.c | 52 +--- 1 file changed, 37 insertions(+),

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Cong Wang
On Mon, Jun 27, 2016 at 9:51 AM, Eric Dumazet wrote: > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index > 5c7ed147449c1b7ba029b12e033ad779a631460a..fddc0ab76c1df82cb05dba03271b773e3b2d > 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -2969,8 +2969,18 @@ static void __tcp_alloc

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-27 Thread Phil Sutter
Hi, On Mon, Jun 27, 2016 at 10:59:12AM -0700, Stephen Hemminger wrote: > On Thu, 23 Jun 2016 17:34:08 + > Phil Sutter wrote: > > > This is v3 of my C99-style initializer related patch series. The changes > > since v2 are: [...] > > I like the idea and it makes code cleaner. But doing this i

[Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-27 Thread Cong Wang
The stack doesn't trust the complete csum by hardware even when it is correct. In the case we fix csum by ourself probably it is safe to just mark it as completed by software. This should shut up a kernel warning from netdev_rx_csum_fault() with mlx4 driver for ICMP packets. Fixes: f8c6455bb04b (

[PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink

2016-06-27 Thread Nikolay Aleksandrov
This patch adds stats support for the currently used IGMP/MLD types by the bridge. The stats are per-port (plus one stat per-bridge) and per-direction (RX/TX). The stats are exported via netlink via the new linkxstats API (RTM_GETSTATS). In order to minimize the performance impact, a new option is

Re: [PATCH iproute2 3/3] ss: Add support to filter on device

2016-06-27 Thread Stephen Hemminger
On Tue, 21 Jun 2016 20:38:26 -0700 David Ahern wrote: > Add support for device names in the filter. Example: > > root@kenny:~# ss -t 'sport == :22 && dev == red' > State Recv-Q Send-Q Local Address:Port Peer Address:Port > ESTAB 0 0 10.100.1.2%red:ss

Re: [PATCH iproute2 1/3] ss: Refactor inet_show_sock

2016-06-27 Thread Stephen Hemminger
On Tue, 21 Jun 2016 20:38:24 -0700 David Ahern wrote: > Extract parsing of sockstat and filter from inet_show_sock. > While moving run_ssfilter into callers of inet_show_sock enable > userspace filtering before the kill. > > Signed-off-by: David Ahern I would add this but it has checkpatch sty

Re: [PATCH iproute2] man: ip-link: Add vrf type

2016-06-27 Thread Stephen Hemminger
On Tue, 21 Jun 2016 16:29:01 -0700 David Ahern wrote: > Add description for vrf type to ip-link man page. > > Signed-off-by: David Ahern Applied

Re: [iproute PATCH] Fix MAC address length check

2016-06-27 Thread Stephen Hemminger
On Wed, 22 Jun 2016 12:05:38 +0200 Phil Sutter wrote: > I forgot to change the variable in the conditional, too. > > Fixes: 8fe58d58941f4 ("iplink: Check address length via netlink") > Signed-off-by: Phil Sutter Applied

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Andy Lutomirski
On Mon, Jun 27, 2016 at 9:51 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Some arches have virtually mapped kernel stacks, or will soon have. > > tcp_md5_hash_header() uses an automatic variable to copy tcp header > before mangling th->check and calling crypto function, which might > be probl

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-27 Thread Stephen Hemminger
On Thu, 23 Jun 2016 17:34:08 + Phil Sutter wrote: > This is v3 of my C99-style initializer related patch series. The changes > since v2 are: > > - Flattened embedded struct's initializers: > Since the field names are very short, I figured it makes more sense to > keep indenting low. Also

Re: [PATCH iproute2] Enable use of extra debugging information

2016-06-27 Thread Stephen Hemminger
On Tue, 21 Jun 2016 16:27:09 -0700 David Ahern wrote: > Add -g flag to builds if DEBUG parameter is set. Improves > debugging with gdb. > > Signed-off-by: David Ahern I would rather not put this in the upstream repo. Developers are free to modify flags as they see fit when debugging.

Re: [PATCH iproute2 net-next] bridge: man: fix "brige" typo

2016-06-27 Thread Stephen Hemminger
On Tue, 21 Jun 2016 19:28:50 + Vivien Didelot wrote: > Signed-off-by: Vivien Didelot Applied to current no need to wait for net-next

Re: [iproute PATCH] man: ip-address, ip-link: Document 'type' quirk

2016-06-27 Thread Stephen Hemminger
On Fri, 24 Jun 2016 12:14:23 +0200 Phil Sutter wrote: > This covers the fact that calling 'ip {link|addr} show type foobar' does > not return an error. > > Signed-off-by: Phil Sutter Applied

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-06-27 Thread Marc Dionne
On Mon, Jun 27, 2016 at 12:38 PM, Florian Westphal wrote: > Marc Dionne wrote: >> On Mon, Jun 27, 2016 at 11:22 AM, Florian Westphal wrote: >> > Marc Dionne wrote: >> >> Hi, > >> > hlist_nulls_for_each_entry(h, n, &nf_conntrack_hash[hash], hnnode) >> > if (nf_ct_key_equa

Re: [PATCH net-next 03/16] net/mlx5: E-Switch, Add miss rule for offloads mode

2016-06-27 Thread Sergei Shtylyov
Hello. On 06/27/2016 07:07 PM, Saeed Mahameed wrote: From: Or Gerlitz In the sriov offloads mode, packets that are not matched by any other rule should be sent towards the e-switch manager for further processing. Add such "miss" rule which matches ANY packet as the last rule in the e-switch

Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-06-27 Thread David Decotigny
On Sun, Jun 26, 2016 at 12:45 PM, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Enhancing link mode bits to support 25G/50G/100G > for supported and advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati > --- > ethtool.c | 27 +++ > 1 file cha

[PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-27 Thread Eric Dumazet
From: Eric Dumazet Some arches have virtually mapped kernel stacks, or will soon have. tcp_md5_hash_header() uses an automatic variable to copy tcp header before mangling th->check and calling crypto function, which might be problematic on such arches. David says that using percpu storage is al

[PATCH net] net: bridge: fix vlan stats continue counter

2016-06-27 Thread Nikolay Aleksandrov
I made a dumb off-by-one mistake when I added the vlan stats counter dumping code. The increment should happen before the check, not after otherwise we miss one entry when we continue dumping. Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats") Signed-off-by: Nikolay Aleksandrov --- n

[PATCH net-next 02/16] net/mlx5: E-Switch, Add support for the sriov offloads mode

2016-06-27 Thread Saeed Mahameed
From: Or Gerlitz Unlike the legacy mode, here, forwarding rules are not learned by the driver per events on macs set by VFs/VMs into their vports, but rather should be programmed by higher-level SW entities. Saying that, still, in the offloads mode (SRIOV_OFFLOADS), two flow groups are created b

Re: [PATCH] geneve: fix max_mtu setting

2016-06-27 Thread Jesse Gross
On Sun, Jun 26, 2016 at 6:13 PM, 严海双 wrote: > >> On Jun 26, 2016, at 8:35 PM, zhuyj wrote: >> >> + if (geneve->remote.sa.sa_family == AF_INET) >> + max_mtu -= sizeof(struct iphdr); >> + else >> + max_mtu -= sizeof(struct ipv6hdr); >> >> Sorry, if sa_family

[PATCH net-next 11/16] net/mlx5e: Create NIC global resources only once

2016-06-27 Thread Saeed Mahameed
From: Hadar Hen Zion To allow creating more than one netdev over the same PCI function, we change the driver such that global NIC resources are created once and later be shared amongst all the mlx5e netdevs running over that port. Move the CQ UAR, PD (pdn), Transport Domain (tdn), MKey resources

[PATCH net-next 07/16] net/mlx5: E-Switch, Add API to create vport rx rules

2016-06-27 Thread Saeed Mahameed
From: Or Gerlitz Add the API to create vport rx rules of the form packet meta-data :: vport == $VPORT --> $TIR where the TIR is opened by this VF representor. This logic will by used for packets that didn't match any rule in the e-switch datapath and should be received into the host OS

[PATCH net-next 10/16] net/mlx5e: Add devlink based SRIOV mode changes (legacy --> offloads)

2016-06-27 Thread Saeed Mahameed
From: Or Gerlitz Implement handlers for the devlink commands to get and set the SRIOV E-Switch mode. When turning to the offloads mode, we disable the e-switch and enable it again in the new mode, create the NIC offloads table and create VF reps. When turning to legacy mode, we remove the VF re

[PATCH net-next 14/16] net/mlx5e: Add support for multiple profiles

2016-06-27 Thread Saeed Mahameed
From: Hadar Hen Zion To allow support in representor netdevices where we create more than one netdevice per NIC, add profiles to the mlx5e driver. The profiling allows for creation of mlx5e instances with different characteristics. Each profile implements its own behavior using set of function p

[PATCH net-next 06/16] net/mlx5: E-Switch, Add offloads table

2016-06-27 Thread Saeed Mahameed
From: Or Gerlitz Belongs to the NIC offloads name-space, and to be used as part of the SRIOV offloads logic to steer packets that hit the e-switch miss rule to the TIR of the relevant VF representor. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next 12/16] net/mlx5e: TIRs management refactoring

2016-06-27 Thread Saeed Mahameed
From: Hadar Hen Zion The current refresh tirs self loopback mechanism, refreshes all the tirs belonging to the same mlx5e instance to prevent self loopback by packets sent over any ring of that instance. This mechanism relies on all the tirs/tises of an instance to be created with the same transp

  1   2   3   >