> 在 2016年6月19日，07:24，David Miller 写道：
>
> From: Shanker Wang
> Date: Sun, 19 Jun 2016 07:21:27 +0200
>
>> This patch removes the check for CAP_NET_ADMIN in the initial namespace
>> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user
>> namespace the net namespace was created
From: Shanker Wang
Date: Sun, 19 Jun 2016 07:21:27 +0200
> This patch removes the check for CAP_NET_ADMIN in the initial namespace
> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user
> namespace the net namespace was created so that /dev/ppp cat get opened
> in a unprivileged
This patch removes the check for CAP_NET_ADMIN in the initial namespace
when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user
namespace the net namespace was created so that /dev/ppp cat get opened
in a unprivileged container.
Cc: Hannes Frederic Sowa
Cc: Richard Weinberger
Cc: G
From: Eric Dumazet
Date: Sat, 18 Jun 2016 21:52:01 -0700
> In commit ca15a078bd90 ("sit: generate icmpv6 error when receiving icmpv4
> error"), Oussama Ghorbel added minimal support for SIT tunnels to
> generate ICMPv6 messages when receiving ICMPv4 messages.
>
> This patch series extends this t
SIT or GRE tunnels might want to translate an IPV4 address
into a v4mapped one when translating ICMP to ICMPv6.
This patch adds the parameter to icmp6_send() but
does not change icmpv6_send() signature.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 3 ++-
net/ipv6/icmp.c| 7 +
ipgre_err() can call ip6_err_gen_icmpv6_unreach() for proper
support of ipv4+gre+icmp+ipv6+... frames, used for example
by traceroute/mtr.
Signed-off-by: Eric Dumazet
---
include/net/ip_tunnels.h | 1 +
net/ipv4/gre_demux.c | 1 +
net/ipv4/ip_gre.c| 6 ++
3 files changed, 8 inser
For better traceroute/mtr support for SIT and GRE tunnels,
we translate IPV4 ICMP ICMP_TIME_EXCEEDED to ICMPV6_TIME_EXCEED
We also have to translate the IPv4 source IP address of ICMP
message to IPv6 v4mapped.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 2 +-
net/ipv6/icmp.c
When receiving an ICMPv4 message containing extensions as
defined in RFC 4884, and translating it to ICMPv6 at SIT
or GRE tunnel, we need some extra manipulation in order
to properly forward the extensions.
This patch only takes care of Time Exceeded messages as they
are the ones that typically ca
In commit ca15a078bd90 ("sit: generate icmpv6 error when receiving icmpv4
error"), Oussama Ghorbel added minimal support for SIT tunnels to
generate ICMPv6 messages when receiving ICMPv4 messages.
This patch series extends this to GRE tunnels.
It also adds support for ICMPV6_TIME_EXCEED.
Partial
We want to use this helper from GRE as well, so this is
the time to move it in net/ipv6/icmp.c
Also add a @nhs parameter, since SIT and GRE have different
values for the header(s) to skip.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 1 +
net/ipv6/icmp.c| 39 +++
On Sat, 2016-06-18 at 21:26 -0700, David Miller wrote:
> The golden rule is: "the memory areas must not overlap"
>
> If it can be optimized into calling a memcpy, the memmove
> implementation will do so.
Of course, I guess I have been working on x86 for too long ;)
From: Joshua Houghton
Date: Sat, 18 Jun 2016 15:46:31 +
> Fix coding style issues in the following files:
>
> ib_cm.c: add space
> loop.c: convert spaces to tabs
> sysctl.c: add space
> tcp.h:convert spaces to tabs
> tcp_connect.c:remove extra indentation in switch sta
From: Eric Dumazet
Date: Sat, 18 Jun 2016 21:03:29 -0700
> On Sat, 2016-06-18 at 20:54 -0700, David Miller wrote:
>> From: Eric Dumazet
>> Date: Sat, 18 Jun 2016 16:26:40 -0700
>>
>> > @@ -588,12 +594,26 @@ int ip6_err_gen_icmpv6_unreach(struct sk_buff *skb,
>> > int nhs, int type)
>> >
On Sat, 2016-06-18 at 20:54 -0700, David Miller wrote:
> From: Eric Dumazet
> Date: Sat, 18 Jun 2016 16:26:40 -0700
>
> > @@ -588,12 +594,26 @@ int ip6_err_gen_icmpv6_unreach(struct sk_buff *skb,
> > int nhs, int type)
> > skb2->dev = rt->dst.dev;
> >
> > ipv6_addr_set_v4mapped
From: Basil Gunn
Date: Thu, 16 Jun 2016 09:42:30 -0700
> A socket connection made in ax.25 is not closed when session is
> completed. The heartbeat timer is stopped prematurely and this is
> where the socket gets closed. Allow heatbeat timer to run to close
> socket. Symptom occurs in kernels >=
From: Eric Dumazet
Date: Sat, 18 Jun 2016 16:26:40 -0700
> @@ -588,12 +594,26 @@ int ip6_err_gen_icmpv6_unreach(struct sk_buff *skb, int
> nhs, int type)
> skb2->dev = rt->dst.dev;
>
> ipv6_addr_set_v4mapped(ip_hdr(skb)->saddr, &temp_saddr);
> +
> + if (data_len) {
> +
On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman
wrote:
> On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote:
>> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman
>> wrote:
>> > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote:
>> >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
Hello David,
I don't have a specific commit # for you at the moment but there have been a
few serious regressions since 4.1.x. When new code gets commited, are there
any systems to run regession tests on? I'd be willing to build up a pair of
VMs that can be run with scripts to verify say basi
The array subscript increments after the execution of the statement.
So there is no issue here. However it helps to read the code better.
Signed-off-by: Babu Moger
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/
We obviously don't want to fall through in that switch. With this change
1) We wait for event (triggered by p2p_disc) as expected
2) We remove interface manually on timeout
3) We return 0 on success instead of -ENOTSUPP
Signed-off-by: Rafał Miłecki
---
drivers/net/wireless/broadcom/brcm80211/brc
This patch removes the check for CAP_NET_ADMIN in the initial namespace
when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user
namespace the net namespace was created so that /dev/ppp cat get opened
in a unprivileged container.
Cc: Hannes Frederic Sowa
Cc: Richard Weinberger
Cc: G
We want to use this helper from GRE as well, so this is
the time to move it in net/ipv6/icmp.c
Also add a @nhs parameter, since SIT and GRE have different
values for the header(s) to skip.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 1 +
net/ipv6/icmp.c| 39 +++
When receiving an ICMPv4 message containing extensions as
defined in RFC 4884, and translating it to ICMPv6 at SIT
or GRE tunnel, we need some extra manipulation in order
to properly forward the extensions.
This patch only takes care of Time Exceeded messages as they
are the ones that typically ca
ipgre_err() can call ip6_err_gen_icmpv6_unreach() for proper
support of ipv4+gre+icmp+ipv6+... frames, used for example
by traceroute/mtr.
Signed-off-by: Eric Dumazet
---
include/net/ip_tunnels.h | 1 +
net/ipv4/gre_demux.c | 1 +
net/ipv4/ip_gre.c| 6 ++
3 files changed, 8 inser
For better traceroute/mtr support for SIT and GRE tunnels,
we translate IPV4 ICMP ICMP_TIME_EXCEEDED to ICMPV6_TIME_EXCEED
We also have to translate the IPv4 source IP address of ICMP
message to IPv6 v4mapped.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 2 +-
net/ipv6/icmp.c
SIT or GRE tunnels might want to translate an IPV4 address
into a v4mapped one when translating ICMP to ICMPv6.
This patch adds the parameter to icmp6_send() but
does not change icmpv6_send() signature.
Signed-off-by: Eric Dumazet
---
include/linux/icmpv6.h | 3 ++-
net/ipv6/icmp.c| 7 +
In commit ca15a078bd90 ("sit: generate icmpv6 error when receiving icmpv4
error"), Oussama Ghorbel added minimal support for SIT tunnels to
generate ICMPv6 messages when receiving ICMPv4 messages.
This patch series extends this to GRE tunnels.
It also adds support for ICMPV6_TIME_EXCEED.
Partial
On Sat, Jun 18, 2016 at 02:22:13PM +0900, Takashi Sakamoto wrote:
> Hi,
Hi Takashi,
You raise a lot of valid points and questions, I'll try to answer them.
edit: this turned out to be a somewhat lengthy answer. I have tried to
shorten it down somewhere. it is getting late and I'm getting increa
On 18 June 2016 at 23:58, Rafał Miłecki wrote:
> On 18 June 2016 at 21:26, Arend van Spriel
> wrote:
>> On 18-06-16 20:18, Rafał Miłecki wrote:
>>> So far when receiving event about in-firmware-interface removal we were
>>> notifying our listener and afterwards we were removing Linux interface.
Hi,
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.7-rc3 next-20160617]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jakub-Kicinski/register-field-manipul
On 18 June 2016 at 21:26, Arend van Spriel wrote:
> On 18-06-16 20:18, Rafał Miłecki wrote:
>> So far when receiving event about in-firmware-interface removal we were
>> notifying our listener and afterwards we were removing Linux interface.
>>
>
> [snip]
>
>>
>> diff --git a/drivers/net/wireless/
Hi Andrew,
Andrew Lunn writes:
>> +struct mv88e6xxx_smi_ops {
>> +int (*read)(struct mii_bus *bus, int sw_addr,
>> +int addr, int reg, u16 *val);
>> +int (*write)(struct mii_bus *bus, int sw_addr,
>> + int addr, int reg, u16 val);
>> +};
>
> Hi Vivien
>
>
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/aurora/nb8800.c | 24 ++--
1 files changed, 2 insertions(+), 22 deletions(-)
d
The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet
On Fri, Jun 17, 2016 at 08:07:36PM -0400, Vivien Didelot wrote:
> The switch ID is located at address 0x3 of every Port Registers bank.
>
> But not all Marvell switches have their Port Registers SMI Addresses
> starting at 0x10. 88E6060 starts at 0x8 and 88E6390 starts at 0x0.
>
> Add this data i
> +struct mv88e6xxx_smi_ops {
> + int (*read)(struct mii_bus *bus, int sw_addr,
> + int addr, int reg, u16 *val);
> + int (*write)(struct mii_bus *bus, int sw_addr,
> + int addr, int reg, u16 val);
> +};
Hi Vivien
I still think this API should be based on
On Fri, Jun 17, 2016 at 08:07:34PM -0400, Vivien Didelot wrote:
> After allocating the chip structure, pass it a compatible info pointer.
>
> The compatible info structure will be used later to describe how to
> access the switch registers and where to read the switch ID.
>
> For the standard MDI
On Fri, Jun 17, 2016 at 08:07:33PM -0400, Vivien Didelot wrote:
> Extract the common detection code which assigns the info structure to
> the chip given the read switch ID.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Fri, Jun 17, 2016 at 08:07:32PM -0400, Vivien Didelot wrote:
> Add an helper function to isolate SMI specific assignations and checks.
I don't think you meant assignations. Assignments?
Otherwise
Reviewed-by: Andrew Lunn
Andrew
On Fri, Jun 17, 2016 at 08:07:31PM -0400, Vivien Didelot wrote:
> Add an helper function to allocate the chip structure at the beginning
> of the probe functions. It will be used to initialize the SMI access.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Fri, Jun 17, 2016 at 08:07:30PM -0400, Vivien Didelot wrote:
> The chip smi_mutex mutex is used to protect the access to the internal
> switch registers, not only the Multi-chip Addressing Mode, as commented.
>
> Other registers access (like management frames) may use this mutex.
>
> Since we
On Fri, Jun 17, 2016 at 08:07:29PM -0400, Vivien Didelot wrote:
> The mv88e6xxx_table array and the mv88e6xxx_lookup_info function are
> static, so remove the table and size arguments from the lookup function.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Fri, Jun 17, 2016 at 08:07:28PM -0400, Vivien Didelot wrote:
> Use the optional variant to get the reset GPIO line, instead of checking
> for the -ENOENT error.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On 18-06-16 20:18, Rafał Miłecki wrote:
> New firmwares (e.g. 10.10.69.36 for BCM4366) support "interface_remove"
> for removing interfaces. Try to use this method on cfg80211 request. In
> case of older firmwares (e.g. 7.35.177.56 for BCM43602 as I tested) this
> will just result in firmware rejec
On 18-06-16 20:18, Rafał Miłecki wrote:
> So far when receiving event about in-firmware-interface removal we were
> notifying our listener and afterwards we were removing Linux interface.
>
[snip]
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
> b/drivers/net/wireless
So far when receiving event about in-firmware-interface removal we were
notifying our listener and afterwards we were removing Linux interface.
This order was most likely a try to avoid a lockup. Removing in-firmware
interface could be requested by a driver code holding rtnl lock. Such
code waits
New firmwares (e.g. 10.10.69.36 for BCM4366) support "interface_remove"
for removing interfaces. Try to use this method on cfg80211 request. In
case of older firmwares (e.g. 7.35.177.56 for BCM43602 as I tested) this
will just result in firmware rejecting command and this won't change any
behavior.
On Saturday, 18 June 2016 09:22:49 UTC santosh.shilim...@oracle.com wrote:
> On 6/18/16 8:46 AM, Joshua Houghton wrote:
> > Fix coding style issues in the following files:
> >
> > ib_cm.c: add space
> > loop.c: convert spaces to tabs
> > sysctl.c: add space
> > tcp.h:convert
This header provides two inline functions using struct brcmf_if so we
need core.h to avoid:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h: In function
‘ndev_to_prof’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:368:13: error:
dereferencing pointer to incomplete type
On 6/18/16 8:46 AM, Joshua Houghton wrote:
Fix coding style issues in the following files:
ib_cm.c: add space
loop.c: convert spaces to tabs
sysctl.c: add space
tcp.h:convert spaces to tabs
tcp_connect.c:remove extra indentation in switch statement
tcp_recv.c: convert sp
On Sat, 2016-06-18 at 11:24 -0400, Jamal Hadi Salim wrote:
> On 16-06-18 11:16 AM, Eric Dumazet wrote:
>
> >> Given an update/replace of an action is such a rare occassion, what
> >> is wrong with init doing a spin lock on existing action?
> >> Sure, there is performance impact on fast path at tha
On 16-06-18 11:16 AM, Eric Dumazet wrote:
Given an update/replace of an action is such a rare occassion, what
is wrong with init doing a spin lock on existing action?
Sure, there is performance impact on fast path at that point - but:
as established update/replace is _a rare occassion_ ;->
The
On Sat, 2016-06-18 at 09:45 -0400, Jamal Hadi Salim wrote:
> On 16-06-17 06:03 PM, Eric Dumazet wrote:
> > On Fri, Jun 17, 2016 at 2:59 PM, Cong Wang wrote:
> >
> >> Generally speaking I worry about we change multiple fields in a struct
> >> meanwhile we could still read them any time in the middl
From: Jamal Hadi Salim
Suggested-by: Daniel Borkmann
Signed-off-by: Jamal Hadi Salim
---
include/linux/skbuff.h | 11 +++
net/netfilter/nft_meta.c | 9 +
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index dc0
From: Jamal Hadi Salim
Extremely useful for setting packet type to host so i dont
have to modify the dst mac address using pedit (which requires
that i know the mac address)
Example usage:
tc filter add dev eth0 parent : protocol ip pref 9 u32 \
match ip src 5.5.5.5/32 \
flowid 1:5 action sk
Fix coding style issues in the following files:
ib_cm.c: add space
loop.c: convert spaces to tabs
sysctl.c: add space
tcp.h:convert spaces to tabs
tcp_connect.c:remove extra indentation in switch statement
tcp_recv.c: convert spaces to tabs
tcp_send.c: convert spaces to
On 16-06-17 01:31 PM, Cong Wang wrote:
My patch is against -net. (I see you already figured out your patch is
missing in -net-next.)
Ok, should have re-read this email before working on the patch;->
Or are you suggesting to rebase it for -net-next? I think it fixes some real
bug so -net is
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/altera/altera_tse_ethtool.c | 24 +
1 files changed, 2 insertions(+), 22 deleti
The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet
On 16-06-18 04:00 AM, Jiri Pirko wrote:
Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote:
Yep. And I believe that for offloaded forwarding, this tools should see
hw counters, as they show what is going on in real.
If your NIC is offloading packets today, these tools typically
On 16-06-18 12:31 AM, David Miller wrote:
From: Jamal Hadi Salim
Date: Fri, 17 Jun 2016 07:15:27 -0400
Ok, mystery solved. Dave, this patch series is missing from current
net-next.
Then what is:
commit 53eb440f4ada034ea43b295891feec3df0fa7a29
/blink, blink
sorry ;-> I should have pulled b
On 16-06-17 06:03 PM, Eric Dumazet wrote:
On Fri, Jun 17, 2016 at 2:59 PM, Cong Wang wrote:
Generally speaking I worry about we change multiple fields in a struct
meanwhile we could still read them any time in the middle, we may
get them correct for some easy case, but it is hard to insure the
Arnd Bergmann wrote:
> Calling sdio_claim_host() from the interface independent part of
> the mwifiex driver is not only a layering violation, but also causes
> a link error if MMC support is disabled, or if CONFIG_MMC=m
> and CONFIG_MWIFIEX=y:
>
> drivers/net/built-in.o: In function `mwifiex_fw_
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 24 ++--
1 files changed, 2 insertions(+), 22 deletion
The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet
The nctrl.udd[] array has 32 elements of size u64.
Imagine that netdev_mc_count() returns more than 32. That means
"mc_count" is 32. On the last iteration through the loop we have
mc == &nctrl.udd[32] so we're writing one element beyond the end
of the array.
Fixes: f21fb3ed364b ('Add support of
We don't use "i" in this function.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c
b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 715ddfa..1126422 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/li
Remove a stray space character and fix an if statement that wasn't
indented.
Signed-off-by: Dan Carpenter
---
Speaking of style issues, this whole file follows return 1 on error
and 0 on success. It was confusing for me. It's not too late to change
it to use correct error codes. ;)
diff --git
rxrpc_lookup_peer_rcu() returns NULL on error, it never returns error
pointers.
Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table and
RCU')
Signed-off-by: Dan Carpenter
diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index 47fb167..e11e4d7 100644
--- a/net/rxrpc/inpu
Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote:
>On 06/17/2016 08:42 AM, Jiri Pirko wrote:
>> Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote:
>>> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote:
On 16-06-17 10:05 AM, Jiri Pirko wrote:
> Fri, Jun 17, 2016
70 matches
Mail list logo
