Re: [PATCH net] net: bcmgenet: device stats are unsigned long

2016-04-16 Thread David Miller
From: Eric Dumazet Date: Fri, 15 Apr 2016 10:47:52 -0700 > From: Eric Dumazet > > On 64bit kernels, device stats are 64bit wide, not 32bit. > > Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file") > Signed-off-by: Eric Dumazet > Cc: Florian Fainelli Applied, thanks Eric.

Re: [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up

2016-04-16 Thread David Miller
From: Phil Sutter Date: Fri, 15 Apr 2016 19:14:18 +0200 > The following series converts two further drivers away from setting > 'tx_queue_len = 0' to adding IFF_NO_QUEUE to priv_flags instead. > > The first one, rtl8188eu in staging didn't exist back when all drivers > were converted. The second

Re: [PATCH net-next v2 0/6] FUJITSU Extended Socket driver version 1.1

2016-04-16 Thread David Miller
From: Taku Izumi Date: Fri, 15 Apr 2016 11:20:00 +0900 > This patchsets update FUJITSU Extended Socket network driver into version 1.1. > This mainly includes some improvements and minor bugfix. > > v1->v2: > - Remove ioctl and debugfs facility according to David comment Series applied.

Re: [PATCH net-next v3 1/2] rtnetlink: add new RTM_GETSTATS message to query stats

2016-04-16 Thread roopa
On 4/16/16, 12:49 AM, Thomas Graf wrote: > On 04/15/16 at 08:28pm, Roopa Prabhu wrote: >> +static u16 rtnl_stats_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) >> +{ >> +struct net *net = sock_net(skb->sk); >> +struct net_device *dev; >> +u16 min_ifinfo_dump_size = 0; >> +struct

Re: [net-next PATCH] stmmac: socfpga: remove extra call to socfpga_dwmac_setup

2016-04-16 Thread David Miller
From: Date: Thu, 14 Apr 2016 20:42:29 -0500 > From: Dinh Nguyen > > In the socfpga_dwmac_probe function, we have a call to socfpga_dwmac_setup, > which is already called from socfpga_dwmac_init later in the probe function. > Remove this extra call to socfpga_dwmac_setup. > > Also we should not

Re: [PATCH] bpf: avoid warning for wrong pointer cast

2016-04-16 Thread Alexei Starovoitov
On Sat, Apr 16, 2016 at 10:29:33PM +0200, Arnd Bergmann wrote: > Two new functions in bpf contain a cast from a 'u64' to a > pointer. This works on 64-bit architectures but causes a warning > on all 32-bit architectures: > > kernel/trace/bpf_trace.c: In function 'bpf_perf_event_output_tp': > kerne

Re: [Odd commit author id merge via netdev]

2016-04-16 Thread santosh shilimkar
On 4/1/2016 3:15 PM, santosh shilimkar wrote: On 4/1/2016 1:01 PM, Johannes Berg wrote: On Fri, 2016-04-01 at 10:51 -0700, santosh shilimkar wrote: Hi Dave, I noticed something odd while checking the recent commits of mine in kernel.org tree made it via netdev. Don't know if its patchwork too

Re: [net][PATCH v2 0/2] RDS: couple of fixes for 4.6

2016-04-16 Thread santosh shilimkar
On 4/16/2016 3:53 PM, David Miller wrote: From: Santosh Shilimkar Date: Thu, 14 Apr 2016 10:43:25 -0700 git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git for_4.6/net/rds-fixes I have no idea how you set this up, but there is no WAY this can be pulled from by me. Thought

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-16 Thread Arnd Bergmann
On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote: > > The patch was build-tested / debugged by removing the > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > code, since I don't think anyone really ever touches this driv

Re: [PATCH] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-16 Thread David Miller
From: Andrew Lunn Date: Thu, 14 Apr 2016 23:47:12 +0200 > These macros hide a ds variable and a return statement on error, which > can lead to locking issues. Kill them off. > > Signed-off-by: Andrew Lunn Applied, thanks Andrew.

Re: [net-next PATCH] netdev_features: Add NETIF_F_TSO_MANGLEID to NETIF_F_ALL_TSO

2016-04-16 Thread David Miller
From: Alexander Duyck Date: Thu, 14 Apr 2016 17:04:34 -0400 > I realized that when I added NETIF_F_TSO_MANGLEID as a TSO type I forgot to > add it to NETIF_F_ALL_TSO. This patch corrects that so the flag will be > included correctly. > > The result should be minor as it was only used by a few d

Re: [net-next PATCH 0/5] Add support for offloads with IPv6 GRE tunnels

2016-04-16 Thread David Miller
From: Alexander Duyck Date: Thu, 14 Apr 2016 15:33:30 -0400 > This patch series enables the use of segmentation and checksum > offloads with IPv6 based GRE tunnels. Series applied, nice work Alex.

Re: [PATCH net 0/3] net: dsa: mv88e6xxx: fix hardware cross-chip bridging

2016-04-16 Thread David Miller
From: Vivien Didelot Date: Thu, 14 Apr 2016 14:42:06 -0400 > In order to accelerate cross-chip switching of frames with the hardware, > the DSA Tag ports, used to interconnect switch devices, must learn SA > and DA addresses, and share the same FDB with the user ports. > > The two first patches

Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update

2016-04-16 Thread David Miller
From: Santosh Shilimkar Date: Thu, 14 Apr 2016 10:43:27 -0700 > Two different threads with different rds sockets may be in > rds_recv_rcvbuf_delta() via receive path. If their ports > both map to the same word in the congestion map, then > using non-atomic ops to update it could cause the map to

Re: [net][PATCH v2 1/2] RDS: fix endianness for dp_ack_seq

2016-04-16 Thread David Miller
From: Santosh Shilimkar Date: Thu, 14 Apr 2016 10:43:26 -0700 > From: Qing Huang > > dp->dp_ack_seq is used in big endian format. We need to do the > big endianness conversion when we assign a value in host format > to it. > > Signed-off-by: Qing Huang > Signed-off-by: Santosh Shilimkar App

Re: [net][PATCH v2 0/2] RDS: couple of fixes for 4.6

2016-04-16 Thread David Miller
From: Santosh Shilimkar Date: Thu, 14 Apr 2016 10:43:25 -0700 > git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git > for_4.6/net/rds-fixes I have no idea how you set this up, but there is no WAY this can be pulled from by me. When I try to pull it into 'net' I get 2690 objects.

Re: [PATCH] ipv6: allow bypassing cross-intf routing limits

2016-04-16 Thread David Miller
From: Michal Kazior Date: Thu, 14 Apr 2016 14:46:28 +0200 > There are some use-cases to allow link-local > routing for bridging purposes. > > One of these is allowing transparent 802.11 > bridging. Due to 802.11 framing limitations many > Access Points make it impossible to create bridges > on C

[PATCH net-next v3 3/8] net: dsa: mv88e6xxx: read switch ID in probe

2016-04-16 Thread Vivien Didelot
Read the switch ID only once, at probe time, to avoid multiple read accesses and MII bus checking. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 54 + 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers/net/dsa/mv8

[PATCH net-next v3 1/8] net: dsa: mv88e6xxx: drop double ds assignment

2016-04-16 Thread Vivien Didelot
Every driver assigns ps->ds even though it gets assigned in the shared mv88e6xxx_setup_common function. Kill redundancy. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 2 -- drivers/net/dsa/mv88e6131.c | 2 -- drivers/net/dsa/mv88e6171.c | 2 -- drivers

[PATCH net-next v3 6/8] net: dsa: mv88e6xxx: add number of ports to info

2016-04-16 Thread Vivien Didelot
Drop the ps->num_ports variable in favor of a new member of the info structure. This removes the need to assign it at setup time. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 16 +++- drivers/net/dsa/mv88e6131.c | 22 +-

[PATCH net-next v3 4/8] net: dsa: mv88e6xxx: add switch info

2016-04-16 Thread Vivien Didelot
Add a new switch info structure which is meant to store switch models static information, such as product number, name, number of ports, number of databases, etc. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 15 +++ drivers/net/dsa/mv88e6131.c | 19 ++--

[PATCH net-next v3 5/8] net: dsa: mv88e6xxx: add family to info

2016-04-16 Thread Vivien Didelot
Add an mv88e6xxx_family enum to the info structure for better family indentification. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 3 ++ drivers/net/dsa/mv88e6131.c | 4 +++ drivers/net/dsa/mv88e6171.c | 4 +++ drivers/net/dsa/mv88e6352.c | 6

[PATCH net-next v3 2/8] net: dsa: mv88e6xxx: drop revision probing

2016-04-16 Thread Vivien Didelot
There is no point in having a special case for the revision when probing a switch model. The code gets cluttered with unnecessary defines, and leads to errors when code such as mv88e6131_setup compares PORT_SWITCH_ID_6131_B2 to ps->id which masks the revision. Drop every revision definition, and l

[PATCH net-next v3 0/8] net: dsa: mv88e6xxx: factorize switch info

2016-04-16 Thread Vivien Didelot
This patchset factorizes the mv88e6xxx code by sharing a new extendable info structure to store static data such as switch family, product number, number of ports, number of databases and the name. The next step is to add a "flags" bitmap member to the info structure in order to simplify the share

[PATCH net-next v3 8/8] net: dsa: mv88e6xxx: remove switch ID from ps

2016-04-16 Thread Vivien Didelot
ps->id is not needed anymore, so remove it as well as the related defined values. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 1 - drivers/net/dsa/mv88e6xxx.h | 32 2 files changed, 33 deletions(-) diff --git a/driv

[PATCH net-next v3 7/8] net: dsa: mv88e6xxx: add number of db to info

2016-04-16 Thread Vivien Didelot
Add the number of databases to the info structure. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 3 +++ drivers/net/dsa/mv88e6131.c | 4 drivers/net/dsa/mv88e6171.c | 4 drivers/net/dsa/mv88e6352.c | 6 ++ drivers/net/dsa/mv88e6xxx.c

Re: [PATCH v3 0/5] net: w5100: add support W5100/W5200 for SPI interface

2016-04-16 Thread David Miller
From: Akinobu Mita Date: Fri, 15 Apr 2016 00:11:28 +0900 > This series add support for Wiznet W5100 and W5200 for SPI interface. Series applied, thank you.

Re: [PATCH net-next] vxlan: reduce usage of synchronize_net in ndo_stop

2016-04-16 Thread David Miller
From: Hannes Frederic Sowa Date: Sat, 9 Apr 2016 12:46:23 +0200 > We only need to do the synchronize_net dance once for both, ipv4 and > ipv6 sockets, thus removing one synchronize_net in case both sockets get > dismantled. > > Signed-off-by: Hannes Frederic Sowa Applied.

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-16 Thread David Miller
From: Hannes Frederic Sowa Date: Fri, 8 Apr 2016 22:55:01 +0200 > Due to the fact that the udp socket is destructed asynchronously in a > work queue, we have some nondeterministic behavior during shutdown of > vxlan tunnels and creating new ones. Fix this by keeping the destruction > process syn

[PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-16 Thread Sinan Kaya
Current code is assuming that the address returned by dma_alloc_coherent is a logical address. This is not true on ARM/ARM64 systems. This patch replaces dma_alloc_coherent with dma_map_page API. The address returned can later by virtually mapped from the CPU side with vmap API. Signed-off-by: Sin

[PATCH] of_mdio: make of_mdiobus_register_{device|phy}() *void*

2016-04-16 Thread Sergei Shtylyov
The results of of_mdiobus_register_{device|phy}() are never checked, so we can make both these functions *void*... Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo. drivers/of/of_mdio.c | 21 - 1 file changed, 8 insertions(+), 13 deleti

Re: [PATCH] netlink: don't send NETLINK_URELEASE for unbound sockets

2016-04-16 Thread Johannes Berg
On Sat, 2016-04-16 at 14:30 +0800, Herbert Xu wrote: > Johannes Berg wrote: > > > > > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > > index 215fc08c02ab..330ebd600f25 100644 > > --- a/net/netlink/af_netlink.c > > +++ b/net/netlink/af_netlink.c > > @@ -688,7 +688,7 @@ stati

Re: [PATCH] devlink: fix devlink_sb_register prototype

2016-04-16 Thread Jiri Pirko
Sat, Apr 16, 2016 at 10:27:06PM CEST, a...@arndb.de wrote: >The devlink shared buffer interface contains two different >prototypes for devlink_sb_register, and the one that is >used when NET_DEVLINK is disabled does not work: > >drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c: In function >

[PATCH] ixgbe: use msleep for long delays

2016-04-16 Thread Arnd Bergmann
The newly added x550em_a support causes a link failure on ARM because of an overly long time passed into udelay(): ERROR: "__bad_udelay" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined! There are multiple variants of the ixgbe_acquire_swfw_sync_*() function, and the other ones all use mslee

[PATCH] bpf: avoid warning for wrong pointer cast

2016-04-16 Thread Arnd Bergmann
Two new functions in bpf contain a cast from a 'u64' to a pointer. This works on 64-bit architectures but causes a warning on all 32-bit architectures: kernel/trace/bpf_trace.c: In function 'bpf_perf_event_output_tp': kernel/trace/bpf_trace.c:350:13: error: cast to pointer from integer of differe

[PATCH] devlink: fix devlink_sb_register prototype

2016-04-16 Thread Arnd Bergmann
The devlink shared buffer interface contains two different prototypes for devlink_sb_register, and the one that is used when NET_DEVLINK is disabled does not work: drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c: In function 'mlxsw_sp_buffers_init': drivers/net/ethernet/mellanox/mlxsw/spec

[PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-16 Thread Arnd Bergmann
A recent patch removed many 'inline' annotations for static functions in this file, which has caused warnings for functions that are not used in a given configuration, in particular when CONFIG_NF_CONNTRACK_EVENTS is disabled: nf_conntrack_netlink.c:572:15: 'ctnetlink_timestamp_size' defined but n

Re: WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

2016-04-16 Thread Grumbach, Emmanuel
On Sat, 2016-04-16 at 17:43 +0200, Borislav Petkov wrote: > On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote: > > [1] > > https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi > > fi.git/ > > It is very strange to pull from this repo, git fetch is doing > something

Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

2016-04-16 Thread David Ahern
On 4/15/16 9:13 PM, Mike Manning wrote: f1705ec197e7 added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of this change

Re: WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

2016-04-16 Thread Borislav Petkov
On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote: > [1] https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi > fi.git/ It is very strange to pull from this repo, git fetch is doing something for a while now without any forward progress. In any case, 4.5 is bad too

Re: [PATCH v2] carl9170: Clarify kconfig text

2016-04-16 Thread Christian Lamparter
On Saturday, April 16, 2016 05:18:56 PM Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > >

Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

2016-04-16 Thread Sergei Shtylyov
Hello. On 4/16/2016 6:13 AM, Mike Manning wrote: f1705ec197e7 added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of

[PATCH v2] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- v2: Remove the mention of the previous d

Grant Donation

2016-04-16 Thread Julie Leach
-- You have a cash grant donation of $2,500.000.00 USD, I am Julie Leach;Won $310.5 million Powerball jackpot winner. To verify the genuineness of this email and my winnings, please you can read more about me by viewing the below links: http://www.powerball.com/powerball/winners/2015/MI_Leac

[PATCH net-next 5/6] nfp: remove buggy RX buffer length validation

2016-04-16 Thread Jakub Kicinski
Meaning of data_len and meta_len RX WB descriptor fields is slightly confusing. Add a comment with a diagram clarifying the layout. Also remove the buffer length validation: (a) it's imprecise for static rx-offsets; (b) if firmware is buggy enough to DMA past the end of the buffer WARN_ON_ONCE()

[PATCH net-next 6/6] nfp: add async reconfiguration mechanism

2016-04-16 Thread Jakub Kicinski
Some callers of nfp_net_reconfig() are in atomic context so we used to busy wait for commands to complete. In worst case scenario that means locking up a core for up to 5 seconds when a command times out. Lets add a timer-based mechanism of asynchronously checking whether reconfiguration complete

[PATCH net-next 2/6] nfp: remove unnecessary static

2016-04-16 Thread Jakub Kicinski
There is no reason for those local variables to be static. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c b/drivers/net/ethernet/netro

[PATCH net-next 4/6] nfp: remove unused suspicious mask defines

2016-04-16 Thread Jakub Kicinski
NFP_NET_RXR_MASK sounds like a mask which could be used on NFP_NET_CFG_RXRS_ENABLE register but its value is quite strange. In fact there are no users of this define so let's just remove it. Same for TX rings. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h

[PATCH net-next 3/6] nfp: correct names of constants in comments

2016-04-16 Thread Jakub Kicinski
Documentation in comments lacks CFG in some names. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h b/drivers/net/ethernet/netronome/nfp

[PATCH net-next 1/6] nfp: check the right pointer for errors

2016-04-16 Thread Jakub Kicinski
Correct checking error condition on wrong pointer - copy/paste mistake most likely. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c b/d

[PATCH net-next 0/6] nfp: cleanups and improvements

2016-04-16 Thread Jakub Kicinski
Hi! Main purpose of this set is to get rid of doing potentially long mdelay()s but it also contains some trivial changes I've accumulated. First two patches fix harmless copy-paste errors, next two clean up the documentation and remove unused defines. Patch 5 clarifies the interpretation of RX de

Re: qdisc spin lock

2016-04-16 Thread Andrew
I think that it isn't a good solution - unless you can bind specified host (src/dst) to specified txq. Usually traffic is spreaded on txqs by src+dst IP (or even IP:port) hash which results in traffic spreading among all mqs on device, and wrong bandwidth limiting (N*bandwidth on multi-session

[PATCH] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- drivers/net/wireless/ath/carl9170/Kconf

Re: [PATCH net-next v3 RFC 2/2] ipv6: add support for stats via RTM_GETSTATS

2016-04-16 Thread Thomas Graf
On 04/15/16 at 08:28pm, Roopa Prabhu wrote: > +static size_t inet6_get_link_af_stats_size(const struct net_device *dev, > +u32 filter_mask) > +{ > + if (!(filter_mask & IFLA_STATS_FILTER_BIT(IFLA_STATS_LINK_INET6))) > + return 0; > + > + i

Re: [PATCH net-next v3 1/2] rtnetlink: add new RTM_GETSTATS message to query stats

2016-04-16 Thread Thomas Graf
On 04/15/16 at 08:28pm, Roopa Prabhu wrote: > +static u16 rtnl_stats_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) > +{ > + struct net *net = sock_net(skb->sk); > + struct net_device *dev; > + u16 min_ifinfo_dump_size = 0; > + struct if_stats_msg *ifsm; > + u32 filter_mask;