Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2016 at 06:18:25PM -0800, Florian Fainelli wrote: > On 11/02/16 10:58, bryan.whiteh...@microchip.com wrote: > > This is the initial submission of an ethernet driver for > > the Microchip LAN9352. > > > > The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with > > 16-Bit Non-PCI

[PATCH net] tcp: md5: release request socket instead of listener

2016-02-11 Thread Eric Dumazet
If tcp_v4_inbound_md5_hash() returns an error, we must release the refcount on the request socket, not on the listener. The bug was added for IPv4 only. Fixes: 079096f103fac ("tcp/dccp: install syn_recv requests into ehash table") Signed-off-by: Eric Dumazet --- net/ipv4/tcp_ipv4.c | 6 --

[PATCH net-next] tcp: add tcpi_min_rtt and tcpi_notsent_bytes to tcp_info

2016-02-11 Thread Eric Dumazet
From: Eric Dumazet tcpi_min_rtt reports the minimal rtt observed by TCP stack for the flow, in usec unit. Might be ~0U if not yet known. tcpi_notsent_bytes reports the amount of bytes in the write queue that were not yet sent. This is done in a single patch to not add a temporary 32bit padding

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-11 Thread Florian Fainelli
On 11/02/16 10:58, bryan.whiteh...@microchip.com wrote: > This is the initial submission of an ethernet driver for > the Microchip LAN9352. > > The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with > 16-Bit Non-PCI CPU Interface. The CPU interface includes a basic > ethernet controller inter

[PATCH v2 net-next 1/2] tcp/dccp: better use of ephemeral ports in connect()

2016-02-11 Thread Eric Dumazet
In commit 07f4c90062f8 ("tcp/dccp: try to not exhaust ip_local_port_range in connect()"), I added a very simple heuristic, so that we got better chances to use even ports, and allow bind() users to have more available slots. It gave nice results, but with more than 200,000 TCP sessions on a typica

[PATCH v2 net-next 2/2] tcp/dccp: better use of ephemeral ports in bind()

2016-02-11 Thread Eric Dumazet
Implement strategy used in __inet_hash_connect() in opposite way : Try to find a candidate using odd ports, then fallback to even ports. We no longer disable BH for whole traversal, but one bucket at a time. We also use cond_resched() to yield cpu to other tasks if needed. I removed one indentat

[PATCH v2 net-next 0/2] tcp/dccp: better use of ephemeral ports

2016-02-11 Thread Eric Dumazet
Big servers have bloated bind table, making very hard to succeed ephemeral port allocations, without special containers/namespace tricks. This patch series extends the strategy added in commit 07f4c90062f8 ("tcp/dccp: try to not exhaust ip_local_port_range in connect()"). Since ports used by con

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-11 Thread Lino Sanfilippo
Hi, > +static int mchp9352_open(struct net_device *dev) > +{ > + > + MCHP_TRACE(pdata, ifup, "Testing irq handler using IRQ %d", dev->irq); > + pdata->software_irq_signal = 0; > + > + /* Testing irq handler */ > + smp_wmb(); Should not there at least be a matching smp_rmb() in th

Re: [PATCH 8/8] netfilter: implement xt_cgroup cgroup2 path match

2016-02-11 Thread Alban Crequy
Hi, On 7 December 2015 at 23:38, Tejun Heo wrote: > This patch implements xt_cgroup path match which matches cgroup2 > membership of the associated socket. The match is recursive and > invertible. Is there any plans to implement a similar cgroup2 path match in a cgroup classifier in tc? I wonde

Re: BUG: held lock freed! - request_sock_queue::rskq_lock

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 23:43 +0100, Ilya Dryomov wrote: > Hi Eric, > > I'm hitting the following splat (attached in full): > > kernel: = > kernel: [ BUG: held lock freed! ] > kernel: 4.5.0-rc1-ceph-00026-g5e0a311 #1 Not tainted > kernel: - > kernel:

Re: [PATCH] ath10k: fix erroneous return value

2016-02-11 Thread Julian Calaby
Hi All, On Thu, Feb 11, 2016 at 3:58 AM, Anton Protopopov wrote: > The ath10k_pci_hif_exchange_bmi_msg() function may return the positive > value EIO instead of -EIO in case of error. > > Signed-off-by: Anton Protopopov This looks right to me. Reviewed-by: Julian Calaby > --- > drivers/net/

Re: gigaset: memory leak in gigaset_initcshw

2016-02-11 Thread Paul Bolle
Hi Dmitry, On vr, 2016-02-05 at 17:06 +0100, Paul Bolle wrote: > On vr, 2016-02-05 at 14:28 +0100, Dmitry Vyukov wrote: > > I wonder why you don't see the leak I am seeing... > > So do I, for a few days now. 0) I finally managed to reliably trigger this leak on an i686, single core machine (yet

BUG: held lock freed! - request_sock_queue::rskq_lock

2016-02-11 Thread Ilya Dryomov
Hi Eric, I'm hitting the following splat (attached in full): kernel: = kernel: [ BUG: held lock freed! ] kernel: 4.5.0-rc1-ceph-00026-g5e0a311 #1 Not tainted kernel: - kernel: swapper/5/0 is freeing memory 880035c9d200-880035c9dbff, with a l

Re: gigaset: memory leak in gigaset_initcshw

2016-02-11 Thread Paul Bolle
On vr, 2016-02-05 at 22:25 +0100, Dmitry Vyukov wrote: > On Fri, Feb 5, 2016 at 7:36 PM, Paul Bolle wrote: > > Does that make any difference? > Nope. > Almost 500 objects leaked in less than 10 seconds: Too bad. Still a nice (potential) clean up though. Thanks, Paul Bolle

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2016 at 06:58:52PM +, bryan.whiteh...@microchip.com wrote: > This is the initial submission of an ethernet driver for > the Microchip LAN9352. > > The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with > 16-Bit Non-PCI CPU Interface. The CPU interface includes a basic > et

Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-11 Thread Joseph Salisbury
On 02/05/2016 05:30 PM, Rainer Weikusat wrote: > The present unix_stream_read_generic contains various code sequences of > the form > > err = -EDISASTER; > if () > goto out; > > This has the unfortunate side effect of possibly causing the error code > to bleed through to the final > > out: >

[PATCH v5 net-next 8/8] Documentation/networking: add checksum-offloads.txt to explain LCO

2016-02-11 Thread Edward Cree
Signed-off-by: Edward Cree --- Documentation/networking/00-INDEX | 2 + Documentation/networking/checksum-offloads.txt | 119 + include/linux/skbuff.h | 2 + 3 files changed, 123 insertions(+) create mode 100644 Documentation/netwo

[PATCH v5 net-next 7/8] net: ip_tunnel: remove 'csum_help' argument to iptunnel_handle_offloads

2016-02-11 Thread Edward Cree
All users now pass false, so we can remove it, and remove the code that was conditional upon it. Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 2 +- include/net/ip_tunnels.h| 3 +-- include/net/udp_tunnel.h| 3 +-- net/ipv4/fou.c | 4 ++--

[PATCH v5 net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-02-11 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/ip_gre.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 7c51c4e..9b31532 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -440,6 +440,17 @@ drop: return 0;

[PATCH v5 net-next 5/8] fou: enable LCO in FOU and GUE

2016-02-11 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/fou.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 976f0dc..dac1874 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -774,7 +774,6 @@ static void fou_build_udp(struct sk_buff *sk

[PATCH v5 net-next 4/8] net: vxlan: enable local checksum offload

2016-02-11 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index ebf57d9..9f52203 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1702,10 +1702,8 @@ static int vxlan_build_sk

[PATCH v5 net-next 3/8] net: enable LCO for udp_tunnel_handle_offloads() users

2016-02-11 Thread Edward Cree
The only protocol affected at present is Geneve. Signed-off-by: Edward Cree --- include/net/udp_tunnel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index cca2ad3..734c156 100644 --- a/include/net/udp_tunnel.h +++ b/in

[PATCH v5 net-next 2/8] net: udp: always set up for CHECKSUM_PARTIAL offload

2016-02-11 Thread Edward Cree
If the dst device doesn't support it, it'll get fixed up later anyway by validate_xmit_skb(). Also, this allows us to take advantage of LCO to avoid summing the payload multiple times. Signed-off-by: Edward Cree --- net/ipv4/udp.c | 14 +- net/ipv6/ip6_checksum.c | 13 +--

[PATCH v5 net-next 1/8] net: local checksum offload for encapsulation

2016-02-11 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the one

[PATCH v5 net-next 0/8] Local Checksum Offload

2016-02-11 Thread Edward Cree
Re-tested VxLAN; everything else is unchanged from v4. Changes from v4: * Rebased series to fix conflicts with vxlan/vxlan6 merge. Changes from v3: * Fixed inverted checksum values introduced in v3. * Don't mangle zero checksums in GRE. * Clear skb->encapsulation in iptunnel_handle_offloads w

[PATCH net-next v2 0/2] NSH and VxLAN-GPE

2016-02-11 Thread Brian Russell
These patches add a new module to support encap/decap of Network Service Header (NSH) as defined in: https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 Both NSH Type 1 and Type 2 metadata are supported with a simple registration hook to allow listeners to register to see packets with Type 1 or a s

[PATCH net-next v2 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
Support encap/decap of Network Service Header (NSH) as defined in https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 Includes support for Type 1 and Type 2 metadata and a simple registration for listeners to see decapsulated packets based on the Type/Class. Signed-off-by: Brian Russell --- inclu

[PATCH net-next v2 2/2] vxlan: support GPE/NSH

2016-02-11 Thread Brian Russell
Support the Generic Protocol Extension to VxLAN which extends VxLAN to allow multi-protocol encapsulation. IPv4, IPv6, MPLS unicast and NSH encapsulated packets can be sent and received in addition to ethernet frames. As defined in: https://tools.ietf.org/html/draft-ietf-nvo3-vxlan-gpe-01 Signed-

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
On 11/02/16 16:39, David Miller wrote: > From: Brian Russell > Date: Thu, 11 Feb 2016 10:35:13 + > >> +++ b/include/net/nsh.h >> +struct nsh_metadata { >> +u_short class; >> +u_char crit; >> +u_char type; >> +u_int len; /* 4 byte words */ >> +void *data; > > Do not use

[PATCH net] af_unix: Guard against other == sk in unix_dgram_sendmsg

2016-02-11 Thread Rainer Weikusat
The unix_dgram_sendmsg routine use the following test if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) { to determine if sk and other are in an n:1 association (either established via connect or by using sendto to send messages to an unrelated socket identified by address). This is

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-02-11 Thread Vijay Pandurangan
Just as a followup, I wrote a short blog detailing the bug and our resolution: (https://twitter.com/vijayp/status/697837808417779716) Thanks again for your help in guiding us through our first kernel patch. This was a great experience! direct link: https://medium.com/vijay-pandurangan/linux-kern

[PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-11 Thread Bryan.Whitehead
This is the initial submission of an ethernet driver for the Microchip LAN9352. The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with 16-Bit Non-PCI CPU Interface. The CPU interface includes a basic ethernet controller interface whose virtual phy is connected internally to a 3rd port on the

[PATCH net] phy: keep pause flags in phy driver features

2016-02-11 Thread Woojung.Huh
genphy_config_init() masked out pause flags set in phy driver structure. Pause flags needs to be preserved in phydev->supported & phydev->advertising. Signed-off-by: Woojung Huh --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/

Re: [PATCH v2 0/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-11 Thread David Miller
From: "Andrew F. Davis" Date: Sun, 7 Feb 2016 11:47:16 -0600 > This series is [0] split into its logical components. Series applied, thanks.

Re: [net-next PATCH V2 0/3] net: mitigating kmem_cache free slowpath

2016-02-11 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 08 Feb 2016 13:14:54 +0100 > This patchset is the first real use-case for kmem_cache bulk _free_. > The use of bulk _alloc_ is NOT included in this patchset. The full use > have previously been posted here [1]. > > The bulk free side have the largest benef

Re: [PATCH net-next 0/2] tcp/dccp: better use of ephemeral ports

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 11:48 -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri, 5 Feb 2016 18:08:56 -0800 > > > Big servers have bloated bind table, making very hard to succeed > > ephemeral port allocations, without special containers/namespace tricks. > > > > This patch series extend

[PATCH net] tcp: do not set rtt_min to 1

2016-02-11 Thread Eric Dumazet
From: Eric Dumazet There are some cases where rtt_us derives from deltas of jiffies, instead of using usec timestamps. Since we want to track minimal rtt, better to assume a delta of 0 jiffie might be in fact be very close to 1 jiffie. It is kind of sad jiffies_to_usecs(1) calls a function inst

Re: [PATCH net-next 0/2] virtio_net: better ethtool setting validation

2016-02-11 Thread David Miller
From: Nikolay Aleksandrov Date: Sun, 7 Feb 2016 21:52:22 +0100 > This small set is a follow-up for the recent patches that added ethtool > get/set settings. Patch 1 changes the speed validation routine to check > if the speed is between 0 and INT_MAX (or SPEED_UNKNOWN) and patch 2 adds > port va

Re: [patch net-next RFC 1/6] Introduce devlink infrastructure

2016-02-11 Thread Jiri Pirko
Thu, Feb 11, 2016 at 03:31:36PM CET, ivec...@redhat.com wrote: >On 3.2.2016 11:47, Jiri Pirko wrote: >>+struct devlink_ops { >>+ size_t priv_size; >>+ int (*port_type_set)(struct devlink_port *devlink_port, >>+ enum devlink_port_type port_type); >>+}; >It does not m

Re: [PATCH v3 0/6] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-11 Thread David Miller
From: Helmut Buchsbaum Date: Tue, 9 Feb 2016 20:47:12 +0100 > This patch series refactors the spi-ks8995 driver to finally add support > for the MICREL KSZ8795CLX. Additionally support for controlling a GPIO > line for resetting the switch is added. Series applied, thanks.

Re: [PATCH net-next 0/2] tcp/dccp: better use of ephemeral ports

2016-02-11 Thread David Miller
From: Eric Dumazet Date: Fri, 5 Feb 2016 18:08:56 -0800 > Big servers have bloated bind table, making very hard to succeed > ephemeral port allocations, without special containers/namespace tricks. > > This patch series extends the strategy added in commit 07f4c90062f8 > ("tcp/dccp: try to not

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread David Miller
From: Brian Russell Date: Thu, 11 Feb 2016 10:35:13 + > +++ b/include/net/nsh.h > +struct nsh_metadata { > + u_short class; > + u_char crit; > + u_char type; > + u_int len; /* 4 byte words */ > + void *data; Do not use these shorthands, spell out "unsigned short" etc. ex

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
On 11/02/16 16:17, Robert Shearman wrote: > On 11/02/16 11:35, Brian Russell wrote: > ... >> diff --git a/include/net/nsh.h b/include/net/nsh.h >> new file mode 100644 >> index 000..7a5fb95 >> --- /dev/null >> +++ b/include/net/nsh.h >> @@ -0,0 +1,158 @@ >> +/* >> + * Network Service Header (

Re: [PATCH net-next v2] be2net: don't report EVB for older chipsets when SR-IOV is disabled

2016-02-11 Thread David Miller
From: Ivan Vecera Date: Thu, 11 Feb 2016 12:42:26 +0100 > The EVB (virtual bridge) functionality should be disabled on older BE3 > and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting > is identified by the zero value of total VFs reported by the card. > The GET_HSW_CONFIG comma

Re: [PATCH v2 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

2016-02-11 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 11 Feb 2016 21:50:20 +0530 > This patch series contains changes > - To add support for virtual function's irq affinity hint > - Replace napi_schedule() with napi_schedule_irqoff() > - Reduce page allocation overhead by allocating pages > of higher order w

[PATCH v2 1/6] net, thunderx: Add TX timeout and RX buffer alloc failure stats.

2016-02-11 Thread sunil . kovvuri
From: Thanneeru Srinivasulu When system is low on atomic memory, too many error messages are logged. Since this is not a total failure but a simple switch to non-atomic allocation better to have a stat. Also add a stat for reset, kicked due to transmit watchdog timeout. Signed-off-by: Thanneeru

[PATCH v2 6/6] net: thunderx: Alloc higher order pages when pagesize is small

2016-02-11 Thread sunil . kovvuri
From: Sunil Goutham Allocate higher order pages when pagesize is small, this will reduce number of calls to page allocator and wastage of memory. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) dif

[PATCH v2 3/6] net: thunderx: Assign affinity hints to vf's interrupts

2016-02-11 Thread sunil . kovvuri
From: Sunil Goutham This affinity hint can be used by user space irqbalance tool to set preferred CPU mask for irqs registered by this VF. Irqbalance needs to be in 'exact' mode to set irq affinity same as indicated by affinity hint. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium

[PATCH v2 4/6] net: thunderx: bgx: Use standard firmware node infrastructure.

2016-02-11 Thread sunil . kovvuri
From: David Daney In the case of OF device tree, the firmware information is attached to the BGX device structure in the standard manner, so use the firmware iterators and accessors where possible. Signed-off-by: David Daney Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Robert Shearman
On 11/02/16 11:35, Brian Russell wrote: ... diff --git a/include/net/nsh.h b/include/net/nsh.h new file mode 100644 index 000..7a5fb95 --- /dev/null +++ b/include/net/nsh.h @@ -0,0 +1,158 @@ +/* + * Network Service Header (NSH) inserted onto encapsulated packets + * or frames to realize servi

[PATCH v2 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-11 Thread sunil . kovvuri
From: Robert Richter Signed-off-by: Robert Richter Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cav

[PATCH v2 2/6] net: thunderx: Use napi_schedule_irqoff()

2016-02-11 Thread sunil . kovvuri
From: Sunil Goutham napi_schedule is being called from hard irq context, hence switch to napi_schedule_irqoff which avoids unneeded call to local_irq_save and local_irq_restore. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nicvf_main.c |2 +- 1 files changed, 1 inse

[PATCH v2 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

2016-02-11 Thread sunil . kovvuri
From: Sunil Goutham This patch series contains changes - To add support for virtual function's irq affinity hint - Replace napi_schedule() with napi_schedule_irqoff() - Reduce page allocation overhead by allocating pages of higher order when pagesize is 4KB. - Add couple of stats which helps in

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Dave Taht
On Thu, Feb 11, 2016 at 7:29 AM, Grumbach, Emmanuel wrote: > > > On 02/11/2016 05:12 PM, Eric Dumazet wrote: >> On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: >> >> >>> Yeah :) codel_should_drop seemed very long indeed... I wanted to use the >>> codel_get_time and associated utils (_

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-11 Thread Doug Ledford
On 02/09/2016 03:11 PM, Rasmus Villemoes wrote: > The while loop after err_slaves should use post-decrement; otherwise > we'll fail to do the kfrees for i==0, and will run into out-of-bounds > accesses if the setup above failed already at i==0. > > The predecrement in the --port is ok, since ->vla

Re: [PATCH 2/2] net: dsa: remove phy_disconnect from error path

2016-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2016 at 11:44:49AM +0100, Sascha Hauer wrote: > The phy has not been initialized, disconnecting it in the error > path results in a NULL pointer exception. Drop the phy_disconnect > from the error path. > > Signed-off-by: Sascha Hauer Hi Sascha The fix looks correct, since the p

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Dave Taht
On Thu, Feb 11, 2016 at 7:05 AM, Grumbach, Emmanuel wrote: > fixing linux-wireless address ... > > On 02/11/2016 04:30 PM, Eric Dumazet wrote: >> On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: >>> Signed-off-by: Emmanuel Grumbach >>> --- >>> -static bool codel_should_drop(const struc

Re: [PATCH 1/2] net: dsa: mv88e6xxx: Add support for Marvell 88E6240

2016-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2016 at 11:44:48AM +0100, Sascha Hauer wrote: > The Marvell 88E6240 has been tested successfully without further > changes. Add entry to the table of supported devices. > > Signed-off-by: Sascha Hauer Reviewed-by: Andrew Lunn Thanks Andrew > --- > drivers/net/dsa/mv88

Re: [PATCH 2/2] net: dsa: remove phy_disconnect from error path

2016-02-11 Thread Vivien Didelot
Hi Sascha, Sascha Hauer writes: > The phy has not been initialized, disconnecting it in the error > path results in a NULL pointer exception. Drop the phy_disconnect > from the error path. > > Signed-off-by: Sascha Hauer > --- > net/dsa/slave.c | 1 - > 1 file changed, 1 deletion(-) > > diff -

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Grumbach, Emmanuel
On 02/11/2016 05:12 PM, Eric Dumazet wrote: > On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: > > >> Yeah :) codel_should_drop seemed very long indeed... I wanted to use the >> codel_get_time and associated utils (_before, _after) in iwlwifi. >> They're better than jiffies... So mayb

RE: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

2016-02-11 Thread Woojung.Huh
I'll submit patch for review. - Woojung > On 10/02/2016 15:18, woojung@microchip.com wrote: > >>> +static int lan88xx_config_init(struct phy_device *phydev) > >>> +{ > >>> + phydev->supported &= phydev->drv->features; > >>> + phydev->advertising &= phydev->drv->features; > >> > >> This looks

Re: [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

2016-02-11 Thread Robert Richter
On 11.02.16 09:33:41, David Miller wrote: > From: Sunil Kovvuri > Date: Thu, 11 Feb 2016 18:56:48 +0530 > > > If time permits, can you please look at this patchset. > > You were given feedback and I expect you to address that feedback > and resubmit this series. > > This is what the "Changed Re

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: > Yeah :) codel_should_drop seemed very long indeed... I wanted to use the > codel_get_time and associated utils (_before, _after) in iwlwifi. > They're better than jiffies... So maybe I can just copy that code to > iwlwifi. You certa

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Grumbach, Emmanuel
fixing linux-wireless address ... On 02/11/2016 04:30 PM, Eric Dumazet wrote: > On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: >> Signed-off-by: Emmanuel Grumbach >> --- >> -static bool codel_should_drop(const struct sk_buff *skb, >> - struct Qdisc *sch, >> -

Re: [RFC PATCH v2 00/18] CALIPSO Implementation

2016-02-11 Thread Huw Davies
On Sun, Feb 07, 2016 at 02:56:18PM -0500, Paul Moore wrote: > Thanks for fixing this patchset up and sending out a v2. I took a closer > look > and just sent out my comments, let me know if you have any questions. > > Once we get to a v3 patchset, I think it's time to reach out Oracle and try

Re: [net-next v2] bonding: use return instead of goto

2016-02-11 Thread David Miller
From: Zhang Shengju Date: Tue, 9 Feb 2016 10:37:46 + > Replace 'goto' with 'return' to remove unnecessary check at label: > err_undo_flags. > > The reason is that 'err_undo_flags' do two things for the first slave device: > 1.revert bond mac address if it is set by the slave device. > 2.rev

Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64

2016-02-11 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 10 Feb 2016 10:08:54 +0530 > 32 bit systems using 'struct timeval' will break in the year 2038, so > we replace the code appropriately. However, this driver is not broken > in 2038 since we are only using microseconds portion of the time. > > This patch replac

Re: [RFC PATCH v2 10/18] calipso: Set the calipso socket label to match the secattr.

2016-02-11 Thread Huw Davies
On Sun, Feb 07, 2016 at 02:56:08PM -0500, Paul Moore wrote: > On Friday, January 08, 2016 09:52:46 AM Huw Davies wrote: > > +/** > > + * calipso_genopt - Generate a CALIPSO option > > + * @buf: the option buffer > > + * @start: offset from which to write > > + * @buf_len: the size of opt_buf > > +

Re: [PATCH v3] openvswitch: allow management from inside user namespaces

2016-02-11 Thread David Miller
From: Tycho Andersen Date: Fri, 5 Feb 2016 09:20:52 -0700 > Operations with the GENL_ADMIN_PERM flag fail permissions checks because > this flag means we call netlink_capable, which uses the init user ns. > > Instead, let's introduce a new flag, GENL_UNS_ADMIN_PERM for operations > which should

Re: [PATCH repost net-next] ethtool: future-proof interface for speed extensions

2016-02-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 7 Feb 2016 23:27:55 +0200 > Many virtual and not quite virtual devices allow any speed to be set > through ethtool. In particular, this applies to the virtio-net devices. > Document this fact to make sure people don't assume the enum lists all > possible valu

Re: [RFC PATCH v2 08/18] ipv6: Add ipv6_renew_options_kern() that accepts a kernel mem pointer.

2016-02-11 Thread Huw Davies
On Sun, Feb 07, 2016 at 02:56:05PM -0500, Paul Moore wrote: > On Friday, January 08, 2016 09:52:44 AM Huw Davies wrote: > > The functionality is equivalent to ipv6_renew_options() except > > that the newopt pointer is in kernel, not user, memory > > > > The kernel memory implementation will be use

Re: [PATCH net-next] rds: duplicate include net/tcp.h

2016-02-11 Thread David Miller
From: Stephen Hemminger Date: Tue, 9 Feb 2016 22:04:47 -0800 > Duplicate include detected. > > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH net-next] vrf: duplicate include of rtnetlink.h

2016-02-11 Thread David Miller
From: Stephen Hemminger Date: Tue, 9 Feb 2016 22:11:27 -0800 > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH net-next] vxlan: udp_tunnel duplicate include net/udp_tunnel.h

2016-02-11 Thread David Miller
From: Stephen Hemminger Date: Tue, 9 Feb 2016 22:07:29 -0800 > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH] bonding: Return correct error code

2016-02-11 Thread David Miller
From: Amitoj Kaur Chawla Date: Sun, 7 Feb 2016 10:56:25 +0530 > The return value of kzalloc on failure of allocation of memory should > be -ENOMEM and not -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: ... > The single call site only checks that the return

Re: net: mv643xx: interface does not transmit after some time

2016-02-11 Thread Ezequiel Garcia
(let's expand the Cc a bit) On 10 February 2016 at 19:57, Andrew Lunn wrote: > On Wed, Feb 10, 2016 at 07:40:54PM +0100, Thomas Schlöter wrote: >> >> > Am 08.02.2016 um 19:49 schrieb Thomas Schlöter : >> > >> > >> >> Am 07.02.2016 um 22:07 schrieb Thomas Schlöter : >> >> >> >> Am 07.02.2016 um 21

Re: [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

2016-02-11 Thread David Miller
From: Sunil Kovvuri Date: Thu, 11 Feb 2016 18:56:48 +0530 > If time permits, can you please look at this patchset. You were given feedback and I expect you to address that feedback and resubmit this series. This is what the "Changed Requested" state in patchwork means.

Re: [net-next PATCH 00/10] Add GSO support for outer checksum w/ inner checksum offloads

2016-02-11 Thread David Miller
From: Alexander Duyck Date: Fri, 05 Feb 2016 15:27:25 -0800 > This patch series updates the existing segmentation offload code for > tunnels to make better use of existing and updated GSO checksum > computation. This is done primarily through two mechanisms. First we > maintain a separate check

Re: [patch net-next RFC 1/6] Introduce devlink infrastructure

2016-02-11 Thread Ivan Vecera
On 3.2.2016 11:47, Jiri Pirko wrote: +struct devlink_ops { + size_t priv_size; + int (*port_type_set)(struct devlink_port *devlink_port, +enum devlink_port_type port_type); +}; It does not make sense to have priv_size member here... If it is necessary it s

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: > Signed-off-by: Emmanuel Grumbach > --- > -static bool codel_should_drop(const struct sk_buff *skb, > - struct Qdisc *sch, > - struct codel_vars *vars, > - st

[PATCH 3.12 28/64] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-02-11 Thread Jiri Slaby
From: Vijay Pandurangan 3.12-stable review patch. If anyone has any objections, please let me know. === [ Upstream commit ce8c839b74e3017996fad4e1b7ba2e2625ede82f ] Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the c

[PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Emmanuel Grumbach
Signed-off-by: Emmanuel Grumbach --- include/net/codel.h | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/codel.h b/include/net/codel.h index 267e702..0775c24 100644 --- a/include/net/codel.h +++ b/include/net/codel.h @

Re: [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

2016-02-11 Thread Sunil Kovvuri
Hi David, If time permits, can you please look at this patchset. Thanks, Sunil. On Mon, Feb 8, 2016 at 5:37 PM, wrote: > From: Sunil Goutham > > This patch series contains changes > - To add support for virtual function's irq affinity hint > - Replace napi_schedule() with napi_schedule_irqoff

Re: [PATCH net-next 7/7] net/ipv4: add dst cache support for gre lwtunnels

2016-02-11 Thread Sergei Shtylyov
Hello. On 2/11/2016 1:12 PM, Paolo Abeni wrote: In case of UDP traffic with datagram length below MTU this give about 4% performance increase Gives. Signed-off-by: Paolo Abeni Suggested-and-acked-by: Hannes Frederic Sowa --- net/ipv4/ip_gre.c | 17 ++--- 1 file changed,

Re: [PATCH v4 net-next 0/8] Local Checksum Offload

2016-02-11 Thread David Miller
From: Edward Cree Date: Fri, 5 Feb 2016 20:39:34 + > Tested with VxLAN, GRE and FOU-IPIP tunnels. Not tested with GENEVE, > because iproute2 doesn't support enabling checksums on GENEVE tunnels. > Also tested VxLAN with IPv6 (as both inner and outer protocol). This gets rejects when I try

Re: [PATCH net-next v2] be2net: don't report EVB for older chipsets when SR-IOV is disabled

2016-02-11 Thread Sathya Perla
On Thu, Feb 11, 2016 at 12:42 PM, Ivan Vecera wrote: > The EVB (virtual bridge) functionality should be disabled on older BE3 > and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting > is identified by the zero value of total VFs reported by the card. > The GET_HSW_CONFIG command c

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Jiri Benc
On Thu, 11 Feb 2016 13:16:52 +0100, Jiri Benc wrote: > I don't see a better way out of this now. Fortunately, this does not > affect route based tunneling. > > Acked-by: Jiri Benc Oh, and this should go to net, not net-next. Jiri -- Jiri Benc

Re: [PATCH V2 net-next] hv_netvsc: cleanup netdev feature flags for netvsc

2016-02-11 Thread David Miller
From: Simon Xiao Date: Thu, 4 Feb 2016 15:49:34 -0800 > 1. Adding NETIF_F_TSO6 feature flag; > 2. Adding NETIF_F_HW_CSUM. NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are > being deprecated; > 3. Cleanup the coding style of flag assignment by using macro. > > Signed-off-by: Simon Xiao > Reviewed-by:

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Jiri Benc
On Thu, 11 Feb 2016 12:38:51 +0100, Paolo Abeni wrote: > We are already sending by default zero UDP checksum when tunneling over > vxlan/geneve light weight tunnel since the commit 35e2d1152b22 > ("tunnels: Allow IPv6 UDP checksums to be correctly controlled."). > > Currently, geneve/vxlan lwt pai

Re: [PATCH v2 net-next 0/2] IPv6 NFC

2016-02-11 Thread David Miller
From: Edward Cree Date: Fri, 5 Feb 2016 11:12:33 + > This series adds support for steering IPv6 flows using the ethtool NFC > interface, and implements it for sfc devices. > Tested using an in-development patch to the ethtool utility. Series applied, thanks.

Re: [PATCH for-next 0/3] Add TOS support and some cleanup

2016-02-11 Thread David Miller
From: Hariprasad Shenai Date: Fri, 5 Feb 2016 11:43:27 +0530 > This series adds TOS support for iWARP and also does some cleanup to make > code more readable. Patch series is created against infiniband tree and > includes patches on iw_cxgb4 and cxgb4 driver. > > We have included all the maint

Re: [PATCH net-next 5/7] net: add dst_cache to ovs vxlan lwtunnel

2016-02-11 Thread Jiri Benc
On Thu, 11 Feb 2016 11:12:01 +0100, Paolo Abeni wrote: > In case of UDP traffic with datagram length > below MTU this give about 2% performance increase The performance increase is not that great probably because of the addition of the pointer to ip_tunnel_info, making it even fatter than it is no

[PATCH net-next v2] be2net: don't report EVB for older chipsets when SR-IOV is disabled

2016-02-11 Thread Ivan Vecera
The EVB (virtual bridge) functionality should be disabled on older BE3 and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting is identified by the zero value of total VFs reported by the card. The GET_HSW_CONFIG command cannot be used as it is not supported by these older chipset's

Re: [PATCH net v4] r8169: Bad implementation of netif_carrier_*

2016-02-11 Thread Corcodel Marian
On Thu, 2016-02-11 at 06:12 -0500, David Miller wrote: > From: Corcodel Marian > Date: Thu, 11 Feb 2016 12:52:49 +0200 > > > On Thu, 2016-02-11 at 03:39 -0500, David Miller wrote: > >> From: Corcodel Marian > >> Date: Thu, 11 Feb 2016 08:27:43 +0200 > >> > >> > On probe stage what carrier to

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Paolo Abeni
On Thu, 2016-02-11 at 11:41 +0100, Jiri Benc wrote: > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: > > --- a/drivers/net/geneve.c > > +++ b/drivers/net/geneve.c > > @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net > > *net, const char *name, > > return

Re: [PATCH net-next] be2net: don't report EVB for older chipsets when SR-IOV is disabled

2016-02-11 Thread Ivan Vecera
On 11.2.2016 10:56, Sathya Perla wrote: On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera wrote: The EVB (virtual bridge) functionality should be disabled on older BE3 and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting is identified by the zero value of total VFs reported by the

[PATCH] pcnet_cs: add new id

2016-02-11 Thread Ken Kawasaki
add new id (CONTEC C-NET(PC)C-100TX2) Signed-off-by: Ken Kawasaki --- --- linux-4.4.1/drivers/net/ethernet/8390/pcnet_cs.c.orig 2016-02-11 19:26:02.281108472 +0900 +++ linux-4.4.1/drivers/net/ethernet/8390/pcnet_cs.c2016-02-11 19:27:21.353595301 +0900 @@ -1501,6 +1501,7 @@ static c

[PATCH] pcnet_cs: add new id

2016-02-11 Thread Ken Kawasaki
add new id (CONTEC C-NET(PC)C-100TX2) Signed-off-by: Ken Kawasaki --- --- linux-4.4.1/drivers/net/ethernet/8390/pcnet_cs.c.orig 2016-02-11 19:26:02.281108472 +0900 +++ linux-4.4.1/drivers/net/ethernet/8390/pcnet_cs.c2016-02-11 19:27:21.353595301 +0900 @@ -1501,6 +1501,7 @@ static c

Re: [PATCH net-next V2 0/8] net: fec: cleanup/fixes

2016-02-11 Thread David Miller
From: Troy Kisky Date: Fri, 5 Feb 2016 14:52:42 -0700 > > V2 is a rebase on top of johannes endian-safe patch and > is only the 1st eight patches. > The testing for this series was done on a nitrogen6x. > The base commit was > commit b45efa30a626e915192a6c548cd8642379cd47cc > Merge git://gi

Re: [PATCH net v4] r8169: Bad implementation of netif_carrier_*

2016-02-11 Thread David Miller
From: Corcodel Marian Date: Thu, 11 Feb 2016 12:52:49 +0200 > On Thu, 2016-02-11 at 03:39 -0500, David Miller wrote: >> From: Corcodel Marian >> Date: Thu, 11 Feb 2016 08:27:43 +0200 >> >> > On probe stage what carrier to stop and rest two situation >> > netif_carrier_* is slow and disturbi

  1   2   >