Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-09 Thread Tom Herbert
On Tue, Feb 9, 2016 at 5:47 PM, David Wragg wrote: > Allow the MTU of geneve devices to be set to large values, in order to > exploit underlying networks with larger frame sizes. > > GENEVE does not have a fixed encapsulation overhead (an openvswitch > rule can add variable length options), so the

[PATCH] cxgb4: Add pci device id for chelsio t540 lom adapter

2016-02-09 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index a8dda635456d..06bc2d2e7a73 100644 --- a/driver

[PATCH net-next] vrf: duplicate include of rtnetlink.h

2016-02-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- a/drivers/net/vrf.c 2015-12-10 08:57:12.573235836 -0800 +++ b/drivers/net/vrf.c 2015-12-14 19:08:59.672199087 -0800 @@ -32,7 +32,6 @@ #include #include #include -#include #include #include #include

Re: [PATCH net-next v3 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-09 Thread kbuild test robot
Hi Craig, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT-for-TCP/20160210-074230 config: i386-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386

[PATCH net-next] vxlan: udp_tunnel duplicate include net/udp_tunnel.h

2016-02-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- a/drivers/net/vxlan.c 2015-11-03 15:01:17.693751277 -0800 +++ b/drivers/net/vxlan.c 2015-12-14 19:07:35.879811786 -0800 @@ -42,7 +42,7 @@ #include #include #include -#include + #if IS_ENABLED(CONFIG_IPV6) #include #include

[PATCH net-next] rds: duplicate include net/tcp.h

2016-02-09 Thread Stephen Hemminger
Duplicate include detected. Signed-off-by: Stephen Hemminger --- a/net/rds/tcp.c 2015-12-17 17:17:15.0 -0800 +++ b/net/rds/tcp.c 2016-02-09 22:02:23.491897938 -0800 @@ -37,7 +37,6 @@ #include #include #include -#include #include "rds.h" #include "tcp.h"

Re: [PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-09 Thread Eric Dumazet
On Tue, 2016-02-09 at 17:41 -0800, Stephen Hemminger wrote: > On Tue, 9 Feb 2016 18:51:35 -0500 > Jarod Wilson wrote: > > > On Tue, Feb 09, 2016 at 11:17:57AM -0800, Stephen Hemminger wrote: > > > Support for the new rx_nohandler statistic. > > > This code is designed to handle the case where the

[PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64

2016-02-09 Thread Amitoj Kaur Chawla
32 bit systems using 'struct timeval' will break in the year 2038, so we replace the code appropriately. However, this driver is not broken in 2038 since we are only using microseconds portion of the time. This patch replaces 'struct timeval' with 'struct timespec64'. We only need to find elapsed

[PATCH net v4] r8169: Remove duplicate of RTL_FEATURE_WOL

2016-02-09 Thread Corcodel Marian
This patch remove multiple invocation of RTL_FEATURE_WOL. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c i

Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-09 Thread Diego Viola
Hi Guo, I have an x86 computer with this network card: 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260 PCI Express Fast Ethernet Controller (rev 03) Every time I initiate a suspend (systemctl suspend) the machine hangs at resume unless I unload the jme driver. Here is a Call Trace

[PATCH net-next v2] sxgbe: remove unused code

2016-02-09 Thread Jεan Sacren
From: Jean Sacren Remove the unused code of sxgbe_xpcs. Reported-by: Julia Lawall Suggested-by: David S. Miller Signed-off-by: Jean Sacren Cc: Byungho An Cc: Girish K S Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1601191918470.2531@hadrien --- v2: Rewrite the changelog per request by Shu

Bonding MAC failover behavior with VLAN interfaces

2016-02-09 Thread John Valko
Hi all, I have observed the following on CentOS 6 using the 2.6.32-573.8.1.el6.x86_64 kernel as well as Ubuntu 15.10 with 4.2.0-25-generic.. I have not yet tried with a vanilla kernel but with the large time/distro gap it didn't seem likely to be caused by distro changes. We have a networki

Re: [PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-09 Thread Stephen Hemminger
On Tue, 9 Feb 2016 18:51:35 -0500 Jarod Wilson wrote: > On Tue, Feb 09, 2016 at 11:17:57AM -0800, Stephen Hemminger wrote: > > Support for the new rx_nohandler statistic. > > This code is designed to handle the case where the kernel reported statistic > > structure is smaller than the larger stru

[PATCH] wlcore: Fix regression in wlcore_set_partition()

2016-02-09 Thread Emil Goode
The below commit introduced a regression causing the wlcore to time out and go into recovery. commit 3719c17e1816695f415dd3b4ddcb679f7dc617c8 ("wlcore/wl18xx: fw logger over sdio") Reverting the changes regarding write of the last partition size brings the module back to it's functional state. R

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-09 Thread George Spelvin
David Laight wrote: > Since adcx and adox must execute in parallel I clearly need to re-remember > how dependencies against the flags register work. I'm sure I remember > issues with 'false dependencies' against the flags. The issue is with flags register bits that are *not* modified by an instruc

[PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-09 Thread David Decotigny
From: David Decotigny History: v8 - bitmap u32 API returns number of bits copied, unit tests updated v7 - module_exit in test_bitmap v6 - fix copy_from_user in user/kernel handshake v5 note: please see v4 bullets for a question regarding bitmap.c - minor fix to make allyesconfig/allmodc

[PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c

2016-02-09 Thread David Decotigny
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/t

[PATCH net-next v8 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 6cdb4d2..ea003ec 100644 --- a/drivers/inf

[PATCH net-next v8 04/19] net: usnic: use __ethtool_get_settings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644 --

[PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-09 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes ethtool_c

[PATCH net-next v8 01/19] lib/bitmap.c: conversion routines to/from u32 array

2016-02-09 Thread David Decotigny
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- include/linux/bitmap.h | 10 ++ lib/bitmap.c | 89 +

[PATCH net-next v8 08/19] net: bonding: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 705cb01..abef2a9 100644 --- a/drivers/net/bonding/b

[PATCH net-next v8 07/19] net: usnic: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..e90dc64 1

[PATCH net-next v8 09/19] net: ipvlan: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 7a3b414..9703610 100644 --- a/drivers/net/ipvlan/ipvlan

[PATCH net-next v8 10/19] net: macvlan: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 94e6888..a54ad4c 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -940,

[PATCH net-next v8 13/19] net: rdma: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..f669751 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_add

[PATCH net-next v8 06/19] tx4939: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips/

[PATCH net-next v8 11/19] net: team: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..7f96eca7 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team

[PATCH net-next v8 17/19] net: ethtool: remove unused __ethtool_get_settings

2016-02-09 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux/ethtool.h

[PATCH net-next v8 12/19] net: fcoe: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..2d5909f

[PATCH net-next v8 14/19] net: 8021q: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index ad5e2fd..d4a6131 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -621,12 +6

[PATCH net-next v8 16/19] net: core: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index da7dbc2..b9c8b91 100644 --- a/net/cor

[PATCH net-next v8 15/19] net: bridge: use __ethtool_get_ksettings

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..cafe4e6 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10 @@ */

[PATCH net-next v8 18/19] net: mlx4: convenience predicate for debug messages

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d 100644

Re: [PATCH net-next v7 01/19] lib/bitmap.c: conversion routines to/from u32 array

2016-02-09 Thread David Decotigny
thanks. done in v8 I am sending right now. On Mon, Feb 8, 2016 at 3:36 PM, Andrew Morton wrote: > On Sun, 7 Feb 2016 17:08:45 -0800 David Decotigny wrote: > >> From: David Decotigny >> >> Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic >> way. >> >> Tested: >> unit t

[PATCH net-next v8 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2016-02-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 177 insertions(+), 169 dele

[PATCH net-next v3 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-09 Thread Craig Gallek
From: Craig Gallek This change extends the fast SO_REUSEPORT socket lookup implemented for UDP to TCP. Listener sockets with SO_REUSEPORT and the same receive address are additionally added to an array for faster random access. This means that only a single socket from the group must be found i

[PATCH net-next v3 3/7] tcp: __tcp_hdrlen() helper

2016-02-09 Thread Craig Gallek
From: Craig Gallek tcp_hdrlen is wasteful if you already have a pointer to struct tcphdr. This splits the size calculation into a helper function that can be used if a struct tcphdr is already available. Signed-off-by: Craig Gallek --- include/linux/tcp.h | 7 ++- 1 file changed, 6 inserti

[PATCH net-next v3 4/7] inet: refactor inet[6]_lookup functions to take skb

2016-02-09 Thread Craig Gallek
From: Craig Gallek This is a preliminary step to allow fast socket lookup of SO_REUSEPORT groups. Doing so with a BPF filter will require access to the skb in question. This change plumbs the skb (and offset to payload data) through the call stack to the listening socket lookup implementations

[PATCH net-next v3 0/7] Faster SO_REUSEPORT for TCP

2016-02-09 Thread Craig Gallek
From: Craig Gallek This patch series complements an earlier series (6a5ef90c58da) which added faster SO_REUSEPORT lookup for UDP sockets by extending the feature to TCP sockets. It uses the same array-based data structure which allows for socket selection after finding the first listening socket

[PATCH net-next v3 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-09 Thread Craig Gallek
From: Craig Gallek In order to support fast lookups for TCP sockets with SO_REUSEPORT, the function that adds sockets to the listening hash set needs to be able to check receive address equality. Since this equality check is different for IPv4 and IPv6, we will need two different socket hashing

[PATCH net-next v3 1/7] sock: struct proto hash function may error

2016-02-09 Thread Craig Gallek
From: Craig Gallek In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at a

[PATCH net-next v3 5/7] soreuseport: Prep for fast reuseport TCP socket selection

2016-02-09 Thread Craig Gallek
From: Craig Gallek Both of the lines in this patch probably should have been included in the initial implementation of this code for generic socket support, but weren't technically necessary since only UDP sockets were supported. First, the sk_reuseport_cb points to a structure which assumes eac

[PATCH net-next v3 7/7] soreuseport: BPF selection functional test for TCP

2016-02-09 Thread Craig Gallek
From: Craig Gallek Unfortunately the existing test relied on packet payload in order to map incoming packets to sockets. In order to get this to work with TCP, TCP_FASTOPEN needed to be used. Since the fast open path is slightly different than the standard TCP path, I created a second test whic

Re: [PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-09 Thread Craig Gallek
On Tue, Feb 9, 2016 at 6:58 PM, kbuild test robot wrote: > Hi Craig, > > [auto build test WARNING on net-next/master] v3 will be the charm :\

[PATCH net v2 1/3] vxlan: Relax the MTU constraints

2016-02-09 Thread David Wragg
Allow the MTU of vxlan devices without an underlying device to be set to larger values (up to a maximum based on IP packet limits and vxlan overhead). Previously, their MTUs could not be set to higher than the conventional ethernet value of 1500. This is a very arbitrary value in the context of v

[PATCH net v3 2/3] geneve: Relax MTU constraints

2016-02-09 Thread David Wragg
Allow the MTU of geneve devices to be set to large values, in order to exploit underlying networks with larger frame sizes. GENEVE does not have a fixed encapsulation overhead (an openvswitch rule can add variable length options), so there is no relevant maximum MTU to enforce. A maximum of IP_MA

[PATCH net v3 0/3] Set a large MTU on ovs-created tunnel devices

2016-02-09 Thread David Wragg
Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could transmit vxlan packets of any size, constrained only by the ability to send out the resulting packets. 4.3 introduced netdevs corresponding to tunnel vports. These netdevs have an MTU, which limits the size of a packet that can

[PATCH net v3 1/3] vxlan: Relax MTU constraints

2016-02-09 Thread David Wragg
Allow the MTU of vxlan devices without an underlying device to be set to larger values (up to a maximum based on IP packet limits and vxlan overhead). Previously, their MTUs could not be set to higher than the conventional ethernet value of 1500. This is a very arbitrary value in the context of v

[PATCH net v3 3/3] vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-02-09 Thread David Wragg
Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could transmit vxlan packets of any size, constrained only by the ability to send out the resulting packets. 4.3 introduced netdevs corresponding to tunnel vports. These netdevs have an MTU, which limits the size of a packet that can

Re: [PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-09 Thread kbuild test robot
Hi Craig, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT-for-TCP/20160210-074230 config: cris-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git

Re: [PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-09 Thread Jarod Wilson
On Tue, Feb 09, 2016 at 11:17:57AM -0800, Stephen Hemminger wrote: > Support for the new rx_nohandler statistic. > This code is designed to handle the case where the kernel reported statistic > structure is smaller than the larger structure in later releases (and vice > versa). This seems to work

Re: [PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-09 Thread Craig Gallek
On Thu, Feb 4, 2016 at 10:35 AM, Craig Gallek wrote: > From: Craig Gallek > > In order to support fast reuseport lookups in TCP, the hash function > defined in struct proto must be capable of returning an error code. > This patch changes the function signature of all related hash functions > to r

[PATCH net-next 4/7] inet: refactor inet[6]_lookup functions to take skb

2016-02-09 Thread Craig Gallek
From: Craig Gallek This is a preliminary step to allow fast socket lookup of SO_REUSEPORT groups. Doing so with a BPF filter will require access to the skb in question. This change plumbs the skb (and offset to payload data) through the call stack to the listening socket lookup implementations

[PATCH net-next 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-09 Thread Craig Gallek
From: Craig Gallek In order to support fast lookups for TCP sockets with SO_REUSEPORT, the function that adds sockets to the listening hash set needs to be able to check receive address equality. Since this equality check is different for IPv4 and IPv6, we will need two different socket hashing

[PATCH net-next 5/7] soreuseport: Prep for fast reuseport TCP socket selection

2016-02-09 Thread Craig Gallek
From: Craig Gallek Both of the lines in this patch probably should have been included in the initial implementation of this code for generic socket support, but weren't technically necessary since only UDP sockets were supported. First, the sk_reuseport_cb points to a structure which assumes eac

[PATCH net-next 0/7] Faster SO_REUSEPORT for TCP

2016-02-09 Thread Craig Gallek
From: Craig Gallek This patch series complements an earlier series (6a5ef90c58da) which added faster SO_REUSEPORT lookup for UDP sockets by extending the feature to TCP sockets. It uses the same array-based data structure which allows for socket selection after finding the first listening socket

[PATCH net-next 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-09 Thread Craig Gallek
From: Craig Gallek This change extends the fast SO_REUSEPORT socket lookup implemented for UDP to TCP. Listener sockets with SO_REUSEPORT and the same receive address are additionally added to an array for faster random access. This means that only a single socket from the group must be found i

[PATCH net-next 3/7] tcp: __tcp_hdrlen() helper

2016-02-09 Thread Craig Gallek
From: Craig Gallek tcp_hdrlen is wasteful if you already have a pointer to struct tcphdr. This splits the size calculation into a helper function that can be used if a struct tcphdr is already available. Signed-off-by: Craig Gallek --- include/linux/tcp.h | 7 ++- 1 file changed, 6 inserti

[PATCH net-next 7/7] soreuseport: BPF selection functional test for TCP

2016-02-09 Thread Craig Gallek
From: Craig Gallek Unfortunately the existing test relied on packet payload in order to map incoming packets to sockets. In order to get this to work with TCP, TCP_FASTOPEN needed to be used. Since the fast open path is slightly different than the standard TCP path, I created a second test whic

[PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-09 Thread Craig Gallek
From: Craig Gallek In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at a

[PATCH v2 2/2] sh_eth: factor out register bit twiddling code

2016-02-09 Thread Sergei Shtylyov
The driver has often repeated pattern of reading a register, AND'ing and/or OR'ing some bits and writing the value back. Factor the pattern out into sh_eth_modify() -- this saves 84 bytes of code with ARM gcc 4.7.3. While at it, update Cogent Embedded's copyright. Signed-off-by: Sergei Shty

[PATCH v2 1/2] ravb: factor out register bit twiddling code

2016-02-09 Thread Sergei Shtylyov
The driver has often repeated pattern of reading a register, AND'ing and/or OR'ing some bits and writing the value back. Factor the pattern out into ravb_modify() -- this saves 260 bytes of code with ARM gcc 4.7.3. While at it, update Cogent Embedded's copyrights. Signed-off-by: Sergei Shtyl

[PATCH v2 0/2] Factor out register bit twiddling in the Renesas Ethernet drivers

2016-02-09 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net-next.git' repo. We factor out the often repeated pattern of reading a register, AND'ing and/or OR'ing some bits, and then writing the value back. [1/2] ravb: factor out register bit twiddling code [2/2] sh_eth: factor out register bit twidd

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-09 Thread Fabio Estevam
Hi Bernhard, On Tue, Feb 9, 2016 at 6:01 PM, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle Looks good: Reviewed-by: Fabio Estevam

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-09 Thread David Miller
From: Shannon Nelson Date: Tue, 9 Feb 2016 09:42:45 -0800 > It seem to me this should be using eth_platform_get_mac_address(), a > slightly more generic method to do this. See the i40e driver for an > example, commit d9a84324e6 I believe. +1

Re: Pushing AF_RXRPC rewrite patches to net/next

2016-02-09 Thread David Miller
From: David Howells Date: Tue, 09 Feb 2016 16:31:01 + > Are you okay with me sending some of them your way now so that you don't get a > host all in one go, or would you prefer the mass invasion approach? Please send them in reasonable chunks, thanks.

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-09 Thread Julian Calaby
Hi All, On Wed, Feb 10, 2016 at 8:36 AM, João Paulo Rechi Vita wrote: > Provide an interface for the airplane-mode indicator be controlled from > userspace. User has to first acquire the control through > RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time > it wants to be in

[PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-09 Thread João Paulo Rechi Vita
Provide an interface for the airplane-mode indicator be controlled from userspace. User has to first acquire the control through RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time it wants to be in control of the indicator. Closing the fd or using RFKILL_OP_AIRPLANE_MODE_RELEAS

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-09 Thread João Paulo Rechi Vita
On 8 February 2016 at 17:53, Julian Calaby wrote: >> + if (ev.op == RFKILL_OP_AIRPLANE_MODE_RELEASE) { >> + if (rfkill_apm_owned && !data->is_apm_owner) { > > Are you sure this is correct? > > In the case that airplane mode isn't owned, the > rfkill_apm_led_trigger_event() cal

[PATCH net-next] Add LAN9352 Ethernet Driver

2016-02-09 Thread Bryan.Whitehead
This is the initial submission of an ethernet driver for the Microchip LAN9352. The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with 16-Bit Non-PCI CPU Interface. While the LAN9352 is a Managed Ethernet Switch, this driver only supports a simple ethernet controller interface. Signed-off

Mellanox ConnectX3 Pro and kernel 4.4 low throughput bug

2016-02-09 Thread John
I'm running into a bug with kernel 4.4.0 where a VM-VM test between two different baremetal hosts (HP Proliant dl360gen9s) has receive-side throughput that's about 25% lower than expected with a Mellanox ConnectX3-pro NIC. The VMs are connected over a VXLAN tunnel that I used OpenvSwitch 2.4

[PATCH 0/5] pre-decrement in error paths considered harmful

2016-02-09 Thread Rasmus Villemoes
There are a few instances of for (i = 0; i < FOO; ++i) { ret = do_stuff(i) if (ret) goto err; } ... err: while (--i) undo_stuff(i); At best, this fails to undo_stuff for i==0, but if i==0 was the case that failed, we'll end up with an "infinite" loop in the error path

[PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-09 Thread Rasmus Villemoes
The while loop after err_slaves should use post-decrement; otherwise we'll fail to do the kfrees for i==0, and will run into out-of-bounds accesses if the setup above failed already at i==0. The predecrement in the --port is ok, since ->vlan_filter is (bizarrely) 1-indexed. But I'm changing 'if' t

[PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe()

2016-02-09 Thread Rasmus Villemoes
We need to use post-decrement to ensure that irq_dispose_mapping is also called on priv->rxq[0]->irq_no; moreover, if one of the above for loops failed already at i==0 (so we reach one of these labels with that value of i), we'll enter an essentially infinite loop of out-of-bounds accesses. Signed

[PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-09 Thread Bernhard Walle
We need that for a custom hardware that needs the reverse reset sequence. Signed-off-by: Bernhard Walle --- Changes compared to v1: - Add documentation to 'phy-reset-gpios' that flags are ignored as suggested by Andrew Lunn. Documentation/devicetree/bindings/net/fsl-fec.txt | 7 ++- dri

[PATCH v3 5/6] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-09 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/ph

[PATCH v3 2/6] net: phy: spi_ks8995: verify chip and determine revision

2016-02-09 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed, 80 insertions(+), 38 deletions(-) diff --git a/

[PATCH v3 3/6] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-09 Thread Helmut Buchsbaum
When using device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allows to power down the switch when it is not used any more. The patch introduces a new optional property "reset-gpios" denoting an appropriate GPIO handle, e.g.: reset-gpios = <&gpio0

[PATCH v3 4/6] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-09 Thread Helmut Buchsbaum
Prepare creating SPI reads and writes for other switch families. The KS8995 family uses the straight forward <8bit CMD><8bit ADDR> sequence. To be able to support KSZ8795 family, which uses <3bit CMD><12bit ADDR><1 bit TR> make the SPI command creation chip variant dependent. Signe

[PATCH v3 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-09 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt b

[PATCH v3 0/6] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-09 Thread Helmut Buchsbaum
This patch series refactors the spi-ks8995 driver to finally add support for the MICREL KSZ8795CLX. Additionally support for controlling a GPIO line for resetting the switch is added. Helmut Changes since v2: - use GPIO_ACTIVE_LOW according to Andrew's remark. - use ePAPR compliant node name in

[PATCH v3 1/6] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-09 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/sp

Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-09 Thread Arnd Bergmann
On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote: > > The descriptors are usable by different drivers, one driver may use it as > buf ptr/ len, other for something else. So they should remain as generic > and it is up to individual drivers to use it in whatever way it requires.

[PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-09 Thread Stephen Hemminger
Support for the new rx_nohandler statistic. This code is designed to handle the case where the kernel reported statistic structure is smaller than the larger structure in later releases (and vice versa). Signed-off-by: Stephen Hemminger --- ip/ipaddress.c | 35 ++

Re: [PATCH iproute2 2/2] tipc: add peer remove functionality

2016-02-09 Thread Stephen Hemminger
I ended up reverting this patch from iproute2 because the code in kernel was not accepted upstream. After it is upstream in kernel please resubmit

[PATCH] dmascc: Return correct error codes

2016-02-09 Thread Amitoj Kaur Chawla
This change has been made with the goal that kernel functions should return something more descriptive than -1 on failure. A variable `err` has been introduced for storing error codes. The return value of kzalloc on failure should return a -1 and not a -ENOMEM. This was found using Coccinelle. A

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-09 Thread David Wragg
Sergei Shtylyov writes: >The networking code formats comments: > > /* Like > * this. > */ Thanks. And I noticed another silly mistake. Will respin. David

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-09 Thread Sergei Shtylyov
On 02/09/2016 07:47 PM, David Wragg wrote: Allow the MTU of geneve devices to be set to large values, in order to exploit underlying networks with larger frame sizes. GENEVE does not have a fixed encapsulation overhead (an openvswitch rule can add variable length options), so there is no releva

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-09 Thread Shannon Nelson
It seem to me this should be using eth_platform_get_mac_address(), a slightly more generic method to do this. See the i40e driver for an example, commit d9a84324e6 I believe. sln On Tue, Feb 9, 2016 at 3:59 AM, Andrew Lunn wrote: >> > + dn = of_find_compatible_node(NULL, NULL, "intel,i211

Re: [PATCH iproute2 v2 01/21] iplink: bridge: export bridge_id and designated_root

2016-02-09 Thread Stephen Hemminger
On Tue, 9 Feb 2016 00:14:19 +0100 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Netlink returns the bridge_id and designated_root, we just need to > make them visible. > > Signed-off-by: Nikolay Aleksandrov Series applied.

Re: [PATCH iproute2] iplink: bond_slave: fix ad_actor/partner_oper_port_state output

2016-02-09 Thread Stephen Hemminger
On Mon, 8 Feb 2016 17:13:58 +0100 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > It seems that I've made a mistake when I exported these, instead of a > space in the end I've put a newline character which is wrong and breaks > the single line output. > > Fixes: 7d6bc3b87abad ("bon

Re: [PATCH iproute2] ip route: add mpls multipath support

2016-02-09 Thread Stephen Hemminger
On Sun, 7 Feb 2016 16:28:16 -0800 Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds support to add mpls multipath > routes. > > example: > ip -f mpls route add 100 \ > nexthop as 200 via inet 10.1.1.2 dev swp1 \ > nexthop as 700 via inet 10.1.1.6 dev swp2 > > Signed-of

RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-09 Thread Karicheri, Muralidharan
>-Original Message- >From: David Laight [mailto:david.lai...@aculab.com] >Sent: Tuesday, February 09, 2016 11:38 AM >To: Karicheri, Muralidharan; Strashko, Grygorii; netdev@vger.kernel.org; David >S . Miller; >Arnd Bergmann >Cc: Cooper Jr., Franklin; Nori, Sekhar; linux-ker...@vger.kernel.

RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-09 Thread David Laight
From: Karicheri, Muralidharan > Sent: 09 February 2016 16:19 > >... > >> >In reality the 'pad' fields ought to be renamed - since they aren't pads. > >> >Perhaps they should be a union? > > > >> No. At the end of the descriptor, host software can add scratchpad > >> which is not modified by the har

[PATCH net v2 1/3] vxlan: Relax the MTU constraints

2016-02-09 Thread David Wragg
Allow the MTU of vxlan devices without an underlying device to be set to larger values (up to a maximum based on IP packet limits and vxlan overhead). Previously, their MTUs could not be set to higher than the conventional ethernet value of 1500. This is a very arbitrary value in the context of v

[PATCH net v2 3/3] vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-02-09 Thread David Wragg
Prior to 4.3, tunnel vports (vxlan, gre and geneve) could transmit vxlan packets of any size, constrained only by the ability to send out the resulting packets. 4.3 introduced netdevs corresponding to tunnel vports. These netdevs have an MTU, which limits the size of a packet that can be successf

[PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-09 Thread David Wragg
Allow the MTU of geneve devices to be set to large values, in order to exploit underlying networks with larger frame sizes. GENEVE does not have a fixed encapsulation overhead (an openvswitch rule can add variable length options), so there is no relevant maximum MTU to enforce. A maximum of IP_MA

[PATCH net v2 0/3] Set a large MTU on ovs-created tunnel devices

2016-02-09 Thread David Wragg
Prior to 4.3, tunnel vports (vxlan, gre and geneve) could transmit vxlan packets of any size, constrained only by the ability to send out the resulting packets. 4.3 introduced netdevs corresponding to tunnel vports. These netdevs have an MTU, which limits the size of a packet that can be successf

Pushing AF_RXRPC rewrite patches to net/next

2016-02-09 Thread David Howells
Hi Dave, I've split 23 patches out of my AF_RXRPC rewrite so far. If you look here: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-experimental the penultimate patch is the remnant rewrite, the 23 patches below that are ones I've split out of it. Are yo

  1   2   >