Connection remains in the ESTABLISHED state when the virtual IP is down.

2016-02-03 Thread Arkadiusz Bubała
Hello, I encountered following issue: when I connect with NFS server through virtual IP then I remove this IP netstat still shows that connection is ESTABLISHED. When I put down whole interface all ESTABLISHED connections disappear. The kernel version is 3.10.92. How to reproduce. create v

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

2016-02-03 Thread Amir Vadai"
On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: > This adds initial support for offloading the u32 tc classifier. This > initial implementation only implements a few base matches and actions > to illustrate the use of the infrastructure patches. > > However it is an interesting sub

Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

2016-02-03 Thread Josh Boyer
On Thu, Jan 7, 2016 at 2:15 PM, Mikko Rapeli wrote: > On Thu, Jan 07, 2016 at 10:30:40AM -0800, Stephen Hemminger wrote: >> On Thu, 7 Jan 2016 07:29:50 + >> Mikko Rapeli wrote: >> >> > On Wed, Jan 06, 2016 at 09:20:07AM -0800, Stephen Hemminger wrote: >> > > This commit breaks compilation of

[PATCH RFC 03/13] esp: Add a software GRO codepath

2016-02-03 Thread Steffen Klassert
This patch adds GRO callbacks for ESP on ipv4 and ipv6. In case the GRO layer detects an ESP packet, the esp4_gro_receive() function calls the xfrm input layer which decapsulates the packet and reinject it into layer 2 by calling netif_rx(). We use on bit of the sk_buff to flag xfrm_gro. If this b

[PATCH RFC 04/13] xfrm: Move device notifications to a sepatate file

2016-02-03 Thread Steffen Klassert
This is needed for the upcomming IPsec device offloading. Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 1 + net/xfrm/Makefile | 2 +- net/xfrm/xfrm_device.c | 43 +++ net/xfrm/xfrm_policy.c | 17 + 4 files changed, 46

[PATCH RFC 10/13] xfrm: Add basic infrastructure for IPsec device offloading

2016-02-03 Thread Steffen Klassert
This patch fills the IPsec device offloading callbacks for software GSO. We handle async crypto with the xfrm_dev_resume() function. This tries to do a direct call to dev_hard_start_xmit(). If the netdevice is busy, we defere the transmit to the NET_TX_SOFTIRQ softirq. Signed-off-by: Steffen Klas

[PATCH RFC 08/13] esp4: Add a software GSO codepath.

2016-02-03 Thread Steffen Klassert
This patch adds an esp4_gso_segment() callback and registers functions for the new ESP encapsulation and crypto callbacks. The work to get transport mode ready was done by Sowmini Varadhan Signed-off-by: Steffen Klassert --- include/linux/skbuff.h | 3 +- net/ipv4/af_inet.c | 1 + net/

[PATCH RFC 13/13] net: Allow IPsec GSO for locally sent traffic.

2016-02-03 Thread Steffen Klassert
This patch finally allows locally sent IPsec packets to use the GSO codepath. Signed-off-by: Steffen Klassert --- net/core/sock.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index 6c1c8bc..8fca8b0 100644 --- a/net/core/sock.c +

[PATCH RFC 05/13] xfrm: Add callbacks for IPsec GSO offloading

2016-02-03 Thread Steffen Klassert
This patch prepares struct xfrm_type for IPsec GSO offloading by adding a encap() callback for encapsulation and a output_tail() callback to do the crypto operations after the return from the GSO layer. We need the output_tail() callback to handle async crypto operations. Signed-off-by: Steffen Kl

[PATCH RFC 11/13] net: Enable IPsec software GSO.

2016-02-03 Thread Steffen Klassert
This patch hooks the IPsec GSO code into the generic network stack. Signed-off-by: Steffen Klassert --- include/linux/netdevice.h | 2 +- include/net/xfrm.h| 1 + net/core/dev.c| 40 +++- net/ipv4/ip_output.c | 8 +--- net/ipv4/

[PATCH RFC] IPsec performance improvements (discussion base for the IPsec performance BoF)

2016-02-03 Thread Steffen Klassert
This patchset adds some performance improvements for IPsec. It is a early stage RFC version and still contains bugs. I post this now just to have a discussion base for the IPsec performance BoF at the netdev conference next week. The patchset adds a GRO/GSO codepath for IPsec and tries to avoid th

[PATCH RFC 09/13] esp: Avoid skb_cow_data whenever possible

2016-02-03 Thread Steffen Klassert
If we are allowed to write the buffer and have enough free space on the lineaer part of the buffer, we add the IPsec tailbit to it. If there is no space on the linare part but we are allowed to write, we add a page fragment with the tailbits to the buffer. With this, we can avoid a linearization o

[PATCH RFC 02/13] gro: Partly revert "net: gro: allow to build full sized skb"

2016-02-03 Thread Steffen Klassert
This partly reverts the below mentioned patch because on forwarding, such skbs can't be offloaded to a NIC. This is just a hack to get IPsec GRO for forwarding to work. A real fix may consider the proposed solutions in the original patch, see below. ---

[PATCH RFC 07/13] net: Add ESP offload features

2016-02-03 Thread Steffen Klassert
This patch adds netdev features to configure IPsec offloads. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 6 +- include/linux/netdevice.h | 1 + include/linux/skbuff.h | 2 ++ net/core/ethtool.c | 2 ++ 4 files changed, 10 insertions(+), 1

[PATCH RFC 06/13] net: Add xfrm offload callbacks to struct net_device

2016-02-03 Thread Steffen Klassert
This patch adds the callbacks we need for IPsec GSO and maybe also for IPsec hardware offload. Signed-off-by: Steffen Klassert --- include/linux/netdevice.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 6fd1f1d..6936e96f

[PATCH RFC 01/13] net: allow to leave the buffer fragmented in skb_cow_data()

2016-02-03 Thread Steffen Klassert
From: Mathias Krause Do not linearize the buffer per se but only if we're expected to expand the tail. All callers can handle fragmented buffers and even expect them! Not linearizing the buffer leads to a small performance improvement for the IPsec receive path in case the network driver passed

[PATCH RFC 12/13] crypto: Make the page handling of hash walk compatible to networking.

2016-02-03 Thread Steffen Klassert
The network layer tries to allocate high order pages for skb_buff fragments, this leads to problems if we pass such a buffer to crypto because crypto assumes to have always order null pages in the scatterlists. This was not a problem so far, bacause the network stack linearized all buffers before

Re: bonding reports interface up with 0 Mbps

2016-02-03 Thread zhuyj
On 02/04/2016 01:57 PM, Jay Vosburgh wrote: Tantilov, Emil S wrote: We are seeing an occasional issue where the bonding driver may report interface up with 0 Mbps: bond0: link status definitely up for interface eth0, 0 Mbps full duplex So far in all the failed traces I have collected this ha

[PATCH net v4] r8169: Prevent nic to start xmit without default priority.

2016-02-03 Thread Corcodel Marian
This patch set default priority before xmit operations and, also when nic running on worst speed (500Mbs-1Mbs), this patch increase speed to 8-10Mbs. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

Re: bonding reports interface up with 0 Mbps

2016-02-03 Thread Jay Vosburgh
Tantilov, Emil S wrote: >We are seeing an occasional issue where the bonding driver may report >interface up with 0 Mbps: >bond0: link status definitely up for interface eth0, 0 Mbps full duplex > >So far in all the failed traces I have collected this happens on >NETDEV_CHANGELOWERSTATE event:

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Eric Dumazet
On Wed, 2016-02-03 at 22:02 +0100, Jason A. Donenfeld wrote: > > > I don't know about the particular problems with > > tunnels but the scripts can use the route metric to order > > the routes in a table. > > This unfortunately does not cut it with tunnels. ip rule show ip route show ta

Re: bonding reports interface up with 0 Mbps

2016-02-03 Thread zhuyj
Hi, Emil Thanks for your hard work. With kernel 3.14, NETDEV_CHANGELOWERSTATE is not introduced. my user still confronted "bond_mii_monitor: bond0: link status definitely up for interface eth1, 0 Mbps full duplex". How to explain it? Would you like to make tests with kernel 3.14? Thanks a

Re: Fw: [Bug 111771] New: deadlock in ppp/l2tp

2016-02-03 Thread Sorin Manolache
On 2016-02-03 18:14, Guillaume Nault wrote: On Wed, Feb 03, 2016 at 11:04:31AM +1100, Stephen Hemminger wrote: Please excuse URL mangling, my bugzilla address appears to route through stupid corporate firewall. Sorin, it seems like one of your L2TP tunnels is routed to one of its upper PPP de

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-03 Thread Salam Noureddine
On Wed, Feb 3, 2016 at 12:08 AM, Julian Anastasov wrote: > Aha, I see, it is after NETDEV_UNREGISTER but may be > the above loop should be changed to two loops so that > NETDEV_UNREGISTER_BATCH is called exactly after all > NETDEV_UNREGISTER and before all dev_*_flush and > ndo_uninit ca

Re: [PATCH 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-02-03 Thread kbuild test robot
Hi Alexandre, [auto build test WARNING on net/master] [also build test WARNING on v4.5-rc2 next-20160203] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Alexandre-TORGUE/Add-Ethernet-support

[ANNOUNCE] NetDev 1.1 schedule is out

2016-02-03 Thread Pablo Neira Ayuso
Hi! We're happy to release the NetDev 1.1 schedule today: http://www.netdevconf.org/1.1/schedule.html We have three days ahead of interesting talks, tutorials, BoFs and keynotes! And... you still have a chance to join us: https://www.netdevconf.org/1.1/registration.html

[PATCH 3.16.y-ckt 002/180] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-02-03 Thread Luis Henriques
3.16.7-ckt24 -stable review patch. If anyone has any objections, please let me know. ---8< From: Vijay Pandurangan commit ce8c839b74e3017996fad4e1b7ba2e2625ede82f upstream. Packets that arrive from real hardware devices have ip_summ

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-03 Thread Stephen Hemminger
On Tue, 2 Feb 2016 13:51:20 +0100 Nikolay Aleksandrov wrote: > +static bool virtnet_validate_speed(u32 speed) > +{ > + switch (speed) { > + case SPEED_10: > + case SPEED_100: > + case SPEED_1000: > + case SPEED_2500: > + case SPEED_5000: > + case SPEED_1: > +

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-03 Thread Rick Jones
On 02/03/2016 03:32 PM, Stephen Hemminger wrote: But why check for valid value at all. At some point in the future, there will be yet another speed adopted by some standard body and the switch statement would need another value. Why not accept any value? This is a virtual device. And even fo

Re: [PATCH] Netlink messages for multicast HW addr programming

2016-02-03 Thread Stephen Hemminger
On Wed, 3 Feb 2016 06:14:41 -0800 Patrick Ruddy wrote: > One more Q on this. I can use IFA_ADDRESS for unicast addresses and > IFA_MULTICAST for multicast addresses but are these distinctions > actually required since the multicast nature of an address is clear from > the address itself - at leas

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-03 Thread Stephen Hemminger
On Wed, 3 Feb 2016 04:04:36 +0100 Nikolay Aleksandrov wrote: > > +static inline int ethtool_validate_speed(__u32 speed) > +{ No need for inline. But why check for valid value at all. At some point in the future, there will be yet another speed adopted by some standard body and the switch st

bonding reports interface up with 0 Mbps

2016-02-03 Thread Tantilov, Emil S
We are seeing an occasional issue where the bonding driver may report interface up with 0 Mbps: bond0: link status definitely up for interface eth0, 0 Mbps full duplex So far in all the failed traces I have collected this happens on NETDEV_CHANGELOWERSTATE event: <...>-20533 [000] 81811.04

[PATCH net-next v2 0/4] packet: tpacket gso and csum offload

2016-02-03 Thread Willem de Bruijn
From: Willem de Bruijn Extend PACKET_VNET_HDR socket option support to packet sockets with memory mapped rings. Patches 2 and 4 add support to tpacket_rcv and tpacket_snd. Patch 1 prepares for this by moving the relevant virtio_net_hdr logic out of packet_snd and packet_rcv into helper function

[PATCH net-next v2 1/4] packet: move vnet_hdr code to helper functions

2016-02-03 Thread Willem de Bruijn
From: Willem de Bruijn packet_snd and packet_rcv support virtio net headers for GSO. Move this logic into helper functions to be able to reuse it in tpacket_snd and tpacket_rcv. This is a straighforward code move with one exception. Instead of creating and passing a separate gso_type variable, r

[PATCH net-next v2 2/4] packet: vnet_hdr support for tpacket_rcv

2016-02-03 Thread Willem de Bruijn
From: Willem de Bruijn Support socket option PACKET_VNET_HDR together with PACKET_RX_RING. When enabled, a struct virtio_net_hdr will precede the data in the packet ring slots. Verified with test program at github.com/wdebruij/kerneltools/blob/master/tests/psock_rxring_vnet.c pkt: 1454269209.

[PATCH net-next v2 4/4] packet: tpacket_snd gso and checksum offload

2016-02-03 Thread Willem de Bruijn
From: Willem de Bruijn Support socket option PACKET_VNET_HDR together with PACKET_TX_RING. When enabled, a struct virtio_net_hdr is expected to precede the data in the ring. The vnet option must be set before the ring is created. The implementation reuses the existing skb_copy_bits code that is

[PATCH net-next v2 3/4] packet: parse tpacket header before skb alloc

2016-02-03 Thread Willem de Bruijn
From: Willem de Bruijn GSO packet headers must be stored in the linear skb segment. Move tpacket header parsing before sock_alloc_send_skb. The GSO follow-on patch will later increase the skb linear argument to sock_alloc_send_skb if needed for large packets. The header parsing code does not req

Re: [PATCH net-next] sxgbe: remove unused code

2016-02-03 Thread Shuah Khan
On 02/03/2016 01:11 PM, Jεan Sacren wrote: > From: Jean Sacren > > With the introduction of this commit 1edb9ca69e8a > ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver"), > the following interface was added: > > int sxgbe_xpcs_init(struct net_device *ndev); > int sx

[PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-03 Thread Robert Jarzmik
The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ethernet: insufficient resources [1.068439] dm9000 800.ethernet: not found (-2). [1.073451] dm9000: probe of 800.ethernet failed with e

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread Aaro Koskinen
Hi, On Wed, Feb 03, 2016 at 12:14:05PM -0800, David Daney wrote: > On 02/03/2016 12:08 PM, Andrew Lunn wrote: > >On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > >>Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > >>compatibilities.") missed one compatible string used in

[PATCH net 3/4] net: phy: bcm7xxx: Fix bcm7xxx_config_init() check

2016-02-03 Thread Florian Fainelli
Since we were wrongly advertising gigabit features for these 10/100 only Ethernet PHYs, bcm7xxx_config_init() which is supposed to apply workaround would have not run since the check would be true, now that we have fixed the PHY features, remove that check since it has no reasoning to be there anym

[PATCH net 4/4] net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming consistent

2016-02-03 Thread Florian Fainelli
The driver is BCM7xxx, we were missing an additional X in the constant naming, fix that to be consistent. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c in

[PATCH net 1/4] net: phy: bcm7xxx: Fix shadow mode 2 disabling

2016-02-03 Thread Florian Fainelli
The clear and set masks in the call to phy_set_clr_bits() called from bcm7xxx_config_init() are inverted. We need to fix this by swapping the two arguments, that is, set 0 bits, but clear the shade mode 2 enable bit. Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver") Signe

[PATCH net 2/4] net: phy: bcm7xxx: Fix 40nm EPHY features

2016-02-03 Thread Florian Fainelli
The PHY entries for BCM7425/29/35 declare the 40nm Ethernet PHY as being 10/100/1000 capable, while this is just a 10/100 capable PHY device, fix that. Fixes: d068b02cfdfc2 ("net: phy: add BCM7425 and BCM7429 PHYs") Fixes: 9458ceab4917 ("net: phy: bcm7xxx: Add entry for BCM7435") Signed-off-by: Fl

[PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes

2016-02-03 Thread Florian Fainelli
Hi David, Here is a collection of fixes for the 40nm Ethernet PHY supported by the 7xxx PHY driver, please also queue these fixes for stable. Let me know if you think patch 4 is too much of a cleanup to be taken as a fix. Thanks! Florian Fainelli (4): net: phy: bcm7xxx: Fix shadow mode 2 disa

Re: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread Alexander Duyck
On Wed, Feb 3, 2016 at 11:23 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 10:24 -0800, Alexander Duyck wrote: > >> If this is only meant to be a performance modification and is only >> really targeted at TCP TSO/GRO then all I ask is that we use a name >> like tcp_max_gso_frags and relocate the

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Jason A. Donenfeld
Hi Julian, Thanks a lot for your review. Much appreciated. On Wed, Feb 3, 2016 at 9:42 PM, Julian Anastasov wrote: > If you check every flowi4_oif user you will notice > that some places can not fulfil this requirement: > - fib_select_path -> fib_select_multipath > Other places l

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread Aaro Koskinen
Hi, On Wed, Feb 03, 2016 at 09:08:57PM +0100, Andrew Lunn wrote: > On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > > Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > > compatibilities.") missed one compatible string used in in-tree DTBs: > > in OCTEON, for selected boar

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread David Daney
On 02/03/2016 12:08 PM, Andrew Lunn wrote: On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.") missed one compatible string used in in-tree DTBs: in OCTEON, for selected boards, the kernel DTB pruning code wi

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Julian Anastasov
Hello, On Wed, 3 Feb 2016, Jason A. Donenfeld wrote: > This patch simply adds support for specifying a "not_oif" device in > flowi4 and flowi6 lookups, that will find a matching route that _isn't_ > via the specified device. If you check every flowi4_oif user you will notice tha

Re: Keystone 2 boards boot failure

2016-02-03 Thread Arnd Bergmann
On Wednesday 03 February 2016 11:41:40 Murali Karicheri wrote: > > > > This looks wrong: I was getting the build warnings originally > > because of 64-bit dma_addr_t, and that should be the only way that > > this driver can operate, because in some configurations on keystone > > there is no memory

Re: Keystone 2 boards boot failure

2016-02-03 Thread Arnd Bergmann
On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: > On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: > >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: > >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: > >

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread Andrew Lunn
> The compatibility strings may be present in deployed firmware, they > cannot be removed. For many OCTEON boards, the device tree is a > firmware-kernel ABI, it is not practical to unilaterally decide to > change the bindings on the kernel side as you don't control the > firmware. Hi David We a

Re: [PATCH net v2] bonding: Fix ARP monitor validation

2016-02-03 Thread Jay Vosburgh
Jarod Wilson wrote: [...] >This sounds suspiciously like the same problem Uwe was encountering[*] and >attempting to solve. Uwe, can you give this patch a try? > >[*] = http://marc.info/?l=linux-netdev&m=144416122705850&w=2 Agreed; my apologies for not Cc'ing you, Uwe. FWIW, the

Re: Keystone 2 boards boot failure

2016-02-03 Thread santosh shilimkar
On 2/3/2016 10:47 AM, Murali Karicheri wrote: On 02/03/2016 12:08 PM, santosh shilimkar wrote: On 2/3/2016 8:35 AM, Arnd Bergmann wrote: [..] It would be nice to give this a go once the network driver problem is solved. Big endian kernel has worked on Keystone in past. Yes, this was on a

[PATCH net-next] sxgbe: remove unused code

2016-02-03 Thread Jεan Sacren
From: Jean Sacren With the introduction of this commit 1edb9ca69e8a ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver"), the following interface was added: int sxgbe_xpcs_init(struct net_device *ndev); int sxgbe_xpcs_init_1G(struct net_device *ndev); But those t

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread Andrew Lunn
On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > compatibilities.") missed one compatible string used in in-tree DTBs: > in OCTEON, for selected boards, the kernel DTB pruning code will overwrite > the DTB compatible string

Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F_TSO6 for netvsc

2016-02-03 Thread Tom Herbert
On Wed, Feb 3, 2016 at 1:30 PM, Simon Xiao wrote: > 1. Adding NETIF_F_IPV6_CSUM and NETIF_F_TSO6 feature flags which are > supported by Hyper-V platform. NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated. Please change to use NETIF_F_HW_CSUM (calling helper functions if need). Thanks, T

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

2016-02-03 Thread Nikolay Aleksandrov
On 02/03/2016 08:48 PM, Jay Vosburgh wrote: > Nikolay Aleksandrov wrote: > >> On 02/03/2016 08:05 PM, Jay Vosburgh wrote: >>> Nikolay Aleksandrov wrote: >>> From: Nikolay Aleksandrov Currently the bonding allows to set ad_actor_system and prio while the bond device is down,

[PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F_TSO6 for netvsc

2016-02-03 Thread Simon Xiao
1. Adding NETIF_F_IPV6_CSUM and NETIF_F_TSO6 feature flags which are supported by Hyper-V platform. 2. Cleanup the coding style of flag assignment by using macro. Signed-off-by: Simon Xiao Reviewed-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 12 +++

Re: [PATCH v2 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-03 Thread Larry Finger
On 02/02/2016 08:16 PM, Byeoungwook Kim wrote: rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- V2 split in separate patchs. drivers/net/wir

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

2016-02-03 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: >On 02/03/2016 08:05 PM, Jay Vosburgh wrote: >> Nikolay Aleksandrov wrote: >> >>> From: Nikolay Aleksandrov >>> >>> Currently the bonding allows to set ad_actor_system and prio while the >>> bond device is down, but these are actually applied only if there aren't >>>

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-03 Thread Larry Finger
On 02/03/2016 11:49 AM, ByeoungWook Kim wrote: Hi David, 2016-02-03 23:41 GMT+09:00 David Laight : From: Byeoungwook Kim Sent: 03 February 2016 02:00 Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. ... void rtl_addr_delay(u32 addr)

[PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

2016-02-03 Thread Aaro Koskinen
Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.") missed one compatible string used in in-tree DTBs: in OCTEON, for selected boards, the kernel DTB pruning code will overwrite the DTB compatible string with "marvell,88e1145", which is missing from the whitelist. Add it.

Re: [PATCH net v2] bonding: Fix ARP monitor validation

2016-02-03 Thread Jarod Wilson
On Tue, Feb 02, 2016 at 01:35:56PM -0800, Jay Vosburgh wrote: > > The current logic in bond_arp_rcv will accept an incoming ARP for > validation if (a) the receiving slave is either "active" (which includes > the currently active slave, or the current ARP slave) or, (b) there is a > currentl

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-03 Thread Eric Dumazet
On Wed, 2016-02-03 at 19:17 +0100, Bendik Rønning Opstad wrote: > On Tue, Feb 2, 2016 at 9:35 PM, Eric Dumazet wrote: > > On Tue, 2016-02-02 at 20:23 +0100, Bendik Rønning Opstad wrote: > >> > >> o When packets are scheduled for transmission, RDB replaces the SKB to > >> be sent with a modif

Re: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread Eric Dumazet
On Wed, 2016-02-03 at 10:24 -0800, Alexander Duyck wrote: > If this is only meant to be a performance modification and is only > really targeted at TCP TSO/GRO then all I ask is that we use a name > like tcp_max_gso_frags and relocate the sysctl to the TCP section. > Otherwise if we are actually g

[PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-03 Thread Tom Herbert
Implement assembly routine for csum_partial for 64 bit x86. This primarily speeds up checksum calculation for smaller lengths such as those that are present when doing skb_postpull_rcsum when getting CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSARY conversion. CONFIG_HAVE_EFFICIENT_UNAL

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

2016-02-03 Thread Nikolay Aleksandrov
On 02/03/2016 08:05 PM, Jay Vosburgh wrote: > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> Currently the bonding allows to set ad_actor_system and prio while the >> bond device is down, but these are actually applied only if there aren't >> any slaves yet (applied to bond devi

Re: gigaset: memory leak in gigaset_initcshw

2016-02-03 Thread Paul Bolle
Hi Dmitry, On wo, 2016-02-03 at 17:16 +0100, Paul Bolle wrote: > The above should provide me with enough information to figure out > what's going on here. I've instrumented ser_gigaset with some printk's. Basically I added the stuff pasted at the end of this message. In 10.000 runs of the program

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

2016-02-03 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: >From: Nikolay Aleksandrov > >Currently the bonding allows to set ad_actor_system and prio while the >bond device is down, but these are actually applied only if there aren't >any slaves yet (applied to bond device when first slave shows up, and to >slaves at 3ad bind

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

2016-02-03 Thread Fastabend, John R
On 2/3/2016 4:46 AM, Jamal Hadi Salim wrote: [...] >>> >>> What are you doing w.r.t priorities? Are the filters processed by the >>> order of the priorities? >>> In the same order as software processes filters. I tried to faithfully translate the u32 classify and u32_change loops into hardw

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

2016-02-03 Thread Fastabend, John R
On 2/3/2016 4:21 AM, Jamal Hadi Salim wrote: > On 16-02-03 05:31 AM, Or Gerlitz wrote: >> On 2/3/2016 12:21 PM, John Fastabend wrote: >>> Thanks, we will need at least a v2 to fixup some build errors >>> with various compile flags caught by build_bot and missed by me. >> Hi John, >> >> You didn't m

Re: Keystone 2 boards boot failure

2016-02-03 Thread Murali Karicheri
On 02/03/2016 12:08 PM, santosh shilimkar wrote: > On 2/3/2016 8:35 AM, Arnd Bergmann wrote: >> On Tuesday 02 February 2016 19:19:13 Franklin S Cooper Jr. wrote: >>> On 02/02/2016 05:26 PM, Arnd Bergmann wrote: On Tuesday 02 February 2016 16:59:34 Franklin Cooper wrote: > On 02/02/2016 03:

Re: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread Alexander Duyck
On Wed, Feb 3, 2016 at 9:54 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 09:43 -0800, Alexander Duyck wrote: > >> Read the history. I still say it is best if we don't accept a partial >> solution. If we are going to introduce the sysctl as a core item it >> should function as a core item and

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-03 Thread Bendik Rønning Opstad
On Tue, Feb 2, 2016 at 9:35 PM, Eric Dumazet wrote: > On Tue, 2016-02-02 at 20:23 +0100, Bendik Rønning Opstad wrote: >> >> o When packets are scheduled for transmission, RDB replaces the SKB to >> be sent with a modified SKB containing the redundant data of >> previously sent data segme

[PATCH nf-next] netfilter: nf_defrag_ipv4: Drop redundant ip_send_check()

2016-02-03 Thread Joe Stringer
Since commit 0848f6428ba3 ("inet: frags: fix defragmented packet's IP header for af_packet"), ip_send_check() would be called twice for defragmentation that occurs from netfilter ipv4 defrag hooks. Remove the extra call. Signed-off-by: Joe Stringer --- net/ipv4/netfilter/nf_defrag_ipv4.c | 4 +--

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

2016-02-03 Thread Sowmini Varadhan
On (02/03/16 09:51), Tom Herbert wrote: > > (a) quite noisy > > Try disabling the crash dump. That will improve performance. huh?? there is no crash dump involved. If you meant "disable dump_stack()" sure, I am aware of that, and that is the default behavior of log_unaligned(). I was just tryi

Re: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread Eric Dumazet
On Wed, 2016-02-03 at 09:43 -0800, Alexander Duyck wrote: > Read the history. I still say it is best if we don't accept a partial > solution. If we are going to introduce the sysctl as a core item it > should function as a core item and not as something that belongs to > TCP only. But this pat

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

2016-02-03 Thread Tom Herbert
On Wed, Feb 3, 2016 at 9:31 AM, Sowmini Varadhan wrote: > On (02/03/16 09:07), Tom Herbert wrote: >> > Kernel unaligned access at TPC[9150dc] ipv4_neigh_lookup+0x38/0x170 >> >> Sowmini, >> >> This doesn't look like a hard crash to me. Instead of trying to fix >> all the alignment issues for Sparc,

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-03 Thread ByeoungWook Kim
Hi David, 2016-02-03 23:41 GMT+09:00 David Laight : > From: Byeoungwook Kim >> Sent: 03 February 2016 02:00 >> Conditional codes in rtl_addr_delay() were improved in readability and >> performance by using switch codes. >> ... >> void rtl_addr_delay(u32 addr) >> { >> - if (addr == 0xfe) >> +

[PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Jason A. Donenfeld
This patch simply adds support for specifying a "not_oif" device in flowi4 and flowi6 lookups, that will find a matching route that _isn't_ via the specified device. Signed-off-by: Jason A. Donenfeld --- include/net/flow.h | 3 +++ net/ipv4/fib_trie.c | 2 ++ net/ipv6/route.c| 6 +- 3 f

Re: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread Alexander Duyck
On Wed, Feb 3, 2016 at 8:07 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 07:58 -0800, Alexander Duyck wrote: >> > +++ b/net/core/sysctl_net_core.c >> >> I really don't think these changes belong in the core. Below you only >> modify the TCP code path so this more likely belongs in the TCP path

Re: [RFC] Inverse of flowi{4,6}_oif: flowi{4,6}_not_oif

2016-02-03 Thread Jason A. Donenfeld
On Wed, Feb 3, 2016 at 5:28 PM, David Ahern wrote: > > For IPv6 start with ip6_pol_route_lookup and modifying rt6_device_match > If that's all it takes, then that turns out to be ridiculously easy too. I'll get a patch together for this. --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -467,6 +4

RE: [PATCH v3] net:Add sysctl_max_skb_frags

2016-02-03 Thread David Laight
From: Herbert Xu > Sent: 03 February 2016 12:21 > On Wed, Feb 03, 2016 at 12:36:21PM +0100, Hannes Frederic Sowa wrote: > > > > Agreed that it feels like a hack, but a rather simple one. I would > > consider this to be just a performance improvement. We certainly need > > a slow-path when virtio dr

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

2016-02-03 Thread Sven Eckelmann
On Wednesday 03 February 2016 18:09:40 Sven Eckelmann wrote: > > AFAICT this should be a driver (or perhaps mac80211) issue, but I don't > > see any information about the driver used. > > It doesn't really look like it is batman-adv specific. batman-adv also doesn't > be active because the message

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

2016-02-03 Thread Sowmini Varadhan
On (02/03/16 09:07), Tom Herbert wrote: > > Kernel unaligned access at TPC[9150dc] ipv4_neigh_lookup+0x38/0x170 > > Sowmini, > > This doesn't look like a hard crash to me. Instead of trying to fix > all the alignment issues for Sparc, can we just take the trap, fix up > the load, and continue wit

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

2016-02-03 Thread Sven Eckelmann
On Wednesday 03 February 2016 16:41:30 Johannes Berg wrote: > On Wed, 2016-02-03 at 10:26 -0500, Josh Boyer wrote: > > On Wed, Feb 3, 2016 at 10:24 AM, Josh Boyer > g> wrote: > > > Hi All, > > > > > > We've had a user report the backtrace below when loading batman-adv > > > on > > > his machine.

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

2016-02-03 Thread Sven Eckelmann
On Wednesday 03 February 2016 10:24:43 Josh Boyer wrote: > Hi All, > > We've had a user report the backtrace below when loading batman-adv on > his machine. It looks like the cfg80211 layer is complaining about a > null bss returned, but I cannot tell if the rtlwifi driver or > batman-adv is in e

Re: Fw: [Bug 111771] New: deadlock in ppp/l2tp

2016-02-03 Thread Guillaume Nault
On Wed, Feb 03, 2016 at 11:04:31AM +1100, Stephen Hemminger wrote: > Please excuse URL mangling, my bugzilla address appears to route through > stupid corporate firewall. > > Begin forwarded message: > > Date: Tue, 2 Feb 2016 18:38:41 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To:

Re: Keystone 2 boards boot failure

2016-02-03 Thread santosh shilimkar
On 2/3/2016 8:35 AM, Arnd Bergmann wrote: On Tuesday 02 February 2016 19:19:13 Franklin S Cooper Jr. wrote: On 02/02/2016 05:26 PM, Arnd Bergmann wrote: On Tuesday 02 February 2016 16:59:34 Franklin Cooper wrote: On 02/02/2016 03:26 PM, Arnd Bergmann wrote: On Tuesday 02 February 2016 15:01:3

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

2016-02-03 Thread Tom Herbert
On Mon, Feb 1, 2016 at 4:31 PM, Sowmini Varadhan wrote: > On (01/31/16 13:37), Tom Herbert wrote: >> >> Call get_unaligned_be32 when we access 32-bit fields in >> __skb_flow_dissect. At the beginning check for unlikely case of >> 1-byte aligned packet. >> >> Note that flow_dissector may be asked t

RE: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets

2016-02-03 Thread David Laight
From: Paul Burton > Sent: 03 February 2016 12:03 > Resets of the EG20T MAC on the MIPS Boston development board take longer > than the 1000 loops that pch_gbe_wait_clr_bit was performing. Bump up > the number of loops. ... > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > b/dri

Re: Keystone 2 boards boot failure

2016-02-03 Thread Murali Karicheri
On 02/03/2016 11:31 AM, Grygorii Strashko wrote: > On 02/03/2016 06:20 PM, Arnd Bergmann wrote: >> On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >>> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: >> > So only

RE: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

2016-02-03 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, February 3, 2016 11:06 AM > To: Haiyang Zhang > Cc: da...@davemloft.net; netdev@vger.kernel.org; KY Srinivasan > ; o...@aepfle.de; linux-ker...@vger.kernel.org; > driverdev-de...@linuxdriverproj

Re: Keystone 2 boards boot failure

2016-02-03 Thread Murali Karicheri
On 02/03/2016 11:20 AM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: > So only making this change on the latest master with no oth

Re: Keystone 2 boards boot failure

2016-02-03 Thread Arnd Bergmann
On Tuesday 02 February 2016 19:19:13 Franklin S Cooper Jr. wrote: > On 02/02/2016 05:26 PM, Arnd Bergmann wrote: > > On Tuesday 02 February 2016 16:59:34 Franklin Cooper wrote: > >> On 02/02/2016 03:26 PM, Arnd Bergmann wrote: > >>> On Tuesday 02 February 2016 15:01:33 Franklin S Cooper Jr. wrote:

Re: [PATCH net-next 4/4] packet: tpacket_snd gso and checksum offload

2016-02-03 Thread Willem de Bruijn
> union tpacket_uhdr ph; On Tue, Feb 2, 2016 at 10:56 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Support socket option PACKET_VNET_HDR together with PACKET_TX_RING. >> > Signed-off-by: Willem de Bruijn > --- > net/packet/af_packet.c | 53 >

Re: Keystone 2 boards boot failure

2016-02-03 Thread Grygorii Strashko
On 02/03/2016 06:20 PM, Arnd Bergmann wrote: On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: So only making this change on the latest master with no other changes I see t

Re: [RFC] Inverse of flowi{4,6}_oif: flowi{4,6}_not_oif

2016-02-03 Thread David Ahern
On 2/3/16 7:27 AM, Jason A. Donenfeld wrote: FYI, for v4 at least, it's ridiculously easy and simple to implement: =~=~=~=~=~=~=~=~= diff --git a/include/net/flow.h b/include/net/flow.h index 83969ee..29967ad 100644 --- a/include/net/flow.h +++ b/include/net/flow.h @@ -26,6 +26,7 @@ struct flow

  1   2   3   >